Re: [E-devel] E SVN: mekius IN trunk/PROTO/emote: . src/bin src/lib src/lib/protocols/irc
On Sat, 7 Jul 2012 19:22:28 -0500 Nick Hughart mek...@mekius.net wrote: On Sat, 7 Jul 2012 21:41:48 +0100 Michael Blumenkrantz michael.blumenkra...@gmail.com wrote: On Sat, 7 Jul 2012 15:31:23 -0500 Nick Hughart mek...@mekius.net wrote: On Sat, 7 Jul 2012 20:27:16 +0100 Michael Blumenkrantz michael.blumenkra...@gmail.com wrote: On Sat, 7 Jul 2012 12:10:51 -0700 Enlightenment SVN no-re...@enlightenment.org wrote: Log: Multiple improvements and some cleanup: * Switch channel/server text to use Evas textgrid instead of elm_entry. This is of course missing a lot of nice things like scrolling, selection, colors, etc. This is in the TODO. * Redesign the interface a bit. Still not looking great, but this is probably the next thing to work on. It's on the TODO. * IRC code no longer converts the utf8 to markup. It just passes it directly to the frontend. The frontend also must convert any text with markup to utf8 before sending to the library. * Removed some random printfs. Incorporating Eina log is in the TODO. * Updated TODO to reflect the current state of things. There is a lot to do so any help would be appreciated. Particularly I'd love some feedback on how bad the code is and ways it can be improved. I didn't check this code for memory leaks as it's not really in a daily usable state yet. Author: mekius Date: 2012-07-07 12:10:51 -0700 (Sat, 07 Jul 2012) New Revision: 73456 Trac: http://trac.enlightenment.org/e/changeset/73456 Modified: trunk/PROTO/emote/TODO trunk/PROTO/emote/src/bin/em_config.c trunk/PROTO/emote/src/bin/em_gui.c trunk/PROTO/emote/src/bin/em_gui.h trunk/PROTO/emote/src/bin/main.c trunk/PROTO/emote/src/lib/emote_event.c trunk/PROTO/emote/src/lib/emote_protocol.c trunk/PROTO/emote/src/lib/protocols/irc/irc.c trunk/PROTO/emote/src/lib/protocols/irc/irc_parse.c * any reason you're not using eina_module ? IIRC this code predated eina_module or we had reasons for not using it at the time. It's been awhile so I cannot recall. The actual exported functions for each protocol are fairly small as most of the interface is implemented using ecore events. imo you didn't use it because a certain someone working on it at the time hates eina for dubious reasons ;) Well at the time I can't say I was a big fan either, but it is what it is and that's the past. Regardless, at the time we had other reasons and it's not really important now as the interface is done and working. Given everything is done via events there isn't much chance the external API for the protocol plugins will change. * I see a lot of calls to ecore_con_server_connected_get(); in general, any time you have to call this function you're probably doing something wrong I think this was just a safeguard to ensure the connection was still open. Is there a callback that should be used instead when the connection is lost? ECORE_CON_EVENT_SERVER_DEL occurs whenever a connection is lost for any reason Btw, why does ecore_con_server_connected_get do anything more than check a flag? My thought here is that we'd still have to check a flag, it would just be locally stored and modified. it doesn't do anything more than that, the point is more if you have to check, you don't already know the connection state, and you should always know it. -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: illogict IN trunk/e: po src/modules/conf_theme
On Sun, 8 Jul 2012 10:43:18 -0700 Enlightenment SVN no-re...@enlightenment.org wrote: Log: e theme: merge application and icon themes. Author: illogict Date: 2012-07-08 10:43:17 -0700 (Sun, 08 Jul 2012) New Revision: 73475 Trac: http://trac.enlightenment.org/e/changeset/73475 Removed: trunk/e/src/modules/conf_theme/e_int_config_icon_themes.c trunk/e/src/modules/conf_theme/e_int_config_icon_themes.h Modified: trunk/e/po/POTFILES.in trunk/e/src/modules/conf_theme/Makefile.am trunk/e/src/modules/conf_theme/e_int_config_xsettings.c trunk/e/src/modules/conf_theme/e_mod_main.c trunk/e/src/modules/conf_theme/e_mod_main.h doing a hero's work imo -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [PATCH] edje: Update tween image documentation
Trying to make the description more explicit --- edje/src/bin/edje_cc_handlers.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/edje/src/bin/edje_cc_handlers.c b/edje/src/bin/edje_cc_handlers.c index b5e9bcc..c200c76 100644 --- a/edje/src/bin/edje_cc_handlers.c +++ b/edje/src/bin/edje_cc_handlers.c @@ -5348,7 +5348,8 @@ st_collections_group_parts_part_description_image_normal(void) @effect Name of an image to be used in an animation loop, an image block can have none, one or multiple tween declarations. Images are displayed in -the order they are listed. +the order they are listed, during the transition to the state they are +declared in; the normal image is the final state. @endproperty */ static void -- 1.7.10.4 -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] edje: Update tween image documentation
Thanks! In SVN! Daniel Juyung Seo (SeoZ) On Mon, Jul 9, 2012 at 7:09 AM, Anisse Astier ani...@astier.eu wrote: Trying to make the description more explicit --- edje/src/bin/edje_cc_handlers.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/edje/src/bin/edje_cc_handlers.c b/edje/src/bin/edje_cc_handlers.c index b5e9bcc..c200c76 100644 --- a/edje/src/bin/edje_cc_handlers.c +++ b/edje/src/bin/edje_cc_handlers.c @@ -5348,7 +5348,8 @@ st_collections_group_parts_part_description_image_normal(void) @effect Name of an image to be used in an animation loop, an image block can have none, one or multiple tween declarations. Images are displayed in -the order they are listed. +the order they are listed, during the transition to the state they are +declared in; the normal image is the final state. @endproperty */ static void -- 1.7.10.4 -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: tasn trunk/clouseau
hahaha CEDRIC! Daniel Juyung Seo (SeoZ) On Sun, Jul 8, 2012 at 5:24 PM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: Clouseau: Fixed configure.ac. Cedric, Thanks for your wonderful birthday gift to us all. ;) Author: tasn Date: 2012-07-08 01:24:13 -0700 (Sun, 08 Jul 2012) New Revision: 73461 Trac: http://trac.enlightenment.org/e/changeset/73461 Modified: trunk/clouseau/configure.ac Modified: trunk/clouseau/configure.ac === --- trunk/clouseau/configure.ac 2012-07-08 08:12:38 UTC (rev 73460) +++ trunk/clouseau/configure.ac 2012-07-08 08:24:13 UTC (rev 73461) @@ -57,7 +57,6 @@ ecore = 1.0.0 ecore-ipc = 1.0.0 edje = 1.0.0 - ]) ] ) -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-svn mailing list enlightenment-...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-svn -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [PATCH][Terminology] Use Xresource background color
Hey guys,
find attached a patch for terminology based on r73450 making it use
the xresource background color if available and enabled in
Terminology's settings.
What can be improved:
- Add xrdb abstraction to ecore_x (depends on Xlib right now)
- Make clicking the radio button immediately trigger
disabling/enabling the background color (needs restart atm)
So, as you can see, it's not good enough for upstream yet.
For those who don't like the shadow: Simple use the mild theme
provided with Terminology ('-t=mild' switch)
--
Leif
terminology_xres.diff
Description: Binary data
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH][Terminology] Use Xresource background color
On Sun, Jul 8, 2012 at 10:37 PM, Leif Middelschulte
leif.middelschu...@gmail.com wrote:
Hey guys,
find attached a patch for terminology based on r73450 making it use
the xresource background color if available and enabled in
Terminology's settings.
What can be improved:
- Add xrdb abstraction to ecore_x (depends on Xlib right now)
- Make clicking the radio button immediately trigger
disabling/enabling the background color (needs restart atm)
So, as you can see, it's not good enough for upstream yet.
For those who don't like the shadow: Simple use the mild theme
provided with Terminology ('-t=mild' switch)
I didn't look at the patch, but I'd say: keep away from Xresources...
it's ugly, legacy and confusing if you already have simple in-app
configuration.
it's just simpler to add the color selection inside terminology. We
even have a colorselector widget, it's almost zero-effort.
--
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH][Terminology] Use Xresource background color
2012/7/9 Gustavo Sverzut Barbieri barbi...@profusion.mobi:
On Sun, Jul 8, 2012 at 10:37 PM, Leif Middelschulte
leif.middelschu...@gmail.com wrote:
Hey guys,
find attached a patch for terminology based on r73450 making it use
the xresource background color if available and enabled in
Terminology's settings.
What can be improved:
- Add xrdb abstraction to ecore_x (depends on Xlib right now)
- Make clicking the radio button immediately trigger
disabling/enabling the background color (needs restart atm)
So, as you can see, it's not good enough for upstream yet.
For those who don't like the shadow: Simple use the mild theme
provided with Terminology ('-t=mild' switch)
I didn't look at the patch, but I'd say: keep away from Xresources...
it's ugly, legacy and confusing if you already have simple in-app
configuration.
Probably true in most cases. But sometimes people just use some
.Xresources file they found on the web for e.g. nice `ls` colors, etc.
it's just simpler to add the color selection inside terminology. We
even have a colorselector widget, it's almost zero-effort.
You're probably right. That's the reason I didn't invest more work.
Actually just thought this patch might be usable for other people too
and doesn't necessarily have to be improved. It can stay in people's
local repositories if it's useful for them. Just wanted to share it.
--
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Leif
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH][Terminology] Use Xresource background color
On Mon, 9 Jul 2012 03:56:03 +0200
Leif Middelschulte leif.middelschu...@gmail.com wrote:
Based on conversations in IRC, Raster has already expressed that
support for Xresources is an unnecessary evil for Terminology. He made
it clear that support for it would not be going into Terminology nor
Ecore. If distributions want to patch this in, they can go ahead, but
it's probably not making it upstream.
2012/7/9 Gustavo Sverzut Barbieri barbi...@profusion.mobi:
On Sun, Jul 8, 2012 at 10:37 PM, Leif Middelschulte
leif.middelschu...@gmail.com wrote:
Hey guys,
find attached a patch for terminology based on r73450 making it use
the xresource background color if available and enabled in
Terminology's settings.
What can be improved:
- Add xrdb abstraction to ecore_x (depends on Xlib right now)
- Make clicking the radio button immediately trigger
disabling/enabling the background color (needs restart atm)
So, as you can see, it's not good enough for upstream yet.
For those who don't like the shadow: Simple use the mild theme
provided with Terminology ('-t=mild' switch)
I didn't look at the patch, but I'd say: keep away from
Xresources... it's ugly, legacy and confusing if you already have
simple in-app configuration.
Probably true in most cases. But sometimes people just use some
.Xresources file they found on the web for e.g. nice `ls` colors, etc.
it's just simpler to add the color selection inside terminology. We
even have a colorselector widget, it's almost zero-effort.
You're probably right. That's the reason I didn't invest more work.
Actually just thought this patch might be usable for other people too
and doesn't necessarily have to be improved. It can stay in people's
local repositories if it's useful for them. Just wanted to share it.
--
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond.
Discussions will include endpoint security, mobile security and the
latest in malware threats.
http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___ enlightenment-devel
mailing list enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH][Terminology] Use Xresource background color
On Sun, 8 Jul 2012 21:10:50 -0500 Nick Hughart mek...@mekius.net said:
On Mon, 9 Jul 2012 03:56:03 +0200
Leif Middelschulte leif.middelschu...@gmail.com wrote:
Based on conversations in IRC, Raster has already expressed that
support for Xresources is an unnecessary evil for Terminology. He made
it clear that support for it would not be going into Terminology nor
Ecore. If distributions want to patch this in, they can go ahead, but
it's probably not making it upstream.
yup. reject.
1. you hurt terminology's wonderful display independence. it works in
framebuffer and in wayland. it probably should work on osx and windows too as
long as the libc bits are supported (pty opening and ioctl's).
2. xresources/defaults is ugly and almost no one uses it anymore. it's a
leftover for a lot of old school terminal emulators because most of these
were written in xlib/xt days where this was normal.
3. since we need color customisation anyway we will have to duplicate this
functionality then in another way for it to work outside of x11, so it just
discourages that work to be done.
4. xrdb handling is fought leaks. you open the xrm db and never close it. yay!
leak. now if u try and close/delete it.. segv! hooray!. this does not make me a
happy bunny.
2012/7/9 Gustavo Sverzut Barbieri barbi...@profusion.mobi:
On Sun, Jul 8, 2012 at 10:37 PM, Leif Middelschulte
leif.middelschu...@gmail.com wrote:
Hey guys,
find attached a patch for terminology based on r73450 making it use
the xresource background color if available and enabled in
Terminology's settings.
What can be improved:
- Add xrdb abstraction to ecore_x (depends on Xlib right now)
- Make clicking the radio button immediately trigger
disabling/enabling the background color (needs restart atm)
So, as you can see, it's not good enough for upstream yet.
For those who don't like the shadow: Simple use the mild theme
provided with Terminology ('-t=mild' switch)
I didn't look at the patch, but I'd say: keep away from
Xresources... it's ugly, legacy and confusing if you already have
simple in-app configuration.
Probably true in most cases. But sometimes people just use some
.Xresources file they found on the web for e.g. nice `ls` colors, etc.
it's just simpler to add the color selection inside terminology. We
even have a colorselector widget, it's almost zero-effort.
You're probably right. That's the reason I didn't invest more work.
Actually just thought this patch might be usable for other people too
and doesn't necessarily have to be improved. It can stay in people's
local repositories if it's useful for them. Just wanted to share it.
--
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond.
Discussions will include endpoint security, mobile security and the
latest in malware threats.
http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___ enlightenment-devel
mailing list enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
- Codito, ergo sum - I code, therefore I am --
The Rasterman (Carsten Haitzler)ras...@rasterman.com
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] E17 Korea meeting, round 2
Because E17 is finally released^Walmost there and we're having an outrageous nice weather in Korea, some people like to have another meeting in Korea. It should be a good opportunity to drink bugs and fix beers or the contrary, I don't remember. Anyway, I have time to annoy you all the weekend. What about saturday? -- Jérôme Pinot http://ngc891.blogdns.net/ signature.asc Description: Digital signature -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
