Re: [E-devel] Static analyzers Sonar/SonarCloud vs Coverity
Here is one both Coverity and Sonar miss, also clangs scan-build. Likely something valgrind would catch/show. This is never free'd, not anywhere I can tell. Though I could be wrong. _login = strdup(login); https://github.com/Obsidian-StudiosInc/entrance/blob/master/src/daemon/entrance_session.c#L335 Even in orig https://git.enlightenment.org/misc/entrance.git/tree/src/daemon/entrance_session.c#n301 I added another strdup to fix an issue. https://github.com/Obsidian-StudiosInc/entrance/blob/master/src/daemon/entrance_session.c#L404 Sonar did not pick that up, nor clang's scan-build. No longer using Coverity, but seems it would not catch it either as it did not before. Just goes to show one can only rely on the scanners so much. They fail even on valid detection of some things. -- William L. Thomson Jr. pgpzMwdQj_qdl.pgp Description: OpenPGP digital signature -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/enlightenment] master 01/01: compile against stable EFL again
The entire Wayland implementation in Enlightenment is based on
unstable/beta API.
Many patches such as this one have gone in over the years in order to
preserve compatibility across different versions of EFL, and this will
continue to be a normal development process so long as the only entry
points for necessary functionality remain unstable.
On Thu, Apr 26, 2018 at 1:34 AM Carsten Haitzler
wrote:
> On Wed, 25 Apr 2018 09:12:19 -0700 Derek Foreman
> said:
>
> well tbh - this is going to break in theory against nigh on any version of
> efl
> because "eo interfaces are unstable". this shouldn't be in e in the first
> place
> unless the intent is to delay any e release until interfaces are stable...
> or
> many more ifdefs or dlsyms will there have to be here to make it work (and
> then
> if efl upgrades and the e binary doesn't it may not have support for a
> newer
> name and will be broken anyway)?
>
> > derekf pushed a commit to branch master.
> >
> >
> http://git.enlightenment.org/core/enlightenment.git/commit/?id=3e196c1c61cc5d5bfdb8f19a7b88427bfb2c7d33
> >
> > commit 3e196c1c61cc5d5bfdb8f19a7b88427bfb2c7d33
> > Author: Derek Foreman
> > Date: Wed Apr 25 11:06:12 2018 -0500
> >
> > compile against stable EFL again
> >
> > E should probably continue to build against released EFL older than
> > the current interface name changes.
> > ---
> > src/modules/wl_drm/e_mod_main.c | 15 +++
> > 1 file changed, 11 insertions(+), 4 deletions(-)
> >
> > diff --git a/src/modules/wl_drm/e_mod_main.c
> b/src/modules/wl_drm/e_mod_main.c
> > index 68d6593f9..d51293c1d 100644
> > --- a/src/modules/wl_drm/e_mod_main.c
> > +++ b/src/modules/wl_drm/e_mod_main.c
> > @@ -779,14 +779,13 @@ _drm_device_del(void *data EINA_UNUSED, const
> Efl_Event
> > *event) ecore_evas_cursor_device_unset(e_comp->ee, event->info);
> > }
> >
> > -EFL_CALLBACKS_ARRAY_DEFINE(_drm_device_del_cb,
> > - { EFL_CANVAS_SCENE_EVENT_DEVICE_REMOVED,
> > _drm_device_del }); -
> > E_API void *
> > e_modapi_init(E_Module *m)
> > {
> > int w = 0, h = 0;
> >
> > + static Efl_Callback_Array_Item arr[2] = { { 0, _drm_device_del } };
> > +
> > printf("LOAD WL_DRM MODULE\n");
> >
> > /* try to init ecore_drm */
> > @@ -832,6 +831,14 @@ e_modapi_init(E_Module *m)
> > ecore_evas_screen_geometry_get(e_comp->ee, NULL, NULL, &w, &h);
> > if (!e_comp_canvas_init(w, h)) return NULL;
> >
> > +#ifdef EFL_VERSION_1_21
> > + arr[0].desc = EFL_CANVAS_SCENE_EVENT_DEVICE_REMOVED;
> > +#else
> > + if (E_EFL_VERSION_MINIMUM(1, 20, 99))
> > + arr[0].desc = dlsym(NULL,
> "_EFL_CANVAS_SCENE_EVENT_DEVICE_REMOVED");
> > + if (!arr[0].desc)
> > + arr[0].desc = dlsym(NULL, "_EFL_CANVAS_EVENT_DEVICE_REMOVED");
> > +#endif
> > ecore_evas_pointer_xy_get(e_comp->ee, &e_comp_wl->ptr.x,
> > &e_comp_wl->ptr.y);
> > evas_event_feed_mouse_in(e_comp->evas, 0, NULL);
> > @@ -855,7 +862,7 @@ e_modapi_init(E_Module *m)
> > ecore_event_handler_add(ELPUT_EVENT_POINTER_MOTION,
> > (Ecore_Event_Handler_Cb)_pointer_motion,
> NULL);
> >
> > - efl_event_callback_array_priority_add(e_comp->evas,
> _drm_device_del_cb(),
> > + efl_event_callback_array_priority_add(e_comp->evas, arr,
> > EFL_CALLBACK_PRIORITY_BEFORE,
> NULL);
> >
> > return m;
> >
> > --
> >
> >
>
>
> --
> - Codito, ergo sum - "I code, therefore I am" --
> Carsten Haitzler - ras...@rasterman.com
>
>
>
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 01/01: efl theme: remove the elm legacy name of efl ui theme
Hello. On 04/26/2018 12:41 PM, Taehyub Kim wrote: > jaehyun pushed a commit to branch master. > > http://git.enlightenment.org/core/efl.git/commit/?id=6e49db0739c38a378c48c6c880f5b41c986ee1e9 > > commit 6e49db0739c38a378c48c6c880f5b41c986ee1e9 > Author: Taehyub Kim > Date: Thu Apr 26 19:27:43 2018 +0900 > > efl theme: remove the elm legacy name of efl ui theme > > Summary: remove the elm legacy name of efl ui theme > > Test Plan: run elementary_test and test efl ui widget cases > > Reviewers: Jaehyun_Cho, woohyun, cedric, raster, jpeg > > Reviewed By: Jaehyun_Cho > > Differential Revision: https://phab.enlightenment.org/D5934 > --- This patch breaks the wayland build: CC lib/elementary/lib_elementary_libelementary_la-els_tooltip.lo lib/elementary/efl_ui_win.c: In function '_elm_win_wl_cursor_set': lib/elementary/efl_ui_win.c:3147:11: error: expected ')' before 'edje_object_part_geometry_get' edje_object_part_geometry_get(sd->pointer.obj, ^ lib/elementary/efl_ui_win.c:3159:6: error: expected expression before '}' token } ^ lib/elementary/efl_ui_win.c:3122:44: warning: unused variable 'hy' [-Wunused-variable] Evas_Coord mw = 1, mh = 1, hx = 0, hy = 0; ^~ lib/elementary/efl_ui_win.c:3122:36: warning: unused variable 'hx' [-Wunused-variable] Evas_Coord mw = 1, mh = 1, hx = 0, hy = 0; ^~ CC lib/elementary/lib_elementary_libelementary_la-elu_ews_wm.lo make[4]: *** [Makefile:37132: lib/elementary/lib_elementary_libelementary_la-efl_ui_win.lo] Error 1 make[4]: *** Waiting for unfinished jobs make[3]: *** [Makefile:54645: all-recursive] Error 1 make[2]: *** [Makefile:18309: all] Error 2 make[1]: *** [Makefile:3012: all-recursive] Error 1 make: *** [Makefile:2099: all] Error 2 Full log: https://travis-ci.org/Enlightenment/efl/jobs/371500073 -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] does anyone use --enable-g-main-loop
so we have integration for glib/main loop in regular efl which allows glib stuff to work with efl, but --enable-g-main-loop basically puts the efl ecore loop on top of the glib main loop. is anyone actually using this? is the regular glib loop integration not enough? -- - Codito, ergo sum - "I code, therefore I am" -- Carsten Haitzler - ras...@rasterman.com -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
