Re: [E-devel] does anyone use --enable-g-main-loop
On Tue, 01 May 2018 13:29:27 -0400 Cedric Bailsaid: > On April 30, 2018 8:28 PM, Carsten Haitzler wrote: > > On Mon, 30 Apr 2018 11:35:53 + Mike Blumenkrantz > > michael.blumenkra...@gmail.com said: > > > Regardless of this usage, however, I'm still not sure it's a good idea to > > > be dropping support for this type of integration just because a recent > > > refactor has broken it. Dropping support should probably be done over the > > > period of a couple releases, with deprecation in between, to ensure there > > > is no confusion and that there really are no users who will step in to > > > maintain this feature. > > > > Just FYI, we haven't done that before e.g. dropping PS3 support. The general > > question of "is anyone using this" was floated etc. etc. much like this > > thread. > > The PS3 state of things was different. I did contact the author of the > support and did an enquiry about the state of the community usage of that > support and he said to me clearly that their was no user of modern EFL with > it anymore. Their wasn't even a remote chance anyone was using it. it's similar - i checked the tizen repos and .spec files... the only use case i could imagine for it. i'm looking for other cases though. -- - Codito, ergo sum - "I code, therefore I am" -- Carsten Haitzler - ras...@rasterman.com -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] T6913 efl-1.20.7 does not build due to include file missing
Per this ticket https://phab.enlightenment.org/T6913 I have never had that issue on missing file. I think it maybe related to options enabled/disabled at build time. The reporter is using my Gentoo ebuild from my overlay. I have used it for sometime and I would quickly report such issue as I have in the past. Thus I assume its some option I do not have enabled. It comes from here, where I commented as such. They were trying to test out my EFL elogind patches, but that has nothing to do with this issue. https://github.com/Obsidian-StudiosInc/entrance/issues/15#issuecomment-386358779 Cannot comment on phab, thus the above. So others do not waste time on such. Seems it maybe related to them having pulseaudio disabled and maybe gstreamer enabled. To replicate the missing header likely require replicating the configure options. Some abnormal combo which causes such. Maybe need something to require one if the other is enabled/disabled, some conditional. Which I will do in my ebuild/package. Maybe needs modification to build system to make it safe for others. Like the opengles stuff and wayland, some things cannot be used together now and some options require others set. -- William L. Thomson Jr. pgpA4TYchEj6r.pgp Description: OpenPGP digital signature -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 49/66: eina: make eina_value_pget on an EINA_VALUE_TYPE_STRINGSHARE return a new reference to a stringshare.
yes I do think we shouldn't ref, let the user do, as/when needed. so it's consistent across the board, like when you get a string (not share), you should strdup() it yourself On Wed, May 2, 2018 at 3:19 PM, Cedric Bailwrote: > Yeah, I got to wonder about this one too. There was code expecting to own a > reference when manipulating STRINGSHARE. The alternative was maybe to do the > ref on the other side. The only other case where a get like that could > potentially return a ref is EINA_VALUE_TYPE_OBJECT, but we don't do it there. > If you think it is best to not ref, I will fix this the other way around. > > On May 2, 2018 7:33 AM, Gustavo Sverzut Barbieri wrote: >> this doesn't look right, we don't ref in other cases... >> >> On Tue, May 1, 2018 at 2:40 PM, Cedric BAIL cedric.b...@free.fr wrote: >> > cedric pushed a commit to branch master. >> > >> > http://git.enlightenment.org/core/efl.git/commit/?id=b1883c7989355e95cd4c826d3c7ecdbbbd257d77 >> > >> > commit b1883c7989355e95cd4c826d3c7ecdbbbd257d77 >> > Author: Cedric BAIL ced...@osg.samsung.com >> > Date: Fri Apr 27 16:19:42 2018 -0700 >> > >> > eina: make eina_value_pget on an EINA_VALUE_TYPE_STRINGSHARE return a >> > new reference to a stringshare. >> > --- >> > src/lib/eina/eina_value.c | 12 +++- >> > 1 file changed, 11 insertions(+), 1 deletion(-) >> > >> > diff --git a/src/lib/eina/eina_value.c b/src/lib/eina/eina_value.c >> > index cb5fbc11c4..ddb02af48d 100644 >> > --- a/src/lib/eina/eina_value.c >> > +++ b/src/lib/eina/eina_value.c >> > @@ -2225,6 +2225,16 @@ _eina_value_type_stringshare_pset(const >> > Eina_Value_Type *type EINA_UNUSED, void >> > } >> > >> > static Eina_Bool >> > +_eina_value_type_stringshare_pget(const Eina_Value_Type *type >> > EINA_UNUSED, const void *mem, void *ptr) >> > +{ >> > + const Eina_Stringshare * const *src = mem; >> > + Eina_Stringshare **dst = ptr; >> > + >> > + *dst = eina_stringshare_ref(*src); >> > + return EINA_TRUE; >> > +} >> > + >> > +static Eina_Bool >> > _eina_value_type_string_flush(const Eina_Value_Type *type EINA_UNUSED, >> > void *mem) >> > { >> > char *tmem = mem; >> >@@ -5197,7 +5207,7 @@ static const Eina_Value_Type >> >_EINA_VALUE_TYPE_BASICS[] = { >> > NULL, / no convert from */ >> > _eina_value_type_stringshare_vset, >> > _eina_value_type_stringshare_pset, >> > - _eina_value_type_string_common_pget >> > + _eina_value_type_stringshare_pget >> > }, >> > { >> > EINA_VALUE_TYPE_VERSION, > > > -- > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Gustavo Sverzut Barbieri -- Mobile: +55 (16) 99354-9890 -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Heads up on upcoming 1.21 stabilization phase
I found one ABI break issue on elm object item cursor by applying efl ui interface. https://phab.enlightenment.org/D6046 there must be nicer solution then my patch, but I don't want massive fixes would make it unstable. please fallows upon issue also before release. 2018년 5월 3일 (목) 오전 10:30, William L. Thomson Jr. < wlt...@obsidian-studios.com>님이 작성: > On Wed, 02 May 2018 16:38:07 + > Stephen Houstonwrote: > > > Raster this is more of a question for you. You know my thoughts on > > theme being a pressing issue. Is this something we as the community > > can band together during stabilization and have flat ready to go for > > 1.21 or is this something that we will have to put off yet again for > > a later release? > > > > My thoughts are that introducing the flat theme could be the > > headlining pop that this 1.21 release needs... i.e. a selling point > > for the release to be more attractive to users other than just being > > mostly a big fix release with just a preview of the interfaces work. > > +1 > > I think there also needs to be some UI to control spacing, colors, etc. > One other thing that would be nice I may have to help code is to be > able to swap position of top window elements, move close, minimize, > maximize, from right to left. > > That is one nice aspect I liked of KDE/Plasma/Kwin. I stopped using > custom themes and just went with modified default via their theme > customization UIs. Allowed me to set the colors I liked, swap location > of title bar elements, etc. Making something along those lines for E. > > That maybe something more for 1.22 than 1.21. With 1.21 having the new > flat theme, and 1.22 having the UI for user styling etc. > > -- > William L. Thomson Jr. > > -- > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 02/04: Revert "edje_cc: fix default color_class colors"
Hello Cedric. On 05/02/2018 07:46 PM, Cedric BAIL wrote: > cedric pushed a commit to branch master. > > http://git.enlightenment.org/core/efl.git/commit/?id=9c23ffb675316d982d3b9442cb771f31dc1cc0ed > > commit 9c23ffb675316d982d3b9442cb771f31dc1cc0ed > Author: Cedric Bail> Date: Wed May 2 09:35:57 2018 -0700 > > Revert "edje_cc: fix default color_class colors" > > This reverts commit d83ebb69808abdd067aa88dfeb7cd5a8216a9d90. > > Had to revert this as it break backward compatibility with what theme > expect to be the default value. We could reintroduce this with a version > check if necessary. > > T6885 Did you made Andrii aware of this revert?I think this is something we should aim for. Making the original author aware will give her/him a chance to come up with a better solution instead of having to spent time to find out why its broken again. I think the revert is fine in this case. Not picking on you, it was just the first revert I saw after thinking on this a bit more. regards Stefan Schmidt -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel