Re: [E-devel] 1.23 delay for two days
Hello. [Grumpy mail ahead] On 23.09.19 12:06, Stefan Schmidt wrote: Hello. The schedule we planned would have the 1.23 final release today. This will not happen as we have some ongoing things being handled right now that need a delay. The biggest item is the theme API review going on. We hope that we are in the position to release on Wednesday. You can help by looking at the work list I posted and especially the show stopper issues still marked open. We are definitely not in a position that we can release today. :( There have been so many changes coming in the last days it feels like the floodgates have been opened after the freeze and not like the last days before a release! I am seriously grumpy right now. I understand that many of these things have been worked on for a long time and the target was always this release. I also have been communicated most of these things and people have been working hard to get it working, so please do not take this to personal. Still, how are we supposed to release all this just a second after it has landed? This last minute rush of changes is really not how a release could work. I hope Mike will get out theme stuff under control and the big evas leak get fixed quickly. I will do a beta3 today and cross my finger when looking at it again on Friday. regards Stefan Schmidt ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [core/efl] master 01/01: efl_ui : reverse the select method name to be ended verb on the last.
sanghyeonlee pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=2c4db3b09a06815783acc3d6946f94c2d3203d4d
commit 2c4db3b09a06815783acc3d6946f94c2d3203d4d
Author: SangHyeon Jade Lee
Date: Wed Sep 25 16:39:30 2019 +0900
efl_ui : reverse the select method name to be ended verb on the last.
Summary:
our new method naming rule only allow verb at the last position,
so change name to fallow rule.
Reviewers: bu5hm4n, cedric, segfaultxavi
Reviewed By: bu5hm4n, segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10144
---
src/bin/elementary/test_ui_collection.c| 12 +++
src/lib/elementary/efl_ui_collection.c | 8 ++---
src/lib/elementary/efl_ui_collection.eo| 8 ++---
src/lib/elementary/efl_ui_multi_selectable.eo | 8 ++---
.../elementary/efl_ui_multi_selectable_async.eo| 8 ++---
src/lib/elementary/efl_ui_select_model.c | 14
src/lib/elementary/efl_ui_select_model.eo | 8 ++---
.../elementary/spec/efl_test_multi_selectable.c| 40 +++---
8 files changed, 53 insertions(+), 53 deletions(-)
diff --git a/src/bin/elementary/test_ui_collection.c
b/src/bin/elementary/test_ui_collection.c
index ed98d2e377..f407a6988a 100644
--- a/src/bin/elementary/test_ui_collection.c
+++ b/src/bin/elementary/test_ui_collection.c
@@ -5,15 +5,15 @@
#include
static void
-_select_all(void *data, const Efl_Event *ev EINA_UNUSED)
+_all_select(void *data, const Efl_Event *ev EINA_UNUSED)
{
- efl_ui_select_all(data);
+ efl_ui_all_select(data);
}
static void
-_unselect_all(void *data, const Efl_Event *ev EINA_UNUSED)
+_all_unselect(void *data, const Efl_Event *ev EINA_UNUSED)
{
- efl_ui_unselect_all(data);
+ efl_ui_all_unselect(data);
}
static void
@@ -284,14 +284,14 @@ void create_item_container_ui(const Efl_Class
*collection_class, const Efl_Class
efl_gfx_hint_weight_set(efl_added, 0.0, 0.0),
efl_gfx_hint_align_set(efl_added, 0, 0.5));
efl_text_set(o, "Select All");
- efl_event_callback_add(o, EFL_INPUT_EVENT_CLICKED, _select_all,
item_container);
+ efl_event_callback_add(o, EFL_INPUT_EVENT_CLICKED, _all_select,
item_container);
efl_pack_table(tbl, o, 0, 11, 1, 1);
o = efl_add(EFL_UI_BUTTON_CLASS, tbl,
efl_gfx_hint_weight_set(efl_added, 0.0, 0.0),
efl_gfx_hint_align_set(efl_added, 0, 0.5));
efl_text_set(o, "Unselect All");
- efl_event_callback_add(o, EFL_INPUT_EVENT_CLICKED, _unselect_all,
item_container);
+ efl_event_callback_add(o, EFL_INPUT_EVENT_CLICKED, _all_unselect,
item_container);
efl_pack_table(tbl, o, 0, 12, 1, 1);
diff --git a/src/lib/elementary/efl_ui_collection.c
b/src/lib/elementary/efl_ui_collection.c
index dde77ab9b0..b71b1af32c 100644
--- a/src/lib/elementary/efl_ui_collection.c
+++ b/src/lib/elementary/efl_ui_collection.c
@@ -1079,13 +1079,13 @@ _selectable_range_apply(Eina_List *start, Eina_Bool
flag)
}
EOLIAN static void
-_efl_ui_collection_efl_ui_multi_selectable_select_all(Eo *obj EINA_UNUSED,
Efl_Ui_Collection_Data *pd)
+_efl_ui_collection_efl_ui_multi_selectable_all_select(Eo *obj EINA_UNUSED,
Efl_Ui_Collection_Data *pd)
{
_selectable_range_apply(pd->items, EINA_TRUE);
}
EOLIAN static void
-_efl_ui_collection_efl_ui_multi_selectable_unselect_all(Eo *obj EINA_UNUSED,
Efl_Ui_Collection_Data *pd)
+_efl_ui_collection_efl_ui_multi_selectable_all_unselect(Eo *obj EINA_UNUSED,
Efl_Ui_Collection_Data *pd)
{
_selectable_range_apply(pd->items, EINA_FALSE);
}
@@ -1125,13 +1125,13 @@ _range_selection_find(Eo *obj, Efl_Ui_Collection_Data
*pd, Efl_Ui_Selectable *a,
}
EOLIAN static void
-_efl_ui_collection_efl_ui_multi_selectable_select_range(Eo *obj,
Efl_Ui_Collection_Data *pd, Efl_Ui_Selectable *a, Efl_Ui_Selectable *b)
+_efl_ui_collection_efl_ui_multi_selectable_range_select(Eo *obj,
Efl_Ui_Collection_Data *pd, Efl_Ui_Selectable *a, Efl_Ui_Selectable *b)
{
_range_selection_find(obj, pd, a, b, EINA_TRUE);
}
EOLIAN static void
-_efl_ui_collection_efl_ui_multi_selectable_unselect_range(Eo *obj,
Efl_Ui_Collection_Data *pd, Efl_Ui_Selectable *a, Efl_Ui_Selectable *b)
+_efl_ui_collection_efl_ui_multi_selectable_range_unselect(Eo *obj,
Efl_Ui_Collection_Data *pd, Efl_Ui_Selectable *a, Efl_Ui_Selectable *b)
{
_range_selection_find(obj, pd, a, b, EINA_FALSE);
}
diff --git a/src/lib/elementary/efl_ui_collection.eo
b/src/lib/elementary/efl_ui_collection.eo
index 4a320c362a..507477c2bc 100644
--- a/src/lib/elementary/efl_ui_collection.eo
+++ b/src/lib/elementary/efl_ui_collection.eo
@@ -84,10 +84,10 @@ class Efl.Ui.Collection extends Efl.Ui.Layout_Base
implements
Efl.Ui.Single_Selectable.last_selected { get; }
Efl.Ui.Multi_Selectable.selected_items_get;
Efl.Ui.Multi_Selectable.select_mod
[EGIT] [core/efl] master 01/03: efl_ui_win: default window type change should not be applied to legacy one
bu5hm4n pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=1c936631561a5ad3651ec1dcc17490b6e26707fa commit 1c936631561a5ad3651ec1dcc17490b6e26707fa Author: WooHyun Jung Date: Wed Sep 25 05:18:04 2019 + efl_ui_win: default window type change should not be applied to legacy one If my understanding is correct, below referenced commit needs to be applied to efl_ui_win only. @ref D10049 Reviewed-by: Marcel Hollerbach Differential Revision: https://phab.enlightenment.org/D10143 --- src/lib/elementary/efl_ui_win.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/elementary/efl_ui_win.c b/src/lib/elementary/efl_ui_win.c index 1dec90aa38..f79d4d1333 100644 --- a/src/lib/elementary/efl_ui_win.c +++ b/src/lib/elementary/efl_ui_win.c @@ -5960,7 +5960,7 @@ _efl_ui_win_efl_object_constructor(Eo *obj, Efl_Ui_Win_Data *pd) if (!efl_parent_get(obj)) efl_allow_parent_unref_set(obj, EINA_TRUE); - if (elm_widget_is_legacy(obj)) + if (!elm_widget_is_legacy(obj)) pd->type = EFL_UI_WIN_TYPE_BASIC; return obj; --
[EGIT] [core/efl] master 02/03: efl_ui : put beta on range select/unselect as parameter unstable
bu5hm4n pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=9b8dcf2f299dfd0cef481bfdfeade0cf3414fdc1
commit 9b8dcf2f299dfd0cef481bfdfeade0cf3414fdc1
Author: SangHyeon Jade Lee
Date: Wed Sep 25 07:50:06 2019 +
efl_ui : put beta on range select/unselect as parameter unstable
there are more discussion need on this range selection.
we could extend this parameter with range structure(aka Eina.Range)
so that extendable object to object, int to int, Range to Range.
Reviewed-by: Marcel Hollerbach
Differential Revision: https://phab.enlightenment.org/D10145
---
src/lib/elementary/efl_ui_multi_selectable.eo | 4 ++--
src/lib/elementary/efl_ui_multi_selectable_async.eo | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/lib/elementary/efl_ui_multi_selectable.eo
b/src/lib/elementary/efl_ui_multi_selectable.eo
index fc10d3ad89..44b39942fe 100644
--- a/src/lib/elementary/efl_ui_multi_selectable.eo
+++ b/src/lib/elementary/efl_ui_multi_selectable.eo
@@ -21,7 +21,7 @@ interface @beta Efl.Ui.Multi_Selectable extends
Efl.Ui.Single_Selectable
[[Get the selected items in a iterator. The iterator sequence will be
decided by selection.]]
return: iterator @move @no_unused; [[User has to
free the iterator after usage.]]
}
- range_select {
+ range_select @beta {
[[Select a range of @Efl.Ui.Selectable.
This will select the range of selectables from a to b or from b to
a depending on which one comes first.
@@ -34,7 +34,7 @@ interface @beta Efl.Ui.Multi_Selectable extends
Efl.Ui.Single_Selectable
b : Efl.Ui.Selectable; [[The other side of the range.]]
}
}
- range_unselect {
+ range_unselect @beta {
[[Unselect a range of @Efl.Ui.Selectable.
This will unselect the range of selectables from a to b or from b
to a depending on which one comes first.
diff --git a/src/lib/elementary/efl_ui_multi_selectable_async.eo
b/src/lib/elementary/efl_ui_multi_selectable_async.eo
index 0047ed9b00..3a09682358 100644
--- a/src/lib/elementary/efl_ui_multi_selectable_async.eo
+++ b/src/lib/elementary/efl_ui_multi_selectable_async.eo
@@ -29,7 +29,7 @@ interface @beta Efl.Ui.Multi_Selectable_Async extends
Efl.Ui.Single_Selectable
return: iterator @move @no_unused; [[The iterator gives
indices of unselected children.
It is valid until any change is made on
the model.]]
}
- range_select {
+ range_select @beta {
[[Select a range of @Efl.Ui.Selectable.
This will select the range of selectables from $a to $b or from $b
to $a depending on which one comes first.
@@ -41,7 +41,7 @@ interface @beta Efl.Ui.Multi_Selectable_Async extends
Efl.Ui.Single_Selectable
b : uint64; [[The other side of the range.]]
}
}
- range_unselect {
+ range_unselect @beta {
[[Unselect a range of @Efl.Ui.Selectable.
This will unselect the range of selectables from $a to $b or from
$b to $a depending on which one comes first.
--
[EGIT] [core/efl] master 03/03: efl/image: remove load_controller events
bu5hm4n pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=595987ae177572a2a1c78af666b736946fedbf9f
commit 595987ae177572a2a1c78af666b736946fedbf9f
Author: Mike Blumenkrantz
Date: Tue Sep 24 16:38:04 2019 -0400
efl/image: remove load_controller events
these aren't implemented by anything and duplicate the functionality
provided
by efl.gfx.image::image,preload_state,changed
ref T7876
Reviewed-by: Marcel Hollerbach
Differential Revision: https://phab.enlightenment.org/D10128
---
src/lib/efl/interfaces/efl_gfx_image_load_controller.eo | 4
1 file changed, 4 deletions(-)
diff --git a/src/lib/efl/interfaces/efl_gfx_image_load_controller.eo
b/src/lib/efl/interfaces/efl_gfx_image_load_controller.eo
index d7b0bbf238..c088b776d4 100644
--- a/src/lib/efl/interfaces/efl_gfx_image_load_controller.eo
+++ b/src/lib/efl/interfaces/efl_gfx_image_load_controller.eo
@@ -164,8 +164,4 @@ interface @beta Efl.Gfx.Image_Load_Controller
}
}
}
- events {
- load,done: void; [[Emitted after the image has been loaded.]]
- load,error: Eina.Error; [[Emitted if an error happened during image
loading.]]
- }
}
--
[EGIT] [core/efl] master 01/01: release: Update NEWS and bump version for 1.23.0-beta3 release
stefan pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=ce135194b438790fa0b928824f15fdeb1958e523 commit ce135194b438790fa0b928824f15fdeb1958e523 Author: Stefan Schmidt Date: Wed Sep 25 11:13:32 2019 +0200 release: Update NEWS and bump version for 1.23.0-beta3 release --- NEWS | 22 ++ 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/NEWS b/NEWS index 2e209bf5a7..d33c99d3bc 100644 --- a/NEWS +++ b/NEWS @@ -29,26 +29,6 @@ Features: Fixes: - * eo: Fix missing varags cleanup (CID1399080) - * efl_core_command_line: Fix logically dead code (CID1399106) - * efl_ui_widget_common: Fix potential resource leak (CID1399088) - * efl_ui_selection_manager: Fix unchecked return value (CID1399092) - * evas_device: Fix dereferencing null pointer (CID1399091) - * efl_ui_stack: Fix dereference null return value (CID1399082) - * efl_ui_datepicker: Fix uninitialized scalar value (CID1397006) - * efl_ui_grid: Fix dereferencing null pointer (CID1397000) - * ecore_con: Fix dereferencing of null pointer (CID1396990) - * elm_atspi_bridge: Fix resource leak (CID1399429) - * efl_ui_win: Fix dereference null return value (CID1399428) - * efl_ui_win: Fix dereference null return (CID1399427) - * efl_ui_win: Fix dereference null return (CID1399426) - * efl_ui_win: Fix dereference null return value (CID1399425) - * efreet: Fix resource leak (CID1399090) - * efl_ui_text: Fix resource leak (CID1396998) - * eldbus: Fix dereference after null check (CID1399422) - * efl_ui_focus_manager_calc: Fix resource leaks (CID1396984, CID1396965) - * elm_focus_legacy: Fix resource leaks (CID1399096, CID1399095) - * eldbus: Fix resource leak (CID1399097) * efl_canvas_vg_object: Fix dereference after null check (CID1399423, CID1399421) * efl_ui_win: fix hw accel detection * efl_ui_layout: Eina_Error type has been modified to work correctly. @@ -229,6 +209,8 @@ Fixes: * fix xpm loader to be threadable - fixes so much stuff... * efl: check file's mtime in efl.file::file_set to determine if file is the same * meson.build: allow to disable tiff evas loader + * ecore/signal: also use nonblock for writing side of signal pipe + * ector engine: +null checking. Changes since 1.21.0: - --
[EGIT] [core/efl] annotated tag v1.23.0-beta3 created (now ac5df7b191)
This is an automated email from the git hooks/post-receive script. stefan pushed a change to annotated tag v1.23.0-beta3 in repository core/efl. at ac5df7b191 (tag) tagging ce135194b438790fa0b928824f15fdeb1958e523 (commit) replaces v1.23.0-beta2 tagged by Stefan Schmidt on Wed Sep 25 11:59:23 2019 +0200 - Log - v1.23.0-beta3 Bruno da Silva Belo (3): eolian-mono: add compiler's complaint methods. efl-mono: Additional blank line between all methods. eolian: fixing switch case. Carsten Haitzler (5): evas - in case handle scope data being null efl ui widget - call parent constructor before doing more init build - update README and meson options to match echother in defaults ci - osx - switch to full gl option on osx osx - require full opengl for gl support on osx Cedric BAIL (32): eina: fix eina_mempool_from to not report pointer that have never been allocated as allocated. eina: fix free support in eina OneBig mempool. eina: turn on Eina_Mempool tests for OneBig too. eina: prevent leak of Eina_Value internal allocation. ecore: remove unused variable after code migration. Fix warning. elementary: fix double eina_value_free in Efl.Ui.Homogeneous_Model.property.set elementary: properly shutdown and cleanup Efl.Ui.Position_Manager. eina: add eina_mempool_iterator_new to slowly iterate every allocated pointer in a mempool. eina: add code to help debug leaking Eina_Value. ecore: properly initialize the event structure in Efl.Generic_Model. ecore: properly initialize all field in event generated by Efl.Generic_Model ecore: remove unused piece of code. efl: improve Efl.Boolean_Model test to enforce Eina_Value type too. elementary: leverage sizing information from model if available to avoid unecessary calc. elementary: Efl.Ui.Widget_Factory bind widget property before finalizing the widget. efl: improve test in checking the return value during Eina_Value get operation. ecore: correctly handle children removal in Efl.Composite_Model by updating all required index. ecore: update Efl.Boolean_Model to handle children removal and shifting all necessary boolean and index. elementary: Efl.Ui.Image_Factory bind property also during widget creation. elementary: Efl.Ui.Layout_Factory bind property during widget creation. efl: simplify logic for widget created by factory. elementary: rework Efl.Ui.Factory to have another additional stage during releasing of items. efl: make Efl.Ui.Factory.release work in batches. elementary: factorize all events emitted by a Efl.Ui.Collection into their own interface. elementary: add an interface for asynchronous multi selection. elementary: fix children removal in Efl.Ui.Select_Model by not remembering index and relying on underlayer infrastructure to do it for us. elementary: introduce Efl.Ui.CollectionView a generic listing View. elementary: migrate Efl.Ui.List_View to use Efl.Ui.Collection_View. elementary: add Efl.Ui.Grid_View by leveraging MVVM and Collection/Position_Manager infrastructure. elementary: add a basic test for MVVM infrastructure. elementary: fix up left over header that got removed. elementary: another forgotten file that need removal. Christopher Michael (3): efl_ui_widget_factory: Fix resource leaks efl_ui_caching_factory: Fix resource leaks tests/ecore_wl2: Fix resource leak Daniel Kolesa (19): eolian: drop @ctor_param and the associated APIs eolian: enable unimplemented function errors for stable API eolian: skip funcs from beta-classes when unimplemented-checking eolian: disallow void for out/inout for stable API eolian: return NULL instead of EINA_FALSE on safety checks eolian: auto-add composited interfaces into implements if needed eolian: allow composites keyword in place of composite efl: replace composite with composites and dedup implements eolian: remove the composite keyword (replaced by composites) eolian: make hashes beta-only for now eolian: string(share) is always const, allow in events out of box eolian: rename any_value_ptr -> any_value_ref for consistency eolian: allow read-only stringshare in events efl: use new eolian error functionality instead of globals eolian: remove global vars from tests eolian: always allow implementation for eot files efl: remove remaining instances of .eo global variables eolian: remove support for globals elm: fix Efl.Ui errors not being registered Hermet Park (8): ector: refer exact stride size for jumping buffer lines. canvas vg: code refactoring. evas map: disable the anti_aliasing code which can't be reached. evas gl: re
[EGIT] [website/www-content] master 01/01: Wiki page efl-1.23.0-beta3 changed with summary [created] by Stefan Schmidt
WWW-www.enlightenment.org pushed a commit to branch master.
http://git.enlightenment.org/website/www-content.git/commit/?id=c3968955d50c29134aa47fedc26bbeb4840514b0
commit c3968955d50c29134aa47fedc26bbeb4840514b0
Author: Stefan Schmidt
Date: Wed Sep 25 03:18:41 2019 -0700
Wiki page efl-1.23.0-beta3 changed with summary [created] by Stefan Schmidt
---
pages/news/efl-1.23.0-beta3.txt | 17 +
1 file changed, 17 insertions(+)
diff --git a/pages/news/efl-1.23.0-beta3.txt b/pages/news/efl-1.23.0-beta3.txt
new file mode 100644
index 0..ffdc64dc1
--- /dev/null
+++ b/pages/news/efl-1.23.0-beta3.txt
@@ -0,0 +1,17 @@
+=== EFL 1.23.0 beta 3 ===
+ * //2019-09-25 - by Stefan Schmidt//
+
+While we hoped we would have the final release at this point we still have
issues to sort out before we can declare our current work a stable release.
+In the meantime I am releasing another beta here to allow people testing which
needs tarballs.
+
+**Fixes:**
+ * ecore/signal: also use nonblock for writing side of signal pipe
+ * ector engine: +null checking.
+
+**Download**
+
+|LINK| SHA256|
+| http://download.enlightenment.org/rel/libs/efl/efl-1.23.0-beta3.tar.xz |
ea6c5503b838f884f7a8960524b2d855e833da62c8c15d654d1099c31c404e3c |
+
+{{:blank.png?nolink&100|}}
+~~DISCUSSIONS~~
\ No newline at end of file
--
[E-devel] EFL 1.23.0 beta 3
hile we hoped we would have the final release at this point we still have issues to sort out before we can declare our current work a stable release. In the meantime I am releasing another beta here to allow people testing which needs tarballs. Fixes: * ecore/signal: also use nonblock for writing side of signal pipe * ector engine: +null checking. Download http://download.enlightenment.org/rel/libs/efl/efl-1.23.0-beta3.tar.xz ea6c5503b838f884f7a8960524b2d855e833da62c8c15d654d1099c31c404e3c ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [core/efl] master 01/01: docs: formatting nitpick in Efl.Player.eo
xartigas pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=eda96947b3720cdaab16ae21880d351618b5e46a commit eda96947b3720cdaab16ae21880d351618b5e46a Author: Xavi Artigas Date: Wed Sep 25 12:33:24 2019 +0200 docs: formatting nitpick in Efl.Player.eo --- src/lib/efl/interfaces/efl_player.eo | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/efl/interfaces/efl_player.eo b/src/lib/efl/interfaces/efl_player.eo index e6425ee244..3157715bec 100644 --- a/src/lib/efl/interfaces/efl_player.eo +++ b/src/lib/efl/interfaces/efl_player.eo @@ -9,7 +9,7 @@ interface Efl.Player This property sets the playback state of the object. Re-setting the current playback state has no effect. - If set to $false, the object's @.playback_progress property is, by default, reset to $0.0. A + If set to $false, the object's @.playback_progress property is, by default, reset to $[0.0]. A class may alter this behavior, and it will be stated in the documentation for a class if such behavior changes should be expected. --
[EGIT] [core/efl] master 01/01: efl_ui_layout: fix null pointer dereferences
zmike pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=09b2ecec6d84c81e7f22eddb0daacd9412bfd69c
commit 09b2ecec6d84c81e7f22eddb0daacd9412bfd69c
Author: Yeongjong Lee
Date: Wed Sep 25 06:44:56 2019 -0400
efl_ui_layout: fix null pointer dereferences
Summary: If theme doesn't have version data, `version` can be NULL.
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10146
---
src/lib/elementary/efl_ui_layout.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/src/lib/elementary/efl_ui_layout.c
b/src/lib/elementary/efl_ui_layout.c
index 8935e017d0..ec5e731dfd 100644
--- a/src/lib/elementary/efl_ui_layout.c
+++ b/src/lib/elementary/efl_ui_layout.c
@@ -547,13 +547,16 @@ _efl_ui_layout_base_efl_ui_widget_theme_apply(Eo *obj,
Efl_Ui_Layout_Data *sd)
if (!version)
ERR("Widget(%p) with type '%s' is not providing a version in its
theme!", obj,
efl_class_name_get(efl_class_get(obj)));
-errno = 0;
-sd->version = strtoul(version, NULL, 10);
-if (errno)
+else
{
- ERR("Widget(%p) with type '%s' is not providing a valid version
in its theme!", obj,
- efl_class_name_get(efl_class_get(obj)));
- sd->version = 0;
+ errno = 0;
+ sd->version = strtoul(version, NULL, 10);
+ if (errno)
+ {
+ ERR("Widget(%p) with type '%s' is not providing a valid
version in its theme!", obj,
+ efl_class_name_get(efl_class_get(obj)));
+ sd->version = 0;
+ }
}
}
if (!version)
--
[EGIT] [core/efl] master 01/02: efl_ui_spin_button: mark "direct_text_input" property @beta
zmike pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=14a6dd6ab0e5ef077866b9d2ac4cd4b94e4a8934
commit 14a6dd6ab0e5ef077866b9d2ac4cd4b94e4a8934
Author: WooHyun Jung
Date: Wed Sep 25 06:53:51 2019 -0400
efl_ui_spin_button: mark "direct_text_input" property @beta
Summary:
After making efl_ui_text interface be stabilized, this property
can be considered again about its opening.
ref T8097
Reviewers: zmike, bu5hm4n
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8097
Differential Revision: https://phab.enlightenment.org/D10140
---
src/lib/elementary/efl_ui_spin_button.eo | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/elementary/efl_ui_spin_button.eo
b/src/lib/elementary/efl_ui_spin_button.eo
index a8b2778b58..b6fa111a31 100644
--- a/src/lib/elementary/efl_ui_spin_button.eo
+++ b/src/lib/elementary/efl_ui_spin_button.eo
@@ -42,7 +42,7 @@ class @beta Efl.Ui.Spin_Button extends Efl.Ui.Spin
circulate: bool(false); [[$true to enable circulate or $false to
disable it.]]
}
}
- @property direct_text_input {
+ @property direct_text_input @beta {
[[Control whether the spin can be directly edited by the user.
Spin objects can have editing disabled, in which case they can only
--
[EGIT] [core/efl] master 02/02: evas_callbacks: check if obj is NULL before using it
zmike pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=5fa21a962966c46f636640a210a96e8e98e69e64
commit 5fa21a962966c46f636640a210a96e8e98e69e64
Author: Shinwoo Kim
Date: Wed Sep 25 06:53:53 2019 -0400
evas_callbacks: check if obj is NULL before using it
Summary:
evas_object_callbacks_finalized could take NULL obj because
_efl_canvas_object_efl_object_finalize could call it with NULL obj.
Reviewers: bu5hm4n, jsuya, Hermet
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10141
---
src/lib/evas/canvas/evas_callbacks.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/lib/evas/canvas/evas_callbacks.c
b/src/lib/evas/canvas/evas_callbacks.c
index cadd0212f0..35ef78aef2 100644
--- a/src/lib/evas/canvas/evas_callbacks.c
+++ b/src/lib/evas/canvas/evas_callbacks.c
@@ -805,6 +805,8 @@ _animator_repeater(void *data, const Efl_Event *event)
void
evas_object_callbacks_finalized(Eo *eo_obj EINA_UNUSED,
Evas_Object_Protected_Data *obj)
{
+ EINA_SAFETY_ON_NULL_RETURN(obj);
+
if (obj->animator_ref > 0)
{
if (obj->layer && obj->layer->evas)
--
[EGIT] [core/efl] master 03/04: api: mark Efl.Ui.Spin_Button stable
xartigas pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=b7ed1901d56b05783c820879ecaa9ea5ac643d6a
commit b7ed1901d56b05783c820879ecaa9ea5ac643d6a
Author: Mike Blumenkrantz
Date: Wed Sep 25 13:28:46 2019 +0200
api: mark Efl.Ui.Spin_Button stable
Summary: fix T8097
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl_api
Maniphest Tasks: T8097
Differential Revision: https://phab.enlightenment.org/D10152
---
src/lib/elementary/efl_ui_spin_button.eo | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/lib/elementary/efl_ui_spin_button.eo
b/src/lib/elementary/efl_ui_spin_button.eo
index b6fa111a31..d8e09d91d3 100644
--- a/src/lib/elementary/efl_ui_spin_button.eo
+++ b/src/lib/elementary/efl_ui_spin_button.eo
@@ -1,6 +1,6 @@
-class @beta Efl.Ui.Spin_Button extends Efl.Ui.Spin
- implements Efl.Ui.Focus.Composition,
Efl.Ui.Layout_Orientable, Efl.Ui.Range_Interactive,
- Efl.Access.Widget.Action
+class Efl.Ui.Spin_Button extends Efl.Ui.Spin
+ implements Efl.Ui.Focus.Composition,
Efl.Ui.Layout_Orientable, Efl.Ui.Range_Interactive,
+Efl.Access.Widget.Action
{
[[A Button Spin.
--
[EGIT] [core/efl] master 02/04: api: mark Efl.Ui.Box_Stack stable
xartigas pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=a171b5bd10a8fbb1ae9ccc43dc3321de4efb8fce
commit a171b5bd10a8fbb1ae9ccc43dc3321de4efb8fce
Author: Mike Blumenkrantz
Date: Wed Sep 25 13:27:42 2019 +0200
api: mark Efl.Ui.Box_Stack stable
Summary: fix T8207
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl_api
Maniphest Tasks: T8207
Differential Revision: https://phab.enlightenment.org/D10150
---
src/lib/elementary/efl_ui_box_stack.eo | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/elementary/efl_ui_box_stack.eo
b/src/lib/elementary/efl_ui_box_stack.eo
index 060f470f35..688f0ef6b7 100644
--- a/src/lib/elementary/efl_ui_box_stack.eo
+++ b/src/lib/elementary/efl_ui_box_stack.eo
@@ -1,4 +1,4 @@
-class @beta Efl.Ui.Box_Stack extends Efl.Ui.Box
+class Efl.Ui.Box_Stack extends Efl.Ui.Box
{
[[A custom layout engine for @Efl.Ui.Box that stacks items.
--
[EGIT] [core/efl] master 01/04: efl/arrangement: mark content_padding beta
xartigas pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=05a7168ca37fe3c0c01c03304f6ac34950b3f436
commit 05a7168ca37fe3c0c01c03304f6ac34950b3f436
Author: Mike Blumenkrantz
Date: Wed Sep 25 13:22:34 2019 +0200
efl/arrangement: mark content_padding beta
Summary:
this still potentially needs some work and changing the implementations
now would be too invasive
ref T7864
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7864
Differential Revision: https://phab.enlightenment.org/D10149
---
src/lib/efl/interfaces/efl_gfx_arrangement.eo | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/efl/interfaces/efl_gfx_arrangement.eo
b/src/lib/efl/interfaces/efl_gfx_arrangement.eo
index 02cda25495..00f3fe4281 100644
--- a/src/lib/efl/interfaces/efl_gfx_arrangement.eo
+++ b/src/lib/efl/interfaces/efl_gfx_arrangement.eo
@@ -28,7 +28,7 @@ interface @beta Efl.Gfx.Arrangement
axis and 1.0 is at the end.]]
}
}
- @property content_padding {
+ @property content_padding @beta {
[[This property determines the space between a container's content
items.
It is different than the @Efl.Gfx.Hint.hint_margin property in that
it is applied to each
--
[EGIT] [core/efl] master 04/04: api: mark Efl.Ui.Scrollable stable
xartigas pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=0b8862642a96c2031d0ba47d6d4d1dfdfc4bc235
commit 0b8862642a96c2031d0ba47d6d4d1dfdfc4bc235
Author: Mike Blumenkrantz
Date: Wed Sep 25 13:34:01 2019 +0200
api: mark Efl.Ui.Scrollable stable
Summary: fix T7883
Subscribers: cedric, #reviewers, #committers
Tags: #efl_api
Maniphest Tasks: T7883
Differential Revision: https://phab.enlightenment.org/D10151
---
src/lib/efl/interfaces/efl_ui_scrollable.eo | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/efl/interfaces/efl_ui_scrollable.eo
b/src/lib/efl/interfaces/efl_ui_scrollable.eo
index 520cdd1d13..8baf832fa8 100644
--- a/src/lib/efl/interfaces/efl_ui_scrollable.eo
+++ b/src/lib/efl/interfaces/efl_ui_scrollable.eo
@@ -1,7 +1,7 @@
import eina_types;
import efl_ui_layout_orientable;
-interface @beta Efl.Ui.Scrollable
+interface Efl.Ui.Scrollable
{
[[Efl UI scrollable interface]]
event_prefix: efl_ui;
--
[EGIT] [core/efl] master 01/01: efl_ui/layout: improve docs
xartigas pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=883cb445c68a2ed9033ad7c46f35ccfbc6f00e12
commit 883cb445c68a2ed9033ad7c46f35ccfbc6f00e12
Author: Mike Blumenkrantz
Date: Wed Sep 25 15:02:52 2019 +0200
efl_ui/layout: improve docs
Summary: add doc notes for these classes
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10155
---
src/lib/elementary/efl_ui_layout.eo | 2 +-
src/lib/elementary/efl_ui_layout_base.eo | 14 +-
2 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/src/lib/elementary/efl_ui_layout.eo
b/src/lib/elementary/efl_ui_layout.eo
index 0ebbb4e1cd..f8ff7a9e39 100644
--- a/src/lib/elementary/efl_ui_layout.eo
+++ b/src/lib/elementary/efl_ui_layout.eo
@@ -2,7 +2,7 @@ import efl_ui;
class Efl.Ui.Layout extends Efl.Ui.Layout_Base implements Efl.File
{
- [[Elementary layout class
+ [[EFL layout widget class.
When loading layouts from a file, use the @Efl.File.key property to
specify
the group that the data belongs to, in case it's an EET file
diff --git a/src/lib/elementary/efl_ui_layout_base.eo
b/src/lib/elementary/efl_ui_layout_base.eo
index 4f4624744a..aa616c777a 100644
--- a/src/lib/elementary/efl_ui_layout_base.eo
+++ b/src/lib/elementary/efl_ui_layout_base.eo
@@ -5,7 +5,19 @@ abstract Efl.Ui.Layout_Base extends Efl.Ui.Widget implements
Efl.Container,
Efl.Layout.Calc, Efl.Layout.Signal,
Efl.Layout.Group
{
- [[Elementary layout abstract
+ [[EFL layout widget abstract.
+
+ A "layout" in the context of EFL is an object which interfaces with the
internal layout engine.
+ Layouts are created using the EDC language, and any widget which
implements this abstract must
+ have a corresponding theme group to load in order to graphically display
anything.
+
+ Theme groups for EFL widgets must be versioned. This means having a
"version" $[data.item] key in
+ the theme group for the widget. If the loaded theme group for a widget
has version info which
+ is lower than the currently-running EFL version, a warning will be
printed to notify the user that
+ new features may be available. If the loaded theme group for a widget has
no version info, an
+ error will be generated. If the loaded theme group for a widget has a
version that is newer than
+ the currently-running EFL version, a critical error will be printed to
notify the user that
+ the theme may not be compatible.
@since 1.22
]]
--
Re: [E-devel] Compiling/Running Wayland.
On Tue, 24 Sep 2019 23:53:52 -0500 Matthew Kolar said: > Ah, > > On some further research it looks like elput is an alternative backend > to inputd? That's what this old news release would seem to indicate: > https://www.enlightenment.org/news/efl-1.18.0 > > I looked for it in meson_options.txt in both efl and enlightenment > packages and could not find a reference to it. What is the config > option using meson? no. elput is our front-end lib to libinput. > On 9/24/19 8:42 PM, Matthew Kolar wrote: > > I use Slackware, which uses SysVinit, not systemd. I dont understand > > the bit about elput, what is that? > > > > > > On 9/24/19 8:27 PM, Carsten Haitzler (The Rasterman) wrote: > >> On Tue, 24 Sep 2019 19:11:50 -0500 Matthew Kolar > >> said: > >> > >>> Ok! > >>> > >>> The dlopen error has been resolved by recompiling targeting > >>> opengl-es/egl, but I'm gettting another error now: > >>> > >>> ESTART: 2.10681 [0.00085] - Compositor Init > >>> Enlightenment cannot initialize X Connection... > >>> LOAD WL_WL MODULE > >>> Could not create wayland canvas > >>> LOAD WL_X11 MODULE > >>> X11 connect failed! > >>> LOAD WL_DRM MODULE > >>> ERR<26151>:ecore_drm2 ../src/lib/ecore_drm2/ecore_drm2_device.c:602 > >>> ecore_drm2_device_open() Could not connect to input manager > >>> ERR<26151>:ecore_evas > >>> ../src/modules/ecore_evas/engines/drm/ecore_evas_drm.c:164 > >>> _ecore_evas_drm_init() Failed to open device > >>> ERR<26151>:ecore_drm2 ../src/lib/ecore_drm2/ecore_drm2_device.c:602 > >>> ecore_drm2_device_open() Could not connect to input manager > >>> ERR<26151>:ecore_evas > >>> ../src/modules/ecore_evas/engines/drm/ecore_evas_drm.c:164 > >>> _ecore_evas_drm_init() Failed to open device > >>> Could not create ecore_evas_drm canvas Enlightenment Error > >>> Enlightenment cannot create a compositor. > >> logind/systemd issue it would seem. your login session doesnt support > >> being able > >> to get input device fd's via logind. elput takes care of this... > >> > >>> E: Begin Shutdown Procedure! > >>> ERR<26151>:e ../src/bin/e_msgbus.c:84 _e_msgbus_request_name_cb() Could > >>> not request bus name > >>> > >>> Looks like I'm missing my "input manager", would that be the dependent > >>> xkbcommon package? > >>> > >>> On 9/24/19 5:03 PM, Carsten Haitzler wrote: > On Tue, 24 Sep 2019 14:03:55 -0500 Matthew Kolar > said: > > > Raster, > > > > Ah! That would probably be it, I just went with the default > > full-opengl, > > I will have to download new git in that case, if it's going to be > > default. I presume that this goes for both efl and E, and that I wont > > have to specify gl-es on either anymore? > e doesn't know or care about full opengl vs egl/gles - ti deals > with efl as > the abstraction and efl abstracts this generally at a high level or > exposes > a gles api from evas_gl regardless what back-end evas was built for. > > > Matthew > > > > > > On 9/24/19 12:27 PM, Carsten Haitzler (The Rasterman) wrote: > >> On Tue, 24 Sep 2019 11:47:43 -0500 Matthew Kolar > >> > >> said: > >> > >> this: > >> libGL.so.1 => /usr/lib64/libGL.so.1 (0x7f1e2d0c) > >> > >> did you not enable gles. full opengl is not supported other than > >> in x11 > >> (and osx)? i actually just switched the default to gl-es because > >> people > >> keep forgetting to switch to gles to have wl/drm work. > >> > >>> Raster, > >>> > >>> Here is some relevant console output: > >>> > >>> bash-5.0$ ldd > >>> /usr/lib64/evas/modules/engines/gl_drm/v-1.23/module.so > >>> linux-vdso.so.1 (0x7fffd23fe000) > >>> libeina.so.1 => /usr/lib64/libeina.so.1 > >>> (0x7f1e2d4c) > >>> libevas.so.1 => /usr/lib64/libevas.so.1 > >>> (0x7f1e2d1f1000) > >>> libecore.so.1 => /usr/lib64/libecore.so.1 > >>> (0x7f1e2d172000) > >>> libecore_drm2.so.1 => /usr/lib64/libecore_drm2.so.1 > >>> (0x7f1e2d15e000) > >>> libdl.so.2 => /lib64/libdl.so.2 (0x7f1e2d159000) > >>> libGL.so.1 => /usr/lib64/libGL.so.1 > >>> (0x7f1e2d0c) > >>> libgbm.so.1 => /usr/lib64/libgbm.so.1 > >>> (0x7f1e2d0ae000) > >>> libwayland-client.so.0 => > >>> /usr/lib64/libwayland-client.so.0 > >>> (0x7f1e2d09e000) > >>> libc.so.6 => /lib64/libc.so.6 (0x7f1e2ceb9000) > >>> libm.so.6 => /lib64/libm.so.6 (0x7f1e2cd6e000) > >>> librt.so.1 => /lib64/librt.so.1 (0x7f1e2cd64000) > >>> libunwind-x86_64.so.8 => > >>> /usr/lib64/libunwind-x86_64.so.8 > >>> (0x7f1e2cd45000) > >>> libunwind.so.8 => /usr/lib64/libunwind.so.8 > >>> (0x7f1e2cd29000) libpthread.so.0 => /lib
[EGIT] [core/efl] master 01/01: eolian: expose most API as stable
q66 pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=71cd89c5809e957b42ff76642f34bb5789ad6a78
commit 71cd89c5809e957b42ff76642f34bb5789ad6a78
Author: Daniel Kolesa
Date: Wed Sep 25 18:17:48 2019 +0200
eolian: expose most API as stable
There is still some TODO with builtin types, parameter
directions and prefixes, which will be resolved in the
next commits.
---
src/bindings/luajit/eolian.lua | 14 +++---
src/lib/eolian/Eolian.h | 84 +---
src/lib/eolian/database_class_api.c | 2 +-
src/lib/eolian/database_type_api.c | 7 ---
src/lib/eolian/database_var_api.c| 2 +-
src/lib/eolian/eo_parser.c | 32 ++--
src/lib/eolian/eolian_database.h | 1 -
src/lib/eolian_cxx/grammar/klass_def.hpp | 4 +-
src/scripts/pyolian/eolian.py| 12 ++---
src/scripts/pyolian/eolian_lib.py| 16 +++---
src/scripts/pyolian/test_eolian.py | 5 +-
src/tests/eolian/eolian_parsing.c| 6 +--
12 files changed, 75 insertions(+), 110 deletions(-)
diff --git a/src/bindings/luajit/eolian.lua b/src/bindings/luajit/eolian.lua
index bd3b20601b..8671fc5c2a 100644
--- a/src/bindings/luajit/eolian.lua
+++ b/src/bindings/luajit/eolian.lua
@@ -339,7 +339,7 @@ ffi.cdef [[
Eolian_Class_Type eolian_class_type_get(const Eolian_Class *klass);
const Eolian_Documentation *eolian_class_documentation_get(const
Eolian_Class *klass);
-const char *eolian_class_eo_prefix_get(const Eolian_Class *klass);
+const char *eolian_class_c_prefix_get(const Eolian_Class *klass);
const char *eolian_class_event_prefix_get(const Eolian_Class *klass);
const char *eolian_class_data_type_get(const Eolian_Class *klass);
const Eolian_Class *eolian_class_parent_get(const Eolian_Class *klass);
@@ -454,7 +454,7 @@ ffi.cdef [[
const Eolian_Expression *eolian_expression_unary_expression_get(const
Eolian_Expression *expr);
Eolian_Value_t eolian_expression_value_get(const Eolian_Expression *expr);
const Eolian_Documentation *eolian_constant_documentation_get(const
Eolian_Constant *var);
-const Eolian_Type *eolian_constant_base_type_get(const Eolian_Constant
*var);
+const Eolian_Type *eolian_constant_type_get(const Eolian_Constant *var);
const Eolian_Expression *eolian_constant_value_get(const Eolian_Constant
*var);
Eina_Bool eolian_constant_is_extern(const Eolian_Constant *var);
const char *eolian_documentation_summary_get(const Eolian_Documentation
*doc);
@@ -1435,8 +1435,8 @@ M.Class = ffi.metatype("Eolian_Class", {
return v
end,
-eo_prefix_get = function(self)
-local v = eolian.eolian_class_eo_prefix_get(self)
+c_prefix_get = function(self)
+local v = eolian.eolian_class_c_prefix_get(self)
if v == nil then
local buf = self:namespaces_get()
buf[#buf + 1] = self:short_name_get()
@@ -1448,7 +1448,7 @@ M.Class = ffi.metatype("Eolian_Class", {
event_prefix_get = function(self)
local v = eolian.eolian_class_event_prefix_get(self)
if v == nil then
-return self:eo_prefix_get()
+return self:c_prefix_get()
end
return ffi.string(v)
end,
@@ -1713,8 +1713,8 @@ M.Constant = ffi.metatype("Eolian_Constant", {
return v
end,
-base_type_get = function(self)
-local v = eolian.eolian_constant_base_type_get(self)
+type_get = function(self)
+local v = eolian.eolian_constant_type_get(self)
if v == nil then return nil end
return v
end,
diff --git a/src/lib/eolian/Eolian.h b/src/lib/eolian/Eolian.h
index b0d7a4e9ce..33e571c491 100644
--- a/src/lib/eolian/Eolian.h
+++ b/src/lib/eolian/Eolian.h
@@ -34,7 +34,7 @@ extern "C" {
#include
/**
- * @page eolian_main Eolian (BETA)
+ * @page eolian_main Eolian
*
* @date 2014 (created)
*
@@ -82,8 +82,6 @@ extern "C" {
* @{
*/
-#ifdef EFL_BETA_API_SUPPORT
-
/* The maximum format version supported by this version of Eolian */
#define EOLIAN_FILE_FORMAT_VERSION 1
@@ -284,7 +282,9 @@ typedef enum
EOLIAN_TYPE_REGULAR,
EOLIAN_TYPE_CLASS,
EOLIAN_TYPE_ERROR,
+#ifdef EFL_BETA_API_SUPPORT
EOLIAN_TYPE_UNDEFINED
+#endif
} Eolian_Type_Type;
typedef enum
@@ -336,7 +336,7 @@ typedef enum
EOLIAN_TYPE_BUILTIN_ARRAY,
EOLIAN_TYPE_BUILTIN_FUTURE,
EOLIAN_TYPE_BUILTIN_ITERATOR,
- EOLIAN_TYPE_BUILTIN_HASH,
+ EOLIAN_TYPE_BUILTIN_HASH, /* FIXME: beta */
EOLIAN_TYPE_BUILTIN_LIST,
EOLIAN_TYPE_BUILTIN_ANY_VALUE,
@@ -348,7 +348,9 @@ typedef enum
EOLIAN_TYPE_BUILTIN_STRINGSHARE,
EOLIAN_TYPE_BUILTIN_STRBUF,
+#ifdef EOLIAN_BETA_API_SUPPORT
EOLIAN_TYPE_BUILTIN_VOID_PTR
+#endif
} Eolian_Type_Builtin_Type;
typedef enum
@@ -1498,14 +150
Re: [E-devel] 1.23 delay for two days
Hi, There are currently patches on phab (which I expect to land in the next few hours) to resolve all of the remaining minor interfaces API-related issues. There are still a number of tasks in progress for MVVM-related items, but if they are not resolved by the end of today then they will be deferred until after the release. There is the patch series beginning with https://phab.enlightenment.org/D9899 which resolves a regression with running EFL on X without a window manager. I've spent about an hour examining https://phab.enlightenment.org/T8260 today to see what can be done, but I'm unable to reproduce it either in the scenario described or the test case that I created. I'm not planning to look into this further. There's a strange issue with the "Efl.Ui.Image_Zoomable animation" case in elm_test where the image is not properly aligned, but this is an issue in elm_test itself as far as I'm aware. This is the only remaining "solvable" issue that I know of which may be worth exploring prior to the release. In summary, at this time I don't see a case where a Friday release could be blocked. It's regrettable that things have not gone as smoothly for this release as they could have, but considering the sheer volume of serious issues which have managed to pop up over the past couple weeks, I'd say we're in better shape than expected. Regards, Mike On Wed, Sep 25, 2019 at 3:36 AM Stefan Schmidt wrote: > Hello. > > [Grumpy mail ahead] > > On 23.09.19 12:06, Stefan Schmidt wrote: > > Hello. > > > > The schedule we planned would have the 1.23 final release today. > > > > This will not happen as we have some ongoing things being handled right > > now that need a delay. The biggest item is the theme API review going on. > > > > We hope that we are in the position to release on Wednesday. You can > > help by looking at the work list I posted and especially the show > > stopper issues still marked open. > > We are definitely not in a position that we can release today. :( > > There have been so many changes coming in the last days it feels like > the floodgates have been opened after the freeze and not like the last > days before a release! I am seriously grumpy right now. > > I understand that many of these things have been worked on for a long > time and the target was always this release. I also have been > communicated most of these things and people have been working hard to > get it working, so please do not take this to personal. > > Still, how are we supposed to release all this just a second after it > has landed? This last minute rush of changes is really not how a release > could work. > > I hope Mike will get out theme stuff under control and the big evas leak > get fixed quickly. > > I will do a beta3 today and cross my finger when looking at it again on > Friday. > > regards > Stefan Schmidt > > > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [tools/expedite] master 02/02: Updated to fit EFL 1.23 API.
cedric pushed a commit to branch master.
http://git.enlightenment.org/tools/expedite.git/commit/?id=ac6a3bcb44a4385a8c01222e6f2e9b178325b3ad
commit ac6a3bcb44a4385a8c01222e6f2e9b178325b3ad
Author: Cedric Bail
Date: Wed Sep 25 10:26:17 2019 -0700
Updated to fit EFL 1.23 API.
---
src/bin/image_blend_border.c| 2 +-
src/bin/image_blend_border_recolor.c| 2 +-
src/bin/image_blend_solid_border.c | 2 +-
src/bin/image_blend_solid_middle_border.c | 4 ++--
src/bin/image_blend_solid_middle_unscaled.c | 4 ++--
src/bin/ui.c| 2 +-
src/bin/widgets_list_1.c| 2 +-
src/bin/widgets_list_1_grouped.c| 2 +-
src/bin/widgets_list_2.c| 2 +-
src/bin/widgets_list_2_grouped.c| 2 +-
src/bin/widgets_list_3.c| 4 ++--
src/bin/widgets_list_3_grouped.c| 4 ++--
src/bin/widgets_list_4.c| 4 ++--
src/bin/widgets_list_4_grouped.c| 4 ++--
14 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/src/bin/image_blend_border.c b/src/bin/image_blend_border.c
index 188bfe7..4acad32 100644
--- a/src/bin/image_blend_border.c
+++ b/src/bin/image_blend_border.c
@@ -26,7 +26,7 @@ static void _setup(void)
o = efl_add(EFL_CANVAS_IMAGE_CLASS, evas);
o_images[i] = o;
efl_file_simple_load(o, build_path("bar.png"), NULL);
-efl_gfx_image_border_set(o, 6, 6, 6, 6);
+efl_gfx_image_border_insets_set(o, 6, 6, 6, 6);
efl_gfx_entity_visible_set(o, EINA_TRUE);
}
done = 0;
diff --git a/src/bin/image_blend_border_recolor.c
b/src/bin/image_blend_border_recolor.c
index 4de2697..5d46f2b 100644
--- a/src/bin/image_blend_border_recolor.c
+++ b/src/bin/image_blend_border_recolor.c
@@ -27,7 +27,7 @@ static void _setup(void)
o_images[i] = o;
efl_file_simple_load(o, build_path("pan.png"), NULL);
efl_gfx_color_set(o, 64, 64, 64, 255);
-efl_gfx_image_border_set(o, 3, 3, 3, 3);
+efl_gfx_image_border_insets_set(o, 3, 3, 3, 3);
efl_gfx_entity_visible_set(o, EINA_TRUE);
}
done = 0;
diff --git a/src/bin/image_blend_solid_border.c
b/src/bin/image_blend_solid_border.c
index b72d7b7..b4d972d 100644
--- a/src/bin/image_blend_solid_border.c
+++ b/src/bin/image_blend_solid_border.c
@@ -26,7 +26,7 @@ static void _setup(void)
o = efl_add(EFL_CANVAS_IMAGE_CLASS, evas);
o_images[i] = o;
efl_file_simple_load(o, build_path("frame.png"), NULL);
-efl_gfx_image_border_set(o, 8, 8, 8, 8);
+efl_gfx_image_border_insets_set(o, 8, 8, 8, 8);
efl_gfx_entity_visible_set(o, EINA_TRUE);
}
done = 0;
diff --git a/src/bin/image_blend_solid_middle_border.c
b/src/bin/image_blend_solid_middle_border.c
index 95e22c8..329fc13 100644
--- a/src/bin/image_blend_solid_middle_border.c
+++ b/src/bin/image_blend_solid_middle_border.c
@@ -26,8 +26,8 @@ static void _setup(void)
o = efl_add(EFL_CANVAS_IMAGE_CLASS, evas);
o_images[i] = o;
efl_file_simple_load(o, build_path("bar.png"), NULL);
-efl_gfx_image_border_set(o, 6, 6, 6, 6);
-efl_gfx_image_border_center_fill_set(o,
EFL_GFX_BORDER_FILL_MODE_SOLID);
+efl_gfx_image_border_insets_set(o, 6, 6, 6, 6);
+efl_gfx_image_center_fill_mode_set(o, EFL_GFX_CENTER_FILL_MODE_SOLID);
efl_gfx_entity_visible_set(o, EINA_TRUE);
}
done = 0;
diff --git a/src/bin/image_blend_solid_middle_unscaled.c
b/src/bin/image_blend_solid_middle_unscaled.c
index 5a3fdc0..67b50d3 100644
--- a/src/bin/image_blend_solid_middle_unscaled.c
+++ b/src/bin/image_blend_solid_middle_unscaled.c
@@ -28,8 +28,8 @@ static void _setup(void)
efl_file_simple_load(o, build_path("logo.png"), NULL);
efl_gfx_fill_set(o, EINA_RECT(0, 0, 120, 160));
efl_gfx_entity_size_set(o, EINA_SIZE2D(120, 160));
-efl_gfx_image_border_set(o, 43, 48, 48, 83);
-efl_gfx_image_border_center_fill_set(o,
EFL_GFX_BORDER_FILL_MODE_SOLID);
+efl_gfx_image_border_insets_set(o, 43, 48, 48, 83);
+efl_gfx_image_center_fill_mode_set(o, EFL_GFX_CENTER_FILL_MODE_SOLID);
efl_gfx_entity_visible_set(o, EINA_TRUE);
}
done = 0;
diff --git a/src/bin/ui.c b/src/bin/ui.c
index adaba18..f7292d1 100644
--- a/src/bin/ui.c
+++ b/src/bin/ui.c
@@ -463,7 +463,7 @@ ui_setup(unsigned int ui_w, unsigned int ui_h)
efl_file_simple_load(o, build_path("text_sel.png"), NULL);
efl_gfx_entity_size_set(o, EINA_SIZE2D(96, 32));
efl_gfx_fill_set(o, EINA_RECT(0, 0, 96, 32));
- efl_gfx_image_border_set(o, 7, 7, 7, 7);
+ efl_gfx_image_border_insets_set(o, 7, 7, 7, 7);
o_menu_text_sel = o;
o = evas_object_text_add(evas);
diff --git a/src/bin/widgets_list_1.c b/src/bin/widgets_list_1.c
index 01f0869..c30847e 100644
--- a/src/bin/widgets_list_1.c
+++ b/src/bin/widgets_list_1.c
@@ -64,7 +64,7 @@ static voi
[EGIT] [tools/expedite] master 01/02: main: lookup for the right file thanks error warning in Efl!
cedric pushed a commit to branch master.
http://git.enlightenment.org/tools/expedite.git/commit/?id=105e6568a4974fd86d11291a10cf615a13df43ed
commit 105e6568a4974fd86d11291a10cf615a13df43ed
Author: Cedric Bail
Date: Wed Sep 25 10:25:47 2019 -0700
main: lookup for the right file thanks error warning in Efl!
---
src/bin/ui.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/src/bin/ui.c b/src/bin/ui.c
index d31d4a5..adaba18 100644
--- a/src/bin/ui.c
+++ b/src/bin/ui.c
@@ -12,7 +12,6 @@ static double t_start = 0.0;
static double t_loop = 0.0;
static intf_start = 0;
static intf_loop = 0;
-static char data_dir[4096];
int async_render = 0;
Eina_List *menu = NULL;
@@ -568,7 +567,6 @@ ui_loop(void *data EINA_UNUSED)
tr = tt;
EINA_LIST_FOREACH(menu, l, mi)
{
- char buf[4096];
Evas_Coord x, y, w, h, tw, th;
Evas_Coord len;
double a;
@@ -624,8 +622,7 @@ ui_loop(void *data EINA_UNUSED)
efl_gfx_color_set(o, a, a, a, a);
o = o_menu_icon;
- snprintf(buf, 4096, "%s%s", data_dir, mi->icon);
- efl_file_simple_load(o, buf, NULL);
+ efl_file_simple_load(o, build_path(mi->icon), NULL);
efl_gfx_color_set(o, a / 2, a / 2, a / 2, a / 2);
}
i++;
--
[EGIT] [core/enlightenment] master 01/01: e build fix - make uuid an explicit dep of gadget loader
raster pushed a commit to branch master.
http://git.enlightenment.org/core/enlightenment.git/commit/?id=754e56f68c10cea0ea993124e89ec5f49b165bc4
commit 754e56f68c10cea0ea993124e89ec5f49b165bc4
Author: Carsten Haitzler (Rasterman)
Date: Wed Sep 25 18:45:31 2019 +0100
e build fix - make uuid an explicit dep of gadget loader
fix build break thanks to latest 1.23 bet bleeding edge efl.
---
src/bin/meson.build | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/bin/meson.build b/src/bin/meson.build
index 54940a507..959d4d2e2 100644
--- a/src/bin/meson.build
+++ b/src/bin/meson.build
@@ -577,7 +577,8 @@ if config_h.has('HAVE_WAYLAND') == true
name_prefix: '',
include_directories: include_directories('../..'),
dependencies: [
- dep_dl,
+ dep_dl,
+ dependency('uuid'),
dependency('elementary'),
dependency('ecore-wl2'),
dependency('wayland-client'),
--
[EGIT] [core/enlightenment] enlightenment-0.23 01/02: e build fix - make uuid an explicit dep of gadget loader
raster pushed a commit to branch enlightenment-0.23.
http://git.enlightenment.org/core/enlightenment.git/commit/?id=19309a3e3acae06d481797e30c8f45030f432d38
commit 19309a3e3acae06d481797e30c8f45030f432d38
Author: Carsten Haitzler (Rasterman)
Date: Wed Sep 25 18:45:31 2019 +0100
e build fix - make uuid an explicit dep of gadget loader
fix build break thanks to latest 1.23 bet bleeding edge efl.
---
src/bin/meson.build | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/bin/meson.build b/src/bin/meson.build
index 54940a507..959d4d2e2 100644
--- a/src/bin/meson.build
+++ b/src/bin/meson.build
@@ -577,7 +577,8 @@ if config_h.has('HAVE_WAYLAND') == true
name_prefix: '',
include_directories: include_directories('../..'),
dependencies: [
- dep_dl,
+ dep_dl,
+ dependency('uuid'),
dependency('elementary'),
dependency('ecore-wl2'),
dependency('wayland-client'),
--
[EGIT] [core/enlightenment] enlightenment-0.23 02/02: mixer - try not to create notifications for no change in volume
raster pushed a commit to branch enlightenment-0.23.
http://git.enlightenment.org/core/enlightenment.git/commit/?id=6623bd2d1baa4e337307abdfe71427b77c8b7061
commit 6623bd2d1baa4e337307abdfe71427b77c8b7061
Author: Carsten Haitzler (Rasterman)
Date: Fri Sep 20 13:48:31 2019 +0100
mixer - try not to create notifications for no change in volume
---
src/modules/mixer/gadget/backend.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/modules/mixer/gadget/backend.c
b/src/modules/mixer/gadget/backend.c
index 52e44e0ca..66ebb2652 100644
--- a/src/modules/mixer/gadget/backend.c
+++ b/src/modules/mixer/gadget/backend.c
@@ -351,10 +351,8 @@ _sink_event(int type, void *info)
if (sink == _sink_default)
{
l = emix_sinks_get();
- if (l)
- _sink_default = l->data;
- else
- _sink_default = NULL;
+ if (l) _sink_default = l->data;
+ else _sink_default = NULL;
if (emix_config_save_get()) e_config_save_queue();
_backend_changed();
}
@@ -363,15 +361,17 @@ _sink_event(int type, void *info)
{
if (_sink_default == sink)
{
+ static int prev_vol = -1;
int vol;
_backend_changed();
- if (sink->mute || !sink->volume.channel_count)
- vol = 0;
- else
- vol = sink->volume.volumes[0];
-
- _notify(vol);
+ if (sink->mute || !sink->volume.channel_count) vol = 0;
+ else vol = sink->volume.volumes[0];
+ if (vol != prev_vol)
+ {
+ _notify(vol);
+ prev_vol = vol;
+ }
}
}
else
--
[EGIT] [core/efl] master 04/05: elementary: return an error when unimplemented function on Efl.Ui.Widget_Factory.
cedric pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=267f8fcfa82af22c20c79687eb1aed5d5c513ab8
commit 267f8fcfa82af22c20c79687eb1aed5d5c513ab8
Author: Cedric Bail
Date: Wed Sep 25 16:52:18 2019 +
elementary: return an error when unimplemented function on
Efl.Ui.Widget_Factory.
Reviewed-by: Cedric BAIL
Differential Revision: https://phab.enlightenment.org/D10130
---
src/bindings/mono/efl_mono/Bind.cs| 3 +--
src/lib/efl/interfaces/efl_ui_factory_bind.eo | 1 +
src/lib/elementary/efl_ui_layout.c| 10 ++
src/lib/elementary/efl_ui_layout_factory.c| 6 --
src/lib/elementary/efl_ui_widget_factory.c| 12 +++-
src/lib/elementary/efl_ui_widget_factory.eo | 1 +
6 files changed, 24 insertions(+), 9 deletions(-)
diff --git a/src/bindings/mono/efl_mono/Bind.cs
b/src/bindings/mono/efl_mono/Bind.cs
index 14c45d9dd0..c31186cbb7 100644
--- a/src/bindings/mono/efl_mono/Bind.cs
+++ b/src/bindings/mono/efl_mono/Bind.cs
@@ -112,8 +112,7 @@ public class BindableFactoryPart
/// Binds the given factory to this part.
public Eina.Error BindFactory(Efl.Ui.IFactory factory)
{
-this.Binder.BindFactory(this.PartName, factory);
-return Eina.Error.NO_ERROR;
+return this.Binder.BindFactory(this.PartName, factory);
}
}
diff --git a/src/lib/efl/interfaces/efl_ui_factory_bind.eo
b/src/lib/efl/interfaces/efl_ui_factory_bind.eo
index d26832453f..740c627b82 100644
--- a/src/lib/efl/interfaces/efl_ui_factory_bind.eo
+++ b/src/lib/efl/interfaces/efl_ui_factory_bind.eo
@@ -14,6 +14,7 @@ interface @beta Efl.Ui.Factory_Bind
key: string; [[Key string for bind model property data]]
factory: Efl.Ui.Factory; [[@Efl.Ui.Factory for create and bind
model property data]]
}
+ return: Eina.Error; [[0 when it succeed, an error code otherwise.]]
}
}
}
diff --git a/src/lib/elementary/efl_ui_layout.c
b/src/lib/elementary/efl_ui_layout.c
index c4310f01c1..1797d8a45f 100644
--- a/src/lib/elementary/efl_ui_layout.c
+++ b/src/lib/elementary/efl_ui_layout.c
@@ -2527,16 +2527,16 @@
_efl_ui_layout_base_efl_ui_property_bind_property_bind(Eo *obj, Efl_Ui_Layout_Da
return 0;
}
-EOLIAN static void
+EOLIAN static Eina_Error
_efl_ui_layout_base_efl_ui_factory_bind_factory_bind(Eo *obj EINA_UNUSED,
Efl_Ui_Layout_Data *pd,
const char *key,
Efl_Ui_Factory *factory)
{
- EINA_SAFETY_ON_NULL_RETURN(key);
+ EINA_SAFETY_ON_NULL_RETURN_VAL(key, EFL_PROPERTY_ERROR_INVALID_KEY);
Efl_Ui_Layout_Factory_Tracking *tracking;
Eina_Stringshare *ss_key;
if (!_elm_layout_part_aliasing_eval(obj, &key, EINA_TRUE))
- return;
+ return EFL_PROPERTY_ERROR_INVALID_KEY;
// Check if there is a model and register it
_efl_ui_layout_base_model_watch(obj, pd);
@@ -2566,7 +2566,7 @@ _efl_ui_layout_base_efl_ui_factory_bind_factory_bind(Eo
*obj EINA_UNUSED, Efl_Ui
else
{
tracking = calloc(1, sizeof (Efl_Ui_Layout_Factory_Tracking));
-if (!tracking) return ;
+if (!tracking) return ENOMEM;
tracking->key = ss_key;
@@ -2577,6 +2577,8 @@ _efl_ui_layout_base_efl_ui_factory_bind_factory_bind(Eo
*obj EINA_UNUSED, Efl_Ui
tracking->factory = efl_ref(factory);
_efl_ui_layout_view_model_content_update(pd, tracking, ss_key);
+
+ return EINA_ERROR_NO_ERROR;
}
EOLIAN void
diff --git a/src/lib/elementary/efl_ui_layout_factory.c
b/src/lib/elementary/efl_ui_layout_factory.c
index cfc2749dd3..b6032e70e9 100644
--- a/src/lib/elementary/efl_ui_layout_factory.c
+++ b/src/lib/elementary/efl_ui_layout_factory.c
@@ -88,7 +88,7 @@ _efl_ui_layout_factory_efl_object_destructor(Eo *obj,
Efl_Ui_Layout_Factory_Data
efl_destructor(efl_super(obj, MY_CLASS));
}
-EOLIAN static void
+EOLIAN static Eina_Error
_efl_ui_layout_factory_efl_ui_factory_bind_factory_bind(Eo *obj EINA_UNUSED,
Efl_Ui_Layout_Factory_Data *pd,
const char *key,
Efl_Ui_Factory *factory)
{
@@ -99,7 +99,7 @@ _efl_ui_layout_factory_efl_ui_factory_bind_factory_bind(Eo
*obj EINA_UNUSED, Efl
if (factory == NULL)
{
eina_hash_del(pd->bind.factories, ss_key, NULL);
-return;
+return EINA_ERROR_NO_ERROR;
}
f_old = eina_hash_set(pd->bind.factories, ss_key, efl_ref(factory));
@@ -108,6 +108,8 @@ _efl_ui_layout_factory_efl_ui_factory_bind_factory_bind(Eo
*obj EINA_UNUSED, Efl
efl_unref(f_old);
eina_stringshare_del(ss_key);
}
+
+ return EINA_ERROR_NO_ERROR;
}
EOLIAN static Eina_Error
diff --git a/src/lib/elementary/efl_ui_widget_factory.c
b/src/lib/elementary/efl_ui_widget_factory.c
index 54b1b8dc09..13160af8e1 100644
--- a/src/lib/elementary/efl_ui_widget_factory.c
+++ b/src/lib/elementary/efl_ui_widget_factory.c
@@ -413,7 +413,7 @@
_efl_ui_property_
[EGIT] [core/efl] master 03/05: elementary: add support for default property on item being created by Efl.Ui.Widget_Factory.
cedric pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=78ee2ca6b0604ddf6ac2479da9585b68ad937613
commit 78ee2ca6b0604ddf6ac2479da9585b68ad937613
Author: Cedric Bail
Date: Tue Sep 24 17:13:49 2019 -0700
elementary: add support for default property on item being created by
Efl.Ui.Widget_Factory.
Reviewed-by: SangHyeon Jade Lee
Differential Revision: https://phab.enlightenment.org/D10129
---
src/lib/elementary/efl_ui_widget_factory.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/lib/elementary/efl_ui_widget_factory.c
b/src/lib/elementary/efl_ui_widget_factory.c
index 00ba103cda..54b1b8dc09 100644
--- a/src/lib/elementary/efl_ui_widget_factory.c
+++ b/src/lib/elementary/efl_ui_widget_factory.c
@@ -36,6 +36,8 @@ struct _Efl_Ui_Widget_Factory_Data
Eina_Hash *parts;
+ Eina_Stringshare *default_property;
+
Eina_Stringshare *style;
};
@@ -182,6 +184,9 @@ _efl_ui_widget_factory_releasing(void *data, const
Efl_Event *ev)
efl_key_data_set(ui_view, "efl.ui.widget.factory.size_check", NULL);
if (efl_isa(ui_view, EFL_UI_ITEM_CLASS))
efl_ui_item_calc_locked_set(ui_view, EINA_TRUE);
+ // Bind default property
+ if (pd->default_property) efl_ui_property_bind(ui_view, NULL,
pd->default_property);
+
// Bind all property before the object is finalize
it = eina_hash_iterator_data_new(pd->parts);
EINA_ITERATOR_FOREACH(it, bpd)
@@ -405,6 +410,12 @@
_efl_ui_property_bind_part_efl_ui_property_bind_property_bind(Eo *obj EINA_UNUSE
return ENOENT;
}
+ if (!key)
+ {
+eina_stringshare_replace(&pd->pd->default_property, property);
+return;
+ }
+
if (!pd->pd->parts)
pd->pd->parts = eina_hash_stringshared_new(NULL);
--
[EGIT] [core/efl] master 05/05: elementary: properly mark iterator usage in Efl.Ui.Factory.
cedric pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=e5ad8716bd1f0f94a9d6b789c99fc00721d419f8
commit e5ad8716bd1f0f94a9d6b789c99fc00721d419f8
Author: Cedric Bail
Date: Tue Sep 24 16:48:31 2019 -0700
elementary: properly mark iterator usage in Efl.Ui.Factory.
Reviewed-by: SangHyeon Jade Lee
Differential Revision: https://phab.enlightenment.org/D10132
---
src/lib/efl/interfaces/efl_ui_factory.eo | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/lib/efl/interfaces/efl_ui_factory.eo
b/src/lib/efl/interfaces/efl_ui_factory.eo
index 47dd203f6e..b0518a0755 100644
--- a/src/lib/efl/interfaces/efl_ui_factory.eo
+++ b/src/lib/efl/interfaces/efl_ui_factory.eo
@@ -21,10 +21,10 @@ interface @beta Efl.Ui.Factory extends
Efl.Ui.Property_Bind, Efl.Ui.Factory_Bind
Note: This is the function you need to implement for a custom
factory, but if you want to use a factory,
you should rely on @Efl.Ui.View_Factory.create_with_event.]]
params {
-models: iterator; [[Efl iterator providing the model to
be associated to the new item.
+models: iterator @move; [[Efl iterator providing the
model to be associated to the new item.
It should remain valid until the
end of the function call.]]
}
- return: future; [[Created UI object.]]
+ return: future @move @no_unused; [[Created UI
object.]]
}
release {
[[Release a UI object and disconnect from models.]]
--
[EGIT] [core/efl] master 02/05: efl_ui/image: fix playback_speed timer calcs
cedric pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=a4597c8326d340b93cfcfd62a72057aae9b9f506
commit a4597c8326d340b93cfcfd62a72057aae9b9f506
Author: Mike Blumenkrantz
Date: Wed Sep 25 06:47:49 2019 -0400
efl_ui/image: fix playback_speed timer calcs
I accidentally inverted this; the frame timing needs to be divided by
the playback speed to have the correct time here
Reviewed-by: Cedric BAIL
Differential Revision: https://phab.enlightenment.org/D10147
---
src/lib/elementary/efl_ui_image.c | 8
src/lib/elementary/efl_ui_image_zoomable.c | 8
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/lib/elementary/efl_ui_image.c
b/src/lib/elementary/efl_ui_image.c
index ade335b3ee..f732d44add 100644
--- a/src/lib/elementary/efl_ui_image.c
+++ b/src/lib/elementary/efl_ui_image.c
@@ -141,7 +141,7 @@ _efl_ui_image_animate_cb(void *data)
(sd->img, sd->cur_frame, 0);
if (sd->frame_duration > 0)
- ecore_timer_interval_set(sd->anim_timer, sd->frame_duration *
sd->playback_speed);
+ ecore_timer_interval_set(sd->anim_timer, sd->frame_duration /
sd->playback_speed);
return ECORE_CALLBACK_RENEW;
}
@@ -1762,7 +1762,7 @@ _efl_ui_image_animated_set_internal(Eo *obj,
Efl_Ui_Image_Data *sd, Eina_Bool an
evas_object_image_animated_frame_set(sd->img, sd->cur_frame);
if (!sd->paused)//legacy
sd->anim_timer = ecore_timer_add
- (sd->frame_duration * sd->playback_speed,
_efl_ui_image_animate_cb, obj);
+ (sd->frame_duration / sd->playback_speed,
_efl_ui_image_animate_cb, obj);
}
else
{
@@ -1821,7 +1821,7 @@ _efl_ui_image_efl_player_playback_speed_set(Eo *obj
EINA_UNUSED, Efl_Ui_Image_Da
efl_player_playback_speed_set(sd->img, factor);
else if (sd->anim_timer)
{
-ecore_timer_interval_set(sd->anim_timer, sd->frame_duration *
sd->playback_speed);
+ecore_timer_interval_set(sd->anim_timer, sd->frame_duration /
sd->playback_speed);
ecore_timer_reset(sd->anim_timer);
}
}
@@ -1881,7 +1881,7 @@ _efl_ui_image_animated_paused_set_internal(Eo *obj,
Efl_Ui_Image_Data *sd, Eina_
if (!paused)
{
sd->anim_timer = ecore_timer_add
-(sd->frame_duration * sd->playback_speed,
_efl_ui_image_animate_cb, obj);
+(sd->frame_duration / sd->playback_speed,
_efl_ui_image_animate_cb, obj);
}
else
{
diff --git a/src/lib/elementary/efl_ui_image_zoomable.c
b/src/lib/elementary/efl_ui_image_zoomable.c
index b14bace8a2..a08a72ca8a 100644
--- a/src/lib/elementary/efl_ui_image_zoomable.c
+++ b/src/lib/elementary/efl_ui_image_zoomable.c
@@ -3035,7 +3035,7 @@ _efl_ui_image_zoomable_animate_cb(void *data)
(sd->img, sd->cur_frame, 0);
if (sd->frame_duration > 0)
- ecore_timer_interval_set(sd->anim_timer, sd->frame_duration *
sd->playback_speed);
+ ecore_timer_interval_set(sd->anim_timer, sd->frame_duration /
sd->playback_speed);
return ECORE_CALLBACK_RENEW;
}
@@ -3065,7 +3065,7 @@ _efl_ui_image_zoomable_animated_set_internal(Eo *obj
EINA_UNUSED, Efl_Ui_Image_Z
evas_object_image_animated_frame_set(sd->img, sd->cur_frame);
if (!sd->paused)//legacy
sd->anim_timer = ecore_timer_add
- (sd->frame_duration * sd->playback_speed,
_efl_ui_image_zoomable_animate_cb, obj);
+ (sd->frame_duration / sd->playback_speed,
_efl_ui_image_zoomable_animate_cb, obj);
}
else
{
@@ -3092,7 +3092,7 @@ _efl_ui_image_zoomable_animated_paused_set_internal(Eo
*obj, Efl_Ui_Image_Zoomab
if (!paused)
{
sd->anim_timer = ecore_timer_add
-(sd->frame_duration * sd->playback_speed,
_efl_ui_image_zoomable_animate_cb, obj);
+(sd->frame_duration / sd->playback_speed,
_efl_ui_image_zoomable_animate_cb, obj);
}
else
{
@@ -3138,7 +3138,7 @@ _efl_ui_image_zoomable_efl_player_playback_speed_set(Eo
*obj EINA_UNUSED, Efl_Ui
efl_player_playback_speed_set(sd->edje, factor);
else if (sd->anim_timer)
{
-ecore_timer_interval_set(sd->anim_timer, sd->frame_duration *
sd->playback_speed);
+ecore_timer_interval_set(sd->anim_timer, sd->frame_duration /
sd->playback_speed);
ecore_timer_reset(sd->anim_timer);
}
}
--
[EGIT] [core/efl] master 01/05: efl_ui/layout: add explicit error case when theme version > efl version
cedric pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=9206960dfac9e2ad6651c69e24a3df5c1b92a2eb
commit 9206960dfac9e2ad6651c69e24a3df5c1b92a2eb
Author: Mike Blumenkrantz
Date: Wed Sep 25 07:30:24 2019 -0400
efl_ui/layout: add explicit error case when theme version > efl version
it's important to handle cases where a "future" theme is trying to be used
by "current" efl. this throws a serious error, since it's possible that the
widget may look/act in a way that makes it unusable
ref T8231
Reviewed-by: Cedric BAIL
Differential Revision: https://phab.enlightenment.org/D10153
---
src/lib/elementary/efl_ui.eot | 3 +++
src/lib/elementary/efl_ui_layout.c | 15 +--
2 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/src/lib/elementary/efl_ui.eot b/src/lib/elementary/efl_ui.eot
index b397b27094..eaa4ae41be 100644
--- a/src/lib/elementary/efl_ui.eot
+++ b/src/lib/elementary/efl_ui.eot
@@ -11,6 +11,9 @@ error Efl.Ui.Theme.Apply_Error.DEFAULT = "Fallback to default
style was enabled
error Efl.Ui.Theme.Apply_Error.GENERIC = "An error occurred and no theme could
be set for this widget"; [[
Failed to apply theme. The widget may become unusable.
]]
+error Efl.Ui.Theme.Apply_Error.VERSION = "The widget attempted to load a theme
that is incompatible with the current EFL version"; [[
+ The theme was applied. The widget may not function or look as expected.
+]]
enum Efl.Ui.Focus.Direction
{
diff --git a/src/lib/elementary/efl_ui_layout.c
b/src/lib/elementary/efl_ui_layout.c
index ec5e731dfd..c4310f01c1 100644
--- a/src/lib/elementary/efl_ui_layout.c
+++ b/src/lib/elementary/efl_ui_layout.c
@@ -545,8 +545,11 @@ _efl_ui_layout_base_efl_ui_widget_theme_apply(Eo *obj,
Efl_Ui_Layout_Data *sd)
{
const char *version = edje_object_data_get(wd->resize_obj, "version");
if (!version)
- ERR("Widget(%p) with type '%s' is not providing a version in its
theme!", obj,
- efl_class_name_get(efl_class_get(obj)));
+ {
+ ERR("Widget(%p) with type '%s' is not providing a version in its
theme!", obj,
+ efl_class_name_get(efl_class_get(obj)));
+ return EFL_UI_THEME_APPLY_ERROR_VERSION;
+ }
else
{
errno = 0;
@@ -556,6 +559,7 @@ _efl_ui_layout_base_efl_ui_widget_theme_apply(Eo *obj,
Efl_Ui_Layout_Data *sd)
ERR("Widget(%p) with type '%s' is not providing a valid
version in its theme!", obj,
efl_class_name_get(efl_class_get(obj)));
sd->version = 0;
+ return EFL_UI_THEME_APPLY_ERROR_VERSION;
}
}
}
@@ -575,6 +579,13 @@ _efl_ui_layout_base_efl_ui_widget_theme_apply(Eo *obj,
Efl_Ui_Layout_Data *sd)
if (sd->version < version)
WRN("Widget(%p) with type '%s' is providing a potentially old
version in its theme: found %u, should be %u", obj,
efl_class_name_get(efl_class_get(obj)), sd->version, version);
+else if (sd->version > version)
+ {
+ CRI("Widget(%p) with type '%s' is attempting to use a theme that
is too new: found %u, should be %u", obj,
+ efl_class_name_get(efl_class_get(obj)), sd->version, version);
+ CRI("\tTheme file: %s\tTheme group: %s", efl_file_get(obj),
efl_file_key_get(obj));
+ return EFL_UI_THEME_APPLY_ERROR_VERSION;
+ }
}
return EFL_UI_THEME_APPLY_ERROR_NONE;
--
Re: [E-devel] 1.23 delay for two days
"There is the patch series beginning with https://phab.enlightenment.org/D9899 which resolves a regression with running EFL on X without a window manager." I took a look at this, and the patch that is there looks good ... however your comment seems to indicate that this is part of a series, yet I cannot see the rest of the seriesPerhaps they are not uploaded yet ? or perhaps a typo in the email ?? Cheers, dh From: Mike Blumenkrantz Sent: Wednesday, September 25, 2019 12:45 PM To: Enlightenment developer list Subject: Re: [E-devel] 1.23 delay for two days Hi, There are currently patches on phab (which I expect to land in the next few hours) to resolve all of the remaining minor interfaces API-related issues. There are still a number of tasks in progress for MVVM-related items, but if they are not resolved by the end of today then they will be deferred until after the release. There is the patch series beginning with https://phab.enlightenment.org/D9899 which resolves a regression with running EFL on X without a window manager. I've spent about an hour examining https://phab.enlightenment.org/T8260 today to see what can be done, but I'm unable to reproduce it either in the scenario described or the test case that I created. I'm not planning to look into this further. There's a strange issue with the "Efl.Ui.Image_Zoomable animation" case in elm_test where the image is not properly aligned, but this is an issue in elm_test itself as far as I'm aware. This is the only remaining "solvable" issue that I know of which may be worth exploring prior to the release. In summary, at this time I don't see a case where a Friday release could be blocked. It's regrettable that things have not gone as smoothly for this release as they could have, but considering the sheer volume of serious issues which have managed to pop up over the past couple weeks, I'd say we're in better shape than expected. Regards, Mike On Wed, Sep 25, 2019 at 3:36 AM Stefan Schmidt wrote: > Hello. > > [Grumpy mail ahead] > > On 23.09.19 12:06, Stefan Schmidt wrote: > > Hello. > > > > The schedule we planned would have the 1.23 final release today. > > > > This will not happen as we have some ongoing things being handled right > > now that need a delay. The biggest item is the theme API review going on. > > > > We hope that we are in the position to release on Wednesday. You can > > help by looking at the work list I posted and especially the show > > stopper issues still marked open. > > We are definitely not in a position that we can release today. :( > > There have been so many changes coming in the last days it feels like > the floodgates have been opened after the freeze and not like the last > days before a release! I am seriously grumpy right now. > > I understand that many of these things have been worked on for a long > time and the target was always this release. I also have been > communicated most of these things and people have been working hard to > get it working, so please do not take this to personal. > > Still, how are we supposed to release all this just a second after it > has landed? This last minute rush of changes is really not how a release > could work. > > I hope Mike will get out theme stuff under control and the big evas leak > get fixed quickly. > > I will do a beta3 today and cross my finger when looking at it again on > Friday. > > regards > Stefan Schmidt > > > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [core/efl] master 01/02: elm: add basics test to create a destroy *every* widget with errors
bu5hm4n pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=10cdb070180e0f1e62d5b8e5d5164a19fbc51548
commit 10cdb070180e0f1e62d5b8e5d5164a19fbc51548
Author: Marcel Hollerbach
Date: Mon Sep 23 20:43:47 2019 +0200
elm: add basics test to create a destroy *every* widget with errors
this simply creates packs, resizes, and destroys every single widget
that we have in legacy elm.
This i made to ensure that there are no mistakes in the construction
chain. Additionally, a second test case checks that creation with none
elm parents is erroring but not failing, this seems weird, but we have
provided that in the past, so we should continue providing this.
Differential Revision: https://phab.enlightenment.org/D10088
---
src/tests/elementary/elm_suite.c | 1 +
src/tests/elementary/elm_suite.h | 1 +
src/tests/elementary/elm_test_widget_basics.c | 137 ++
src/tests/elementary/meson.build | 3 +-
4 files changed, 141 insertions(+), 1 deletion(-)
diff --git a/src/tests/elementary/elm_suite.c b/src/tests/elementary/elm_suite.c
index 87fac6e4e1..d6aa4636e8 100644
--- a/src/tests/elementary/elm_suite.c
+++ b/src/tests/elementary/elm_suite.c
@@ -86,6 +86,7 @@ static const Efl_Test_Case etc[] = {
{ "elm_code_widget_selection", elm_code_test_widget_selection },
{ "elm_code_widget_undo", elm_code_test_widget_undo },
{ "elm_widget_focus", elm_test_widget_focus},
+ { "elm_widget_basics", elm_test_widget_basics},
{ NULL, NULL }
};
diff --git a/src/tests/elementary/elm_suite.h b/src/tests/elementary/elm_suite.h
index ba76b29615..67f5d0d5c4 100644
--- a/src/tests/elementary/elm_suite.h
+++ b/src/tests/elementary/elm_suite.h
@@ -84,6 +84,7 @@ void elm_test_slideshow(TCase *tc);
void elm_test_spinner(TCase *tc);
void elm_test_plug(TCase *tc);
void elm_test_widget_focus(TCase *tc);
+void elm_test_widget_basics(TCase *tc);
void elm_code_file_test_load(TCase *tc);
void elm_code_file_test_memory(TCase *tc);
diff --git a/src/tests/elementary/elm_test_widget_basics.c
b/src/tests/elementary/elm_test_widget_basics.c
new file mode 100644
index 00..e66a9ac149
--- /dev/null
+++ b/src/tests/elementary/elm_test_widget_basics.c
@@ -0,0 +1,137 @@
+#ifdef HAVE_CONFIG_H
+# include "elementary_config.h"
+#endif
+
+#include
+#include "elm_suite.h"
+
+typedef struct _Simple_Test_Widget
+{
+ Evas_Object* (*constructor)(Evas_Object *win);
+ const char *name;
+} Simple_Test_Widget;
+
+
+static const Simple_Test_Widget simple_widgets[] = {
+ {elm_flip_add, "flip"},
+ {elm_frame_add, "frame"},
+ {elm_player_add, "player"},
+ {elm_video_add, "video"},
+ {elm_ctxpopup_add, "ctxpopup"},
+ {elm_fileselector_add, "fileselector"},
+ {elm_hoversel_add, "hoversel"},
+ {elm_multibuttonentry_add, "multibuttonentry"},
+ {elm_naviframe_add, "naviframe"},
+ {elm_popup_add, "popup"},
+ {elm_actionslider_add, "actionslider"},
+ {elm_bg_add, "bg"},
+ {elm_box_add, "box"},
+ {elm_bubble_add, "bubble"},
+ {elm_calendar_add, "calendar"},
+ {elm_button_add, "button"},
+ {elm_check_add, "check"},
+ {elm_clock_add, "clock"},
+ {elm_colorselector_add, "colorselector"},
+ {elm_conformant_add, "conformant"},
+ {elm_dayselector_add, "dayselector"},
+ {elm_entry_add, "entry"},
+ {elm_flipselector_add, "flipselector"},
+ {elm_gengrid_add, "gengrid"},
+ {elm_genlist_add, "genlist"},
+ {elm_glview_add, "glview"},
+ {elm_grid_add, "grid"},
+ {elm_hover_add, "hover"},
+ {elm_icon_add, "icon"},
+ {elm_image_add, "image"},
+ {elm_index_add, "index"},
+ {elm_label_add, "label"},
+ {elm_layout_add, "layout"},
+ {elm_list_add, "list"},
+ {elm_map_add, "map"},
+ {elm_mapbuf_add, "mapbuf"},
+ {elm_menu_add, "menu"},
+ {elm_notify_add, "notify"},
+ {elm_panel_add, "panel"},
+ {elm_panes_add, "panes"},
+ {elm_photo_add, "photo"},
+ {elm_photocam_add, "photocam"},
+ {elm_plug_add, "plug"},
+ {elm_prefs_add, "prefs"},
+ {elm_progressbar_add, "progressbar"},
+ {elm_radio_add, "radio"},
+ {elm_route_add, "route"},
+ {elm_separator_add, "seperator"},
+ {elm_slider_add, "slider"},
+ {elm_slideshow_add, "slideshow"},
+ {elm_spinner_add, "spinner"},
+ {elm_table_add, "table"},
+ {elm_textpath_add, "textpath"},
+ {elm_toolbar_add, "toolbar"},
+ {elm_web_add, "web"},
+ {elm_diskselector_add, "diskselector"},
+ {elm_datetime_add, "datetime"},
+ //{elm_combobox_add, "button"}, This is a beta widget which was never public
and is written in a few ways that break basic assertions of widgets base class
+ //{elm_thumb_add, "button"}, This dies because of a ethumb bug, where the
log domain is not correctly inited
+ //{elm_systray_add, "button"}, This is not a elm widget, but matches the API
regax
+ //{elm_factory_add, "button"}, This is a beta widget which was never public
but matches the API regax
+ {NULL, NULL},
+};
+
+EFL_START_TEST(elm_test_widget_creation_
[EGIT] [core/efl] master 02/02: efl_ui : change selected_items_get to selected_iterator_new.
bu5hm4n pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=7884a38dbd46baf4d9636663269bcbb53f6c0b97
commit 7884a38dbd46baf4d9636663269bcbb53f6c0b97
Author: SangHyeon Jade Lee
Date: Wed Sep 25 10:57:03 2019 +
efl_ui : change selected_items_get to selected_iterator_new.
multi_selectable_aync already changed name as
selected_iterator_new
so multi_selectable change name also for unity of API.
not sure about we need unselected_items_get in multi_selectable,
so skip to create new api for this time.
Reviewed-by: Marcel Hollerbach
Differential Revision: https://phab.enlightenment.org/D10148
---
src/examples/elementary/efl_ui_list_example_1.c | 2 +-
src/lib/elementary/efl_ui_collection.c | 2 +-
src/lib/elementary/efl_ui_collection.eo | 4 ++--
src/lib/elementary/efl_ui_grid.eo| 2 +-
src/lib/elementary/efl_ui_list.eo| 2 +-
src/lib/elementary/efl_ui_multi_selectable.eo| 2 +-
.../elementary/spec/efl_test_multi_selectable.c | 20 ++--
7 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/src/examples/elementary/efl_ui_list_example_1.c
b/src/examples/elementary/efl_ui_list_example_1.c
index cbd05d23d1..dab45ae261 100644
--- a/src/examples/elementary/efl_ui_list_example_1.c
+++ b/src/examples/elementary/efl_ui_list_example_1.c
@@ -30,7 +30,7 @@ _list_selected(void *data EINA_UNUSED, const Efl_Event *ev)
Eo *item = ev->info, *tmp;
printf("list item [%p:%d] is %s\n", item, efl_ui_item_index_get(item),
(efl_ui_selectable_selected_get(item)? "selected" : "unselected"));
- Eina_Iterator *selects = efl_ui_selected_items_get(list);
+ Eina_Iterator *selects = efl_ui_selected_iterator_new(list);
EINA_ITERATOR_FOREACH(selects, tmp)
printf("selected [%p:%d] ", tmp, efl_ui_item_index_get(tmp));
diff --git a/src/lib/elementary/efl_ui_collection.c
b/src/lib/elementary/efl_ui_collection.c
index b71b1af32c..abef6732c1 100644
--- a/src/lib/elementary/efl_ui_collection.c
+++ b/src/lib/elementary/efl_ui_collection.c
@@ -261,7 +261,7 @@
_efl_ui_collection_efl_ui_single_selectable_last_selected_get(const Eo *obj EINA
}
EOLIAN static Eina_Iterator*
-_efl_ui_collection_efl_ui_multi_selectable_selected_items_get(Eo *obj
EINA_UNUSED, Efl_Ui_Collection_Data *pd)
+_efl_ui_collection_efl_ui_multi_selectable_selected_iterator_new(Eo *obj
EINA_UNUSED, Efl_Ui_Collection_Data *pd)
{
return eina_list_iterator_new(pd->selected);
}
diff --git a/src/lib/elementary/efl_ui_collection.eo
b/src/lib/elementary/efl_ui_collection.eo
index 507477c2bc..28ecb4975d 100644
--- a/src/lib/elementary/efl_ui_collection.eo
+++ b/src/lib/elementary/efl_ui_collection.eo
@@ -24,7 +24,7 @@ class Efl.Ui.Collection extends Efl.Ui.Layout_Base implements
If all items do not fit in the current widget size scrolling facilities
are provided.
Items inside this widget can be selected according to the
@Efl.Ui.Multi_Selectable.select_mode
- policy, and the selection can be retrieved with
@Efl.Ui.Multi_Selectable.selected_items_get.
+ policy, and the selection can be retrieved with
@Efl.Ui.Multi_Selectable.selected_iterator_new.
]]
methods {
item_scroll {
@@ -82,7 +82,7 @@ class Efl.Ui.Collection extends Efl.Ui.Layout_Base implements
Efl.Ui.Widget.focus_state_apply;
Efl.Ui.Focus.Manager.move;
Efl.Ui.Single_Selectable.last_selected { get; }
- Efl.Ui.Multi_Selectable.selected_items_get;
+ Efl.Ui.Multi_Selectable.selected_iterator_new;
Efl.Ui.Multi_Selectable.select_mode {get; set;}
Efl.Ui.Multi_Selectable.all_select;
Efl.Ui.Multi_Selectable.all_unselect;
diff --git a/src/lib/elementary/efl_ui_grid.eo
b/src/lib/elementary/efl_ui_grid.eo
index 72c2bfface..0b8be563df 100644
--- a/src/lib/elementary/efl_ui_grid.eo
+++ b/src/lib/elementary/efl_ui_grid.eo
@@ -8,7 +8,7 @@ class Efl.Ui.Grid extends Efl.Ui.Collection
@Efl.Ui.Layout_Orientable.orientation.
Items inside this widget can be selected according to the
@Efl.Ui.Multi_Selectable.select_mode
- policy, and the selection can be retrieved with
@Efl.Ui.Multi_Selectable.selected_items_get.
+ policy, and the selection can be retrieved with
@Efl.Ui.Multi_Selectable.selected_iterator_new.
@Efl.Ui.Grid supports grouping by using @Efl.Ui.Group_Item objects.
Group headers are displayed at the top of the viewport if items belonging
to the group
diff --git a/src/lib/elementary/efl_ui_list.eo
b/src/lib/elementary/efl_ui_list.eo
index c4481361f6..37173c2e0e 100644
--- a/src/lib/elementary/efl_ui_list.eo
+++ b/src/lib/elementary/efl_ui_list.eo
@@ -8,7 +8,7 @@ class Efl.Ui.List extends Efl.Ui.Collection
@Efl.Ui.Layout_Orientable.orientation.
Items inside this widget can be selected according to the
@Efl.Ui.Multi_Selectable.select_mode
- policy, and the sele
Re: [E-devel] 1.23 delay for two days
Ok, nvm. I found the whole series now. Cheers, dh From: Christopher Michael Sent: Wednesday, September 25, 2019 2:38 PM To: Enlightenment developer list Subject: Re: [E-devel] 1.23 delay for two days "There is the patch series beginning with https://phab.enlightenment.org/D9899 which resolves a regression with running EFL on X without a window manager." I took a look at this, and the patch that is there looks good ... however your comment seems to indicate that this is part of a series, yet I cannot see the rest of the seriesPerhaps they are not uploaded yet ? or perhaps a typo in the email ?? Cheers, dh From: Mike Blumenkrantz Sent: Wednesday, September 25, 2019 12:45 PM To: Enlightenment developer list Subject: Re: [E-devel] 1.23 delay for two days Hi, There are currently patches on phab (which I expect to land in the next few hours) to resolve all of the remaining minor interfaces API-related issues. There are still a number of tasks in progress for MVVM-related items, but if they are not resolved by the end of today then they will be deferred until after the release. There is the patch series beginning with https://phab.enlightenment.org/D9899 which resolves a regression with running EFL on X without a window manager. I've spent about an hour examining https://phab.enlightenment.org/T8260 today to see what can be done, but I'm unable to reproduce it either in the scenario described or the test case that I created. I'm not planning to look into this further. There's a strange issue with the "Efl.Ui.Image_Zoomable animation" case in elm_test where the image is not properly aligned, but this is an issue in elm_test itself as far as I'm aware. This is the only remaining "solvable" issue that I know of which may be worth exploring prior to the release. In summary, at this time I don't see a case where a Friday release could be blocked. It's regrettable that things have not gone as smoothly for this release as they could have, but considering the sheer volume of serious issues which have managed to pop up over the past couple weeks, I'd say we're in better shape than expected. Regards, Mike On Wed, Sep 25, 2019 at 3:36 AM Stefan Schmidt wrote: > Hello. > > [Grumpy mail ahead] > > On 23.09.19 12:06, Stefan Schmidt wrote: > > Hello. > > > > The schedule we planned would have the 1.23 final release today. > > > > This will not happen as we have some ongoing things being handled right > > now that need a delay. The biggest item is the theme API review going on. > > > > We hope that we are in the position to release on Wednesday. You can > > help by looking at the work list I posted and especially the show > > stopper issues still marked open. > > We are definitely not in a position that we can release today. :( > > There have been so many changes coming in the last days it feels like > the floodgates have been opened after the freeze and not like the last > days before a release! I am seriously grumpy right now. > > I understand that many of these things have been worked on for a long > time and the target was always this release. I also have been > communicated most of these things and people have been working hard to > get it working, so please do not take this to personal. > > Still, how are we supposed to release all this just a second after it > has landed? This last minute rush of changes is really not how a release > could work. > > I hope Mike will get out theme stuff under control and the big evas leak > get fixed quickly. > > I will do a beta3 today and cross my finger when looking at it again on > Friday. > > regards > Stefan Schmidt > > > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [core/efl] master 01/01: Revert "elm: add basics test to create a destroy *every* widget with errors"
bu5hm4n pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=6592fefcdd3c3d59b0619d1c1ce3a5d5dd7fadef
commit 6592fefcdd3c3d59b0619d1c1ce3a5d5dd7fadef
Author: Marcel Hollerbach
Date: Wed Sep 25 21:46:54 2019 +0200
Revert "elm: add basics test to create a destroy *every* widget with errors"
This reverts commit 10cdb070180e0f1e62d5b8e5d5164a19fbc51548.
this does not pass on ci ... o.O
---
src/tests/elementary/elm_suite.c | 1 -
src/tests/elementary/elm_suite.h | 1 -
src/tests/elementary/elm_test_widget_basics.c | 137 --
src/tests/elementary/meson.build | 3 +-
4 files changed, 1 insertion(+), 141 deletions(-)
diff --git a/src/tests/elementary/elm_suite.c b/src/tests/elementary/elm_suite.c
index d6aa4636e8..87fac6e4e1 100644
--- a/src/tests/elementary/elm_suite.c
+++ b/src/tests/elementary/elm_suite.c
@@ -86,7 +86,6 @@ static const Efl_Test_Case etc[] = {
{ "elm_code_widget_selection", elm_code_test_widget_selection },
{ "elm_code_widget_undo", elm_code_test_widget_undo },
{ "elm_widget_focus", elm_test_widget_focus},
- { "elm_widget_basics", elm_test_widget_basics},
{ NULL, NULL }
};
diff --git a/src/tests/elementary/elm_suite.h b/src/tests/elementary/elm_suite.h
index 67f5d0d5c4..ba76b29615 100644
--- a/src/tests/elementary/elm_suite.h
+++ b/src/tests/elementary/elm_suite.h
@@ -84,7 +84,6 @@ void elm_test_slideshow(TCase *tc);
void elm_test_spinner(TCase *tc);
void elm_test_plug(TCase *tc);
void elm_test_widget_focus(TCase *tc);
-void elm_test_widget_basics(TCase *tc);
void elm_code_file_test_load(TCase *tc);
void elm_code_file_test_memory(TCase *tc);
diff --git a/src/tests/elementary/elm_test_widget_basics.c
b/src/tests/elementary/elm_test_widget_basics.c
deleted file mode 100644
index e66a9ac149..00
--- a/src/tests/elementary/elm_test_widget_basics.c
+++ /dev/null
@@ -1,137 +0,0 @@
-#ifdef HAVE_CONFIG_H
-# include "elementary_config.h"
-#endif
-
-#include
-#include "elm_suite.h"
-
-typedef struct _Simple_Test_Widget
-{
- Evas_Object* (*constructor)(Evas_Object *win);
- const char *name;
-} Simple_Test_Widget;
-
-
-static const Simple_Test_Widget simple_widgets[] = {
- {elm_flip_add, "flip"},
- {elm_frame_add, "frame"},
- {elm_player_add, "player"},
- {elm_video_add, "video"},
- {elm_ctxpopup_add, "ctxpopup"},
- {elm_fileselector_add, "fileselector"},
- {elm_hoversel_add, "hoversel"},
- {elm_multibuttonentry_add, "multibuttonentry"},
- {elm_naviframe_add, "naviframe"},
- {elm_popup_add, "popup"},
- {elm_actionslider_add, "actionslider"},
- {elm_bg_add, "bg"},
- {elm_box_add, "box"},
- {elm_bubble_add, "bubble"},
- {elm_calendar_add, "calendar"},
- {elm_button_add, "button"},
- {elm_check_add, "check"},
- {elm_clock_add, "clock"},
- {elm_colorselector_add, "colorselector"},
- {elm_conformant_add, "conformant"},
- {elm_dayselector_add, "dayselector"},
- {elm_entry_add, "entry"},
- {elm_flipselector_add, "flipselector"},
- {elm_gengrid_add, "gengrid"},
- {elm_genlist_add, "genlist"},
- {elm_glview_add, "glview"},
- {elm_grid_add, "grid"},
- {elm_hover_add, "hover"},
- {elm_icon_add, "icon"},
- {elm_image_add, "image"},
- {elm_index_add, "index"},
- {elm_label_add, "label"},
- {elm_layout_add, "layout"},
- {elm_list_add, "list"},
- {elm_map_add, "map"},
- {elm_mapbuf_add, "mapbuf"},
- {elm_menu_add, "menu"},
- {elm_notify_add, "notify"},
- {elm_panel_add, "panel"},
- {elm_panes_add, "panes"},
- {elm_photo_add, "photo"},
- {elm_photocam_add, "photocam"},
- {elm_plug_add, "plug"},
- {elm_prefs_add, "prefs"},
- {elm_progressbar_add, "progressbar"},
- {elm_radio_add, "radio"},
- {elm_route_add, "route"},
- {elm_separator_add, "seperator"},
- {elm_slider_add, "slider"},
- {elm_slideshow_add, "slideshow"},
- {elm_spinner_add, "spinner"},
- {elm_table_add, "table"},
- {elm_textpath_add, "textpath"},
- {elm_toolbar_add, "toolbar"},
- {elm_web_add, "web"},
- {elm_diskselector_add, "diskselector"},
- {elm_datetime_add, "datetime"},
- //{elm_combobox_add, "button"}, This is a beta widget which was never public
and is written in a few ways that break basic assertions of widgets base class
- //{elm_thumb_add, "button"}, This dies because of a ethumb bug, where the
log domain is not correctly inited
- //{elm_systray_add, "button"}, This is not a elm widget, but matches the API
regax
- //{elm_factory_add, "button"}, This is a beta widget which was never public
but matches the API regax
- {NULL, NULL},
-};
-
-EFL_START_TEST(elm_test_widget_creation_easy)
-{
- Evas_Object *win, *o;
- win = win_add();
-
- evas_object_resize(win, 200, 200);
- evas_object_show(win);
- for (int i = 0; simple_widgets[i].name; ++i)
- {
-o = simple_widgets[i].constructor(win);
-ck_assert_ptr_nonnull(o);
-evas_object_size_hint_weight_set(o, EVAS_HINT_EXPAND,
EVAS_HINT_EXPAND);
-
[EGIT] [core/efl] master 01/01: efl: improve error message to be really useful.
zmike pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=25cba85a6a060c89d77ac76c63cc1979b6388dbe
commit 25cba85a6a060c89d77ac76c63cc1979b6388dbe
Author: Cedric Bail
Date: Wed Sep 25 15:50:35 2019 -0400
efl: improve error message to be really useful.
Reviewers: zmike, bu5hm4n
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10168
---
src/lib/efl/interfaces/efl_file.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/lib/efl/interfaces/efl_file.c
b/src/lib/efl/interfaces/efl_file.c
index d6f262d3e2..a35710f0f3 100644
--- a/src/lib/efl/interfaces/efl_file.c
+++ b/src/lib/efl/interfaces/efl_file.c
@@ -172,7 +172,11 @@ efl_file_simple_load(Eo *obj, const char *file, const char
*key)
{
EINA_SAFETY_ON_NULL_RETURN_VAL(obj, EINA_FALSE);
efl_ref(obj);
- EINA_SAFETY_ON_TRUE_GOTO(efl_file_set(obj, file), fail);
+ if (efl_file_set(obj, file))
+ {
+EINA_LOG_ERR("File set to '%s' on '%s' failed.", file,
efl_debug_name_get(obj));
+goto fail;
+ }
efl_file_key_set(obj, key);
if (file)
{
--
[EGIT] [core/efl] master 01/01: elm: Avoid maybe unitialized variable accesses
zmike pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=1115752451f8c0095762a407dec08f42a7cbca06
commit 1115752451f8c0095762a407dec08f42a7cbca06
Author: Lauro Moura
Date: Wed Sep 25 16:15:43 2019 -0400
elm: Avoid maybe unitialized variable accesses
Reviewers: cedric, bu5hm4n, zmike, felipealmeida
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10170
---
src/lib/elementary/efl_ui_collection_view.c | 2 +-
src/lib/elementary/efl_ui_layout.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/lib/elementary/efl_ui_collection_view.c
b/src/lib/elementary/efl_ui_collection_view.c
index aa3b9c56d4..a13e69e49a 100644
--- a/src/lib/elementary/efl_ui_collection_view.c
+++ b/src/lib/elementary/efl_ui_collection_view.c
@@ -494,7 +494,7 @@ _entity_fetched_cb(Eo *obj, void *data, const Eina_Value v)
Efl_Ui_Collection_Request *request = data;
Efl_Gfx_Entity *child;
unsigned int i, len;
- uint64_t updated_size_start_id, updated_entity_start_id;
+ uint64_t updated_size_start_id = 0, updated_entity_start_id = 0;
Eina_Bool updated_size = EINA_FALSE, updated_entity = EINA_FALSE;
EINA_VALUE_ARRAY_FOREACH(&v, len, i, child)
diff --git a/src/lib/elementary/efl_ui_layout.c
b/src/lib/elementary/efl_ui_layout.c
index 1797d8a45f..05a9063db1 100644
--- a/src/lib/elementary/efl_ui_layout.c
+++ b/src/lib/elementary/efl_ui_layout.c
@@ -522,7 +522,7 @@ EOLIAN static Eina_Error
_efl_ui_layout_base_efl_ui_widget_theme_apply(Eo *obj, Efl_Ui_Layout_Data *sd)
{
Eina_Error theme_apply_ret, theme_apply_internal_ret;
- Elm_Widget_Smart_Data *wd;
+ Elm_Widget_Smart_Data *wd = NULL;
char buf[64];
static unsigned int version = 0;
--
[EGIT] [core/efl] master 04/08: efl: stabilize Efl.Ui.Factory_Bind
lauromoura pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=c3db2793043b40c943f589ac37ebf60cd3385d4e
commit c3db2793043b40c943f589ac37ebf60cd3385d4e
Author: Cedric Bail
Date: Wed Sep 25 11:59:45 2019 -0300
efl: stabilize Efl.Ui.Factory_Bind
Summary:
T8264
Depends on D10134
Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura,
felipealmeida
Reviewed By: SanghyeonLee
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7885
Differential Revision: https://phab.enlightenment.org/D10135
---
src/lib/efl/interfaces/efl_ui_factory_bind.eo | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/efl/interfaces/efl_ui_factory_bind.eo
b/src/lib/efl/interfaces/efl_ui_factory_bind.eo
index 740c627b82..f924073954 100644
--- a/src/lib/efl/interfaces/efl_ui_factory_bind.eo
+++ b/src/lib/efl/interfaces/efl_ui_factory_bind.eo
@@ -1,4 +1,4 @@
-interface @beta Efl.Ui.Factory_Bind
+interface Efl.Ui.Factory_Bind
{
[[Efl UI Property interface.
view object can have @Efl.Model and need to set cotent with those model
stored data.
--
[EGIT] [core/efl] master 08/08: ecore: stabilize Efl.Loop_Model
lauromoura pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=a55580ab27d268af8c559edd762cdf09ba31fbf8
commit a55580ab27d268af8c559edd762cdf09ba31fbf8
Author: Cedric Bail
Date: Wed Sep 25 12:05:38 2019 -0300
ecore: stabilize Efl.Loop_Model
Summary:
T8270
Depends on D10138
Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura,
felipealmeida
Reviewed By: SanghyeonLee
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7885
Differential Revision: https://phab.enlightenment.org/D10139
---
src/lib/ecore/efl_loop_model.eo | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/ecore/efl_loop_model.eo b/src/lib/ecore/efl_loop_model.eo
index 3a15490fce..ec2488e4fd 100644
--- a/src/lib/ecore/efl_loop_model.eo
+++ b/src/lib/ecore/efl_loop_model.eo
@@ -1,4 +1,4 @@
-abstract @beta Efl.Loop_Model extends Efl.Loop_Consumer implements Efl.Model
+abstract Efl.Loop_Model extends Efl.Loop_Consumer implements Efl.Model
{
data: null;
methods {
--
[EGIT] [core/efl] master 02/08: efl: stabilize Efl.Ui.Factory.
lauromoura pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=bf1f7cfab78b408bc015dca299bdcef6b1776ea3
commit bf1f7cfab78b408bc015dca299bdcef6b1776ea3
Author: Cedric Bail
Date: Wed Sep 25 11:55:30 2019 -0300
efl: stabilize Efl.Ui.Factory.
Summary:
T8262
Depends on D10132
Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura,
felipealmeida
Reviewed By: SanghyeonLee
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7885
Differential Revision: https://phab.enlightenment.org/D10133
---
src/lib/efl/interfaces/efl_ui_factory.eo | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/lib/efl/interfaces/efl_ui_factory.eo
b/src/lib/efl/interfaces/efl_ui_factory.eo
index b0518a0755..61d0ce961e 100644
--- a/src/lib/efl/interfaces/efl_ui_factory.eo
+++ b/src/lib/efl/interfaces/efl_ui_factory.eo
@@ -1,10 +1,10 @@
-struct @beta Efl.Ui.Factory_Item_Created_Event {
+struct Efl.Ui.Factory_Item_Created_Event {
[[EFL UI Factory event structure provided when an item was just created.]]
model: Efl.Model; [[The model already set on the new item.]]
item: Efl.Gfx.Entity; [[The item that was just created.]]
}
-interface @beta Efl.Ui.Factory extends Efl.Ui.Property_Bind,
Efl.Ui.Factory_Bind
+interface Efl.Ui.Factory extends Efl.Ui.Property_Bind, Efl.Ui.Factory_Bind
{
[[Interface for factory-pattern object creation.
--
[EGIT] [core/efl] master 06/08: elementary: stabilize Efl.Ui.View_Model
lauromoura pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=4473483503813a3ae79b88cd9d47fa1edfcde9ee
commit 4473483503813a3ae79b88cd9d47fa1edfcde9ee
Author: Cedric Bail
Date: Wed Sep 25 12:02:14 2019 -0300
elementary: stabilize Efl.Ui.View_Model
Summary:
T8268
Depends on D10136
Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura,
felipealmeida
Reviewed By: SanghyeonLee
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7885
Differential Revision: https://phab.enlightenment.org/D10137
---
src/lib/elementary/efl_ui_view_model.eo | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/lib/elementary/efl_ui_view_model.eo
b/src/lib/elementary/efl_ui_view_model.eo
index a5caaa8d1c..ebc25dd342 100644
--- a/src/lib/elementary/efl_ui_view_model.eo
+++ b/src/lib/elementary/efl_ui_view_model.eo
@@ -17,7 +17,7 @@ function @beta EflUiViewModelPropertySet {
return: future; [[The value that was finally set.]]
};
-class @beta Efl.Ui.View_Model extends Efl.Composite_Model
+class Efl.Ui.View_Model extends Efl.Composite_Model
{
[[Efl model providing helpers for custom properties used when linking a
model to a view and you need to
generate/adapt values for display.
@@ -60,7 +60,7 @@ class @beta Efl.Ui.View_Model extends Efl.Composite_Model
}
return: Eina.Error;
}
- property_logic_add {
+ property_logic_add @beta {
[[Add callbacks that will be triggered when someone ask for the
specified property name when getting or
setting a property.
@@ -79,7 +79,7 @@ class @beta Efl.Ui.View_Model extends Efl.Composite_Model
}
return: Eina.Error;
}
- property_logic_del {
+ property_logic_del @beta {
[[Delete previously added callbacks that were triggered when someone
asked for the specified property name
when getting or setting a property.
--
[EGIT] [core/efl] master 01/08: elementary: stabilize Efl.Ui.Widget_Factory.
lauromoura pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=31b99e67c475e7687dbed64514e1692f552506e8
commit 31b99e67c475e7687dbed64514e1692f552506e8
Author: Cedric Bail
Date: Wed Sep 25 11:45:38 2019 -0300
elementary: stabilize Efl.Ui.Widget_Factory.
Summary:
T8271
Depends on D10130
Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura,
felipealmeida
Reviewed By: SanghyeonLee
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7885
Differential Revision: https://phab.enlightenment.org/D10131
---
src/lib/elementary/efl_ui_widget_factory.eo | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/elementary/efl_ui_widget_factory.eo
b/src/lib/elementary/efl_ui_widget_factory.eo
index 7cdfab2887..47367b395c 100644
--- a/src/lib/elementary/efl_ui_widget_factory.eo
+++ b/src/lib/elementary/efl_ui_widget_factory.eo
@@ -1,4 +1,4 @@
-class @beta Efl.Ui.Widget_Factory extends Efl.Loop_Consumer implements
Efl.Ui.Factory, Efl.Part
+class Efl.Ui.Widget_Factory extends Efl.Loop_Consumer implements
Efl.Ui.Factory, Efl.Part
{
[[Efl Ui Factory that provides @Efl.Ui.Widget.
--
[EGIT] [core/efl] master 05/08: efl: stabilize Efl.Model
lauromoura pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=2078fe00e07e7e86f2c784e8b676cbfdfa697ea4
commit 2078fe00e07e7e86f2c784e8b676cbfdfa697ea4
Author: Cedric Bail
Date: Wed Sep 25 12:00:28 2019 -0300
efl: stabilize Efl.Model
Summary:
T8267
Depends on D10135
Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura,
felipealmeida
Reviewed By: SanghyeonLee
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7885
Differential Revision: https://phab.enlightenment.org/D10136
---
src/lib/efl/interfaces/efl_model.eo | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/lib/efl/interfaces/efl_model.eo
b/src/lib/efl/interfaces/efl_model.eo
index 5713df6dc4..477e9e10b5 100644
--- a/src/lib/efl/interfaces/efl_model.eo
+++ b/src/lib/efl/interfaces/efl_model.eo
@@ -1,4 +1,4 @@
-struct @beta Efl.Model_Property_Event {
+struct Efl.Model_Property_Event {
[[EFL model property event data structure]]
changed_properties: array; [[List of changed properties]]
invalidated_properties: array; [[Removed properties
identified by name]]
@@ -13,7 +13,7 @@ struct @beta Efl.Model_Children_Event {
the parent, it will be available here.]]
}
-interface @beta Efl.Model
+interface Efl.Model
{
[[Basic Model abstraction.
@@ -178,8 +178,8 @@ interface @beta Efl.Model
properties,changed: Efl.Model_Property_Event; [[Event dispatched when
properties list is
available.]]
- child,added: Efl.Model_Children_Event; [[Event dispatched when new child
is added.]]
- child,removed: Efl.Model_Children_Event; [[Event dispatched when child
is removed.]]
+ child,added @beta: Efl.Model_Children_Event; [[Event dispatched when new
child is added.]]
+ child,removed @beta: Efl.Model_Children_Event; [[Event dispatched when
child is removed.]]
children,count,changed: void; [[Event dispatched when children count is
finished.]]
}
}
--
[EGIT] [core/efl] master 07/08: ecore: stabilize Efl.Composite_Model.
lauromoura pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=acb314fb1dade1cc37b2a2025da928cf5b338940
commit acb314fb1dade1cc37b2a2025da928cf5b338940
Author: Cedric Bail
Date: Wed Sep 25 12:03:27 2019 -0300
ecore: stabilize Efl.Composite_Model.
Summary: Depends on D10137
Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura,
felipealmeida
Reviewed By: SanghyeonLee
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7885
Differential Revision: https://phab.enlightenment.org/D10138
---
src/lib/ecore/efl_composite_model.eo | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/ecore/efl_composite_model.eo
b/src/lib/ecore/efl_composite_model.eo
index 4244e930bc..34c2e203d4 100644
--- a/src/lib/ecore/efl_composite_model.eo
+++ b/src/lib/ecore/efl_composite_model.eo
@@ -1,4 +1,4 @@
-class @beta Efl.Composite_Model extends Efl.Loop_Model implements Efl.Ui.View
+class Efl.Composite_Model extends Efl.Loop_Model implements Efl.Ui.View
{
[[Efl model for all composite class which provide a unified API to set
source of data.
--
[EGIT] [core/efl] master 03/08: efl: stabilize Efl.Ui.Property_Bind
lauromoura pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=31dda961147428b609c7d82735911a9ec1737c62
commit 31dda961147428b609c7d82735911a9ec1737c62
Author: Cedric Bail
Date: Wed Sep 25 11:56:54 2019 -0300
efl: stabilize Efl.Ui.Property_Bind
Summary:
T7579
Depends on D10133
Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura,
felipealmeida
Reviewed By: SanghyeonLee
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7885
Differential Revision: https://phab.enlightenment.org/D10134
---
src/lib/efl/interfaces/efl_ui_property_bind.eo | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/efl/interfaces/efl_ui_property_bind.eo
b/src/lib/efl/interfaces/efl_ui_property_bind.eo
index 31d66e0134..aafd772e58 100644
--- a/src/lib/efl/interfaces/efl_ui_property_bind.eo
+++ b/src/lib/efl/interfaces/efl_ui_property_bind.eo
@@ -6,7 +6,7 @@ struct Efl.Ui.Property_Event {
changed_properties: array; [[List of changed properties]]
}
-interface @beta Efl.Ui.Property_Bind
+interface Efl.Ui.Property_Bind
{
[[Efl UI Property_Bind interface.
view object can have @Efl.Model to manage the data,
--
[EGIT] [core/efl] master 13/15: api: mark efl.gfx.image and related types stable
zmike pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=8e17112c76fce8d28e4b153d368461b742ee815f
commit 8e17112c76fce8d28e4b153d368461b742ee815f
Author: Mike Blumenkrantz
Date: Wed Sep 25 17:56:29 2019 -0400
api: mark efl.gfx.image and related types stable
Summary:
fix T7875
fix T7926
fix T7927
fix T7926
fix T7929
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl_api
Maniphest Tasks: T7929, T7927, T7926, T7875
Differential Revision: https://phab.enlightenment.org/D10124
---
src/lib/efl/interfaces/efl_gfx_image.eo | 8
src/lib/efl/interfaces/efl_gfx_types.eot | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/lib/efl/interfaces/efl_gfx_image.eo
b/src/lib/efl/interfaces/efl_gfx_image.eo
index b9ccac41ea..b89c051f80 100644
--- a/src/lib/efl/interfaces/efl_gfx_image.eo
+++ b/src/lib/efl/interfaces/efl_gfx_image.eo
@@ -1,7 +1,7 @@
import efl_gfx_types;
import eina_types;
-enum @beta Efl.Gfx.Image_Content_Hint
+enum Efl.Gfx.Image_Content_Hint
{
[[How an image's data is to be treated by EFL, for optimization.]]
none = 0,[[No hint on the content (default).]]
@@ -9,7 +9,7 @@ enum @beta Efl.Gfx.Image_Content_Hint
static = 2 [[The content won't change over time.]]
}
-enum @beta Efl.Gfx.Image_Scale_Hint
+enum Efl.Gfx.Image_Scale_Hint
{
/* FIXME: Legacy is in Emile, where it does not belong. */
[[How an image's data is to be treated by EFL, with regard to scaling
cache.]]
@@ -18,7 +18,7 @@ enum @beta Efl.Gfx.Image_Scale_Hint
static = 2 [[Image will not be re-scaled over time, thus turning scaling
cache ON for its data.]]
}
-enum @beta Efl.Gfx.Image_Scale_Method
+enum Efl.Gfx.Image_Scale_Method
{
[[Enumeration that defines scaling methods to be used when rendering an
image.]]
none,[[Use the image's natural size.]]
@@ -58,7 +58,7 @@ struct Efl.Gfx.Image_Stretch_Region
length: uint; [[Length of the stretchable region in pixels.]]
}
-interface @beta Efl.Gfx.Image
+interface Efl.Gfx.Image
{
[[This interface defines a set of common APIs which should be implemented
by image objects.
diff --git a/src/lib/efl/interfaces/efl_gfx_types.eot
b/src/lib/efl/interfaces/efl_gfx_types.eot
index 2e14ae9732..2a4e66841c 100644
--- a/src/lib/efl/interfaces/efl_gfx_types.eot
+++ b/src/lib/efl/interfaces/efl_gfx_types.eot
@@ -152,7 +152,7 @@ enum @beta Efl.Gfx.Vg_Composite_Method
mask_difference
}
-enum @beta Efl.Gfx.Center_Fill_Mode
+enum Efl.Gfx.Center_Fill_Mode
{
[[How an image's center region (the complement to the border region) should
be rendered by EFL]]
none = 0, [[Image's center region is $not to be rendered]]
--
[EGIT] [core/efl] master 14/15: api: mark Efl.Gfx.Image_Load_Controller stable
zmike pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=b59c00864c1e549ae9ebf94e58a892a3edf36d19
commit b59c00864c1e549ae9ebf94e58a892a3edf36d19
Author: Mike Blumenkrantz
Date: Wed Sep 25 17:56:33 2019 -0400
api: mark Efl.Gfx.Image_Load_Controller stable
Summary:
fix T7876
Depends on D10124
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl_api
Maniphest Tasks: T7876
Differential Revision: https://phab.enlightenment.org/D10125
---
src/lib/efl/interfaces/efl_gfx_image_load_controller.eo | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/efl/interfaces/efl_gfx_image_load_controller.eo
b/src/lib/efl/interfaces/efl_gfx_image_load_controller.eo
index c088b776d4..8f6164760f 100644
--- a/src/lib/efl/interfaces/efl_gfx_image_load_controller.eo
+++ b/src/lib/efl/interfaces/efl_gfx_image_load_controller.eo
@@ -13,7 +13,7 @@ enum @beta Efl.Gfx.Image_Load_Controller_State
}
*/
-interface @beta Efl.Gfx.Image_Load_Controller
+interface Efl.Gfx.Image_Load_Controller
{
[[Common APIs for all loadable 2D images.]]
--
[EGIT] [core/efl] master 06/15: theme: use more explicit signal names for C -> theme scrollbar signals
zmike pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=ab8306135c584eec65b7eafcbc8cd3a3e190921f
commit ab8306135c584eec65b7eafcbc8cd3a3e190921f
Author: Mike Blumenkrantz
Date: Wed Sep 25 17:55:45 2019 -0400
theme: use more explicit signal names for C -> theme scrollbar signals
Summary:
ref T8231
Depends on D10159
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10160
---
data/elementary/themes/edc/efl/scroller.edc | 8
src/lib/elementary/efl_ui_image_zoomable.c | 8
src/lib/elementary/efl_ui_scroll_util.c | 8
3 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/data/elementary/themes/edc/efl/scroller.edc
b/data/elementary/themes/edc/efl/scroller.edc
index 8ab02628d8..aba12ffbc4 100644
--- a/data/elementary/themes/edc/efl/scroller.edc
+++ b/data/elementary/themes/edc/efl/scroller.edc
@@ -301,7 +301,7 @@ group { name: "efl/scroller";
}
}
program {
- signal: "efl,vbar,visible,on"; source: "efl";
+ signal: "efl,vertical_bar,visible,on"; source: "efl";
action: STATE_SET "default" 0.0;
target: "sb_vbar";
target: "sb_vbar_show";
@@ -316,7 +316,7 @@ group { name: "efl/scroller";
target: "arrow2_vbar_indent";
}
program {
- signal: "efl,vbar,visible,off"; source: "efl";
+ signal: "efl,vertical_bar,visible,off"; source: "efl";
action: STATE_SET "hidden" 0.0;
target: "sb_vbar";
target: "sb_vbar_show";
@@ -568,7 +568,7 @@ group { name: "efl/scroller";
}
}
program {
- signal: "efl,hbar,visible,on"; source: "efl";
+ signal: "efl,horizontal_bar,visible,on"; source: "efl";
action: STATE_SET "default" 0.0;
target: "sb_hbar";
target: "sb_hbar_show";
@@ -583,7 +583,7 @@ group { name: "efl/scroller";
target: "arrow2_hbar_indent";
}
program {
- signal: "efl,hbar,visible,off"; source: "efl";
+ signal: "efl,horizontal_bar,visible,off"; source: "efl";
action: STATE_SET "hidden" 0.0;
target: "sb_hbar";
target: "sb_hbar_show";
diff --git a/src/lib/elementary/efl_ui_image_zoomable.c
b/src/lib/elementary/efl_ui_image_zoomable.c
index a08a72ca8a..1967c93bc4 100644
--- a/src/lib/elementary/efl_ui_image_zoomable.c
+++ b/src/lib/elementary/efl_ui_image_zoomable.c
@@ -1550,9 +1550,9 @@ _efl_ui_image_zoomable_bar_show_cb(void *data, const
Efl_Event *event)
else
{
if (type == EFL_UI_LAYOUT_ORIENTATION_HORIZONTAL)
- edje_object_signal_emit(wd->resize_obj, "efl,hbar,visible,on",
"efl");
+ edje_object_signal_emit(wd->resize_obj,
"efl,horizontal_bar,visible,on", "efl");
else if (type == EFL_UI_LAYOUT_ORIENTATION_VERTICAL)
- edje_object_signal_emit(wd->resize_obj, "efl,vbar,visible,on",
"efl");
+ edje_object_signal_emit(wd->resize_obj,
"efl,vertical_bar,visible,on", "efl");
}
}
@@ -1573,9 +1573,9 @@ _efl_ui_image_zoomable_bar_hide_cb(void *data, const
Efl_Event *event)
else
{
if (type == EFL_UI_LAYOUT_ORIENTATION_HORIZONTAL)
- edje_object_signal_emit(wd->resize_obj, "efl,hbar,visible,off",
"efl");
+ edje_object_signal_emit(wd->resize_obj,
"efl,horizontal_bar,visible,off", "efl");
else if (type == EFL_UI_LAYOUT_ORIENTATION_VERTICAL)
- edje_object_signal_emit(wd->resize_obj, "efl,vbar,visible,off",
"efl");
+ edje_object_signal_emit(wd->resize_obj,
"efl,vertical_bar,visible,off", "efl");
}
}
diff --git a/src/lib/elementary/efl_ui_scroll_util.c
b/src/lib/elementary/efl_ui_scroll_util.c
index 019b68dbfb..fba8ecdfd0 100644
--- a/src/lib/elementary/efl_ui_scroll_util.c
+++ b/src/lib/elementary/efl_ui_scroll_util.c
@@ -227,9 +227,9 @@ _scroll_connector_bar_show_cb(void *data, const Efl_Event
*event)
Efl_Ui_Layout_Orientation type = *(Efl_Ui_Layout_Orientation
*)(event->info);
if (type == EFL_UI_LAYOUT_ORIENTATION_HORIZONTAL)
- efl_layout_signal_emit(wd->resize_obj, "efl,hbar,visible,on", "efl");
+ efl_layout_signal_emit(wd->resize_obj, "efl,horizontal_bar,visible,on",
"efl");
else if (type == EFL_UI_LAYOUT_ORIENTATION_VERTICAL)
- efl_layout_signal_emit(wd->resize_obj, "efl,vbar,visible,on", "efl");
+ efl_layout_signal_emit(wd->resize_obj, "efl,vertical_bar,visible,on",
"efl");
}
static void
@@ -240,9 +240,9 @@ _scroll_connector_bar_hide_cb(void *data, const Efl_Event
*event)
Efl_Ui_Layout_Orientation type = *(Efl_Ui_Layout_Orientation
*)(event->info);
if (type == EFL_UI_LAYOUT_ORIENTATION_HORIZONTAL)
- efl_layout_signal_emit(wd->resize_obj, "efl,hbar,visible
[EGIT] [core/efl] master 15/15: api: mark Efl.Ui.Image_Zoomable stable
zmike pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=593b7426ae230b628a25450c352556f21a29399c
commit 593b7426ae230b628a25450c352556f21a29399c
Author: Mike Blumenkrantz
Date: Wed Sep 25 17:56:38 2019 -0400
api: mark Efl.Ui.Image_Zoomable stable
Summary:
ref T7875
Depends on D10125
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl_api
Maniphest Tasks: T7875
Differential Revision: https://phab.enlightenment.org/D10126
---
src/lib/elementary/efl_ui_image_zoomable.eo | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/elementary/efl_ui_image_zoomable.eo
b/src/lib/elementary/efl_ui_image_zoomable.eo
index 945cfaba04..d5443b54f8 100644
--- a/src/lib/elementary/efl_ui_image_zoomable.eo
+++ b/src/lib/elementary/efl_ui_image_zoomable.eo
@@ -2,7 +2,7 @@
struct @extern Elm.Photocam.Error; [[Photocam error information.]]
struct @extern Elm.Photocam.Progress; [[Photocam progress information.]]
-class @beta Efl.Ui.Image_Zoomable extends Efl.Ui.Image implements Efl.Ui.Zoom
+class Efl.Ui.Image_Zoomable extends Efl.Ui.Image implements Efl.Ui.Zoom
composites Efl.Ui.Scrollable, Efl.Ui.Scrollbar
{
[[Elementary Image Zoomable class]]
--
[EGIT] [core/efl] master 03/15: efl_ui/layout: add mechanism for deferring versioned theme signals
zmike pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=f24ce654c0c20ac77644e2021e2271ec6c58c67f
commit f24ce654c0c20ac77644e2021e2271ec6c58c67f
Author: Mike Blumenkrantz
Date: Wed Sep 25 17:55:29 2019 -0400
efl_ui/layout: add mechanism for deferring versioned theme signals
Summary:
the theme version isn't available until the theme has been applied, so
we can create an array of all the pending signals and defer them until
such time as we get a theme or destroy the object
this is internal and can be reworked at a later time as needed
ref T8231
Depends on D10157
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10164
---
src/lib/elementary/efl_ui_layout.c | 46 ++
src/lib/elementary/elm_widget_layout.h | 1 +
2 files changed, 47 insertions(+)
diff --git a/src/lib/elementary/efl_ui_layout.c
b/src/lib/elementary/efl_ui_layout.c
index 05a9063db1..2d73dee6f0 100644
--- a/src/lib/elementary/efl_ui_layout.c
+++ b/src/lib/elementary/efl_ui_layout.c
@@ -70,6 +70,13 @@ static const char *_efl_ui_layout_swallow_parts[] = {
NULL
};
+typedef struct _Deferred_Version_Signal
+{
+ Eina_Stringshare *old_sig;
+ Eina_Stringshare *new_sig;
+ unsigned int version_threshold;
+} Deferred_Version_Signal;
+
typedef struct _Efl_Ui_Layout_Factory_Tracking Efl_Ui_Layout_Factory_Tracking;
struct _Efl_Ui_Layout_Factory_Tracking
@@ -222,6 +229,19 @@ _efl_ui_layout_subobjs_calc_set(Eo *obj, Eina_Bool set)
sd->calc_subobjs = !!set;
}
+static void
+_defer_version_signal(Efl_Ui_Layout_Data *sd, Eina_Stringshare *old_sig,
Eina_Stringshare *new_sig, unsigned int version_threshold)
+{
+ Deferred_Version_Signal dvs;
+ if (!sd->deferred_signals)
+ sd->deferred_signals = eina_inarray_new(sizeof(Deferred_Version_Signal),
5);
+ EINA_SAFETY_ON_NULL_RETURN(sd->deferred_signals);
+ dvs.old_sig = old_sig;
+ dvs.new_sig = new_sig;
+ dvs.version_threshold = version_threshold;
+ eina_inarray_push(sd->deferred_signals, &dvs);
+}
+
/* common content cases for layout objects: icon and text */
static inline void
_signals_emit(Eo *obj,
@@ -563,6 +583,21 @@ _efl_ui_layout_base_efl_ui_widget_theme_apply(Eo *obj,
Efl_Ui_Layout_Data *sd)
}
}
}
+ if (sd->deferred_signals)
+ {
+do
+ {
+ Deferred_Version_Signal *dvs =
eina_inarray_pop(sd->deferred_signals);
+
+ if (sd->version < dvs->version_threshold)
+ efl_layout_signal_emit(sd->obj, dvs->old_sig, "efl");
+ else
+ efl_layout_signal_emit(sd->obj, dvs->new_sig, "efl");
+ eina_stringshare_del(dvs->old_sig);
+ eina_stringshare_del(dvs->new_sig);
+ } while (eina_inarray_count(sd->deferred_signals));
+ELM_SAFE_FREE(sd->deferred_signals, eina_inarray_free);
+ }
if (!version)
{
snprintf(buf, sizeof(buf), "%d%d", EFL_VERSION_MAJOR,
EFL_VERSION_MINOR);
@@ -903,6 +938,17 @@ _efl_ui_layout_base_efl_canvas_group_group_del(Eo *obj,
Efl_Ui_Layout_Data *sd)
sd->connect.signals = NULL;
eina_hash_free(sd->connect.factories);
sd->connect.factories = NULL;
+ if (sd->deferred_signals)
+ {
+do
+ {
+ Deferred_Version_Signal *dvs =
eina_inarray_pop(sd->deferred_signals);
+
+ eina_stringshare_del(dvs->old_sig);
+ eina_stringshare_del(dvs->new_sig);
+ } while (eina_inarray_count(sd->deferred_signals));
+ELM_SAFE_FREE(sd->deferred_signals, eina_inarray_free);
+ }
/* let's make our Edje object the *last* to be processed, since it
* may (smart) parent other sub objects here */
diff --git a/src/lib/elementary/elm_widget_layout.h
b/src/lib/elementary/elm_widget_layout.h
index 5e411eb4c5..299fdc11a6 100644
--- a/src/lib/elementary/elm_widget_layout.h
+++ b/src/lib/elementary/elm_widget_layout.h
@@ -53,6 +53,7 @@ typedef struct _Efl_Ui_Layout_Data
Eina_List*subs; /**< List of Elm_Layout_Sub_Object_Data
structs, to hold the actual sub objects such as text, content and the children
of box and table. */
Eina_List*edje_signals; /**< The list of edje signal callbacks.
*/
Eina_List*parts_cursors; /**< The list of cursor names of
layout parts. This is a list of Elm_Layout_Sub_Object_Cursor struct. */
+ Eina_Inarray *deferred_signals; /**< signals which were generated
during construction */
struct {
Eina_Hash *properties; /**< The list of properties connected to
layout parts. */
--
[EGIT] [core/efl] master 09/15: theme: remove unused scroller group
zmike pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=ecd3d2723b79c4e03695f07c203f347ca8c832f4
commit ecd3d2723b79c4e03695f07c203f347ca8c832f4
Author: Mike Blumenkrantz
Date: Wed Sep 25 17:56:01 2019 -0400
theme: remove unused scroller group
Summary:
this is just copied from legacy but not used for anything
ref T8231
Depends on D10162
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10163
---
data/elementary/themes/edc/efl/scroller.edc | 53 -
1 file changed, 53 deletions(-)
diff --git a/data/elementary/themes/edc/efl/scroller.edc
b/data/elementary/themes/edc/efl/scroller.edc
index 6e2769fdae..478a973639 100644
--- a/data/elementary/themes/edc/efl/scroller.edc
+++ b/data/elementary/themes/edc/efl/scroller.edc
@@ -1193,56 +1193,3 @@ group { name: "efl/scroller:popup/no_inset_shadow";
}
}
}
-
-group { name: "efl/scroller/contents";
- data.item: "version" "123";
- parts {
- part { name: "efl.content"; required;
- type: SWALLOW;
- description { state: "default" 0.0;
- }
- }
- part { name: "efl.content_r"; required;
- type: SWALLOW;
- description { state: "default" 0.0;
-fixed: 1 1;
-rel1 {
-relative: 1.0 0.0;
-to: "efl.content";
-}
-rel2 {
-relative: 2.0 1.0;
-to: "efl.content";
-}
- }
- }
- part { name: "efl.content_b"; required;
- type: SWALLOW;
- description { state: "default" 0.0;
-fixed: 1 1;
-rel1 {
-relative: 0.0 1.0;
-to: "efl.content";
-}
-rel2 {
-relative: 1.0 2.0;
-to: "efl.content";
-}
- }
- }
- part { name: "efl.content_rb"; required;
- type: SWALLOW;
- description { state: "default" 0.0;
-fixed: 1 1;
-rel1 {
-relative: 1.0 1.0;
-to: "efl.content";
-}
-rel2 {
-relative: 2.0 2.0;
-to: "efl.content";
-}
- }
- }
- }
-}
--
[EGIT] [core/efl] master 07/15: theme: efl, action, clicked -> efl, action, click
zmike pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=edab064de9af47c9b8b2bbdece73ad2ecbc88063
commit edab064de9af47c9b8b2bbdece73ad2ecbc88063
Author: Mike Blumenkrantz
Date: Wed Sep 25 17:55:50 2019 -0400
theme: efl,action,clicked -> efl,action,click
Summary:
action signals should infinitives
ref T8231
Depends on D10160
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10161
---
data/elementary/themes/edc/efl/popup.edc | 2 +-
src/lib/elementary/efl_ui_popup.c| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/data/elementary/themes/edc/efl/popup.edc
b/data/elementary/themes/edc/efl/popup.edc
index 44557dc944..c67eabc932 100644
--- a/data/elementary/themes/edc/efl/popup.edc
+++ b/data/elementary/themes/edc/efl/popup.edc
@@ -170,7 +170,7 @@ group { "efl/popup/backwall"; data.item: "version" "123";
}
program {
signal: "mouse,clicked,1"; source: "block";
- action: SIGNAL_EMIT "efl,action,clicked" "efl";
+ action: SIGNAL_EMIT "efl,action,click" "efl";
}
}
}
diff --git a/src/lib/elementary/efl_ui_popup.c
b/src/lib/elementary/efl_ui_popup.c
index b4d1226465..edf71073aa 100644
--- a/src/lib/elementary/efl_ui_popup.c
+++ b/src/lib/elementary/efl_ui_popup.c
@@ -554,7 +554,7 @@ _efl_ui_popup_efl_object_constructor(Eo *obj,
Efl_Ui_Popup_Data *pd)
evas_object_smart_member_add(pd->backwall, obj);
evas_object_stack_below(pd->backwall, wd->resize_obj);
- edje_object_signal_callback_add(pd->backwall, "efl,action,clicked", "*",
+ edje_object_signal_callback_add(pd->backwall, "efl,action,click", "*",
_backwall_clicked_cb, obj);
pd->align = EFL_UI_POPUP_ALIGN_CENTER;
--
[EGIT] [core/efl] master 05/15: theme: use 'visible' style signals for spin_button button/entry visibility
zmike pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=41f37c328ee9dca9a252ac5a81683c2a496d28a0
commit 41f37c328ee9dca9a252ac5a81683c2a496d28a0
Author: Mike Blumenkrantz
Date: Wed Sep 25 17:55:40 2019 -0400
theme: use 'visible' style signals for spin_button button/entry visibility
Summary:
ref T8231
Depends on D10158
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10159
---
data/elementary/themes/edc/efl/datepicker.edc | 8
data/elementary/themes/edc/efl/spin_button.edc | 8
src/lib/elementary/efl_ui_spin_button.c| 8
3 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/data/elementary/themes/edc/efl/datepicker.edc
b/data/elementary/themes/edc/efl/datepicker.edc
index a0c23597c2..cc913e253b 100644
--- a/data/elementary/themes/edc/efl/datepicker.edc
+++ b/data/elementary/themes/edc/efl/datepicker.edc
@@ -282,25 +282,25 @@ group { "efl/datepicker/spin_button"; data.item:
"version" "123";
}
programs {
program { "entry_active";
- signal: "efl,state,entry,active";
+ signal: "efl,entry,visible,on";
source: "efl";
action: STATE_SET "active";
target: "efl.entry";
}
program { "entry_inactive";
- signal: "efl,state,entry,inactive";
+ signal: "efl,entry,visible,off";
source: "efl";
action: STATE_SET "default";
target: "efl.entry";
}
program { "text_button_active";
- signal: "efl,state,button,active";
+ signal: "efl,button,visible,on";
source: "efl";
action: STATE_SET "default";
target: "efl.text_button";
}
program { "text_button_inactive";
- signal: "efl,state,button,inactive";
+ signal: "efl,button,visible,off";
source: "efl";
action: STATE_SET "inactive";
target: "efl.text_button";
diff --git a/data/elementary/themes/edc/efl/spin_button.edc
b/data/elementary/themes/edc/efl/spin_button.edc
index 91dff76c20..5008295218 100644
--- a/data/elementary/themes/edc/efl/spin_button.edc
+++ b/data/elementary/themes/edc/efl/spin_button.edc
@@ -101,25 +101,25 @@ group { "efl/spin_button/horizontal";
}
programs {
program { "entry_active";
- signal: "efl,state,entry,active";
+ signal: "efl,entry,visible,on";
source: "efl";
action: STATE_SET "active";
target: "efl.entry";
}
program { "entry_inactive";
- signal: "efl,state,entry,inactive";
+ signal: "efl,entry,visible,off";
source: "efl";
action: STATE_SET "default";
target: "efl.entry";
}
program { "text_button_active";
- signal: "efl,state,button,active";
+ signal: "efl,button,visible,on";
source: "efl";
action: STATE_SET "default";
target: "efl.text_button";
}
program { "text_button_inactive";
- signal: "efl,state,button,inactive";
+ signal: "efl,button,visible,off";
source: "efl";
action: STATE_SET "inactive";
target: "efl.text_button";
diff --git a/src/lib/elementary/efl_ui_spin_button.c
b/src/lib/elementary/efl_ui_spin_button.c
index a4c9122822..bbfd7d7286 100644
--- a/src/lib/elementary/efl_ui_spin_button.c
+++ b/src/lib/elementary/efl_ui_spin_button.c
@@ -167,8 +167,8 @@ _entry_hide(Evas_Object *obj)
{
Efl_Ui_Spin_Button_Data *sd = efl_data_scope_get(obj, MY_CLASS);
- efl_layout_signal_emit(obj, "efl,state,button,active", "efl");
- efl_layout_signal_emit(obj, "efl,state,entry,inactive", "efl");
+ efl_layout_signal_emit(obj, "efl,button,visible,on", "efl");
+ efl_layout_signal_emit(obj, "efl,entry,visible,off", "efl");
if (sd->entry_visible && !evas_focus_state_get(evas_object_evas_get(obj)))
sd->entry_reactivate = EINA_TRUE;
@@ -343,7 +343,7 @@ _entry_show_cb(void *data,
elm_object_focus_set(obj, EINA_TRUE);
elm_entry_select_all(obj);
sd->entry_visible = EINA_TRUE;
- efl_layout_signal_emit(data, "efl,state,button,inactive", "efl");
+ efl_layout_signal_emit(data, "efl,button,visible,off", "efl");
}
static void
@@ -378,7 +378,7 @@ _toggle_entry(Evas_Object *obj)
efl_event_callback_add(sd->ent,
EFL_UI_FOCUS_OBJECT_EVENT_FOCUS_CHANGED,
_entry_focus_changed_cb, obj);
sd->entry_visible = EINA_TRUE;
-efl_layout_signal_emit(obj, "efl,state,entry,active", "efl");
+efl_layout_signal_emit(obj, "efl,entry,visible,on", "efl");
{
Eina_List *items = NULL;
--
[EGIT] [core/efl] master 02/15: api: move eo-based radio and check widgets to use selectable signal names
zmike pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=75c8fd1cc297b6c14f1626ad10483f948ea064e5
commit 75c8fd1cc297b6c14f1626ad10483f948ea064e5
Author: Mike Blumenkrantz
Date: Wed Sep 25 17:55:24 2019 -0400
api: move eo-based radio and check widgets to use selectable signal names
Summary:
this is a more standardized name
ref T8231
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10157
---
data/elementary/themes/edc/efl/check.edc | 16
data/elementary/themes/edc/efl/radio.edc | 4 ++--
src/lib/elementary/efl_ui_check.c| 22 +++---
src/lib/elementary/efl_ui_radio.c| 4 ++--
4 files changed, 23 insertions(+), 23 deletions(-)
diff --git a/data/elementary/themes/edc/efl/check.edc
b/data/elementary/themes/edc/efl/check.edc
index cccd10b824..62d85ed085 100644
--- a/data/elementary/themes/edc/efl/check.edc
+++ b/data/elementary/themes/edc/efl/check.edc
@@ -258,12 +258,12 @@ group { "efl/check"; data.item: "version" "123";
programs {
EFL_UI_CLICKABLE_PART_BIND(event)
program {
- signal: "efl,state,check,on"; source: "efl";
+ signal: "efl,state,selected"; source: "efl";
action: STATE_SET "selected" 0.0;
target: "indicator";
}
program {
- signal: "efl,state,check,off"; source: "efl";
+ signal: "efl,state,unselected"; source: "efl";
action: STATE_SET "default" 0.0;
target: "indicator";
}
@@ -773,7 +773,7 @@ group { "efl/check:toggle"; data.item: "version" "123";
programs {
EFL_UI_CLICKABLE_PART_BIND(event)
program {
- signal: "efl,state,check,on"; source: "efl";
+ signal: "efl,state,selected"; source: "efl";
script {
new Float:drag;
if (get_int(is_rtl) == 0) {
@@ -785,7 +785,7 @@ group { "efl/check:toggle"; data.item: "version" "123";
}
}
program {
- signal: "efl,state,check,off"; source: "efl";
+ signal: "efl,state,unselected"; source: "efl";
script {
new Float:drag;
if (get_int(is_rtl) == 0) {
@@ -809,9 +809,9 @@ group { "efl/check:toggle"; data.item: "version" "123";
}
if (((get_int(is_rtl) == 1) && (dx <= 0.5)) ||
(get_int(is_rtl) == 0) && (dx > 0.5)) {
- emit("efl,action,check,off", "efl");
+ emit("efl,action,unselect", "efl");
} else {
- emit("efl,action,check,on", "efl");
+ emit("efl,action,select", "efl");
}
}
}
@@ -842,9 +842,9 @@ group { "efl/check:toggle"; data.item: "version" "123";
}
if (((get_int(is_rtl) == 1) && (dx <= 0.5)) ||
(get_int(is_rtl) == 0) && (dx > 0.5)) {
- emit("efl,action,check,on", "efl");
+ emit("efl,action,select", "efl");
} else {
- emit("efl,action,check,off", "efl");
+ emit("efl,action,unselect", "efl");
}
set_int(was_drag, 1);
set_int(is_drag, 0);
diff --git a/data/elementary/themes/edc/efl/radio.edc
b/data/elementary/themes/edc/efl/radio.edc
index 4efbd8eff8..c2fc2141c5 100644
--- a/data/elementary/themes/edc/efl/radio.edc
+++ b/data/elementary/themes/edc/efl/radio.edc
@@ -225,12 +225,12 @@ group { "efl/radio";
programs {
EFL_UI_CLICKABLE_PART_BIND(event)
program {
- signal: "efl,state,radio,on"; source: "efl";
+ signal: "efl,state,selected"; source: "efl";
action: STATE_SET "selected" 0.0;
target: "indicator";
}
program {
- signal: "efl,state,radio,off"; source: "efl";
+ signal: "efl,state,unselected"; source: "efl";
action: STATE_SET "default" 0.0;
target: "indicator";
}
diff --git a/src/lib/elementary/efl_ui_check.c
b/src/lib/elementary/efl_ui_check.c
index 190242e3ef..15f528168a 100644
--- a/src/lib/elementary/efl_ui_check.c
+++ b/src/lib/elementary/efl_ui_check.c
@@ -79,14 +79,14 @@ _activate(Evas_Object *obj)
// so that we can distinguish between state change by user or state
change
// by calling state_change() api. Keep both the signal for backward
compatibility
// and remove "elm,state,check,on" signal emission when we can break
ABI.
-// efl_ui_selectable_selected_set below will emit "elm,state,check,*"
or "efl,state,check,*"
+// efl_ui_selectable_selected_set below will emit "elm,state,check,*"
or "efl,state,*selected"
if (elm_widget_is_legacy(obj))
{
elm_l
[EGIT] [core/efl] master 04/15: theme: efl, state, (content|text), (set|unset) -> efl, (content|text), (set|unset)
zmike pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=9b18e5a29160a631943b5b99e305a41e8aa16410
commit 9b18e5a29160a631943b5b99e305a41e8aa16410
Author: Mike Blumenkrantz
Date: Wed Sep 25 17:55:35 2019 -0400
theme: efl,state,(content|text),(set|unset) ->
efl,(content|text),(set|unset)
Summary:
this is versioned, so the correct signal will always be emitted for the
theme
version that is provided
ref T8231
Depends on D10164
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10158
---
data/elementary/themes/edc/efl/button.edc | 16
data/elementary/themes/edc/efl/check.edc| 16
data/elementary/themes/edc/efl/popup.edc| 4 ++--
data/elementary/themes/edc/efl/progress.edc | 16
data/elementary/themes/edc/efl/radio.edc| 8
data/elementary/themes/edc/efl/tab_bar.edc | 4 ++--
src/lib/elementary/efl_ui_layout.c | 23 +++
7 files changed, 47 insertions(+), 40 deletions(-)
diff --git a/data/elementary/themes/edc/efl/button.edc
b/data/elementary/themes/edc/efl/button.edc
index 0f24ebbf7e..cf86312688 100644
--- a/data/elementary/themes/edc/efl/button.edc
+++ b/data/elementary/themes/edc/efl/button.edc
@@ -331,7 +331,7 @@ group { name: "efl/button"; data.item: "version" "123";
target: "base";
}
program { name: "button_text_visible";
- signal: "efl,state,text,set"; source: "efl";
+ signal: "efl,text,set"; source: "efl";
script {
new m = get_int(btmode);
m |= LABEL; set_int(btmode, m);
@@ -339,7 +339,7 @@ group { name: "efl/button"; data.item: "version" "123";
}
}
program { name: "button_text_hidden";
- signal: "efl,state,text,unset"; source: "efl";
+ signal: "efl,text,unset"; source: "efl";
script {
new m = get_int(btmode);
m &= ~LABEL; set_int(btmode, m);
@@ -347,7 +347,7 @@ group { name: "efl/button"; data.item: "version" "123";
}
}
program { name: "button_icon_visible";
- signal: "efl,state,content,set"; source: "efl";
+ signal: "efl,content,set"; source: "efl";
script {
new m = get_int(btmode);
m |= ICON; set_int(btmode, m);
@@ -355,7 +355,7 @@ group { name: "efl/button"; data.item: "version" "123";
}
}
program { name: "button_icon_hidden";
- signal: "efl,state,content,unset"; source: "efl";
+ signal: "efl,content,unset"; source: "efl";
script {
new m = get_int(btmode);
m &= ~ICON; set_int(btmode, m);
@@ -713,7 +713,7 @@ group { name: "efl/button:anchor"; data.item: "version"
"123";
action: SIGNAL_EMIT "efl,action,click" "efl";
}
program { name: "button_text_visible";
- signal: "efl,state,text,set"; source: "efl";
+ signal: "efl,text,set"; source: "efl";
script {
new m = get_int(btmode);
m |= LABEL; set_int(btmode, m);
@@ -721,7 +721,7 @@ group { name: "efl/button:anchor"; data.item: "version"
"123";
}
}
program { name: "button_text_hidden";
- signal: "efl,state,text,unset"; source: "efl";
+ signal: "efl,text,unset"; source: "efl";
script {
new m = get_int(btmode);
m &= ~LABEL; set_int(btmode, m);
@@ -729,7 +729,7 @@ group { name: "efl/button:anchor"; data.item: "version"
"123";
}
}
program { name: "button_icon_visible";
- signal: "efl,state,content,set"; source: "efl";
+ signal: "efl,content,set"; source: "efl";
script {
new m = get_int(btmode);
m |= ICON; set_int(btmode, m);
@@ -737,7 +737,7 @@ group { name: "efl/button:anchor"; data.item: "version"
"123";
}
}
program { name: "button_icon_hidden";
- signal: "efl,state,content,unset"; source: "efl";
+ signal: "efl,content,unset"; source: "efl";
script {
new m = get_int(btmode);
m &= ~ICON; set_int(btmode, m);
diff --git a/data/elementary/themes/edc/efl/check.edc
b/data/elementary/themes/edc/efl/check.edc
index 62d85ed085..5aabedee9e 100644
--- a/data/elementary/themes/edc/efl/check.edc
+++ b/data/elementary/themes/edc/efl/check.edc
@@ -268,7 +268,7 @@ group { "efl/check"; data.item: "version" "123";
target: "indicator";
}
program {
- signal: "efl,state,text,set"; source: "efl";
+ signal: "efl,text,set"; source: "efl";
script {
new m = get_int(btmode);
m |= LABEL; set_int(btmode, m);
@@ -276,7 +276,7 @@
[EGIT] [core/efl] master 11/15: theme: efl, state, anim, stop -> efl, state, animating, stopped
zmike pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=aab934176637d445858d1fded8886ecdb9daa349
commit aab934176637d445858d1fded8886ecdb9daa349
Author: Mike Blumenkrantz
Date: Wed Sep 25 17:56:11 2019 -0400
theme: efl,state,anim,stop -> efl,state,animating,stopped
Summary:
ref T8231
Depends on D10165
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10166
---
data/elementary/themes/edc/efl/focus.edc | 2 +-
src/lib/elementary/efl_ui_win.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/data/elementary/themes/edc/efl/focus.edc
b/data/elementary/themes/edc/efl/focus.edc
index c56428f8db..c1f4695668 100644
--- a/data/elementary/themes/edc/efl/focus.edc
+++ b/data/elementary/themes/edc/efl/focus.edc
@@ -164,7 +164,7 @@ group { name: "efl/focus_highlight/top"; data.item:
"version" "123";
after: "pulse";
}
program {
- signal: "efl,state,anim,stop"; source: "efl";
+ signal: "efl,state,animating,stopped"; source: "efl";
action: STATE_SET "default" 0.0;
target: "base";
}
diff --git a/src/lib/elementary/efl_ui_win.c b/src/lib/elementary/efl_ui_win.c
index f79d4d1333..72a9239a26 100644
--- a/src/lib/elementary/efl_ui_win.c
+++ b/src/lib/elementary/efl_ui_win.c
@@ -1226,7 +1226,7 @@ _elm_win_focus_highlight_simple_setup(Efl_Ui_Win_Data *sd,
if (elm_widget_is_legacy(sd->obj))
edje_object_signal_emit(obj, "elm,state,anim,stop", "elm");
else
- edje_object_signal_emit(obj, "efl,state,anim,stop", "efl");
+ edje_object_signal_emit(obj, "efl,state,animating,stopped", "efl");
}
static void
--
[EGIT] [core/efl] master 12/15: theme: migrate all efl, anim, activate (and similar) signals to efl, state, animation, activated
zmike pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=59709bc90776261aee66e1f3d527fca0e5fbe151
commit 59709bc90776261aee66e1f3d527fca0e5fbe151
Author: Mike Blumenkrantz
Date: Wed Sep 25 17:56:17 2019 -0400
theme: migrate all efl,anim,activate (and similar) signals to
efl,state,animation,activated
Summary:
ref T8231
Depends on D10166
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10167
---
data/elementary/themes/edc/efl/button.edc | 4 ++--
data/elementary/themes/edc/efl/calendar.edc| 2 +-
data/elementary/themes/edc/efl/spin_button.edc | 2 +-
src/lib/elementary/efl_ui_button.c | 4 ++--
src/lib/elementary/efl_ui_spin_button.c| 4 ++--
5 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/data/elementary/themes/edc/efl/button.edc
b/data/elementary/themes/edc/efl/button.edc
index cf86312688..bd07559076 100644
--- a/data/elementary/themes/edc/efl/button.edc
+++ b/data/elementary/themes/edc/efl/button.edc
@@ -320,7 +320,7 @@ group { name: "efl/button"; data.item: "version" "123";
}
}
program { name: "buttonactivate";
- signal: "efl,anim,activate"; source: "efl";
+ signal: "efl,state,animation,activated"; source: "efl";
action: STATE_SET "pressed" 0.0;
target: "base";
after: "button_unpressed_anim";
@@ -696,7 +696,7 @@ group { name: "efl/button:anchor"; data.item: "version"
"123";
target: "text2";
}
program {
- signal: "efl,anim,activate"; source: "efl";
+ signal: "efl,state,animation,activated"; source: "efl";
action: STATE_SET "clicked" 0.0;
target: "bar2";
target: "text2";
diff --git a/data/elementary/themes/edc/efl/calendar.edc
b/data/elementary/themes/edc/efl/calendar.edc
index 459dbdbf00..7ec30b14fb 100644
--- a/data/elementary/themes/edc/efl/calendar.edc
+++ b/data/elementary/themes/edc/efl/calendar.edc
@@ -647,7 +647,7 @@ group { "efl/calendar"; data.item: "version" "123";
action: SIGNAL_EMIT "efl,action,click" "";
}
program { name: "access_pressed";
-signal: "efl,action,anim,activate";
+signal: "efl,state,animation,activated";
source: "efl";
action: STATE_SET "pressed" 0.0;
target: "arrow.image";
diff --git a/data/elementary/themes/edc/efl/spin_button.edc
b/data/elementary/themes/edc/efl/spin_button.edc
index 5008295218..d359fc3384 100644
--- a/data/elementary/themes/edc/efl/spin_button.edc
+++ b/data/elementary/themes/edc/efl/spin_button.edc
@@ -311,7 +311,7 @@ group { "efl/spin_button/horizontal/inc_button";
action: SIGNAL_EMIT "efl,action,click" "";
}
program { name: "access_pressed";
- signal: "efl,anim,activate";
+ signal: "efl,state,animation,activated";
source: "efl";
action: STATE_SET "pressed" 0.0;
target: "arrow.image";
diff --git a/src/lib/elementary/efl_ui_button.c
b/src/lib/elementary/efl_ui_button.c
index 4bcbc11380..7c0a13e478 100644
--- a/src/lib/elementary/efl_ui_button.c
+++ b/src/lib/elementary/efl_ui_button.c
@@ -102,7 +102,7 @@ _efl_ui_button_efl_ui_widget_on_access_activate(Eo *obj,
Efl_Ui_Button_Data *_pd
if (elm_widget_is_legacy(obj))
elm_layout_signal_emit(obj, "elm,anim,activate", "elm");
else
- elm_layout_signal_emit(obj, "efl,anim,activate", "efl");
+ elm_layout_signal_emit(obj, "efl,state,animation,activated", "efl");
return EINA_TRUE;
}
@@ -113,7 +113,7 @@ _key_action_activate(Evas_Object *obj, const char *params
EINA_UNUSED)
if (elm_widget_is_legacy(obj))
elm_layout_signal_emit(obj, "elm,anim,activate", "elm");
else
- elm_layout_signal_emit(obj, "efl,anim,activate", "efl");
+ elm_layout_signal_emit(obj, "efl,state,animation,activated", "efl");
_activate(obj);
return EINA_TRUE;
}
diff --git a/src/lib/elementary/efl_ui_spin_button.c
b/src/lib/elementary/efl_ui_spin_button.c
index bbfd7d7286..9be21373a1 100644
--- a/src/lib/elementary/efl_ui_spin_button.c
+++ b/src/lib/elementary/efl_ui_spin_button.c
@@ -542,13 +542,13 @@ _access_increment_decrement_info_say(Evas_Object *obj,
if (is_incremented)
{
elm_object_signal_emit
- (sd->inc_button, "efl,anim,activate", "efl");
+ (sd->inc_button, "efl,state,animation,activated", "efl");
eina_strbuf_append(buf, E_("incremented"));
}
else
{
elm_object_signal_emit
- (sd->dec_button, "efl,anim,activate", "efl");
+ (sd->dec_button, "efl,state,animation,activated", "efl");
eina_strbuf_append(buf, E_("decremented"));
}
--
[EGIT] [core/efl] master 01/15: theme: /efl, orient, (horizontal|vertical)/efl, state, (horizontal|vertical)/
zmike pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=d2adb0d3086025ba3a7f4fb92eb206db7d29b861
commit d2adb0d3086025ba3a7f4fb92eb206db7d29b861
Author: Mike Blumenkrantz
Date: Wed Sep 25 17:55:19 2019 -0400
theme: /efl,orient,(horizontal|vertical)/efl,state,(horizontal|vertical)/
Summary:
these signals aren't actually used by anything, just changing for grep
ref T8231
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10156
---
data/elementary/themes/edc/efl/tab_bar.edc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/data/elementary/themes/edc/efl/tab_bar.edc
b/data/elementary/themes/edc/efl/tab_bar.edc
index 4fc3c8d75e..6573bfe7c2 100644
--- a/data/elementary/themes/edc/efl/tab_bar.edc
+++ b/data/elementary/themes/edc/efl/tab_bar.edc
@@ -436,13 +436,13 @@ group { "efl/tab_bar/tab";
programs {
EFL_UI_CLICKABLE_PART_BIND(event)
program {
- signal: "efl,orient,horizontal"; source: "efl";
+ signal: "efl,state,horizontal"; source: "efl";
action: STATE_SET "default" 0.0;
target: "base";
target: "bend_clip";
}
program {
- signal: "efl,orient,vertical"; source: "efl";
+ signal: "efl,state,vertical"; source: "efl";
action: STATE_SET "vert" 0.0;
target: "base";
target: "bend_clip";
--
[EGIT] [core/efl] master 08/15: theme: use more explicit signal names for C <- theme scrollbar signals
zmike pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=6d6bfeecfa85bb3596a5a5b080ba65e58c8e360c
commit 6d6bfeecfa85bb3596a5a5b080ba65e58c8e360c
Author: Mike Blumenkrantz
Date: Wed Sep 25 17:55:55 2019 -0400
theme: use more explicit signal names for C <- theme scrollbar signals
Summary:
ref T8231
Depends on D10161
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10162
---
data/elementary/themes/edc/efl/scroller.edc | 6 +++---
src/lib/elementary/efl_ui_image_zoomable.c | 8
src/lib/elementary/efl_ui_scroll_util.c | 8
3 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/data/elementary/themes/edc/efl/scroller.edc
b/data/elementary/themes/edc/efl/scroller.edc
index aba12ffbc4..6e2769fdae 100644
--- a/data/elementary/themes/edc/efl/scroller.edc
+++ b/data/elementary/themes/edc/efl/scroller.edc
@@ -1101,7 +1101,7 @@ group { name: "efl/scroller";
}
program {
signal: "mouse,down,*"; source: "efl.dragable.vbar";
- action: SIGNAL_EMIT "efl,vbar,press" "efl";
+ action: SIGNAL_EMIT "efl,vertical_bar,press" "efl";
}
program {
signal: "mouse,up,1"; source: "efl.dragable.vbar";
@@ -1125,7 +1125,7 @@ group { name: "efl/scroller";
}
program {
signal: "mouse,down,*"; source: "efl.dragable.hbar";
- action: SIGNAL_EMIT "efl,hbar,press" "efl";
+ action: SIGNAL_EMIT "efl,horizontal_bar,press" "efl";
}
program {
signal: "mouse,up,1"; source: "efl.dragable.hbar";
@@ -1137,7 +1137,7 @@ group { name: "efl/scroller";
}
program {
signal: "mouse,up,*"; source: "efl.dragable.hbar";
- action: SIGNAL_EMIT "efl,hbar,unpress" "efl";
+ action: SIGNAL_EMIT "efl,horizontal_bar,unpress" "efl";
}
}
}
diff --git a/src/lib/elementary/efl_ui_image_zoomable.c
b/src/lib/elementary/efl_ui_image_zoomable.c
index 1967c93bc4..ad4d0f57a4 100644
--- a/src/lib/elementary/efl_ui_image_zoomable.c
+++ b/src/lib/elementary/efl_ui_image_zoomable.c
@@ -1658,7 +1658,7 @@ _efl_ui_image_zoomable_edje_object_attach(Eo *obj)
(obj, "drag,page", "efl.dragable.vbar",
obj, _efl_ui_image_zoomable_edje_drag_cb, NULL);
efl_layout_signal_callback_add
- (obj, "efl,vbar,press", "efl",
+ (obj, "efl,vertical_bar,press", "efl",
obj, _efl_ui_image_zoomable_vbar_press_cb, NULL);
efl_layout_signal_callback_add
(obj, "efl,vbar,unpress", "efl",
@@ -1682,7 +1682,7 @@ _efl_ui_image_zoomable_edje_object_attach(Eo *obj)
(obj, "drag,page", "efl.dragable.hbar",
obj, _efl_ui_image_zoomable_edje_drag_cb, NULL);
efl_layout_signal_callback_add
- (obj, "efl,hbar,press", "efl",
+ (obj, "efl,horizontal_bar,press", "efl",
obj, _efl_ui_image_zoomable_hbar_press_cb, NULL);
efl_layout_signal_callback_add
(obj, "efl,hbar,unpress", "efl",
@@ -1769,7 +1769,7 @@ _efl_ui_image_zoomable_edje_object_detach(Evas_Object
*obj)
(obj, "drag,page", "efl.dragable.vbar",
obj, _efl_ui_image_zoomable_edje_drag_cb, NULL);
efl_layout_signal_callback_del
- (obj, "efl,vbar,press", "efl",
+ (obj, "efl,vertical_bar,press", "efl",
obj, _efl_ui_image_zoomable_vbar_press_cb, NULL);
efl_layout_signal_callback_del
(obj, "efl,vbar,unpress", "efl",
@@ -1793,7 +1793,7 @@ _efl_ui_image_zoomable_edje_object_detach(Evas_Object
*obj)
(obj, "drag,page", "efl.dragable.hbar",
obj, _efl_ui_image_zoomable_edje_drag_cb, NULL);
efl_layout_signal_callback_del
- (obj, "efl,hbar,press", "efl",
+ (obj, "efl,horizontal_bar,press", "efl",
obj, _efl_ui_image_zoomable_hbar_press_cb, NULL);
efl_layout_signal_callback_del
(obj, "efl,hbar,unpress", "efl",
diff --git a/src/lib/elementary/efl_ui_scroll_util.c
b/src/lib/elementary/efl_ui_scroll_util.c
index fba8ecdfd0..dec7e5dd28 100644
--- a/src/lib/elementary/efl_ui_scroll_util.c
+++ b/src/lib/elementary/efl_ui_scroll_util.c
@@ -269,7 +269,7 @@ efl_ui_scroll_connector_bind(Eo *obj, Eo *manager)
ctx, _scroll_connector_edje_drag_cb, NULL);
efl_layout_signal_callback_add(obj, "drag,page", "efl.dragable.vbar",
ctx, _scroll_connector_edje_drag_cb, NULL);
- efl_layout_signal_callback_add(obj, "efl,vbar,press", "efl",
+ efl_layout_signal_callback_add(obj, "efl,vertical_bar,press", "efl",
ctx, _scroll_connector_vbar_press_cb, NULL);
efl_layout_signal_callback_add(ob
[EGIT] [core/efl] master 10/15: api: efl, state, busy, (start|stop) -> efl, state, busy, (started|stopped)
zmike pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=3ec56e0dc43dc86a3c788db4bd177fe4a3601779
commit 3ec56e0dc43dc86a3c788db4bd177fe4a3601779
Author: Mike Blumenkrantz
Date: Wed Sep 25 17:56:06 2019 -0400
api: efl,state,busy,(start|stop) -> efl,state,busy,(started|stopped)
Summary:
ref T8231
Depends on D10163
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8231
Differential Revision: https://phab.enlightenment.org/D10165
---
data/elementary/themes/edc/efl/image_zoomable.edc | 6 +++---
src/lib/elementary/efl_ui_image_zoomable.c| 14 +++---
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/data/elementary/themes/edc/efl/image_zoomable.edc
b/data/elementary/themes/edc/efl/image_zoomable.edc
index a1852a2b4a..7ec3644d60 100644
--- a/data/elementary/themes/edc/efl/image_zoomable.edc
+++ b/data/elementary/themes/edc/efl/image_zoomable.edc
@@ -46,7 +46,7 @@ group { name: "efl/image_zoomable";
}
programs {
program { name: "spin";
- signal: "efl,state,busy,start"; source: "efl";
+ signal: "efl,state,busy,started"; source: "efl";
action: ACTION_STOP;
target: "spin";
target: "spin0";
@@ -74,14 +74,14 @@ group { name: "efl/image_zoomable";
}
program {
- signal: "efl,state,busy,start"; source: "efl";
+ signal: "efl,state,busy,started"; source: "efl";
action: STATE_SET "active" 0.0;
transition: SINUSOIDAL 0.25;
target: "busy_clip";
}
program {
- signal: "efl,state,busy,stop"; source: "efl";
+ signal: "efl,state,busy,stopped"; source: "efl";
action: STATE_SET "default" 0.0;
transition: SINUSOIDAL 1.0;
target: "busy_clip";
diff --git a/src/lib/elementary/efl_ui_image_zoomable.c
b/src/lib/elementary/efl_ui_image_zoomable.c
index ad4d0f57a4..910854ee16 100644
--- a/src/lib/elementary/efl_ui_image_zoomable.c
+++ b/src/lib/elementary/efl_ui_image_zoomable.c
@@ -276,7 +276,7 @@ _grid_load(Evas_Object *obj,
else
edje_object_signal_emit
(wd->resize_obj,
- "efl,state,busy,start", "efl");
+ "efl,state,busy,started", "efl");
efl_event_callback_legacy_call
(obj, EFL_UI_IMAGE_ZOOMABLE_EVENT_LOAD_DETAIL, NULL);
@@ -294,7 +294,7 @@ _grid_load(Evas_Object *obj,
else
edje_object_signal_emit
(wd->resize_obj,
- "efl,state,busy,stop", "efl");
+ "efl,state,busy,stopped", "efl");
efl_event_callback_legacy_call
(obj, EFL_UI_IMAGE_ZOOMABLE_EVENT_LOADED_DETAIL, NULL);
@@ -498,7 +498,7 @@ _grid_clear(Evas_Object *obj,
else
edje_object_signal_emit
(wd->resize_obj,
- "efl,state,busy,stop", "efl");
+ "efl,state,busy,stopped", "efl");
efl_event_callback_legacy_call
(obj, EFL_UI_IMAGE_ZOOMABLE_EVENT_LOAD_DETAIL, NULL);
@@ -536,7 +536,7 @@ _tile_preloaded_cb(void *data,
"elm");
else
edje_object_signal_emit
- (wd->resize_obj, "efl,state,busy,stop",
+ (wd->resize_obj, "efl,state,busy,stopped",
"efl");
efl_event_callback_legacy_call
@@ -745,7 +745,7 @@ _main_img_preloaded_cb(void *data,
(wd->resize_obj, "elm,state,busy,stop", "elm");
else
edje_object_signal_emit
- (wd->resize_obj, "efl,state,busy,stop", "efl");
+ (wd->resize_obj, "efl,state,busy,stopped", "efl");
efl_event_callback_legacy_call
(obj, EFL_UI_IMAGE_ZOOMABLE_EVENT_LOADED_DETAIL, NULL);
@@ -2054,7 +2054,7 @@ _img_proxy_set(Evas_Object *obj,
Efl_Ui_Image_Zoomable_Data *sd,
(wd->resize_obj, "elm,state,busy,start", "elm");
else
edje_object_signal_emit
- (wd->resize_obj, "efl,state,busy,start", "efl");
+ (wd->resize_obj, "efl,state,busy,started", "efl");
efl_event_callback_legacy_call(obj,
EFL_UI_IMAGE_ZOOMABLE_EVENT_LOAD_DETAIL, NULL);
}
@@ -2139,7 +2139,7 @@ _internal_file_set(Eo *obj, Efl_Ui_Image_Zoomable_Data
*sd, Evas_Load_Error *ret
(wd->resize_obj, "elm,state,busy,start", "elm");
else
edje_object_signal_emit
- (wd->resize_obj, "efl,state,busy,start", "efl");
+ (wd->resize_obj,
[EGIT] [core/efl] master 01/05: elementary: stabilize Efl.Ui.Collection_View.
zmike pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=4c3dce94eb80a22cfd7e0c42a2a0e4bb9091978c
commit 4c3dce94eb80a22cfd7e0c42a2a0e4bb9091978c
Author: Cedric Bail
Date: Wed Sep 25 21:59:09 2019 -0400
elementary: stabilize Efl.Ui.Collection_View.
Reviewers: zmike, bu5hm4n, segfaultxavi, lauromoura, SanghyeonLee,
felipealmeida
Reviewed By: zmike, SanghyeonLee
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8261
Differential Revision: https://phab.enlightenment.org/D10171
---
src/lib/elementary/efl_ui_collection_view.eo | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/lib/elementary/efl_ui_collection_view.eo
b/src/lib/elementary/efl_ui_collection_view.eo
index a0cbbc8545..ac379d94e8 100644
--- a/src/lib/elementary/efl_ui_collection_view.eo
+++ b/src/lib/elementary/efl_ui_collection_view.eo
@@ -1,4 +1,4 @@
-class @beta Efl.Ui.Collection_View extends Efl.Ui.Layout_Base implements
+class Efl.Ui.Collection_View extends Efl.Ui.Layout_Base implements
Efl.Ui.Layout_Orientable,
Efl.Ui.Selectable,
Efl.Ui.Multi_Selectable_Async,
@@ -35,7 +35,7 @@ class @beta Efl.Ui.Collection_View extends Efl.Ui.Layout_Base
implements
factory: Efl.Ui.Factory; [[The factory.]]
}
}
- @property position_manager {
+ @property position_manager @beta {
[[Position manager object that handles placement of items.]]
values {
position_manager : Efl.Ui.Position_Manager.Entity @move; [[The
objects ownership is passed to the item container.]]
--
[EGIT] [core/efl] master 03/05: elementary: temporary workaround include issue that prevent acces to Evas_Eo.h
zmike pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=b8af6c17fc29226d351e141457dcded8c122c5eb commit b8af6c17fc29226d351e141457dcded8c122c5eb Author: Cedric Bail Date: Wed Sep 25 21:59:20 2019 -0400 elementary: temporary workaround include issue that prevent acces to Evas_Eo.h Summary: Depends on D10175 Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida Reviewed By: zmike Subscribers: #reviewers, #committers Tags: #efl Maniphest Tasks: T8266 Differential Revision: https://phab.enlightenment.org/D10176 --- src/lib/elementary/Efl_Ui.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lib/elementary/Efl_Ui.h b/src/lib/elementary/Efl_Ui.h index 80cdde78b5..060fdc93c1 100644 --- a/src/lib/elementary/Efl_Ui.h +++ b/src/lib/elementary/Efl_Ui.h @@ -307,6 +307,7 @@ typedef Eo Efl_Ui_Spotlight_Indicator; # include # include # include +# include # include # include # include --
[EGIT] [core/efl] master 04/05: elementary: forward Efl.Input.Clickable event to Efl.Ui.Collection* event.
zmike pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=26d5b7366eb4852aa4441947201b11ea637a0ad2
commit 26d5b7366eb4852aa4441947201b11ea637a0ad2
Author: Cedric Bail
Date: Wed Sep 25 21:59:25 2019 -0400
elementary: forward Efl.Input.Clickable event to Efl.Ui.Collection* event.
Summary: Depends on D10176
Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura,
felipealmeida
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8266
Differential Revision: https://phab.enlightenment.org/D10177
---
src/lib/elementary/efl_ui_collection.c | 14 --
src/lib/elementary/efl_ui_collection_view.c | 13 +++--
src/lib/elementary/efl_ui_item_clickable.eo | 17 -
3 files changed, 35 insertions(+), 9 deletions(-)
diff --git a/src/lib/elementary/efl_ui_collection.c
b/src/lib/elementary/efl_ui_collection.c
index abef6732c1..0dac5b0a60 100644
--- a/src/lib/elementary/efl_ui_collection.c
+++ b/src/lib/elementary/efl_ui_collection.c
@@ -621,8 +621,18 @@ _redirect_cb(void *data, const Efl_Event *ev)
{
Eo *obj = data;
-#define REDIRECT_EVT(item_evt, item) \
- if (item_evt == ev->desc) efl_event_callback_call(obj, item, ev->object);
+#define REDIRECT_EVT(Desc, Item_Desc) \
+ if (Desc == ev->desc)\
+ { \
+Efl_Ui_Item_Clickable_Clicked item_clicked; \
+Efl_Input_Clickable_Clicked *clicked = ev->info;\
+\
+item_clicked.clicked = *clicked;\
+item_clicked.item = ev->object; \
+\
+efl_event_callback_call(obj, Item_Desc, &item_clicked); \
+ }
+
REDIRECT_EVT(EFL_INPUT_EVENT_PRESSED, EFL_UI_EVENT_ITEM_PRESSED);
REDIRECT_EVT(EFL_INPUT_EVENT_UNPRESSED, EFL_UI_EVENT_ITEM_UNPRESSED);
REDIRECT_EVT(EFL_INPUT_EVENT_LONGPRESSED, EFL_UI_EVENT_ITEM_LONGPRESSED);
diff --git a/src/lib/elementary/efl_ui_collection_view.c
b/src/lib/elementary/efl_ui_collection_view.c
index a13e69e49a..608c31c059 100644
--- a/src/lib/elementary/efl_ui_collection_view.c
+++ b/src/lib/elementary/efl_ui_collection_view.c
@@ -183,8 +183,17 @@ _redirect_item_cb(void *data, const Efl_Event *ev)
{
Eo *obj = data;
-#define REDIRECT_EVT(item_evt, item)\
- if (item_evt == ev->desc) efl_event_callback_call(obj, item, ev->object);
+#define REDIRECT_EVT(Desc, Item_Desc) \
+ if (Desc == ev->desc)\
+ { \
+Efl_Ui_Item_Clickable_Clicked item_clicked; \
+Efl_Input_Clickable_Clicked *clicked = ev->info;\
+\
+item_clicked.clicked = *clicked;\
+item_clicked.item = ev->object; \
+\
+efl_event_callback_call(obj, Item_Desc, &item_clicked); \
+ }
REDIRECT_EVT(EFL_INPUT_EVENT_PRESSED, EFL_UI_EVENT_ITEM_PRESSED);
REDIRECT_EVT(EFL_INPUT_EVENT_UNPRESSED, EFL_UI_EVENT_ITEM_UNPRESSED);
REDIRECT_EVT(EFL_INPUT_EVENT_LONGPRESSED, EFL_UI_EVENT_ITEM_LONGPRESSED);
diff --git a/src/lib/elementary/efl_ui_item_clickable.eo
b/src/lib/elementary/efl_ui_item_clickable.eo
index 7177d24f49..1c4f9f318e 100644
--- a/src/lib/elementary/efl_ui_item_clickable.eo
+++ b/src/lib/elementary/efl_ui_item_clickable.eo
@@ -1,12 +1,19 @@
+import efl_input_clickable;
+
+struct @beta Efl.Ui.Item_Clickable_Clicked {
+ clicked: Efl.Input.Clickable_Clicked;
+ item: Efl.Ui.Item;
+}
+
interface @beta Efl.Ui.Item_Clickable
{
[[Shared sets of events between @Efl.Ui.Collection and
@Efl.Ui.Collection_View.]]
event_prefix: efl_ui;
events {
- item,pressed : Efl.Ui.Item; [[A $press event occurred over an item.]]
- item,unpressed : Efl.Ui.Item; [[An $unpress event occurred over an
item.]]
- item,longpressed : Efl.Ui.Item; [[A $longpressed event occurred over an
item.]]
- item,clicked : Efl.Ui.Item; [[A $clicked event occurred over an item.]]
- item,clicked,any : Efl.Ui.Item; [[A $clicked,any event occurred over an
item.]]
+ item,pressed : Efl.Ui.Item_Clickable_Clicked; [[A $press event occurred
over an item.]]
+ item,unpressed : Efl.Ui.Item_Clickable_Clicked; [[An $unpress event
occurred over an item.]]
+ item,longpressed : Efl.Ui.Item_Clickable_Clicked; [[A $longpressed event
occurred over an item.]]
+
[EGIT] [core/efl] master 05/05: elementary: stabilize Efl.Ui.Item_Clickable.
zmike pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=41d0ead833d0e48fb42aa537439f0fbd27d39a91
commit 41d0ead833d0e48fb42aa537439f0fbd27d39a91
Author: Cedric Bail
Date: Wed Sep 25 21:59:29 2019 -0400
elementary: stabilize Efl.Ui.Item_Clickable.
Summary: Depends on D10177
Reviewers: zmike, bu5hm4n, segfaultxavi, lauromoura, SanghyeonLee,
felipealmeida
Reviewed By: zmike, SanghyeonLee
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8266
Differential Revision: https://phab.enlightenment.org/D10173
---
src/lib/elementary/efl_ui_item_clickable.eo | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/lib/elementary/efl_ui_item_clickable.eo
b/src/lib/elementary/efl_ui_item_clickable.eo
index 1c4f9f318e..5f92a5fbce 100644
--- a/src/lib/elementary/efl_ui_item_clickable.eo
+++ b/src/lib/elementary/efl_ui_item_clickable.eo
@@ -1,11 +1,11 @@
import efl_input_clickable;
-struct @beta Efl.Ui.Item_Clickable_Clicked {
+struct Efl.Ui.Item_Clickable_Clicked {
clicked: Efl.Input.Clickable_Clicked;
item: Efl.Ui.Item;
}
-interface @beta Efl.Ui.Item_Clickable
+interface Efl.Ui.Item_Clickable
{
[[Shared sets of events between @Efl.Ui.Collection and
@Efl.Ui.Collection_View.]]
event_prefix: efl_ui;
--
[EGIT] [core/efl] master 02/05: elementary: rename Efl.Ui.Collection_Event to Efl.Ui.Item_Clickable
zmike pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=7cf364f270de5a582ad92ec7c3277837e58c045a
commit 7cf364f270de5a582ad92ec7c3277837e58c045a
Author: Cedric Bail
Date: Wed Sep 25 21:59:14 2019 -0400
elementary: rename Efl.Ui.Collection_Event to Efl.Ui.Item_Clickable
Summary: Depends on D10171
Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura,
felipealmeida
Reviewed By: zmike, SanghyeonLee
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8266
Differential Revision: https://phab.enlightenment.org/D10175
---
src/lib/elementary/Efl_Ui.h | 2 +-
src/lib/elementary/efl_ui_collection.eo | 2 +-
src/lib/elementary/efl_ui_collection_view.eo| 2 +-
src/lib/elementary/efl_ui_item.c| 2 +-
.../{efl_ui_collection_events.eo => efl_ui_item_clickable.eo} | 2 +-
src/lib/elementary/meson.build | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/lib/elementary/Efl_Ui.h b/src/lib/elementary/Efl_Ui.h
index 29ef99383e..80cdde78b5 100644
--- a/src/lib/elementary/Efl_Ui.h
+++ b/src/lib/elementary/Efl_Ui.h
@@ -307,7 +307,7 @@ typedef Eo Efl_Ui_Spotlight_Indicator;
# include
# include
# include
-# include
+# include
# include
# include
# include
diff --git a/src/lib/elementary/efl_ui_collection.eo
b/src/lib/elementary/efl_ui_collection.eo
index 28ecb4975d..a57e07b028 100644
--- a/src/lib/elementary/efl_ui_collection.eo
+++ b/src/lib/elementary/efl_ui_collection.eo
@@ -4,7 +4,7 @@ class Efl.Ui.Collection extends Efl.Ui.Layout_Base implements
Efl.Ui.Multi_Selectable,
Efl.Ui.Focus.Manager_Sub,
Efl.Ui.Widget_Focus_Manager,
- Efl.Ui.Collection_Events
+ Efl.Ui.Item_Clickable
composites
Efl.Ui.Scrollable,
Efl.Ui.Scrollbar,
diff --git a/src/lib/elementary/efl_ui_collection_view.eo
b/src/lib/elementary/efl_ui_collection_view.eo
index ac379d94e8..9278cd04c7 100644
--- a/src/lib/elementary/efl_ui_collection_view.eo
+++ b/src/lib/elementary/efl_ui_collection_view.eo
@@ -4,7 +4,7 @@ class Efl.Ui.Collection_View extends Efl.Ui.Layout_Base
implements
Efl.Ui.Multi_Selectable_Async,
Efl.Ui.Focus.Manager_Sub,
Efl.Ui.Widget_Focus_Manager,
-Efl.Ui.Collection_Events
+Efl.Ui.Item_Clickable
composites Efl.Ui.Scrollable, Efl.Ui.Scrollbar,
Efl.Ui.Multi_Selectable_Async
{
[[This widget displays a list of items in an arrangement controlled by an
external @.position_manager
diff --git a/src/lib/elementary/efl_ui_item.c b/src/lib/elementary/efl_ui_item.c
index 7cdfe16424..3dce9c3837 100644
--- a/src/lib/elementary/efl_ui_item.c
+++ b/src/lib/elementary/efl_ui_item.c
@@ -237,5 +237,5 @@ ELM_WIDGET_KEY_DOWN_DEFAULT_IMPLEMENT(efl_ui_item,
Efl_Ui_Item_Data)
#include "efl_ui_selectable.eo.c"
#include "efl_ui_multi_selectable.eo.c"
#include "efl_ui_single_selectable.eo.c"
-#include "efl_ui_collection_events.eo.c"
+#include "efl_ui_item_clickable.eo.c"
diff --git a/src/lib/elementary/efl_ui_collection_events.eo
b/src/lib/elementary/efl_ui_item_clickable.eo
similarity index 92%
rename from src/lib/elementary/efl_ui_collection_events.eo
rename to src/lib/elementary/efl_ui_item_clickable.eo
index 653172564b..7177d24f49 100644
--- a/src/lib/elementary/efl_ui_collection_events.eo
+++ b/src/lib/elementary/efl_ui_item_clickable.eo
@@ -1,4 +1,4 @@
-interface @beta Efl.Ui.Collection_Events
+interface @beta Efl.Ui.Item_Clickable
{
[[Shared sets of events between @Efl.Ui.Collection and
@Efl.Ui.Collection_View.]]
event_prefix: efl_ui;
diff --git a/src/lib/elementary/meson.build b/src/lib/elementary/meson.build
index 8166aafd95..c2cd86bbc9 100644
--- a/src/lib/elementary/meson.build
+++ b/src/lib/elementary/meson.build
@@ -171,7 +171,7 @@ pub_eo_files = [
'efl_ui_relative_layout.eo',
'efl_ui_action_connector.eo',
'efl_ui_format.eo',
- 'efl_ui_collection_events.eo',
+ 'efl_ui_item_clickable.eo',
'efl_ui_collection.eo',
'efl_ui_position_manager_entity.eo',
'efl_ui_position_manager_list.eo',
--
Re: [E-devel] 1.23 delay for two days
On Wed, 25 Sep 2019 12:45:48 -0400 Mike Blumenkrantz wrote: > Hi, > > There are currently patches on phab (which I expect to land in the next few > hours) to resolve all of the remaining minor interfaces API-related issues. > There are still a number of tasks in progress for MVVM-related items, but > if they are not resolved by the end of today then they will be deferred > until after the release. To confirm, all API stabilizations for code and theme should now have occurred for this release. I'm not aware of any pending or intended changes which need to be made at this time. > > There is the patch series beginning with > https://phab.enlightenment.org/D9899 which resolves a regression with > running EFL on X without a window manager. > > I've spent about an hour examining https://phab.enlightenment.org/T8260 > today to see what can be done, but I'm unable to reproduce it either in the > scenario described or the test case that I created. I'm not planning to > look into this further. > > There's a strange issue with the "Efl.Ui.Image_Zoomable animation" case in > elm_test where the image is not properly aligned, but this is an issue in > elm_test itself as far as I'm aware. This is the only remaining "solvable" > issue that I know of which may be worth exploring prior to the release. > > > In summary, at this time I don't see a case where a Friday release could be > blocked. It's regrettable that things have not gone as smoothly for this > release as they could have, but considering the sheer volume of serious > issues which have managed to pop up over the past couple weeks, I'd say > we're in better shape than expected. > > > Regards, > Mike > > On Wed, Sep 25, 2019 at 3:36 AM Stefan Schmidt > wrote: > > > Hello. > > > > [Grumpy mail ahead] > > > > On 23.09.19 12:06, Stefan Schmidt wrote: > > > Hello. > > > > > > The schedule we planned would have the 1.23 final release today. > > > > > > This will not happen as we have some ongoing things being handled right > > > now that need a delay. The biggest item is the theme API review going on. > > > > > > We hope that we are in the position to release on Wednesday. You can > > > help by looking at the work list I posted and especially the show > > > stopper issues still marked open. > > > > We are definitely not in a position that we can release today. :( > > > > There have been so many changes coming in the last days it feels like > > the floodgates have been opened after the freeze and not like the last > > days before a release! I am seriously grumpy right now. > > > > I understand that many of these things have been worked on for a long > > time and the target was always this release. I also have been > > communicated most of these things and people have been working hard to > > get it working, so please do not take this to personal. > > > > Still, how are we supposed to release all this just a second after it > > has landed? This last minute rush of changes is really not how a release > > could work. > > > > I hope Mike will get out theme stuff under control and the big evas leak > > get fixed quickly. > > > > I will do a beta3 today and cross my finger when looking at it again on > > Friday. > > > > regards > > Stefan Schmidt > > > > > > ___ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
