Re: [E-devel] E SVN: woohyun trunk/elementary/src/lib

[woohyun]

Hello. glima :)

I wanna get review about this commit.
Because of _elm_legacy_is returned EINA_FALSE, elm_scroller's focus_region was 
not called.
Can I know the intention of "_elm_legacy_is" at this line ?

Thanks :)

-Original Message-
From: "Enlightenment SVN" 
To: ; 
Cc: 
Sent: 2012-07-25 (수) 11:43:33
Subject: E SVN: woohyun trunk/elementary/src/lib

Log:
elementary/elm_widget : focus_region function in elm_scroller was not
  executed because of _elm_legacy_is always returned EINA_FALSE. So I removed
  it.
  

Author:   woohyun
Date: 2012-07-24 19:43:32 -0700 (Tue, 24 Jul 2012)
New Revision: 74367
Trac: http://trac.enlightenment.org/e/changeset/74367

Modified:
  trunk/elementary/src/lib/elm_widget.c 

Modified: trunk/elementary/src/lib/elm_widget.c
===
--- trunk/elementary/src/lib/elm_widget.c2012-07-25 02:39:33 UTC (rev 74366)
+++ trunk/elementary/src/lib/elm_widget.c2012-07-25 02:43:32 UTC (rev 74367)
@@ -889,7 +889,7 @@
  {
 Evas_Coord px, py;
 sd2 = evas_object_smart_data_get(o);
-if (_elm_legacy_is(o) && sd2->focus_region)
+if (sd2->focus_region)
   {
  sd2->focus_region(o, x, y, w, h);
  elm_widget_focus_region_get(o, &x, &y, &w, &h);


--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn

--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: woohyun trunk/elementary/src/lib

[woohyun]

I reverted elc_ctxpopup.c because latest modification made ctxpopup little bit 
strange.
You can check the strangeness from datetime in elementary_test.


The location of ctxpopup was different and size calculcation seemed to be wrong.


-Original Message-
From: "Enlightenment SVN"<no-re...@enlightenment.org> 
To: <enlightenment-...@lists.sourceforge.net>; 
Cc: 
Sent: 2012-09-12 (수) 13:34:08
Subject: E SVN: woohyun trunk/elementary/src/lib

Log:
elementary/ctxpopup : Rollback 76452. Ctxpopup seemed to be bad with
  this modification. (please see the datetime in elementary_test)
  

Author:   woohyun
Date: 2012-09-11 21:34:08 -0700 (Tue, 11 Sep 2012)
New Revision: 76486
Trac: http://trac.enlightenment.org/e/changeset/76486

Modified:
  trunk/elementary/src/lib/elc_ctxpopup.c 

Modified: trunk/elementary/src/lib/elc_ctxpopup.c
===
--- trunk/elementary/src/lib/elc_ctxpopup.c 2012-09-12 03:58:02 UTC (rev 
76485)
+++ trunk/elementary/src/lib/elc_ctxpopup.c 2012-09-12 04:34:08 UTC (rev 
76486)
@@ -200,7 +200,7 @@
  break;
 
default:
- continue;
+ break;
   }
 break;
  }


--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn


--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] New commit access

[woohyun]

+1 ~~~ !!


She has been doing and will do well for EFL :)



-Original Message-
From: "Jihoon Kim" 
To: "Enlightenment developer 
list"; 
Cc: 
Sent: 2012-10-11 (목) 23:37:10
Subject: Re: [E-devel] New commit access

+1. She has the enough ability to get commit access.
2012. 10. 11. 오후 5:37에 "Daniel Juyung Seo" @gmail.com>님이 
작성:

> Great! +1!
> Sohyun has been doing good jobs :)
>
> Daniel Juyung Seo (SeoZ)
> On Oct 11, 2012 5:31 PM, "Cedric BAIL" @free.fr> 
wrote:
>
> > Hello,
> >
> > I would like to recommand Sohyun Kim to get commit access to svn. She
> > has shown in the past good contribution to evas, ecore, emotion and
> > elementary as far as I remember. If nobody oppose, I will just do that
> > next monday.
> >
> > Have fun,
> > --
> > Cedric BAIL
> >
> >
> >
> 
--
> > Don't let slow site performance ruin your business. Deploy New Relic 
APM
> > Deploy New Relic app performance management and know exactly
> > what is happening inside your Ruby, Python, PHP, Java, and .NET app
> > Try New Relic at no cost today and get our sweet Data Nerd shirt too!
> > http://p.sf.net/sfu/newrelic-dev2dev
> > ___
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
>
> 
--
> Don't let slow site performance ruin your business. Deploy New Relic APM
> Deploy New Relic app performance management and know exactly
> what is happening inside your Ruby, Python, PHP, Java, and .NET app
> Try New Relic at no cost today and get our sweet Data Nerd shirt too!
> http://p.sf.net/sfu/newrelic-dev2dev
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [PATCH][ELEMENTARY][DOC] elm_slideshow returns value documentation fix

[woohyun]

Thanks. in 77936 :)



-Original Message-
From: "Michal Jagiello" 
To: ; 
Cc: 
Sent: 2012-10-12 (금) 18:38:09
Subject: [E-devel] [PATCH][ELEMENTARY][DOC] elm_slideshow returns value 
documentation fix

Hi,

 

In elm_slideshow_timeout_get  documentation is no information about what
function returns on errors.

 

I've prepared a little patch which add this information.

 

Please take a look at attached patch.

 

BR,

MJ

 


--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [Patch] [Elementary] [Entry] Correct disabled mode

[woohyun]

Thanks in svn 78836 :)



-Original Message-
From: "thiep ha" 
To: ; 
Cc: 
Sent: 2012-10-31 (수) 17:37:11
Subject: [E-devel] [Patch] [Elementary] [Entry] Correct disabled mode

Dear All,



In elementary, the disabled entry works incorrectly.

We still can cut/paste from/to it.

I'd like to send a patch to fix it.

Please review this patch.



Thanks & Regards,

Thiep Ha
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

--
LogMeIn Central: Instant, anywhere, Remote PC access and management.
Stay in control, update software, and manage PCs from one command center
Diagnose problems and improve visibility into emerging IT issues
Automate, monitor and manage. Do more in less time with Central
http://p.sf.net/sfu/logmein12331_d2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: lfelipe branches/elementary-1.7/src/lib

[woohyun]

omg  I'm sorry for my mistake.. and 
Thanks for fixing !!!




-Original Message-
From: "Enlightenment SVN" 
To: ; 
Cc: 
Sent: 2012-12-08 (토) 00:53:50
Subject: E SVN: lfelipe branches/elementary-1.7/src/lib

Log:
Fix build failure caused by 80435.
  
  

Author:   lfelipe
Date: 2012-12-07 07:53:48 -0800 (Fri, 07 Dec 2012)
New Revision: 80469
Trac: http://trac.enlightenment.org/e/changeset/80469

Modified:
  branches/elementary-1.7/src/lib/elc_multibuttonentry.c 

Modified: branches/elementary-1.7/src/lib/elc_multibuttonentry.c
===
--- branches/elementary-1.7/src/lib/elc_multibuttonentry.c  2012-12-07 
15:44:41 UTC (rev 80468)
+++ branches/elementary-1.7/src/lib/elc_multibuttonentry.c  2012-12-07 
15:53:48 UTC (rev 80469)
@@ -275,7 +275,7 @@
wd->focused = EINA_TRUE;
_view_update(data);
 
-   if (elm_widget_focus_get(data) && sd->editable)
+   if (elm_widget_focus_get(data) && wd->editable)
  {
 elm_entry_input_panel_show(wd->entry);
 elm_object_focus_set(wd->entry, EINA_TRUE);


--
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn


--
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

[woohyun]

Thanks ~ : ) 
-Original Message-
From: "Enlightenment SVN" 
To: ; 
Cc: 
Sent: 2013-01-10 (목) 00:54:42
Subject: E SVN: seoz trunk/elementary/src/lib

Log:
elm index: Fixed formatting.

Author:   seoz
Date: 2013-01-09 07:54:42 -0800 (Wed, 09 Jan 2013)
New Revision: 82468
Trac: http://trac.enlightenment.org/e/changeset/82468

Modified:
  trunk/elementary/src/lib/elm_index.c 

Modified: trunk/elementary/src/lib/elm_index.c
===
--- trunk/elementary/src/lib/elm_index.c2013-01-09 15:46:05 UTC (rev 
82467)
+++ trunk/elementary/src/lib/elm_index.c2013-01-09 15:54:42 UTC (rev 
82468)
@@ -1259,15 +1259,15 @@
p_it->base.data = it->base.data;
  _item_free(it);
  elm_widget_item_del(it);
-it = NULL;
+ it = NULL;
   }
  }
_index_box_clear(obj, sd->bx[sd->level], sd->level);
 
if (!it)
-  *ret = NULL;
+ *ret = NULL;
else
-  *ret = (Elm_Object_Item *)it;
+ *ret = (Elm_Object_Item *)it;
 }
 
 EAPI Elm_Object_Item *


--
Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery
and much more. Keep your Java skills current with LearnJavaNow -
200+ hours of step-by-step video tutorials by Java experts.
SALE $49.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122612 
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn

 
--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122712
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/efl] master 01/01: edje/edje_entry : When selected word exists, selection is cleared and cursor remains on the current entry by additional key input.

[woohyun]

You are super faster than me !!!
I was just trying to commit it, and encountered conflict ! haha. 
Anyway ~ thanks for fast removing !
 
-Original Message-
From: "Tom Hacohen"<tom.haco...@samsung.com> 
To: <enlightenment-devel@lists.sourceforge.net>; 
Cc: 
Sent: 2013-04-22 (월) 23:43:00
Subject: Re: [E-devel] [EGIT] [core/efl] master 01/01: edje/edje_entry : When 
selected word exists, selection is cleared and cursor remains on the current 
entry by additional key input.

On 22/04/13 15:34, WooHyun Jung - Enlightenment Git wrote:
> diff --git a/data/libeo.so.1.7.99-gdb.py b/data/libeo.so.1.7.99-gdb.py
> new file mode 100644
> index 000..5a3778f
> --- /dev/null
> +++ b/data/libeo.so.1.7.99-gdb.py
> @@ -0,0 +1,7 @@
> +import sys
> +
> +eodir = '/usr/local/share/eo/gdb'
> +if not eodir in sys.path:
> +   sys.path.insert(0, eodir)
> +
> +import eo_gdb

SUPER SPANK!!!

Removed it in 226517aa88428921e3f844a2b11be37184d5e94c.

Don't add generated files to git.

--
Tom.

--
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

 
--
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [admin/devs] master 01/01: ryuan: Added Ryuan Choi as a new EFL committer.

[woohyun]

 Congratulation !!! really really expect your fantastic 
work on EFL :)
 
-Original Message-
From: "ChunEon Park" 
To: ; 
; 
Cc: 
Sent: 2013-06-04 (화) 11:00:14
Subject: Re: [E-devel][EGIT] [admin/devs] master 01/01: ryuan: Added Ryuan Choi 
as a new EFL committer.

Congratulation!  :-)
 

-Regards, Hermet- 

-Original Message-
From: "Daniel Juyung Seo - Enlightenment 
Git"@enlightenment.org> 
To: @lists.sourceforge.net>; 
Cc: 
Sent: 2013-06-04 (화) 10:38:46
Subject: [EGIT] [admin/devs] master 01/01: ryuan: Added Ryuan Choi as a new EFL 
committer.

seoz pushed a commit to branch master.

commit 7c2b08a3233eb7f239055988c082e38ee552ac09
Author: Daniel Juyung Seo @samsung.com>
Date:   Tue Jun 4 10:34:11 2013 +0900

ryuan: Added Ryuan Choi as a new EFL committer.

I nominate Ryuan Choi as a next efl committer.
He has been contributing good patches so far and I guarantee that he is 
good and very passionate.
It's apparent that his effort will be so much helpful to efl community.
Also he is a webkit efl committer and I hope he will enhance eweb/eweb2 so 
much.

Please welcome ryuan!
---
 ryuan/icon-big.png  Bin 0 -> 47627 bytes
 ryuan/icon-map.png  Bin 0 -> 1487 bytes
 ryuan/icon-med.png  Bin 0 -> 13399 bytes
 ryuan/icon-sml.png  Bin 0 -> 4299 bytes
 ryuan/id_rsa.pub  1 +
 ryuan/info.txt   11 +++
 6 files changed, 12 insertions(+)

diff --git a/ryuan/icon-big.png b/ryuan/icon-big.png
new file mode 100644
index 000..509f6da
Binary files /dev/null and b/ryuan/icon-big.png differ
diff --git a/ryuan/icon-map.png b/ryuan/icon-map.png
new file mode 100644
index 000..2c504b3
Binary files /dev/null and b/ryuan/icon-map.png differ
diff --git a/ryuan/icon-med.png b/ryuan/icon-med.png
new file mode 100644
index 000..791400a
Binary files /dev/null and b/ryuan/icon-med.png differ
diff --git a/ryuan/icon-sml.png b/ryuan/icon-sml.png
new file mode 100644
index 000..fb56e9c
Binary files /dev/null and b/ryuan/icon-sml.png differ
diff --git a/ryuan/id_rsa.pub b/ryuan/id_rsa.pub
new file mode 100644
index 000..14120ad
--- /dev/null
+++ b/ryuan/id_rsa.pub
@@ -0,0 +1 @@
+ssh-rsa 
B3NzaC1yc2EDAQABAAABAQCnQlbsgvQFbnmvHxoGst0m9seXp2V+JbK2DBYX5k/Nrjv/IzrufpRNzZ+EgcmuYpQZaH8UmhOm5dat4Wu6Pi39BXk94brpfOE4r2kqwNQCD9tS4rCXZnjki/9Xi6i76XdO+tjIDtRGQig2PtjRgFHEhlF5+scf910rXqP2gxurrX/H0Gt/bGcWEwyyCcrg0JmN+V/nMV2fqiJZQX9oUjpvj53ID9ZFvi/qlsD33Hr8rDpKA3vCg8opTLCu+9j1PhBM03koTBCWCkQ1p0LBXnNliC/Ix1eeSsiiA94kgguwXQd0Idd9J1rWy4eWTz/ODVlKTlyKjt3eflAa1oJ+W14N
 ryuan.c...@gmail.com
diff --git a/ryuan/info.txt b/ryuan/info.txt
new file mode 100644
index 000..eaf56dd
--- /dev/null
+++ b/ryuan/info.txt
@@ -0,0 +1,11 @@
+Login:ryuan
+IRC Nick: ryuan
+Cloak:developer/ryuan
+Name: Ryuan Choi 
+Location: Suwon, Korea
+E-Mail:   ryuan.c...@gmail.com, ryuan.c...@samsung.com
+WWW:  http://bunhere.tistory.com
+Managing: elementary
+Contributing: edje, evas
+Platform: Ubuntu (Linux), Windows XP/7
+GeoData:  37.258 127.02

-- 

--
How ServiceNow helps IT people transform IT departments:
1. A cloud service to automate IT design, transition and operations
2. Dashboards that offer high-level views of enterprise services
3. A single system of record for all IT processes
http://p.sf.net/sfu/servicenow-d2d-j

--
How ServiceNow helps IT people transform IT departments:
1. A cloud service to automate IT design, transition and operations
2. Dashboards that offer high-level views of enterprise services
3. A single system of record for all IT processes
http://p.sf.net/sfu/servicenow-d2d-j
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel 
--
How ServiceNow helps IT people transform IT departments:
1. A cloud service to automate IT design, transition and operations
2. Dashboards that offer high-level views of enterprise services
3. A single system of record for all IT processes
http://p.sf.net/sfu/servicenow-d2d-j
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: woohyun trunk/edje

[woohyun]

 Thanks a lot :) ~ !!!
-Original Message-
From: "Vincent Torri"<vincent.to...@gmail.com> 
To: enlightenment-devel@lists.sourceforge.net
Cc: 
Sent: 12-02-07(화) 17:58:04
Subject: Re: [E-devel] E SVN: woohyun trunk/edje
On Tue, Feb 7, 2012 at 9:52 AM, Enlightenment SVN
<no-re...@enlightenment.org> wrote:
> Log:
> [edje/markup_filter] update Changelog and NEWS
>
>
> Author: woohyun
> Date: 2012-02-07 00:52:30 -0800 (Tue, 07 Feb 2012)
> New Revision: 67725
> Trac: http://trac.enlightenment.org/e/changeset/67725
>
> Modified:
> trunk/edje/ChangeLog trunk/edje/NEWS
>
> Modified: trunk/edje/ChangeLog
> ===
> --- trunk/edje/ChangeLog 2012-02-07 08:49:56 UTC (rev 67724)
> +++ trunk/edje/ChangeLog 2012-02-07 08:52:30 UTC (rev 67725)
> @@ -1,3 +1,9 @@
> +2012-02-07 WooHyun Jung
> +
> + * Added edje_object_markup_filter_callback_{add,del,del_full}.
> + These let you append(delete) markup filter functions for filtering
> + inserted text.
> +
> 2011-01-29 Carsten Haitzler (The Rasterman)
>
> 1.0.0 release
changelog entries are added at the end of the file
Vincent
>
> Modified: trunk/edje/NEWS
> ===
> --- trunk/edje/NEWS 2012-02-07 08:49:56 UTC (rev 67724)
> +++ trunk/edje/NEWS 2012-02-07 08:52:30 UTC (rev 67725)
> @@ -10,6 +10,7 @@
> * edje.version() Lua function.
> * minmul edc property.
> * add min: SOURCE and max: SOURCE.
> + * add edje_object_markup_filter_callback_add/del/delfull().
>
> Improvements:
> * speedup load time of Edje file.
>
>
> --
> Keep Your Developer Skills Current with LearnDevNow!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-d2d
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] SVN access recommendation for Hyoyoung Chang

[woohyun]

Oh! hyyoung ~ welcome !!
& Congratulation ~~~ !!!
:)




-Original Message-
From: "Daniel Juyung Seo" 
To: "Carsten Haitzler"; 
Cc: "Enlightenment developer 
list"; 
Sent: 2012-04-24 (화) 11:25:27
Subject: Re: [E-devel] SVN access recommendation for Hyoyoung Chang

In SVN!
I've seen many people left the community after becoming committers. So
only for those who have been working over  some period is worthy of
svn access. I think hyoyoung has enough reason.
Anyhow hyoyoung, please keep in mind I mentioned in the previous email.
Waiting for your good commits :)
Thanks.


Daniel Juyung Seo (SeoZ)

On Fri, Apr 20, 2012 at 9:55 PM, Carsten Haitzler 
@rasterman.com> wrote:
> On Fri, 20 Apr 2012 17:39:45 +0900 Daniel Juyung Seo 
@gmail.com>
> said:
>
> i would agree with all the below. just one added note. NEVER commit unless 
u
> will stay around for the next 2-3 hrs after it and be around online. no
> committing friday night and then immediately and then going and getting 
drunk :)
>
>> Dear all, this is Daniel Juyung Seo.
>>
>> I recommend Hyoyoung to have a SVN commit access.
>> As many of you know, he has been heavily working for elementary so far.
>> If I remember correctly, he has been sent over a hundred patches.
>> And because I think he did enough contribution and it's ok to give him
>> svn access, I recommend him as a committer.
>> If there is no super big objection, I'll add his account in a couple 
of days.
>> But Hyoyoung, remember once you have svn access you need to be more
>> careful about your code.
>>
>> Thanks.
>>
>> Daniel Juyung Seo (SeoZ)
>>
>> 
--
>> For Developers, A Lot Can Happen In A Second.
>> Boundary is the first to Know...and Tell You.
>> Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
>> http://p.sf.net/sfu/Boundary-d2dvs2
>> ___
>> enlightenment-devel mailing list
>> enlightenment-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>>
>
>
> --
> - Codito, ergo sum - "I code, therefore I am" --
> The Rasterman (Carsten Haitzler)ras...@rasterman.com
>

--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] I wanna get review of my patch about "Focus movement in all directions".

[woohyun]

+_elm_win_focus_direction_hook(const Evas_Object *obj, const Evas_Object *base, double degree,
+  Evas_Object **direction, double *weight)
+{
+   Elm_Win *wd = elm_widget_data_get(obj);
+   const Eina_List *items;
+   const Eina_List *list;
+   void *(*list_data_get) (const Eina_List *list);
+
+   if (!wd)
+ return EINA_FALSE;
+   list = elm_widget_sub_object_list_get(obj);
+
+   /* Focus chain */
+   if (list)
+ {
+if (!(items = elm_widget_focus_custom_chain_get(obj)))
+  items = list;
+
+list_data_get = eina_list_data_get;
+
+return elm_widget_focus_list_direction_get(obj, base,  items, list_data_get, degree, direction, weight);
+ }
+   return EINA_FALSE;
+}
+
 static void
 _elm_win_on_focus_hook(void *data __UNUSED__, Evas_Object *obj)
 {
@@ -540,6 +566,9 @@ _elm_win_event_cb(Evas_Object *obj, Evas_Object *s
if (type == EVAS_CALLBACK_KEY_DOWN)
  {
 Evas_Event_Key_Down *ev = event_info;
+Evas_Object *current_focused;
+
+current_focused = elm_widget_focused_object_get(obj);
 if (!strcmp(ev->keyname, "Tab"))
   {
  if (evas_key_modifier_is_set(ev->modifiers, "Shift"))
@@ -552,22 +581,34 @@ _elm_win_event_cb(Evas_Object *obj, Evas_Object *s
 else if ((!strcmp(ev->keyname, "Left")) ||
  ((!strcmp(ev->keyname, "KP_Left")) && (!ev->string)))
   {
- //TODO : woohyun jung
+ if (current_focused == obj)
+   elm_widget_focus_cycle(obj, ELM_FOCUS_NEXT);
+ else
+   elm_widget_focus_direction_go(obj, 270.0);
   }
 else if ((!strcmp(ev->keyname, "Right")) ||
      ((!strcmp(ev->keyname, "KP_Right")) && (!ev->string)))
   {
- //TODO : woohyun jung
+ if (current_focused == obj)
+   elm_widget_focus_cycle(obj, ELM_FOCUS_NEXT);
+ else
+   elm_widget_focus_direction_go(obj, 90.0);
   }
 else if ((!strcmp(ev->keyname, "Up")) ||
  ((!strcmp(ev->keyname, "KP_Up")) && (!ev->string)))
   {
- //TODO : woohyun jung
+ if (current_focused == obj)
+   elm_widget_focus_cycle(obj, ELM_FOCUS_NEXT);
+ else
+   elm_widget_focus_direction_go(obj, 0.0);
   }
 else if ((!strcmp(ev->keyname, "Down")) ||
  ((!strcmp(ev->keyname, "KP_Down")) && (!ev->string)))
   {
- //TODO : woohyun jung
+ if (current_focused == obj)
+   elm_widget_focus_cycle(obj, ELM_FOCUS_NEXT);
+ else
+   elm_widget_focus_direction_go(obj, 180.0);
   }
  }
 
@@ -1980,6 +2021,7 @@ elm_win_add(Evas_Object *parent, const char *name,
elm_widget_can_focus_set(win->win_obj, EINA_TRUE);
elm_widget_highlight_ignore_set(win->win_obj, EINA_TRUE);
elm_widget_focus_next_hook_set(win->win_obj, _elm_win_focus_next_hook);
+   elm_widget_focus_direction_hook_set(win->win_obj, _elm_win_focus_direction_hook);
evas_object_color_set(win->win_obj, 0, 0, 0, 0);
evas_object_move(win->win_obj, 0, 0);
evas_object_resize(win->win_obj, 1, 1);
Index: src/lib/elm_layout.c
===
--- src/lib/elm_layout.c	(revision 70544)
+++ src/lib/elm_layout.c	(working copy)
@@ -180,6 +180,32 @@ _elm_layout_focus_next_hook(const Evas_Object *obj
  next);
 }
 
+static Eina_Bool
+_elm_layout_focus_direction_hook(const Evas_Object *obj, const Evas_Object *base, double degree,
+ Evas_Object **direction, double *weight)
+{
+   Widget_Data *wd = elm_widget_data_get(obj);
+   const Eina_List *items;
+   void *(*list_data_get) (const Eina_List *list);
+
+   if ((!wd) || (!wd->subs))
+ return EINA_FALSE;
+
+   /* Focus chain (This block is diferent of elm_win cycle)*/
+   if ((items = elm_widget_focus_custom_chain_get(obj)))
+ list_data_get = eina_list_data_get;
+   else
+ {
+items = wd->subs;
+list_data_get = _elm_layout_list_data_get;
+
+if (!items) return EINA_FALSE;
+ }
+
+   return elm_widget_focus_list_direction_get(obj, base, items, list_data_get, degree,
+  direction, weight);
+}
+
 static void
 _sizing_eval(Widget_Data *wd)
 {
@@ -458,6 +484,7 @@ elm_layout_add(Evas_Object *parent)
elm_widget_changed_hook_set(obj, _changed_hook);
elm_widget_can_focus_set(obj, EINA_FALSE);
elm_widget_focus_next_hook_set(obj, _elm_layout_focus_next_hook);
+   elm_widget_focus_direction_hook_set(obj, _elm_layout_focus_direction_hook);
elm_widge

Re: [E-devel] [Elementary]: Test case fail fixes. - hover, flipselector, genlist, multibuttonentry

[woohyun]

Hello. Shilpa :)


Because elementary 1.0 was released, we should also maintain backport as Daniel 
did ~
http://trac.enlightenment.org/e/changeset/70520


And for trunk, you should update ChangeLog as Herment did ~
http://trac.enlightenment.org/e/changeset/70621


Can you make new patch including above ? 
Thanks :)


-Original Message-
From: "SHILPA ONKAR SINGH" 
To: ; 
Cc: "csm...@samsung.com"; 
"sreena...@samsung.com"; 
Sent: 2012-05-03 (목) 15:01:21
Subject: [E-devel] [Elementary]: Test case fail fixes. - hover, flipselector, 
genlist, multibuttonentry

Hi All,

 

Please check the attached patch for elementary test case fail fixes.



Genlist - crash fix (if itc parameter is passed as NULL )



Hover -> crash fix (when swallow part is passed as NULL in content_set_hook, 
here "smart" is assumed as default ).



Multibuttonentry, flipselector -> item text set fail on NULL parameter. 

i.e, When elm_object_item_part_text_set(it, NULL, NULL); is called and then 
elm_object_item_part_text_get(it, NULL) is called.

We should get return as NULL instead we get previously set text. 



Change description: "Test case fail fixes. - hover,flipselector,genlist, 
multibuttonentry".



Signed-off by: Shilpa Singh

  

Thanks & Regards

Shilpa 
Singh--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. 
http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: woohyun trunk/elementary/src/lib

[woohyun]

This is the new feature ~ so not for backport :)


-Original Message-
From: "Jihoon Kim"<imfin...@gmail.com> 
To: <enlightenment-devel@lists.sourceforge.net>; 
Cc: 
Sent: 2012-05-10 (목) 19:39:32
Subject: Re: [E-devel] E SVN: woohyun trunk/elementary/src/lib

backport in 1.0?
2012. 5. 10. 오후 4:21에 "Enlightenment SVN" 
<no-reply>@enlightenment.org>님이 작성:

> Log:
> elementary/elm_bubble : Fix a bug. Should return EINA_FALSE when no
>  content exists.
>
>
> Author:   woohyun
> Date: 2012-05-10 00:21:26 -0700 (Thu, 10 May 2012)
> New Revision: 70904
> Trac: http://trac.enlightenment.org/e/changeset/70904
>
> Modified:
>  trunk/elementary/src/lib/elm_bubble.c
>
> Modified: trunk/elementary/src/lib/elm_bubble.c
> ===
> --- trunk/elementary/src/lib/elm_bubble.c   2012-05-10 06:30:49 UTC
> (rev 70903)
> +++ trunk/elementary/src/lib/elm_bubble.c   2012-05-10 07:21:26 UTC
> (rev 70904)
> @@ -130,7 +130,7 @@
>
>content = elm_layout_content_get(obj, NULL);
>
> -   if (content) return EINA_FALSE;
> +   if (!content) return EINA_FALSE;
>
>/* Try Focus cycle in subitem */
>return elm_widget_focus_direction_get
>
>
>
> 
--
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: hermet trunk/devs/woohyun

[woohyun]

ooo 
I wanna be hidden  ; _ ; 


-Original Message-
From: "Enlightenment SVN"<no-re...@enlightenment.org> 
To: <enlightenment-...@lists.sourceforge.net>; 
Cc: 
Sent: 2012-05-21 (월) 10:30:42
Subject: E SVN: hermet trunk/devs/woohyun

Log:
devs/woohyun - "show me the face"
  
  

Author:   hermet
Date: 2012-05-20 18:30:41 -0700 (Sun, 20 May 2012)
New Revision: 71261
Trac: http://trac.enlightenment.org/e/changeset/71261

Added:
  trunk/devs/woohyun/icon-big.png trunk/devs/woohyun/icon-map.png 
trunk/devs/woohyun/icon-med.png trunk/devs/woohyun/icon-sml.png 


Property changes on: trunk/devs/woohyun/icon-big.png
___
Added: svn:mime-type
   + application/octet-stream


Property changes on: trunk/devs/woohyun/icon-map.png
___
Added: svn:mime-type
   + application/octet-stream


Property changes on: trunk/devs/woohyun/icon-med.png
___
Added: svn:mime-type
   + application/octet-stream


Property changes on: trunk/devs/woohyun/icon-sml.png
___
Added: svn:mime-type
   + application/octet-stream


--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn


--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [announcement] ePeriodique 0.3.1

[woohyun]

It's really cool :)  !


-Original Message-
From: "Bruno Dilly" 
To: "Enlightenment developer list"; 
"e-users"; 
Cc: 
Sent: 2012-06-25 (월) 07:42:10
Subject: Re: [E-devel] [announcement] ePeriodique 0.3.1

On Sun, Jun 24, 2012 at 6:51 AM, Jérôme Pinot @gmail.com> wrote:
> Hi,
>
> I am pleased to announce here a new minor version of ePeriodique, the EFL
> based periodic table of elements. This release adds new data (covalent
> and Van der Walls radii), a russian translation, and few fixes in the
> autotools files.
>
> This version, like the 0.3, requires elementary 1.0 (and EFL 1.2).
> Source and Slackware packages are available at:
> http://eperiodique.sourceforge.net/

Hey, Jérôme,

I've watched the screencast, it looks really nice.

Congrats

>
> --
> Jérôme Pinot
> http://ngc891.blogdns.net/
>
> --
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>



-- 
Bruno Dilly
Senior Developer
ProFUSION embedded systems
http://profusion.mobi

--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [Patch] Elementary : Flip selector test and example patches

[woohyun]

I think this is the problem of elm_flipselector.
It should calculate its min size when there is a change in the length of label.
I'll check it soon :)

-Original Message-
From: "Ingvaldur Sigurjonsson" 
To: ; 
Cc: 
Sent: 2012-06-25 (월) 21:49:06
Subject: [E-devel] [Patch] Elementary : Flip selector test and example patches

Hi

   Enclosed you find small patches for Elementary's "Flip selector" test 
and example.

   Without the patch, the value the flip selector is supposed to show is 
way too narrow, so narrow that you only see two characters of it's 
value. The patches simply add a 'evas_object_size_hint_align_set(fp, 
EVAS_HINT_FILL, EVAS_HINT_FILL);' so the flip-selector widget is resized 
when it's container is resized (box,...).

   I assume the flip-selector widget width is supposed to be controlled 
by the longest length (up to some maximum) of one of it's values but I 
dont know how to fix that. Atleast you can see the values with the 
enclosed patches.

   Files affected by the patch are:
  - src/bin/test_flipselector.c
  - src/examples/flipselector_example.c

Regards
- Ingvaldur
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. 
http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [patch][elementary] diskselector, duplicate icon for rounded item

[woohyun]

Hello. cinoo :)

I've checked your patch ~ thanks for sending :)

I think "duplicating icon" is not much good idea because that icon is made by 
application side.
That is, diskselector cannot know the properties for icon at all.
I think ~ different way should be considered for fixing this bug. 


-Original Message-
From: "Kim Shinwoo" 
To: "Enlightenment developer list"; 
Cc: 
Sent: 2012-06-28 (목) 21:52:09
Subject: [E-devel] [patch][elementary] diskselector, duplicate icon for rounded 
item

Dear All, Hello.

The diskselector has round mode which can be set by
elm_diskselector_round_enabled_set().
In case of round mode is enabled, the icon does not display properly
because diskselector replace the icon for the additional items - not copy
and paste.
To enable round mode, diskselector adds over/under itmes(additional itmes)
by using normal mode items. So there is a icon to set two places in
diskselector.
But diskselector does not duplicate the icon.. this makes item without icon
but there should be.. I'm not sure the best way to duplicate icon.
So please review the patch and give some feedbacks. Thanks.

Sincerely
Shinwoo Kim.

--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] Question about script in edc file.

[woohyun]

Hello, all.
I've spent some hours for trying to fix current elm_flipselector bug.
But failed to fix :(

The bug can be reproduced by following steps.
(1) elementary_test  -> (2) flip selector -> (3) Click the first flip selector 
-> 
(4) Push rapidly "Down arrow key" in your keyboard several times. ->
(5) Only "E" displayed. (it should be "Elementary" or "Edje" or "Ecore" or ..)

In flip selector's edc file, I've found the reason of this problem. And I made 
a test code.
(The test code wants to display "Elementary", but "l" is not displayed. only 
"Eementary" is shown.)

As you can see in attached problem.edc file, "message" script function calls 
"abc" script function.
if "abc" function uses argument for setting string to a TEXT part, the text is 
shown without some characters.
(exactly to say, the number of "not shown" characters is same with the number 
of arguments in "abc" function)

In "_embryo_str_snprintf", I've checked that "_embryo_data_string_get" returns 
wrong string.

If you test with more arguments for "abc", more characters will not be 
displayed.

This usage of script functions is wrong ? Or a bug of edje/embryo ?

Help me ~~~ #include 

EAPI int
elm_main(int argc, char **argv)
{
   Evas_Object *win, *ly, *ed;
   Edje_Message_String msg;
   char buf[PATH_MAX];

   elm_policy_set(ELM_POLICY_QUIT, ELM_POLICY_QUIT_LAST_WINDOW_CLOSED);

   win = elm_win_util_standard_add(NULL, NULL);
   elm_win_autodel_set(win, EINA_TRUE);
   evas_object_resize(win, 200, 200);
   evas_object_show(win);

   ly = elm_layout_add(win);
   snprintf(buf, sizeof(buf), "./problem.edj");
   elm_layout_file_set(ly, buf, "layout");
   evas_object_size_hint_weight_set(ly, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
   elm_win_resize_object_add(win, ly);
   evas_object_show(ly);

   ed = elm_layout_edje_get(ly);
   msg.str = "Elementary";
   edje_object_message_send(ed, EDJE_MESSAGE_STRING, 0, &msg);
   edje_object_message_signal_process(ed);

   elm_run();
   elm_shutdown();
   return 0;
}

ELM_MAIN()


problem.edc
Description: Binary data


problem.edj
Description: Binary data
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Announcing Nyanology : nyancat theme for Terminology

[woohyun]

Col 
I LOVE THIS 

 : )


-Original Message-
From: "Anisse Astier" 
To: "Enlightenment developer list"; 
Cc: 
Sent: 2012-07-19 (목) 07:14:22
Subject: [E-devel] Announcing Nyanology : nyancat theme for Terminology

Hi,

Here is a small theme for Terminology I've been working on last week:
http://youtu.be/SN5stpMoVs0

And the source:
https://github.com/anisse/nyanology

It requires the "bell signal to cursor" patch I sent earlier for the
"giggle" animation.

Also, I patched terminology to have it take the configured theme's
about part instead of the default. But I'm not sure it's in raster's
plan to allow that.

It's still very much a work-in-progress, especially the selection, but
I hope you'll enjoy it !

--
Anisse

--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Question about script in edc file.

[woohyun]

Thanks ! Raster.
I've checked it's working fine.
And ~ can understand your comments ~
I need more study !!
Anyway ~ thanks again :)


-Original Message-
From: "Carsten Haitzler" 
To: "Enlightenment developer list"; 
Cc: "woohyun"; 
Sent: 2012-07-18 (수) 20:10:33
Subject: Re: [E-devel] Question about script in edc file.

On Wed, 18 Jul 2012 16:34:27 +0900 (KST) woohyun @naver.com> said:

ok i looked at this. at first i went "ho! bug in edje"... then i went
"oooh bug in embryo. that's rare!"... and then
finally i went "OMG THAT'S WHY! crap!!!"

problem is this. you call message() from the animator. message takes varargs -
embryo style. problem is u push a string (array of vars) onto the stack to
call.. but embryo is a very dumb lang... it doesnt know how to pass an array
(string) on the stack of a varargs func as it doesnt have a type like str[] to
tell it to make it such a thing, so it takes the first value of your array and
puts that on the stack... and amazingly it doesnt fall over in a stinking
heap! it gracefully keeps working. thank god for that. so as such calling
message like u do is not possible. c code can call it because it is able to
swizzle embryo runtime to force it to place a string array on the params stack.
embryo itself cant quite manage this :(. well not reliably/the same way. the
solution i put in svn. have a flip_up/dn() func that explicitly takes a string
(str[]). :)

> Hello, all.
> I've spent some hours for trying to fix current elm_flipselector bug.
> But failed to fix :(
> 
> The bug can be reproduced by following steps.
> (1) elementary_test  -> (2) flip selector -> (3) Click the first flip
> selector -> 
> (4) Push rapidly "Down arrow key" in your keyboard several times. ->
> (5) Only "E" displayed. (it should be "Elementary" or "Edje" or "Ecore" or ..)
> 
> In flip selector's edc file, I've found the reason of this problem. And I
> made a test code. (The test code wants to display "Elementary", but "l" is
> not displayed. only "Eementary" is shown.)
> 
> As you can see in attached problem.edc file, "message" script function calls
> "abc" script function. if "abc" function uses argument for setting string to
> a TEXT part, the text is shown without some characters. (exactly to say, the
> number of "not shown" characters is same with the number of arguments in
> "abc" function)
> 
> In "_embryo_str_snprintf", I've checked that "_embryo_data_string_get"
> returns wrong string.
> 
> If you test with more arguments for "abc", more characters will not be
> displayed.
> 
> This usage of script functions is wrong ? Or a bug of edje/embryo ?
> 
> Help me ~~~ 

-- 
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com


--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: hermet trunk/elementary/src/lib

[woohyun]

The reason for calling feed events is as follows.
1. In slider widget, 
2. try mouse down on the slider bar, (not on the slider button)
3. then button will be moved to that mouse down position, 
4. AND BUTTON SHOULD BE DRAGGED when mouse is moved <- for this reason.
For this senario, "calling feed events" is not good way ? little bit curious.
Anyway, I've checked ~ this "feed events calling" caused seg fault.
(I don't know why ~ it worked fine when I wrote this code)
And I think, I can rewrite this code with another way (maybe better way).
Thanks for reporting ~ 
And sorry for late reply.
-Original Message-
From: "Daniel Juyung Seo" 
To: "Enlightenment developer 
list"
Cc: enlightenment-...@lists.sourceforge.net
Sent: 12-01-02(월) 08:00:18
Subject: Re: [E-devel] E SVN: hermet trunk/elementary/src/lib
Cedric added this several days ago.
http://trac.enlightenment.org/e/changeset/66531
Daniel Juyung Seo (SeoZ)
On Sun, Jan 1, 2012 at 6:25 PM, Tom Hacohen
 wrote:
> Yeah, calling feed events sounds bad, should be avoided when possible.
>
> Any news from the original patch author?
>
> --
> Tom.
>
> On 29/12/11 14:36, ChunEon Park wrote:
>> Cedric, this commit is the result of my review.
>> Maybe the original writer could explain this reason.
>> 
>> -Regards, Hermet-
>>
>> -Original Message-
>> From: "Enlightenment SVN"
>> To: enlightenment-...@lists.sourceforge.net
>> Cc:
>> Sent: 11-12-29(목) 21:34:04
>> Subject: E SVN: hermet trunk/elementary/src/lib
>> Log:
>> elementary/slider - prevent infinite loop.
>>
>> It looks no need to call the mouse feed events.
>> Someone needs to tell the reason.
>>
>>
>> Author: hermet
>> Date: 2011-12-29 04:34:04 -0800 (Thu, 29 Dec 2011)
>> New Revision: 66630
>> Trac: http://trac.enlightenment.org/e/changeset/66630
>> Modified:
>> trunk/elementary/src/lib/elm_slider.c
>> Modified: trunk/elementary/src/lib/elm_slider.c
>> ===
>> --- trunk/elementary/src/lib/elm_slider.c 2011-12-29 12:03:42 UTC (rev 66629)
>> +++ trunk/elementary/src/lib/elm_slider.c 2011-12-29 12:34:04 UTC (rev 66630)
>> @@ -446,7 +446,7 @@
>> }
>>
>> static void
>> -_spacer_cb(void *data, Evas *e, Evas_Object *obj __UNUSED__, void 
>> *event_info)
>> +_spacer_cb(void *data, Evas *e __UNUSED__, Evas_Object *obj __UNUSED__, 
>> void *event_info)
>> {
>> Widget_Data *wd = elm_widget_data_get(data);
>> Evas_Event_Mouse_Down *ev = event_info;
>> @@ -474,11 +474,12 @@
>> {
>> edje_object_part_drag_value_set(wd->slider, "elm.dragable.slider", button_x, 
>> button_y);
>> }
>> - else
>> - {
>> - evas_event_feed_mouse_cancel(e, 0, NULL);
>> - evas_event_feed_mouse_down(e, 1, EVAS_BUTTON_NONE, 0, NULL);
>> - }
>> +
>> + //What is a purpose of these two mouse events?
>> + //I don't know the reason but these calls cause infinite loop.
>> + //So blocked them.
>> + //evas_event_feed_mouse_cancel(e, 0, NULL);
>> + //evas_event_feed_mouse_down(e, 1, EVAS_BUTTON_NONE, 0, NULL);
>> }
>
>
>
> --
> Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
> infrastructure or vast IT resources to deliver seamless, secure access to
> virtual desktops. With this all-in-one solution, easily deploy virtual
> desktops for less than the cost of PCs and save 60% on VDI infrastructure
> costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual 
desktops for less than the cost of PCs and save 60% on VDI infrastructure 
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual 
desktops for less than the cost of PCs and save 60% on VDI infrastructure 
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/l

Re: [E-devel] E SVN: woohyun trunk/devs/woohyun

[woohyun]

I'm in trouble :(
help me !!! 
Hahaha.
 
-Original Message-
From: "David Seikel"<onef...@gmail.com> 
To: enlightenment-devel@lists.sourceforge.net
Cc: 
Sent: 12-01-09(월) 11:01:08
Subject: Re: [E-devel] E SVN: woohyun trunk/devs/woohyun
On Sun, 8 Jan 2012 20:38:48 -0500 Michael Blumenkrantz
<michael.blumenkra...@gmail.com> wrote:
> On Sun, 8 Jan 2012 17:34:21 -0800
> "Enlightenment SVN" <no-re...@enlightenment.org> wrote:
> 
> > Log:
> > dev/woohyun : update TODO
> > 
> > 
> > Author: woohyun
> > Date: 2012-01-08 17:34:20 -0800 (Sun, 08 Jan 2012)
> > New Revision: 66980
> > Trac: http://trac.enlightenment.org/e/changeset/66980
> > 
> > Modified:
> > trunk/devs/woohyun/TODO 
> 
> oh so woohyun has a TODO file in svn as well! what a lucky find for
> me!
Woohyun is in trouble now.
-- 
A big old stinking pile of genius that no one wants
coz there are too many silver coated monkeys in the world.
--
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual 
desktops for less than the cost of PCs and save 60% on VDI infrastructure 
costs. Try it free! 
http://p.sf.net/sfu/Citrix-VDIinabox___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual 
desktops for less than the cost of PCs and save 60% on VDI infrastructure 
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] Committer access proposal: ali.alzyod (Ali Alzyod)

[woohyun]

Hello. Everyone here :)

I would like to promote Ali to become a committer.
 
He has been contributing a lot in Text field, and I think he can do more for 
other fields, too.
(Especially, he has contributed many of new Text interface features by his own)
 
Plus, he has been given valuable feedback on many patches.
So, I think he is ready to be a committer.
 
If nobody object, I will give access next week :)

Thanks for reading !! ~

WooHyun Jung 

___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Committer access proposal: ali.alzyod (Ali Alzyod)

[woohyun]

Since there has been no objection, I registered him as a EFL developer :)
 
@ali.alzyod Welcome and Congrats :)
 
-Original Message-
From: "cnook"
To: "Enlightenment developer list";
Cc:
Sent: 2020-03-19 (목) 09:58:29 (GMT+09:00)
Subject: Re: [E-devel] Committer access proposal: ali.alzyod (Ali Alzyod)
 
+1

Yes he is. I actually got valuable opinions regarding color related thing.
Thank you.

2020년 3월 17일 (화) 오후 3:12, Hermet Park 님이 작성:

> +1
>
> On Tue, Mar 17, 2020 at 2:11 PM woohyun  wrote:
>
> > Hello. Everyone here :)
> >
> > I would like to promote Ali to become a committer.
> >
> > He has been contributing a lot in Text field, and I think he can do more
> > for other fields, too.
> > (Especially, he has contributed many of new Text interface features by
> his
> > own)
> >
> > Plus, he has been given valuable feedback on many patches.
> > So, I think he is ready to be a committer.
> >
> > If nobody object, I will give access next week :)
> >
> > Thanks for reading !! ~
> >
> > WooHyun Jung
> >
> > ___
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
>
>
> --
> Regards, Hermet
>
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>

___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Committer access proposal: ali.alzyod (Ali Alzyod)

[woohyun]

@raster
Woops !!  What happen  ?!?! 
Are you ok now ? I  really hope you will be recovered soon.
 
Plus, I really appreciate for sharing the information in your worst situation 
for typing.
 
 
-Original Message-
From: "Carsten Haitzler"
To: "Enlightenment developer list";
Cc: "woohyun";
Sent: 2020-03-31 (화) 18:54:20 (GMT+09:00)
Subject: Re: [E-devel] Committer access proposal: ali.alzyod (Ali Alzyod)
 
On Tue, 31 Mar 2020 13:25:42 +0900 woohyun said:

not so fast... :) no dev access changes happen unless i do them manually
currently. i've been essentially off unable to do much in the past 6 weeks or
so due to broken arm and wrist and surgery on my right hand/arm. i just got out
of the bandages and cast with my new adamantine wolverine claws embedded in my
right arm. :)

> Since there has been no objection, I registered him as a EFL developer :)
>  
> @ali.alzyod Welcome and Congrats :)
>  
> -Original Message-
> From: "cnook"
> To: "Enlightenment developer list";
> Cc:
> Sent: 2020-03-19 (목) 09:58:29 (GMT+09:00)
> Subject: Re: [E-devel] Committer access proposal: ali.alzyod (Ali Alzyod)
>  
> +1
>
> Yes he is. I actually got valuable opinions regarding color related thing.
> Thank you.
>
> 2020년 3월 17일 (화) 오후 3:12, Hermet Park 님이 작성:
>
> > +1
> >
> > On Tue, Mar 17, 2020 at 2:11 PM woohyun  wrote:
> >
> > > Hello. Everyone here :)
> > >
> > > I would like to promote Ali to become a committer.
> > >
> > > He has been contributing a lot in Text field, and I think he can do more
> > > for other fields, too.
> > > (Especially, he has contributed many of new Text interface features by
> > his
> > > own)
> > >
> > > Plus, he has been given valuable feedback on many patches.
> > > So, I think he is ready to be a committer.
> > >
> > > If nobody object, I will give access next week :)
> > >
> > > Thanks for reading !! ~
> > >
> > > WooHyun Jung
> > >
> > > ___
> > > enlightenment-devel mailing list
> > > enlightenment-devel@lists.sourceforge.net
> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> > >
> >
> >
> > --
> > Regards, Hermet
> >
> > ___
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
>
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


--
- Codito, ergo sum - "I code, therefore I am" --
Carsten Haitzler - ras...@rasterman.com


___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/efl] master 01/01: evas_textblock: rainbow flag emoji treated as two clusters(update unibreak to version 4.2)

[woohyun]

Woops. Sorry for not checking the release schedule.
I should have been more careful. 
 
Also, I'm sorry for making disturb your work.
 
-Original Message-
From: "Stefan Schmidt"
To: "Enlightenment developer list"; 
"WooHyun Jung";
Cc:
Sent: 2020-09-01 (화) 19:58:17 (GMT+09:00)
Subject: Re: [E-devel] [EGIT] [core/efl] master 01/01: evas_textblock: rainbow 
flag emoji treated as two clusters(update unibreak to version 4.2)
 
Hello WooHyun.

We are in freeze for the release. Such patches are not going in at this
stage. Same for the next one.

Also, the static lib update should be a standalone patch and not mixed
in with a evas feature.

Please pay more attention on review and what is happening upstream. We
expect that from all our committers.

I am revertign thes etwo patches now.

regards
Stefan Schmidt


On 01.09.20 12:38, AbdullehGhujeh wrote:
> woohyun pushed a commit to branch master.
>
> http://git.enlightenment.org/core/efl.git/commit/?id=1ab71284db89dcc37da12dd56796e892bc50ae0a
>
> commit 1ab71284db89dcc37da12dd56796e892bc50ae0a
> Author: AbdullehGhujeh 
> Date:   Tue Sep 1 19:33:51 2020 +0900
>
>  evas_textblock: rainbow flag emoji treated as two clusters(update 
> unibreak to version 4.2)
>  
>  Summary:
>  if we have rainbow flag emoji (🏳️‍🌈)
>  we can use mouse/keyboard to move cursor inside it because we break it 
> into two clusters, we break on 1F308,
>  
>  This is wrong as we should treat emoji as a single cluster (based on 
> rules mentioned in Unicode segmentation standard “Do not break within emoji 
> modifier sequences or emoji ZWJ sequences” 
> (https://unicode.org/reports/tr29/#GB11 )).
>  
>  this issue happens because we don’t give 1F308 its correct grapheme 
> break property value, I think this is a bug in the unibreak library as this 
> Unicode 1F308 should have word break class value equals to Glue_After_ZWJ 
> (based on https://www.unicode.org/reports/tr29/tr29-31.html#Glue_After_Zwj_WB 
> and http://unicode.org/Public/emoji/5.0/emoji-zwj-sequences.txt) which will 
> not make it break and we will get a single cluster.
>  
>  I noticed that the current unibreak lib used in EFL  seems to implement 
> Unicode 9  (latest is Unicode 13) which uses obsolete and unused grapheme 
> break property, such as E_Modifier & Glue_After_ZWJ, so if a new emoji 
> introduced (rainbow flag was introduced after Unicode 9)  and based on 
> Unicode 9 it should use property  E_Modifier or Glue_After_ZWJ we will have 
> issue with it.
>  
>  So I have updated unibreak lib using latest released version of unibreak 
> (4.2) which implement Unicode 12.
>  
>  I needed to remove **BREAK_AFTER(i)** to pass the tests in D1140 as 
> spaces do not break on latest update (also related to T995).
>  
>  {F3868712}
>  
>  this should fix T8665 & T8688
>  
>  Reviewers: ali.alzyod, woohyun, bowonryu, zmike, segfaultxavi, bu5hm4n
>  
>  Reviewed By: ali.alzyod
>  
>  Subscribers: segfaultxavi, cedric, #reviewers, #committers
>  
>  Tags: #efl
>  
>  Maniphest Tasks: T8665
>  
>  Differential Revision: https://phab.enlightenment.org/D11743
> ---
>   src/lib/evas/canvas/evas_object_textblock.c|   4 +-
>   src/static_libs/libunibreak/LICENCE|   8 +-
>   src/static_libs/libunibreak/NEWS   |  14 +-
>   src/static_libs/libunibreak/README.md  |  16 +-
>   src/static_libs/libunibreak/emojidata.c| 264 
> +
>   .../libunibreak/{unibreakbase.c => emojidef.c} |  43 +++-
>   .../libunibreak/{unibreakbase.c => emojidef.h} |  28 ++-
>   src/static_libs/libunibreak/graphemebreak.c|  88 ---
>   src/static_libs/libunibreak/graphemebreak.h|   8 +-
>   src/static_libs/libunibreak/graphemebreakdata.c| 114 +
>   src/static_libs/libunibreak/graphemebreakdef.h |  18 +-
>   src/static_libs/libunibreak/linebreak.c|  66 --
>   src/static_libs/libunibreak/linebreak.h|   8 +-
>   src/static_libs/libunibreak/linebreakdata.c| 225 +-
>   src/static_libs/libunibreak/linebreakdef.c |  17 +-
>   src/static_libs/libunibreak/linebreakdef.h |  25 +-
>   src/static_libs/libunibreak/meson.build|   2 +
>   src/static_libs/libunibreak/unibreakbase.c |   2 +-
>   src/static_libs/libunibreak/unibreakbase.h |   4 +-
>   src/static_libs/libunibreak/unibreakdef.h  |  12 +-
>   src/static_libs/libunibreak/wordbreak.c|  92 +++
>   src/static_libs/libunibreak/wordbreak.h|  11 +-
>   src

Re: [E-devel] [EGIT] [core/elementary] master 01/01: Remove redundant check routine what elm_entry_utf8_to_markup() returns.

[woohyun]

 This function never return NULL :)
 
-Original Message-
From: "ChunEon Park" 
To: ; 
; 
Cc: 
Sent: 2013-07-18 (목) 10:05:06
Subject: Re: [E-devel][EGIT] [core/elementary] master 01/01: Remove redundant 
check routine what elm_entry_utf8_to_markup() returns.

if the returned 's' is NULL,
it will be crashed at free(s);

s = elm_entry_utf8_to_markup(path);
-   if (s)
- {
-elm_object_text_set(sd->entry, s);
-free(s);
- }
+   elm_object_text_set(sd->entry, s);
+   free(s);

 

-Regards, Hermet- 

-Original Message-
From: "Ryuan Choi - Enlightenment Git"@enlightenment.org> 
To: @lists.sourceforge.net>; 
Cc: 
Sent: 2013-07-18 (목) 02:02:22
Subject: [EGIT] [core/elementary] master 01/01: Remove redundant check routine 
what elm_entry_utf8_to_markup() returns.

ryuan pushed a commit to branch master.

commit f579f7fd4b5e863f01a001876e536f5becc40811
Author: Ryuan Choi @gmail.com>
Date:   Thu Jul 18 01:59:22 2013 +0900

Remove redundant check routine what elm_entry_utf8_to_markup() returns.

elm_entry_utf8_to_markup() always returns allocated string.
So, we don't need to check what it returns.
---
 src/lib/elc_fileselector.c1 -
 src/lib/elc_fileselector_entry.c  8 ++--
 2 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/src/lib/elc_fileselector.c b/src/lib/elc_fileselector.c
index 3bfc1f8..68b6df1 100644
--- a/src/lib/elc_fileselector.c
+++ b/src/lib/elc_fileselector.c
@@ -227,7 +227,6 @@ _anchors_do(Evas_Object *obj,
ELM_FILESELECTOR_DATA_GET(obj, sd);
 
s = elm_entry_utf8_to_markup(path);
-   if (!s) return;
 
buf[0] = '\0';
tok = eina_str_split(s, "/", 0);
diff --git a/src/lib/elc_fileselector_entry.c b/src/lib/elc_fileselector_entry.c
index f76f8df..b1e19ed 100644
--- a/src/lib/elc_fileselector_entry.c
+++ b/src/lib/elc_fileselector_entry.c
@@ -79,7 +79,6 @@ _FILE_CHOSEN_fwd(void *data,
ELM_FILESELECTOR_ENTRY_DATA_GET(data, sd);
 
s = elm_entry_utf8_to_markup(file);
-   if (!s) return;
elm_object_text_set(sd->entry, s);
free(s);
evas_object_smart_callback_call(data, SIG_FILE_CHOSEN, event_info);
@@ -560,11 +559,8 @@ _path_set(Eo *obj EINA_UNUSED, void *_pd, va_list *list)
 
elm_fileselector_button_path_set(sd->button, path);
s = elm_entry_utf8_to_markup(path);
-   if (s)
- {
-elm_object_text_set(sd->entry, s);
-free(s);
- }
+   elm_object_text_set(sd->entry, s);
+   free(s);
 }
 
 EAPI const char *

-- 

--
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk

--
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel 
--
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/elementary] master 01/01: Remove redundant check routine what elm_entry_utf8_to_markup() returns.

[woohyun]

oh. right. I also missed the case that strdup returns NULL ! :(
  
-Original Message-
From: "ryuan Choi" 
To: "Enlightenment developer 
list"; 
Cc: ; 
Sent: 2013-07-18 (목) 10:49:26
Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: Remove redundant 
check routine what elm_entry_utf8_to_markup() returns.

reverted. sorry for the poor reading.
Yes. strdup can return NULL when allocation is failed.

Sorry for the noise.


2013/7/18 ChunEon Park @naver.com>

> if the returned 's' is NULL,
> it will be crashed at free(s);
>
> s = elm_entry_utf8_to_markup(path);
> -   if (s)
> - {
> -elm_object_text_set(sd->entry, s);
> -free(s);
> - }
> +   elm_object_text_set(sd->entry, s);
> +   free(s);
>
>
> 
> -Regards, Hermet-
>
> -Original Message-
> From: "Ryuan Choi - Enlightenment 
Git"@enlightenment.org>
> To: @lists.sourceforge.net>;
> Cc:
> Sent: 2013-07-18 (목) 02:02:22
> Subject: [EGIT] [core/elementary] master 01/01: Remove redundant check
> routine what elm_entry_utf8_to_markup() returns.
>
> ryuan pushed a commit to branch master.
>
> commit f579f7fd4b5e863f01a001876e536f5becc40811
> Author: Ryuan Choi @gmail.com>
> Date:   Thu Jul 18 01:59:22 2013 +0900
>
> Remove redundant check routine what elm_entry_utf8_to_markup() returns.
>
> elm_entry_utf8_to_markup() always returns allocated string.
> So, we don't need to check what it returns.
> ---
>  src/lib/elc_fileselector.c1 -
>  src/lib/elc_fileselector_entry.c  8 ++--
>  2 files changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/src/lib/elc_fileselector.c b/src/lib/elc_fileselector.c
> index 3bfc1f8..68b6df1 100644
> --- a/src/lib/elc_fileselector.c
> +++ b/src/lib/elc_fileselector.c
> @@ -227,7 +227,6 @@ _anchors_do(Evas_Object *obj,
> ELM_FILESELECTOR_DATA_GET(obj, sd);
>
> s = elm_entry_utf8_to_markup(path);
> -   if (!s) return;
>
> buf[0] = '\0';
> tok = eina_str_split(s, "/", 0);
> diff --git a/src/lib/elc_fileselector_entry.c
> b/src/lib/elc_fileselector_entry.c
> index f76f8df..b1e19ed 100644
> --- a/src/lib/elc_fileselector_entry.c
> +++ b/src/lib/elc_fileselector_entry.c
> @@ -79,7 +79,6 @@ _FILE_CHOSEN_fwd(void *data,
> ELM_FILESELECTOR_ENTRY_DATA_GET(data, sd);
>
> s = elm_entry_utf8_to_markup(file);
> -   if (!s) return;
> elm_object_text_set(sd->entry, s);
> free(s);
> evas_object_smart_callback_call(data, SIG_FILE_CHOSEN, event_info);
> @@ -560,11 +559,8 @@ _path_set(Eo *obj EINA_UNUSED, void *_pd, va_list
> *list)
>
> elm_fileselector_button_path_set(sd->button, path);
> s = elm_entry_utf8_to_markup(path);
> -   if (s)
> - {
> -elm_object_text_set(sd->entry, s);
> -free(s);
> - }
> +   elm_object_text_set(sd->entry, s);
> +   free(s);
>  }
>
>  EAPI const char *
>
> --
>
>
> 
--
> See everything from the browser to the database with AppDynamics
> Get end-to-end visibility with application monitoring from AppDynamics
> Isolate bottlenecks and diagnose root cause in seconds.
> Start your free trial of AppDynamics Pro today!
> 
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
>
>
> 
--
> See everything from the browser to the database with AppDynamics
> Get end-to-end visibility with application monitoring from AppDynamics
> Isolate bottlenecks and diagnose root cause in seconds.
> Start your free trial of AppDynamics Pro today!
> 
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel 
--
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=488

Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm_focus: added new focus move policy and elm_object_focus_move_policy_set/get

[woohyun]

Hello.
 
In some cases, this new policy is useful.
For example,
 - there are elm_entry and elm_check.
 - elm_entry gets focus and software keyboard is shown. (in the smart phone 
application) 
 - this elm_check is for changing the password mode of elm_entry. (it will 
set/unset password mode) 
 - Without this policy, every clicking of elm_check will set focus to elm_check.
 - software keyboard will be hidden because of losing focus from elm_entry.
 
Many smart phone application does not want to move focus to elm_check in this 
case.
I know this can be implemented by using elm_object_focus_allow_set(check, 
EINA_FALSE).
But this is not good way because elm_check should be accessible when somebody 
uses h/w keyboard only.
 
For this case, other platforms are supporting this special focus move policy, 
too.
 
Thanks :)  
 
-Original Message-
From: "Daniel Juyung Seo"<seojuyu...@gmail.com> 
To: "WooHyun Jung"<wh0705.j...@samsung.com>; 
Cc: "Enlightenment developer 
list"<enlightenment-devel@lists.sourceforge.net>; 
Sent: 2015-06-02 (화) 18:15:25
Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm_focus: added 
new focus move policy and elm_object_focus_move_policy_set/get
 
Hello Woohyun Jung,

I have a strong doubt about this commit.
1. In what case do you need ELM_FOCUS_MOVE_POLICY_KEY_ONLY? It would be
confusing to users if the focus does not move with pointing devices when
you have both pointing and key devices. If you have only key device, there
is nothing you need to do because pointing event would not be triggered.
2. Why do you need to set a separate focus policy per object? Focus is a
general concept used between multiple objects. Having a different focus
move policy per object does not make sense. This would be confusing to
users too.

Thanks,
Daniel Juyung Seo (SeoZ)

On Tue, Jun 2, 2015 at 1:47 PM, WooHyun Jung <wh0705.j...@samsung.com>
wrote:

> woohyun pushed a commit to branch master.
>
>
> 
http://git.enlightenment.org/core/elementary.git/commit/?id=f0a7fafa5959f7b182100e31cab2a808e3543c9b
>
> commit f0a7fafa5959f7b182100e31cab2a808e3543c9b
> Author: WooHyun Jung <wh0705.j...@samsung.com>
> Date:   Tue Jun 2 13:42:00 2015 +0900
>
> elm_focus: added new focus move policy and
> elm_object_focus_move_policy_set/get
>
> New focus move policy, ELM_FOCUS_MOVE_POLICY_KEY_ONLY, is added.
> If you set this policy as base focus move policy, objects cannot steal
> focus by using mouse click or mouse in. Only keyboard input (such as
> Left,
> Right, Up, Down, ...) can make focus be moved.
> Additaionally, an object can have its own focus move policy by using
> elm_object_focus_move_policy_set API.
>
> @feature
> ---
>  src/bin/Makefile.am   |  1 +
>  src/bin/test.c|  2 ++
>  src/lib/elm_config.h  |  3 ++-
>  src/lib/elm_focus.h   | 36 
>  src/lib/elm_main.c| 15 +++
>  src/lib/elm_widget.c  | 38 +++---
>  src/lib/elm_widget.eo | 11 +++
>  src/lib/elm_widget.h  |  3 +++
>  8 files changed, 105 insertions(+), 4 deletions(-)
>
> diff --git a/src/bin/Makefile.am b/src/bin/Makefile.am
> index 3d0a990..fdaafa4 100644
> --- a/src/bin/Makefile.am
> +++ b/src/bin/Makefile.am
> @@ -65,6 +65,7 @@ test_flipselector.c \
>  test_floating.c \
>  test_focus.c \
>  test_focus_custom_chain.c \
> +test_focus_policy.c \
>  test_focus_style.c \
>  test_gengrid.c \
>  test_genlist.c \
> diff --git a/src/bin/test.c b/src/bin/test.c
> index 9a7de33..443d69c 100644
> --- a/src/bin/test.c
> +++ b/src/bin/test.c
> @@ -206,6 +206,7 @@ void test_focus_style(void *data, Evas_Object *obj,
> void *event_info);
>  void test_focus_part(void *data, Evas_Object *obj, void *event_info);
>  void test_focus3(void *data, Evas_Object *obj, void *event_info);
>  void test_focus_object_style(void *data, Evas_Object *obj, void
> *event_info);
> +void test_focus_object_policy(void *data, Evas_Object *obj, void
> *event_info);
>  void test_flipselector(void *data, Evas_Object *obj, void *event_info);
>  void test_diskselector(void *data, Evas_Object *obj, void *event_info);
>  void test_colorselector(void *data, Evas_Object *obj, void *event_info);
> @@ -804,6 +805,7 @@ add_tests:
> ADD_TEST(NULL, "Focus", "Focus On Part", test_focus_part);
> ADD_TEST(NULL, "Focus", "Focus 3", test_focus3);
> ADD_TEST(NULL, "Focus", "Focus Object Style", test_focus_object_style);
> +   ADD_TEST(NULL, "Focus", "Focus Object Policy",
> test_focus_object_policy);
>
> //--//
> ADD_TEST(NULL, "Naviframe", "Naviframe",

Re: [E-devel] Commit access

[woohyun]

 
I fully agree with Cedric.
He can do many things not only for genlist - but also for other modules.
 
So ! +1  :) 
 
-Original Message-
From: "Daniel Juyung Seo" 
To: "Enlightenment developer 
list"; 
Cc: 
Sent: 2015-06-26 (금) 05:06:12
Subject: Re: [E-devel] Commit access
 
Oh my god. I was late, Cedric.

I strongly agree with Cedric's suggestion. Sanghyeon has been doing
incredible jobs on elementary, especially genlist/gengrid. He has a deep
knowledge about overall EFL. I guarantee his impact on our community.
Thumbs up!! Go ahead.

Thanks,
Daniel Juyung Seo (SeoZ)

On Fri, Jun 26, 2015 at 1:45 AM, Cedric BAIL  wrote:

> Hello,
>
> I would like to propose Sanghyeon Lee to receive commit access. He has
> been doing some great work on reviewing incoming patch on genlist and
> gengrid. You can look at his work on phab. He is the closest we have
> from an elementary genlist maintainer at this stage and we seriously
> need someone to take a good care of his patch. I am relying on him
> already to do the review on genlist/gengrid related patch on phab and
> trust his opinion.
>   Does anyone have a different opinion ?
>
> Have fun,
> --
> Cedric BAIL
>
>
> 
--
> Monitor 25 network devices or servers for free with OpManager!
> OpManager is web-based network management software that monitors
> network devices and physical & virtual servers, alerts via email & 
sms
> for fault. Monitor 25 devices for free with no restriction. Download now
> http://ad.doubleclick.net/ddm/clk/292181274;119417398;o
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
Monitor 25 network devices or servers for free with OpManager!
OpManager is web-based network management software that monitors 
network devices and physical & virtual servers, alerts via email & sms 
for fault. Monitor 25 devices for free with no restriction. Download now
http://ad.doubleclick.net/ddm/clk/292181274;119417398;o
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Monitor 25 network devices or servers for free with OpManager!
OpManager is web-based network management software that monitors 
network devices and physical & virtual servers, alerts via email & sms 
for fault. Monitor 25 devices for free with no restriction. Download now
http://ad.doubleclick.net/ddm/clk/292181274;119417398;o
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/efl] efl-1.8 01/01: Revert "evas: replace EINA_LIST_FREE to EINA_LIST_FOREACH_SAFE."

[woohyun]

Woops! Sorry !!!
 
-Original Message-
From: "Daniel Juyung Seo"<seojuyu...@gmail.com> 
To: "Enlightenment developer 
list"<enlightenment-devel@lists.sourceforge.net>; 
Cc: 
Sent: 2014-03-03 (월) 18:33:55
Subject: Re: [E-devel] [EGIT] [core/efl] efl-1.8 01/01: Revert "evas: replace 
EINA_LIST_FREE to EINA_LIST_FOREACH_SAFE."

Woohyun!

Daniel Juyung Seo (SeoZ)


On Mon, Mar 3, 2014 at 6:29 PM, Stefan Schmidt 
<stefan>@datenfreihafen.org>wrote:

> Hello.
>
> On Mon, 2014-03-03 at 01:20, Stefan Schmidt wrote:
> > stefan pushed a commit to branch efl-1.8.
> >
> >
> 
http://git.enlightenment.org/core/efl.git/commit/?id=1b251dc707219edadf51e467fabac99fb5cae1a0
> >
> > commit 1b251dc707219edadf51e467fabac99fb5cae1a0
> > Author: Stefan Schmidt <stefan>@datenfreihafen.org>
> > Date:   Mon Mar 3 10:19:48 2014 +0100
> >
> > Revert "evas: replace EINA_LIST_FREE to EINA_LIST_FOREACH_SAFE."
> >
> > This reverts commit eb022cba1d1df351d5f5043879eade5cee9d918c.
> >
> > This does not even compile. Blindly backported without any 
testing.
>
>
> lib/evas/canvas/evas_object_main.c:656:46: error: 'l' undeclared (first
> use in this function)
>
> Its not acceptable to blindly cherry-pick commits form master and put
> them inot a stable branch without any testing.
>
> Gives me a grumpy start into the week.
>
> regards
> Stefan Schmidt
>
>
> > ---
> >  src/lib/evas/canvas/evas_object_main.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/lib/evas/canvas/evas_object_main.c
> b/src/lib/evas/canvas/evas_object_main.c
> > index eed4429..0480098 100644
> > --- a/src/lib/evas/canvas/evas_object_main.c
> > +++ b/src/lib/evas/canvas/evas_object_main.c
> > @@ -653,7 +653,7 @@ _destructor(Eo *eo_obj, void *_pd, va_list *list
> EINA_UNUSED)
> >  goto end;
> >   }
> > evas_object_grabs_cleanup(eo_obj, obj);
> > -   EINA_LIST_FOREACH_SAFE(obj->clip.clipees, l, l2, tmp)
> > +   EINA_LIST_FREE(obj->clip.clipees, tmp)
> >   evas_object_clip_unset(tmp->object);
> > while (obj->proxy->proxies)
> >   
evas_object_image_source_unset(obj->proxy->proxies->data);
>
>
> 
--
> Subversion Kills Productivity. Get off Subversion & Make the Move to
> Perforce.
> With Perforce, you get hassle-free workflows. Merge that actually works.
> Faster operations. Version large binaries.  Built-in WAN optimization and
> the
> freedom to use Git, Perforce or both. Make the move to Perforce.
>
> 
http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
Subversion Kills Productivity. Get off Subversion & Make the Move to 
Perforce.
With Perforce, you get hassle-free workflows. Merge that actually works. 
Faster operations. Version large binaries.  Built-in WAN optimization and the
freedom to use Git, Perforce or both. Make the move to Perforce.
http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

 
--
Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce.
With Perforce, you get hassle-free workflows. Merge that actually works. 
Faster operations. Version large binaries.  Built-in WAN optimization and the
freedom to use Git, Perforce or both. Make the move to Perforce.
http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/efl] master 01/01: evas: replace EINA_LIST_FREE to EINA_LIST_FOREACH_SAFE.

[woohyun]

It would be much helpful if you can give the valgrind trace :)
Only with the result of gdb, it's little bit hard to check ~ 
 
-Original Message-
From: "Davide Andreoli"<d...@gurumeditation.it> 
To: "Enlightenment developer 
list"<enlightenment-devel@lists.sourceforge.net>; 
Cc: 
Sent: 2014-03-07 (금) 16:22:43
Subject: Re: [E-devel] [EGIT] [core/efl] master 01/01: evas: replace 
EINA_LIST_FREE to EINA_LIST_FOREACH_SAFE.

2014-03-06 23:28 GMT+01:00 Cedric BAIL <cedric.bail>@free.fr>:

> On Thu, Mar 6, 2014 at 5:26 PM, Davide Andreoli 
<dave>@gurumeditation.it>
> wrote:
> > 2014-02-27 2:36 GMT+01:00 WooHyun Jung 
<wh0705.jung>@samsung.com>:
> >
> >> woohyun pushed a commit to branch master.
> >>
> >>
> >>
> 
http://git.enlightenment.org/core/efl.git/commit/?id=6093e68cb01cf915057b9e330f7586039d092990
> >>
> >> commit 6093e68cb01cf915057b9e330f7586039d092990
> >> Author: WooHyun Jung <wh0705.jung>@samsung.com>
> >> Date:   Thu Feb 27 10:31:42 2014 +0900
> >>
> >> evas: replace EINA_LIST_FREE to EINA_LIST_FOREACH_SAFE.
> >>
> >> EINA_LIST_FREE does eina_list_remove_list, and clip_unset does
> >> the same thing to the same list pointer. So, 
EINA_LIST_FOREACH_SAFE
> >> is proper for this case.
> >> ---
> >>  src/lib/evas/canvas/evas_object_main.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/src/lib/evas/canvas/evas_object_main.c
> >> b/src/lib/evas/canvas/evas_object_main.c
> >> index 9db95d4..d8d3850 100644
> >> --- a/src/lib/evas/canvas/evas_object_main.c
> >> +++ b/src/lib/evas/canvas/evas_object_main.c
> >> @@ -654,7 +654,7 @@ _destructor(Eo *eo_obj, void *_pd, va_list 
*list
> >> EINA_UNUSED)
> >>  goto end;
> >>   }
> >> evas_object_grabs_cleanup(eo_obj, obj);
> >> -   EINA_LIST_FREE(obj->clip.clipees, tmp)
> >> +   EINA_LIST_FOREACH_SAFE(obj->clip.clipees, l, l2, tmp)
> >>   evas_object_clip_unset(tmp->object);
> >> EINA_LIST_FOREACH_SAFE(obj->proxy->proxies, l, l2, 
proxy)
> >>   evas_object_image_source_unset(proxy);
> >>
> >
> > Weird, this commit is causing a segfault in the elementary photo test 
in
> > python bindings...and in my Git user interface :(
> >
> > strangely the segfault seems not reproducible in the C photo test.
> >
> > The segfault is triggered when elm_object_style_set(photo, "shadow") 
is
> > called.
> >
> > If I revert this commit the segfault goes away, I have no idea why 
this
> is
> > happening, can you please give a look? Or tell me what I can check
> >
> > This is the first part of the gdb backtrace:
>
> Would you have valgrind trace to ?
>

No, sorry, I never used valgrind in python apps, dunno how to make it. If
it is really needed I can make a try this evening


> --
> Cedric BAIL
>
>
> 
--
> Subversion Kills Productivity. Get off Subversion & Make the Move to
> Perforce.
> With Perforce, you get hassle-free workflows. Merge that actually works.
> Faster operations. Version large binaries.  Built-in WAN optimization and
> the
> freedom to use Git, Perforce or both. Make the move to Perforce.
>
> 
http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
Subversion Kills Productivity. Get off Subversion & Make the Move to 
Perforce.
With Perforce, you get hassle-free workflows. Merge that actually works. 
Faster operations. Version large binaries.  Built-in WAN optimization and the
freedom to use Git, Perforce or both. Make the move to Perforce.
http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

 
--
Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce.
With Perforce, you get hassle-free workflows. Merge that actually works. 
Faster operations. Version large binaries.  Built-in WAN optimization and the
freedom to use Git, Perforce or both. Make the move to Perforce.
http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/efl] master 01/01: evas: replace EINA_LIST_FREE to EINA_LIST_FOREACH_SAFE.

[woohyun]

I have researched this issue - but didn't get the reason.
I'll try to fix it asap. Sorry for giving unstability. 
  
 
-Original Message-
From: "Davide Andreoli"<d...@gurumeditation.it> 
To: "Enlightenment developer 
list"<enlightenment-devel@lists.sourceforge.net>; 
Cc: 
Sent: 2014-03-11 (화) 05:48:04
Subject: Re: [E-devel] [EGIT] [core/efl] master 01/01: evas: replace 
EINA_LIST_FREE to EINA_LIST_FOREACH_SAFE.

2014-03-08 10:01 GMT+01:00 Davide Andreoli <dave>@gurumeditation.it>:

>
> 2014-03-07 9:33 GMT+01:00 woohyun <woo_hyun0705>@naver.com>:
>
> It would be much helpful if you can give the valgrind trace :)
>> Only with the result of gdb, it's little bit hard to check ~
>>
>
> I do have the valgrid output but I now the segfault seems reproducible
> also in the C elm test.
> Please try:
> elementary_test -to Photo
>

woohyun: so? any news about the issue? did you tested as I suggest?

People are going to make a stable release and your commit is going to be
included, but it is still broken. Please fix it asap or we will need to
revert it.

Thanks


>
>
>
>>
>> -Original Message-
>> From: "Davide Andreoli"<d...@gurumeditation.it>
>> To: "Enlightenment developer list"&
>> lt;enlightenment-devel@lists.sourceforge.net>;
>> Cc:
>> Sent: 2014-03-07 (금) 16:22:43
>> Subject: Re: [E-devel] [EGIT] [core/efl] master 01/01: evas: replace
>> EINA_LIST_FREE to EINA_LIST_FOREACH_SAFE.
>>
>> 2014-03-06 23:28 GMT+01:00 Cedric BAIL <cedric.bail>@free.fr>:
>>
>> > On Thu, Mar 6, 2014 at 5:26 PM, Davide Andreoli &
>> lt;dave>@gurumeditation.it>
>> > wrote:
>> > > 2014-02-27 2:36 GMT+01:00 WooHyun Jung &
>> lt;wh0705.jung>@samsung.com>:
>> > >
>> > >> woohyun pushed a commit to branch master.
>> > >>
>> > >>
>> > >>
>> >
>> 
http://git.enlightenment.org/core/efl.git/commit/?id=6093e68cb01cf915057b9e330f7586039d092990
>> 
><http:>//git.enlightenment.org/core/efl.git/commit/?id=6093e68cb01cf915057b9e330f7586039d092990>>;
>> >>
>> > >> commit 6093e68cb01cf915057b9e330f7586039d092990
>> > >> Author: WooHyun Jung <wh0705.jung>@samsung.com>
>> > >> Date:   Thu Feb 27 10:31:42 2014 +0900
>> > >>
>> > >> evas: replace EINA_LIST_FREE to 
EINA_LIST_FOREACH_SAFE.
>> > >>
>> > >> EINA_LIST_FREE does eina_list_remove_list, and
>> clip_unset does
>> > >> the same thing to the same list pointer. So,
>> EINA_LIST_FOREACH_SAFE
>> > >> is proper for this case.
>> > >> ---
>> > >>  src/lib/evas/canvas/evas_object_main.c | 2 +-
>> > >>  1 file changed, 1 insertion(+), 1 deletion(-)
>> > >>
>> > >> diff --git a/src/lib/evas/canvas/evas_object_main.c
>> > >> b/src/lib/evas/canvas/evas_object_main.c
>> > >> index 9db95d4..d8d3850 100644
>> > >> --- a/src/lib/evas/canvas/evas_object_main.c
>> > >> +++ b/src/lib/evas/canvas/evas_object_main.c
>> > >> @@ -654,7 +654,7 @@ _destructor(Eo *eo_obj, void *_pd,
>> va_list *list
>> > >> EINA_UNUSED)
>> > >>  goto end;
>> > >>   }
>> > >> evas_object_grabs_cleanup(eo_obj, obj);
>> > >> -   EINA_LIST_FREE(obj->clip.clipees, tmp)
>> > >> +   EINA_LIST_FOREACH_SAFE(obj->clip.clipees, l, l2, 
tmp)
>> > >>   evas_object_clip_unset(tmp->object);
>> > >> EINA_LIST_FOREACH_SAFE(obj->proxy->proxies, l,
>> l2, proxy)
>> > >>   evas_object_image_source_unset(proxy);
>> > >>
>> > >
>> > > Weird, this commit is causing a segfault in the elementary
>> photo test in
>> > > python bindings...and in my Git user interface :(
>> > >
>> > > strangely the segfault seems not reproducible in the C photo
>> test.
>> > >
>> > > The segfault is triggered when elm_object_style_set(photo,
>> "shadow") is
>> > > called.
>> > >
>> > > If I revert this commit the segfault goes away, I have no 
idea
>> why this
>> > is
>> > > happening, can you please give a look? Or tell me what I can
>> check
>> > >
>> > > This is the first part of the gdb backtrace:
>

Re: [E-devel] [EGIT] [core/elementary] master 01/01: Fix build warning.

[woohyun]

Tom 
thanks :) good advice.
 
-Original Message-
From: "Tom Hacohen"<tom.haco...@samsung.com> 
To: "Enlightenment developer 
list"<enlightenment-devel@lists.sourceforge.net>; 
Cc: 
Sent: 2013-11-20 (수) 20:21:38
Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: Fix build warning.

Comment regarding the commit message (yeah, I'm a pedantic asshole):
You didn't fix a build warning, you removed an unused variable. :)

--
Tom.

On 20/11/13 11:23, WooHyun Jung wrote:
> woohyun pushed a commit to branch master.
>
> 
http://git.enlightenment.org/core/elementary.git/commit/?id=3d2e5d44aa4edc1675914b546535d44311cc22ae
>
> commit 3d2e5d44aa4edc1675914b546535d44311cc22ae
> Author: WooHyun Jung <wh0705.jung>@samsung.com>
> Date:   Wed Nov 20 20:23:49 2013 +0900
>
>  Fix build warning.
> ---
>   src/lib/elc_multibuttonentry.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/src/lib/elc_multibuttonentry.c 
b/src/lib/elc_multibuttonentry.c
> index 77004f9..800401b 100644
> --- a/src/lib/elc_multibuttonentry.c
> +++ b/src/lib/elc_multibuttonentry.c
> @@ -285,7 +285,6 @@ _elm_multibuttonentry_smart_on_focus(Eo *obj, void 
*_pd, va_list *list)
>
>  Eina_Bool *ret = va_arg(*list, Eina_Bool *);
>  if (ret) *ret = EINA_FALSE;
> -   Eina_Bool int_ret;
>
>  if (elm_widget_focus_get(obj))
>{
>


--
Shape the Mobile Experience: Free Subscription
Software experts and developers: Be at the forefront of tech innovation.
Intel(R) Software Adrenaline delivers strategic insight and game-changing 
conversations that shape the rapidly evolving mobile landscape. Sign up now. 
http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

 
--
Shape the Mobile Experience: Free Subscription
Software experts and developers: Be at the forefront of tech innovation.
Intel(R) Software Adrenaline delivers strategic insight and game-changing 
conversations that shape the rapidly evolving mobile landscape. Sign up now. 
http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Probie access

[woohyun]

+1 to Seoz's opinion.
 
His patches for various modules prove his ability :) 
 
-Original Message-
From: "Daniel Juyung Seo" 
To: "Enlightenment developer 
list"; 
Cc: 
Sent: 2014-07-15 (화) 20:10:42
Subject: Re: [E-devel] Probie access

Yes, he has been doing a very good job.
I saw his patches on many different modules not just for terminology.
Actually he contributed more on efl itself.
zmike and raster have been reviewing his patches.
I think he is worthy of having a full access considering his job so far.
How do you think?

Probie is good for having a branch work and personal repo, but in his case
he can just work on master. If he is not sure of his commit, he can raise a
patch on phabricator as we suggest to do.

Thanks.

Daniel Juyung Seo (SeoZ)



On Tue, Jul 15, 2014 at 7:54 PM, Boris Faure @fau.re> wrote:

> Hi!
>
> I would like to add probie access to Wonguk Jeong (huchi) for his good
> patches on terminology.
>
> Greets
> --
> Boris Faure
> Pointer Arithmetician
>
>
> 
--
> Want fast and easy access to all the code in your enterprise? Index and
> search up to 200,000 lines of code with a free copy of Black Duck
> Code Sight - the same software that powers the world's largest code
> search on Ohloh, the Black Duck Open Hub! Try it now.
> http://p.sf.net/sfu/bds
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
>
--
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

 
--
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [admin/devs] master 01/01: Please welcome Gwanglim Lee as a new committer

[woohyun]

Contratulations !  :)
 

-Original 
Message-
From: "Daniel Juyung 
Seo" 
To: 
"enlightenment-devel"; 

Cc: ; 

Sent: 2014-10-24 (금) 
22:25:13
Subject: Re: [E-devel] [EGIT] [admin/devs] 
master 01/01: Please welcome Gwanglim Lee as a new 
committer

Congratulations!!
With great power comes great responsibility.
Thanks.

Daniel Juyung Seo (SeoZ)
On Oct 24, 2014 9:53 PM, "Chris Michael"  wrote:

> devilhorns pushed a commit to branch master.
>
>
> 
http://git.enlightenment.org/admin/devs.git/commit/?id=362a46282ae283c85ff9cb7954e1fc1e60e30ddf
>
> commit 362a46282ae283c85ff9cb7954e1fc1e60e30ddf
> Author: Chris Michael 
> Date:   Fri Oct 24 08:51:00 2014 -0400
>
> Please welcome Gwanglim Lee as a new committer
>
> Signed-off-by: Chris Michael 
> ---
>  developers/gl-lee/id_rsa.pub |  1 +
>  developers/gl-lee/info.txt   | 11 +++
>  2 files changed, 12 insertions(+)
>
> diff --git a/developers/gl-lee/id_rsa.pub b/developers/gl-lee/id_rsa.pub
> new file mode 100644
> index 000..5090c44
> --- /dev/null
> +++ b/developers/gl-lee/id_rsa.pub
> @@ -0,0 +1 @@
> +ssh-rsa
> 
B3NzaC1yc2EDAQABAAABAQDOikjTH3ej70lw74wqetakpOGhPYl/EsyYKi8htt9flEvLaI6xiAnbASVVcaMok5Dt11jpHWoFeb2vWToqextaRBJh5mE9Y7sqs36kBt/caq5Ux69xbrsUADrFOPKinflG3KRwoIWWj0cjXCBoiCUv1KUHemrfUSvfl/JVZuGwKoG3jNAjv4TAo7Cke94i5bz7Od3r5mXBnPZjBgp/aM4F0rDbAq8EDViRF1coRbQ+6xwtaPdaGz4Iiyp5+T8pPiXGqBG9ND5tWmukMldobOUVKpqXxBrtwAq7g9yEGPDTquKqa1eBgj2suD5tqTEZZVKe6nFe6BN4jJ/veEhWKw8L
> yigl@denmark
> diff --git a/developers/gl-lee/info.txt b/developers/gl-lee/info.txt
> new file mode 100644
> index 000..9b4ad31
> --- /dev/null
> +++ b/developers/gl-lee/info.txt
> @@ -0,0 +1,11 @@
> +Login: gwanglim
> +IRC Nick: gl-lee
> +Cloak: developer/gwanglim
> +Name: Gwanglim Lee
> +Location: Seongnam, Korea
> +E-Mail: gwang...@gmail.com
> +WWW: http://gwanglim.blogspot.kr
> +Managing: evas, ecore, elementary, enlightenment, EFL Wayland
> +Group: Core
> +Platform: Ubuntu
> +GeoData: 37.364165,127.114368
>
> --
>
>
>
--
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
 
--
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Meet Erigo - the EFL GUI builder

[woohyun]

I'm a fan of this tool - as you know Yakov :)
AMAZING !!!
 
 
-Original Message-
From: "Jeff Hoogland" 
To: "Enlightenment developer 
list"; 
Cc: 
Sent: 2015-01-20 (화) 15:26:05
Subject: Re: [E-devel] Meet Erigo - the EFL GUI builder
 
Just wanted to say this is amazing. Eagerly awaiting python support.

On Mon, Jan 19, 2015 at 9:20 AM, Thanatermesis  wrote:

> Thank you, I will try to recompile it when 1.13 is released then :)
>
> 2015-01-19 16:17 GMT+01:00 Yakov Goldberg :
>
> > Yes, of course, you are right.
> > I will create stable releases which follow stable libs starting with 
1.13
> > :)
> >
> > I will also check possibility of creating stable version which works
> > with 1.12.
> >
> >
> > On 01/19/2015 05:09 PM, Thanatermesis wrote:
> > > so v1.13 is alpha, not a release, mmh...
> > >
> > > what about making the stable branches to follow the last stable 
release
> > of
> > > the libs too? I understand the bleeding-edge versions for the
> development
> > > itself but if the releases don't follow releases too they just 
will
> never
> > > compile to who use releases of the libs :)
> > >
> > >
> > >
> > > 2015-01-19 15:57 GMT+01:00 Yakov Goldberg 
:
> > >
> > >> Hi Thanatermesis,
> > >>thank you for your message.
> > >>That's actually not Efl, but Elementary.
> > >>We were building Erigo on the latest Elementary, so Erigo 
will
> > compile
> > >> with v1.13.0-alpha1 and later.
> > >>
> > >>Sorry for inconvenience, I'm going to add version check.
> > >>
> > >> Yakov.
> > >>
> > >> On 01/19/2015 04:41 PM, Thanatermesis wrote:
> > >>> Hi Yakov,
> > >>>
> > >>> I just tried to compile it (master branch) and i get 
this error:
> > >>>
> > >>> [ 93%] Building C object
> > src/bin/egui_gui/CMakeFiles/erigo.dir/editor.c.o
> > >>> /tmp/erigo/src/bin/egui_gui/editor.c: In function
> > >> ‘_itemview_item_selected’:
> > >>> /tmp/erigo/src/bin/egui_gui/editor.c:3668:19: error:
> > >> ‘ELM_MENU_ITEM_CLASS’
> > >>> undeclared (first use in this function)
> > >>> /tmp/erigo/src/bin/egui_gui/editor.c:3668:19: note: each 
undeclared
> > >>> identifier is reported only once for each function it 
appears in
> > >>> /tmp/erigo/src/bin/egui_gui/editor.c:3668:4: warning: 
passing
> argument
> > 1
> > >> of
> > >>> ‘eo_isa’ from incompatible pointer type [enabled by 
default]
> > >>> In file included from 
/tmp/erigo/src/lib/gui_widget.h:5:0,
> > >>>from /tmp/erigo/src/lib/ffi_glue.h:5,
> > >>>from 
/tmp/erigo/src/bin/egui_gui/editor.c:4:
> > >>> /usr/include/eo-1/Eo.h:432:16: note: expected ‘const 
struct Eo *’ but
> > >>> argument is of type ‘struct Elm_Object_Item *’
> > >>> make[4]: *** 
[src/bin/egui_gui/CMakeFiles/erigo.dir/editor.c.o]
> Error 1
> > >>>
> > >>> I'm using *libefl* at *1.12.2*
> > >>>
> > >>> Note: doing a checkout on 0.9.0 tag doesn't compile it 
too
> > >>>
> > >>>
> > >>> 2015-01-19 14:48 GMT+01:00 Yakov Goldberg 
:
> > >>>
> >  We are proud to introduce Erigo - the EFL GUI 
builder.
> >  Now you can easily build GUIs by using drag and drop 
with Elementary
> >  widgets. We currently support C, but support for 
languages is easy
> to
> >  add, and contributions are welcomed!
> >  It also supports Edje, swallow objects and can 
simulate real
> behaviour
> >  without on-the-fly. Btw, the Erigo UI was created 
using Erigo
> itself!
> > 
> >  It's still under heavy development, you should most 
likely use
> master
> > to
> >  get the latest features and fixes. However, we do 
release stable
> >  snapshots, so if you'd like to use them, just refer 
to the latest
> tag
> > on
> >  git, at the moment it's v0.9.0.
> > 
> >  Brace yourself for unexpected crashes, save your 
work often and
> please
> >  report issues as you encounter them. Also we would 
love to hear
> about
> >  your experience using it and suggestions on how we 
can improve it.
> > 
> >  Repo:
> >  https://git.enlightenment.org/tools/erigo.git/
> > 
> >  Detailed information is available at wiki page:
> >  
https://phab.enlightenment.org/w/projects/gui_builder/
> > 
> >  and YouTube playlist:
> > 
> > >>
> > 
https://www.youtube.com/playlist?list=PLal8LrkIgqzHrmHm0IBDT6s_Y7uVctR6r
> >  Yakov
> > 
> > 
> > 
> > 
> > >>
> >
> 
--
> >  New Year. New Location. New Benefits. New Data 
Center in Ashburn,
> VA.
> >  GigeNET is offering a free month of service with a 
new server in
> > >> Ashburn.
> >  Choose from 2 high performing configs, both with 
100TB of bandwidth.
> >  Higher redundancy.Lower latency.Increased 
capacity.Completely
> > compliant.
> >  http://p.sf.net/sfu/gigenet
> >  

[E-devel] [Patch] patch for elm_module

[WooHyun Jung]

Hello. 

Mr. Wonguk Jeong made a patch for elm_module. 

This patch is for changing the timing of module loading. 

 

For now, module loading is done in elm_init

Thus, modules are always loaded, even if the application does not use them.

 

So this patch deferred the timing of module loading to
"_elm_module_find_as".

 

Can anyone check about this ?

Thanks. 



elm_module.c.patch
Description: Binary data
--
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] One bug in _edje_key_down_cb func (in edje_entry.c)

[WooHyun Jung]

Hello. All ~ 

I found one bug in _edje_key_down_cb func (in edje_entry.c)

 

When I input "Backspace" in an entry object,  _signal_cursor_chagned func(in
elm_entry.c) is not called. 

This is because the following code in _edje_key_down_cb func (in
edje_entry.c) is not called. 

 

if ((evas_textblock_cursor_compare(tc, en->cursor)) && (!cursor_changed))

  _edje_emit(ed, "cursor,changed", rp->part->name);

 

Why not called ? Because ~ evas_textblock_cursor_compare(tc, en->cursor)
returns 0.

(i.e. old cursor and current cursor have the same position information)

 

I think old cursor should keep its position without any updating. 

But in evas_textblock_cursor_char_delete() func, called by _backsapce func
(in edje_entry.c) - 

old cursor's postion is updated as the current position. 

 

How can I solve this problem ? ~ 

--
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] One bug in _edje_key_down_cb func (in edje_entry.c)

[WooHyun Jung]

I made a patch - just using the position of "old-cursor". 
Is it enough for this problem ? 


-Original Message-
From: Carsten Haitzler (The Rasterman) [mailto:ras...@rasterman.com] 
Sent: Sunday, February 20, 2011 11:07 PM
To: Tom Hacohen
Cc: WooHyun Jung; enlightenment-devel@lists.sourceforge.net
Subject: Re: [E-devel] One bug in _edje_key_down_cb func (in edje_entry.c)

On Sat, 19 Feb 2011 12:02:10 +0200 Tom Hacohen  said:

> On Sat, Feb 19, 2011 at 2:54 AM, Carsten Haitzler
wrote:
> 
> > no no - you got him wrong. currently is creates a tmp cursor, copies 
> > current cursor to tmp cursor, then does the operation (delete char 
> > to the left of cursor). it then COMPARES cursor and tmp cursor. if 
> > different - send messages to say the cursor moved/changed. entry 
> > depends on this to know if/when to reposition things that are 
> > relative to the cursor. the cursor DID change BUT...
> > textblock adjusted BOTH cursors so they are now the same so the 
> > comparison doesnt show a difference, thus no emit of signal.
> >
> >
> That's what I thought he meant (just re-read my previous email and 
> noticed I didn't explain myself very well).
> 
> WooHyun: regarding your issue: I have another solution, you can use 
> evas_textblock_cursor_pos_get to get the cursor position as a number 
> which obviously will not get updated when you delete, so your 
> comparison will still remain valid. Currently this function is pretty 
> fast, but if you ever think it's not fast enough, I can easily make it 
> WAY faster.
> 
> I have one more question: What do you expect to happen when a user 
> presses delete?

actually he means backspace. what is meant to happen is elm is meant to get
a signal that the entry cursor changed position - which it did :) getting
pos before the op, pos after and comparing - if different, then send signal
will work. it just needs fixing :)

> In some cases, the coordinates of the cursor will change, in some 
> cases they won't, so I'm still not sure you want the actual position.
> 
> What are you using this signal for? Maybe we'll have to fix something
there.
> 
> --
> Tom.


-- 
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com
Index: edje_entry.c
===
--- edje_entry.c(revision 57197)
+++ edje_entry.c(working copy)
@@ -1017,7 +1017,7 @@ _edje_key_down_cb(void *data, Evas *e __UNUSED__,
Eina_Bool control, alt, shift;
Eina_Bool multiline;
Eina_Bool cursor_changed;
-   Evas_Textblock_Cursor *tc;
+   int old_cur_pos;
if (!rp) return;
en = rp->entry_data;
if ((!en) || (rp->part->type != EDJE_PART_TYPE_TEXTBLOCK) ||
@@ -1037,8 +1037,7 @@ _edje_key_down_cb(void *data, Evas *e __UNUSED__,
  }
 #endif
 
-   tc = evas_object_textblock_cursor_new(rp->object);
-   evas_textblock_cursor_copy(en->cursor, tc);
+   old_cur_pos = evas_textblock_cursor_pos_get(en->cursor);
 
control = evas_key_modifier_is_set(ev->modifiers, "Control");
alt = evas_key_modifier_is_set(ev->modifiers, "Alt");
@@ -1344,9 +1343,8 @@ _edje_key_down_cb(void *data, Evas *e __UNUSED__,
  ev->event_flags |= EVAS_EVENT_FLAG_ON_HOLD;
   }
  }
-   if ((evas_textblock_cursor_compare(tc, en->cursor)) && (!cursor_changed))
+   if ((old_cur_pos != evas_textblock_cursor_pos_get(en->cursor)) && 
(!cursor_changed))
   _edje_emit(ed, "cursor,changed", rp->part->name);
-   evas_textblock_cursor_free(tc);
 
 #ifdef HAVE_ECORE_IMF
if (en->imf_context)
--
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] Small bug in evas_textblock.

[WooHyun Jung]

Hello. All. 

I found one small bug in evas_textblock. 

For checking this bug ~ I recommend to do like following scenario. 

 

In Entry 3 of Elementary_test,

1. Push Clr Button for the bottom entry. 

2. Input 'a' and input "Backspace" in the bottom entry.

3. Click the top entry. 

4. Click the bottom entry. 

5. Input some characters. 

6. Result : char is input before the last character. 

 

So I made a patch and attached it. 

Anybody can check about this ? 

Thanks. 

Index: src/lib/canvas/evas_object_textblock.c
===
--- src/lib/canvas/evas_object_textblock.c  (revision 57196)
+++ src/lib/canvas/evas_object_textblock.c  (working copy)
@@ -5465,7 +5465,11 @@ evas_textblock_cursor_line_char_last(Evas_Textbloc
 
_find_layout_item_match(cur, &ln, &it);
 
-   if (!ln) return;
+   if (!ln) 
+ {
+cur->pos++;
+return;
+ }
if (ln->items)
  {
 Evas_Object_Textblock_Item *i;
--
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Small bug in evas_textblock.

[WooHyun Jung]

Oh. Right - return 0 is correct thing. 

But, why do you think - this solution will fix my issue ? 

I think - just returning 0 will be enough for this. 

 

From: tta...@gmail.com [mailto:tta...@gmail.com] On Behalf Of Tom Hacohen
Sent: Tuesday, February 22, 2011 2:25 AM
To: WooHyun Jung
Cc: enlightenment-devel@lists.sourceforge.net
Subject: Re: [E-devel] Small bug in evas_textblock.

 

Dear WooHyun,

I can confirm the issue, but I don't think your solution is valid, probably
the more correct thing to do is set to 0
and return, but I don't think this will fix your issue, but it's just a
correct thing to do :P

Anyhow, will take a look tomorrow, I'm too tired atm.

Thanks for the report,
Tom.

On Mon, Feb 21, 2011 at 2:43 PM, WooHyun Jung 
wrote:

Hello. All.

I found one small bug in evas_textblock.

For checking this bug ~ I recommend to do like following scenario.



In Entry 3 of Elementary_test,

1. Push Clr Button for the bottom entry.

2. Input 'a' and input "Backspace" in the bottom entry.

3. Click the top entry.

4. Click the bottom entry.

5. Input some characters.

6. Result : char is input before the last character.



So I made a patch and attached it.

Anybody can check about this ?

Thanks.



--
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel




-- 
Tom.

--
Index, Search & Analyze Logs and other IT data in Real-Time with Splunk 
Collect, index and harness all the fast moving IT data generated by your 
applications, servers and devices whether physical, virtual or in the cloud.
Deliver compliance at lower cost and gain new business insights. 
Free Software Download: http://p.sf.net/sfu/splunk-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Small bug in evas_textblock.

[WooHyun Jung]

I've checked with ~ setting cursor to 0. 
And it worked fine :) 
I made a patch for it ~ 

-Original Message-
From: Tom Hacohen [mailto:tom.haco...@partner.samsung.com] 
Sent: Tuesday, February 22, 2011 5:25 PM
To: WooHyun Jung
Cc: 'Tom Hacohen'; enlightenment-devel@lists.sourceforge.net
Subject: Re: [E-devel] Small bug in evas_textblock.

Yeah, setting the cursor to 0 may actually fix your issue (did you try it?), 
though I think there's another issue hiding there, I'll take a look :)

Will add the set to 0 soon.

--
Tom.

On Tue, 2011-02-22 at 11:12 +0900, WooHyun Jung wrote:
> Oh. Right - return 0 is correct thing. 
> 
> But, why do you think - this solution will fix my issue ? 
> 
> I think - just returning 0 will be enough for this. 
> 
>  
> 
> From: tta...@gmail.com [mailto:tta...@gmail.com] On Behalf Of Tom 
> Hacohen
> Sent: Tuesday, February 22, 2011 2:25 AM
> To: WooHyun Jung
> Cc: enlightenment-devel@lists.sourceforge.net
> Subject: Re: [E-devel] Small bug in evas_textblock.
> 
>  
> 
> Dear WooHyun,
> 
> I can confirm the issue, but I don't think your solution is valid, 
> probably the more correct thing to do is set to 0 and return, but I 
> don't think this will fix your issue, but it's just a correct thing to 
> do :P
> 
> Anyhow, will take a look tomorrow, I'm too tired atm.
> 
> Thanks for the report,
> Tom.
> 
> On Mon, Feb 21, 2011 at 2:43 PM, WooHyun Jung 
> 
> wrote:
> 
> Hello. All.
> 
> I found one small bug in evas_textblock.
> 
> For checking this bug ~ I recommend to do like following scenario.
> 
> 
> 
> In Entry 3 of Elementary_test,
> 
> 1. Push Clr Button for the bottom entry.
> 
> 2. Input 'a' and input "Backspace" in the bottom entry.
> 
> 3. Click the top entry.
> 
> 4. Click the bottom entry.
> 
> 5. Input some characters.
> 
> 6. Result : char is input before the last character.
> 
> 
> 
> So I made a patch and attached it.
> 
> Anybody can check about this ?
> 
> Thanks.
> 
> 
> --
> --
> --
> The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
> Pinpoint memory and threading errors before they happen.
> Find and fix more than 250 security defects in the development cycle.
> Locate bottlenecks in serial and parallel code that limit performance.
> http://p.sf.net/sfu/intel-dev2devfeb
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> 
> 
> 
> 

Index: src/lib/canvas/evas_object_textblock.c
===
--- src/lib/canvas/evas_object_textblock.c  (revision 57228)
+++ src/lib/canvas/evas_object_textblock.c  (working copy)
@@ -5465,7 +5465,11 @@ evas_textblock_cursor_line_char_last(Evas_Textbloc
 
_find_layout_item_match(cur, &ln, &it);
 
-   if (!ln) return;
+   if (!ln) 
+ {
+cur->pos = 0;
+return;
+ }
if (ln->items)
  {
 Evas_Object_Textblock_Item *i;
--
Index, Search & Analyze Logs and other IT data in Real-Time with Splunk 
Collect, index and harness all the fast moving IT data generated by your 
applications, servers and devices whether physical, virtual or in the cloud.
Deliver compliance at lower cost and gain new business insights. 
Free Software Download: http://p.sf.net/sfu/splunk-dev2dev___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Small bug in evas_textblock.

[WooHyun Jung]

Right ~ It's fixed and working well now ^^


-Original Message-
From: Tom Hacohen [mailto:tom.haco...@partner.samsung.com] 
Sent: Sunday, February 27, 2011 7:18 PM
To: Carsten Haitzler
Cc: WooHyun Jung; enlightenment-devel@lists.sourceforge.net
Subject: Re: [E-devel] Small bug in evas_textblock.

It is the fix to that bug. I'm 99% sure I sent an email to WooHyun and list, 
but maybe I only sent it to WooHyun, but yeah, it's fixed. (Unless my memory is 
wrong).

WooHyun: right?

--
Tom.

On Sun, 2011-02-27 at 10:59 +0100, Carsten Haitzler wrote:
> On Tue, 22 Feb 2011 18:15:30 +0900 WooHyun Jung  
> said:
> 
> tom -> hmm somehow is this one related:
> 
> http://trac.enlightenment.org/e/changeset/57229
> 
> suspiciously looks like its trying to fix the same bug.
> 
> > I've checked with ~ setting cursor to 0. 
> > And it worked fine :)
> > I made a patch for it ~
> > 
> > -Original Message-
> > From: Tom Hacohen [mailto:tom.haco...@partner.samsung.com]
> > Sent: Tuesday, February 22, 2011 5:25 PM
> > To: WooHyun Jung
> > Cc: 'Tom Hacohen'; enlightenment-devel@lists.sourceforge.net
> > Subject: Re: [E-devel] Small bug in evas_textblock.
> > 
> > Yeah, setting the cursor to 0 may actually fix your issue (did you 
> > try it?), though I think there's another issue hiding there, I'll 
> > take a look :)
> > 
> > Will add the set to 0 soon.
> > 
> > --
> > Tom.
> > 
> > On Tue, 2011-02-22 at 11:12 +0900, WooHyun Jung wrote:
> > > Oh. Right - return 0 is correct thing. 
> > > 
> > > But, why do you think - this solution will fix my issue ? 
> > > 
> > > I think - just returning 0 will be enough for this. 
> > > 
> > >  
> > > 
> > > From: tta...@gmail.com [mailto:tta...@gmail.com] On Behalf Of Tom 
> > > Hacohen
> > > Sent: Tuesday, February 22, 2011 2:25 AM
> > > To: WooHyun Jung
> > > Cc: enlightenment-devel@lists.sourceforge.net
> > > Subject: Re: [E-devel] Small bug in evas_textblock.
> > > 
> > >  
> > > 
> > > Dear WooHyun,
> > > 
> > > I can confirm the issue, but I don't think your solution is valid, 
> > > probably the more correct thing to do is set to 0 and return, but 
> > > I don't think this will fix your issue, but it's just a correct 
> > > thing to do :P
> > > 
> > > Anyhow, will take a look tomorrow, I'm too tired atm.
> > > 
> > > Thanks for the report,
> > > Tom.
> > > 
> > > On Mon, Feb 21, 2011 at 2:43 PM, WooHyun Jung 
> > > 
> > > wrote:
> > > 
> > > Hello. All.
> > > 
> > > I found one small bug in evas_textblock.
> > > 
> > > For checking this bug ~ I recommend to do like following scenario.
> > > 
> > > 
> > > 
> > > In Entry 3 of Elementary_test,
> > > 
> > > 1. Push Clr Button for the bottom entry.
> > > 
> > > 2. Input 'a' and input "Backspace" in the bottom entry.
> > > 
> > > 3. Click the top entry.
> > > 
> > > 4. Click the bottom entry.
> > > 
> > > 5. Input some characters.
> > > 
> > > 6. Result : char is input before the last character.
> > > 
> > > 
> > > 
> > > So I made a patch and attached it.
> > > 
> > > Anybody can check about this ?
> > > 
> > > Thanks.
> > > 
> > > 
> > > --
> > > 
> > > --
> > > --
> > > The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
> > > Pinpoint memory and threading errors before they happen.
> > > Find and fix more than 250 security defects in the development cycle.
> > > Locate bottlenecks in serial and parallel code that limit performance.
> > > http://p.sf.net/sfu/intel-dev2devfeb
> > > ___
> > > enlightenment-devel mailing list
> > > enlightenment-devel@lists.sourceforge.net
> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> > > 
> > > 
> > > 
> > > 
> > 
> 
> 



--
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [Patch] small patch for elm_module

[WooHyun Jung]

Hello. All ~ 

 

I made a patch for elm_module. 

Null setting for freed pointer ~ 

 

Can anybody check about this ?

Thanks. 

Index: src/lib/elm_module.c
===
--- src/lib/elm_module.c(revision 57211)
+++ src/lib/elm_module.c(working copy)
@@ -176,8 +176,17 @@ _elm_module_unload(Elm_Module *m)
eina_stringshare_del(m->data_dir);
eina_stringshare_del(m->bin_dir);
if (m->shutdown_func) m->shutdown_func(m);
-   if (m->api) free(m->api);
-   dlclose(m->handle);
+   if (m->api)
+ {
+free(m->api);
+m->api = NULL;
+ }
+   if (m->handle)
+ {
+if (m->shutdown_func) m->shutdown_func(m);
+dlclose(m->handle);
+m->handle = NULL;
+ }
 }
 
 Elm_Module *
--
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev ___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [Patch] small patch for elm_module

[WooHyun Jung]

No reason ! Just my mistake - T-T

I re-made the patch , thanks for nice checking. 


-Original Message-
From: Daniel Juyung Seo [mailto:seojuyu...@gmail.com] 
Sent: Thursday, March 03, 2011 3:57 PM
To: WooHyun Jung
Cc: enlightenment-devel@lists.sourceforge.net
Subject: Re: [E-devel] [Patch] small patch for elm_module

if (m->shutdown_func) m->shutdown_func(m);

...

+   if (m->handle)
+ {
+if (m->shutdown_func) m->shutdown_func(m);
+dlclose(m->handle);
+m->handle = NULL;
+ }

Any reason to do m->shutdown_func() twice?

Thanks.
Daniel Juyung Seo (SeoZ)

On Thu, Mar 3, 2011 at 2:13 AM, WooHyun Jung 
wrote:
> Hello. All ~
>
>
>
> I made a patch for elm_module.
>
> Null setting for freed pointer ~
>
>
>
> Can anybody check about this ?
>
> Thanks.
>
>
> --
>  Free Software Download: Index, Search & Analyze Logs and 
> other IT data in Real-Time with Splunk. Collect, index and harness all 
> the fast moving IT data generated by your applications, servers and 
> devices whether physical, virtual or in the cloud. Deliver compliance 
> at lower cost and gain new business insights. 
> http://p.sf.net/sfu/splunk-dev2dev
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
>
Index: src/lib/elm_module.c
===
--- src/lib/elm_module.c(revision 57211)
+++ src/lib/elm_module.c(working copy)
@@ -175,9 +175,17 @@ _elm_module_unload(Elm_Module *m)
eina_stringshare_del(m->so_path);
eina_stringshare_del(m->data_dir);
eina_stringshare_del(m->bin_dir);
-   if (m->shutdown_func) m->shutdown_func(m);
-   if (m->api) free(m->api);
-   dlclose(m->handle);
+   if (m->api)
+ {
+free(m->api);
+m->api = NULL;
+ }
+   if (m->handle)
+ {
+if (m->shutdown_func) m->shutdown_func(m);
+dlclose(m->handle);
+m->handle = NULL;
+ }
 }
 
 Elm_Module *
--
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev ___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [Patch] anchorview's "clicked" signal is always sent when mouse up.

[WooHyun Jung]

Hello. All. 

I've checked "anchor,clicked" signal is always sent with mouse_up. 

That is, mouse_down on the anchor -> mouse_move out from the anchor ->
mouse_up can emit "anchor,clicked" signal.

So I made one patch for right clicked signal emitting. 

Can anybody check about this ? 

Thanks. 

Index: src/lib/edje_entry.c
===
--- src/lib/edje_entry.c(revision 57517)
+++ src/lib/edje_entry.c(working copy)
@@ -620,15 +620,20 @@ _edje_anchor_mouse_up_cb(void *data, Evas *e __UNU
if ((rp->part->select_mode == EDJE_ENTRY_SELECTION_MODE_EXPLICIT) &&
(en->select_allow))
   return;
+   n = an->name;
+   if (!n) n = "";
+   len = 200 + strlen(n);
+   buf = alloca(len);
if ((!ev->event_flags) || (!ignored))
  {
-n = an->name;
-if (!n) n = "";
-len = 200 + strlen(n);
-buf = alloca(len);
 snprintf(buf, len, "anchor,mouse,up,%i,%s", ev->button, n);
 _edje_emit(rp->edje, buf, rp->part->name);
  }
+   if ((rp->still_in) && (rp->clicked_button == ev->button) && (!ignored))
+ {
+snprintf(buf, len, "anchor,mouse,clicked,%i,%s", ev->button, n);
+_edje_emit(rp->edje, buf, rp->part->name);
+ }
 }
 
 static void
Index: src/lib/elm_entry.c
===
--- src/lib/elm_entry.c (revision 57517)
+++ src/lib/elm_entry.c (working copy)
@@ -1201,9 +1201,16 @@ _signal_anchor_down(void *data, Evas_Object *obj _
 }
 
 static void
-_signal_anchor_up(void *data, Evas_Object *obj __UNUSED__, const char 
*emission, const char *source __UNUSED__)
+_signal_anchor_up(void *data, Evas_Object *obj __UNUSED__, const char 
*emission __UNUSED__, const char *source __UNUSED__)
 {
Widget_Data *wd = elm_widget_data_get(data);
+   if (!wd) return;
+}
+
+static void
+_signal_anchor_clicked(void *data, Evas_Object *obj __UNUSED__, const char 
*emission, const char *source __UNUSED__)
+{
+   Widget_Data *wd = elm_widget_data_get(data);
Elm_Entry_Anchor_Info ei;
char *buf2, *p, *p2, *n;
if (!wd) return;
@@ -1541,6 +1548,8 @@ elm_entry_add(Evas_Object *parent)
_signal_anchor_down, obj);
edje_object_signal_callback_add(wd->ent, "anchor,mouse,up,*", "elm.text",
_signal_anchor_up, obj);
+   edje_object_signal_callback_add(wd->ent, "anchor,mouse,clicked,*", 
"elm.text",
+   _signal_anchor_clicked, obj);
edje_object_signal_callback_add(wd->ent, "anchor,mouse,move,*", "elm.text",
_signal_anchor_move, obj);
edje_object_signal_callback_add(wd->ent, "anchor,mouse,in,*", "elm.text",
--
What You Don't Know About Data Connectivity CAN Hurt You
This paper provides an overview of data connectivity, details
its effect on application quality, and explores various alternative
solutions. http://p.sf.net/sfu/progress-d2d___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [Patch] Focus issue in elm_widget.c

[WooHyun Jung]

Hello ~ 

I've checked there were some focus problems when an object is hidden. 

So I made patch for that ~ 

Can anybody check about this ? 

Thanks.



elm_widget.patch
Description: Binary data
--
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [Patch] Focus issue in elm_widget.c

[WooHyun Jung]

Oh. Patch has bad white space ~ I modified it. 

(Thx Seoz)

 

 

From: WooHyun Jung [mailto:wh0705.j...@samsung.com] 
Sent: Friday, March 11, 2011 3:53 PM
To: 'enlightenment-devel@lists.sourceforge.net'
(enlightenment-devel@lists.sourceforge.net)
Subject: [Patch] Focus issue in elm_widget.c 

 

Hello ~ 

I've checked there were some focus problems when an object is hidden. 

So I made patch for that ~ 

Can anybody check about this ? 

Thanks.



elm_widget.patch
Description: Binary data
--
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [Patch] Small patch for elm_slider (scrolling pop + push)

[WooHyun Jung]

Hello ~ 

I made small patch for elm_slider. 

I think scrolling should be freezed (not held) when dragging is started. 

This is because scrolling can go on with elm_widget_scroll_hold_push. 

Anybody can check about this ? 

Thanks.  

 



elm_slider.patch
Description: Binary data
--
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [Patch] modify elm_widget_region_show_set (NULL checking)

[WooHyun Jung]

Hello ~ 

I modified "elm_widget_show_region_set function" about NULL checking. 

Can anybody check about this ?

Thanks. 



elm_widget.patch
Description: Binary data
--
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [Patch] Modify elm_widget_show_region_set (last patch had bad modification)

[WooHyun Jung]

Hello. All.

I've made new patch for elm_widget. 

This patch is for modification last change in elm_widget_show_region_set
function.

Can anybody check about this ? 

Thanks. 



elm_widget.patch
Description: Binary data
--
Enable your software for Intel(R) Active Management Technology to meet the
growing manageability and security demands of your customers. Businesses
are taking advantage of Intel(R) vPro (TM) technology - will your software 
be a part of the solution? Download the Intel(R) Manageability Checker 
today! http://p.sf.net/sfu/intel-dev2devmar___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [Patch] for Gettext /I18N

[WooHyun Jung]

Hello. All. 

Mr. Govi in SISO made a patch for following description. 

Can anybody check about this ? 

Thanks. 

 

--

Detail Description:

1. If EFL/Elementary Application has i18n String with its own PO file,

then Elementary will end up looking for internal Strings at application

PO files.

Passing PACKAGE name in the Elementary String Look up macro eliminates

this issue and looks for internal String from Elm.po files.

 

2. Macro E_(str) is used, to differentiate the elementary Strings from

commonly used #define _(str) in the applications. ( Just E ed :) )

 



gettext_elementary.patch
Description: Binary data
--
Enable your software for Intel(R) Active Management Technology to meet the
growing manageability and security demands of your customers. Businesses
are taking advantage of Intel(R) vPro (TM) technology - will your software 
be a part of the solution? Download the Intel(R) Manageability Checker 
today! http://p.sf.net/sfu/intel-dev2devmar___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [Patch] elm_colorselector : mouse_down (on buttons) is canceled when mouse_move.

[WooHyun Jung]

Hello. 

 

I made a patch for elm_colorselector. 

Purpose is "Mouse_down (on buttons) is canceled when mouse_move (i.e.
flicking)". 

Can anybody check about this ? 

 

Thanks. : )



colorselector.patch
Description: Binary data
--
Xperia(TM) PLAY
It's a major breakthrough. An authentic gaming
smartphone on the nation's most reliable network.
And it wants your games.
http://p.sf.net/sfu/verizon-sfdev___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [Patch] elm_colorselector : mouse_down (on buttons) is canceled when mouse_move.

[WooHyun Jung]

Hmm. But, as you said, ON_HOLD is set only by scroller. 
It means horizontal flicking can not be checked with vertical scroller.
So I implemented like this ~ 
How do you think about this ? 

-Original Message-
From: Carsten Haitzler (The Rasterman) [mailto:ras...@rasterman.com] 
Sent: Tuesday, April 12, 2011 4:58 PM
To: WooHyun Jung
Cc: enlightenment-devel@lists.sourceforge.net
Subject: Re: [E-devel] [Patch] elm_colorselector : mouse_down (on buttons)
is canceled when mouse_move.

On Mon, 11 Apr 2011 15:32:41 +0900 WooHyun Jung 
said:

you know.. you should just look at the ON_HOLD flag and/or the ON_HOLD event
callback rather than re-implement the "check if distance moved more than X"
that scroller already does (then sets hold flag - hold flag == cancel what u
were going to do before) :)

> Hello. 
> 
>  
> 
> I made a patch for elm_colorselector. 
> 
> Purpose is "Mouse_down (on buttons) is canceled when mouse_move (i.e.
> flicking)". 
> 
> Can anybody check about this ? 
> 
>  
> 
> Thanks. : )
> 


--
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com


--
Forrester Wave Report - Recovery time is now measured in hours and minutes
not days. Key insights are discussed in the 2010 Forrester Wave Report as
part of an in-depth evaluation of disaster recovery service providers.
Forrester found the best-in-class provider in terms of services and vision.
Read this report now!  http://p.sf.net/sfu/ibm-webcastpromo
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [Patch] bug fix in _elm_util_mkup_to_text function ~

[WooHyun Jung]

Hello. 

I've found one bug in _elm_util_mkup_to_text function.

If (!*p) then, it should finish the loop. 

Thx : ) 




elm_util.patch
Description: Binary data
--
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [Patch] Focus moving by arrow key.

[WooHyun Jung]

Hello. All ~ 

I've made a patch for "Focus moving by arrow key".

After adapting this patch to current elementary, you can check the change by
executing elementary_test application.

(elementary_test -> focus)

 

Can anybody check about this ? 

I welcome your advice : ) 

Thanks !!

 




arrow_focus_move.patch
Description: Binary data
--
Achieve unprecedented app performance and reliability
What every C/C++ and Fortran developer should know.
Learn how Intel has extended the reach of its next-generation tools
to help boost performance applications - inlcuding clusters.
http://p.sf.net/sfu/intel-dev2devmay___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [Patch] About _parent_focus function in elm_widget.c

[WooHyun Jung]

Hello. All. 

I think current _parent_focus function (elm_widget.c) has one problem. 

Following conditional statement(in _parent_focus func) can not cover all
cases.

 

.

if (!ret || (!i) || (i != focus_order))

 _parent_focus(o);

.

 

For example, an application calls like follows, 

1. elm_object_unfocus(a parent of newest focused object);

2. elm_object_focus(newest focused object);

then the parent(unfocused by 1) is still unfocused, even if its child gets
focused(by 2).

This is because (i == focus_order).  

 

So I made a patch. Can anybody check about this? 

Thanks. 




elm_widget.patch
Description: Binary data
--
Achieve unprecedented app performance and reliability
What every C/C++ and Fortran developer should know.
Learn how Intel has extended the reach of its next-generation tools
to help boost performance applications - inlcuding clusters.
http://p.sf.net/sfu/intel-dev2devmay___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [Patch] elm_widget_focus_steal should be executed only with "can_focus" object.

[WooHyun Jung]

Hello. All ~ 

I think elm_widget_focus_steal function should be executed only with
"can_focus" widget object.

("Cannot_focus" object has no right to steal focus from others !!)

 

How do you think about this ? 

If my idea makes sense, then plz adapt my patch : )




elm_widget.patch
Description: Binary data
--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] Question about eina_inline_lock_posix.x error.

[WooHyun Jung]

Hello~ All. 

 

If I include "pthread.h" first and then "Elementary.h", following error
message is shown. (__USE_UNIX98 = 0)

 

/usr/include/eina-1/eina/eina_inline_lock_posix.x:101:41: error:
'PTHREAD_MUTEX_ERRORCHECK' undeclared (first use in this function)

 

Should eina_inline_lock_posix.x file be modified as below ? 

 

#ifdef __USE_UNIX98

  if (pthread_mutexattr_settype(&attr, PTHREAD_MUTEX_ERRORCHECK) != 0)

return EINA_FALSE;

#else

  if (pthread_mutexattr_settype(&attr, PTHREAD_MUTEX_ERRORCHECK_NP) !=
0)

return EINA_FALSE;

#endif

 

 

 

 


--
vRanger cuts backup time in half-while increasing security.
With the market-leading solution for virtual backup and recovery, 
you get blazing-fast, flexible, and affordable data protection.
Download your free trial now. 
http://p.sf.net/sfu/quest-d2dcopy1
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] Question about edje_cc error

[WooHyun Jung]

Hello. All. 

I encountered one edje_cc error, and tried to resolve.. but hard : (

This error is shown when Macro is used. 

I attached a patch file for making problem situation.

After adapting patch, you can see the following error message. 

 

ERR<18498>:edje_cc edje_cc_parse.c:1376 _funcf() /usr/local/bin/edje_cc:
Error. ../../data/themes/default.edc:1973 unexpected character at @0)/8)

 

Does anybody have a idea about this? 


--
Simplify data backup and recovery for your virtual environment with vRanger. 
Installation's a snap, and flexible recovery options mean your data is safe,
secure and there when you need it. Data protection magic?
Nope - It's vRanger. Get your free trial download today. 
http://p.sf.net/sfu/quest-sfdev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] Question about edje_cc error

[WooHyun Jung]

Missed file ~ Sorry 




problem_edc.patch
Description: Binary data
--
Simplify data backup and recovery for your virtual environment with vRanger. 
Installation's a snap, and flexible recovery options mean your data is safe,
secure and there when you need it. Data protection magic?
Nope - It's vRanger. Get your free trial download today. 
http://p.sf.net/sfu/quest-sfdev2dev___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Question about edje_cc error

[WooHyun Jung]

Missed file Sorry T _ T

 

From: WooHyun Jung [mailto:wh0705.j...@samsung.com] 
Sent: Tuesday, May 31, 2011 9:34 PM
To: 'enlightenment-devel@lists.sourceforge.net'
Subject: Question about edje_cc error 

 

Hello. All. 

I encountered one edje_cc error, and tried to resolve.. but hard : (

This error is shown when Macro is used. 

I attached a patch file for making problem situation.

After adapting patch, you can see the following error message. 

 

ERR<18498>:edje_cc edje_cc_parse.c:1376 _funcf() /usr/local/bin/edje_cc:
Error. ../../data/themes/default.edc:1973 unexpected character at @0)/8)

 

Does anybody have a idea about this? 




problem_edc.patch
Description: Binary data
--
Simplify data backup and recovery for your virtual environment with vRanger. 
Installation's a snap, and flexible recovery options mean your data is safe,
secure and there when you need it. Data protection magic?
Nope - It's vRanger. Get your free trial download today. 
http://p.sf.net/sfu/quest-sfdev2dev___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Question about edje_cc error

[WooHyun Jung]

My result of /usr/local/bin "your data" is
((8+ 30)/8);

If my memory is correct, it was ((8+@0)/8); 
Right ? 


-Original Message-
From: Carsten Haitzler (The Rasterman) [mailto:ras...@rasterman.com] 
Sent: Wednesday, June 01, 2011 4:51 PM
To: WooHyun Jung
Cc: enlightenment-devel@lists.sourceforge.net
Subject: Re: [E-devel] Question about edje_cc error

On Tue, 31 May 2011 21:45:45 +0900 WooHyun Jung 
said:

this reduces pretty much to the attached case havign a bug :) if its "8+x"
is fails. if its "8.x" it fails. if its "8:x" it works or "8 x" it works.

> Missed file Sorry T _ T
> 
>  
> 
> From: WooHyun Jung [mailto:wh0705.j...@samsung.com]
> Sent: Tuesday, May 31, 2011 9:34 PM
> To: 'enlightenment-devel@lists.sourceforge.net'
> Subject: Question about edje_cc error
> 
>  
> 
> Hello. All. 
> 
> I encountered one edje_cc error, and tried to resolve.. but hard : (
> 
> This error is shown when Macro is used. 
> 
> I attached a patch file for making problem situation.
> 
> After adapting patch, you can see the following error message. 
> 
>  
> 
> ERR<18498>:edje_cc edje_cc_parse.c:1376 _funcf() /usr/local/bin/edje_cc:
> Error. ../../data/themes/default.edc:1973 unexpected character at 
> @0)/8)
> 
>  
> 
> Does anybody have a idea about this? 
> 
> 


--
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com



--
Simplify data backup and recovery for your virtual environment with vRanger. 
Installation's a snap, and flexible recovery options mean your data is safe,
secure and there when you need it. Data protection magic?
Nope - It's vRanger. Get your free trial download today. 
http://p.sf.net/sfu/quest-sfdev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [Patch] Improve elm_entry_filter_limit_size function.

[WooHyun Jung]

Hello ~ 

I made a patch for improving elm_entry_filter_limit_size function.

After updating this patch, elm_entry_filter_limit_size function will care
about tags and escape characters.

Can anybody check about this patch ? 

Thanks : )




entry_filter.patch
Description: Binary data
--
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: seoz IN trunk/devs: . woohyun

[WooHyun Jung]

Thanks for welcoming ~ JJ 


--
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Renaming elm_object_label_set/get

[WooHyun Jung]

Hello ~ Tom. 

 

I really really really agree with this change J

It should be ~ I think.

 

+1 to your opinion 

 

Thanks.

WooHyun. 


--
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security 
threats, fraudulent activity, and more. Splunk takes this data and makes 
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [PATCH] XIM patch for generating preedit changed event

[WooHyun Jung]

I tested this patch ~ and checked that it worked well : )

In svn 61876 !!


--
Got Input?   Slashdot Needs You.
Take our quick survey online.  Come on, we don't ask for help often.
Plus, you'll get a chance to win $100 to spend on ThinkGeek.
http://p.sf.net/sfu/slashdot-survey
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: woohyun IN trunk/elementary/src: bin lib

[WooHyun Jung]

Oh. I got your point.
Thanks for good advice ~~
I'll implement empty "elm_widget_focus_direction_go()" at first.
I thought somebody(who declared this API) had a plan to implement this,
so made simple directional scrolling function (only for diagonal movement).

Anybody ~ who is working for this API ~ then please inform to me :)


2011/8/5 Jung정우현 

> hello ~ Gustavo.
>
> Can I know that you meant "elm_widget_focus_direction_go" API ?
> And one more, what is worse API I made ?
> I only added elm_widget_can_focus_child_get API...  and I think it doesn't
> duplicate exist one.
>
>
> 2011/8/5 Gustavo Barbieri 
>
>> Sorry, but there is directional scrolling implemented. Why did you
>> duplicate it with a worse API (directional scrolling takes x,y as
>> direction parameters and may do diagonal). If it's broken or not
>> implemented it's better to fix it than to introduce something new.
>>
>> Sent from my iPhone
>>
>> On 05/08/2011, at 10:26, "Enlightenment SVN" 
>> wrote:
>>
>> > Log:
>> > elementary : Focus movement is possible with arrow keys. You can check
>> >  this feature in elementary_test -> focus.
>> >
>> >
>> > Author:   woohyun
>> > Date: 2011-08-05 01:25:07 -0700 (Fri, 05 Aug 2011)
>> > New Revision: 62125
>> > Trac: http://trac.enlightenment.org/e/changeset/62125
>> >
>> > Modified:
>> >  trunk/elementary/src/bin/test_focus.c trunk/elementary/src/lib/
>> Elementary.h.in trunk/elementary/src/lib/elm_widget.c
>> trunk/elementary/src/lib/elm_widget.h trunk/elementary/src/lib/elm_win.c
>> >
>> > Modified: trunk/elementary/src/bin/test_focus.c
>> > ===
>> > --- trunk/elementary/src/bin/test_focus.c2011-08-05 07:45:45 UTC
>> (rev 62124)
>> > +++ trunk/elementary/src/bin/test_focus.c2011-08-05 08:25:07 UTC
>> (rev 62125)
>> > @@ -91,7 +91,8 @@
>> >   {
>> >  Evas_Object *lb = elm_label_add(win);
>> >  elm_object_text_set(lb,
>> > - "Use Tab and Shift+Tab"
>> > + "Use Tab, Shift+Tab, and"
>> > + "Arrow Keys"
>> > );
>> >  evas_object_size_hint_weight_set(lb, 0.0, 0.0);
>> >  evas_object_size_hint_align_set(lb, EVAS_HINT_FILL,
>> >
>> > Modified: trunk/elementary/src/lib/Elementary.h.in
>> > ===
>> > --- trunk/elementary/src/lib/Elementary.h.in2011-08-05 07:45:45 UTC
>> (rev 62124)
>> > +++ trunk/elementary/src/lib/Elementary.h.in2011-08-05 08:25:07 UTC
>> (rev 62125)
>> > @@ -320,7 +320,11 @@
>> >typedef enum _Elm_Focus_Direction
>> >  {
>> > ELM_FOCUS_PREVIOUS,
>> > -ELM_FOCUS_NEXT
>> > +ELM_FOCUS_NEXT,
>> > +ELM_FOCUS_UP,
>> > +ELM_FOCUS_DOWN,
>> > +ELM_FOCUS_LEFT,
>> > +ELM_FOCUS_RIGHT
>> >  } Elm_Focus_Direction;
>> >
>> >typedef enum _Elm_Text_Format
>> >
>> > Modified: trunk/elementary/src/lib/elm_widget.c
>> > ===
>> > --- trunk/elementary/src/lib/elm_widget.c2011-08-05 07:45:45 UTC
>> (rev 62124)
>> > +++ trunk/elementary/src/lib/elm_widget.c2011-08-05 08:25:07 UTC
>> (rev 62125)
>> > @@ -158,6 +158,10 @@
>> > static Evas_Object *_newest_focus_order_get(Evas_Object  *obj,
>> > unsigned int
>> *newest_focus_order,
>> > Eina_Bool
>> can_focus_only);
>> > +static Eina_Bool _focus_list_direction_nearest_get(Evas_Object
>>  *obj,
>> > +Eina_List
>>  *list,
>> > +Elm_Focus_Direction
>> dir,
>> > +Evas_Object
>> **nearest);
>> >
>> > /* local subsystem globals */
>> > static Evas_Smart *_e_smart = NULL;
>> > @@ -399,6 +403,96 @@
>> >  }
>> > }
>> >
>> > +static Eina_Bool
>> > +_focus_list_direction_nearest_get(Evas_Object   

Re: [E-devel] E SVN: discomfitor trunk/elementary/src/lib

[WooHyun Jung]

+1 ~

(wanna hear Tom's opinion. Is there any reason that this API is not
deprecated yet?)

2011/10/28, Mike Blumenkrantz :
> On Thu, 27 Oct 2011 12:12:54 -0700
> "Enlightenment SVN"  wrote:
>
>> Log:
>> add long forgotten note for entry filters
>>
>>
>> Author:   discomfitor
>> Date: 2011-10-27 12:12:53 -0700 (Thu, 27 Oct 2011)
>> New Revision: 64446
>> Trac: http://trac.enlightenment.org/e/changeset/64446
>>
>> Modified:
>>   trunk/elementary/src/lib/Elementary.h.in
>>
>> Modified: trunk/elementary/src/lib/Elementary.h.in
>> ===
>> --- trunk/elementary/src/lib/Elementary.h.in 2011-10-27 18:59:57 UTC
>> (rev 64445) +++ trunk/elementary/src/lib/Elementary.h.in 2011-10-27
>> 19:12:53 UTC (rev 64446) @@ -11062,6 +11062,7 @@
>>  * @param entry The text to be displayed
>>  *
>>  * @deprecated Use elm_object_text_set() instead.
>> +* @note Using this function bypasses text filters
>>  */
>> EAPI void elm_entry_entry_set(Evas_Object *obj, const char
>> *entry) EINA_ARG_NONNULL(1); /**
>>
>>
>> --
>> The demand for IT networking professionals continues to grow, and the
>> demand for specialized networking skills is growing even more rapidly.
>> Take a complimentary Learning@Cisco Self-Assessment and learn
>> about Cisco certifications, training, and career opportunities.
>> http://p.sf.net/sfu/cisco-dev2dev
>> ___
>> enlightenment-svn mailing list
>> enlightenment-...@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
> debated putting this on text_set() too. thoughts?
>
> --
> Mike Blumenkrantz
> Zentific: Doctor recommended, mother approved.
>
> --
> The demand for IT networking professionals continues to grow, and the
> demand for specialized networking skills is growing even more rapidly.
> Take a complimentary Learning@Cisco Self-Assessment and learn
> about Cisco certifications, training, and career opportunities.
> http://p.sf.net/sfu/cisco-dev2dev
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>

--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn 
about Cisco certifications, training, and career opportunities. 
http://p.sf.net/sfu/cisco-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [PATCH] fix build warning in scim-immodule

[WooHyun Jung]

+1
I think he is the specialist for ecore imf :)

2011/12/28, ChunEon Park :
> +1 Here.
> As I know, he's been EFL Programming over 3 years.
> He will be a good member to improve our EFL.
> Thank u.
> 
> -Regards, Hermet-
>
> -Original Message-
> From: "Daniel Juyung Seo"
> To: "Enlightenment developer
> list"
> Cc:
> Sent: 11-12-28(수) 08:06:18
> Subject: Re: [E-devel] [PATCH] fix build warning in scim-immodule
> +1 here.
> He's been sending many patches so far and done a good job mainly on ecore
> imf.
> Daniel Juyung Seo (SeoZ)
> On Tue, Dec 27, 2011 at 11:28 PM, Cedric BAIL 
> wrote:
>> On Tue, Dec 27, 2011 at 3:13 PM, Iván Briano (Sachiel)
>>  wrote:
>>> 2011/12/27 Jihoon Kim :
 Here are two simple patches.

 'fix_warning_scim_imcontext.patch' is for fixing build warning 'warning:
 unused parameter' in scim-immodule.
 'fix_indent_Makefile.patch' is for fixing indentation of Makefile.am in
 immodules/scim directory.

 Would you please apply in svn?
>>>
>>> In, both at once. I changed the warning fix to include config.h
>>> at the top, as that's what we do everywhere else.
>>>
>>> I'm also wondering if your next patch shouldn't be an info.txt file
>>> and your public key.
>>
>> Sounds like a lazy way to get the work done faster and better as
>> Jihoon has been annoyingly sending patch that get in svn quite fast
>> since sometimes now. So I vote that we get less work and put the
>> burden on him by giving him svn access.
>> --
>> Cedric BAIL
>>
>> --
>> Write once. Port to many.
>> Get the SDK and tools to simplify cross-platform app development. Create
>> new or port existing apps to sell to consumers worldwide. Explore the
>> Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
>> http://p.sf.net/sfu/intel-appdev
>> ___
>> enlightenment-devel mailing list
>> enlightenment-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> --
> Write once. Port to many.
> Get the SDK and tools to simplify cross-platform app development. Create
> new or port existing apps to sell to consumers worldwide. Explore the
> Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
> http://p.sf.net/sfu/intel-appdev
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> --
> Write once. Port to many.
> Get the SDK and tools to simplify cross-platform app development. Create
> new or port existing apps to sell to consumers worldwide. Explore the
> Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
> http://p.sf.net/sfu/intel-appdev
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>

--
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create 
new or port existing apps to sell to consumers worldwide. Explore the 
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [PATCH] Add "longpress_timeout" in "_elm_config" structure.

[woohyun jung]

Hello. I'm WooHyun Jung. 

I wanna add "longpress_timeout" in "_elm_config" structure. 
I checked ~ some winsets did hard-coding about setting timeout of long press 
event. 
(For example :  wd->longpress_timeout = LONGPRESS_TIMEOUT in elm_genlist.c)
So, I thought ~ it would be better if "longpress_timeout" is in _elm_config 
structure. 

Please check my patch file ~ 
If I need to do something more ~ don't hesitate to give advice ~ 
Thanks ! 
--
Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
Tap into the largest installed PC base & get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [PATCH] Some modifications about elm_colorselector.c and elm_entry.c

[WooHyun Jung]

Hello. I'm WooHyun Jung.

 

I modified some codes of elm_colorselector.c . 

And , for about elm_entry.c , I thought that "SIG_CLICKED" was wrongly
emitted (by "MOUSE_UP" event).

So I changed it. 

 

Please check attached patch file. 

Thanks. 

Index: src/lib/elm_colorselector.c
===
--- src/lib/elm_colorselector.c (revision 54926)
+++ src/lib/elm_colorselector.c (working copy)
@@ -14,8 +14,22 @@
 #define LIG_STEP 256.0
 #define ALP_STEP 256.0
 
+typedef enum _Button_State
+{
+   BUTTON_RELEASED,
+   L_BUTTON_PRESSED,
+   R_BUTTON_PRESSED
+} Button_State;
+
+typedef enum _Color_Type
+{
+   HUE,
+   SATURATION,
+   LIGHTNESS,
+   ALPHA
+} Color_Type;
+
 typedef struct _Colorselector_Data Colorselector_Data;
-
 struct _Colorselector_Data
 {
Evas_Object *parent;
@@ -26,12 +40,11 @@ struct _Colorselector_Data
Evas_Object *bg_rect;
Evas_Object *arrow;
Evas_Object *touch_area;
-   int colorselector_num;
-   int button_state;
+   Color_Type color_type;
+   Button_State button_state;
 };
 
 typedef struct _Widget_Data Widget_Data;
-
 struct _Widget_Data
 {
Evas_Object *base;
@@ -46,13 +59,6 @@ struct _Widget_Data
Ecore_Timer *mv_timer;
 };
 
-typedef enum
-{
-   BUTTON_RELEASED,
-   L_BUTTON_PRESSED,
-   R_BUTTON_PRESSED
-} Button_State;
-
 static const char *widtype = NULL;
 
 static void _del_hook(Evas_Object *obj);
@@ -317,9 +323,9 @@ _draw_rects(void *data, double x)
Widget_Data *wd = elm_widget_data_get(cp->parent);
double one_six = 1.0 / 6.0;
 
-   switch (cp->colorselector_num)
+   switch (cp->color_type)
  {
- case 0:
+ case HUE:
 wd->h = 360.0 * x;
 
 if (x < one_six)
@@ -377,26 +383,25 @@ _draw_rects(void *data, double x)
   wd->a);
 break;
 
- case 1:
+ case SATURATION:
 wd->s = 1.0 - x;
 _color_with_saturation(wd);
 evas_object_color_set(wd->cp[1]->arrow, wd->sr, wd->sg, wd->sb, 255);
 break;
 
- case 2:
+ case LIGHTNESS:
 wd->l = x;
 _color_with_lightness(wd);
 evas_object_color_set(wd->cp[2]->arrow, wd->lr, wd->lg, wd->lb, 255);
 break;
 
- case 3:
+ case ALPHA:
 wd->a = 255.0 * x;
 evas_object_color_set(wd->cp[3]->arrow, wd->er, wd->eg, wd->eb, wd->a);
 break;
 
  default:
 break;
-
  }
_hsl_to_rgb(wd);
 }
@@ -502,10 +507,23 @@ _left_button_down_cb(void *data, Evas *e __UNUSED_
   "left_button");
edje_object_part_drag_value_get(cp->colorbar, "elm.arrow", &x, &y);
 
-   if (!cp->colorselector_num) x -= 1.0 / HUE_STEP;
-   else if (cp->colorselector_num == 1) x -= 1.0 / SAT_STEP;
-   else if (cp->colorselector_num == 2) x -= 1.0 / LIG_STEP;
-   else if (cp->colorselector_num == 3) x -= 1.0 / ALP_STEP;
+   switch(cp->color_type)
+ {
+  case HUE :
+ x -= 1.0 / HUE_STEP;
+ break;
+  case SATURATION :
+ x -= 1.0 / SAT_STEP;
+ break;
+  case LIGHTNESS :
+ x -= 1.0 / LIG_STEP;
+ break;
+  case ALPHA :
+ x -= 1.0 / ALP_STEP;
+ break;
+  default : 
+ break; 
+ }
 
if (x < 0.0) x = 0.0;
 
@@ -528,10 +546,23 @@ _right_button_down_cb(void *data, Evas *e __UNUSED
   "right_button");
edje_object_part_drag_value_get(cp->colorbar, "elm.arrow", &x, &y);
 
-   if (!cp->colorselector_num) x += 1.0 / HUE_STEP;
-   else if (cp->colorselector_num == 1) x += 1.0 / SAT_STEP;
-   else if (cp->colorselector_num == 2) x += 1.0 / LIG_STEP;
-   else if (cp->colorselector_num == 3) x += 1.0 / ALP_STEP;
+   switch(cp->color_type)
+ {
+  case HUE :
+ x += 1.0 / HUE_STEP;
+ break;
+  case SATURATION :
+ x += 1.0 / SAT_STEP;
+ break;
+  case LIGHTNESS :
+ x += 1.0 / LIG_STEP;
+ break;
+  case ALPHA :
+ x += 1.0 / ALP_STEP;
+ break;
+  default : 
+ break; 
+ }
 
if (x > 1.0) x = 1.0;
 
@@ -604,9 +635,25 @@ _add_colorbar(Evas_Object *obj)
wd->cp[i] = ELM_NEW(Colorselector_Data);
 
wd->cp[i]->parent = obj;
-   wd->cp[i]->colorselector_num = i;
-
-   /* load colorbar area */
+wd->cp[i]->color_type = i;
+switch(i)
+  {
+   case 0 :
+  wd->cp[i]->color_type = HUE;
+  break;
+   case 1 :
+  wd->cp[i]->color_type = SATURATION;
+  break;
+   case 2 :
+  wd->cp[i]->color_type = LIGHTNESS;
+  break;
+   case 3 :
+  wd->cp[i]->colo

Re: [E-devel] [PATCH] Some modifications about elm_colorselector.c and elm_entry.c

[WooHyun Jung]

Hello ~ 
I modified my patch. 

The reason for modifying about elm_colorselector can be "readability".
Each bar in the colorselector has its own color type (like hue, saturation,
...)
So I thought it will be better, if I added enum for each color type. 

And about elm_entry, 
I deleted mouse_up callback function (as you advised), 
because this function didn't do anything by my modification.

Thanks. 

-Original Message-
From: Bruno Dilly [mailto:bdi...@profusion.mobi] 
Sent: Wednesday, November 24, 2010 11:35 PM
To: WooHyun Jung
Cc: enlightenment-devel@lists.sourceforge.net
Subject: Re: [E-devel] [PATCH] Some modifications about elm_colorselector.c
and elm_entry.c

On Wed, Nov 24, 2010 at 11:44 AM, WooHyun Jung 
wrote:
> Hello. I'm WooHyun Jung.
>
>
>
> I modified some codes of elm_colorselector.c .

Hey WooHyun,

would you matter to explain me why are you proposing the following
change, please?

@@ -604,9 +635,25 @@ _add_colorbar(Evas_Object *obj)
wd->cp[i] = ELM_NEW(Colorselector_Data);

wd->cp[i]->parent = obj;
-   wd->cp[i]->colorselector_num = i;
-
-   /* load colorbar area */
+wd->cp[i]->color_type = i;
+switch(i)
+  {
+   case 0 :
+  wd->cp[i]->color_type = HUE;
+  break;
+   case 1 :
+  wd->cp[i]->color_type = SATURATION;
+  break;
+   case 2 :
+  wd->cp[i]->color_type = LIGHTNESS;
+  break;
+   case 3 :
+  wd->cp[i]->color_type = ALPHA;
+  break;
+   default :
+  break;
+  }
+/* load colorbar area */

It's insider a for (i = 0; i < 4; i++).
Basically you are doing
  wd->cp[0]->color_type = 0;
then "i" will match case 0 and:
  wd->cp[0]->color_type = 0 (HUE) once again...

Or maybe I'm missing something.

>
> And , for about elm_entry.c , I thought that "SIG_CLICKED" was wrongly
> emitted (by "MOUSE_UP" event).

If you are proposing to use _signal_mouse_clicked instead of
_signal_mouse_up your patch should remove this function. Don't leave
dead code, please.

Thank you

>
> So I changed it.
>
>
>
> Please check attached patch file.
>
> Thanks.
>
>
>

--
> Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
> Tap into the largest installed PC base & get more eyes on your game by
> optimizing for Intel(R) Graphics Technology. Get started today with the
> Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
> http://p.sf.net/sfu/intelisp-dev2dev
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
>
Index: elm_colorselector.c
===
--- elm_colorselector.c (revision 55060)
+++ elm_colorselector.c (working copy)
@@ -14,8 +14,22 @@
 #define LIG_STEP 256.0
 #define ALP_STEP 256.0
 
+typedef enum _Button_State
+{
+   BUTTON_RELEASED,
+   L_BUTTON_PRESSED,
+   R_BUTTON_PRESSED
+} Button_State;
+
+typedef enum _Color_Type
+{
+   HUE,
+   SATURATION,
+   LIGHTNESS,
+   ALPHA
+} Color_Type;
+
 typedef struct _Colorselector_Data Colorselector_Data;
-
 struct _Colorselector_Data
 {
Evas_Object *parent;
@@ -26,12 +40,11 @@ struct _Colorselector_Data
Evas_Object *bg_rect;
Evas_Object *arrow;
Evas_Object *touch_area;
-   int colorselector_num;
-   int button_state;
+   Color_Type color_type;
+   Button_State button_state;
 };
 
 typedef struct _Widget_Data Widget_Data;
-
 struct _Widget_Data
 {
Evas_Object *base;
@@ -46,13 +59,6 @@ struct _Widget_Data
Ecore_Timer *mv_timer;
 };
 
-typedef enum
-{
-   BUTTON_RELEASED,
-   L_BUTTON_PRESSED,
-   R_BUTTON_PRESSED
-} Button_State;
-
 static const char *widtype = NULL;
 
 static void _del_hook(Evas_Object *obj);
@@ -317,9 +323,9 @@ _draw_rects(void *data, double x)
Widget_Data *wd = elm_widget_data_get(cp->parent);
double one_six = 1.0 / 6.0;
 
-   switch (cp->colorselector_num)
+   switch (cp->color_type)
  {
- case 0:
+ case HUE:
 wd->h = 360.0 * x;
 
 if (x < one_six)
@@ -377,26 +383,25 @@ _draw_rects(void *data, double x)
   wd->a);
 break;
 
- case 1:
+ case SATURATION:
 wd->s = 1.0 - x;
 _color_with_saturation(wd);
 evas_object_color_set(wd->cp[1]->arrow, wd->sr, wd->sg, wd->sb, 255);
 break;
 
- case 2:
+ case LIGHTNESS:
 wd->l = x;
 _color_with_lightness(wd);
 evas_object_co

[E-devel] [PATCH] Some modifications for adapting elm_longpress_timeout_get().

[WooHyun Jung]

Hello. I'm WooHyun Jung. 

 

I made a patch for adapting elm_longpress_timeout_get() function to all
winsets, using long press event. 

And I checked one warning in elm_entry.c , so I modified it. 

 

Thanks. 

Index: elm_list.c
===
--- elm_list.c  (revision 55319)
+++ elm_list.c  (working copy)
@@ -842,7 +842,7 @@ _mouse_down(void *data, Evas *evas __UNUSED__, Eva
_item_hilight(it);
wd->longpressed = EINA_FALSE;
if (it->long_timer) ecore_timer_del(it->long_timer);
-   it->long_timer = ecore_timer_add(1.0, _long_press, it);
+   it->long_timer = ecore_timer_add(elm_longpress_timeout_get(), _long_press, 
it);
if (it->swipe_timer) ecore_timer_del(it->swipe_timer);
it->swipe_timer = ecore_timer_add(0.4, _swipe_cancel, it);
/* Always call the callbacks last - the user may delete our context! */
Index: elm_map.c
===
--- elm_map.c   (revision 55319)
+++ elm_map.c   (working copy)
@@ -1038,7 +1038,7 @@ _mouse_down(void *data, Evas *evas __UNUSED__, Eva
  evas_object_smart_callback_call(data, SIG_PRESS, NULL);
wd->longpressed = EINA_FALSE;
if (wd->long_timer) ecore_timer_del(wd->long_timer);
-   wd->long_timer = ecore_timer_add(1.0, _long_press, data);
+   wd->long_timer = ecore_timer_add(elm_longpress_timeout_get(), _long_press, 
data);
 }
 
 static void
Index: elm_entry.c
===
--- elm_entry.c (revision 55319)
+++ elm_entry.c (working copy)
@@ -834,7 +834,7 @@ _mouse_down(void *data, Evas *evas __UNUSED__, Eva
if (ev->button != 1) return;
//   if (ev->flags & EVAS_BUTTON_DOUBLE_CLICK)
if (wd->longpress_timer) ecore_timer_del(wd->longpress_timer);
-   wd->longpress_timer = ecore_timer_add(1.0, _long_press, data);
+   wd->longpress_timer = ecore_timer_add(elm_longpress_timeout_get(), 
_long_press, data);
wd->downx = ev->canvas.x;
wd->downy = ev->canvas.y;
 }
@@ -1517,7 +1517,7 @@ _get_item(void *data, Evas_Object *edje __UNUSED__
  }
if (!strncmp(item, "file://", 7))
  {
-char *fname = item + 7;
+const char *fname = item + 7;

 o = evas_object_image_filled_add(evas_object_evas_get(data));
 evas_object_image_file_set(o, fname, NULL);
Index: elm_photocam.c
===
--- elm_photocam.c  (revision 55319)
+++ elm_photocam.c  (working copy)
@@ -654,7 +654,7 @@ _mouse_down(void *data, Evas *evas __UNUSED__, Eva
  evas_object_smart_callback_call(data, "press", NULL);
wd->longpressed = EINA_FALSE;
if (wd->long_timer) ecore_timer_del(wd->long_timer);
-   wd->long_timer = ecore_timer_add(1.0, _long_press, data);
+   wd->long_timer = ecore_timer_add(elm_longpress_timeout_get(), _long_press, 
data);
 }

 static void
Index: elm_colorselector.c
===
--- elm_colorselector.c (revision 55319)
+++ elm_colorselector.c (working copy)
@@ -532,7 +532,7 @@ _left_button_down_cb(void *data, Evas *e __UNUSED_
evas_object_smart_callback_call(cp->parent, SIG_CHANGED, NULL);
cp->button_state = L_BUTTON_PRESSED;
if (wd->lp_timer) ecore_timer_del(wd->lp_timer);
-   wd->lp_timer = ecore_timer_add(1.0, _long_press_timer, cp);
+   wd->lp_timer = ecore_timer_add(elm_longpress_timeout_get(), 
_long_press_timer, cp);
 }
 
 static void
@@ -570,7 +570,7 @@ _right_button_down_cb(void *data, Evas *e __UNUSED
_draw_rects(data, x);
evas_object_smart_callback_call(cp->parent, SIG_CHANGED, NULL);
cp->button_state = R_BUTTON_PRESSED;
-   wd->lp_timer = ecore_timer_add(1.0, _long_press_timer, cp);
+   wd->lp_timer = ecore_timer_add(elm_longpress_timeout_get(), 
_long_press_timer, cp);
 }
 
 static void
Index: elm_gengrid.c
===
--- elm_gengrid.c   (revision 55319)
+++ elm_gengrid.c   (working copy)
@@ -783,7 +783,7 @@ _mouse_down(void *data, Evas *evas __UNUSED__, Eva
  evas_object_smart_callback_call(item->wd->self, "clicked", item);
if (item->long_timer) ecore_timer_del(item->long_timer);
if (item->realized)
- item->long_timer = ecore_timer_add(1.0, _long_press, item);
+ item->long_timer = ecore_timer_add(elm_longpress_timeout_get(), 
_long_press, item);
else
  item->long_timer = NULL;
 }
--
What happens now with your Lotus Notes apps - do you make another costly 
upgrade, or settle for being marooned without product support? Time to move
off Lotus Notes and onto the cloud with Force.com, apps are easier to build,
use, and manage than apps on tradi

Re: [E-devel] [PATCH] Some modifications for adapting elm_longpress_timeout_get().

[WooHyun Jung]

Oh. Thanks for your advice. 
I made new patch, using _elm_config->longpress_timeout directly.
(This patch also includes longpress in genlist)


-Original Message-
From: Daniel Juyung Seo [mailto:seojuyu...@gmail.com] 
Sent: Monday, December 06, 2010 10:54 PM
To: WooHyun Jung
Cc: enlightenment-devel@lists.sourceforge.net
Subject: Re: [E-devel] [PATCH] Some modifications for adapting
elm_longpress_timeout_get().

Dear Woohyun,

Why don't you use _elm_config->longpress_timeout instead of calling
elm_longpress_timeout_get()?
It reduces the function call overhead(it's so tiny overhead though)
and I've seen elementary widgets were using _elm_config.
Please consider this.

And longpress in genlist is missing :)
That's what I was planning to patch.

Thanks.

Daniel Juyung Seo.


On Mon, Dec 6, 2010 at 9:40 PM, WooHyun Jung 
wrote:
> Hello. I'm WooHyun Jung.
>
>
>
> I made a patch for adapting elm_longpress_timeout_get() function to all
> winsets, using long press event.
>
> And I checked one warning in elm_entry.c , so I modified it.
>
>
>
> Thanks.
>
>
>

--
> What happens now with your Lotus Notes apps - do you make another costly
> upgrade, or settle for being marooned without product support? Time to
move
> off Lotus Notes and onto the cloud with Force.com, apps are easier to
build,
> use, and manage than apps on traditional platforms. Sign up for the Lotus
> Notes Migration Kit to learn more. http://p.sf.net/sfu/salesforce-d2d
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
>
Index: elm_entry.c
===
--- elm_entry.c (revision 55335)
+++ elm_entry.c (working copy)
@@ -834,7 +834,7 @@ _mouse_down(void *data, Evas *evas __UNUSED__, Eva
if (ev->button != 1) return;
//   if (ev->flags & EVAS_BUTTON_DOUBLE_CLICK)
if (wd->longpress_timer) ecore_timer_del(wd->longpress_timer);
-   wd->longpress_timer = ecore_timer_add(1.0, _long_press, data);
+   wd->longpress_timer = ecore_timer_add(_elm_config->longpress_timeout, 
_long_press, data);
wd->downx = ev->canvas.x;
wd->downy = ev->canvas.y;
 }
@@ -1517,7 +1517,7 @@ _get_item(void *data, Evas_Object *edje __UNUSED__
  }
if (!strncmp(item, "file://", 7))
  {
-char *fname = item + 7;
+const char *fname = item + 7;

 o = evas_object_image_filled_add(evas_object_evas_get(data));
 evas_object_image_file_set(o, fname, NULL);
Index: elm_genlist.c
===
--- elm_genlist.c   (revision 55335)
+++ elm_genlist.c   (working copy)
@@ -2227,7 +2227,7 @@ elm_genlist_add(Evas_Object *parent)
wd->mode = ELM_LIST_SCROLL;
wd->max_items_per_block = MAX_ITEMS_PER_BLOCK;
wd->item_cache_max = wd->max_items_per_block * 2;
-   wd->longpress_timeout = LONGPRESS_TIMEOUT;
+   wd->longpress_timeout = _elm_config->longpress_timeout;
 
evas_object_smart_callback_add(obj, "scroll-hold-on", _hold_on, obj);
evas_object_smart_callback_add(obj, "scroll-hold-off", _hold_off, obj);
Index: elm_list.c
===
--- elm_list.c  (revision 55335)
+++ elm_list.c  (working copy)
@@ -842,7 +842,7 @@ _mouse_down(void *data, Evas *evas __UNUSED__, Eva
_item_hilight(it);
wd->longpressed = EINA_FALSE;
if (it->long_timer) ecore_timer_del(it->long_timer);
-   it->long_timer = ecore_timer_add(1.0, _long_press, it);
+   it->long_timer = ecore_timer_add(_elm_config->longpress_timeout, 
_long_press, it);
if (it->swipe_timer) ecore_timer_del(it->swipe_timer);
it->swipe_timer = ecore_timer_add(0.4, _swipe_cancel, it);
/* Always call the callbacks last - the user may delete our context! */
Index: elm_gengrid.c
===
--- elm_gengrid.c   (revision 55335)
+++ elm_gengrid.c   (working copy)
@@ -783,7 +783,7 @@ _mouse_down(void *data, Evas *evas __UNUSED__, Eva
  evas_object_smart_callback_call(item->wd->self, "clicked", item);
if (item->long_timer) ecore_timer_del(item->long_timer);
if (item->realized)
- item->long_timer = ecore_timer_add(1.0, _long_press, item);
+ item->long_timer = ecore_timer_add(_elm_config->longpress_timeout, 
_long_press, item);
else
  item->long_timer = NULL;
 }
Index: elm_photocam.c
===
--- elm_photocam.c  (revision 55335)
+++ elm_photocam.c  (working cop

[E-devel] [PATCH] Patch for elm_slider.c (if you click the bar of the slider, the button will be at there.)

[WooHyun Jung]

Hello ~ I'm WooHyun Jung.

I made one patch for elm_slider.c file.

If you click the bar of the slider, the button will be located at there.

(If you keep your "mouse_down" after moving of the button, you can
continuously move the button.)

Thanks.

Index: src/lib/elm_slider.c
===
--- src/lib/elm_slider.c(revision 8)
+++ src/lib/elm_slider.c(working copy)
@@ -78,6 +78,7 @@ static void _drag_down(void *data, Evas_Object *ob
 const char *emission, const char *source);
 static Eina_Bool _event_hook(Evas_Object *obj, Evas_Object *src,
  Evas_Callback_Type type, void *event_info);
+static void _spacer_cb(void *data, Evas * e, Evas_Object * obj, void 
*event_info);
 
 static const char SIG_CHANGED[] = "changed";
 static const char SIG_DELAY_CHANGED[] = "delay,changed";
@@ -434,6 +435,33 @@ _drag_down(void *data, Evas_Object *obj __UNUSED__
edje_object_part_drag_step(wd->slider, "elm.dragable.slider", step, step);
 }
 
+static void
+_spacer_cb(void *data, Evas * e, Evas_Object * obj, void *event_info)
+{
+   Widget_Data *wd = elm_widget_data_get(data);
+   Evas_Event_Mouse_Down *ev = event_info;
+   Evas_Coord x, y, w, h;
+   double button_x, button_y;
+
+   evas_object_geometry_get(wd->spacer, &x, &y, &w, &h);
+   edje_object_part_drag_value_get(wd->slider, "elm.dragable.slider", 
&button_x, &button_y);
+   if(wd->horizontal)
+ {
+button_x = ((double)ev->output.x - (double)x) / (double)w;
+if (button_x > 1) button_x = 1;
+if (button_x < 0) button_x = 0;
+ }
+   else 
+ {
+button_y = ((double)ev->output.y - (double)y) / (double)h;
+if (button_y > 1) button_y = 1;
+if (button_y < 0) button_y = 0;
+ }
+   edje_object_part_drag_value_set(wd->slider, "elm.dragable.slider", 
button_x, button_y);
+   evas_event_feed_mouse_cancel(e, 0, NULL);
+   evas_event_feed_mouse_down(e, 1, EVAS_BUTTON_NONE, 0, NULL);  
+}
+
 /**
  * Add a new slider to the parent
  *
@@ -488,7 +516,7 @@ elm_slider_add(Evas_Object *parent)
evas_object_pass_events_set(wd->spacer, EINA_TRUE);
elm_widget_sub_object_add(obj, wd->spacer);
edje_object_part_swallow(wd->slider, "elm.swallow.bar", wd->spacer);
-
+   evas_object_event_callback_add(wd->spacer, EVAS_CALLBACK_MOUSE_DOWN, 
_spacer_cb, obj);
evas_object_smart_callback_add(obj, "sub-object-del", _sub_del, obj);
 
_sizing_eval(obj);
--
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [PATCH] Patch for password (showing the last character of password)

[WooHyun Jung]

Hello ~ all. 

Shilpa Onkar Singh (in India) made a patch for the password. 

After adapting enveloped patches, please export
ELM_PASSWORD_SHOW_LAST_CHARACTER=1.

Then the last charcter of password will be shown. (You can check this with
"Entry Scrolled" in elementary_test)

Thanks.

Index: src/lib/edje_program.c
===
--- src/lib/edje_program.c  (revision 55575)
+++ src/lib/edje_program.c  (working copy)
@@ -963,6 +963,13 @@ _edje_program_run(Edje *ed, Edje_Program *pr, Eina
  if (_edje_block_break(ed)) goto break_prog;
   }
 break;
+  case EDJE_ACTION_TYPE_HIDE_VISIBLE_PASSWORD:
+  {
+ Edje_Real_Part *part;
+ part = ed->table_parts[pr->param.dst % ed->table_parts_size];
+ _edje_entry_hide_visible_password(part);
+  }
+break;
  default:
 // _edje_emit(ed, "program,start", pr->name);
 // _edje_emit(ed, "program,stop", pr->name);
Index: src/lib/edje_private.h
===
--- src/lib/edje_private.h  (revision 55575)
+++ src/lib/edje_private.h  (working copy)
@@ -358,7 +358,9 @@ typedef struct _Edje_Part_Box_Animation
 #define EDJE_ENTRY_EDIT_MODE_SELECTABLE 1
 #define EDJE_ENTRY_EDIT_MODE_EDITABLE 2
 #define EDJE_ENTRY_EDIT_MODE_PASSWORD 3
+#define EDJE_ENTRY_EDIT_MODE_PASSWORD_SHOW_LAST_CHARACTER 4
 
+
 #define EDJE_ENTRY_SELECTION_MODE_DEFAULT 0
 #define EDJE_ENTRY_SELECTION_MODE_EXPLICIT 1
 
@@ -1731,6 +1733,7 @@ void _edje_lua_script_only_message(Edje *ed, Edje_
 void _edje_entry_init(Edje *ed);
 void _edje_entry_shutdown(Edje *ed);
 void _edje_entry_real_part_init(Edje_Real_Part *rp);
+void _edje_entry_hide_visible_password(Edje_Real_Part *rp);
 void _edje_entry_real_part_shutdown(Edje_Real_Part *rp);
 void _edje_entry_real_part_configure(Edje_Real_Part *rp);
 const char *_edje_entry_selection_get(Edje_Real_Part *rp);
Index: src/lib/Edje.h
===
--- src/lib/Edje.h  (revision 55575)
+++ src/lib/Edje.h  (working copy)
@@ -144,7 +144,8 @@ typedef enum _Edje_Action_Type
EDJE_ACTION_TYPE_FOCUS_OBJECT  = 10,
EDJE_ACTION_TYPE_PARAM_COPY= 11,
EDJE_ACTION_TYPE_PARAM_SET = 12,
-   EDJE_ACTION_TYPE_LAST  = 13
+   EDJE_ACTION_TYPE_HIDE_VISIBLE_PASSWORD = 13, 
+   EDJE_ACTION_TYPE_LAST  = 14
 } Edje_Action_Type;
 
 typedef enum _Edje_Tween_Mode
Index: src/lib/edje_entry.c
===
--- src/lib/edje_entry.c(revision 55575)
+++ src/lib/edje_entry.c(working copy)
@@ -996,6 +996,27 @@ _delete(Evas_Textblock_Cursor *c, Evas_Object *o _
evas_textblock_cursor_char_delete(c);
 }
 
+void
+_edje_entry_hide_visible_password(Edje_Real_Part *rp)
+{
+   Entry *en = rp->entry_data;
+   const Evas_Object_Textblock_Node_Format *node;
+   node = evas_textblock_node_format_first_get(rp->object);
+   for (; node ; node = evas_textblock_node_format_next_get(node))
+ {
+const char *text = evas_textblock_node_format_text_get(node);
+if (text)
+  {
+ if (!strcmp(text, "+ password=off"))
+   {
+  evas_textblock_node_format_remove_pair(rp->object, 
(Evas_Object_Textblock_Node_Format *)node);
+  break;
+   }
+  }
+ }
+   _edje_entry_real_part_configure(rp);
+}
+
 static void
 _edje_key_down_cb(void *data, Evas *e __UNUSED__, Evas_Object *obj __UNUSED__, 
void *event_info)
 {
@@ -1322,9 +1343,20 @@ _edje_key_down_cb(void *data, Evas *e __UNUSED__,
  if (en->have_selection)
 _range_del(en->cursor, rp->object, en);
  _sel_clear(en->cursor, rp->object, en);
- //zz
-// evas_textblock_cursor_text_prepend(en->cursor, ev->string);
- _text_filter_text_prepend(en, en->cursor, ev->string);
+ //   if PASSWORD_SHOW_LAST_CHARACTER mode, appending it with 
password tag
+ if (rp->part->entry_mode == 
EDJE_ENTRY_EDIT_MODE_PASSWORD_SHOW_LAST_CHARACTER)
+   {
+  _edje_entry_hide_visible_password(en->rp);
+  _text_filter_markup_prepend(en, en->cursor, 
"");
+  _text_filter_markup_prepend(en, en->cursor, ev->string);
+  _text_filter_markup_prepend(en, en->cursor, "");
+   }
+ else
+   {
+  //zz
+  //   evas_textblock_cursor_text_prepend(en->cursor, 
ev->string);
+  _text_filter_text_prepend(en, en->cursor, ev->string);
+   }
  _curs_update_from_curs(en->cursor, rp->object, en);
  _anchors_get(en->cursor, rp->object, en);
  _edje_emit(ed, "entry,changed", rp->part->name);
@@ -1794,7 +1826,7 @@ _edje_entry_real_part_init(Edje_Real_Part

[E-devel] [PATCH] patch for elm_button.

[WooHyun Jung]

Hello. I'm WooHyun Jung. 

Rajeev Ranjan(in India) made a patch for elm_button. 

Reasons for this patch are as follows. 

1. Clicked signal is emitted from button when mouse release region coincides
with button region and there has not been any drag outside the region during
pressed state. (theme change)

2. Unpressed signal is emitted from button every time we press on button and
unpress it irrespective of whether we unpress in button's region or outside.
(theme change)

3. The unsetting of maximum size hint has been removed from _sizing_eval
function as there is a possibility that some application may set this hint
and if we unset it then this information set by application will be lost.

4. Modification in test code for button to show the difference between
clicked and unpressed signal emission from this widget. Added a scroller in
the heirarchy to show the effect of hold on clicked signal emission.

 

Index: AUTHORS
===
--- AUTHORS (revision 55647)
+++ AUTHORS (working copy)
@@ -28,3 +28,4 @@ Tiago Falcão 
 Otavio Pontes 
 Viktor Kojouharov 
 Daniel Juyung Seo (SeoZ)  
+Rajeev Ranjan (Rajeev)  
Index: src/lib/elm_button.c
===
--- src/lib/elm_button.c(revision 55647)
+++ src/lib/elm_button.c(working copy)
@@ -161,14 +161,13 @@ static void
 _sizing_eval(Evas_Object *obj)
 {
Widget_Data *wd = elm_widget_data_get(obj);
-   Evas_Coord minw = -1, minh = -1, maxw = -1, maxh = -1;
+   Evas_Coord minw = -1, minh = -1;
 
if (!wd) return;
elm_coords_finger_size_adjust(1, &minw, 1, &minh);
edje_object_size_min_restricted_calc(wd->btn, &minw, &minh, minw, minh);
elm_coords_finger_size_adjust(1, &minw, 1, &minh);
evas_object_size_hint_min_set(obj, minw, minh);
-   evas_object_size_hint_max_set(obj, maxw, maxh);
 }
 
 static void
@@ -209,7 +208,6 @@ _activate(Evas_Object *obj)
  }
wd->repeating = EINA_FALSE;
evas_object_smart_callback_call(obj, SIG_CLICKED, NULL);
-   _signal_unpressed(obj, wd->btn, NULL, NULL); /* safe guard when the theme 
does not emit the 'unpress' signal */
 }
 
 static void
Index: src/bin/test_button.c
===
--- src/bin/test_button.c   (revision 55647)
+++ src/bin/test_button.c   (working copy)
@@ -15,10 +15,26 @@ _bt_repeated(void *data __UNUSED__, Evas_Object *o
elm_button_label_set(obj, buf);
 }
 
+static void
+_bt_clicked(void *data, Evas_Object * obj, void *event_info)
+{
+   int param = (int)(data);
+
+   printf("clicked event on Button:%d\n", param);
+}
+
+static void
+_bt_unpressed(void *data, Evas_Object * obj, void *event_info)
+{
+   int param = (int)(data);
+
+   printf("unpressed event on Button:%d\n", param);
+}
+
 void
 test_button(void *data __UNUSED__, Evas_Object *obj __UNUSED__, void 
*event_info __UNUSED__)
 {
-   Evas_Object *win, *bg, *bx, *ic, *bt;
+   Evas_Object *win, *bg, *scr, *bx, *ic, *bt;
char buf[PATH_MAX];
 
win = elm_win_add(NULL, "buttons", ELM_WIN_BASIC);
@@ -30,9 +46,16 @@ test_button(void *data __UNUSED__, Evas_Object *ob
evas_object_size_hint_weight_set(bg, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
evas_object_show(bg);
 
+   scr = elm_scroller_add(win);
+   elm_scroller_bounce_set(scr, EINA_FALSE, EINA_TRUE);
+   elm_scroller_policy_set(scr, ELM_SCROLLER_POLICY_OFF, 
ELM_SCROLLER_POLICY_AUTO);
+   elm_win_resize_object_add(win, scr);
+   evas_object_show(scr);
+   evas_object_size_hint_weight_set(scr, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
+
bx = elm_box_add(win);
evas_object_size_hint_weight_set(bx, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
-   elm_win_resize_object_add(win, bx);
+   elm_scroller_content_set(scr, bx);
evas_object_show(bx);
 
ic = elm_icon_add(win);
@@ -42,17 +65,21 @@ test_button(void *data __UNUSED__, Evas_Object *ob
bt = elm_button_add(win);
elm_button_label_set(bt, "Icon sized to button");
elm_button_icon_set(bt, ic);
+   evas_object_smart_callback_add(bt, "clicked", _bt_clicked, (void *)1);
+   evas_object_smart_callback_add(bt, "unpressed", _bt_unpressed, (void *)1);
elm_box_pack_end(bx, bt);
evas_object_show(bt);
evas_object_show(ic);
 
-   ic = elm_icon_add(win);
+   ic = elm_icon_add(bx);
snprintf(buf, sizeof(buf), "%s/images/logo_small.png", PACKAGE_DATA_DIR);
elm_icon_file_set(ic, buf, NULL);
elm_icon_scale_set(ic, 0, 0);
bt = elm_button_add(win);
elm_button_label_set(bt, "Icon no scale");
elm_button_icon_set(bt, ic);
+   evas_object_smart_callback_add(bt, "clicked", _bt_clicked, (void *)2);
+   evas_object_smart_callback_add(bt, "unpressed", _bt_unpressed, (void *)2);
elm_box_pack_end(bx, bt);
evas_object_show(bt);
evas_object_show(

[E-devel] [PATCH] patch for elm_colorselector.

[WooHyun Jung]

Hello~ all. 

 

I made a patch for elm_colorselector. 

Some unnecessary codes are deleted. 

( evas_object_show(obj); codes can be deleted if the obj will be swallowed.
)

 

Thanks. 

Index: src/lib/elm_colorselector.c
===
--- src/lib/elm_colorselector.c (revision 55695)
+++ src/lib/elm_colorselector.c (working copy)
@@ -672,14 +672,12 @@ _add_colorbar(Evas_Object *obj)
edje_object_signal_callback_add(wd->cp[i]->colorbar, "drag", "*",
_arrow_cb, wd->cp[i]);
edje_object_part_swallow(wd->base, colorbar_s, wd->cp[i]->colorbar);
-   evas_object_show(wd->cp[i]->colorbar);
elm_widget_sub_object_add(obj, wd->cp[i]->colorbar);
 
/* load colorbar image */
wd->cp[i]->bar = edje_object_add(e);
_elm_theme_object_set(obj, wd->cp[i]->bar, "colorselector", "image",
  colorbar_name);
-   evas_object_show(wd->cp[i]->bar);
edje_object_part_swallow(wd->cp[i]->colorbar, "elm.bar",
  wd->cp[i]->bar);
elm_widget_sub_object_add(obj, wd->cp[i]->bar);
@@ -692,7 +690,6 @@ _add_colorbar(Evas_Object *obj)
evas_object_event_callback_add(wd->cp[i]->touch_area,
   EVAS_CALLBACK_MOUSE_DOWN, _colorbar_cb,
   wd->cp[i]);
-   evas_object_show(wd->cp[i]->touch_area);
elm_widget_sub_object_add(obj, wd->cp[i]->touch_area);
 
/* load background rectangle of the colorbar. used for
@@ -702,7 +699,6 @@ _add_colorbar(Evas_Object *obj)
 wd->cp[i]->bg_rect = evas_object_rectangle_add(e);
  evas_object_color_set(wd->cp[i]->bg_rect, wd->er, wd->eg, wd->eb,
255);
-evas_object_show(wd->cp[i]->bg_rect);
 edje_object_part_swallow(wd->cp[i]->colorbar, "elm.bar_bg",
  wd->cp[i]->bg_rect);
 
@@ -713,7 +709,6 @@ _add_colorbar(Evas_Object *obj)
  wd->cp[i]->bg_rect = edje_object_add(e);
  _elm_theme_object_set(obj, wd->cp[i]->bg_rect, "colorselector",
"bg_image", colorbar_name);
- evas_object_show(wd->cp[i]->bg_rect);
  edje_object_part_swallow(wd->cp[i]->colorbar, "elm.bar_bg",
   wd->cp[i]->bg_rect);
  elm_widget_sub_object_add(obj, wd->cp[i]->bg_rect);
@@ -723,7 +718,6 @@ _add_colorbar(Evas_Object *obj)
wd->cp[i]->arrow = edje_object_add(e);
_elm_theme_object_set(obj, wd->cp[i]->arrow, "colorselector", "image",
  "updown");
-   evas_object_show(wd->cp[i]->arrow);
edje_object_part_swallow(wd->cp[i]->colorbar, "elm.arrow_icon",
 wd->cp[i]->arrow);
elm_widget_sub_object_add(obj, wd->cp[i]->arrow);
@@ -740,7 +734,6 @@ _add_colorbar(Evas_Object *obj)
   _left_button_down_cb, wd->cp[i]);
evas_object_event_callback_add(wd->cp[i]->lbt, EVAS_CALLBACK_MOUSE_UP,
   _left_button_up_cb, wd->cp[i]);
-   evas_object_show(wd->cp[i]->lbt);
edje_object_part_swallow(wd->cp[i]->colorbar, "elm.l_button",
 wd->cp[i]->lbt);
elm_widget_sub_object_add(obj, wd->cp[i]->lbt);
@@ -753,7 +746,6 @@ _add_colorbar(Evas_Object *obj)
   _right_button_down_cb, wd->cp[i]);
evas_object_event_callback_add(wd->cp[i]->rbt, EVAS_CALLBACK_MOUSE_UP,
   _right_button_up_cb, wd->cp[i]);
-   evas_object_show(wd->cp[i]->rbt);
edje_object_part_swallow(wd->cp[i]->colorbar, "elm.r_button",
 wd->cp[i]->rbt);
elm_widget_sub_object_add(obj, wd->cp[i]->rbt);
--
Forrester recently released a report on the Return on Investment (ROI) of
Google Apps. They found a 300% ROI, 38%-56% cost savings, and break-even
within 7 months.  Over 3 million businesses have gone Google with Google Apps:
an online email calendar, and document program that's accessible from your 
browser. Read the Forrester report: http://p.sf.net/sfu/googleapps-sfnew___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [Patch] small patch for elm_main.c

[WooHyun Jung]

Hello ~ all. 

I found one small bug in elm_main.c

"exe" is used just after "free(exe)". (in elm_quicklaunch_prepare()
function)

Can anybody check about this ? 

Thanks. 

Index: src/lib/elm_main.c
===
--- src/lib/elm_main.c  (revision 55742)
+++ src/lib/elm_main.c  (working copy)
@@ -755,7 +755,6 @@ elm_quicklaunch_prepare(int argc __UNUSED__,
 return EINA_FALSE;
  }
INF("dlopen('%s') = %p", exe, qr_handle);
-   free(exe);
qr_main = dlsym(qr_handle, "elm_main");
INF("dlsym(%p, 'elm_main') = %p", qr_handle, qr_main);
if (!qr_main)
@@ -763,8 +762,10 @@ elm_quicklaunch_prepare(int argc __UNUSED__,
 WRN("not quicklauncher capable: no elm_main in '%s'", exe);
 dlclose(qr_handle);
 qr_handle = NULL;
+   free(exe);
 return EINA_FALSE;
  }
+   free(exe);
return EINA_TRUE;
 #else
return EINA_FALSE;
--
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [Patch] small patch for elm_pager.c

[WooHyun Jung]

Hello, all. 

I'm WooHyun Jung. 

I felt strange with the following codes in elm_pager.c

Why it->content should be hidden after deleted ? 

Is it a bug ? 

I made a small patch for this

Thanks.. 

 

static void

_signal_hide_finished(void *data, Evas_Object *obj __UNUSED__, const char
*emission __UNUSED__, const char *source __UNUSED__)

{

.

if (it->popme) evas_object_del(it->content);

   evas_object_hide(it->content);

_sizing_eval(obj2);

}

 

Index: src/lib/elm_pager.c
===
--- src/lib/elm_pager.c (revision 56055)
+++ src/lib/elm_pager.c (working copy)
@@ -222,8 +222,8 @@ _signal_hide_finished(void *data, Evas_Object *obj
edje_object_signal_emit(it->base, "elm,action,reset", "elm");
evas_object_smart_callback_call(obj2, "hide,finished", it->content);
edje_object_message_signal_process(it->base);
+   evas_object_hide(it->content);
if (it->popme) evas_object_del(it->content);
-   evas_object_hide(it->content);
_sizing_eval(obj2);
 }
 
--
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] elm_mod_shutdown in elm.c (in edje_externals) is not called.

[WooHyun Jung]

Hello. I'm WooHyun Jung. 

One question about not calling elm_mod_shutdown in elm.c (in
edje_externals).

I've tested with elementary_test and I checked elm_mod_init is called when
initiating.

But elm_mode_shutdown was not called when elementary_test is terminated. 

By this situation elm_init is called twice but elm_shutdown is called just
once. 

Can anybody check about this ? 

Thanks. 

--
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] elm_mod_shutdown in elm.c (in edje_externals) is not called.

[WooHyun Jung]

Oh ~ Thanks for good information. 



--
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] elm_mod_shutdown in elm.c (in edje_externals) is not called.

[WooHyun Jung]

The above reply was my mistake - I wrongly mailed to all. Sorry. ^^;

-Original Message-
From: WooHyun Jung [mailto:wh0705.j...@samsung.com] 
Sent: Thursday, January 13, 2011 12:04 PM
To: 'enlightenment-devel@lists.sourceforge.net'
Subject: RE: [E-devel] elm_mod_shutdown in elm.c (in edje_externals) is not
called.

Oh ~ Thanks for good information. 



--
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [Patch] small patch for elm_main.c

[WooHyun Jung]

Hello ~ 

I made small patch for elm_main.c

In elm_all_flush function, I was suspicious about, 

if _elm_win_list is NULL then following codes should not be called or not.  

 

ejde_file_cache_flush();

edje_collection_cache_flush();

eet_clearcache();

 

I thinks above functions should be called without any consideration about
the state of _elm_win_list. 

Can anybody check about this ? 

Thanks. 

Index: src/lib/elm_main.c
===
--- src/lib/elm_main.c  (revision 56218)
+++ src/lib/elm_main.c  (working copy)
@@ -1829,12 +1829,12 @@ elm_all_flush(void)
const Eina_List *l;
Evas_Object *obj;
 
+   edje_file_cache_flush();
+   edje_collection_cache_flush();
+   eet_clearcache();
EINA_LIST_FOREACH(_elm_win_list, l, obj)
  {
 Evas *e = evas_object_evas_get(obj);
-edje_file_cache_flush();
-edje_collection_cache_flush();
-eet_clearcache();
 evas_image_cache_flush(e);
 evas_font_cache_flush(e);
 evas_render_dump(e);
--
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [Patch] small patch for elm_main.c

[WooHyun Jung]

Hello ~ 

I made small patch for elm_main.c

In elm_all_flush function, I was suspicious about, 

if _elm_win_list is NULL then following codes should not be called or not.  

 

ejde_file_cache_flush();

edje_collection_cache_flush();

eet_clearcache();

 

I thinks above functions should be called without any consideration about
the state of _elm_win_list. 

Can anybody check about this ? 

Thanks. 

Index: src/lib/elm_main.c
===
--- src/lib/elm_main.c  (revision 56218)
+++ src/lib/elm_main.c  (working copy)
@@ -1829,12 +1829,12 @@ elm_all_flush(void)
const Eina_List *l;
Evas_Object *obj;
 
+   edje_file_cache_flush();
+   edje_collection_cache_flush();
+   eet_clearcache();
EINA_LIST_FOREACH(_elm_win_list, l, obj)
  {
 Evas *e = evas_object_evas_get(obj);
-edje_file_cache_flush();
-edje_collection_cache_flush();
-eet_clearcache();
 evas_image_cache_flush(e);
 evas_font_cache_flush(e);
 evas_render_dump(e);
--
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [Patch] patch for elm_main.c (about elm_all_flush func)

[WooHyun Jung]

Hello ~ 

I made small patch for elm_main.c

In elm_all_flush function, I was suspicious about, 

if _elm_win_list is NULL then following codes should not be called or not.  

 

ejde_file_cache_flush();

edje_collection_cache_flush();

eet_clearcache();

 

I thinks above functions should be called without any consideration about
the state of _elm_win_list. 

Can anybody check about this ? 

Thanks. 

Index: src/lib/elm_main.c
===
--- src/lib/elm_main.c  (revision 56218)
+++ src/lib/elm_main.c  (working copy)
@@ -1829,12 +1829,12 @@ elm_all_flush(void)
const Eina_List *l;
Evas_Object *obj;
 
+   edje_file_cache_flush();
+   edje_collection_cache_flush();
+   eet_clearcache();
EINA_LIST_FOREACH(_elm_win_list, l, obj)
  {
 Evas *e = evas_object_evas_get(obj);
-edje_file_cache_flush();
-edje_collection_cache_flush();
-eet_clearcache();
 evas_image_cache_flush(e);
 evas_font_cache_flush(e);
 evas_render_dump(e);
--
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [Patch] patch for elm_main.c (about elm_all_flush func)

[WooHyun Jung]

Oh. I checked below link for finding my first request - but it was not
updated. 
(The title was "[Patch] small patch for elm_main.c" )
http://www.mail-archive.com/enlightenment-devel@lists.sourceforge.net/index.
html

So I re-sent the mail with the new subject.
Sorry for bothering T-T 


-Original Message-
From: Mike Blumenkrantz [mailto:m...@zentific.com] 
Sent: Friday, January 21, 2011 4:57 PM
To: WooHyun Jung
Cc: enlightenment-devel@lists.sourceforge.net
Subject: Re: [E-devel] [Patch] patch for elm_main.c (about elm_all_flush
func)

On Fri, 21 Jan 2011 16:43:43 +0900
WooHyun Jung  wrote:

> Hello ~
> 
> I made small patch for elm_main.c
> 
> In elm_all_flush function, I was suspicious about,
> 
> if _elm_win_list is NULL then following codes should not be called or not.

> 
>  
> 
> ejde_file_cache_flush();
> 
> edje_collection_cache_flush();
> 
> eet_clearcache();
> 
>  
> 
> I thinks above functions should be called without any consideration 
> about the state of _elm_win_list.
> 
> Can anybody check about this ? 
> 
> Thanks. 
> 
err...double send?

--
Mike Blumenkrantz
Zentific: NULL pointer dereferences now 50% off!


--
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [Patch] patch for elm_main.c (about elm_all_flush func)

[WooHyun Jung]

Oh ! Thanks for nice tip ^^ 
I'll care for not bothering anyone at here. 

-Original Message-
From: Tom Hacohen [mailto:tom.haco...@partner.samsung.com] 
Sent: Friday, January 21, 2011 5:47 PM
To: WooHyun Jung
Cc: 'Mike Blumenkrantz'; enlightenment-devel@lists.sourceforge.net
Subject: Re: [E-devel] [Patch] patch for elm_main.c (about elm_all_flush func)

Nice tip:
Just modify the settings for your mailing list account so it'll send you a copy 
of your own emails, so you'll get them in your inbox when they get to the 
mailing list.

--
Tom.

On Fri, 2011-01-21 at 17:32 +0900, WooHyun Jung wrote:
> Oh. I checked below link for finding my first request - but it was not 
> updated.
> (The title was "[Patch] small patch for elm_main.c" ) 
> http://www.mail-archive.com/enlightenment-devel@lists.sourceforge.net/index.
> html
> 
> So I re-sent the mail with the new subject.
> Sorry for bothering T-T
> 
> 
> -Original Message-
> From: Mike Blumenkrantz [mailto:m...@zentific.com]
> Sent: Friday, January 21, 2011 4:57 PM
> To: WooHyun Jung
> Cc: enlightenment-devel@lists.sourceforge.net
> Subject: Re: [E-devel] [Patch] patch for elm_main.c (about 
> elm_all_flush
> func)
> 
> On Fri, 21 Jan 2011 16:43:43 +0900
> WooHyun Jung  wrote:
> 
> > Hello ~
> > 
> > I made small patch for elm_main.c
> > 
> > In elm_all_flush function, I was suspicious about,
> > 
> > if _elm_win_list is NULL then following codes should not be called or not.
> 
> > 
> >  
> > 
> > ejde_file_cache_flush();
> > 
> > edje_collection_cache_flush();
> > 
> > eet_clearcache();
> > 
> >  
> > 
> > I thinks above functions should be called without any consideration 
> > about the state of _elm_win_list.
> > 
> > Can anybody check about this ? 
> > 
> > Thanks. 
> > 
> err...double send?
> 
> --
> Mike Blumenkrantz
> Zentific: NULL pointer dereferences now 50% off!
> 
> 
> --
>  Special Offer-- Download ArcSight Logger for FREE (a $49 USD 
> value)!
> Finally, a world-class log management solution at an even better price-free!
> Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
> February 28th, so secure your free ArcSight Logger TODAY!
> http://p.sf.net/sfu/arcsight-sfd2d
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel



--
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[EGIT] [core/efl] master 01/01: efl_ui_internal_text_interactive: fix undefined symbol issue

[WooHyun Jung]

xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=d2ed28bd8aa7f407d13cb5eb6db4e98cc663ce89

commit d2ed28bd8aa7f407d13cb5eb6db4e98cc663ce89
Author: WooHyun Jung 
Date:   Fri Nov 22 12:51:06 2019 +0100

efl_ui_internal_text_interactive: fix undefined symbol issue

Summary: This fixes an issue from d7352f4db41dc8975eaeb3f79dff326338a5a63c.

Reviewers: segfaultxavi, bu5hm4n

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10725
---
 src/lib/elementary/efl_ui_internal_text_interactive.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/elementary/efl_ui_internal_text_interactive.c 
b/src/lib/elementary/efl_ui_internal_text_interactive.c
index 51c66b5cbb..5f623f83d5 100644
--- a/src/lib/elementary/efl_ui_internal_text_interactive.c
+++ b/src/lib/elementary/efl_ui_internal_text_interactive.c
@@ -824,7 +824,7 @@ _key_down_cb(void *data EINA_UNUSED, Evas *e EINA_UNUSED, 
Evas_Object *obj, void
 _key_down_sel_pre(obj, cur, en, shift, EINA_TRUE);
 
 #if defined(__APPLE__) && defined(__MACH__)
-if (altgr) efl_text_cursor_word_end(cur);
+if (altgr) efl_text_cursor_move(cur, 
EFL_TEXT_CURSOR_MOVE_TYPE_WORD_END);
 #else
 /* If control is pressed, go to the end of the word */
 if (control) efl_text_cursor_move(cur, 
EFL_TEXT_CURSOR_MOVE_TYPE_WORD_END);

-- 

[EGIT] [core/efl] master 01/02: efl_ui_position_manager_grid: avoid zero division case

[WooHyun Jung]

bu5hm4n pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=62e470130c7005e85f5e1c7e039c352f31bad8b3

commit 62e470130c7005e85f5e1c7e039c352f31bad8b3
Author: WooHyun Jung 
Date:   Fri Nov 29 04:15:48 2019 +

efl_ui_position_manager_grid: avoid zero division case

This fixes the issue of zero division when columns is zero.
Sometimes columns can be zero when "pd->viewport.w = 0".

Reviewed-by: Marcel Hollerbach 
Differential Revision: https://phab.enlightenment.org/D10768
---
 src/lib/elementary/efl_ui_position_manager_grid.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/lib/elementary/efl_ui_position_manager_grid.c 
b/src/lib/elementary/efl_ui_position_manager_grid.c
index bc3124abdc..7b0ed303f5 100644
--- a/src/lib/elementary/efl_ui_position_manager_grid.c
+++ b/src/lib/elementary/efl_ui_position_manager_grid.c
@@ -706,6 +706,7 @@ 
_efl_ui_position_manager_grid_efl_ui_position_manager_entity_position_single_ite
  EINA_SAFETY_ON_FALSE_RETURN_VAL(group_consumed_ids == 0, EINA_RECT(0, 0, 
0, 0));
 
int columns = pd->viewport.w/pd->max_min_size.w;
+   if (columns == 0) return EINA_RECT(0, 0, 0, 0);
int sub_pos_id = idx - group_consumed_ids;
 
if (pd->dir == EFL_UI_LAYOUT_ORIENTATION_VERTICAL)

-- 

[EGIT] [core/elementary] master 01/01: elementary/naviframe.c : Because naviframe is focusable, it should set focus to itself when the new item is unfocusable.

[WooHyun Jung]

woohyun pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=b216de22610fd8831f03fd9fd32b9f4ffdd20c30

commit b216de22610fd8831f03fd9fd32b9f4ffdd20c30
Author: WooHyun Jung 
Date:   Mon Sep 30 10:09:23 2013 +0900

elementary/naviframe.c : Because naviframe is focusable, it should set 
focus to itself when the new item is unfocusable.
---
 src/lib/elc_naviframe.c | 30 +-
 1 file changed, 25 insertions(+), 5 deletions(-)

diff --git a/src/lib/elc_naviframe.c b/src/lib/elc_naviframe.c
index d3fc708..a81e255 100644
--- a/src/lib/elc_naviframe.c
+++ b/src/lib/elc_naviframe.c
@@ -69,7 +69,12 @@ _prev_page_focus_recover(Elm_Naviframe_Item *it)
if (newest)
  elm_object_focus_set(newest, EINA_TRUE);
else
- elm_object_focus_set(VIEW(it), EINA_TRUE);
+ {
+if (elm_object_focus_allow_get(VIEW(it)))
+  elm_object_focus_set(VIEW(it), EINA_TRUE);
+else
+  elm_object_focus_set(WIDGET(it), EINA_TRUE);
+ }
 }
 
 static void
@@ -1260,7 +1265,7 @@ _elm_naviframe_smart_focus_next(Eo *obj, void *_pd 
EINA_UNUSED, va_list *list)
Eina_Bool int_ret;
 
top_it = (Elm_Naviframe_Item *)elm_naviframe_top_item_get(obj);
-   if (!top_it) return;
+   if (!top_it) goto end;
 
list_data_get = eina_list_data_get;
 
@@ -1274,8 +1279,15 @@ _elm_naviframe_smart_focus_next(Eo *obj, void *_pd 
EINA_UNUSED, va_list *list)
  }
 
int_ret = elm_widget_focus_list_next_get(obj, l, list_data_get, dir, next);
-   if (ret) *ret = int_ret;
eina_list_free(l);
+   if (ret) *ret = int_ret;
+
+end:
+   if (!*ret)
+ {
+*next = obj;
+*ret = !elm_widget_focus_get(obj);
+ }
 }
 
 static void
@@ -1521,7 +1533,12 @@ _item_push(Eo *obj, void *_pd, va_list *list)
 it->animator = ecore_animator_add(_push_transition_cb, it);
  }
else
- elm_object_focus_set(VIEW(it), EINA_TRUE);
+ {
+if (elm_object_focus_allow_get(VIEW(it)))
+  elm_object_focus_set(VIEW(it), EINA_TRUE);
+else
+  elm_object_focus_set(WIDGET(it), EINA_TRUE);
+ }
 
sd->stack = eina_inlist_append(sd->stack, EINA_INLIST_GET(it));
 
@@ -1629,7 +1646,10 @@ _item_insert_after(Eo *obj, void *_pd, va_list *list)
  EINA_FALSE);
 evas_object_show(VIEW(it));
 evas_object_hide(VIEW(after));
-elm_object_focus_set(VIEW(it), EINA_TRUE);
+if (elm_object_focus_allow_get(VIEW(it)))
+  elm_object_focus_set(VIEW(it), EINA_TRUE);
+else
+  elm_object_focus_set(WIDGET(it), EINA_TRUE);
  }
 
elm_layout_sizing_eval(obj);

-- 

[EGIT] [core/elementary] master 01/01: elementary/elm_entry.c : evas_smart_objects_calculate in elm_widget_show_region_set can delete elm_entry.

[WooHyun Jung]

woohyun pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=534253f783aaa2a5c5abbc43656507027aee8dfd

commit 534253f783aaa2a5c5abbc43656507027aee8dfd
Author: WooHyun Jung 
Date:   Mon Oct 21 19:45:53 2013 +0900

elementary/elm_entry.c : evas_smart_objects_calculate in 
elm_widget_show_region_set can delete elm_entry.
---
 src/lib/elm_entry.c | 15 ---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/src/lib/elm_entry.c b/src/lib/elm_entry.c
index 8460dd6..ed83299 100644
--- a/src/lib/elm_entry.c
+++ b/src/lib/elm_entry.c
@@ -522,7 +522,13 @@ _elm_entry_smart_theme(Eo *obj, void *_pd, va_list *list)
  (sd->entry_edje, "elm.text", sd->input_panel_return_key_disabled);
 
if (sd->cursor_pos != 0)
- elm_entry_cursor_pos_set(obj, sd->cursor_pos);
+ {
+// elm_entry_cursor_pos_set -> cursor,changed -> widget_show_region_set
+// -> smart_objects_calculate will call all smart calculate functions,
+// and one of them can delete elm_entry.
+evas_object_ref(obj);
+elm_entry_cursor_pos_set(obj, sd->cursor_pos);
+ }
 
if (elm_widget_focus_get(obj))
  edje_object_signal_emit(sd->entry_edje, "elm,action,focus", "elm");
@@ -564,6 +570,9 @@ _elm_entry_smart_theme(Eo *obj, void *_pd, va_list *list)
 
evas_object_smart_callback_call(obj, SIG_THEME_CHANGED, NULL);
 
+   if (sd->cursor_pos != 0)
+ evas_object_unref(obj);
+
if (ret) *ret = EINA_TRUE;
 }
 
@@ -582,8 +591,8 @@ _cursor_geometry_recalc(Evas_Object *obj)
   (sd->entry_edje, "elm.text", &cx, &cy, &cw, &ch);
 if (sd->cur_changed)
   {
- elm_widget_show_region_set(obj, cx, cy, cw, ch, EINA_FALSE);
  sd->cur_changed = EINA_FALSE;
+ elm_widget_show_region_set(obj, cx, cy, cw, ch, EINA_FALSE);
   }
  }
else
@@ -656,8 +665,8 @@ _deferred_recalc_job(void *data)
   (sd->entry_edje, "elm.text", &cx, &cy, &cw, &ch);
 if (sd->cur_changed)
   {
- elm_widget_show_region_set(data, cx, cy, cw, ch, EINA_FALSE);
  sd->cur_changed = EINA_FALSE;
+ elm_widget_show_region_set(data, cx, cy, cw, ch, EINA_FALSE);
   }
  }
 }

-- 

[EGIT] [core/elementary] master 01/01: elementary/elm_entry.c : theme,changed smart callback can move the cursor position ! Thanks Daniel~

[WooHyun Jung]

woohyun pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=97972844257fd3ffc20a620844a540150def0cf9

commit 97972844257fd3ffc20a620844a540150def0cf9
Author: WooHyun Jung 
Date:   Mon Oct 21 20:59:43 2013 +0900

elementary/elm_entry.c : theme,changed smart callback can move the cursor 
position ! Thanks Daniel~
---
 src/lib/elm_entry.c | 16 +++-
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/src/lib/elm_entry.c b/src/lib/elm_entry.c
index ed83299..088b2db 100644
--- a/src/lib/elm_entry.c
+++ b/src/lib/elm_entry.c
@@ -521,14 +521,13 @@ _elm_entry_smart_theme(Eo *obj, void *_pd, va_list *list)
edje_object_part_text_input_panel_return_key_disabled_set
  (sd->entry_edje, "elm.text", sd->input_panel_return_key_disabled);
 
+   // elm_entry_cursor_pos_set -> cursor,changed -> widget_show_region_set
+   // -> smart_objects_calculate will call all smart calculate functions,
+   // and one of them can delete elm_entry.
+   evas_object_ref(obj);
+
if (sd->cursor_pos != 0)
- {
-// elm_entry_cursor_pos_set -> cursor,changed -> widget_show_region_set
-// -> smart_objects_calculate will call all smart calculate functions,
-// and one of them can delete elm_entry.
-evas_object_ref(obj);
-elm_entry_cursor_pos_set(obj, sd->cursor_pos);
- }
+ elm_entry_cursor_pos_set(obj, sd->cursor_pos);
 
if (elm_widget_focus_get(obj))
  edje_object_signal_emit(sd->entry_edje, "elm,action,focus", "elm");
@@ -570,8 +569,7 @@ _elm_entry_smart_theme(Eo *obj, void *_pd, va_list *list)
 
evas_object_smart_callback_call(obj, SIG_THEME_CHANGED, NULL);
 
-   if (sd->cursor_pos != 0)
- evas_object_unref(obj);
+   evas_object_unref(obj);
 
if (ret) *ret = EINA_TRUE;
 }

-- 

[EGIT] [core/elementary] master 01/01: elementary/elc_ctxpopup.c : Focus-direction-go should be tried after checking focus next object.

[WooHyun Jung]

woohyun pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=ab4c2efb1fa75637b716cbd14416d8b723d187e8

commit ab4c2efb1fa75637b716cbd14416d8b723d187e8
Author: WooHyun Jung 
Date:   Thu Oct 31 16:50:48 2013 +0900

elementary/elc_ctxpopup.c : Focus-direction-go should be tried after 
checking focus next object.
---
 src/lib/elc_ctxpopup.c | 11 ---
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/src/lib/elc_ctxpopup.c b/src/lib/elc_ctxpopup.c
index ec6debc..0f26cf4 100644
--- a/src/lib/elc_ctxpopup.c
+++ b/src/lib/elc_ctxpopup.c
@@ -148,22 +148,19 @@ _elm_ctxpopup_smart_event(Eo *obj, void *_pd, va_list 
*list)
  {
 if (sd->box)
   {
- double degree = 0.0;
-
  if ((!strcmp(ev->key, "Left")) ||
  (!strcmp(ev->key, "KP_Left")))
-   degree = 270.0;
+   elm_widget_focus_cycle(sd->box, ELM_FOCUS_LEFT);
  else if ((!strcmp(ev->key, "Right")) ||
   (!strcmp(ev->key, "KP_Right")))
-   degree = 90.0;
+   elm_widget_focus_cycle(sd->box, ELM_FOCUS_RIGHT);
  else if ((!strcmp(ev->key, "Up")) ||
   (!strcmp(ev->key, "KP_Up")))
-   degree = 0.0;
+   elm_widget_focus_cycle(sd->box, ELM_FOCUS_UP);
  else if ((!strcmp(ev->key, "Down")) ||
   (!strcmp(ev->key, "KP_Down")))
-   degree = 180.0;
+   elm_widget_focus_cycle(sd->box, ELM_FOCUS_DOWN);
 
- elm_widget_focus_direction_go(obj, degree);
  ev->event_flags |= EVAS_EVENT_FLAG_ON_HOLD;
  if (ret) *ret = EINA_TRUE;
  return;

-- 

[EGIT] [core/efl] master 01/01: edje/edje_entry.c : By Next/Previous, cursor can reach to the top or the bottom of entry.

[WooHyun Jung]

woohyun pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=91bd46eee96c0519a4426ddd90ceae5361f9bc3f

commit 91bd46eee96c0519a4426ddd90ceae5361f9bc3f
Author: WooHyun Jung 
Date:   Fri Nov 1 18:32:43 2013 +0900

edje/edje_entry.c : By Next/Previous, cursor can reach to the top or the 
bottom of entry.
---
 src/lib/edje/edje_entry.c | 13 +++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/src/lib/edje/edje_entry.c b/src/lib/edje/edje_entry.c
index 159a2b4..31c6d70 100644
--- a/src/lib/edje/edje_entry.c
+++ b/src/lib/edje/edje_entry.c
@@ -1879,7 +1879,11 @@ _edje_key_down_cb(void *data, Evas *e EINA_UNUSED, 
Evas_Object *obj EINA_UNUSED,
  if (shift) _sel_start(en->cursor, rp->object, en);
  else _sel_clear(ed, en->cursor, rp->object, en);
   }
-_curs_jump_line_by(en->cursor, rp->object, en, -10);
+if (!_curs_jump_line_by(en->cursor, rp->object, en, -10))
+  {
+ evas_textblock_cursor_line_set(en->cursor, 0);
+ _curs_lin_start(en->cursor, rp->object, en);
+  }
 if (en->select_allow)
   {
  if (shift) _sel_extend(ed, en->cursor, rp->object, en);
@@ -1897,7 +1901,12 @@ _edje_key_down_cb(void *data, Evas *e EINA_UNUSED, 
Evas_Object *obj EINA_UNUSED,
  if (shift) _sel_start(en->cursor, rp->object, en);
  else _sel_clear(ed, en->cursor, rp->object, en);
   }
-_curs_jump_line_by(en->cursor, rp->object, en, 10);
+if (!_curs_jump_line_by(en->cursor, rp->object, en, 10))
+  {
+ int last = _curs_line_last_get(en->cursor, rp->object, en);
+ evas_textblock_cursor_line_set(en->cursor, last);
+ _curs_lin_end(en->cursor, rp->object, en);
+  }
 if (en->select_allow)
   {
  if (shift) _sel_extend(ed, en->cursor, rp->object, en);

-- 

[EGIT] [core/elementary] master 01/01: toolbar: remove useless codes

[WooHyun Jung]

woohyun pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=e47a59568702fc8acb7b79d61c757513bee5bb5f

commit e47a59568702fc8acb7b79d61c757513bee5bb5f
Author: WooHyun Jung 
Date:   Sat Mar 21 09:45:59 2015 +0900

toolbar: remove useless codes
---
 src/lib/elm_toolbar.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/lib/elm_toolbar.c b/src/lib/elm_toolbar.c
index cb4278b..ad3b5c2 100644
--- a/src/lib/elm_toolbar.c
+++ b/src/lib/elm_toolbar.c
@@ -950,7 +950,6 @@ static void
 _resizing_eval(Evas_Object *obj)
 {
Evas_Coord x, y, h;
-   Evas_Coord mw = -1, mh = -1;
ELM_TOOLBAR_DATA_GET(obj, sd);
 
evas_object_geometry_get(obj, &x, &y, NULL, &h);

-- 

[EGIT] [admin/devs] master 01/01: developer/jypark: update public key

[WooHyun Jung]

woohyun pushed a commit to branch master.

http://git.enlightenment.org/admin/devs.git/commit/?id=7f5b38603ac23c7304d561889e267009849feaff

commit 7f5b38603ac23c7304d561889e267009849feaff
Author: WooHyun Jung 
Date:   Tue Mar 24 11:24:22 2015 +0900

developer/jypark: update public key
---
 developers/jypark/id_rsa.pub | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/developers/jypark/id_rsa.pub b/developers/jypark/id_rsa.pub
index 816a5ec..b1b734c 100755
--- a/developers/jypark/id_rsa.pub
+++ b/developers/jypark/id_rsa.pub
@@ -1 +1 @@
-ssh-rsa 
B3NzaC1yc2EDAQABAAACAQDBF6g8OEG5lXgIQEetaPgajWVayVHCPJqAc4kN9N3219DTtPMgDr4UOYRJPFFweIIahRReMTu3caUlVnkc5OijrGjEqEODesAzKQ3OQOX6sr9rQ2NpIz3dRnH102SSKGqoGh8NeEGG713w6WRk1Gw0mGVbh2YZkpAskaZXi0815z0L307oGyKEHEcL4nsvQQ5PM52CiXRdzcgcEuDb+ntlwezh1zrQojr4Y4hlTfu0tNSaMAIM7NELCLDKay56paMIA4Y2OrPJrCXLVORwSg6+hrqCpv+1FcNBJbK6xY4YVcj4I6u1lW4X522qsjFMZLfKI3FajioOSqiydYQgEiq2MTK1EfkKnczLjvb2B8gL8uvrJpX38bUyhNbZzC0iwa9ApATtGZnkqNihXHVdwDt+2obmKMs2SFF4d2wamso5AizzCUH3ENfrQvhP88z4oe/d6SU0
 [...]
+ssh-rsa 
B3NzaC1yc2EDAQABAAABAQDEJzgZ5SvuOFlw6ydEXMLluacbxp9njs/1WdI1OyoIioL3U4u7tqMfcEQmiCoF0KyxFCPljG2Q3PYU998Wl8XPuF5xxsiGo4SLQIPqHrgD2ppFuLXYUbcx+1ud9fGkrOKd0mW59by0/otOHy3sWlZx/uv77VvpTkl7sffKvn2mmoNss8seWWSneQui6FTmBfhVP6lbnES0nBq4+3tls7a40RVL2dgVK9Cc2cLYh2IGjqWG5fSEdaU2cHJqXMoC77EXxyGsNmejzsbeX45cwWS8JnzW01v5zX7VcpSocoC/+XgbxSqtgMZrMQyRkIey6IeUaIpt7q4ngy45hKU0VFMJ
 jy0703.p...@samsung.com

--