Re: [E-devel] [EGIT] [core/efl] 14/15: ecore_evas/wayland_shm: Fixed window resize.
This case makes clear that we actually want to see the commits made
from other person to appear on the mailing list. There were 13 from
devilhorns that missed the ML because it was Antognolli who pushed
them. Please fix the hook script.
In the case that someone has a dirty tree, I mean, some commits on top
of HEAD, and wants to push a patch made by another person which has
nothing to to with his current work in progress, I'd suggest that the
commiter do it in a separate branch.
Regards, Etrunko
On Tue, Feb 19, 2013 at 10:26 AM, Enlightenment Git
no-re...@enlightenment.org wrote:
antognolli pushed a commit to branch devs/antognolli/work.
commit dc0d88df9cd12839c2cd2c931e3510a2478ca59d
Author: Rafael Antognolli rafael.antogno...@linux.intel.com
Date: Mon Feb 18 14:31:17 2013 -0300
ecore_evas/wayland_shm: Fixed window resize.
Using the server_allocation/allocation to determine the resize offset
was not completely precise, and causing the window to not always resize
correctly.
Additionally, calling evas_engine_info_set() on every resize step caused
the window content to blink and resize very slow, because the swap
buffer, swapper, and everything were being destroyed and recreated. Now
only the swapbuf_reconfigure is being called during the resize, which is
way faster.
---
.../engines/wayland/ecore_evas_wayland_shm.c | 20 ++-
.../engines/wayland_shm/Evas_Engine_Wayland_Shm.h | 5 +--
src/modules/evas/engines/wayland_shm/evas_engine.c | 41
++
.../evas/engines/wayland_shm/evas_swapper.c| 10 +++---
4 files changed, 34 insertions(+), 42 deletions(-)
diff --git a/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_shm.c
b/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_shm.c
index 6105863..27e9865 100644
--- a/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_shm.c
+++ b/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_shm.c
@@ -299,28 +299,14 @@ _ecore_evas_wl_resize(Ecore_Evas *ee, int w, int h)
if (wdata-win)
{
Ecore_Wl_Window *win;
- Evas_Coord x = 0, y = 0;
Evas_Engine_Info_Wayland_Shm *einfo;
win = wdata-win;
- if (win-surface)
- {
- if (win-edges 4)
-x = win-server_allocation.w - win-allocation.w;
- if (win-edges 1)
-y = win-server_allocation.h - win-allocation.h;
- }
-
- win-edges = 0;
if ((einfo = (Evas_Engine_Info_Wayland_Shm
*)evas_engine_info_get(ee-evas)))
- {
- printf(Setting Resize Edges: %d %d\n, x, y);
- einfo-info.edges.x = x;
- einfo-info.edges.y = y;
- if (!evas_engine_info_set(ee-evas, (Evas_Engine_Info
*)einfo))
-ERR(evas_engine_info_set() for engine '%s' failed.,
ee-driver);
- }
+ einfo-info.edges = win-edges;
+
+ win-edges = 0;
win-server_allocation = win-allocation;
ecore_wl_window_update_size(wdata-win, w, h);
diff --git a/src/modules/evas/engines/wayland_shm/Evas_Engine_Wayland_Shm.h
b/src/modules/evas/engines/wayland_shm/Evas_Engine_Wayland_Shm.h
index 7482cde..b1cb310 100644
--- a/src/modules/evas/engines/wayland_shm/Evas_Engine_Wayland_Shm.h
+++ b/src/modules/evas/engines/wayland_shm/Evas_Engine_Wayland_Shm.h
@@ -18,10 +18,7 @@ struct _Evas_Engine_Info_Wayland_Shm
unsigned int rotation, depth;
Eina_Bool destination_alpha : 1;
-struct
- {
- int x, y;
- } edges;
+int edges;
} info;
/* non-blocking or blocking mode */
diff --git a/src/modules/evas/engines/wayland_shm/evas_engine.c
b/src/modules/evas/engines/wayland_shm/evas_engine.c
index f6fc17e..4c5802d 100644
--- a/src/modules/evas/engines/wayland_shm/evas_engine.c
+++ b/src/modules/evas/engines/wayland_shm/evas_engine.c
@@ -9,6 +9,7 @@ typedef struct _Render_Engine Render_Engine;
struct _Render_Engine
{
+ Evas_Engine_Info_Wayland_Shm *info;
Outbuf *ob;
Tilebuf *tb;
@@ -237,13 +238,14 @@ eng_setup(Evas *eo_evas, void *einfo)
}
if (!(re =
- _output_engine_setup(info-info.edges.x, info-info.edges.y,
- epd-output.w, epd-output.h,
- info-info.rotation, info-info.depth,
- info-info.destination_alpha,
- info-info.wl_shm, info-info.wl_surface,
+ _output_engine_setup(0, 0,
+ epd-output.w, epd-output.h,
+ info-info.rotation, info-info.depth,
+
Re: [E-devel] [EGIT] [core/efl] 14/15: ecore_evas/wayland_shm: Fixed window resize.
On 20/02/13 15:20, Eduardo Lima (Etrunko) wrote: This case makes clear that we actually want to see the commits made from other person to appear on the mailing list. There were 13 from devilhorns that missed the ML because it was Antognolli who pushed them. Please fix the hook script. Ah, that was the problem. I was wondering if I missed the mails. Yeah, definitely needs to be fixed. Thanks for the explanation. Daniel -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] 14/15: ecore_evas/wayland_shm: Fixed window resize.
I don't understand the problem you are describing. Why would Antognolli pushing them cause any problems? I fixed some issues yesterday afternoon, so maybe the problem you are describing doesn't exist. On Wed, Feb 20, 2013 at 3:37 PM, Daniel Willmann d.willm...@samsung.comwrote: On 20/02/13 15:20, Eduardo Lima (Etrunko) wrote: This case makes clear that we actually want to see the commits made from other person to appear on the mailing list. There were 13 from devilhorns that missed the ML because it was Antognolli who pushed them. Please fix the hook script. Ah, that was the problem. I was wondering if I missed the mails. Yeah, definitely needs to be fixed. Thanks for the explanation. Daniel -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Tom. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] 14/15: ecore_evas/wayland_shm: Fixed window resize.
On Wed, Feb 20, 2013 at 12:41 PM, Tom Hacohen t...@stosb.com wrote: I don't understand the problem you are describing. Why would Antognolli pushing them cause any problems? I fixed some issues yesterday afternoon, so maybe the problem you are describing doesn't exist. Ok, so devilhorns started some work (13 patches) and shared with antognolli, who fixed some things on his original patches and also added other two new commits to the set and pushed them. The only commits we got on the ML were antognolli's, whle devilhorns' were missed. The range in the repository is 5526a29417d7fd57be69f079256e9511a5c41037..8be4940bb356838c28b72553c277762d581206c6. On Wed, Feb 20, 2013 at 3:37 PM, Daniel Willmann d.willm...@samsung.comwrote: On 20/02/13 15:20, Eduardo Lima (Etrunko) wrote: This case makes clear that we actually want to see the commits made from other person to appear on the mailing list. There were 13 from devilhorns that missed the ML because it was Antognolli who pushed them. Please fix the hook script. Ah, that was the problem. I was wondering if I missed the mails. Yeah, definitely needs to be fixed. Thanks for the explanation. Daniel -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Tom. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Eduardo de Barros Lima ◤✠◢ ebl...@gmail.com -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] 14/15: ecore_evas/wayland_shm: Fixed window resize.
Is it from yesterday? If so, I think it's because I messed it up a bit (and later fixed it). Unless you think you know what's wrong. It should be fine now. On Wed, Feb 20, 2013 at 3:50 PM, Eduardo Lima (Etrunko) ebl...@gmail.comwrote: On Wed, Feb 20, 2013 at 12:41 PM, Tom Hacohen t...@stosb.com wrote: I don't understand the problem you are describing. Why would Antognolli pushing them cause any problems? I fixed some issues yesterday afternoon, so maybe the problem you are describing doesn't exist. Ok, so devilhorns started some work (13 patches) and shared with antognolli, who fixed some things on his original patches and also added other two new commits to the set and pushed them. The only commits we got on the ML were antognolli's, whle devilhorns' were missed. The range in the repository is 5526a29417d7fd57be69f079256e9511a5c41037..8be4940bb356838c28b72553c277762d581206c6. On Wed, Feb 20, 2013 at 3:37 PM, Daniel Willmann d.willm...@samsung.com wrote: On 20/02/13 15:20, Eduardo Lima (Etrunko) wrote: This case makes clear that we actually want to see the commits made from other person to appear on the mailing list. There were 13 from devilhorns that missed the ML because it was Antognolli who pushed them. Please fix the hook script. Ah, that was the problem. I was wondering if I missed the mails. Yeah, definitely needs to be fixed. Thanks for the explanation. Daniel -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Tom. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Eduardo de Barros Lima ◤✠◢ ebl...@gmail.com -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Tom. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] 14/15: ecore_evas/wayland_shm: Fixed window resize.
Yep, it is, and I pushed devilhorn's changes after talking to him about it. On Wed, Feb 20, 2013 at 1:15 PM, Tom Hacohen t...@stosb.com wrote: Is it from yesterday? If so, I think it's because I messed it up a bit (and later fixed it). Unless you think you know what's wrong. It should be fine now. On Wed, Feb 20, 2013 at 3:50 PM, Eduardo Lima (Etrunko) ebl...@gmail.comwrote: On Wed, Feb 20, 2013 at 12:41 PM, Tom Hacohen t...@stosb.com wrote: I don't understand the problem you are describing. Why would Antognolli pushing them cause any problems? I fixed some issues yesterday afternoon, so maybe the problem you are describing doesn't exist. Ok, so devilhorns started some work (13 patches) and shared with antognolli, who fixed some things on his original patches and also added other two new commits to the set and pushed them. The only commits we got on the ML were antognolli's, whle devilhorns' were missed. The range in the repository is 5526a29417d7fd57be69f079256e9511a5c41037..8be4940bb356838c28b72553c277762d581206c6. On Wed, Feb 20, 2013 at 3:37 PM, Daniel Willmann d.willm...@samsung.com wrote: On 20/02/13 15:20, Eduardo Lima (Etrunko) wrote: This case makes clear that we actually want to see the commits made from other person to appear on the mailing list. There were 13 from devilhorns that missed the ML because it was Antognolli who pushed them. Please fix the hook script. Ah, that was the problem. I was wondering if I missed the mails. Yeah, definitely needs to be fixed. Thanks for the explanation. Daniel -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Tom. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Eduardo de Barros Lima ◤✠◢ ebl...@gmail.com -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Tom. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Rafael Antognolli http://antognolli.org/ -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] 14/15: ecore_evas/wayland_shm: Fixed window resize.
On Wed, Feb 20, 2013 at 1:15 PM, Tom Hacohen t...@stosb.com wrote: Is it from yesterday? If so, I think it's because I messed it up a bit (and later fixed it). Unless you think you know what's wrong. It should be fine now. Ah ok, I thought it was being done in purpose because there was a confusion some days ago with cedric pushing commits from someone else. Thanks, Etrunko On Wed, Feb 20, 2013 at 3:50 PM, Eduardo Lima (Etrunko) ebl...@gmail.comwrote: On Wed, Feb 20, 2013 at 12:41 PM, Tom Hacohen t...@stosb.com wrote: I don't understand the problem you are describing. Why would Antognolli pushing them cause any problems? I fixed some issues yesterday afternoon, so maybe the problem you are describing doesn't exist. Ok, so devilhorns started some work (13 patches) and shared with antognolli, who fixed some things on his original patches and also added other two new commits to the set and pushed them. The only commits we got on the ML were antognolli's, whle devilhorns' were missed. The range in the repository is 5526a29417d7fd57be69f079256e9511a5c41037..8be4940bb356838c28b72553c277762d581206c6. On Wed, Feb 20, 2013 at 3:37 PM, Daniel Willmann d.willm...@samsung.com wrote: On 20/02/13 15:20, Eduardo Lima (Etrunko) wrote: This case makes clear that we actually want to see the commits made from other person to appear on the mailing list. There were 13 from devilhorns that missed the ML because it was Antognolli who pushed them. Please fix the hook script. Ah, that was the problem. I was wondering if I missed the mails. Yeah, definitely needs to be fixed. Thanks for the explanation. Daniel -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Tom. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Eduardo de Barros Lima ◤✠◢ ebl...@gmail.com -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Tom. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Eduardo de Barros Lima ◤✠◢ ebl...@gmail.com -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] 14/15: ecore_evas/wayland_shm: Fixed window resize.
I hope it's OK. I don't really know if there are problems or not. Please keep a close eye to see if there's anything going wrong. On Wed, Feb 20, 2013 at 4:57 PM, Eduardo Lima (Etrunko) ebl...@gmail.comwrote: On Wed, Feb 20, 2013 at 1:15 PM, Tom Hacohen t...@stosb.com wrote: Is it from yesterday? If so, I think it's because I messed it up a bit (and later fixed it). Unless you think you know what's wrong. It should be fine now. Ah ok, I thought it was being done in purpose because there was a confusion some days ago with cedric pushing commits from someone else. Thanks, Etrunko On Wed, Feb 20, 2013 at 3:50 PM, Eduardo Lima (Etrunko) ebl...@gmail.comwrote: On Wed, Feb 20, 2013 at 12:41 PM, Tom Hacohen t...@stosb.com wrote: I don't understand the problem you are describing. Why would Antognolli pushing them cause any problems? I fixed some issues yesterday afternoon, so maybe the problem you are describing doesn't exist. Ok, so devilhorns started some work (13 patches) and shared with antognolli, who fixed some things on his original patches and also added other two new commits to the set and pushed them. The only commits we got on the ML were antognolli's, whle devilhorns' were missed. The range in the repository is 5526a29417d7fd57be69f079256e9511a5c41037..8be4940bb356838c28b72553c277762d581206c6. On Wed, Feb 20, 2013 at 3:37 PM, Daniel Willmann d.willm...@samsung.com wrote: On 20/02/13 15:20, Eduardo Lima (Etrunko) wrote: This case makes clear that we actually want to see the commits made from other person to appear on the mailing list. There were 13 from devilhorns that missed the ML because it was Antognolli who pushed them. Please fix the hook script. Ah, that was the problem. I was wondering if I missed the mails. Yeah, definitely needs to be fixed. Thanks for the explanation. Daniel -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Tom. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Eduardo de Barros Lima ◤✠◢ ebl...@gmail.com -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Tom. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Eduardo de Barros Lima ◤✠◢ ebl...@gmail.com -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Tom. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
