Re: [E-devel] [EGIT] [core/efl] master 06/06: evas: no loader should ever close an Eina_File anymore.
On Fri, 20 Dec 2013 08:55:34 +0100 Stefan Schmidt
said:
> Hello.
>
> On Fri, 2013-12-20 at 16:06, Cedric BAIL wrote:
> > On Fri, Dec 20, 2013 at 3:16 PM, Michael Blumenkrantz
> > wrote:
> > > On Thu, 19 Dec 2013 22:11:37 -0800
> > > Cedric BAIL wrote:
> > >> cedric pushed a commit to branch master.
> > >>
> > >> http://git.enlightenment.org/core/efl.git/commit/?id=1929637aa0c12f6d2bd2a09e218fba736965a238
> > >>
> > >> commit 1929637aa0c12f6d2bd2a09e218fba736965a238
> > >> Author: Cedric BAIL
> > >> Date: Fri Dec 20 14:39:57 2013 +0900
> > >>
> > >> evas: no loader should ever close an Eina_File anymore.
> > >>
> > >> This would lead to some crash in EFM if relying on Evas to find the
> > >> file format by trying all its loader.
> > >>
> > >> This should fix T674 and T668.
> > >
> > > it seems at this point that eina_file_close() is the gift that keeps on
> > > giving.
> > >
> > >> ---
> > >> src/modules/evas/loaders/pmaps/evas_image_load_pmaps.c | 4
> > >> 1 file changed, 4 deletions(-)
> > >>
> > >> diff --git a/src/modules/evas/loaders/pmaps/evas_image_load_pmaps.c
> > >> b/src/modules/evas/loaders/pmaps/evas_image_load_pmaps.c index
> > >> 50d1226..0a15181 100644
> > >> --- a/src/modules/evas/loaders/pmaps/evas_image_load_pmaps.c
> > >> +++ b/src/modules/evas/loaders/pmaps/evas_image_load_pmaps.c
> > >> @@ -170,8 +170,6 @@ pmaps_buffer_open(Pmaps_Buffer *b, Eina_File *f,
> > >> Eina_Bool header, int *error) if (!b->map)
> > >> {
> > >> *error = EVAS_LOAD_ERROR_DOES_NOT_EXIST;
> > >> -eina_file_close(b->file);
> > >> -b->file = NULL;
> > >> return EINA_FALSE;
> > >> }
> > >>
> > >> @@ -187,9 +185,7 @@ pmaps_buffer_open(Pmaps_Buffer *b, Eina_File *f,
> > >> Eina_Bool header, int *error) {
> > >> *error = EVAS_LOAD_ERROR_CORRUPT_FILE;
> > >> eina_file_map_free(b->file, b->map);
> > >> -eina_file_close(b->file);
> > >> b->map = NULL;
> > >> -b->file = NULL;
> > >> return EINA_FALSE;
> > >> }
> > >>
> > >>
> > >
> > > stefan's going to kill me for this but...it needs to get into the next
> > > minor release pretty urgently :/
> >
> > I fear to agree with you on that, I know he is a dangerous man. Still
> > that need to get in.
>
> /me puts away the machete he used to pick his teeth
>
> This makes me grumpy. It drages the release into the weekend which
> makes it harder for me. Sadly I can see that this is an important fix
> so I'm going to do it. Will put up new tarballs later today.
>
> What makes me even more grumpy though is that the fix is not in the
> efl-1.8 stabilization branch. Its plain and simple: If you have a fix
> from which you think it is important enough to go in the next stable
> release put it into the efl-1.8 branch.
>
> If you are not doing it I can only imagine the developer does not
> consider it stable release material and it will most likely never go
> into a stable release.
>
> I'm not here to judge every patch and decide if it should go into
> stable. The developer has a way better idea of the impact and risks of
> the patch. Its up to him to make sure it lands in stable. If you are
> not sure about the risks bring it up on the mailing list.
>
> I cherry-picked it now and if nothing shows up in testing will put out
> new tarballs later.
i think it'd be good for devs to log them as "cherry pick me" or something so
if they do get forgotten... someone can notice. :) one of these days i'll make
a script to cherry pick for me... but until then it's still a multi-step
process. :(
--
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com
--
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 06/06: evas: no loader should ever close an Eina_File anymore.
Hello.
On Fri, 2013-12-20 at 16:06, Cedric BAIL wrote:
> On Fri, Dec 20, 2013 at 3:16 PM, Michael Blumenkrantz
> wrote:
> > On Thu, 19 Dec 2013 22:11:37 -0800
> > Cedric BAIL wrote:
> >> cedric pushed a commit to branch master.
> >>
> >> http://git.enlightenment.org/core/efl.git/commit/?id=1929637aa0c12f6d2bd2a09e218fba736965a238
> >>
> >> commit 1929637aa0c12f6d2bd2a09e218fba736965a238
> >> Author: Cedric BAIL
> >> Date: Fri Dec 20 14:39:57 2013 +0900
> >>
> >> evas: no loader should ever close an Eina_File anymore.
> >>
> >> This would lead to some crash in EFM if relying on Evas to find the
> >> file format by
> >> trying all its loader.
> >>
> >> This should fix T674 and T668.
> >
> > it seems at this point that eina_file_close() is the gift that keeps on
> > giving.
> >
> >> ---
> >> src/modules/evas/loaders/pmaps/evas_image_load_pmaps.c | 4
> >> 1 file changed, 4 deletions(-)
> >>
> >> diff --git a/src/modules/evas/loaders/pmaps/evas_image_load_pmaps.c
> >> b/src/modules/evas/loaders/pmaps/evas_image_load_pmaps.c
> >> index 50d1226..0a15181 100644
> >> --- a/src/modules/evas/loaders/pmaps/evas_image_load_pmaps.c
> >> +++ b/src/modules/evas/loaders/pmaps/evas_image_load_pmaps.c
> >> @@ -170,8 +170,6 @@ pmaps_buffer_open(Pmaps_Buffer *b, Eina_File *f,
> >> Eina_Bool header, int *error)
> >> if (!b->map)
> >> {
> >> *error = EVAS_LOAD_ERROR_DOES_NOT_EXIST;
> >> -eina_file_close(b->file);
> >> -b->file = NULL;
> >> return EINA_FALSE;
> >> }
> >>
> >> @@ -187,9 +185,7 @@ pmaps_buffer_open(Pmaps_Buffer *b, Eina_File *f,
> >> Eina_Bool header, int *error)
> >> {
> >> *error = EVAS_LOAD_ERROR_CORRUPT_FILE;
> >> eina_file_map_free(b->file, b->map);
> >> -eina_file_close(b->file);
> >> b->map = NULL;
> >> -b->file = NULL;
> >> return EINA_FALSE;
> >> }
> >>
> >>
> >
> > stefan's going to kill me for this but...it needs to get into the next
> > minor release pretty urgently :/
>
> I fear to agree with you on that, I know he is a dangerous man. Still
> that need to get in.
/me puts away the machete he used to pick his teeth
This makes me grumpy. It drages the release into the weekend which
makes it harder for me. Sadly I can see that this is an important fix
so I'm going to do it. Will put up new tarballs later today.
What makes me even more grumpy though is that the fix is not in the
efl-1.8 stabilization branch. Its plain and simple: If you have a fix
from which you think it is important enough to go in the next stable
release put it into the efl-1.8 branch.
If you are not doing it I can only imagine the developer does not
consider it stable release material and it will most likely never go
into a stable release.
I'm not here to judge every patch and decide if it should go into
stable. The developer has a way better idea of the impact and risks of
the patch. Its up to him to make sure it lands in stable. If you are
not sure about the risks bring it up on the mailing list.
I cherry-picked it now and if nothing shows up in testing will put out
new tarballs later.
regards
Stefan Schmidt
--
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 06/06: evas: no loader should ever close an Eina_File anymore.
On Fri, Dec 20, 2013 at 3:16 PM, Michael Blumenkrantz
wrote:
> On Thu, 19 Dec 2013 22:11:37 -0800
> Cedric BAIL wrote:
>> cedric pushed a commit to branch master.
>>
>> http://git.enlightenment.org/core/efl.git/commit/?id=1929637aa0c12f6d2bd2a09e218fba736965a238
>>
>> commit 1929637aa0c12f6d2bd2a09e218fba736965a238
>> Author: Cedric BAIL
>> Date: Fri Dec 20 14:39:57 2013 +0900
>>
>> evas: no loader should ever close an Eina_File anymore.
>>
>> This would lead to some crash in EFM if relying on Evas to find the file
>> format by
>> trying all its loader.
>>
>> This should fix T674 and T668.
>
> it seems at this point that eina_file_close() is the gift that keeps on
> giving.
>
>> ---
>> src/modules/evas/loaders/pmaps/evas_image_load_pmaps.c | 4
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/src/modules/evas/loaders/pmaps/evas_image_load_pmaps.c
>> b/src/modules/evas/loaders/pmaps/evas_image_load_pmaps.c
>> index 50d1226..0a15181 100644
>> --- a/src/modules/evas/loaders/pmaps/evas_image_load_pmaps.c
>> +++ b/src/modules/evas/loaders/pmaps/evas_image_load_pmaps.c
>> @@ -170,8 +170,6 @@ pmaps_buffer_open(Pmaps_Buffer *b, Eina_File *f,
>> Eina_Bool header, int *error)
>> if (!b->map)
>> {
>> *error = EVAS_LOAD_ERROR_DOES_NOT_EXIST;
>> -eina_file_close(b->file);
>> -b->file = NULL;
>> return EINA_FALSE;
>> }
>>
>> @@ -187,9 +185,7 @@ pmaps_buffer_open(Pmaps_Buffer *b, Eina_File *f,
>> Eina_Bool header, int *error)
>> {
>> *error = EVAS_LOAD_ERROR_CORRUPT_FILE;
>> eina_file_map_free(b->file, b->map);
>> -eina_file_close(b->file);
>> b->map = NULL;
>> -b->file = NULL;
>> return EINA_FALSE;
>> }
>>
>>
>
> stefan's going to kill me for this but...it needs to get into the next minor
> release pretty urgently :/
I fear to agree with you on that, I know he is a dangerous man. Still
that need to get in.
--
Cedric BAIL
--
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 06/06: evas: no loader should ever close an Eina_File anymore.
On Thu, 19 Dec 2013 22:11:37 -0800
Cedric BAIL wrote:
> cedric pushed a commit to branch master.
>
> http://git.enlightenment.org/core/efl.git/commit/?id=1929637aa0c12f6d2bd2a09e218fba736965a238
>
> commit 1929637aa0c12f6d2bd2a09e218fba736965a238
> Author: Cedric BAIL
> Date: Fri Dec 20 14:39:57 2013 +0900
>
> evas: no loader should ever close an Eina_File anymore.
>
> This would lead to some crash in EFM if relying on Evas to find the file
> format by
> trying all its loader.
>
> This should fix T674 and T668.
it seems at this point that eina_file_close() is the gift that keeps on giving.
> ---
> src/modules/evas/loaders/pmaps/evas_image_load_pmaps.c | 4
> 1 file changed, 4 deletions(-)
>
> diff --git a/src/modules/evas/loaders/pmaps/evas_image_load_pmaps.c
> b/src/modules/evas/loaders/pmaps/evas_image_load_pmaps.c
> index 50d1226..0a15181 100644
> --- a/src/modules/evas/loaders/pmaps/evas_image_load_pmaps.c
> +++ b/src/modules/evas/loaders/pmaps/evas_image_load_pmaps.c
> @@ -170,8 +170,6 @@ pmaps_buffer_open(Pmaps_Buffer *b, Eina_File *f,
> Eina_Bool header, int *error)
> if (!b->map)
> {
> *error = EVAS_LOAD_ERROR_DOES_NOT_EXIST;
> -eina_file_close(b->file);
> -b->file = NULL;
> return EINA_FALSE;
> }
>
> @@ -187,9 +185,7 @@ pmaps_buffer_open(Pmaps_Buffer *b, Eina_File *f,
> Eina_Bool header, int *error)
> {
> *error = EVAS_LOAD_ERROR_CORRUPT_FILE;
> eina_file_map_free(b->file, b->map);
> -eina_file_close(b->file);
> b->map = NULL;
> -b->file = NULL;
> return EINA_FALSE;
> }
>
>
stefan's going to kill me for this but...it needs to get into the next minor
release pretty urgently :/
--
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
