Re: [E-devel] [patch]: minor e_winlist functional change
On 1/14/06, David Stevenson <[EMAIL PROTECTED]> wrote:
>
> Dude! You might want to compile and test it first as well :-)
i'm one of those {cr,l}azy gentoo people... i thought this was trivial
enough that i couldn't get it wrong.. i forgot the disclaimer this
time though, heh.
> + warp_to_y = ww->border->zone->y + ((ww->border->y +
> ww->border->h - ww->border->zone-y) / 2);
>
> Should be
>
> + warp_to_y = ww->border->zone->y + ((ww->border->y +
> ww->border->h - ww->border->zone->y) / 2);
yup, oops.
> I actually tried the patch the other day with the fake xinerama cmd option,
> and otherwise I couldn't see any problem with it :-)
>
> Regards!
> David
On 1/14/06, The Rasterman Carsten Haitzler <[EMAIL PROTECTED]> wrote:
> second time lucky - i actually lost my "mark" on this mail to know to look at
> the patch... so good u sent again! :)
That thought passed through my mind as well. :D Thanks!
/me runs and updates e again.
d#
---
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_idv37&alloc_id865&op=click
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [patch]: minor e_winlist functional change
On Sat, 14 Jan 2006 22:25:04 -0800 David Sharp <[EMAIL PROTECTED]> babbled: > On 1/9/06, David Sharp <[EMAIL PROTECTED]> wrote: > > On 1/9/06, David Stevenson <[EMAIL PROTECTED]> wrote: > > > On 1/10/06, David Sharp <[EMAIL PROTECTED]> wrote: > > > > On 1/6/06, The Rasterman Carsten Haitzler <[EMAIL PROTECTED]> wrote: > > > > > > > > > > good point! well spotted! fixed! :) > > > > > > > > the solution is incomplete, however. It is not mindfull of what 'zone' > > > > (xinerama) the window is in. Alt-Tab switching on the second screen > > > > warps the pointer half way between the left screen edge (or right edge > > > > of the first screen) and the left edge of the window. > > > > > > > > An attempt at a patch (a revision of Mr. Stevenson's) is attached, but > > > > i have not compiled, let alone tested, it. > > > > > > > > also, more minorly, it seems the previous patch assumed screen coords > > > > start at 1, which unless i don't know something about e, is incorrect, > > > > so my patch assumes they start at 0, or, really, at the zone's x and > > > > y. > > > > > > > > Thanks, d# > > > > > > With regards to the second part, I used screen coords of 1 because the > > > outer row of pixels on the zone has an input window which is what the edge > > > flipping uses, so don't want to consider warping to that space. > > > > Somehow, i knew there was probably a reason for it.. let's try again, then. > > > > Again, totally untested patch attached. > > > > > With regards to the first part, I don't have xinerama so couldn't test > > > that > > > - apologies for it seemingly not working. My understanding was that a zone > > > was like a desk, but it seems I got that bit wrong. > > > > Yes, i thought that too the first time, and got very confused clearing > > up what was what. > > > > d# > > > > > > > > Regards! > > > David > > well, it's been a few days, and i was hoping this would get in, but it > hasn't, and i figure it's probably because the patch isn't against > HEAD. > > so, i've doctored the patch up to be against HEAD. :D second time lucky - i actually lost my "mark" on this mail to know to look at the patch... so good u sent again! :) -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)[EMAIL PROTECTED] 裸好多 Tokyo, Japan (東京 日本) --- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [patch]: minor e_winlist functional change
On 1/15/06, David Sharp <[EMAIL PROTECTED]> wrote: On 1/9/06, David Sharp <[EMAIL PROTECTED]> wrote:> On 1/9/06, David Stevenson <[EMAIL PROTECTED]> wrote:> > On 1/10/06, David Sharp < [EMAIL PROTECTED]> wrote:> > > On 1/6/06, The Rasterman Carsten Haitzler <[EMAIL PROTECTED]> wrote:> > > > > > > > good point! well spotted! fixed! :)> > >> > > the solution is incomplete, however. It is not mindfull of what 'zone'> > > (xinerama) the window is in. Alt-Tab switching on the second screen > > > warps the pointer half way between the left screen edge (or right edge> > > of the first screen) and the left edge of the window.> > >> > > An attempt at a patch (a revision of Mr. Stevenson's) is attached, but > > > i have not compiled, let alone tested, it.> > >> > > also, more minorly, it seems the previous patch assumed screen coords> > > start at 1, which unless i don't know something about e, is incorrect, > > > so my patch assumes they start at 0, or, really, at the zone's x and> > > y.> > >> > > Thanks, d#> >> > With regards to the second part, I used screen coords of 1 because the > > outer row of pixels on the zone has an input window which is what the edge> > flipping uses, so don't want to consider warping to that space.>> Somehow, i knew there was probably a reason for it.. let's try again, then. >> Again, totally untested patch attached.>> > With regards to the first part, I don't have xinerama so couldn't test that> > - apologies for it seemingly not working. My understanding was that a zone > > was like a desk, but it seems I got that bit wrong.>> Yes, i thought that too the first time, and got very confused clearing> up what was what.>> d#>> > > > Regards!> > Davidwell, it's been a few days, and i was hoping this would get in, but ithasn't, and i figure it's probably because the patch isn't againstHEAD.so, i've doctored the patch up to be against HEAD. :D Thanks! d# Dude! You might want to compile and test it first as well :-) + warp_to_y = ww->border->zone->y + ((ww->border->y + ww->border->h - ww->border->zone-y) / 2); Should be + warp_to_y = ww->border->zone->y + ((ww->border->y + ww->border->h - ww->border->zone->y) / 2); I actually tried the patch the other day with the fake xinerama cmd option, and otherwise I couldn't see any problem with it :-) Regards! David
Re: [E-devel] [patch]: minor e_winlist functional change
On 1/9/06, David Sharp <[EMAIL PROTECTED]> wrote: > On 1/9/06, David Stevenson <[EMAIL PROTECTED]> wrote: > > On 1/10/06, David Sharp <[EMAIL PROTECTED]> wrote: > > > On 1/6/06, The Rasterman Carsten Haitzler <[EMAIL PROTECTED]> wrote: > > > > > > > > good point! well spotted! fixed! :) > > > > > > the solution is incomplete, however. It is not mindfull of what 'zone' > > > (xinerama) the window is in. Alt-Tab switching on the second screen > > > warps the pointer half way between the left screen edge (or right edge > > > of the first screen) and the left edge of the window. > > > > > > An attempt at a patch (a revision of Mr. Stevenson's) is attached, but > > > i have not compiled, let alone tested, it. > > > > > > also, more minorly, it seems the previous patch assumed screen coords > > > start at 1, which unless i don't know something about e, is incorrect, > > > so my patch assumes they start at 0, or, really, at the zone's x and > > > y. > > > > > > Thanks, d# > > > > With regards to the second part, I used screen coords of 1 because the > > outer row of pixels on the zone has an input window which is what the edge > > flipping uses, so don't want to consider warping to that space. > > Somehow, i knew there was probably a reason for it.. let's try again, then. > > Again, totally untested patch attached. > > > With regards to the first part, I don't have xinerama so couldn't test that > > - apologies for it seemingly not working. My understanding was that a zone > > was like a desk, but it seems I got that bit wrong. > > Yes, i thought that too the first time, and got very confused clearing > up what was what. > > d# > > > > > Regards! > > David well, it's been a few days, and i was hoping this would get in, but it hasn't, and i figure it's probably because the patch isn't against HEAD. so, i've doctored the patch up to be against HEAD. :D Thanks! d# winlistwarp-dsharp-r2.patch Description: Binary data
Re: [E-devel] [patch]: minor e_winlist functional change
On 1/9/06, David Stevenson <[EMAIL PROTECTED]> wrote: > > > On 1/10/06, David Sharp <[EMAIL PROTECTED]> wrote: > > On 1/6/06, The Rasterman Carsten Haitzler <[EMAIL PROTECTED]> wrote: > > > > > > good point! well spotted! fixed! :) > > > > the solution is incomplete, however. It is not mindfull of what 'zone' > > (xinerama) the window is in. Alt-Tab switching on the second screen > > warps the pointer half way between the left screen edge (or right edge > > of the first screen) and the left edge of the window. > > > > An attempt at a patch (a revision of Mr. Stevenson's) is attached, but > > i have not compiled, let alone tested, it. > > > > also, more minorly, it seems the previous patch assumed screen coords > > start at 1, which unless i don't know something about e, is incorrect, > > so my patch assumes they start at 0, or, really, at the zone's x and > > y. > > > > Thanks, d# > > With regards to the second part, I used screen coords of 1 because the > outer row of pixels on the zone has an input window which is what the edge > flipping uses, so don't want to consider warping to that space. Somehow, i knew there was probably a reason for it.. let's try again, then. Again, totally untested patch attached. > With regards to the first part, I don't have xinerama so couldn't test that > - apologies for it seemingly not working. My understanding was that a zone > was like a desk, but it seems I got that bit wrong. Yes, i thought that too the first time, and got very confused clearing up what was what. d# > > Regards! > David > winlistwarp-dsharp.patch Description: Binary data
Re: [E-devel] [patch]: minor e_winlist functional change
On 1/10/06, David Sharp <[EMAIL PROTECTED]> wrote: On 1/6/06, The Rasterman Carsten Haitzler <[EMAIL PROTECTED]> wrote:> On Wed, 4 Jan 2006 00:41:56 +0900 David Stevenson < [EMAIL PROTECTED]>> babbled:>> > Hi,> >> > When using the winlist functionality, if your windows are more> > than half-way off a given edge of the screen (i know i know! but I only have > > a 15-inch display :-) it happens) when the mouse pointer warps, it warps so> > far as to cause an edge-flip to occur after the window is selected.> >> > The attached patch ensures the pointer is warped to the center of the part > > of the window that remains visible on the desk, preventing the> > edge-flipping.>> good point! well spotted! fixed! :)the solution is incomplete, however. It is not mindfull of what 'zone' (xinerama) the window is in. Alt-Tab switching on the second screenwarps the pointer half way between the left screen edge (or right edgeof the first screen) and the left edge of the window.An attempt at a patch (a revision of Mr. Stevenson's) is attached, but i have not compiled, let alone tested, it.also, more minorly, it seems the previous patch assumed screen coordsstart at 1, which unless i don't know something about e, is incorrect,so my patch assumes they start at 0, or, really, at the zone's x and y.Thanks, d# With regards to the second part, I used screen coords of 1 because the outer row of pixels on the zone has an input window which is what the edge flipping uses, so don't want to consider warping to that space. With regards to the first part, I don't have xinerama so couldn't test that - apologies for it seemingly not working. My understanding was that a zone was like a desk, but it seems I got that bit wrong. Regards! David
Re: [E-devel] [patch]: minor e_winlist functional change
On 1/6/06, The Rasterman Carsten Haitzler <[EMAIL PROTECTED]> wrote: > On Wed, 4 Jan 2006 00:41:56 +0900 David Stevenson <[EMAIL PROTECTED]> > babbled: > > > Hi, > > > > When using the winlist functionality, if your windows are more > > than half-way off a given edge of the screen (i know i know! but I only have > > a 15-inch display :-) it happens) when the mouse pointer warps, it warps so > > far as to cause an edge-flip to occur after the window is selected. > > > > The attached patch ensures the pointer is warped to the center of the part > > of the window that remains visible on the desk, preventing the > > edge-flipping. > > good point! well spotted! fixed! :) the solution is incomplete, however. It is not mindfull of what 'zone' (xinerama) the window is in. Alt-Tab switching on the second screen warps the pointer half way between the left screen edge (or right edge of the first screen) and the left edge of the window. An attempt at a patch (a revision of Mr. Stevenson's) is attached, but i have not compiled, let alone tested, it. also, more minorly, it seems the previous patch assumed screen coords start at 1, which unless i don't know something about e, is incorrect, so my patch assumes they start at 0, or, really, at the zone's x and y. Thanks, d# > > -- > - Codito, ergo sum - "I code, therefore I am" -- > The Rasterman (Carsten Haitzler)[EMAIL PROTECTED] > 裸好多 > Tokyo, Japan (東京 日本) > > > --- > This SF.net email is sponsored by: Splunk Inc. Do you grep through log files > for problems? Stop! Download the new AJAX search engine that makes > searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! > http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > winlistwarp-dsharp.patch Description: Binary data
Re: [E-devel] [patch]: minor e_winlist functional change
On Wed, 4 Jan 2006 00:41:56 +0900 David Stevenson <[EMAIL PROTECTED]> babbled: > Hi, > > When using the winlist functionality, if your windows are more > than half-way off a given edge of the screen (i know i know! but I only have > a 15-inch display :-) it happens) when the mouse pointer warps, it warps so > far as to cause an edge-flip to occur after the window is selected. > > The attached patch ensures the pointer is warped to the center of the part > of the window that remains visible on the desk, preventing the > edge-flipping. good point! well spotted! fixed! :) -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)[EMAIL PROTECTED] 裸好多 Tokyo, Japan (東京 日本) --- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [patch]: minor e_winlist functional change
Hi, When using the winlist functionality, if your windows are more than half-way off a given edge of the screen (i know i know! but I only have a 15-inch display :-) it happens) when the mouse pointer warps, it warps so far as to cause an edge-flip to occur after the window is selected. The attached patch ensures the pointer is warped to the center of the part of the window that remains visible on the desk, preventing the edge-flipping. Regards! David winlistwarp.patch Description: Binary data
