Re: [E-devel] E CVS: libs/efreet cedric

2008-05-18 Thread The Rasterman
On Tue, 6 May 2008 14:03:03 -0500 Nathan Ingersoll [EMAIL PROTECTED]
babbled:

we still use fwrite for writing to the eet file - buffering is good in f* funcs
- but yes, in theory read() for that example would work.

 In case you missed my question on IRC...
 
 On Tue, May 6, 2008 at 10:56 AM, Enlightenment CVS
 [EMAIL PROTECTED] wrote:
 
   f = fopen(file, rb);
   if (!f) return NULL;
 
   +if (fstat(fileno(f), file_stat)
   +|| file_stat.st_size  1)
   +{
   +fclose(f);
   +return NULL;
   +}
 
 Is there any reason to not convert this to open/close instead of
 fopen/fclose? It would simplify the code as you would no longer need
 to use fileno at every point you access the associated fd.
 
 -
 This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
 Don't miss this year's exciting event. There's still time to save $100. 
 Use priority code J8TL2D2. 
 http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
 ___
 enlightenment-devel mailing list
 enlightenment-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
 


-- 
- Codito, ergo sum - I code, therefore I am --
The Rasterman (Carsten Haitzler)[EMAIL PROTECTED]


-
This SF.net email is sponsored by: Microsoft 
Defy all challenges. Microsoft(R) Visual Studio 2008. 
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E CVS: libs/efreet cedric

2008-05-06 Thread Nathan Ingersoll
In case you missed my question on IRC...

On Tue, May 6, 2008 at 10:56 AM, Enlightenment CVS
[EMAIL PROTECTED] wrote:

  f = fopen(file, rb);
  if (!f) return NULL;

  +if (fstat(fileno(f), file_stat)
  +|| file_stat.st_size  1)
  +{
  +fclose(f);
  +return NULL;
  +}

Is there any reason to not convert this to open/close instead of
fopen/fclose? It would simplify the code as you would no longer need
to use fileno at every point you access the associated fd.

-
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel