Re: [E-devel] E SVN: cedric trunk/edje/src/bin
daniel++
On Wed, Sep 12, 2012 at 9:36 AM, Daniel Willmann wrote:
> Hi,
>
> from the looks of this patch you can probably save yourself some time
> and compares by checking for pl->u.ep->name at the beginning of this
> hunk and skipping it entirely if it's NULL.
>
> Regards,
> Daniel Willmann
>
> On 09/11/2012 09:15 AM, Enlightenment SVN wrote:
> > Log:
> > edje: don't strcmp ith NULL.
> >
> >
> > Author: cedric
> > Date: 2012-09-11 01:15:33 -0700 (Tue, 11 Sep 2012)
> > New Revision: 76449
>
> > Modified: trunk/edje/src/bin/edje_cc_out.c
> > ===
> > --- trunk/edje/src/bin/edje_cc_out.c 2012-09-11 07:59:19 UTC (rev 76448)
> > +++ trunk/edje/src/bin/edje_cc_out.c 2012-09-11 08:15:33 UTC (rev 76449)
> > @@ -1881,27 +1881,32 @@
> >{
>
> if (pl->u.ep->name) {
>
> > for (i = 0 ; i < pc->programs.fnmatch_count ; i++)
> > {
> > - if (!strcmp(pl->u.ep->name,
> pc->programs.fnmatch[i]->name))
> > + if (pl->u.ep->name && pc->programs.fnmatch[i]->name &&
> > + !strcmp(pl->u.ep->name,
> pc->programs.fnmatch[i]->name))
> > data_queue_anonymous_lookup(pc,
> pc->programs.fnmatch[i], dest);
> > }
> > for (i = 0 ; i < pc->programs.strcmp_count ; i++)
> > {
> > - if (!strcmp(pl->u.ep->name,
> pc->programs.strcmp[i]->name))
> > + if (pl->u.ep->name && pc->programs.strcmp[i]->name &&
> > + !strcmp(pl->u.ep->name,
> pc->programs.strcmp[i]->name))
> > data_queue_anonymous_lookup(pc,
> pc->programs.strcmp[i], dest);
> > }
> > for (i = 0 ; i < pc->programs.strncmp_count ; i++)
> > {
> > - if (!strcmp(pl->u.ep->name,
> pc->programs.strncmp[i]->name))
> > + if (pl->u.ep->name && pc->programs.strncmp[i]->name &&
> > + !strcmp(pl->u.ep->name,
> pc->programs.strncmp[i]->name))
> > data_queue_anonymous_lookup(pc,
> pc->programs.strncmp[i], dest);
> > }
> > for (i = 0 ; i < pc->programs.strrncmp_count ; i++)
> > {
> > - if (!strcmp(pl->u.ep->name,
> pc->programs.strrncmp[i]->name))
> > + if (pl->u.ep->name && pc->programs.strrncmp[i]->name
> &&
> > + !strcmp(pl->u.ep->name,
> pc->programs.strrncmp[i]->name))
> > data_queue_anonymous_lookup(pc,
> pc->programs.strrncmp[i], dest);
> > }
> > for (i = 0 ; i < pc->programs.nocmp_count ; i++)
> > {
> > - if (!strcmp(pl->u.ep->name,
> pc->programs.nocmp[i]->name))
> > + if (pl->u.ep->name && pc->programs.nocmp[i]->name &&
> > + !strcmp(pl->u.ep->name,
> pc->programs.nocmp[i]->name))
> > data_queue_anonymous_lookup(pc,
> pc->programs.nocmp[i], dest);
> > }
>
> }
>
> >}
>
>
>
> --
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/bin
Hi,
from the looks of this patch you can probably save yourself some time
and compares by checking for pl->u.ep->name at the beginning of this
hunk and skipping it entirely if it's NULL.
Regards,
Daniel Willmann
On 09/11/2012 09:15 AM, Enlightenment SVN wrote:
> Log:
> edje: don't strcmp ith NULL.
>
>
> Author: cedric
> Date: 2012-09-11 01:15:33 -0700 (Tue, 11 Sep 2012)
> New Revision: 76449
> Modified: trunk/edje/src/bin/edje_cc_out.c
> ===
> --- trunk/edje/src/bin/edje_cc_out.c 2012-09-11 07:59:19 UTC (rev 76448)
> +++ trunk/edje/src/bin/edje_cc_out.c 2012-09-11 08:15:33 UTC (rev 76449)
> @@ -1881,27 +1881,32 @@
>{
if (pl->u.ep->name) {
> for (i = 0 ; i < pc->programs.fnmatch_count ; i++)
> {
> - if (!strcmp(pl->u.ep->name, pc->programs.fnmatch[i]->name))
> + if (pl->u.ep->name && pc->programs.fnmatch[i]->name &&
> + !strcmp(pl->u.ep->name, pc->programs.fnmatch[i]->name))
> data_queue_anonymous_lookup(pc, pc->programs.fnmatch[i],
> dest);
> }
> for (i = 0 ; i < pc->programs.strcmp_count ; i++)
> {
> - if (!strcmp(pl->u.ep->name, pc->programs.strcmp[i]->name))
> + if (pl->u.ep->name && pc->programs.strcmp[i]->name &&
> + !strcmp(pl->u.ep->name, pc->programs.strcmp[i]->name))
> data_queue_anonymous_lookup(pc, pc->programs.strcmp[i],
> dest);
> }
> for (i = 0 ; i < pc->programs.strncmp_count ; i++)
> {
> - if (!strcmp(pl->u.ep->name, pc->programs.strncmp[i]->name))
> + if (pl->u.ep->name && pc->programs.strncmp[i]->name &&
> + !strcmp(pl->u.ep->name, pc->programs.strncmp[i]->name))
> data_queue_anonymous_lookup(pc, pc->programs.strncmp[i],
> dest);
> }
> for (i = 0 ; i < pc->programs.strrncmp_count ; i++)
> {
> - if (!strcmp(pl->u.ep->name,
> pc->programs.strrncmp[i]->name))
> + if (pl->u.ep->name && pc->programs.strrncmp[i]->name &&
> + !strcmp(pl->u.ep->name,
> pc->programs.strrncmp[i]->name))
> data_queue_anonymous_lookup(pc,
> pc->programs.strrncmp[i], dest);
> }
> for (i = 0 ; i < pc->programs.nocmp_count ; i++)
> {
> - if (!strcmp(pl->u.ep->name, pc->programs.nocmp[i]->name))
> + if (pl->u.ep->name && pc->programs.nocmp[i]->name &&
> + !strcmp(pl->u.ep->name, pc->programs.nocmp[i]->name))
> data_queue_anonymous_lookup(pc, pc->programs.nocmp[i],
> dest);
> }
}
>}
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/bin
oops, sorry :)
2012/6/24 Enlightenment SVN
> Log:
> edje: Resistance is futile. The B0rk.
>
>
> Author: cedric
> Date: 2012-06-23 23:01:12 -0700 (Sat, 23 Jun 2012)
> New Revision: 72754
> Trac: http://trac.enlightenment.org/e/changeset/72754
>
> Modified:
> trunk/edje/src/bin/edje_cc_out.c
>
> Modified: trunk/edje/src/bin/edje_cc_out.c
> ===
> --- trunk/edje/src/bin/edje_cc_out.c2012-06-24 05:35:49 UTC (rev 72753)
> +++ trunk/edje/src/bin/edje_cc_out.c2012-06-24 06:01:12 UTC (rev 72754)
> @@ -2144,15 +2144,15 @@
> }
> else
> {
> - char *aliased;
> - aliased = eina_hash_find(part->pc->aliased, part->name);
> - if (!aliased)
> - aliased = part->name;
> + char *alias;
> + alias = eina_hash_find(part->pc->alias, part->name);
> + if (!alias)
> + alias = part->name;
> for (i = 0; i < part->pc->parts_count; ++i)
>{
> ep = part->pc->parts[i];
>
> - if ((ep->name) && (!strcmp(ep->name, aliased)))
> + if ((ep->name) && (!strcmp(ep->name, alias)))
> {
>handle_slave_lookup(part_slave_lookups, part->dest,
> ep->id);
>*(part->dest) = ep->id;
> @@ -2162,8 +2162,8 @@
>
> if (i == part->pc->parts_count)
>{
> - ERR("%s: Error. Unable to find part name \"%s\".",
> - progname, part->name);
> + ERR("%s: Error. Unable to find part name \"%s\" needed
> in group '%s'.",
> + progname, alias, part->pc->part);
> exit(-1);
>}
> }
>
>
>
> --
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
--
Michaël Bouchaud (yoz)
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/bin
2012/1/23 Cedric BAIL : > Because we are crazy french ! More seriously, by doing this you can > just #include the original elementary theme and change some part in a > group without copying code. So a very small and easy to read new theme > that will be kept in sync with original one. As for my phone number, I > have not setup yet an over priced phone line, but as soon as I have, I > will happily give it :) Valid use case but it still sounds like a hacky solution. Maybe once group inheritance is solid enough we can think of a less awful way to do this. > -- > Cedric BAIL > > -- > Try before you buy = See our experts in action! > The most comprehensive online learning library for Microsoft developers > is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, > Metro Style Apps, more. Free future releases when you subscribe now! > http://p.sf.net/sfu/learndevnow-dev2 > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Try before you buy = See our experts in action! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-dev2 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/bin
On Mon, Jan 23, 2012 at 4:48 PM, Iván Briano (Sachiel)
wrote:
> 2012/1/23 Enlightenment SVN :
>> Log:
>> edje: detect when we try to inherit from ourself.
>>
>>
>> Author: cedric
>> Date: 2012-01-23 07:45:12 -0800 (Mon, 23 Jan 2012)
>> New Revision: 67472
>> Trac: http://trac.enlightenment.org/e/changeset/67472
>>
>> Modified:
>> trunk/edje/src/bin/edje_cc_handlers.c
>>
>> Modified: trunk/edje/src/bin/edje_cc_handlers.c
>> ===
>> --- trunk/edje/src/bin/edje_cc_handlers.c 2012-01-23 15:17:16 UTC (rev
>> 67471)
>> +++ trunk/edje/src/bin/edje_cc_handlers.c 2012-01-23 15:45:12 UTC (rev
>> 67472)
>> @@ -2242,6 +2242,14 @@
>> progname, file_in, line - 1, parent_name);
>> exit(-1);
>> }
>> + if (pc2 == pc)
>> + {
>> + ERR("%s: Error. parse error %s:%i. You are trying to inherit '%s'
>> from itself. That's not possible."
>> + "If there is another group of the same name, you want to
>> inherit from that group and have the"
>> + "same name as that group, there is a trick ! Just put the
>> inherit before the directive that set"
>> + "the name !", progname, file_in, line - 1, parent_name);
>
> WHAT? Why would you do that? People goes all around fixing
> shadowing of variables in the C code and now we are telling people
> how to shadow Edje groups? Give me your phone number so I can
> direct people asking how to fix the problems cause by this to talk
> directly to you.
Because we are crazy french ! More seriously, by doing this you can
just #include the original elementary theme and change some part in a
group without copying code. So a very small and easy to read new theme
that will be kept in sync with original one. As for my phone number, I
have not setup yet an over priced phone line, but as soon as I have, I
will happily give it :)
--
Cedric BAIL
--
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/bin
2012/1/23 Enlightenment SVN :
> Log:
> edje: detect when we try to inherit from ourself.
>
>
> Author: cedric
> Date: 2012-01-23 07:45:12 -0800 (Mon, 23 Jan 2012)
> New Revision: 67472
> Trac: http://trac.enlightenment.org/e/changeset/67472
>
> Modified:
> trunk/edje/src/bin/edje_cc_handlers.c
>
> Modified: trunk/edje/src/bin/edje_cc_handlers.c
> ===
> --- trunk/edje/src/bin/edje_cc_handlers.c 2012-01-23 15:17:16 UTC (rev
> 67471)
> +++ trunk/edje/src/bin/edje_cc_handlers.c 2012-01-23 15:45:12 UTC (rev
> 67472)
> @@ -2242,6 +2242,14 @@
> progname, file_in, line - 1, parent_name);
> exit(-1);
> }
> + if (pc2 == pc)
> + {
> + ERR("%s: Error. parse error %s:%i. You are trying to inherit '%s'
> from itself. That's not possible."
> + "If there is another group of the same name, you want to inherit
> from that group and have the"
> + "same name as that group, there is a trick ! Just put the
> inherit before the directive that set"
> + "the name !", progname, file_in, line - 1, parent_name);
WHAT? Why would you do that? People goes all around fixing
shadowing of variables in the C code and now we are telling people
how to shadow Edje groups? Give me your phone number so I can
direct people asking how to fix the problems cause by this to talk
directly to you.
> + exit(-1);
> + }
>
> if (pc2->data)
> {
>
>
> --
> Try before you buy = See our experts in action!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-dev2
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/bin
On Sat, Dec 4, 2010 at 2:13 AM, Carsten Haitzler wrote:
> On Fri, 3 Dec 2010 18:47:38 +0100 (CET) Vincent Torri
> said:
>> On Fri, 3 Dec 2010, Cedric BAIL wrote:
>> > On Fri, Dec 3, 2010 at 5:57 PM, Vincent Torri wrote:
>> >> On Fri, 3 Dec 2010, Enlightenment SVN wrote:
>> >>> Log:
>> >>> * edje: improve portability and simplify code.
>> >>>
>> >>> + snprintf(buf, sizeof(buf), "%s -I%s %s -E -o %s - < %s",
>> >>> + getenv("CC") ? getenv("CC") : "cc",
>> >>> inc, def, tmpn, file_in);
>> >>> ret = system(buf);
>> >>
>> >> shouldn't you also pass
>> >>
>> >> -x c
>> >>
>> >> to force the language (gcc can rely on the file extension to select the
>> >
>> > No need as I pass it using redirection instead of directly the
>> > filename. That was to avoid complexifying the command line.
>> >
>> >> language) and
>> >
>> >> -std=c99
>> >>
>> >> to be sure to remove the c++ comments ?
>> >
>> > Good question, don't know if it will be supported by other compiler
>> > than gcc. What's your opinion ?
>>
>> sun (oracle) compiler: -xc99 (no -std option)
>> icc: -std=c99
>> x86 open64 (amd) : -std=c99
>> vc++ (cl.exe): i don't know
>>
>> so maybe try first with -std=c99 ; if the command fails, try with -xc99
>>
>> I don't know other interesting compiler
>
> actually... this brings up a bit of an issue. using cpp/cc/gcc to handle
> #includes and macros and #ifdefs and so on was a handy idea... but it creates
> a
> LOT of problems in the maintainability and portability of edje_cc due to
> relying on a nebulous cpp that may or may not behave as we expect.
>
> i'm thinking post 1.0 a lot of these features should go into edje_cc itself.
> being able to do includes and macros - maybe we can do much more intelligent
> macros that are able to understand the rest of the edc syntax and model.
As Vincent said I would like in the futur to remove that dependency
with cpp as it is a hell to make it portable. And by the mean time we
could also add loop support and other usefull stuff that cpp is
lacking for our use.
But as always, it will require some time to be able to do it :-)
--
Cedric BAIL
--
What happens now with your Lotus Notes apps - do you make another costly
upgrade, or settle for being marooned without product support? Time to move
off Lotus Notes and onto the cloud with Force.com, apps are easier to build,
use, and manage than apps on traditional platforms. Sign up for the Lotus
Notes Migration Kit to learn more. http://p.sf.net/sfu/salesforce-d2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/bin
On Sat, 4 Dec 2010 07:39:42 +0100 (CET) Vincent Torri said: > > actually... this brings up a bit of an issue. using cpp/cc/gcc to handle > > #includes and macros and #ifdefs and so on was a handy idea... but it > > #creates a > > LOT of problems in the maintainability and portability of edje_cc due to > > relying on a nebulous cpp that may or may not behave as we expect. > > > > i'm thinking post 1.0 a lot of these features should go into edje_cc itself. > > being able to do includes and macros - maybe we can do much more intelligent > > macros that are able to understand the rest of the edc syntax and model. > > cedric had the same kind of idea, actually (writing a specific > preprocessor for edc syntax). great minds think :) -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- What happens now with your Lotus Notes apps - do you make another costly upgrade, or settle for being marooned without product support? Time to move off Lotus Notes and onto the cloud with Force.com, apps are easier to build, use, and manage than apps on traditional platforms. Sign up for the Lotus Notes Migration Kit to learn more. http://p.sf.net/sfu/salesforce-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/bin
On Sat, 4 Dec 2010, Carsten Haitzler (The Rasterman) wrote:
On Fri, 3 Dec 2010 18:47:38 +0100 (CET) Vincent Torri
said:
On Fri, 3 Dec 2010, Cedric BAIL wrote:
On Fri, Dec 3, 2010 at 5:57 PM, Vincent Torri wrote:
On Fri, 3 Dec 2010, Enlightenment SVN wrote:
Log:
* edje: improve portability and simplify code.
+ snprintf(buf, sizeof(buf), "%s -I%s %s -E -o %s - < %s",
+ getenv("CC") ? getenv("CC") : "cc",
inc, def, tmpn, file_in);
ret = system(buf);
shouldn't you also pass
-x c
to force the language (gcc can rely on the file extension to select the
No need as I pass it using redirection instead of directly the
filename. That was to avoid complexifying the command line.
language) and
-std=c99
to be sure to remove the c++ comments ?
Good question, don't know if it will be supported by other compiler
than gcc. What's your opinion ?
sun (oracle) compiler: -xc99 (no -std option)
icc: -std=c99
x86 open64 (amd) : -std=c99
vc++ (cl.exe): i don't know
so maybe try first with -std=c99 ; if the command fails, try with -xc99
I don't know other interesting compiler
actually... this brings up a bit of an issue. using cpp/cc/gcc to handle
#includes and macros and #ifdefs and so on was a handy idea... but it creates a
LOT of problems in the maintainability and portability of edje_cc due to
relying on a nebulous cpp that may or may not behave as we expect.
i'm thinking post 1.0 a lot of these features should go into edje_cc itself.
being able to do includes and macros - maybe we can do much more intelligent
macros that are able to understand the rest of the edc syntax and model.
cedric had the same kind of idea, actually (writing a specific
preprocessor for edc syntax).
Vincent--
What happens now with your Lotus Notes apps - do you make another costly
upgrade, or settle for being marooned without product support? Time to move
off Lotus Notes and onto the cloud with Force.com, apps are easier to build,
use, and manage than apps on traditional platforms. Sign up for the Lotus
Notes Migration Kit to learn more. http://p.sf.net/sfu/salesforce-d2d___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/bin
On Fri, 3 Dec 2010 18:47:38 +0100 (CET) Vincent Torri
said:
>
>
> On Fri, 3 Dec 2010, Cedric BAIL wrote:
>
> > On Fri, Dec 3, 2010 at 5:57 PM, Vincent Torri wrote:
> >> On Fri, 3 Dec 2010, Enlightenment SVN wrote:
> >>> Log:
> >>> * edje: improve portability and simplify code.
> >>>
> >>> + snprintf(buf, sizeof(buf), "%s -I%s %s -E -o %s - < %s",
> >>> + getenv("CC") ? getenv("CC") : "cc",
> >>> inc, def, tmpn, file_in);
> >>> ret = system(buf);
> >>
> >> shouldn't you also pass
> >>
> >> -x c
> >>
> >> to force the language (gcc can rely on the file extension to select the
> >
> > No need as I pass it using redirection instead of directly the
> > filename. That was to avoid complexifying the command line.
> >
> >> language) and
> >
> >> -std=c99
> >>
> >> to be sure to remove the c++ comments ?
> >
> > Good question, don't know if it will be supported by other compiler
> > than gcc. What's your opinion ?
>
> sun (oracle) compiler: -xc99 (no -std option)
> icc: -std=c99
> x86 open64 (amd) : -std=c99
> vc++ (cl.exe): i don't know
>
> so maybe try first with -std=c99 ; if the command fails, try with -xc99
>
> I don't know other interesting compiler
actually... this brings up a bit of an issue. using cpp/cc/gcc to handle
#includes and macros and #ifdefs and so on was a handy idea... but it creates a
LOT of problems in the maintainability and portability of edje_cc due to
relying on a nebulous cpp that may or may not behave as we expect.
i'm thinking post 1.0 a lot of these features should go into edje_cc itself.
being able to do includes and macros - maybe we can do much more intelligent
macros that are able to understand the rest of the edc syntax and model.
--
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com
--
What happens now with your Lotus Notes apps - do you make another costly
upgrade, or settle for being marooned without product support? Time to move
off Lotus Notes and onto the cloud with Force.com, apps are easier to build,
use, and manage than apps on traditional platforms. Sign up for the Lotus
Notes Migration Kit to learn more. http://p.sf.net/sfu/salesforce-d2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/bin
On Fri, 3 Dec 2010, Cedric BAIL wrote:
On Fri, Dec 3, 2010 at 5:57 PM, Vincent Torri wrote:
On Fri, 3 Dec 2010, Enlightenment SVN wrote:
Log:
* edje: improve portability and simplify code.
+ snprintf(buf, sizeof(buf), "%s -I%s %s -E -o %s - < %s",
+ getenv("CC") ? getenv("CC") : "cc",
inc, def, tmpn, file_in);
ret = system(buf);
shouldn't you also pass
-x c
to force the language (gcc can rely on the file extension to select the
No need as I pass it using redirection instead of directly the
filename. That was to avoid complexifying the command line.
language) and
-std=c99
to be sure to remove the c++ comments ?
Good question, don't know if it will be supported by other compiler
than gcc. What's your opinion ?
sun (oracle) compiler: -xc99 (no -std option)
icc: -std=c99
x86 open64 (amd) : -std=c99
vc++ (cl.exe): i don't know
so maybe try first with -std=c99 ; if the command fails, try with -xc99
I don't know other interesting compiler
Vincent--
Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
Tap into the largest installed PC base & get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/bin
On Fri, Dec 3, 2010 at 5:57 PM, Vincent Torri wrote:
> On Fri, 3 Dec 2010, Enlightenment SVN wrote:
>> Log:
>> * edje: improve portability and simplify code.
>>
>> + snprintf(buf, sizeof(buf), "%s -I%s %s -E -o %s - < %s",
>> + getenv("CC") ? getenv("CC") : "cc",
>> inc, def, tmpn, file_in);
>> ret = system(buf);
>
> shouldn't you also pass
>
> -x c
>
> to force the language (gcc can rely on the file extension to select the
No need as I pass it using redirection instead of directly the
filename. That was to avoid complexifying the command line.
> language) and
> -std=c99
>
> to be sure to remove the c++ comments ?
Good question, don't know if it will be supported by other compiler
than gcc. What's your opinion ?
--
Cedric BAIL
--
Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
Tap into the largest installed PC base & get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/bin
On Fri, 3 Dec 2010, Enlightenment SVN wrote:
> Log:
> * edje: improve portability and simplify code.
>
> + snprintf(buf, sizeof(buf), "%s -I%s %s -E -o %s - < %s",
> + getenv("CC") ? getenv("CC") : "cc",
> inc, def, tmpn, file_in);
>ret = system(buf);
shouldn't you also pass
-x c
to force the language (gcc can rely on the file extension to select the
language) and
-std=c99
to be sure to remove the c++ comments
?
Vincent
--
Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
Tap into the largest installed PC base & get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/bin
On Mon, Oct 4, 2010 at 6:35 AM, Daniel Juyung Seo wrote: > Hello, this is Daniel Juyung Seo. > > I have a question about below commit. > > It looks like the statement is trying to avoid argc == 2. > Why 'argc > 2 || argc < 2' was used instead of 'argc != 2' ? > Any reasons? Maybe it was too early in the morning. Duno why I wrote this that way. -- Cedric BAIL -- Virtualization is moving to the mainstream and overtaking non-virtualized environment for deploying applications. Does it make network security easier or more difficult to achieve? Read this whitepaper to separate the two and get a better understanding. http://p.sf.net/sfu/hp-phase2-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric trunk/edje/src/bin
Hello, this is Daniel Juyung Seo.
I have a question about below commit.
It looks like the statement is trying to avoid argc == 2.
Why 'argc > 2 || argc < 2' was used instead of 'argc != 2' ?
Any reasons?
Thank you.
Best Regards,
Daniel Juyung Seo.
On Mon, Aug 23, 2010 at 11:44 PM, Enlightenment SVN
wrote:
> Log:
> * edje: prevent segv when no param is given to edje_convert.
>
> Author: cedric
> Date: 2010-08-23 07:44:04 -0700 (Mon, 23 Aug 2010)
> New Revision: 51575
>
> Modified:
> trunk/edje/src/bin/edje_convert_main.c
>
> Modified: trunk/edje/src/bin/edje_convert_main.c
> ===
> --- trunk/edje/src/bin/edje_convert_main.c 2010-08-23 14:27:50 UTC (rev
> 51574)
> +++ trunk/edje/src/bin/edje_convert_main.c 2010-08-23 14:44:04 UTC (rev
> 51575)
> @@ -128,7 +128,7 @@
> eet_init();
>
> progname = argv[0];
> - if (argc > 2 || !strcmp(argv[1], "-h"))
> + if (argc > 2 || argc < 2 || !strcmp(argv[1], "-h"))
> {
> main_help();
> return 0;
>
>
> --
> This SF.net email is sponsored by
>
> Make an app they can't live without
> Enter the BlackBerry Developer Challenge
> http://p.sf.net/sfu/RIM-dev2dev
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
--
Virtualization is moving to the mainstream and overtaking non-virtualized
environment for deploying applications. Does it make network security
easier or more difficult to achieve? Read this whitepaper to separate the
two and get a better understanding.
http://p.sf.net/sfu/hp-phase2-d2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
