Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
Awesome information. On Sun, Aug 12, 2012 at 2:13 PM, Carsten Haitzler wrote: > On Sun, 12 Aug 2012 01:27:21 -0300 Gustavo Sverzut Barbieri > said: > > > On Sun, Aug 12, 2012 at 1:17 AM, Enlightenment SVN > > wrote: > > > so memcpy changed behavior, though within specs of the manual page > > > anyway, but now the values can be ones that break the simple > assignment. > > > > there was a long discussion about this and MySQL or Kernel, I don't > > recall which one it was, but was the same reason :-P > > how interesting... > > resulted in a vulnerability n mysql: > > https://bugzilla.redhat.com/show_bug.cgi?id=CVE-2012-2122 > > -- > - Codito, ergo sum - "I code, therefore I am" -- > The Rasterman (Carsten Haitzler)ras...@rasterman.com > > > > -- > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Sun, 12 Aug 2012 01:27:21 -0300 Gustavo Sverzut Barbieri said: > On Sun, Aug 12, 2012 at 1:17 AM, Enlightenment SVN > wrote: > > so memcpy changed behavior, though within specs of the manual page > > anyway, but now the values can be ones that break the simple assignment. > > there was a long discussion about this and MySQL or Kernel, I don't > recall which one it was, but was the same reason :-P how interesting... resulted in a vulnerability n mysql: https://bugzilla.redhat.com/show_bug.cgi?id=CVE-2012-2122 -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Sun, Aug 12, 2012 at 1:17 AM, Enlightenment SVN wrote: > Log: > finally found evas_map weirdness bug. CEDRIC code...! commit #74180. > > now here's the rub. from the glibc manual page: > > ... > int memcmp(const void *s1, const void *s2, size_t n); > > DESCRIPTION > The memcmp() function compares the first n bytes (each interpreted > as > unsigned char) of the memory areas s1 and s2. It returns an > integer > less than, equal to, or greater than zero if s1 is found, > respectively, > to be less than, to match, or be greater than s2. > > RETURN VALUE > The memcmp() function returns an integer less than, equal to, > or > greater than zero if the first n bytes of s1 is found, respectively, > to > be less than, to match, or be greater than the first n bytes of s2. > > ... > > this explicitly says that s1 and s2 have their BYTES compared... and > then returns just some value < 0, 0 or > 0 based on the difference. what > that value is and means is not defined, as long as it is < 0, 0 or > 0. > > so the C standard has this to say: > > 6.3.1.3 Signed and unsigned integers > > 2. Otherwise, if the new type is unsigned, the value is converted by > repeatedly adding or subtracting one more than the maximum value that > can be represented in the new type until the value is in the range of > the new type. > > so a result of -255 (possible) is converted by REPEATEDLY adding the > max size of the new type (255) until within range... so ... > -255 + 255 = 0 ... within range.. BUT FALSE! > > so why do we see this now? something changed in memcpy behavior. > before we ONLY saw values of -1, 0 or 1 - nothing else, NOW we see > thins like: > > -12288 > 49152 > 4096 > 16384 > 61440 > -53248 > > so memcpy changed behavior, though within specs of the manual page > anyway, but now the values can be ones that break the simple assignment. there was a long discussion about this and MySQL or Kernel, I don't recall which one it was, but was the same reason :-P -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Wed, 7 Mar 2012 17:58:48 +0100 Joerg Sonnenberger said: > On Thu, Mar 08, 2012 at 12:51:19AM +0900, Carsten Haitzler wrote: > > On Wed, 7 Mar 2012 12:37:42 -0300 Gustavo Sverzut Barbieri > > said: > > > > > On Wed, Mar 7, 2012 at 6:05 AM, Enlightenment SVN > > > wrote: > > > > Log: > > > > to be paranoid - ensure umask for mkstemp allows no other uids oir > > > > grps access. > > > > > > Ugh, isn't there any other way to do this? What you did break if > > > people are using other threads to open files, and if they fork() they > > > will inherit these values! TOO BAD :-( > > > > 1. umask is reset back immediately after creation so fork (unless its FROM > > another thread which is incredibly odd) wont be a problem > > 2. its changed for a very short period so yes - it could affect other > > threads creating files too but its a very small condition, but yes - its > > possible > > 3. no mk*temp libc funcs let u set mode so this is the only way other than > > creating our own tmpfile name allocator. > > > > NOT doing this makes for a security hole. i'd rather this very "rare/odd" > > bug than the security hole until someone spends the time to make a custom > > tmpfile creator. > > mkstemp is supposed to create the file with 0600 permission, so is that > really necessary? indeed you are right - early glibc's were 0666. shall remove then. glibc issue if they care about this. :) -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Thu, Mar 08, 2012 at 12:51:19AM +0900, Carsten Haitzler wrote: > On Wed, 7 Mar 2012 12:37:42 -0300 Gustavo Sverzut Barbieri > said: > > > On Wed, Mar 7, 2012 at 6:05 AM, Enlightenment SVN > > wrote: > > > Log: > > > to be paranoid - ensure umask for mkstemp allows no other uids oir > > > grps access. > > > > Ugh, isn't there any other way to do this? What you did break if > > people are using other threads to open files, and if they fork() they > > will inherit these values! TOO BAD :-( > > 1. umask is reset back immediately after creation so fork (unless its FROM > another thread which is incredibly odd) wont be a problem > 2. its changed for a very short period so yes - it could affect other threads > creating files too but its a very small condition, but yes - its possible > 3. no mk*temp libc funcs let u set mode so this is the only way other than > creating our own tmpfile name allocator. > > NOT doing this makes for a security hole. i'd rather this very "rare/odd" bug > than the security hole until someone spends the time to make a custom tmpfile > creator. mkstemp is supposed to create the file with 0600 permission, so is that really necessary? Joerg -- Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Wed, 7 Mar 2012 12:37:42 -0300 Gustavo Sverzut Barbieri said: > On Wed, Mar 7, 2012 at 6:05 AM, Enlightenment SVN > wrote: > > Log: > > to be paranoid - ensure umask for mkstemp allows no other uids oir > > grps access. > > Ugh, isn't there any other way to do this? What you did break if > people are using other threads to open files, and if they fork() they > will inherit these values! TOO BAD :-( 1. umask is reset back immediately after creation so fork (unless its FROM another thread which is incredibly odd) wont be a problem 2. its changed for a very short period so yes - it could affect other threads creating files too but its a very small condition, but yes - its possible 3. no mk*temp libc funcs let u set mode so this is the only way other than creating our own tmpfile name allocator. NOT doing this makes for a security hole. i'd rather this very "rare/odd" bug than the security hole until someone spends the time to make a custom tmpfile creator. -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Wed, Mar 7, 2012 at 6:05 AM, Enlightenment SVN wrote: > Log: > to be paranoid - ensure umask for mkstemp allows no other uids oir > grps access. Ugh, isn't there any other way to do this? What you did break if people are using other threads to open files, and if they fork() they will inherit these values! TOO BAD :-( -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Thu, 23 Feb 2012 13:51:47 -0200 Gustavo Sverzut Barbieri said: > On Thu, Feb 23, 2012 at 2:53 AM, Enlightenment SVN > wrote: > > Log: > > since too many people make this mistake of not reading evas's docs and > > seeing color is PREMULTIPLIED ARGB... evas_object_color_set is just > > going to enforce it and limit r, g and b to a. > > I always wondered why it did not do that. > > But please issue a warning as well, since you're just resetting the > color instead of properly fix the color to be premultiplied (ie: > a=128, r=200, g=255, b=129 will become a = r = g = b = 128 with your > code). i was going to put in an abort() instead. :) seriously. thats the code i had typed up before i changed it. :) -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Thu, Feb 23, 2012 at 2:53 AM, Enlightenment SVN wrote: > Log: > since too many people make this mistake of not reading evas's docs and > seeing color is PREMULTIPLIED ARGB... evas_object_color_set is just > going to enforce it and limit r, g and b to a. I always wondered why it did not do that. But please issue a warning as well, since you're just resetting the color instead of properly fix the color to be premultiplied (ie: a=128, r=200, g=255, b=129 will become a = r = g = b = 128 with your code). -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Fri, 30 Dec 2011 16:40:42 +0100 Cedric BAIL said:
> On Fri, Dec 30, 2011 at 4:20 PM, Enlightenment SVN
> wrote:
> > Log:
> > fix mouse out handler to out all objects mouse is in - right thing to
> > do.
>
> I see some resizing issue in E17 where mouse out seems to be ignored
> or something like that.
yeah. it's fix 1 bug, create a onther. e17 has some really old crusty code
where it does weird things with border events. fixed now. :)
> > Author: raster
> > Date: 2011-12-30 07:20:15 -0800 (Fri, 30 Dec 2011)
> > New Revision: 66699
> > Trac: http://trac.enlightenment.org/e/changeset/66699
> >
> > Modified:
> > trunk/evas/src/lib/canvas/evas_events.c
> >
> > Modified: trunk/evas/src/lib/canvas/evas_events.c
> > ===
> > --- trunk/evas/src/lib/canvas/evas_events.c 2011-12-30 15:17:13 UTC
> > (rev 66698) +++ trunk/evas/src/lib/canvas/evas_events.c 2011-12-30
> > 15:20:15 UTC (rev 66699) @@ -909,8 +909,7 @@
> > ev.event_flags = e->default_event_flags;
> >
> > _evas_walk(e);
> > - /* if our mouse button is grabbed to any objects */
> > - if ((0) && (e->pointer.mouse_grabbed != 0))
> > + /* if our mouse button is inside any objects */
> > {
> > /* go thru old list of in objects */
> > Eina_List *l, *copy;
> > @@ -928,7 +927,7 @@
> > if (!obj->delete_me)
> > {
> > if (e->events_frozen <= 0)
> > - evas_object_event_callback_call(obj,
> > EVAS_CALLBACK_MOUSE_OUT, &ev, event_id);
> > + evas_object_event_callback_call(obj,
> > EVAS_CALLBACK_MOUSE_OUT, &ev, event_id); }
> > obj->mouse_grabbed = 0;
> > }
> >
> >
> > --
> > Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
> > infrastructure or vast IT resources to deliver seamless, secure access to
> > virtual desktops. With this all-in-one solution, easily deploy virtual
> > desktops for less than the cost of PCs and save 60% on VDI infrastructure
> > costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
> > ___
> > enlightenment-svn mailing list
> > enlightenment-...@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
> >
>
>
>
> --
> Cedric BAIL
>
> --
> Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
> infrastructure or vast IT resources to deliver seamless, secure access to
> virtual desktops. With this all-in-one solution, easily deploy virtual
> desktops for less than the cost of PCs and save 60% on VDI infrastructure
> costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com
--
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual
desktops for less than the cost of PCs and save 60% on VDI infrastructure
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Fri, Dec 30, 2011 at 4:20 PM, Enlightenment SVN
wrote:
> Log:
> fix mouse out handler to out all objects mouse is in - right thing to
> do.
I see some resizing issue in E17 where mouse out seems to be ignored
or something like that.
> Author: raster
> Date: 2011-12-30 07:20:15 -0800 (Fri, 30 Dec 2011)
> New Revision: 66699
> Trac: http://trac.enlightenment.org/e/changeset/66699
>
> Modified:
> trunk/evas/src/lib/canvas/evas_events.c
>
> Modified: trunk/evas/src/lib/canvas/evas_events.c
> ===
> --- trunk/evas/src/lib/canvas/evas_events.c 2011-12-30 15:17:13 UTC (rev
> 66698)
> +++ trunk/evas/src/lib/canvas/evas_events.c 2011-12-30 15:20:15 UTC (rev
> 66699)
> @@ -909,8 +909,7 @@
> ev.event_flags = e->default_event_flags;
>
> _evas_walk(e);
> - /* if our mouse button is grabbed to any objects */
> - if ((0) && (e->pointer.mouse_grabbed != 0))
> + /* if our mouse button is inside any objects */
> {
> /* go thru old list of in objects */
> Eina_List *l, *copy;
> @@ -928,7 +927,7 @@
> if (!obj->delete_me)
> {
> if (e->events_frozen <= 0)
> - evas_object_event_callback_call(obj,
> EVAS_CALLBACK_MOUSE_OUT, &ev, event_id);
> + evas_object_event_callback_call(obj,
> EVAS_CALLBACK_MOUSE_OUT, &ev, event_id);
> }
> obj->mouse_grabbed = 0;
> }
>
>
> --
> Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
> infrastructure or vast IT resources to deliver seamless, secure access to
> virtual desktops. With this all-in-one solution, easily deploy virtual
> desktops for less than the cost of PCs and save 60% on VDI infrastructure
> costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
--
Cedric BAIL
--
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual
desktops for less than the cost of PCs and save 60% on VDI infrastructure
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Sunday, October 23, 2011, Carsten Haitzler wrote: > On Sun, 23 Oct 2011 11:17:25 -0200 Gustavo Sverzut Barbieri > said: > >> It is funny to see every 6 months or so... I gave up on trying because since >> 2007 when I started we have a common blocker thing: raster. He is the single > > and every time this comes up i say "someone go find a formatter that > consistently format in a way close if not exactly how things are done now". the > only person who seriously did anything is mike! you, instead just choose to > whine like a broken record. i gave a path to solve this. it's not quite there > yet. It wont help to just find a tool :-) >> thing that will block this, his editor does not have such a thing and nobody > > OMG! OMG! i'm not in the vim user club! oh i'm such a loser! i'm not in the vim > user club and i don't care. i suggest you adjust your attitude or take it and > yourself elsewhere Btw, I'm an emacs user. We have both clubs here! >> will make him change his editor and he is the one doing most of the code >> (and will remain like that forever as his attitude doesn't help to attract >> more dudes) > > now you want to begin making it personal? fine. let's see how well that works > out. > >> So just ignore white spaces and br happy ;-) As I said, just ignore and be happy ;-) >> >> On Sunday, October 23, 2011, Lucas De Marchi < lucas.demar...@profusion.mobi> >> wrote: >> > On Sun, Oct 23, 2011 at 5:56 AM, Carsten Haitzler >> wrote: >> >> On Sun, 23 Oct 2011 15:41:25 +0900 Daniel Juyung Seo < >> seojuyu...@gmail.com> >> >> said: >> >> >> >> i see my test worked. the irrational formatting pedants now come out of >> the >> >> woodwork. i did this to see just who would respond and how. >> >> >> >> i added spaces on BLANK LINES that align with indenting. all it takes is >> an >> >> enter or hitting tab. all editors do this by default (with autoindent >> on). >> > >> > All decent editors have an option to configure this. It's not a >> > matter of fighting the editor, but correctly configuring it. >> > >> > Can you look at the diff you generated and sanely review it with the >> > bunch of line changes that are totally unrelated? >> > >> >> >> >> are these pedants (like you and vincent) proposing that we fight against >> our >> >> editors and keep undoing the work they do for us? i assume the answer is >> yes >> >> because this whole thing is irrational. >> > >> > Do you really think all the other decent open source projects out >> > there have pedant developers/maintainers? >> > >> > >> > Lucas De Marchi >> > >> > >> -- >> > The demand for IT networking professionals continues to grow, and the >> > demand for specialized networking skills is growing even more rapidly. >> > Take a complimentary Learning@Cisco Self-Assessment and learn >> > about Cisco certifications, training, and career opportunities. >> > http://p.sf.net/sfu/cisco-dev2dev >> > ___ >> > enlightenment-devel mailing list >> > enlightenment-devel@lists.sourceforge.net >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > >> >> -- >> Gustavo Sverzut Barbieri >> http://profusion.mobi embedded systems >> -- >> MSN: barbi...@gmail.com >> Skype: gsbarbieri >> Mobile: +55 (19) 9225-2202 >> -- >> The demand for IT networking professionals continues to grow, and the >> demand for specialized networking skills is growing even more rapidly. >> Take a complimentary Learning@Cisco Self-Assessment and learn >> about Cisco certifications, training, and career opportunities. >> http://p.sf.net/sfu/cisco-dev2dev >> ___ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > > -- > - Codito, ergo sum - "I code, therefore I am" -- > The Rasterman (Carsten Haitzler)ras...@rasterman.com > > -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Sun, 23 Oct 2011 10:55:13 -0200 Lucas De Marchi said: > On Sun, Oct 23, 2011 at 5:56 AM, Carsten Haitzler > wrote: > > On Sun, 23 Oct 2011 15:41:25 +0900 Daniel Juyung Seo > > said: > > > > i see my test worked. the irrational formatting pedants now come out of the > > woodwork. i did this to see just who would respond and how. > > > > i added spaces on BLANK LINES that align with indenting. all it takes is an > > enter or hitting tab. all editors do this by default (with autoindent on). > > All decent editors have an option to configure this. It's not a > matter of fighting the editor, but correctly configuring it. > > Can you look at the diff you generated and sanely review it with the > bunch of line changes that are totally unrelated? you don't get it. that commit was a troll. specifically to set off all the "omg whitespace at the end of a line!" brigade. it has worked a charm. > > > > are these pedants (like you and vincent) proposing that we fight against our > > editors and keep undoing the work they do for us? i assume the answer is yes > > because this whole thing is irrational. > > Do you really think all the other decent open source projects out > there have pedant developers/maintainers? well funny - i'm not as pedantic. this is the "how dare your editor not do what mine is doing" brigade. -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Sun, 23 Oct 2011 11:17:25 -0200 Gustavo Sverzut Barbieri said: > It is funny to see every 6 months or so... I gave up on trying because since > 2007 when I started we have a common blocker thing: raster. He is the single and every time this comes up i say "someone go find a formatter that consistently format in a way close if not exactly how things are done now". the only person who seriously did anything is mike! you, instead just choose to whine like a broken record. i gave a path to solve this. it's not quite there yet. > thing that will block this, his editor does not have such a thing and nobody OMG! OMG! i'm not in the vim user club! oh i'm such a loser! i'm not in the vim user club and i don't care. i suggest you adjust your attitude or take it and yourself elsewhere > will make him change his editor and he is the one doing most of the code > (and will remain like that forever as his attitude doesn't help to attract > more dudes) now you want to begin making it personal? fine. let's see how well that works out. > So just ignore white spaces and br happy ;-) > > On Sunday, October 23, 2011, Lucas De Marchi > wrote: > > On Sun, Oct 23, 2011 at 5:56 AM, Carsten Haitzler > wrote: > >> On Sun, 23 Oct 2011 15:41:25 +0900 Daniel Juyung Seo < > seojuyu...@gmail.com> > >> said: > >> > >> i see my test worked. the irrational formatting pedants now come out of > the > >> woodwork. i did this to see just who would respond and how. > >> > >> i added spaces on BLANK LINES that align with indenting. all it takes is > an > >> enter or hitting tab. all editors do this by default (with autoindent > on). > > > > All decent editors have an option to configure this. It's not a > > matter of fighting the editor, but correctly configuring it. > > > > Can you look at the diff you generated and sanely review it with the > > bunch of line changes that are totally unrelated? > > > >> > >> are these pedants (like you and vincent) proposing that we fight against > our > >> editors and keep undoing the work they do for us? i assume the answer is > yes > >> because this whole thing is irrational. > > > > Do you really think all the other decent open source projects out > > there have pedant developers/maintainers? > > > > > > Lucas De Marchi > > > > > -- > > The demand for IT networking professionals continues to grow, and the > > demand for specialized networking skills is growing even more rapidly. > > Take a complimentary Learning@Cisco Self-Assessment and learn > > about Cisco certifications, training, and career opportunities. > > http://p.sf.net/sfu/cisco-dev2dev > > ___ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > -- > Gustavo Sverzut Barbieri > http://profusion.mobi embedded systems > -- > MSN: barbi...@gmail.com > Skype: gsbarbieri > Mobile: +55 (19) 9225-2202 > -- > The demand for IT networking professionals continues to grow, and the > demand for specialized networking skills is growing even more rapidly. > Take a complimentary Learning@Cisco Self-Assessment and learn > about Cisco certifications, training, and career opportunities. > http://p.sf.net/sfu/cisco-dev2dev > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
It is funny to see every 6 months or so... I gave up on trying because since 2007 when I started we have a common blocker thing: raster. He is the single thing that will block this, his editor does not have such a thing and nobody will make him change his editor and he is the one doing most of the code (and will remain like that forever as his attitude doesn't help to attract more dudes) So just ignore white spaces and br happy ;-) On Sunday, October 23, 2011, Lucas De Marchi wrote: > On Sun, Oct 23, 2011 at 5:56 AM, Carsten Haitzler wrote: >> On Sun, 23 Oct 2011 15:41:25 +0900 Daniel Juyung Seo < seojuyu...@gmail.com> >> said: >> >> i see my test worked. the irrational formatting pedants now come out of the >> woodwork. i did this to see just who would respond and how. >> >> i added spaces on BLANK LINES that align with indenting. all it takes is an >> enter or hitting tab. all editors do this by default (with autoindent on). > > All decent editors have an option to configure this. It's not a > matter of fighting the editor, but correctly configuring it. > > Can you look at the diff you generated and sanely review it with the > bunch of line changes that are totally unrelated? > >> >> are these pedants (like you and vincent) proposing that we fight against our >> editors and keep undoing the work they do for us? i assume the answer is yes >> because this whole thing is irrational. > > Do you really think all the other decent open source projects out > there have pedant developers/maintainers? > > > Lucas De Marchi > > -- > The demand for IT networking professionals continues to grow, and the > demand for specialized networking skills is growing even more rapidly. > Take a complimentary Learning@Cisco Self-Assessment and learn > about Cisco certifications, training, and career opportunities. > http://p.sf.net/sfu/cisco-dev2dev > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Sun, Oct 23, 2011 at 5:56 AM, Carsten Haitzler wrote: > On Sun, 23 Oct 2011 15:41:25 +0900 Daniel Juyung Seo > said: > > i see my test worked. the irrational formatting pedants now come out of the > woodwork. i did this to see just who would respond and how. > > i added spaces on BLANK LINES that align with indenting. all it takes is an > enter or hitting tab. all editors do this by default (with autoindent on). All decent editors have an option to configure this. It's not a matter of fighting the editor, but correctly configuring it. Can you look at the diff you generated and sanely review it with the bunch of line changes that are totally unrelated? > > are these pedants (like you and vincent) proposing that we fight against our > editors and keep undoing the work they do for us? i assume the answer is yes > because this whole thing is irrational. Do you really think all the other decent open source projects out there have pedant developers/maintainers? Lucas De Marchi -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Sun, 23 Oct 2011 10:00:49 +0200 (CEST) Vincent Torri
said:
>
>
> On Sun, 23 Oct 2011, Carsten Haitzler (The Rasterman) wrote:
>
> > On Sun, 23 Oct 2011 15:41:25 +0900 Daniel Juyung Seo
> > said:
> >
> > i see my test worked. the irrational formatting pedants now come out of the
> > woodwork. i did this to see just who would respond and how.
> >
> > i added spaces on BLANK LINES that align with indenting. all it takes is an
> > enter or hitting tab. all editors do this by default (with autoindent on).
> >
> > are these pedants (like you and vincent) proposing that we fight against our
> > editors and keep undoing the work they do for us? i assume the answer is yes
> > because this whole thing is irrational.
>
> no : the parsing fo the files is faster without these white spaces, so
> it's not illogical :p
BWHAHAHAHAHAHAHAHHAHAH! hehehehe... well played! touché!
:)
> >
> >> Well... This is my personal opinion about this commit.
> >> This is so disappointing and childish as a grown-up person.
> >>
> >> I didn't set that vim configuration before I was requested to remove
> >> trailing whitespaces from enlightenment community.
> >> Now e-founder encourages trailing whitespaces.
> >> Seriously that's so funny.
> >>
> >> Anyhow, I have no objection to you doing this funny behavior because
> >> it looks like trailing whitespace is now allowed in enlightenment.
> >>
> >> Thanks.
> >>
> >> Daniel Juyung Seo (SeoZ)
> >>
> >> On Sun, Oct 23, 2011 at 12:51 PM, Enlightenment SVN
> >> wrote:
> >>> Log:
> >>> annoy vim users with spaces at the start of blank lines. :)
> >>>
> >>>
> >>>
> >>> Author: raster
> >>> Date: 2011-10-22 20:51:41 -0700 (Sat, 22 Oct 2011)
> >>> New Revision: 64317
> >>> Trac: http://trac.enlightenment.org/e/changeset/64317
> >>>
> >>> Modified:
> >>> trunk/evas/src/lib/canvas/evas_async_events.c
> >>>
> >>> Modified: trunk/evas/src/lib/canvas/evas_async_events.c
> >>> ===
> >>> --- trunk/evas/src/lib/canvas/evas_async_events.c 2011-10-22
> >>> 23:40:48 UTC (rev 64316) +++ trunk/evas/src/lib/canvas/evas_async_events.c
> >>> 2011-10-23 03:51:41 UTC (rev 64317) @@ -3,11 +3,11 @@
> >>>
> >>> #ifdef BUILD_ASYNC_EVENTS
> >>>
> >>> -#ifndef _MSC_VER
> >>> -# include
> >>> -#endif
> >>> -#include
> >>> -#include
> >>> +# ifndef _MSC_VER
> >>> +# include
> >>> +# endif
> >>> +# include
> >>> +# include
> >>>
> >>> static int _fd_write = -1;
> >>> static int _fd_read = -1;
> >>> @@ -28,21 +28,21 @@
> >>> evas_async_events_init(void)
> >>> {
> >>> int filedes[2];
> >>> -
> >>> +
> >>> _init_evas_event++;
> >>> if (_init_evas_event > 1) return _init_evas_event;
> >>> -
> >>> +
> >>> if (pipe(filedes) == -1)
> >>> {
> >>> _init_evas_event = 0;
> >>> return 0;
> >>> }
> >>> -
> >>> +
> >>> _fd_read = filedes[0];
> >>> _fd_write = filedes[1];
> >>> -
> >>> +
> >>> fcntl(_fd_read, F_SETFL, O_NONBLOCK);
> >>> -
> >>> +
> >>> return _init_evas_event;
> >>> }
> >>>
> >>> @@ -51,12 +51,12 @@
> >>> {
> >>> _init_evas_event--;
> >>> if (_init_evas_event > 0) return _init_evas_event;
> >>> -
> >>> +
> >>> close(_fd_read);
> >>> close(_fd_write);
> >>> _fd_read = -1;
> >>> _fd_write = -1;
> >>> -
> >>> +
> >>> return _init_evas_event;
> >>> }
> >>>
> >>> @@ -79,10 +79,10 @@
> >>> Evas_Event_Async *ev;
> >>> int check;
> >>> int count = 0;
> >>> -
> >>> +
> >>> if (_fd_read == -1) return 0;
> >>> -
> >>> - do
> >>> +
> >>> + do
> >>> {
> >>> check = read(_fd_read, &ev, sizeof (Evas_Event_Async *));
> >>>
> >>> @@ -92,11 +92,11 @@
> >>> free(ev);
> >>> count++;
> >>> }
> >>> - }
> >>> + }
> >>> while (check > 0);
> >>> -
> >>> +
> >>> evas_cache_image_wakeup();
> >>> -
> >>> +
> >>> if (check < 0)
> >>> {
> >>> switch (errno)
> >>> @@ -108,7 +108,7 @@
> >>> _fd_read = -1;
> >>> }
> >>> }
> >>> -
> >>> +
> >>> return count;
> >>> #else
> >>> return 0;
> >>> @@ -122,27 +122,27 @@
> >>> Evas_Event_Async *ev;
> >>> ssize_t check;
> >>> Eina_Bool result = EINA_FALSE;
> >>> -
> >>> +
> >>> if (!func) return 0;
> >>> if (_fd_write == -1) return 0;
> >>> -
> >>> +
> >>> ev = calloc(1, sizeof (Evas_Event_Async));
> >>> if (!ev) return 0;
> >>> -
> >>> +
> >>> ev->func = func;
> >>> ev->target = target;
> >>> ev->type = type;
> >>> ev->event_info = event_info;
> >>> -
> >>> - do
> >>> +
> >>> + do
> >>> {
> >>> check = write(_fd_write, &ev, sizeof (Evas_Event_Async*));
> >>> }
> >>> - while ((check != sizeof (Evas_Event_Async*)) &&
> >>> + while ((check != sizeof (Evas_Event_Async*)) &&
> >>> ((errno == EINTR) || (errno == EAGAIN)));
> >>> -
> >>> +
> >>> evas_cache_image_wakeup();
> >>> -
> >>> +
> >>> if (check == sizeof (Evas_Event_Async*))
> >>>
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On 23/10/11 10:24, Mike Blumenkrantz wrote: > On Sun, 23 Oct 2011 10:22:02 +0200 > Tom Hacohen wrote: >> Trailing whites are bad for a couple reasons, some of which are: >> * unwanted increase in source code size (it's actually noticeable, but >> hey, it's also the case with spaces vs tabs). > yeah, and unnecessary prefixing of commit messages does the same. problem? It's not unnecessary, I explained exactly why in the email I suggested it at, and I guess that's why people agreed with it. More than that, I think, and I believe that others agree, that this was a very needed and useful change, it surely made my life easier/more convenient. Furthermore, commits messages are different than source codes, making such comparison is at best a poor trolling attempt. >> * Increased likelihood of merge clashes. It's easier to miss whitespace >> changes when you don't care about them, and a lot of whites can make it >> nuts. > don't you use git which can avoid whitespace clashes? I do, but I'm not aware of any way to make git avoid whitespace clashes, but even if there is a way, there are still svn users out there. Please, if you know such a way, let me know, sounds like a useful trick. >> * Causing annoying line-wraps for no reason. (a couple of trailing whites). > use a real editor/term which doesn't have mandatory 80 character wrapping > since > we aren't in the 1960s anymore? It's part of the coding conventions, I can change it to whatever value I want in vim, but it's set as 80 cause that's what we all decided to follow (e coding conventions). Furthermore, I rather like 80, it's very useful, it lets you open a couple of instances of vim in the same window without any horizontal scrolling (or wrapping in my case). >> * People (I'm among them) just don't like trailing whites. > oh good, finally a real point. ;P >> * Some other things I can't think about atm. > stop claiming there's any reason to this besides not liking trailing > whitespaces. I don't like them, so I remove them. sometimes. to suggest > anything different is really not going to do anything but give me (and > others) some laughs. > As you can see, I stated a couple of reasons, one of which is the reason you mentioned, which holds on it's own, the others, are valid as well. I'm also against the whitespace witch-hunt, i.e going through all of svn and manually changing whitespace errors, but I'm very much against adding new errors to the code base. -- Tom. -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Sun, 23 Oct 2011 10:22:02 +0200 Tom Hacohen wrote: > On 23/10/11 09:56, Carsten Haitzler (The Rasterman) wrote: > > i see my test worked. the irrational formatting pedants now come out of the > > woodwork. i did this to see just who would respond and how. > > You test was a bit biased from the start. Making the commit message this > provoking is sure to cause extreme and immediate responses. > > > > i added spaces on BLANK LINES that align with indenting. all it takes is an > > enter or hitting tab. all editors do this by default (with autoindent on). > > > > are these pedants (like you and vincent) proposing that we fight against our > > editors and keep undoing the work they do for us? i assume the answer is yes > > because this whole thing is irrational. > > Decent editors (and even less than decent ones), like vim, automatically > remove the automatic indentation when it was not used, i.e when you > don't insert code. > > Trailing whites are bad for a couple reasons, some of which are: > * unwanted increase in source code size (it's actually noticeable, but > hey, it's also the case with spaces vs tabs). yeah, and unnecessary prefixing of commit messages does the same. problem? > * Increased likelihood of merge clashes. It's easier to miss whitespace > changes when you don't care about them, and a lot of whites can make it > nuts. don't you use git which can avoid whitespace clashes? > * Causing annoying line-wraps for no reason. (a couple of trailing whites). use a real editor/term which doesn't have mandatory 80 character wrapping since we aren't in the 1960s anymore? > * People (I'm among them) just don't like trailing whites. oh good, finally a real point. > * Some other things I can't think about atm. > > -- > Tom. > > -- > The demand for IT networking professionals continues to grow, and the > demand for specialized networking skills is growing even more rapidly. > Take a complimentary Learning@Cisco Self-Assessment and learn > about Cisco certifications, training, and career opportunities. > http://p.sf.net/sfu/cisco-dev2dev > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel stop claiming there's any reason to this besides not liking trailing whitespaces. I don't like them, so I remove them. sometimes. to suggest anything different is really not going to do anything but give me (and others) some laughs. -- Mike Blumenkrantz Zentific: Doctor recommended, mother approved. -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On 23/10/11 09:56, Carsten Haitzler (The Rasterman) wrote: > i see my test worked. the irrational formatting pedants now come out of the > woodwork. i did this to see just who would respond and how. You test was a bit biased from the start. Making the commit message this provoking is sure to cause extreme and immediate responses. > > i added spaces on BLANK LINES that align with indenting. all it takes is an > enter or hitting tab. all editors do this by default (with autoindent on). > > are these pedants (like you and vincent) proposing that we fight against our > editors and keep undoing the work they do for us? i assume the answer is yes > because this whole thing is irrational. Decent editors (and even less than decent ones), like vim, automatically remove the automatic indentation when it was not used, i.e when you don't insert code. Trailing whites are bad for a couple reasons, some of which are: * unwanted increase in source code size (it's actually noticeable, but hey, it's also the case with spaces vs tabs). * Increased likelihood of merge clashes. It's easier to miss whitespace changes when you don't care about them, and a lot of whites can make it nuts. * Causing annoying line-wraps for no reason. (a couple of trailing whites). * People (I'm among them) just don't like trailing whites. * Some other things I can't think about atm. -- Tom. -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
yeah i was not blaming editors but i was pointing out the funny commit
message.
i don't think editor did type that message automatically.
anyhow still it looks so ... :)
Daniel Juyung Seo (SeoZ)
On Oct 23, 2011 4:56 PM, "Carsten Haitzler" wrote:
> On Sun, 23 Oct 2011 15:41:25 +0900 Daniel Juyung Seo >
> said:
>
> i see my test worked. the irrational formatting pedants now come out of the
> woodwork. i did this to see just who would respond and how.
>
> i added spaces on BLANK LINES that align with indenting. all it takes is an
> enter or hitting tab. all editors do this by default (with autoindent on).
>
> are these pedants (like you and vincent) proposing that we fight against
> our
> editors and keep undoing the work they do for us? i assume the answer is
> yes
> because this whole thing is irrational.
>
> > Well... This is my personal opinion about this commit.
> > This is so disappointing and childish as a grown-up person.
> >
> > I didn't set that vim configuration before I was requested to remove
> > trailing whitespaces from enlightenment community.
> > Now e-founder encourages trailing whitespaces.
> > Seriously that's so funny.
> >
> > Anyhow, I have no objection to you doing this funny behavior because
> > it looks like trailing whitespace is now allowed in enlightenment.
> >
> > Thanks.
> >
> > Daniel Juyung Seo (SeoZ)
> >
> > On Sun, Oct 23, 2011 at 12:51 PM, Enlightenment SVN
> > wrote:
> > > Log:
> > > annoy vim users with spaces at the start of blank lines. :)
> > >
> > >
> > >
> > > Author: raster
> > > Date: 2011-10-22 20:51:41 -0700 (Sat, 22 Oct 2011)
> > > New Revision: 64317
> > > Trac: http://trac.enlightenment.org/e/changeset/64317
> > >
> > > Modified:
> > > trunk/evas/src/lib/canvas/evas_async_events.c
> > >
> > > Modified: trunk/evas/src/lib/canvas/evas_async_events.c
> > > ===
> > > --- trunk/evas/src/lib/canvas/evas_async_events.c 2011-10-22
> 23:40:48
> > > UTC (rev 64316) +++ trunk/evas/src/lib/canvas/evas_async_events.c
> > > 2011-10-23 03:51:41 UTC (rev 64317) @@ -3,11 +3,11 @@
> > >
> > > #ifdef BUILD_ASYNC_EVENTS
> > >
> > > -#ifndef _MSC_VER
> > > -# include
> > > -#endif
> > > -#include
> > > -#include
> > > +# ifndef _MSC_VER
> > > +# include
> > > +# endif
> > > +# include
> > > +# include
> > >
> > > static int _fd_write = -1;
> > > static int _fd_read = -1;
> > > @@ -28,21 +28,21 @@
> > > evas_async_events_init(void)
> > > {
> > >int filedes[2];
> > > -
> > > +
> > >_init_evas_event++;
> > >if (_init_evas_event > 1) return _init_evas_event;
> > > -
> > > +
> > >if (pipe(filedes) == -1)
> > > {
> > >_init_evas_event = 0;
> > >return 0;
> > > }
> > > -
> > > +
> > >_fd_read = filedes[0];
> > >_fd_write = filedes[1];
> > > -
> > > +
> > >fcntl(_fd_read, F_SETFL, O_NONBLOCK);
> > > -
> > > +
> > >return _init_evas_event;
> > > }
> > >
> > > @@ -51,12 +51,12 @@
> > > {
> > >_init_evas_event--;
> > >if (_init_evas_event > 0) return _init_evas_event;
> > > -
> > > +
> > >close(_fd_read);
> > >close(_fd_write);
> > >_fd_read = -1;
> > >_fd_write = -1;
> > > -
> > > +
> > >return _init_evas_event;
> > > }
> > >
> > > @@ -79,10 +79,10 @@
> > >Evas_Event_Async *ev;
> > >int check;
> > >int count = 0;
> > > -
> > > +
> > >if (_fd_read == -1) return 0;
> > > -
> > > - do
> > > +
> > > + do
> > > {
> > >check = read(_fd_read, &ev, sizeof (Evas_Event_Async *));
> > >
> > > @@ -92,11 +92,11 @@
> > > free(ev);
> > > count++;
> > > }
> > > - }
> > > + }
> > >while (check > 0);
> > > -
> > > +
> > >evas_cache_image_wakeup();
> > > -
> > > +
> > >if (check < 0)
> > > {
> > > switch (errno)
> > > @@ -108,7 +108,7 @@
> > > _fd_read = -1;
> > > }
> > > }
> > > -
> > > +
> > >return count;
> > > #else
> > >return 0;
> > > @@ -122,27 +122,27 @@
> > >Evas_Event_Async *ev;
> > >ssize_t check;
> > >Eina_Bool result = EINA_FALSE;
> > > -
> > > +
> > >if (!func) return 0;
> > >if (_fd_write == -1) return 0;
> > > -
> > > +
> > >ev = calloc(1, sizeof (Evas_Event_Async));
> > >if (!ev) return 0;
> > > -
> > > +
> > >ev->func = func;
> > >ev->target = target;
> > >ev->type = type;
> > >ev->event_info = event_info;
> > > -
> > > - do
> > > +
> > > + do
> > > {
> > > check = write(_fd_write, &ev, sizeof (Evas_Event_Async*));
> > > }
> > > - while ((check != sizeof (Evas_Event_Async*)) &&
> > > + while ((check != sizeof (Evas_Event_Async*)) &&
> > > ((errno == EINTR) || (errno == EAGAIN)));
> > > -
> > > +
> > >evas_cache_image_wakeup();
> > > -
> > > +
> > >if (check == sizeof (Evas_Event_Async*))
> > > result = EINA_TRUE;
> > >else
> > > @@ -156,7 +156,7 @@
> > > _
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Sun, 23 Oct 2011, Carsten Haitzler (The Rasterman) wrote:
On Sun, 23 Oct 2011 15:41:25 +0900 Daniel Juyung Seo
said:
i see my test worked. the irrational formatting pedants now come out of the
woodwork. i did this to see just who would respond and how.
i added spaces on BLANK LINES that align with indenting. all it takes is an
enter or hitting tab. all editors do this by default (with autoindent on).
are these pedants (like you and vincent) proposing that we fight against our
editors and keep undoing the work they do for us? i assume the answer is yes
because this whole thing is irrational.
no : the parsing fo the files is faster without these white spaces, so
it's not illogical :p
Vincent
Well... This is my personal opinion about this commit.
This is so disappointing and childish as a grown-up person.
I didn't set that vim configuration before I was requested to remove
trailing whitespaces from enlightenment community.
Now e-founder encourages trailing whitespaces.
Seriously that's so funny.
Anyhow, I have no objection to you doing this funny behavior because
it looks like trailing whitespace is now allowed in enlightenment.
Thanks.
Daniel Juyung Seo (SeoZ)
On Sun, Oct 23, 2011 at 12:51 PM, Enlightenment SVN
wrote:
Log:
annoy vim users with spaces at the start of blank lines. :)
Author: raster
Date: 2011-10-22 20:51:41 -0700 (Sat, 22 Oct 2011)
New Revision: 64317
Trac: http://trac.enlightenment.org/e/changeset/64317
Modified:
trunk/evas/src/lib/canvas/evas_async_events.c
Modified: trunk/evas/src/lib/canvas/evas_async_events.c
===
--- trunk/evas/src/lib/canvas/evas_async_events.c 2011-10-22 23:40:48
UTC (rev 64316) +++ trunk/evas/src/lib/canvas/evas_async_events.c
2011-10-23 03:51:41 UTC (rev 64317) @@ -3,11 +3,11 @@
#ifdef BUILD_ASYNC_EVENTS
-#ifndef _MSC_VER
-# include
-#endif
-#include
-#include
+# ifndef _MSC_VER
+# include
+# endif
+# include
+# include
static int _fd_write = -1;
static int _fd_read = -1;
@@ -28,21 +28,21 @@
evas_async_events_init(void)
{
int filedes[2];
-
+
_init_evas_event++;
if (_init_evas_event > 1) return _init_evas_event;
-
+
if (pipe(filedes) == -1)
{
_init_evas_event = 0;
return 0;
}
-
+
_fd_read = filedes[0];
_fd_write = filedes[1];
-
+
fcntl(_fd_read, F_SETFL, O_NONBLOCK);
-
+
return _init_evas_event;
}
@@ -51,12 +51,12 @@
{
_init_evas_event--;
if (_init_evas_event > 0) return _init_evas_event;
-
+
close(_fd_read);
close(_fd_write);
_fd_read = -1;
_fd_write = -1;
-
+
return _init_evas_event;
}
@@ -79,10 +79,10 @@
Evas_Event_Async *ev;
int check;
int count = 0;
-
+
if (_fd_read == -1) return 0;
-
- do
+
+ do
{
check = read(_fd_read, &ev, sizeof (Evas_Event_Async *));
@@ -92,11 +92,11 @@
free(ev);
count++;
}
- }
+ }
while (check > 0);
-
+
evas_cache_image_wakeup();
-
+
if (check < 0)
{
switch (errno)
@@ -108,7 +108,7 @@
_fd_read = -1;
}
}
-
+
return count;
#else
return 0;
@@ -122,27 +122,27 @@
Evas_Event_Async *ev;
ssize_t check;
Eina_Bool result = EINA_FALSE;
-
+
if (!func) return 0;
if (_fd_write == -1) return 0;
-
+
ev = calloc(1, sizeof (Evas_Event_Async));
if (!ev) return 0;
-
+
ev->func = func;
ev->target = target;
ev->type = type;
ev->event_info = event_info;
-
- do
+
+ do
{
check = write(_fd_write, &ev, sizeof (Evas_Event_Async*));
}
- while ((check != sizeof (Evas_Event_Async*)) &&
+ while ((check != sizeof (Evas_Event_Async*)) &&
((errno == EINTR) || (errno == EAGAIN)));
-
+
evas_cache_image_wakeup();
-
+
if (check == sizeof (Evas_Event_Async*))
result = EINA_TRUE;
else
@@ -156,7 +156,7 @@
_fd_write = -1;
}
}
-
+
return result;
#else
func(target, type, event_info);
--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
http://p.sf.net/sfu/cisco-dev2dev
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
http://p.sf.net/sfu/cisco-dev2dev
__
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Sun, 23 Oct 2011 15:41:25 +0900 Daniel Juyung Seo
said:
i see my test worked. the irrational formatting pedants now come out of the
woodwork. i did this to see just who would respond and how.
i added spaces on BLANK LINES that align with indenting. all it takes is an
enter or hitting tab. all editors do this by default (with autoindent on).
are these pedants (like you and vincent) proposing that we fight against our
editors and keep undoing the work they do for us? i assume the answer is yes
because this whole thing is irrational.
> Well... This is my personal opinion about this commit.
> This is so disappointing and childish as a grown-up person.
>
> I didn't set that vim configuration before I was requested to remove
> trailing whitespaces from enlightenment community.
> Now e-founder encourages trailing whitespaces.
> Seriously that's so funny.
>
> Anyhow, I have no objection to you doing this funny behavior because
> it looks like trailing whitespace is now allowed in enlightenment.
>
> Thanks.
>
> Daniel Juyung Seo (SeoZ)
>
> On Sun, Oct 23, 2011 at 12:51 PM, Enlightenment SVN
> wrote:
> > Log:
> > annoy vim users with spaces at the start of blank lines. :)
> >
> >
> >
> > Author: raster
> > Date: 2011-10-22 20:51:41 -0700 (Sat, 22 Oct 2011)
> > New Revision: 64317
> > Trac: http://trac.enlightenment.org/e/changeset/64317
> >
> > Modified:
> > trunk/evas/src/lib/canvas/evas_async_events.c
> >
> > Modified: trunk/evas/src/lib/canvas/evas_async_events.c
> > ===
> > --- trunk/evas/src/lib/canvas/evas_async_events.c 2011-10-22 23:40:48
> > UTC (rev 64316) +++ trunk/evas/src/lib/canvas/evas_async_events.c
> > 2011-10-23 03:51:41 UTC (rev 64317) @@ -3,11 +3,11 @@
> >
> > #ifdef BUILD_ASYNC_EVENTS
> >
> > -#ifndef _MSC_VER
> > -# include
> > -#endif
> > -#include
> > -#include
> > +# ifndef _MSC_VER
> > +# include
> > +# endif
> > +# include
> > +# include
> >
> > static int _fd_write = -1;
> > static int _fd_read = -1;
> > @@ -28,21 +28,21 @@
> > evas_async_events_init(void)
> > {
> > int filedes[2];
> > -
> > +
> > _init_evas_event++;
> > if (_init_evas_event > 1) return _init_evas_event;
> > -
> > +
> > if (pipe(filedes) == -1)
> > {
> > _init_evas_event = 0;
> > return 0;
> > }
> > -
> > +
> > _fd_read = filedes[0];
> > _fd_write = filedes[1];
> > -
> > +
> > fcntl(_fd_read, F_SETFL, O_NONBLOCK);
> > -
> > +
> > return _init_evas_event;
> > }
> >
> > @@ -51,12 +51,12 @@
> > {
> > _init_evas_event--;
> > if (_init_evas_event > 0) return _init_evas_event;
> > -
> > +
> > close(_fd_read);
> > close(_fd_write);
> > _fd_read = -1;
> > _fd_write = -1;
> > -
> > +
> > return _init_evas_event;
> > }
> >
> > @@ -79,10 +79,10 @@
> > Evas_Event_Async *ev;
> > int check;
> > int count = 0;
> > -
> > +
> > if (_fd_read == -1) return 0;
> > -
> > - do
> > +
> > + do
> > {
> > check = read(_fd_read, &ev, sizeof (Evas_Event_Async *));
> >
> > @@ -92,11 +92,11 @@
> > free(ev);
> > count++;
> > }
> > - }
> > + }
> > while (check > 0);
> > -
> > +
> > evas_cache_image_wakeup();
> > -
> > +
> > if (check < 0)
> > {
> > switch (errno)
> > @@ -108,7 +108,7 @@
> > _fd_read = -1;
> > }
> > }
> > -
> > +
> > return count;
> > #else
> > return 0;
> > @@ -122,27 +122,27 @@
> > Evas_Event_Async *ev;
> > ssize_t check;
> > Eina_Bool result = EINA_FALSE;
> > -
> > +
> > if (!func) return 0;
> > if (_fd_write == -1) return 0;
> > -
> > +
> > ev = calloc(1, sizeof (Evas_Event_Async));
> > if (!ev) return 0;
> > -
> > +
> > ev->func = func;
> > ev->target = target;
> > ev->type = type;
> > ev->event_info = event_info;
> > -
> > - do
> > +
> > + do
> > {
> > check = write(_fd_write, &ev, sizeof (Evas_Event_Async*));
> > }
> > - while ((check != sizeof (Evas_Event_Async*)) &&
> > + while ((check != sizeof (Evas_Event_Async*)) &&
> > ((errno == EINTR) || (errno == EAGAIN)));
> > -
> > +
> > evas_cache_image_wakeup();
> > -
> > +
> > if (check == sizeof (Evas_Event_Async*))
> > result = EINA_TRUE;
> > else
> > @@ -156,7 +156,7 @@
> > _fd_write = -1;
> > }
> > }
> > -
> > +
> > return result;
> > #else
> > func(target, type, event_info);
> >
> >
> > --
> > The demand for IT networking professionals continues to grow, and the
> > demand for specialized networking skills is growing even more rapidly.
> > Take a complimentary Learning@Cisco Self-Assessment and learn
> > about Cisco certifications, training, and career opportunities.
> > http://p.sf.net/sfu/cisco-dev2dev
> > ___
> > enlightenment-svn
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Sun, 23 Oct 2011, Daniel Juyung Seo wrote:
Well... This is my personal opinion about this commit.
This is so disappointing and childish as a grown-up person.
I didn't set that vim configuration before I was requested to remove
trailing whitespaces from enlightenment community.
Now e-founder encourages trailing whitespaces.
Seriously that's so funny.
Anyhow, I have no objection to you doing this funny behavior because
it looks like trailing whitespace is now allowed in enlightenment.
hell no, i'm against those trailing whitespaces too, the only one who
does not care is raster. Most all other devs remove them.
Vincent
Thanks.
Daniel Juyung Seo (SeoZ)
On Sun, Oct 23, 2011 at 12:51 PM, Enlightenment SVN
wrote:
Log:
annoy vim users with spaces at the start of blank lines. :)
Author: raster
Date: 2011-10-22 20:51:41 -0700 (Sat, 22 Oct 2011)
New Revision: 64317
Trac: http://trac.enlightenment.org/e/changeset/64317
Modified:
trunk/evas/src/lib/canvas/evas_async_events.c
Modified: trunk/evas/src/lib/canvas/evas_async_events.c
===
--- trunk/evas/src/lib/canvas/evas_async_events.c 2011-10-22 23:40:48 UTC
(rev 64316)
+++ trunk/evas/src/lib/canvas/evas_async_events.c 2011-10-23 03:51:41 UTC
(rev 64317)
@@ -3,11 +3,11 @@
#ifdef BUILD_ASYNC_EVENTS
-#ifndef _MSC_VER
-# include
-#endif
-#include
-#include
+# ifndef _MSC_VER
+# include
+# endif
+# include
+# include
static int _fd_write = -1;
static int _fd_read = -1;
@@ -28,21 +28,21 @@
evas_async_events_init(void)
{
int filedes[2];
-
+
_init_evas_event++;
if (_init_evas_event > 1) return _init_evas_event;
-
+
if (pipe(filedes) == -1)
{
_init_evas_event = 0;
return 0;
}
-
+
_fd_read = filedes[0];
_fd_write = filedes[1];
-
+
fcntl(_fd_read, F_SETFL, O_NONBLOCK);
-
+
return _init_evas_event;
}
@@ -51,12 +51,12 @@
{
_init_evas_event--;
if (_init_evas_event > 0) return _init_evas_event;
-
+
close(_fd_read);
close(_fd_write);
_fd_read = -1;
_fd_write = -1;
-
+
return _init_evas_event;
}
@@ -79,10 +79,10 @@
Evas_Event_Async *ev;
int check;
int count = 0;
-
+
if (_fd_read == -1) return 0;
-
- do
+
+ do
{
check = read(_fd_read, &ev, sizeof (Evas_Event_Async *));
@@ -92,11 +92,11 @@
free(ev);
count++;
}
- }
+ }
while (check > 0);
-
+
evas_cache_image_wakeup();
-
+
if (check < 0)
{
switch (errno)
@@ -108,7 +108,7 @@
_fd_read = -1;
}
}
-
+
return count;
#else
return 0;
@@ -122,27 +122,27 @@
Evas_Event_Async *ev;
ssize_t check;
Eina_Bool result = EINA_FALSE;
-
+
if (!func) return 0;
if (_fd_write == -1) return 0;
-
+
ev = calloc(1, sizeof (Evas_Event_Async));
if (!ev) return 0;
-
+
ev->func = func;
ev->target = target;
ev->type = type;
ev->event_info = event_info;
-
- do
+
+ do
{
check = write(_fd_write, &ev, sizeof (Evas_Event_Async*));
}
- while ((check != sizeof (Evas_Event_Async*)) &&
+ while ((check != sizeof (Evas_Event_Async*)) &&
((errno == EINTR) || (errno == EAGAIN)));
-
+
evas_cache_image_wakeup();
-
+
if (check == sizeof (Evas_Event_Async*))
result = EINA_TRUE;
else
@@ -156,7 +156,7 @@
_fd_write = -1;
}
}
-
+
return result;
#else
func(target, type, event_info);
--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
http://p.sf.net/sfu/cisco-dev2dev
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
http://p.sf.net/sfu/cisco-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
htt
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
Well... This is my personal opinion about this commit.
This is so disappointing and childish as a grown-up person.
I didn't set that vim configuration before I was requested to remove
trailing whitespaces from enlightenment community.
Now e-founder encourages trailing whitespaces.
Seriously that's so funny.
Anyhow, I have no objection to you doing this funny behavior because
it looks like trailing whitespace is now allowed in enlightenment.
Thanks.
Daniel Juyung Seo (SeoZ)
On Sun, Oct 23, 2011 at 12:51 PM, Enlightenment SVN
wrote:
> Log:
> annoy vim users with spaces at the start of blank lines. :)
>
>
>
> Author: raster
> Date: 2011-10-22 20:51:41 -0700 (Sat, 22 Oct 2011)
> New Revision: 64317
> Trac: http://trac.enlightenment.org/e/changeset/64317
>
> Modified:
> trunk/evas/src/lib/canvas/evas_async_events.c
>
> Modified: trunk/evas/src/lib/canvas/evas_async_events.c
> ===
> --- trunk/evas/src/lib/canvas/evas_async_events.c 2011-10-22 23:40:48
> UTC (rev 64316)
> +++ trunk/evas/src/lib/canvas/evas_async_events.c 2011-10-23 03:51:41
> UTC (rev 64317)
> @@ -3,11 +3,11 @@
>
> #ifdef BUILD_ASYNC_EVENTS
>
> -#ifndef _MSC_VER
> -# include
> -#endif
> -#include
> -#include
> +# ifndef _MSC_VER
> +# include
> +# endif
> +# include
> +# include
>
> static int _fd_write = -1;
> static int _fd_read = -1;
> @@ -28,21 +28,21 @@
> evas_async_events_init(void)
> {
> int filedes[2];
> -
> +
> _init_evas_event++;
> if (_init_evas_event > 1) return _init_evas_event;
> -
> +
> if (pipe(filedes) == -1)
> {
> _init_evas_event = 0;
> return 0;
> }
> -
> +
> _fd_read = filedes[0];
> _fd_write = filedes[1];
> -
> +
> fcntl(_fd_read, F_SETFL, O_NONBLOCK);
> -
> +
> return _init_evas_event;
> }
>
> @@ -51,12 +51,12 @@
> {
> _init_evas_event--;
> if (_init_evas_event > 0) return _init_evas_event;
> -
> +
> close(_fd_read);
> close(_fd_write);
> _fd_read = -1;
> _fd_write = -1;
> -
> +
> return _init_evas_event;
> }
>
> @@ -79,10 +79,10 @@
> Evas_Event_Async *ev;
> int check;
> int count = 0;
> -
> +
> if (_fd_read == -1) return 0;
> -
> - do
> +
> + do
> {
> check = read(_fd_read, &ev, sizeof (Evas_Event_Async *));
>
> @@ -92,11 +92,11 @@
> free(ev);
> count++;
> }
> - }
> + }
> while (check > 0);
> -
> +
> evas_cache_image_wakeup();
> -
> +
> if (check < 0)
> {
> switch (errno)
> @@ -108,7 +108,7 @@
> _fd_read = -1;
> }
> }
> -
> +
> return count;
> #else
> return 0;
> @@ -122,27 +122,27 @@
> Evas_Event_Async *ev;
> ssize_t check;
> Eina_Bool result = EINA_FALSE;
> -
> +
> if (!func) return 0;
> if (_fd_write == -1) return 0;
> -
> +
> ev = calloc(1, sizeof (Evas_Event_Async));
> if (!ev) return 0;
> -
> +
> ev->func = func;
> ev->target = target;
> ev->type = type;
> ev->event_info = event_info;
> -
> - do
> +
> + do
> {
> check = write(_fd_write, &ev, sizeof (Evas_Event_Async*));
> }
> - while ((check != sizeof (Evas_Event_Async*)) &&
> + while ((check != sizeof (Evas_Event_Async*)) &&
> ((errno == EINTR) || (errno == EAGAIN)));
> -
> +
> evas_cache_image_wakeup();
> -
> +
> if (check == sizeof (Evas_Event_Async*))
> result = EINA_TRUE;
> else
> @@ -156,7 +156,7 @@
> _fd_write = -1;
> }
> }
> -
> +
> return result;
> #else
> func(target, type, event_info);
>
>
> --
> The demand for IT networking professionals continues to grow, and the
> demand for specialized networking skills is growing even more rapidly.
> Take a complimentary Learning@Cisco Self-Assessment and learn
> about Cisco certifications, training, and career opportunities.
> http://p.sf.net/sfu/cisco-dev2dev
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
http://p.sf.net/sfu/cisco-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Sat, 22 Oct 2011 00:47:33 +0900 Daniel Juyung Seo
said:
> Spank spank raster!
> This introduces trailing whitespaces.
turn off your annoyance mode in your editor. fyi if u mean trailing white
spaces at the START of blank lines - thats actually HOW many editors work on
autoindent... because they are EXPECTING you to write some code there. it's
perfectly logical and all you are doing is bitching about something that is
actually a good thing because you insist on having an hyper-annoying editor
feature on.
> Daniel Juyung Seo (SeoZ)
>
> On Fri, Oct 21, 2011 at 2:50 PM, Enlightenment SVN
> wrote:
> > Log:
> > nicer formatting of async events
> >
> >
> >
> > Author: raster
> > Date: 2011-10-20 22:50:05 -0700 (Thu, 20 Oct 2011)
> > New Revision: 64240
> > Trac: http://trac.enlightenment.org/e/changeset/64240
> >
> > Modified:
> > trunk/evas/src/lib/canvas/evas_async_events.c
> >
> > Modified: trunk/evas/src/lib/canvas/evas_async_events.c
> > ===
> > --- trunk/evas/src/lib/canvas/evas_async_events.c 2011-10-21 05:40:59
> > UTC (rev 64239) +++ trunk/evas/src/lib/canvas/evas_async_events.c
> > 2011-10-21 05:50:05 UTC (rev 64240) @@ -82,28 +82,32 @@
> >
> > if (_fd_read == -1) return 0;
> >
> > - do {
> > + do
> > + {
> > check = read(_fd_read, &ev, sizeof (Evas_Event_Async *));
> > -
> > +
> > if (check == sizeof (Evas_Event_Async *))
> > {
> > if (ev->func) ev->func((void *)ev->target, ev->type,
> > ev->event_info); free(ev);
> > count++;
> > }
> > - } while (check > 0);
> > + }
> > + while (check > 0);
> >
> > evas_cache_image_wakeup();
> >
> > if (check < 0)
> > - switch (errno)
> > - {
> > - case EBADF:
> > - case EINVAL:
> > - case EIO:
> > - case EISDIR:
> > - _fd_read = -1;
> > - }
> > + {
> > + switch (errno)
> > + {
> > + case EBADF:
> > + case EINVAL:
> > + case EIO:
> > + case EISDIR:
> > + _fd_read = -1;
> > + }
> > + }
> >
> > return count;
> > #else
> > @@ -130,23 +134,28 @@
> > ev->type = type;
> > ev->event_info = event_info;
> >
> > - do {
> > - check = write(_fd_write, &ev, sizeof (Evas_Event_Async*));
> > - } while ((check != sizeof (Evas_Event_Async*)) && ((errno == EINTR) ||
> > (errno == EAGAIN)));
> > + do
> > + {
> > + check = write(_fd_write, &ev, sizeof (Evas_Event_Async*));
> > + }
> > + while ((check != sizeof (Evas_Event_Async*)) &&
> > + ((errno == EINTR) || (errno == EAGAIN)));
> >
> > evas_cache_image_wakeup();
> >
> > if (check == sizeof (Evas_Event_Async*))
> > result = EINA_TRUE;
> > else
> > - switch (errno)
> > - {
> > - case EBADF:
> > - case EINVAL:
> > - case EIO:
> > - case EPIPE:
> > - _fd_write = -1;
> > - }
> > + {
> > + switch (errno)
> > + {
> > + case EBADF:
> > + case EINVAL:
> > + case EIO:
> > + case EPIPE:
> > + _fd_write = -1;
> > + }
> > + }
> >
> > return result;
> > #else
> >
> >
> > --
> > The demand for IT networking professionals continues to grow, and the
> > demand for specialized networking skills is growing even more rapidly.
> > Take a complimentary Learning@Cisco Self-Assessment and learn
> > about Cisco certifications, training, and career opportunities.
> > http://p.sf.net/sfu/cisco-dev2dev
> > ___
> > enlightenment-svn mailing list
> > enlightenment-...@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
> >
>
> --
> The demand for IT networking professionals continues to grow, and the
> demand for specialized networking skills is growing even more rapidly.
> Take a complimentary Learning@Cisco Self-Assessment and learn
> about Cisco certifications, training, and career opportunities.
> http://p.sf.net/sfu/cisco-dev2dev
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com
--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
http://p.sf.net/sfu
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
Spank spank raster!
This introduces trailing whitespaces.
Daniel Juyung Seo (SeoZ)
On Fri, Oct 21, 2011 at 2:50 PM, Enlightenment SVN
wrote:
> Log:
> nicer formatting of async events
>
>
>
> Author: raster
> Date: 2011-10-20 22:50:05 -0700 (Thu, 20 Oct 2011)
> New Revision: 64240
> Trac: http://trac.enlightenment.org/e/changeset/64240
>
> Modified:
> trunk/evas/src/lib/canvas/evas_async_events.c
>
> Modified: trunk/evas/src/lib/canvas/evas_async_events.c
> ===
> --- trunk/evas/src/lib/canvas/evas_async_events.c 2011-10-21 05:40:59
> UTC (rev 64239)
> +++ trunk/evas/src/lib/canvas/evas_async_events.c 2011-10-21 05:50:05
> UTC (rev 64240)
> @@ -82,28 +82,32 @@
>
> if (_fd_read == -1) return 0;
>
> - do {
> + do
> + {
> check = read(_fd_read, &ev, sizeof (Evas_Event_Async *));
> -
> +
> if (check == sizeof (Evas_Event_Async *))
> {
> if (ev->func) ev->func((void *)ev->target, ev->type,
> ev->event_info);
> free(ev);
> count++;
> }
> - } while (check > 0);
> + }
> + while (check > 0);
>
> evas_cache_image_wakeup();
>
> if (check < 0)
> - switch (errno)
> - {
> - case EBADF:
> - case EINVAL:
> - case EIO:
> - case EISDIR:
> - _fd_read = -1;
> - }
> + {
> + switch (errno)
> + {
> + case EBADF:
> + case EINVAL:
> + case EIO:
> + case EISDIR:
> + _fd_read = -1;
> + }
> + }
>
> return count;
> #else
> @@ -130,23 +134,28 @@
> ev->type = type;
> ev->event_info = event_info;
>
> - do {
> - check = write(_fd_write, &ev, sizeof (Evas_Event_Async*));
> - } while ((check != sizeof (Evas_Event_Async*)) && ((errno == EINTR) ||
> (errno == EAGAIN)));
> + do
> + {
> + check = write(_fd_write, &ev, sizeof (Evas_Event_Async*));
> + }
> + while ((check != sizeof (Evas_Event_Async*)) &&
> + ((errno == EINTR) || (errno == EAGAIN)));
>
> evas_cache_image_wakeup();
>
> if (check == sizeof (Evas_Event_Async*))
> result = EINA_TRUE;
> else
> - switch (errno)
> - {
> - case EBADF:
> - case EINVAL:
> - case EIO:
> - case EPIPE:
> - _fd_write = -1;
> - }
> + {
> + switch (errno)
> + {
> + case EBADF:
> + case EINVAL:
> + case EIO:
> + case EPIPE:
> + _fd_write = -1;
> + }
> + }
>
> return result;
> #else
>
>
> --
> The demand for IT networking professionals continues to grow, and the
> demand for specialized networking skills is growing even more rapidly.
> Take a complimentary Learning@Cisco Self-Assessment and learn
> about Cisco certifications, training, and career opportunities.
> http://p.sf.net/sfu/cisco-dev2dev
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
http://p.sf.net/sfu/cisco-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Fri, 21 Oct 2011 12:34:05 +0200 Cedric BAIL said: > On Fri, Oct 21, 2011 at 12:00 PM, Enlightenment SVN > wrote: > > Log: > > and disable invalidate optimization > > > > > > > > Author: raster > > Date: 2011-10-21 03:00:03 -0700 (Fri, 21 Oct 2011) > > New Revision: 64249 > > Trac: http://trac.enlightenment.org/e/changeset/64249 > > > > Modified: > > trunk/evas/src/lib/canvas/evas_render.c > > > > Modified: trunk/evas/src/lib/canvas/evas_render.c > > === > > --- trunk/evas/src/lib/canvas/evas_render.c 2011-10-21 09:59:13 UTC > > (rev 64248) +++ trunk/evas/src/lib/canvas/evas_render.c 2011-10-21 > > 10:00:03 UTC (rev 64249) @@ -1295,7 +1295,7 @@ > > _evas_render_check_pending_objects(&e->pending_objects, e); > > > > /* phase 1. add extra updates for changed objects */ > > - if (e->invalidate || e->render_objects.count <= 0) > > +/* if (e->invalidate || e->render_objects.count <= 0)*/ > > clean_them = _evas_render_phase1_process(e, > > &e->active_objects, > > &e->restack_objects, > > This optimisation does really impact performance on low end hardware > when they are not using evas map. Could you tell me what was the issue > ? How to reproduce it ? So I can bring this optimisation back in problem is actually this: object a changes. object b is a big solid object covering obj a entirely. b does NOT change. now we render. we SHOULD reduce this to a nop. but we dont. we are rendering the change region even though its obscured. it's a bug. i reverted this already as i thought this was the quick fix. it did - but it created new bugs. i fixed it elsewhere, but now there is yet another corner case it doesnt detect and i don't know why. -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Fri, Oct 21, 2011 at 12:00 PM, Enlightenment SVN wrote: > Log: > and disable invalidate optimization > > > > Author: raster > Date: 2011-10-21 03:00:03 -0700 (Fri, 21 Oct 2011) > New Revision: 64249 > Trac: http://trac.enlightenment.org/e/changeset/64249 > > Modified: > trunk/evas/src/lib/canvas/evas_render.c > > Modified: trunk/evas/src/lib/canvas/evas_render.c > === > --- trunk/evas/src/lib/canvas/evas_render.c 2011-10-21 09:59:13 UTC (rev > 64248) > +++ trunk/evas/src/lib/canvas/evas_render.c 2011-10-21 10:00:03 UTC (rev > 64249) > @@ -1295,7 +1295,7 @@ > _evas_render_check_pending_objects(&e->pending_objects, e); > > /* phase 1. add extra updates for changed objects */ > - if (e->invalidate || e->render_objects.count <= 0) > +/* if (e->invalidate || e->render_objects.count <= 0)*/ > clean_them = _evas_render_phase1_process(e, > &e->active_objects, > &e->restack_objects, This optimisation does really impact performance on low end hardware when they are not using evas map. Could you tell me what was the issue ? How to reproduce it ? So I can bring this optimisation back in. Thanks -- Cedric BAIL -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
2011/10/11 Vincent Torri : > > > On Tue, 11 Oct 2011, Vincent Torri wrote: > >>> >>> correct. in some cases where 15.9 cannot in fp be represented as >>> a value >= 16.0, this it gets slightly rounded down, and thus ends up being >>> 15 >>> when dropped down to an integer. that is the whole crux of the problem. >> >> the almost all the code using ceil() and floor() is broken, as the result >> of these functions is almost always casted to an int... >> >>> so that means non-c99 platforms will have rendering bugs. there has to be a >>> better way. >> >> I don't know any. If someone has a clue... > > http://cgit.freedesktop.org/cairo/tree/src/cairo-misc.c#n487 :O voodoo math > > Vincent > > -- > All the data continuously generated in your IT infrastructure contains a > definitive record of customers, application performance, security > threats, fraudulent activity and more. Splunk takes this data and makes > sense of it. Business sense. IT sense. Common sense. > http://p.sf.net/sfu/splunk-d2d-oct > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2d-oct ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Tue, 11 Oct 2011, Vincent Torri wrote: >> >> correct. in some cases where 15.9 cannot in fp be represented as >> a value >= 16.0, this it gets slightly rounded down, and thus ends up being >> 15 >> when dropped down to an integer. that is the whole crux of the problem. > > the almost all the code using ceil() and floor() is broken, as the result > of these functions is almost always casted to an int... > >> so that means non-c99 platforms will have rendering bugs. there has to be a >> better way. > > I don't know any. If someone has a clue... http://cgit.freedesktop.org/cairo/tree/src/cairo-misc.c#n487 Vincent -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2d-oct ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Tue, 11 Oct 2011, Carsten Haitzler (The Rasterman) wrote: > On Tue, 11 Oct 2011 08:40:33 +0200 (CEST) Vincent Torri > said: > >> >> >> On Tue, 11 Oct 2011, Carsten Haitzler (The Rasterman) wrote: >> >>> On Tue, 11 Oct 2011 08:14:47 +0200 (CEST) Vincent Torri >>> said: >>> On Mon, 10 Oct 2011, Enlightenment SVN wrote: > Log: > use lround() for map coord rounding to avoid silly things like > 15.98 rounding down to 15... whihc leads to > sometimes... odd off-by-1 expected results. lround is C99 compliant and does not exist on Windows. why not using the macro #define round(x) (x<0?ceil((x)-0.5):floor((x)+0.5)) >>> >>> because 1. i dont have a manual page for what is NOT supported in windows's >>> dev envs (that's why we have you!). >> >> in google : "msdn the_function" >> >> Also, did you read the man page of lround ? > > i did. > > ... > long long int llroundl(long double x); > > Link with -lm. > > Feature Test Macro Requirements for glibc (see feature_test_macros(7)): > > All functions shown above: > _XOPEN_SOURCE >= 600 || _ISOC99_SOURCE || > _POSIX_C_SOURCE >= 200112L; > or cc -std=c99 > ... > CONFORMING TO > C99, POSIX.1-2001. > ... > > nothing in the manual page on ubuntu requires any special compile flags other > than -lm (as per usual) for linking. the manual differs from the one you quote > below. that manual is better than most of the manual I read. I also use the opengroup one too. > note that the manula i have seems more complete. as such the standard > for efl is c99 as an assumed base. I thought it was POSIX... > >> See >> >> http://linux.die.net/man/3/lround >> >> did you read the line "Compile with -std=c99" ? Is that flag passed to the >> compiler ? Note that i added an m4 macro that checks if a flags is >> supported by the compiler >> >> 2. floor and ceil return doubles, not >>> integers. lround returns a long int (long). >> >> so (long)ceil(15.999) does not return 16 ? > > correct. in some cases where 15.9 cannot in fp be represented as > a value >= 16.0, this it gets slightly rounded down, and thus ends up being 15 > when dropped down to an integer. that is the whole crux of the problem. the almost all the code using ceil() and floor() is broken, as the result of these functions is almost always casted to an int... > so that means non-c99 platforms will have rendering bugs. there has to be a > better way. I don't know any. If someone has a clue... Vincent > >> then >> >> #ifndef HAVE_LROUND >> # define lround >> #endif >> >> Vincent >> >> -- >> All the data continuously generated in your IT infrastructure contains a >> definitive record of customers, application performance, security >> threats, fraudulent activity and more. Splunk takes this data and makes >> sense of it. Business sense. IT sense. Common sense. >> http://p.sf.net/sfu/splunk-d2d-oct >> ___ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > > -- > - Codito, ergo sum - "I code, therefore I am" -- > The Rasterman (Carsten Haitzler)ras...@rasterman.com > > -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2d-oct ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Tue, 11 Oct 2011, Lucas De Marchi wrote: Hi Vincent, On Tue, Oct 11, 2011 at 3:40 AM, Vincent Torri wrote: On Tue, 11 Oct 2011, Carsten Haitzler (The Rasterman) wrote: On Tue, 11 Oct 2011 08:14:47 +0200 (CEST) Vincent Torri said: On Mon, 10 Oct 2011, Enlightenment SVN wrote: Log: use lround() for map coord rounding to avoid silly things like 15.98 rounding down to 15... whihc leads to sometimes... odd off-by-1 expected results. lround is C99 compliant and does not exist on Windows. why not using the macro #define round(x) (x<0?ceil((x)-0.5):floor((x)+0.5)) because 1. i dont have a manual page for what is NOT supported in windows's dev envs (that's why we have you!). in google : "msdn the_function" Also, did you read the man page of lround ? See http://linux.die.net/man/3/lround did you read the line "Compile with -std=c99" ? Is that flag passed to the compiler ? Note that i added an m4 macro that checks if a flags is supported by the compiler sigh... there's no support for C99 in windows? Hey, it's a 12 years old standard. Isn't evil supposed to cover these differences without staying in our way? I'm not saying it should already have "lround", but now it should be added, right? even if it's a 12 years old standard, most of compilers don't even implement it completely : http://gcc.gnu.org/c99status.html And it has already been said that vc++ aim is not to be C99 compliant. It's not one of the purpose of the vc++ developpers. Vincent-- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2d-oct___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Tue, 11 Oct 2011 08:40:33 +0200 (CEST) Vincent Torri said: > > > On Tue, 11 Oct 2011, Carsten Haitzler (The Rasterman) wrote: > > > On Tue, 11 Oct 2011 08:14:47 +0200 (CEST) Vincent Torri > > said: > > > >> > >> > >> On Mon, 10 Oct 2011, Enlightenment SVN wrote: > >> > >>> Log: > >>> use lround() for map coord rounding to avoid silly things like > >>> 15.98 rounding down to 15... whihc leads to > >>> sometimes... odd off-by-1 expected results. > >> > >> lround is C99 compliant and does not exist on Windows. > >> > >> why not using the macro > >> > >> #define round(x) (x<0?ceil((x)-0.5):floor((x)+0.5)) > > > > because 1. i dont have a manual page for what is NOT supported in windows's > > dev envs (that's why we have you!). > > in google : "msdn the_function" > > Also, did you read the man page of lround ? i did. ... long long int llroundl(long double x); Link with -lm. Feature Test Macro Requirements for glibc (see feature_test_macros(7)): All functions shown above: _XOPEN_SOURCE >= 600 || _ISOC99_SOURCE || _POSIX_C_SOURCE >= 200112L; or cc -std=c99 ... CONFORMING TO C99, POSIX.1-2001. ... nothing in the manual page on ubuntu requires any special compile flags other than -lm (as per usual) for linking. the manual differs from the one you quote below. note that the manula i have seems more complete. as such the standard for efl is c99 as an assumed base. > See > > http://linux.die.net/man/3/lround > > did you read the line "Compile with -std=c99" ? Is that flag passed to the > compiler ? Note that i added an m4 macro that checks if a flags is > supported by the compiler > > 2. floor and ceil return doubles, not > > integers. lround returns a long int (long). > > so (long)ceil(15.999) does not return 16 ? correct. in some cases where 15.9 cannot in fp be represented as a value >= 16.0, this it gets slightly rounded down, and thus ends up being 15 when dropped down to an integer. that is the whole crux of the problem. > > why not do it that way? less efficient than a single lround call. and > > technically incorrect. i'm literally trying to solve minuscule rounding > > issues here and returning a rounded double could still return an inaccurate > > (by a very tiny margin) double that will still get rounded the wrong way. : > > ( need a call that rounds and returns an integer type (int, long, etc.) not > > a double or float. > > The, at least, check the availability in configure.ac so that means non-c99 platforms will have rendering bugs. there has to be a better way. > then > > #ifndef HAVE_LROUND > # define lround > #endif > > Vincent > > -- > All the data continuously generated in your IT infrastructure contains a > definitive record of customers, application performance, security > threats, fraudulent activity and more. Splunk takes this data and makes > sense of it. Business sense. IT sense. Common sense. > http://p.sf.net/sfu/splunk-d2d-oct > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2d-oct ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
Hi Vincent, On Tue, Oct 11, 2011 at 3:40 AM, Vincent Torri wrote: > > > On Tue, 11 Oct 2011, Carsten Haitzler (The Rasterman) wrote: > > > On Tue, 11 Oct 2011 08:14:47 +0200 (CEST) Vincent Torri > > > > said: > > > >> > >> > >> On Mon, 10 Oct 2011, Enlightenment SVN wrote: > >> > >>> Log: > >>> use lround() for map coord rounding to avoid silly things like > >>> 15.98 rounding down to 15... whihc leads to > >>> sometimes... odd off-by-1 expected results. > >> > >> lround is C99 compliant and does not exist on Windows. > >> > >> why not using the macro > >> > >> #define round(x) (x<0?ceil((x)-0.5):floor((x)+0.5)) > > > > because 1. i dont have a manual page for what is NOT supported in windows's > > dev > > envs (that's why we have you!). > > in google : "msdn the_function" > > Also, did you read the man page of lround ? > > See > > http://linux.die.net/man/3/lround > > did you read the line "Compile with -std=c99" ? Is that flag passed to the > compiler ? Note that i added an m4 macro that checks if a flags is > supported by the compiler sigh... there's no support for C99 in windows? Hey, it's a 12 years old standard. Isn't evil supposed to cover these differences without staying in our way? I'm not saying it should already have "lround", but now it should be added, right? Lucas De Marchi -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2d-oct ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Tue, 11 Oct 2011, Carsten Haitzler (The Rasterman) wrote: > On Tue, 11 Oct 2011 08:14:47 +0200 (CEST) Vincent Torri > said: > >> >> >> On Mon, 10 Oct 2011, Enlightenment SVN wrote: >> >>> Log: >>> use lround() for map coord rounding to avoid silly things like >>> 15.98 rounding down to 15... whihc leads to >>> sometimes... odd off-by-1 expected results. >> >> lround is C99 compliant and does not exist on Windows. >> >> why not using the macro >> >> #define round(x) (x<0?ceil((x)-0.5):floor((x)+0.5)) > > because 1. i dont have a manual page for what is NOT supported in windows's > dev > envs (that's why we have you!). in google : "msdn the_function" Also, did you read the man page of lround ? See http://linux.die.net/man/3/lround did you read the line "Compile with -std=c99" ? Is that flag passed to the compiler ? Note that i added an m4 macro that checks if a flags is supported by the compiler 2. floor and ceil return doubles, not > integers. lround returns a long int (long). so (long)ceil(15.999) does not return 16 ? > why not do it that way? less efficient than a single lround call. and > technically incorrect. i'm literally trying to solve minuscule rounding issues > here and returning a rounded double could still return an inaccurate (by a > very > tiny margin) double that will still get rounded the wrong way. :( need a call > that rounds and returns an integer type (int, long, etc.) not a double or > float. The, at least, check the availability in configure.ac then #ifndef HAVE_LROUND # define lround #endif Vincent -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2d-oct ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Tue, 11 Oct 2011 08:14:47 +0200 (CEST) Vincent Torri
said:
>
>
> On Mon, 10 Oct 2011, Enlightenment SVN wrote:
>
> > Log:
> > use lround() for map coord rounding to avoid silly things like
> > 15.98 rounding down to 15... whihc leads to
> > sometimes... odd off-by-1 expected results.
>
> lround is C99 compliant and does not exist on Windows.
>
> why not using the macro
>
> #define round(x) (x<0?ceil((x)-0.5):floor((x)+0.5))
because 1. i dont have a manual page for what is NOT supported in windows's dev
envs (that's why we have you!). 2. floor and ceil return doubles, not
integers. lround returns a long int (long).
why not do it that way? less efficient than a single lround call. and
technically incorrect. i'm literally trying to solve minuscule rounding issues
here and returning a rounded double could still return an inaccurate (by a very
tiny margin) double that will still get rounded the wrong way. :( need a call
that rounds and returns an integer type (int, long, etc.) not a double or float.
> ?
>
> Vincent
>
> >
> >
> >
> > Author: raster
> > Date: 2011-10-10 23:06:11 -0700 (Mon, 10 Oct 2011)
> > New Revision: 63978
> > Trac: http://trac.enlightenment.org/e/changeset/63978
> >
> > Modified:
> > trunk/evas/src/lib/canvas/evas_map.c
> > trunk/evas/src/lib/canvas/evas_object_image.c
> > trunk/evas/src/lib/canvas/evas_render.c
> >
> > Modified: trunk/evas/src/lib/canvas/evas_map.c
> > ===
> > --- trunk/evas/src/lib/canvas/evas_map.c2011-10-11 05:12:06 UTC
> > (rev 63977) +++ trunk/evas/src/lib/canvas/evas_map.c2011-10-11
> > 06:06:11 UTC (rev 63978) @@ -81,10 +81,10 @@
> >
> >p = obj->cur.map->points;
> >p_end = p + obj->cur.map->count;
> > - x1 = p->x;
> > - x2 = p->x;
> > - y1 = p->y;
> > - y2 = p->y;
> > + x1 = lround(p->x);
> > + x2 = lround(p->x);
> > + y1 = lround(p->y);
> > + y2 = lround(p->y);
> >p++;
> >for (; p < p_end; p++)
> > {
> >
> > Modified: trunk/evas/src/lib/canvas/evas_object_image.c
> > ===
> > --- trunk/evas/src/lib/canvas/evas_object_image.c 2011-10-11
> > 05:12:06 UTC (rev 63977) +++
> > trunk/evas/src/lib/canvas/evas_object_image.c 2011-10-11 06:06:11
> > UTC (rev 63978) @@ -2,6 +2,7 @@
> > #include
> > #include
> > #include
> > +#include
> >
> > #include "evas_common.h"
> > #include "evas_private.h"
> > @@ -2887,14 +2888,14 @@
> > // draw geom +x +y
> > for (; p < p_end; p++, pt++)
> >{
> > - pt->x = (p->x + (double)x) * FP1;
> > - pt->y = (p->y + (double)y) * FP1;
> > - pt->z = (p->z) * FP1;
> > + pt->x = (lround(p->x) + x) * FP1;
> > + pt->y = (lround(p->y) + y) * FP1;
> > + pt->z = (lround(p->z)) * FP1;
> > pt->fx = p->px;
> > pt->fy = p->py;
> > pt->fz = p->z;
> > - pt->u = ((p->u * imagew) / uvw) * FP1;
> > - pt->v = ((p->v * imageh) / uvh) * FP1;
> > + pt->u = ((lround(p->u) * imagew) / uvw) * FP1;
> > + pt->v = ((lround(p->v) * imageh) / uvh) * FP1;
> > if (pt->u < 0) pt->u = 0;
> > else if (pt->u > (imagew * FP1)) pt->u = (imagew * FP1);
> > if (pt->v < 0) pt->v = 0;
> >
> > Modified: trunk/evas/src/lib/canvas/evas_render.c
> > ===
> > --- trunk/evas/src/lib/canvas/evas_render.c 2011-10-11 05:12:06 UTC
> > (rev 63977) +++ trunk/evas/src/lib/canvas/evas_render.c 2011-10-11
> > 06:06:11 UTC (rev 63978) @@ -1,5 +1,6 @@
> > #include "evas_common.h"
> > #include "evas_private.h"
> > +#include
> >
> > // debug rendering
> > /* #define REND_DGB 1 */
> > @@ -911,14 +912,14 @@
> > pt = pts;
> > for (; p < p_end; p++, pt++)
> > {
> > - pt->x = (p->x + (double)off_x) * FP1;
> > - pt->y = (p->y + (double)off_y) * FP1;
> > - pt->z = (p->z) * FP1;
> > + pt->x = (lround(p->x) + off_x) * FP1;
> > + pt->y = (lround(p->y) + off_y) * FP1;
> > + pt->z = (lround(p->z)) * FP1;
> > pt->fx = p->px;
> > pt->fy = p->py;
> > pt->fz = p->z;
> > - pt->u = p->u * FP1;
> > - pt->v = p->v * FP1;
> > + pt->u = lround(p->u) * FP1;
> > + pt->v = lround(p->v) * FP1;
> > if (pt->u < 0) pt->u = 0;
> > else if (pt->u > (sw * FP1)) pt->u = (sw * FP1);
> > if (pt->v < 0) pt->v = 0;
> >
> >
> > --
> > All the data continuously generated i
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Mon, 10 Oct 2011, Enlightenment SVN wrote:
> Log:
> use lround() for map coord rounding to avoid silly things like
> 15.98 rounding down to 15... whihc leads to
> sometimes... odd off-by-1 expected results.
lround is C99 compliant and does not exist on Windows.
why not using the macro
#define round(x) (x<0?ceil((x)-0.5):floor((x)+0.5))
?
Vincent
>
>
>
> Author: raster
> Date: 2011-10-10 23:06:11 -0700 (Mon, 10 Oct 2011)
> New Revision: 63978
> Trac: http://trac.enlightenment.org/e/changeset/63978
>
> Modified:
> trunk/evas/src/lib/canvas/evas_map.c
> trunk/evas/src/lib/canvas/evas_object_image.c
> trunk/evas/src/lib/canvas/evas_render.c
>
> Modified: trunk/evas/src/lib/canvas/evas_map.c
> ===
> --- trunk/evas/src/lib/canvas/evas_map.c 2011-10-11 05:12:06 UTC (rev
> 63977)
> +++ trunk/evas/src/lib/canvas/evas_map.c 2011-10-11 06:06:11 UTC (rev
> 63978)
> @@ -81,10 +81,10 @@
>
>p = obj->cur.map->points;
>p_end = p + obj->cur.map->count;
> - x1 = p->x;
> - x2 = p->x;
> - y1 = p->y;
> - y2 = p->y;
> + x1 = lround(p->x);
> + x2 = lround(p->x);
> + y1 = lround(p->y);
> + y2 = lround(p->y);
>p++;
>for (; p < p_end; p++)
> {
>
> Modified: trunk/evas/src/lib/canvas/evas_object_image.c
> ===
> --- trunk/evas/src/lib/canvas/evas_object_image.c 2011-10-11 05:12:06 UTC
> (rev 63977)
> +++ trunk/evas/src/lib/canvas/evas_object_image.c 2011-10-11 06:06:11 UTC
> (rev 63978)
> @@ -2,6 +2,7 @@
> #include
> #include
> #include
> +#include
>
> #include "evas_common.h"
> #include "evas_private.h"
> @@ -2887,14 +2888,14 @@
> // draw geom +x +y
> for (; p < p_end; p++, pt++)
>{
> - pt->x = (p->x + (double)x) * FP1;
> - pt->y = (p->y + (double)y) * FP1;
> - pt->z = (p->z) * FP1;
> + pt->x = (lround(p->x) + x) * FP1;
> + pt->y = (lround(p->y) + y) * FP1;
> + pt->z = (lround(p->z)) * FP1;
> pt->fx = p->px;
> pt->fy = p->py;
> pt->fz = p->z;
> - pt->u = ((p->u * imagew) / uvw) * FP1;
> - pt->v = ((p->v * imageh) / uvh) * FP1;
> + pt->u = ((lround(p->u) * imagew) / uvw) * FP1;
> + pt->v = ((lround(p->v) * imageh) / uvh) * FP1;
> if (pt->u < 0) pt->u = 0;
> else if (pt->u > (imagew * FP1)) pt->u = (imagew * FP1);
> if (pt->v < 0) pt->v = 0;
>
> Modified: trunk/evas/src/lib/canvas/evas_render.c
> ===
> --- trunk/evas/src/lib/canvas/evas_render.c 2011-10-11 05:12:06 UTC (rev
> 63977)
> +++ trunk/evas/src/lib/canvas/evas_render.c 2011-10-11 06:06:11 UTC (rev
> 63978)
> @@ -1,5 +1,6 @@
> #include "evas_common.h"
> #include "evas_private.h"
> +#include
>
> // debug rendering
> /* #define REND_DGB 1 */
> @@ -911,14 +912,14 @@
> pt = pts;
> for (; p < p_end; p++, pt++)
> {
> - pt->x = (p->x + (double)off_x) * FP1;
> - pt->y = (p->y + (double)off_y) * FP1;
> - pt->z = (p->z) * FP1;
> + pt->x = (lround(p->x) + off_x) * FP1;
> + pt->y = (lround(p->y) + off_y) * FP1;
> + pt->z = (lround(p->z)) * FP1;
> pt->fx = p->px;
> pt->fy = p->py;
> pt->fz = p->z;
> - pt->u = p->u * FP1;
> - pt->v = p->v * FP1;
> + pt->u = lround(p->u) * FP1;
> + pt->v = lround(p->v) * FP1;
> if (pt->u < 0) pt->u = 0;
> else if (pt->u > (sw * FP1)) pt->u = (sw * FP1);
> if (pt->v < 0) pt->v = 0;
>
>
> --
> All the data continuously generated in your IT infrastructure contains a
> definitive record of customers, application performance, security
> threats, fraudulent activity and more. Splunk takes this data and makes
> sense of it. Business sense. IT sense. Common sense.
> http://p.sf.net/sfu/splunk-d2d-oct
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
>
--
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2d-oct
___
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
Zero parameters before checking otherwise it will not touch them and
on failure caller will get garbage
--Gustavo
Sent from my iPhone
On 29/08/2011, at 08:40, Enlightenment SVN wrote:
> Log:
> dont need ti check priv - macro did it anyway
>
>
>
> Author: raster
> Date: 2011-08-29 04:39:43 -0700 (Mon, 29 Aug 2011)
> New Revision: 62941
> Trac: http://trac.enlightenment.org/e/changeset/62941
>
> Modified:
> trunk/evas/src/lib/canvas/evas_object_grid.c
>
> Modified: trunk/evas/src/lib/canvas/evas_object_grid.c
> ===
> --- trunk/evas/src/lib/canvas/evas_object_grid.c2011-08-29 11:28:43 UTC
> (rev 62940)
> +++ trunk/evas/src/lib/canvas/evas_object_grid.c2011-08-29 11:39:43 UTC
> (rev 62941)
> @@ -267,16 +267,8 @@
> evas_object_grid_size_get(const Evas_Object *o, int *w, int *h)
> {
>EVAS_OBJECT_GRID_DATA_GET_OR_RETURN(o, priv);
> - if (priv)
> - {
> -if (w) *w = priv->size.w;
> -if (h) *h = priv->size.h;
> - }
> - else
> - {
> -if (w) *w = 0;
> -if (h) *h = 0;
> - }
> + if (w) *w = priv->size.w;
> + if (h) *h = priv->size.h;
> }
>
> EAPI Eina_Bool
>
>
> --
> EMC VNX: the world's simplest storage, starting under $10K
> The only unified storage solution that offers unified management
> Up to 160% more powerful than alternatives and 25% more efficient.
> Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
EMC VNX: the world's simplest storage, starting under $10K
The only unified storage solution that offers unified management
Up to 160% more powerful than alternatives and 25% more efficient.
Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On 08/08/11 17:45, Vincent Torri wrote: > is it really 'start' and not 'tmp' that should be usedd in > FcPatternAddString() ? Nice catch, fixed. -- Tom. -- BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA The must-attend event for mobile developers. Connect with experts. Get tools for creating Super Apps. See the latest technologies. Sessions, hands-on labs, demos & much more. Register early & save! http://p.sf.net/sfu/rim-blackberry-1 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Mon, 8 Aug 2011, Enlightenment SVN wrote:
> Log:
> strndup--!
>
>
>
> Author: raster
> Date: 2011-08-08 07:40:33 -0700 (Mon, 08 Aug 2011)
> New Revision: 62206
> Trac: http://trac.enlightenment.org/e/changeset/62206
>
> Modified:
> trunk/evas/src/lib/canvas/evas_font_dir.c
>
> Modified: trunk/evas/src/lib/canvas/evas_font_dir.c
> ===
> --- trunk/evas/src/lib/canvas/evas_font_dir.c 2011-08-08 14:36:02 UTC (rev
> 62205)
> +++ trunk/evas/src/lib/canvas/evas_font_dir.c 2011-08-08 14:40:33 UTC (rev
> 62206)
> @@ -715,10 +715,10 @@
> end = strchr(start, ',');
> if (end)
> {
> - char *tmp;
> - tmp = strndup(start, end - start);
> + char *tmp = alloca((end - start) + 1);
> + strncpy(tmp, start, end - start);
> + tmp[end - start] = 0;
>FcPatternAddString (p_nm, FC_FAMILY, (FcChar8*) start);
is it really 'start' and not 'tmp' that should be usedd in
FcPatternAddString() ?
Vincent
> - free(tmp);
> }
> else
> {
>
>
> --
> BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA
> The must-attend event for mobile developers. Connect with experts.
> Get tools for creating Super Apps. See the latest technologies.
> Sessions, hands-on labs, demos & much more. Register early & save!
> http://p.sf.net/sfu/rim-blackberry-1
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
>
--
BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA
The must-attend event for mobile developers. Connect with experts.
Get tools for creating Super Apps. See the latest technologies.
Sessions, hands-on labs, demos & much more. Register early & save!
http://p.sf.net/sfu/rim-blackberry-1
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
On Tue, 2011-04-19 at 18:22 -0700, Enlightenment SVN wrote: > Log: > oh dear... way too many warnings. added a whole bunch of fixme's too > for later. I'll sort out the fixme's shortly. Just to be clear; the warnings are mostly unused params? Because it compiles cleanly for me[1], and my flags are -Wall and -Wextra. However I do set -Wno-sign-compare[2], and -Wno-unused-paramater Regards, nash [1] I checked, multiple times. [2] I do this because of otherwise enums nearly always give you the stupid unsigned vs signed comparison, and C gives you no portable way of avoiding it[3]. [3] The cast both sides isn't portable in the general case. -- Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
Go Sachiel :)
dh
Enlightenment SVN wrote:
> Log:
> another sachiel fix! :)
>
>
> Author: raster
> Date: 2008-10-28 20:29:10 -0700 (Tue, 28 Oct 2008)
> New Revision: 37292
>
> Modified:
> trunk/evas/src/lib/canvas/evas_object_textblock.c
>
> Modified: trunk/evas/src/lib/canvas/evas_object_textblock.c
> ===
> --- trunk/evas/src/lib/canvas/evas_object_textblock.c 2008-10-29 01:51:45 UTC
> (rev 37291)
> +++ trunk/evas/src/lib/canvas/evas_object_textblock.c 2008-10-29 03:29:10 UTC
> (rev 37292)
> @@ -1788,12 +1788,16 @@
>
> if ((repch) && (n->text))
> {
> - int i, len = strlen(n->text), chlen;
> + int i = 0, len = 0, chlen;
> + char *ptr;
>
> + while (evas_common_font_utf8_get_next(n->text, &i))
> + len++;
> chlen = strlen(repch);
> str = alloca((len * chlen) + 1);
> - for (i = 0; i < len; i += chlen)
> - strcpy(&(str[i]), repch);
> + for (i = 0, ptr = str; i < len; ptr += chlen, i++)
> + memcpy(ptr, repch, chlen);
> + *ptr = 0;
> }
> else
> str = n->text;
>
>
> -
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> ___
> enlightenment-svn mailing list
> [EMAIL PROTECTED]
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
I would Agreetho are those in the past that say we have done just
that.
Isn't that what we do...duplicate code ? :P.well after a while
doesn't that code become better??
Long Live E
dh (cpm)
Enlightenment SVN wrote:
> Log:
> dont repeat code
>
>
> Author: raster
> Date: 2008-10-26 20:12:59 -0700 (Sun, 26 Oct 2008)
> New Revision: 37191
>
> Modified:
> trunk/evas/src/lib/canvas/evas_object_textblock.c
>
> Modified: trunk/evas/src/lib/canvas/evas_object_textblock.c
> ===
> --- trunk/evas/src/lib/canvas/evas_object_textblock.c 2008-10-27 03:03:59 UTC
> (rev 37190)
> +++ trunk/evas/src/lib/canvas/evas_object_textblock.c 2008-10-27 03:12:59 UTC
> (rev 37191)
> @@ -2682,22 +2682,11 @@
> _prepend_escaped_char(Evas_Textblock_Cursor *cur, const char *s,
>const char *s_end)
> {
> - const char *map_itr, *map_end;
> -
> - map_itr = escape_strings;
> - map_end = map_itr + sizeof(escape_strings);
> -
> - while (map_itr < map_end)
> - {
> - if (_is_eq_and_advance(s, s_end, &map_itr, map_end))
> - {
> - evas_textblock_cursor_text_prepend(cur, map_itr);
> - return;
> - }
> -
> - if (map_itr < map_end)
> - _advance_after_end_of_string(&map_itr);
> - }
> + const char *escape;
> +
> + escape = _escaped_char_get(s, s_end);
> + if (escape)
> + evas_textblock_cursor_text_prepend(cur, escape);
> }
>
> /**
>
>
> -
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> ___
> enlightenment-svn mailing list
> [EMAIL PROTECTED]
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/evas/src/lib/canvas
fp...better for a scale...more precision
dh
[EMAIL PROTECTED] wrote:
> Author: raster
> Date: 2008-09-09 23:40:54 -0700 (Tue, 09 Sep 2008)
> New Revision: 35924
>
> Modified:
> trunk/evas/src/lib/canvas/evas_object_text.c
> trunk/evas/src/lib/canvas/evas_object_textblock.c
> Log:
>
> ensure scaling multiplies are promoted to fp.
>
>
>
> Modified: trunk/evas/src/lib/canvas/evas_object_text.c
> ===
> --- trunk/evas/src/lib/canvas/evas_object_text.c 2008-09-10 06:40:24 UTC
> (rev 35923)
> +++ trunk/evas/src/lib/canvas/evas_object_text.c 2008-09-10 06:40:54 UTC
> (rev 35924)
> @@ -191,7 +191,6 @@
> evas_font_free(obj->layer->evas, o->engine_data);
> o->engine_data = NULL;
> }
> - o->engine_data = evas_font_load(obj->layer->evas, font, o->cur.source,
> (int)(((double)size) * obj->cur.scale));
> if (!same_font)
> {
> if (o->cur.font) evas_stringshare_del(o->cur.font);
> @@ -200,6 +199,8 @@
> o->prev.font = NULL;
> }
> o->cur.size = size;
> + o->engine_data = evas_font_load(obj->layer->evas, o->cur.font,
> o->cur.source,
> +(int)(((double)o->cur.size) *
> obj->cur.scale));
> evas_text_style_pad_get(o->cur.style, &l, &r, &t, &b);
> if ((o->engine_data) && (o->cur.text))
> {
>
> Modified: trunk/evas/src/lib/canvas/evas_object_textblock.c
> ===
> --- trunk/evas/src/lib/canvas/evas_object_textblock.c 2008-09-10 06:40:24 UTC
> (rev 35923)
> +++ trunk/evas/src/lib/canvas/evas_object_textblock.c 2008-09-10 06:40:54 UTC
> (rev 35924)
> @@ -1168,6 +1168,7 @@
> }
> else if (fmt->font.name)
> buf = strdup(fmt->font.name);
> +
> fmt->font.font = evas_font_load(obj->layer->evas,
> buf, fmt->font.source,
> (int)(((double)fmt->font.size) *
> obj->cur.scale));
> @@ -1290,7 +1291,7 @@
> else if (fmt2->font.name)
> buf = strdup(fmt2->font.name);
> fmt2->font.font = evas_font_load(obj->layer->evas,
> -buf, fmt2->font.source,
> + buf, fmt2->font.source,
> (int)(((double)fmt2->font.size) *
> obj->cur.scale));
> if (buf) free(buf);
> return fmt2;
>
>
> -
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> ___
> enlightenment-svn mailing list
> [EMAIL PROTECTED]
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
