Re: [E-devel] Small patch with ecore_con_url.
On Mon, 31 Oct 2011 23:49:22 +0900 Kim Yunhan said:
i was going to say.. yes - that was reverted due to lack of progress callbacks
then.. but now this way works. awesome. in svn it is! thanks!
> Yes!
>
> I empathized what you worry about.
> At the first time, I tried to set this option at the initialization time in
> ecore_con_url.
> Then as you mentioned, no more propagation is occurred! :'-(
> So I looked around more deeply, then I change that this code is called at
> its finalization time as you seen in patch file.
> And to conclude, the progress is working!!
>
> Thank you.
>
> On Mon, Oct 31, 2011 at 11:31 PM, Cedric BAIL wrote:
>
> > On Mon, Oct 31, 2011 at 3:15 PM, Kim Yunhan wrote:
> > > Ooops. I forgot to attach patch file. :-)
> > >
> > > On Mon, Oct 31, 2011 at 11:13 PM, Kim Yunhan wrote:
> > >
> > >>
> > >> Hello.
> > >>
> > >> When I tested with elementary map, there is too many logs on console.
> > >> It makes me difficult to distinguish normal logs that I want to debug.
> > :'-(
> > >> It's libcurl's internal log for representing progress bar like this.
> > >>
> > >> -
> > >> downloaded : 343 / 363
> > >> % Total% Received % Xferd Average Speed TimeTime Time
> > >> Current
> > >> Dload Upload Total SpentLeft
> > >> Speed
> > >> 0 00 00 0 0 0 --:--:-- --:--:-- --:--:--
> > >> 0
> > >> downloaded : 343 / 362
> > >> % Total% Received % Xferd Average Speed TimeTime Time
> > >> Current
> > >> Dload Upload Total SpentLeft
> > >> Speed
> > >> 0 00 00 0 0 0 --:--:-- --:--:-- --:--:--
> > >> 0
> > >> downloaded : 343 / 361
> > >> % Total% Received % Xferd Average Speed TimeTime Time
> > >> Current
> > >> Dload Upload Total SpentLeft
> > >> Speed
> > >> 0 00 00 0 0 0 --:--:-- --:--:-- --:--:--
> > >> 0
> > >> downloaded : 344 / 365
> > >> downloaded : 345 / 365
> > >> downloaded : 346 / 365
> > >> downloaded : 347 / 365
> > >> -
> > >>
> > >> So, I want to remove this log.
> > >> And I look around ecore_con_url's code.
> > >> Then I found solution for it.
> > >>
> > >> Index: src/lib/ecore_con/ecore_con_url.c
> > >> ===
> > >> --- src/lib/ecore_con/ecore_con_url.c (revision 64559)
> > >> +++ src/lib/ecore_con/ecore_con_url.c (working copy)
> > >> @@ -355,6 +355,7 @@
> > >> // FIXME: For an unknown reason, progress continue to arrive
> > >> after destruction
> > >> // this prevent any further call to the callback.
> > >> curl_easy_setopt(url_con->curl_easy, CURLOPT_PROGRESSFUNCTION,
> > >> NULL);
> > >> +curl_easy_setopt(url_con->curl_easy, CURLOPT_NOPROGRESS,
> > >> EINA_TRUE);
> > >>
> > >> if (url_con->active)
> > >>{
> > >>
> > >>
> > >> When ecore_con_url goes to finalize, ecore_con_url remove its own
> > progress
> > >> function from libcurl.
> > >> But final progress function is called in libcurl, and if there is no
> > >> progress function libcurl print out internal progress log message.
> > >> Anyway as you seen above, it's useless!!
> > >> So I set libcurl option CURLOPT_NOPROGRESS, and it makes that be printed
> > >> out no more progress log.
> > >>
> > >> Please review this simple patch, and commit in SVN.
> >
> > I think I already saw that patch, it did go in and was reverted,
> > because when you set noprogress, you don't receive progress
> > information and you can't propagate a progress event. Result you won't
> > be able to update a progress bar during download. It's super annoying,
> > I agree, but I never saw a patch that make this progress feature work
> > without the printf storm.
> > So if the progress is working, what I doubt, this patch could go in,
> > if not, it won't.
> > --
> > Cedric BAIL
> >
> >
> > --
> > Get your Android app more play: Bring it to the BlackBerry PlayBook
> > in minutes. BlackBerry App World™ now supports Android™ Apps
> > for the BlackBerry® PlayBook™. Discover just how easy and simple
> > it is! http://p.sf.net/sfu/android-dev2dev
> > ___
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
> --
> Get your Android app more play: Bring it to the BlackBerry PlayBook
> in minutes. BlackBerry App World™ now supports Android™ Apps
> for the BlackBerry® PlayBook™. Discover just how easy and simple
> it is! http://p.sf.net/sfu/android-dev2dev
> ___
> enlightenment-devel mailing list
> enlightenment-devel@l
Re: [E-devel] Small patch with ecore_con_url.
On Mon, Oct 31, 2011 at 3:49 PM, Kim Yunhan wrote:
> Yes!
>
> I empathized what you worry about.
> At the first time, I tried to set this option at the initialization time in
> ecore_con_url.
> Then as you mentioned, no more propagation is occurred! :'-(
> So I looked around more deeply, then I change that this code is called at
> its finalization time as you seen in patch file.
> And to conclude, the progress is working!!
Oh, I missed that information, so sounds interesting to test then. I
can't at the moment, but as you have already investigated the problem
I just pointed, sounds good to go in svn then.
> On Mon, Oct 31, 2011 at 11:31 PM, Cedric BAIL wrote:
>
>> On Mon, Oct 31, 2011 at 3:15 PM, Kim Yunhan wrote:
>> > Ooops. I forgot to attach patch file. :-)
>> >
>> > On Mon, Oct 31, 2011 at 11:13 PM, Kim Yunhan wrote:
>> >
>> >>
>> >> Hello.
>> >>
>> >> When I tested with elementary map, there is too many logs on console.
>> >> It makes me difficult to distinguish normal logs that I want to debug.
>> :'-(
>> >> It's libcurl's internal log for representing progress bar like this.
>> >>
>> >> -
>> >> downloaded : 343 / 363
>> >> % Total % Received % Xferd Average Speed Time Time Time
>> >> Current
>> >> Dload Upload Total Spent Left
>> >> Speed
>> >> 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:--
>> >> 0
>> >> downloaded : 343 / 362
>> >> % Total % Received % Xferd Average Speed Time Time Time
>> >> Current
>> >> Dload Upload Total Spent Left
>> >> Speed
>> >> 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:--
>> >> 0
>> >> downloaded : 343 / 361
>> >> % Total % Received % Xferd Average Speed Time Time Time
>> >> Current
>> >> Dload Upload Total Spent Left
>> >> Speed
>> >> 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:--
>> >> 0
>> >> downloaded : 344 / 365
>> >> downloaded : 345 / 365
>> >> downloaded : 346 / 365
>> >> downloaded : 347 / 365
>> >> -
>> >>
>> >> So, I want to remove this log.
>> >> And I look around ecore_con_url's code.
>> >> Then I found solution for it.
>> >>
>> >> Index: src/lib/ecore_con/ecore_con_url.c
>> >> ===
>> >> --- src/lib/ecore_con/ecore_con_url.c (revision 64559)
>> >> +++ src/lib/ecore_con/ecore_con_url.c (working copy)
>> >> @@ -355,6 +355,7 @@
>> >> // FIXME: For an unknown reason, progress continue to arrive
>> >> after destruction
>> >> // this prevent any further call to the callback.
>> >> curl_easy_setopt(url_con->curl_easy, CURLOPT_PROGRESSFUNCTION,
>> >> NULL);
>> >> + curl_easy_setopt(url_con->curl_easy, CURLOPT_NOPROGRESS,
>> >> EINA_TRUE);
>> >>
>> >> if (url_con->active)
>> >> {
>> >>
>> >>
>> >> When ecore_con_url goes to finalize, ecore_con_url remove its own
>> progress
>> >> function from libcurl.
>> >> But final progress function is called in libcurl, and if there is no
>> >> progress function libcurl print out internal progress log message.
>> >> Anyway as you seen above, it's useless!!
>> >> So I set libcurl option CURLOPT_NOPROGRESS, and it makes that be printed
>> >> out no more progress log.
>> >>
>> >> Please review this simple patch, and commit in SVN.
>>
>> I think I already saw that patch, it did go in and was reverted,
>> because when you set noprogress, you don't receive progress
>> information and you can't propagate a progress event. Result you won't
>> be able to update a progress bar during download. It's super annoying,
>> I agree, but I never saw a patch that make this progress feature work
>> without the printf storm.
>> So if the progress is working, what I doubt, this patch could go in,
>> if not, it won't.
>> --
>> Cedric BAIL
>>
>>
>> --
>> Get your Android app more play: Bring it to the BlackBerry PlayBook
>> in minutes. BlackBerry App World™ now supports Android™ Apps
>> for the BlackBerry® PlayBook™. Discover just how easy and simple
>> it is! http://p.sf.net/sfu/android-dev2dev
>> ___
>> enlightenment-devel mailing list
>> enlightenment-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>>
> --
> Get your Android app more play: Bring it to the BlackBerry PlayBook
> in minutes. BlackBerry App World™ now supports Android™ Apps
> for the BlackBerry® PlayBook™. Discover just how easy and simple
> it is! http://p.sf.net/sfu/android-dev2dev
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlight
Re: [E-devel] Small patch with ecore_con_url.
Yes!
I empathized what you worry about.
At the first time, I tried to set this option at the initialization time in
ecore_con_url.
Then as you mentioned, no more propagation is occurred! :'-(
So I looked around more deeply, then I change that this code is called at
its finalization time as you seen in patch file.
And to conclude, the progress is working!!
Thank you.
On Mon, Oct 31, 2011 at 11:31 PM, Cedric BAIL wrote:
> On Mon, Oct 31, 2011 at 3:15 PM, Kim Yunhan wrote:
> > Ooops. I forgot to attach patch file. :-)
> >
> > On Mon, Oct 31, 2011 at 11:13 PM, Kim Yunhan wrote:
> >
> >>
> >> Hello.
> >>
> >> When I tested with elementary map, there is too many logs on console.
> >> It makes me difficult to distinguish normal logs that I want to debug.
> :'-(
> >> It's libcurl's internal log for representing progress bar like this.
> >>
> >> -
> >> downloaded : 343 / 363
> >> % Total% Received % Xferd Average Speed TimeTime Time
> >> Current
> >> Dload Upload Total SpentLeft
> >> Speed
> >> 0 00 00 0 0 0 --:--:-- --:--:-- --:--:--
> >> 0
> >> downloaded : 343 / 362
> >> % Total% Received % Xferd Average Speed TimeTime Time
> >> Current
> >> Dload Upload Total SpentLeft
> >> Speed
> >> 0 00 00 0 0 0 --:--:-- --:--:-- --:--:--
> >> 0
> >> downloaded : 343 / 361
> >> % Total% Received % Xferd Average Speed TimeTime Time
> >> Current
> >> Dload Upload Total SpentLeft
> >> Speed
> >> 0 00 00 0 0 0 --:--:-- --:--:-- --:--:--
> >> 0
> >> downloaded : 344 / 365
> >> downloaded : 345 / 365
> >> downloaded : 346 / 365
> >> downloaded : 347 / 365
> >> -
> >>
> >> So, I want to remove this log.
> >> And I look around ecore_con_url's code.
> >> Then I found solution for it.
> >>
> >> Index: src/lib/ecore_con/ecore_con_url.c
> >> ===
> >> --- src/lib/ecore_con/ecore_con_url.c (revision 64559)
> >> +++ src/lib/ecore_con/ecore_con_url.c (working copy)
> >> @@ -355,6 +355,7 @@
> >> // FIXME: For an unknown reason, progress continue to arrive
> >> after destruction
> >> // this prevent any further call to the callback.
> >> curl_easy_setopt(url_con->curl_easy, CURLOPT_PROGRESSFUNCTION,
> >> NULL);
> >> +curl_easy_setopt(url_con->curl_easy, CURLOPT_NOPROGRESS,
> >> EINA_TRUE);
> >>
> >> if (url_con->active)
> >>{
> >>
> >>
> >> When ecore_con_url goes to finalize, ecore_con_url remove its own
> progress
> >> function from libcurl.
> >> But final progress function is called in libcurl, and if there is no
> >> progress function libcurl print out internal progress log message.
> >> Anyway as you seen above, it's useless!!
> >> So I set libcurl option CURLOPT_NOPROGRESS, and it makes that be printed
> >> out no more progress log.
> >>
> >> Please review this simple patch, and commit in SVN.
>
> I think I already saw that patch, it did go in and was reverted,
> because when you set noprogress, you don't receive progress
> information and you can't propagate a progress event. Result you won't
> be able to update a progress bar during download. It's super annoying,
> I agree, but I never saw a patch that make this progress feature work
> without the printf storm.
> So if the progress is working, what I doubt, this patch could go in,
> if not, it won't.
> --
> Cedric BAIL
>
>
> --
> Get your Android app more play: Bring it to the BlackBerry PlayBook
> in minutes. BlackBerry App World™ now supports Android™ Apps
> for the BlackBerry® PlayBook™. Discover just how easy and simple
> it is! http://p.sf.net/sfu/android-dev2dev
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
Get your Android app more play: Bring it to the BlackBerry PlayBook
in minutes. BlackBerry App World™ now supports Android™ Apps
for the BlackBerry® PlayBook™. Discover just how easy and simple
it is! http://p.sf.net/sfu/android-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Small patch with ecore_con_url.
On Mon, Oct 31, 2011 at 3:15 PM, Kim Yunhan wrote:
> Ooops. I forgot to attach patch file. :-)
>
> On Mon, Oct 31, 2011 at 11:13 PM, Kim Yunhan wrote:
>
>>
>> Hello.
>>
>> When I tested with elementary map, there is too many logs on console.
>> It makes me difficult to distinguish normal logs that I want to debug. :'-(
>> It's libcurl's internal log for representing progress bar like this.
>>
>> -
>> downloaded : 343 / 363
>> % Total % Received % Xferd Average Speed Time Time Time
>> Current
>> Dload Upload Total Spent Left
>> Speed
>> 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:--
>> 0
>> downloaded : 343 / 362
>> % Total % Received % Xferd Average Speed Time Time Time
>> Current
>> Dload Upload Total Spent Left
>> Speed
>> 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:--
>> 0
>> downloaded : 343 / 361
>> % Total % Received % Xferd Average Speed Time Time Time
>> Current
>> Dload Upload Total Spent Left
>> Speed
>> 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:--
>> 0
>> downloaded : 344 / 365
>> downloaded : 345 / 365
>> downloaded : 346 / 365
>> downloaded : 347 / 365
>> -
>>
>> So, I want to remove this log.
>> And I look around ecore_con_url's code.
>> Then I found solution for it.
>>
>> Index: src/lib/ecore_con/ecore_con_url.c
>> ===
>> --- src/lib/ecore_con/ecore_con_url.c (revision 64559)
>> +++ src/lib/ecore_con/ecore_con_url.c (working copy)
>> @@ -355,6 +355,7 @@
>> // FIXME: For an unknown reason, progress continue to arrive
>> after destruction
>> // this prevent any further call to the callback.
>> curl_easy_setopt(url_con->curl_easy, CURLOPT_PROGRESSFUNCTION,
>> NULL);
>> + curl_easy_setopt(url_con->curl_easy, CURLOPT_NOPROGRESS,
>> EINA_TRUE);
>>
>> if (url_con->active)
>> {
>>
>>
>> When ecore_con_url goes to finalize, ecore_con_url remove its own progress
>> function from libcurl.
>> But final progress function is called in libcurl, and if there is no
>> progress function libcurl print out internal progress log message.
>> Anyway as you seen above, it's useless!!
>> So I set libcurl option CURLOPT_NOPROGRESS, and it makes that be printed
>> out no more progress log.
>>
>> Please review this simple patch, and commit in SVN.
I think I already saw that patch, it did go in and was reverted,
because when you set noprogress, you don't receive progress
information and you can't propagate a progress event. Result you won't
be able to update a progress bar during download. It's super annoying,
I agree, but I never saw a patch that make this progress feature work
without the printf storm.
So if the progress is working, what I doubt, this patch could go in,
if not, it won't.
--
Cedric BAIL
--
Get your Android app more play: Bring it to the BlackBerry PlayBook
in minutes. BlackBerry App World™ now supports Android™ Apps
for the BlackBerry® PlayBook™. Discover just how easy and simple
it is! http://p.sf.net/sfu/android-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Small patch with ecore_con_url.
Ooops. I forgot to attach patch file. :-)
On Mon, Oct 31, 2011 at 11:13 PM, Kim Yunhan wrote:
>
> Hello.
>
> When I tested with elementary map, there is too many logs on console.
> It makes me difficult to distinguish normal logs that I want to debug. :'-(
> It's libcurl's internal log for representing progress bar like this.
>
> -
> downloaded : 343 / 363
> % Total% Received % Xferd Average Speed TimeTime Time
> Current
> Dload Upload Total SpentLeft
> Speed
> 0 00 00 0 0 0 --:--:-- --:--:-- --:--:--
> 0
> downloaded : 343 / 362
> % Total% Received % Xferd Average Speed TimeTime Time
> Current
> Dload Upload Total SpentLeft
> Speed
> 0 00 00 0 0 0 --:--:-- --:--:-- --:--:--
> 0
> downloaded : 343 / 361
> % Total% Received % Xferd Average Speed TimeTime Time
> Current
> Dload Upload Total SpentLeft
> Speed
> 0 00 00 0 0 0 --:--:-- --:--:-- --:--:--
> 0
> downloaded : 344 / 365
> downloaded : 345 / 365
> downloaded : 346 / 365
> downloaded : 347 / 365
> -
>
> So, I want to remove this log.
> And I look around ecore_con_url's code.
> Then I found solution for it.
>
> Index: src/lib/ecore_con/ecore_con_url.c
> ===
> --- src/lib/ecore_con/ecore_con_url.c (revision 64559)
> +++ src/lib/ecore_con/ecore_con_url.c (working copy)
> @@ -355,6 +355,7 @@
> // FIXME: For an unknown reason, progress continue to arrive
> after destruction
> // this prevent any further call to the callback.
> curl_easy_setopt(url_con->curl_easy, CURLOPT_PROGRESSFUNCTION,
> NULL);
> +curl_easy_setopt(url_con->curl_easy, CURLOPT_NOPROGRESS,
> EINA_TRUE);
>
> if (url_con->active)
>{
>
>
> When ecore_con_url goes to finalize, ecore_con_url remove its own progress
> function from libcurl.
> But final progress function is called in libcurl, and if there is no
> progress function libcurl print out internal progress log message.
> Anyway as you seen above, it's useless!!
> So I set libcurl option CURLOPT_NOPROGRESS, and it makes that be printed
> out no more progress log.
>
> Please review this simple patch, and commit in SVN.
>
> Thanks!
>
>
Index: src/lib/ecore_con/ecore_con_url.c
===
--- src/lib/ecore_con/ecore_con_url.c (revision 64559)
+++ src/lib/ecore_con/ecore_con_url.c (working copy)
@@ -355,6 +355,7 @@
// FIXME: For an unknown reason, progress continue to arrive after
destruction
// this prevent any further call to the callback.
curl_easy_setopt(url_con->curl_easy, CURLOPT_PROGRESSFUNCTION, NULL);
+curl_easy_setopt(url_con->curl_easy, CURLOPT_NOPROGRESS, EINA_TRUE);
if (url_con->active)
{
--
Get your Android app more play: Bring it to the BlackBerry PlayBook
in minutes. BlackBerry App World™ now supports Android™ Apps
for the BlackBerry® PlayBook™. Discover just how easy and simple
it is! http://p.sf.net/sfu/android-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Small patch with ecore_con_url.
Hello.
When I tested with elementary map, there is too many logs on console.
It makes me difficult to distinguish normal logs that I want to debug. :'-(
It's libcurl's internal log for representing progress bar like this.
-
downloaded : 343 / 363
% Total% Received % Xferd Average Speed TimeTime Time
Current
Dload Upload Total SpentLeft
Speed
0 00 00 0 0 0 --:--:-- --:--:-- --:--:--
0
downloaded : 343 / 362
% Total% Received % Xferd Average Speed TimeTime Time
Current
Dload Upload Total SpentLeft
Speed
0 00 00 0 0 0 --:--:-- --:--:-- --:--:--
0
downloaded : 343 / 361
% Total% Received % Xferd Average Speed TimeTime Time
Current
Dload Upload Total SpentLeft
Speed
0 00 00 0 0 0 --:--:-- --:--:-- --:--:--
0
downloaded : 344 / 365
downloaded : 345 / 365
downloaded : 346 / 365
downloaded : 347 / 365
-
So, I want to remove this log.
And I look around ecore_con_url's code.
Then I found solution for it.
Index: src/lib/ecore_con/ecore_con_url.c
===
--- src/lib/ecore_con/ecore_con_url.c (revision 64559)
+++ src/lib/ecore_con/ecore_con_url.c (working copy)
@@ -355,6 +355,7 @@
// FIXME: For an unknown reason, progress continue to arrive after
destruction
// this prevent any further call to the callback.
curl_easy_setopt(url_con->curl_easy, CURLOPT_PROGRESSFUNCTION,
NULL);
+curl_easy_setopt(url_con->curl_easy, CURLOPT_NOPROGRESS,
EINA_TRUE);
if (url_con->active)
{
When ecore_con_url goes to finalize, ecore_con_url remove its own progress
function from libcurl.
But final progress function is called in libcurl, and if there is no
progress function libcurl print out internal progress log message.
Anyway as you seen above, it's useless!!
So I set libcurl option CURLOPT_NOPROGRESS, and it makes that be printed
out no more progress log.
Please review this simple patch, and commit in SVN.
Thanks!
--
Get your Android app more play: Bring it to the BlackBerry PlayBook
in minutes. BlackBerry App World™ now supports Android™ Apps
for the BlackBerry® PlayBook™. Discover just how easy and simple
it is! http://p.sf.net/sfu/android-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] small patch for evas
Hi Carsten, > On Wed, 10 Mar 2010 22:53:27 +0100 Mathieu Taillefumier > said: > >> Hi, >> >> herewith a small patch for evas that check for the presence of libpng14. >> I had trouble today compile e17 with libpng14 because the configura file >> was picking up libpng12 instead. >> >> The patch is very simple but I probably did not indent it correctly. > > thanks! in svn (winth nicer indenting) :) > good. simplify my life a bit. >> I am also finishing a patch for e17 that implement eina_log in the >> enlightenment modules (for now). I wanted to know if i should do the >> same thing on the illume and illume2 modules as well, or if I can let >> them as it is. The patch is almost finished but it needs some more >> testing (compilation and run checks mostly). > > illume - u can leave alone. illume2 is worth it though > The patch is finished but I had to modify it again. I checked the source code for illume2 and there is a comment indicating that the module was written initially with eina_log but doing it this way decreases performance. So I suppose that I should leave it alone too. Mathieu -- Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] small patch for evas
On Wed, 10 Mar 2010 22:53:27 +0100 Mathieu Taillefumier said: > Hi, > > herewith a small patch for evas that check for the presence of libpng14. > I had trouble today compile e17 with libpng14 because the configura file > was picking up libpng12 instead. > > The patch is very simple but I probably did not indent it correctly. thanks! in svn (winth nicer indenting) :) > I am also finishing a patch for e17 that implement eina_log in the > enlightenment modules (for now). I wanted to know if i should do the > same thing on the illume and illume2 modules as well, or if I can let > them as it is. The patch is almost finished but it needs some more > testing (compilation and run checks mostly). illume - u can leave alone. illume2 is worth it though -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] small patch for evas
Hi,
herewith a small patch for evas that check for the presence of libpng14.
I had trouble today compile e17 with libpng14 because the configura file
was picking up libpng12 instead.
The patch is very simple but I probably did not indent it correctly.
I am also finishing a patch for e17 that implement eina_log in the
enlightenment modules (for now). I wanted to know if i should do the
same thing on the illume and illume2 modules as well, or if I can let
them as it is. The patch is almost finished but it needs some more
testing (compilation and run checks mostly).
Mathieu
Index: evas_check_loader.m4
===
--- evas_check_loader.m4(revision 46731)
+++ evas_check_loader.m4(working copy)
@@ -174,12 +174,11 @@
evas_image_loader_[]$1[]_cflags=""
evas_image_loader_[]$1[]_libs=""
-PKG_CHECK_EXISTS([libpng12],
- [PKG_CHECK_MODULES([PNG], [libpng12], [have_dep="yes"
requirement="libpng12"], [have_dep="no"])],
- [PKG_CHECK_EXISTS([libpng10],
- [PKG_CHECK_MODULES([PNG], [libpng10], [have_dep="yes"
requirement="libpng10"], [have_dep="no"])],
- [PKG_CHECK_MODULES([PNG], [libpng], [have_dep="yes"
requirement="libpng"], [have_dep="no"])])]
-)
+PKG_CHECK_EXISTS([libpng14],
+ [PKG_CHECK_MODULES([PNG], [libpng14], [have_dep="yes"
requirement="libpng14"], [have_dep="no"])],
+ [PKG_CHECK_EXISTS([libpng12], [PKG_CHECK_MODULES([PNG], [libpng12],
[have_dep="yes" requirement="libpng12"], [have_dep="no"])],
+ [PKG_CHECK_EXISTS([libpng10], [PKG_CHECK_MODULES([PNG], [libpng10],
[have_dep="yes" requirement="libpng10"], [have_dep="no"])],
+ [PKG_CHECK_MODULES([PNG], [libpng], [have_dep="yes"
requirement="libpng"], [have_dep="no"])])])])
evas_image_loader_[]$1[]_cflags="${PNG_CFLAGS}"
evas_image_loader_[]$1[]_libs="${PNG_LIBS}"
--
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] small patch for ecore
Hey Vincent,
the modifications are done. I choose the shortest notation.
Mathieu
Hey
I modified some hearder file in ecore to ease the cleanup of the
private header files in ecore. Each module has now a private header
with its own log color (eina_log related). I also created two private
header files for ecore_sdl and ecore_input for this purpose and
corrected some typos in the xlib_xcb private header file.
you used:
ECORE_XLIB_XCB_DEFAULT_LOG_COLOR
i would prefer :
ECORE_XCB_DEFAULT_LOG_COLOR
or
ECORE_X11_XCB_DEFAULT_LOG_COLOR
If you use the last one, then change also
ECORE_XLIB_DEFAULT_LOG_COLOR
to
ECORE_X11_XLIB_DEFAULT_LOG_COLOR
Vincent
Index: src/lib/ecore_win32/ecore_win32_private.h
===
--- src/lib/ecore_win32/ecore_win32_private.h (revision 44931)
+++ src/lib/ecore_win32/ecore_win32_private.h (working copy)
@@ -14,8 +14,23 @@
/* logging messages macros */
extern int _ecore_win32_log_dom_global;
+#ifdef ECORE_WIN32_DEFAULT_LOG_COLOR
+# undef ECORE_WIN32_DEFAULT_LOG_COLOR
+#endif
+#define ECORE_WIN32_DEFAULT_LOG_COLOR EINA_COLOR_LIGHTBLUE
+
+#ifdef ERR
+# undef ERR
+#endif
#define ERR(...) EINA_LOG_DOM_ERR(_ecore_win32_log_dom_global , __VA_ARGS__)
+#ifdef DBG
+#undef DBG
+#endif
#define DBG(...) EINA_LOG_DOM_DBG(_ecore_win32_log_dom_global , __VA_ARGS__)
+
+#ifdef INF
+#undef INF
+#endif
#define INF(...) EINA_LOG_DOM_INFO(_ecore_win32_log_dom_global , __VA_ARGS__)
#define ECORE_WIN32_WINDOW_CLASS "Ecore_Win32_Window_Class"
Index: src/lib/ecore_win32/ecore_win32.c
===
--- src/lib/ecore_win32/ecore_win32.c (revision 44931)
+++ src/lib/ecore_win32/ecore_win32.c (working copy)
@@ -89,7 +89,7 @@
return --_ecore_win32_init_count;
eina_log_print_cb_set(_ecore_win32_error_print_cb, NULL);
- _ecore_win32_log_dom_global = eina_log_domain_register("ecore_win32",
EINA_COLOR_LIGHTBLUE);
+ _ecore_win32_log_dom_global = eina_log_domain_register("ecore_win32",
ECORE_WIN32_DEFAULT_LOG_COLOR);
if (_ecore_win32_log_dom_global < 0)
{
EINA_LOG_ERR("Ecore_Win32: Could not register log domain");
Index: src/lib/ecore_wince/ecore_wince_private.h
===
--- src/lib/ecore_wince/ecore_wince_private.h (revision 44931)
+++ src/lib/ecore_wince/ecore_wince_private.h (working copy)
@@ -9,8 +9,22 @@
/* logging messages macros */
extern int _ecore_wince_log_dom_global;
+#ifdef ECORE_WINCE_DEFAULT_LOG_COLOR
+#undef ECORE_WINCE_DEFAULT_LOG_COLOR
+#endif
+#define ECORE_WINCE_DEFAULT_LOG_COLOR EINA_COLOR_LIGHTBLUE
+
+#ifdef ERR
+# undef ERR
+#endif
#define ERR(...) EINA_LOG_DOM_ERR(_ecore_wince_log_dom_global , __VA_ARGS__)
+#ifdef DBG
+# undef DBG
+#endif
#define DBG(...) EINA_LOG_DOM_DBG(_ecore_wince_log_dom_global , __VA_ARGS__)
+#ifdef INF
+# undef INF
+#endif
#define INF(...) EINA_LOG_DOM_INFO(_ecore_wince_log_dom_global , __VA_ARGS__)
#define ECORE_WINCE_WINDOW_CLASS L"Ecore_WinCE_Window_Class"
Index: src/lib/ecore_wince/ecore_wince.c
===
--- src/lib/ecore_wince/ecore_wince.c (revision 44931)
+++ src/lib/ecore_wince/ecore_wince.c (working copy)
@@ -74,7 +74,7 @@
return --_ecore_wince_init_count;
eina_log_print_cb_set(_ecore_wince_error_print_cb, NULL);
- _ecore_wince_log_dom_global = eina_log_domain_register("ecore_wince",
EINA_COLOR_LIGHTBLUE);
+ _ecore_wince_log_dom_global = eina_log_domain_register("ecore_wince",
ECORE_WINCE_DEFAULT_LOG_COLOR);
if (_ecore_wince_log_dom_global < 0)
{
EINA_LOG_ERR("Ecore_WinCE: Could not register log domain");
Index: src/lib/ecore_config/ecore_config_private.h
===
--- src/lib/ecore_config/ecore_config_private.h (revision 44931)
+++ src/lib/ecore_config/ecore_config_private.h (working copy)
@@ -1,6 +1,9 @@
#ifndef _ECORE_CONFIG_PRIVATE_H
# define _ECORE_CONFIG_PRIVATE_H
-
+#ifdef ECORE_CONFIG_DEFAULT_LOG_COLOR
+# undef ECORE_CONFIG_DEFAULT_LOG_COLOR
+#endif
+#define ECORE_CONFIG_DEFAULT_LOG_COLOR EINA_COLOR_BLUE
/* eina_log related things */
extern int _ecore_config_log_dom;
Index: src/lib/ecore_config/ecore_config.c
===
--- src/lib/ecore_config/ecore_config.c (revision 44931)
+++ src/lib/ecore_config/ecore_config.c (working copy)
@@ -1674,7 +1674,7 @@
{
char*path;
Ecore_Config_Prop *list;
- _ecore_config_log_dom = eina_log_domain_register("EcoreConfig",
ECORE_DEFAULT_LOG_COLOR);
+ _ecore_config_log_dom = eina_log_domain_register("EcoreConfig",
ECORE_CONFIG_DEFAULT_LOG_COLOR);
if(_ecore_config_log_dom < 0)
{
EINA_LOG_ERR("Impossible to create a log domain for the Ecore config
module.");
Index: src/lib/ecore_x/xcb/ecore_xcb_private.h
Re: [E-devel] small patch for ecore
Hey > I modified some hearder file in ecore to ease the cleanup of the private > header files in ecore. Each module has now a private header with its own log > color (eina_log related). I also created two private header files for > ecore_sdl and ecore_input for this purpose and corrected some typos in the > xlib_xcb private header file. you used: ECORE_XLIB_XCB_DEFAULT_LOG_COLOR i would prefer : ECORE_XCB_DEFAULT_LOG_COLOR or ECORE_X11_XCB_DEFAULT_LOG_COLOR If you use the last one, then change also ECORE_XLIB_DEFAULT_LOG_COLOR to ECORE_X11_XLIB_DEFAULT_LOG_COLOR Vincent -- This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] small patch for ecore
Hello,
I modified some hearder file in ecore to ease the cleanup of the private
header files in ecore. Each module has now a private header with its own
log color (eina_log related). I also created two private header files
for ecore_sdl and ecore_input for this purpose and corrected some typos
in the xlib_xcb private header file.
regards
Mathieu
Index: src/lib/ecore_win32/ecore_win32_private.h
===
--- src/lib/ecore_win32/ecore_win32_private.h (revision 44931)
+++ src/lib/ecore_win32/ecore_win32_private.h (working copy)
@@ -14,8 +14,23 @@
/* logging messages macros */
extern int _ecore_win32_log_dom_global;
+#ifdef ECORE_WIN32_DEFAULT_LOG_COLOR
+# undef ECORE_WIN32_DEFAULT_LOG_COLOR
+#endif
+#define ECORE_WIN32_DEFAULT_LOG_COLOR EINA_COLOR_LIGHTBLUE
+
+#ifdef ERR
+# undef ERR
+#endif
#define ERR(...) EINA_LOG_DOM_ERR(_ecore_win32_log_dom_global , __VA_ARGS__)
+#ifdef DBG
+#undef DBG
+#endif
#define DBG(...) EINA_LOG_DOM_DBG(_ecore_win32_log_dom_global , __VA_ARGS__)
+
+#ifdef INF
+#undef INF
+#endif
#define INF(...) EINA_LOG_DOM_INFO(_ecore_win32_log_dom_global , __VA_ARGS__)
#define ECORE_WIN32_WINDOW_CLASS "Ecore_Win32_Window_Class"
Index: src/lib/ecore_win32/ecore_win32.c
===
--- src/lib/ecore_win32/ecore_win32.c (revision 44931)
+++ src/lib/ecore_win32/ecore_win32.c (working copy)
@@ -89,7 +89,7 @@
return --_ecore_win32_init_count;
eina_log_print_cb_set(_ecore_win32_error_print_cb, NULL);
- _ecore_win32_log_dom_global = eina_log_domain_register("ecore_win32",
EINA_COLOR_LIGHTBLUE);
+ _ecore_win32_log_dom_global = eina_log_domain_register("ecore_win32",
ECORE_WIN32_DEFAULT_LOG_COLOR);
if (_ecore_win32_log_dom_global < 0)
{
EINA_LOG_ERR("Ecore_Win32: Could not register log domain");
Index: src/lib/ecore_wince/ecore_wince_private.h
===
--- src/lib/ecore_wince/ecore_wince_private.h (revision 44931)
+++ src/lib/ecore_wince/ecore_wince_private.h (working copy)
@@ -9,8 +9,22 @@
/* logging messages macros */
extern int _ecore_wince_log_dom_global;
+#ifdef ECORE_WINCE_DEFAULT_LOG_COLOR
+#undef ECORE_WINCE_DEFAULT_LOG_COLOR
+#endif
+#define ECORE_WINCE_DEFAULT_LOG_COLOR EINA_COLOR_LIGHTBLUE
+
+#ifdef ERR
+# undef ERR
+#endif
#define ERR(...) EINA_LOG_DOM_ERR(_ecore_wince_log_dom_global , __VA_ARGS__)
+#ifdef DBG
+# undef DBG
+#endif
#define DBG(...) EINA_LOG_DOM_DBG(_ecore_wince_log_dom_global , __VA_ARGS__)
+#ifdef INF
+# undef INF
+#endif
#define INF(...) EINA_LOG_DOM_INFO(_ecore_wince_log_dom_global , __VA_ARGS__)
#define ECORE_WINCE_WINDOW_CLASS L"Ecore_WinCE_Window_Class"
Index: src/lib/ecore_wince/ecore_wince.c
===
--- src/lib/ecore_wince/ecore_wince.c (revision 44931)
+++ src/lib/ecore_wince/ecore_wince.c (working copy)
@@ -74,7 +74,7 @@
return --_ecore_wince_init_count;
eina_log_print_cb_set(_ecore_wince_error_print_cb, NULL);
- _ecore_wince_log_dom_global = eina_log_domain_register("ecore_wince",
EINA_COLOR_LIGHTBLUE);
+ _ecore_wince_log_dom_global = eina_log_domain_register("ecore_wince",
ECORE_WINCE_DEFAULT_LOG_COLOR);
if (_ecore_wince_log_dom_global < 0)
{
EINA_LOG_ERR("Ecore_WinCE: Could not register log domain");
Index: src/lib/ecore_config/ecore_config_private.h
===
--- src/lib/ecore_config/ecore_config_private.h (revision 44931)
+++ src/lib/ecore_config/ecore_config_private.h (working copy)
@@ -1,6 +1,9 @@
#ifndef _ECORE_CONFIG_PRIVATE_H
# define _ECORE_CONFIG_PRIVATE_H
-
+#ifdef ECORE_CONFIG_DEFAULT_LOG_COLOR
+# undef ECORE_CONFIG_DEFAULT_LOG_COLOR
+#endif
+#define ECORE_CONFIG_DEFAULT_LOG_COLOR EINA_COLOR_BLUE
/* eina_log related things */
extern int _ecore_config_log_dom;
Index: src/lib/ecore_config/ecore_config.c
===
--- src/lib/ecore_config/ecore_config.c (revision 44931)
+++ src/lib/ecore_config/ecore_config.c (working copy)
@@ -1674,7 +1674,7 @@
{
char*path;
Ecore_Config_Prop *list;
- _ecore_config_log_dom = eina_log_domain_register("EcoreConfig",
ECORE_DEFAULT_LOG_COLOR);
+ _ecore_config_log_dom = eina_log_domain_register("EcoreConfig",
ECORE_CONFIG_DEFAULT_LOG_COLOR);
if(_ecore_config_log_dom < 0)
{
EINA_LOG_ERR("Impossible to create a log domain for the Ecore config
module.");
Index: src/lib/ecore_x/xcb/ecore_xcb_private.h
===
--- src/lib/ecore_x/xcb/ecore_xcb_private.h (revision 44931)
+++ src/lib/ecore_x/xcb/ecore_xcb_private.h (working copy)
@@ -61,8 +61,13 @@
/* FIXME: this is for simulation only */
#include "Ecore_Txt.h"
-static int _ecore_x11xcb_log_dom
Re: [E-devel] Small patch
On Thu, 21 Jun 2007 15:34:34 +0200 Cedric BAIL <[EMAIL PROTECTED]> babbled: > Time to dump all my pending patch again :) Starting with the easy one : > > - edje-const.diff and evas-const.diff: Add some const, useless :) > > - evas-list-sort.diff: I did finally find a bug with some size, the end of > the list was not correctly sorted. Could be the bug raster see in my early > patch (I also attached the test I used to find that issue). in - i'm going to watch for anything strange when it comes to sorts. -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)[EMAIL PROTECTED] 裸好多 Tokyo, Japan (東京 日本) - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] small patch adding an e.event.lower to the config
On Sat, 23 Jun 2007 14:07:50 +0200 (CEST) Paul Koether <[EMAIL PROTECTED]> babbled: > thought this could be useful if themers want to add a lower button to the > border. what about raise? or all the other things... we need to cover a LOT of basic events in signal bindings to flesh this out. -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)[EMAIL PROTECTED] 裸好多 Tokyo, Japan (東京 日本) - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] small patch adding an e.event.lower to the config
thought this could be useful if themers want to add a lower button to the border.--- cvs/e17/apps/e/src/bin/e_config.c 2007-06-23 13:42:52.0 +0200 +++ cvs1/e17/apps/e/src/bin/e_config.c 2007-06-23 13:50:24.0 +0200 @@ -1051,6 +1051,10 @@ "e.event.shade", E_BINDING_MODIFIER_NONE, 1, "window_shaded_toggle", "up"); + CFG_SIGNALBIND(E_BINDING_CONTEXT_BORDER, "mouse,clicked,?", + "e.event.lower", + E_BINDING_MODIFIER_NONE, 1, + "window_lower", NULL); CFG_SIGNALBIND(E_BINDING_CONTEXT_BORDER, "mouse,down,1", "e.event.icon", E_BINDING_MODIFIER_NONE, 1, - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Small patch
Time to dump all my pending patch again :) Starting with the easy one :
- edje-const.diff and evas-const.diff: Add some const, useless :)
- evas-list-sort.diff: I did finally find a bug with some size, the end of the
list was not correctly sorted. Could be the bug raster see in my early patch
(I also attached the test I used to find that issue).
Well, more work is coming...
Cedric
diff -Nrua -X exclude.cvs e17-clean/libs/edje/src/lib/Edje.h e17-dev/libs/edje/src/lib/Edje.h
--- e17-clean/libs/edje/src/lib/Edje.h 2007-06-04 09:17:09.0 +0200
+++ e17-dev/libs/edje/src/lib/Edje.h 2007-06-08 17:09:11.0 +0200
@@ -164,7 +164,7 @@
/* edje_util.c */
EAPI void edje_freeze (void);
EAPI void edje_thaw (void);
- EAPI void edje_fontset_append_set (char *fonts);
+ EAPI void edje_fontset_append_set (const char *fonts);
EAPI const char *edje_fontset_append_get (void);
/* edje_load.c */
diff -Nrua -X exclude.cvs e17-clean/libs/edje/src/lib/edje_util.c e17-dev/libs/edje/src/lib/edje_util.c
--- e17-clean/libs/edje/src/lib/edje_util.c 2007-06-20 13:46:54.0 +0200
+++ e17-dev/libs/edje/src/lib/edje_util.c 2007-06-18 15:22:33.0 +0200
@@ -58,7 +58,7 @@
/* FIXDOC: Expand */
EAPI void
-edje_fontset_append_set(char *fonts)
+edje_fontset_append_set(const char *fonts)
{
if (_edje_fontset_append)
free(_edje_fontset_append);
diff -Nrua -X exclude.cvs e17-clean/libs/evas/src/lib/data/evas_list.c e17-dev/libs/evas/src/lib/data/evas_list.c
--- e17-clean/libs/evas/src/lib/data/evas_list.c 2007-03-20 18:54:27.0 +0100
+++ e17-dev/libs/evas/src/lib/data/evas_list.c 2007-05-21 13:51:31.0 +0200
@@ -850,57 +850,8 @@
if (l1 == l2) break;
l2 = l2->prev;
}
- return list;
-}
-
-static Evas_List *
-evas_list_combine(Evas_List *l, Evas_List *ll, int (*func)(void *, void*))
-{
- Evas_List *result = NULL;
- Evas_List *l_head = NULL, *ll_head = NULL;
-
- l_head = l;
- ll_head = ll;
- while (l && ll)
- {
- int cmp;
- cmp = func(l->data, ll->data);
- if (cmp < 0)
- {
- result = evas_list_append(result, l->data);
- l = evas_list_next(l);
- }
- else if (cmp == 0)
- {
- result = evas_list_append(result, l->data);
- l = evas_list_next(l);
- result = evas_list_append(result, ll->data);
- ll = evas_list_next(ll);
- }
- else if (cmp > 0)
- {
- result = evas_list_append(result, ll->data);
- ll = evas_list_next(ll);
- }
- else
- {
- l = ll = NULL;
- }
- }
- while (l)
- {
- result = evas_list_append(result, l->data);
- l = evas_list_next(l);
- }
- evas_list_free(l_head);
- while (ll)
- {
- result = evas_list_append(result, ll->data);
- ll = evas_list_next(ll);
- }
- evas_list_free(ll_head);
- return (result);
+ return list;
}
/**
@@ -915,8 +866,6 @@
* you just have to be smart enough to know what kind of data is in your
* lists
*
- * In the event of a memory allocation failure, It might segv.
- *
* Example:
* @code
* int
@@ -944,41 +893,97 @@
EAPI Evas_List *
evas_list_sort(Evas_List *list, int size, int (*func)(void *, void *))
{
- Evas_List *l = NULL, *ll = NULL, *llast;
- int mid;
+ unsigned int list_number;
+ unsigned int middle;
+ int list_size;
if (!list || !func)
return NULL;
- /* FIXME: this is really inefficient - calling evas_list_nth is not
-* fast as it has to walk the list */
-
/* if the caller specified an invalid size, sort the whole list */
if ((size <= 0) ||
(size > ((Evas_List_Accounting *)(list->accounting))->count))
size = ((Evas_List_Accounting *)(list->accounting))->count;
- mid = size / 2;
- if (mid < 1) return list;
+ middle = size - size / 2;
- /* bleh evas list splicing */
- llast = ((Evas_List_Accounting *)(list->accounting))->last;
- ll = evas_list_nth_list(list, mid);
- if (ll->prev)
+ for (list_number = middle, list_size = 1;
+ list_size < middle * 2;
+ list_number >>= 1, list_size <<= 1)
{
- ((Evas_List_Accounting *)(list->accounting))->last = ll->prev;
- ((Evas_List_Accounting *)(list->accounting))->count = mid;
- ll->prev->next = NULL;
- ll->prev = NULL;
+ Evas_List *head1 = list;
+ unsigned int limit = size;
+ unsigned int process_list;
+ unsigned int pass_number;
+ unsigned int split_size = list_size;
+
+ for (process_list = 0; process_list < list_number + 1; ++process_list)
+ {
+ Evas_List *head2;
+ unsigned int size_sum;
+ int size1, size2;
+ int i;
+
+ size1 = limit < split_size ? limit : split_size;
+ limit -= size1;
+
+ size2 = limit < split_size ? limit : split_size;
+ limit -= size2;
+
+ size_sum = size1 + size2;
+
+ for (head2 = head1, i = 0; i < size1; ++i)
+ head2 = evas_list_next (head2);
+
+ for (pass_number = 0; pass_number < size_sum; ++pas
[E-devel] small patch to correct winlist mouse warp
Hi,
i reused parts of e_winlist for a module and encouterd the problem
that the warp-timer wont stop due to roundings to int. This patch fixes
that.
Regards,
HannesIndex: e_winlist.c
===
RCS file: /var/cvs/e/e17/apps/e/src/bin/e_winlist.c,v
retrieving revision 1.50
diff -u -r1.50 e_winlist.c
--- e_winlist.c 2 Mar 2007 17:00:20 - 1.50
+++ e_winlist.c 13 Mar 2007 00:28:39 -
@@ -54,10 +54,10 @@
static Evas_List *handlers = NULL;
static Ecore_X_Window input_window = 0;
static int warp_to = 0;
-static int warp_to_x = 0;
-static int warp_to_y = 0;
-static int warp_x = 0;
-static int warp_y = 0;
+static double warp_to_x = 0;
+static double warp_to_y = 0;
+static double warp_x = 0;
+static double warp_y = 0;
static int scroll_to = 0;
static double scroll_align_to = 0.0;
static double scroll_align = 0.0;
@@ -914,7 +914,7 @@
{
if (warp_to)
{
- int x, y;
+ double x, y;
double spd;
spd = e_config->winlist_warp_speed;
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] small patch for clock module (language)
Hi.. the current wording in the menu is a bit unfortunate..
for many people (me included) a 12-hour clock is not considered "normal"
this patch rewords it, and adds the Norwegian translation..
Cheers,
--
Morten
Index: src/modules/clock/e_mod_main.c
===
RCS file: /cvsroot/enlightenment/e17/apps/e/src/modules/clock/e_mod_main.c,v
retrieving revision 1.39
diff -u -r1.39 e_mod_main.c
--- src/modules/clock/e_mod_main.c 24 Sep 2005 13:42:05 - 1.39
+++ src/modules/clock/e_mod_main.c 6 Dec 2005 12:15:38 -
@@ -346,7 +346,7 @@
/* Show normal time */
mi = e_menu_item_new(smn);
- e_menu_item_label_set(mi, _("Normal"));
+ e_menu_item_label_set(mi, _("12 Hour"));
e_menu_item_radio_set(mi, 1);
e_menu_item_radio_group_set(mi, 1);
if (face->conf->digitalStyle == DIGITAL_STYLE_NORMAL) {
Index: po/nb.po
===
RCS file: /cvsroot/enlightenment/e17/apps/e/po/nb.po,v
retrieving revision 1.1
diff -u -r1.1 nb.po
--- po/nb.po15 Oct 2005 05:50:16 - 1.1
+++ po/nb.po6 Dec 2005 12:15:38 -
@@ -195,8 +195,8 @@
#: src/bin/e_border.c:6285 src/modules/clock/e_mod_main.c:349
#: src/modules/pager/e_mod_main.c:458
-msgid "Normal"
-msgstr "Normal"
+msgid "12 Hour"
+msgstr "12-timers"
#: src/bin/e_border.c:6295
msgid "Always Below"
@@ -956,7 +956,7 @@
#: src/modules/clock/e_mod_main.c:360
msgid "24 Hour"
-msgstr "24 timer"
+msgstr "24-timers"
#: src/modules/clock/e_mod_main.c:372
msgid "Digital Display"
[E-devel] Small patch to clean up some typos in e_main.c
Hello, Attached it a small patch against e17's e_main.c that just fixes a few typos in that file. - Chad e_main.c-typos.diff Description: Binary data
[E-devel] small patch to e17
as in subject...
Index: e17/apps/e/src/bin/e_int_menus.c
===
RCS file: /cvsroot/enlightenment/e17/apps/e/src/bin/e_int_menus.c,v
retrieving revision 1.41
diff -u -r1.41 e_int_menus.c
--- e17/apps/e/src/bin/e_int_menus.c22 Mar 2005 19:30:28 - 1.41
+++ e17/apps/e/src/bin/e_int_menus.c25 Mar 2005 17:23:04 -
@@ -430,11 +430,12 @@
zone = root->zone;
for (l = e_border_clients_get(); l; l = l->next)
{
- E_Border *border;
+ E_Border *bd;
- border = l->data;
- if ((border->zone == zone) || (border->iconic))
- borders = evas_list_append(borders, border);
+ bd = l->data;
+ if (((bd->zone == zone) || (bd->iconic)) &&
!ecore_x_window_prop_state_isset(bd->win,
+ ECORE_X_WINDOW_STATE_SKIP_TASKBAR))
+ borders = evas_list_append(borders, bd);
}
if (!borders)
