Re: [E-devel] E SVN: englebass trunk/edbus/src/lib

2012-11-04 Thread Lucas De Marchi 
On Sat, Nov 3, 2012 at 6:29 PM, Sebastian Dransfeld s...@tango.flipp.net 
wrote:
 Ubuntu 12.04

 gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5)

 efreet/src/bin grep ^CFLAGS Makefile
 CFLAGS = -rdynamic -std=gnu99 -g -Wall -Wextra -Wpointer-arith
 -fvisibility=hidden -pipe -march=native -Wshadow

Try setting -Wno-missing-field-initializers to see how pointless that
warning is and how it removes the burden from you of setting
already-known-to-be-0/NULL fields in a struct. C can be much nicer
than people use nowadays.

Since this is a public header, I think it's reasonable to let it as
you want. Just wanted to point out that using edbus is much nicer
without that. Look how ugly the method/signal/property tables are
without disabling this warning.

Lucas De Marchi

--
LogMeIn Central: Instant, anywhere, Remote PC access and management.
Stay in control, update software, and manage PCs from one command center
Diagnose problems and improve visibility into emerging IT issues
Automate, monitor and manage. Do more in less time with Central
http://p.sf.net/sfu/logmein12331_d2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: englebass trunk/edbus/src/lib

2012-11-03 Thread Sebastian Dransfeld 
Ubuntu 12.04

gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5)

efreet/src/bin grep ^CFLAGS Makefile
CFLAGS = -rdynamic -std=gnu99 -g -Wall -Wextra -Wpointer-arith 
-fvisibility=hidden -pipe -march=native -Wshadow

S.

On 11/02/2012 11:20 PM, Gustavo Sverzut Barbieri wrote:
 Hi englebass,

 which compiler version? which cflags? Shouldn't be a problem, but I agree
 with you... but it is good to know why it`s causing that for you.


 On Fri, Nov 2, 2012 at 6:12 PM, Enlightenment SVN 
 no-re...@enlightenment.org wrote:

 Log:
 edbus2: quiet warning (again)

Say what you want, but this creates quite a lot of warnings, and
warnings when including another header into a project is no good. I want
to just see my own warnings.

So as long as there is only two NULLs, please let them be there.

 Author:   englebass
 Date: 2012-11-02 13:12:27 -0700 (Fri, 02 Nov 2012)
 New Revision: 78873
 Trac: http://trac.enlightenment.org/e/changeset/78873

 Modified:
trunk/edbus/src/lib/edbus_service.h

 Modified: trunk/edbus/src/lib/edbus_service.h
 ===
 --- trunk/edbus/src/lib/edbus_service.h 2012-11-02 20:11:56 UTC (rev 78872)
 +++ trunk/edbus/src/lib/edbus_service.h 2012-11-02 20:12:27 UTC (rev 78873)
 @@ -24,7 +24,7 @@
* The signature will be ss and each string will have a tag name on
* introspect XML with the respective name.
*/
 -#define EDBUS_ARGS(args...) (const EDBus_Arg_Info[]){ args, { } }
 +#define EDBUS_ARGS(args...) (const EDBus_Arg_Info[]){ args, { NULL, NULL
 } }

   typedef struct _EDBus_Service_Interface EDBus_Service_Interface;
   typedef EDBus_Message * (*EDBus_Method_Cb)(const EDBus_Service_Interface
 *iface, const EDBus_Message *message);



 --
 LogMeIn Central: Instant, anywhere, Remote PC access and management.
 Stay in control, update software, and manage PCs from one command center
 Diagnose problems and improve visibility into emerging IT issues
 Automate, monitor and manage. Do more in less time with Central
 http://p.sf.net/sfu/logmein12331_d2d
 ___
 enlightenment-svn mailing list
 enlightenment-...@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-svn






--
LogMeIn Central: Instant, anywhere, Remote PC access and management.
Stay in control, update software, and manage PCs from one command center
Diagnose problems and improve visibility into emerging IT issues
Automate, monitor and manage. Do more in less time with Central
http://p.sf.net/sfu/logmein12331_d2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: englebass trunk/edbus/src/lib

2012-11-02 Thread Gustavo Sverzut Barbieri 
Hi englebass,

which compiler version? which cflags? Shouldn't be a problem, but I agree
with you... but it is good to know why it`s causing that for you.


On Fri, Nov 2, 2012 at 6:12 PM, Enlightenment SVN 
no-re...@enlightenment.org wrote:

 Log:
 edbus2: quiet warning (again)

   Say what you want, but this creates quite a lot of warnings, and
   warnings when including another header into a project is no good. I want
   to just see my own warnings.

   So as long as there is only two NULLs, please let them be there.

 Author:   englebass
 Date: 2012-11-02 13:12:27 -0700 (Fri, 02 Nov 2012)
 New Revision: 78873
 Trac: http://trac.enlightenment.org/e/changeset/78873

 Modified:
   trunk/edbus/src/lib/edbus_service.h

 Modified: trunk/edbus/src/lib/edbus_service.h
 ===
 --- trunk/edbus/src/lib/edbus_service.h 2012-11-02 20:11:56 UTC (rev 78872)
 +++ trunk/edbus/src/lib/edbus_service.h 2012-11-02 20:12:27 UTC (rev 78873)
 @@ -24,7 +24,7 @@
   * The signature will be ss and each string will have a tag name on
   * introspect XML with the respective name.
   */
 -#define EDBUS_ARGS(args...) (const EDBus_Arg_Info[]){ args, { } }
 +#define EDBUS_ARGS(args...) (const EDBus_Arg_Info[]){ args, { NULL, NULL
 } }

  typedef struct _EDBus_Service_Interface EDBus_Service_Interface;
  typedef EDBus_Message * (*EDBus_Method_Cb)(const EDBus_Service_Interface
 *iface, const EDBus_Message *message);



 --
 LogMeIn Central: Instant, anywhere, Remote PC access and management.
 Stay in control, update software, and manage PCs from one command center
 Diagnose problems and improve visibility into emerging IT issues
 Automate, monitor and manage. Do more in less time with Central
 http://p.sf.net/sfu/logmein12331_d2d
 ___
 enlightenment-svn mailing list
 enlightenment-...@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-svn




-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
--
LogMeIn Central: Instant, anywhere, Remote PC access and management.
Stay in control, update software, and manage PCs from one command center
Diagnose problems and improve visibility into emerging IT issues
Automate, monitor and manage. Do more in less time with Central
http://p.sf.net/sfu/logmein12331_d2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: englebass trunk/edbus/src/lib

2012-10-22 Thread Lucas De Marchi 
On Sun, Oct 21, 2012 at 2:53 AM, Enlightenment SVN
no-re...@enlightenment.org wrote:
 Log:
 edbus: Add initializers to stop warnings

 Author:   englebass
 Date: 2012-10-20 21:52:59 -0700 (Sat, 20 Oct 2012)
 New Revision: 78292
 Trac: http://trac.enlightenment.org/e/changeset/78292

 Modified:
   trunk/edbus/src/lib/edbus_service.h

 Modified: trunk/edbus/src/lib/edbus_service.h
 ===
 --- trunk/edbus/src/lib/edbus_service.h 2012-10-21 04:25:32 UTC (rev 78291)
 +++ trunk/edbus/src/lib/edbus_service.h 2012-10-21 04:52:59 UTC (rev 78292)
 @@ -24,7 +24,7 @@
   * The signature will be ss and each string will have a tag name on
   * introspect XML with the respective name.
   */
 -#define EDBUS_ARGS(args...) (const EDBus_Arg_Info[]){ args, { } }
 +#define EDBUS_ARGS(args...) (const EDBus_Arg_Info[]){ args, { NULL, NULL } }

Nah... wrong fix. We don't use this warning on EDBus on purpose.


Lucas De Marchi

--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: englebass trunk/edbus/src/lib

2012-10-22 Thread Vincent Torri 
On Mon, Oct 22, 2012 at 4:57 PM, Lucas De Marchi
lucas.demar...@profusion.mobi wrote:
 On Sun, Oct 21, 2012 at 2:53 AM, Enlightenment SVN
 no-re...@enlightenment.org wrote:
 Log:
 edbus: Add initializers to stop warnings

 Author:   englebass
 Date: 2012-10-20 21:52:59 -0700 (Sat, 20 Oct 2012)
 New Revision: 78292
 Trac: http://trac.enlightenment.org/e/changeset/78292

 Modified:
   trunk/edbus/src/lib/edbus_service.h

 Modified: trunk/edbus/src/lib/edbus_service.h
 ===
 --- trunk/edbus/src/lib/edbus_service.h 2012-10-21 04:25:32 UTC (rev 78291)
 +++ trunk/edbus/src/lib/edbus_service.h 2012-10-21 04:52:59 UTC (rev 78292)
 @@ -24,7 +24,7 @@
   * The signature will be ss and each string will have a tag name on
   * introspect XML with the respective name.
   */
 -#define EDBUS_ARGS(args...) (const EDBus_Arg_Info[]){ args, { } }
 +#define EDBUS_ARGS(args...) (const EDBus_Arg_Info[]){ args, { NULL, NULL } }

 Nah... wrong fix. We don't use this warning on EDBus on purpose.

what about explaning that purpose ?

Vincent

--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: englebass trunk/edbus/src/lib

2012-10-22 Thread Lucas De Marchi 
On Mon, Oct 22, 2012 at 1:26 PM, Vincent Torri vincent.to...@gmail.com wrote:
 On Mon, Oct 22, 2012 at 4:57 PM, Lucas De Marchi
 lucas.demar...@profusion.mobi wrote:
 On Sun, Oct 21, 2012 at 2:53 AM, Enlightenment SVN
 no-re...@enlightenment.org wrote:
 Log:
 edbus: Add initializers to stop warnings

 Author:   englebass
 Date: 2012-10-20 21:52:59 -0700 (Sat, 20 Oct 2012)
 New Revision: 78292
 Trac: http://trac.enlightenment.org/e/changeset/78292

 Modified:
   trunk/edbus/src/lib/edbus_service.h

 Modified: trunk/edbus/src/lib/edbus_service.h
 ===
 --- trunk/edbus/src/lib/edbus_service.h 2012-10-21 04:25:32 UTC (rev 78291)
 +++ trunk/edbus/src/lib/edbus_service.h 2012-10-21 04:52:59 UTC (rev 78292)
 @@ -24,7 +24,7 @@
   * The signature will be ss and each string will have a tag name on
   * introspect XML with the respective name.
   */
 -#define EDBUS_ARGS(args...) (const EDBus_Arg_Info[]){ args, { } }
 +#define EDBUS_ARGS(args...) (const EDBus_Arg_Info[]){ args, { NULL, NULL } 
 }

 Nah... wrong fix. We don't use this warning on EDBus on purpose.

 what about explaning that purpose ?

This is allowed in C and that warning flag doesn't make sense at all.
If we ever extend EDBus_Arg_Info, we would need to keep adding NULLs
here. Look what that insanity pushes we to:

EWK_VIEW_SMART_CLASS_INIT in http://searchco.de/codesearch/view/10001195

Currently it contains 37 zeros (and counting...)!!
http://trac.webkit.org/browser/trunk/Source/WebKit/efl/ewk/ewk_view.h#L215

Although I don't envision such a change in EDBus_Arg_Info any time
soon, we heavily rely on this in other places and patches fixing
warnings like this have no benefit.

Lucas De Marchi

--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel