Re: [E-devel] Ecore Glib Integration
On 08/08/2013 07:27 PM, Christopher Michael wrote: I believe that I have discovered a problem with the glib integration into ecore main loop. Basically the issue is this: _ecore_main_fdh_poll_add is calling g_source_add_poll (which seems correct) BUT _ecore_main_fdh_poll_del is callback g_source_add_poll also (which smells wrong). Shouldn't that be doing g_source_remove_poll ?? Yeah, it looks wrong to me too. Looks like a copy and paste error introduced some time ago. Are you guys going to use the g_main_loop integration for something serious, or did you just spot a bug? thanks, Mike -- Get 100% visibility into Java/.NET code with AppDynamics Lite! It's a free troubleshooting tool designed for production. Get down to code-level detail for bottlenecks, with 2% overhead. Download for free and get started troubleshooting in minutes. http://pubads.g.doubleclick.net/gampad/clk?id=48897031iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Ecore Glib Integration
Random bug spotting in this case, though I can confirm that the integration is still totally functional. On Thu, Aug 8, 2013 at 12:03 PM, Mike McCormack m...@atratus.org wrote: On 08/08/2013 07:27 PM, Christopher Michael wrote: I believe that I have discovered a problem with the glib integration into ecore main loop. Basically the issue is this: _ecore_main_fdh_poll_add is calling g_source_add_poll (which seems correct) BUT _ecore_main_fdh_poll_del is callback g_source_add_poll also (which smells wrong). Shouldn't that be doing g_source_remove_poll ?? Yeah, it looks wrong to me too. Looks like a copy and paste error introduced some time ago. Are you guys going to use the g_main_loop integration for something serious, or did you just spot a bug? thanks, Mike -- Get 100% visibility into Java/.NET code with AppDynamics Lite! It's a free troubleshooting tool designed for production. Get down to code-level detail for bottlenecks, with 2% overhead. Download for free and get started troubleshooting in minutes. http://pubads.g.doubleclick.net/gampad/clk?id=48897031iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Get 100% visibility into Java/.NET code with AppDynamics Lite! It's a free troubleshooting tool designed for production. Get down to code-level detail for bottlenecks, with 2% overhead. Download for free and get started troubleshooting in minutes. http://pubads.g.doubleclick.net/gampad/clk?id=48897031iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Ecore Glib Integration
On 08/08/13 12:03, Mike McCormack wrote: On 08/08/2013 07:27 PM, Christopher Michael wrote: I believe that I have discovered a problem with the glib integration into ecore main loop. Basically the issue is this: _ecore_main_fdh_poll_add is calling g_source_add_poll (which seems correct) BUT _ecore_main_fdh_poll_del is callback g_source_add_poll also (which smells wrong). Shouldn't that be doing g_source_remove_poll ?? Yeah, it looks wrong to me too. Looks like a copy and paste error introduced some time ago. Indeed :) Are you ok if I fix this (use g_source_remove_poll there). Or are you already planning to fix this ?? Are you guys going to use the g_main_loop integration for something serious, or did you just spot a bug? thanks, Mike Just something I spotted randomly while researching something else ;) Cheers, dh -- Get 100% visibility into Java/.NET code with AppDynamics Lite! It's a free troubleshooting tool designed for production. Get down to code-level detail for bottlenecks, with 2% overhead. Download for free and get started troubleshooting in minutes. http://pubads.g.doubleclick.net/gampad/clk?id=48897031iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Ecore Glib Integration
On 08/08/2013 09:59 PM, Christopher Michael wrote: Are you ok if I fix this (use g_source_remove_poll there). Or are you already planning to fix this ?? Go ahead and fix it. I've just started a new job, and am a bit short on time right now. I did manage to get efl/ecore building (gah! bullet! dependencies! gah!) and will do some testing, but don't wait for me. Mike -- Get 100% visibility into Java/.NET code with AppDynamics Lite! It's a free troubleshooting tool designed for production. Get down to code-level detail for bottlenecks, with 2% overhead. Download for free and get started troubleshooting in minutes. http://pubads.g.doubleclick.net/gampad/clk?id=48897031iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Ecore Glib Integration
On 08/08/13 21:47, Mike McCormack wrote: On 08/08/2013 09:59 PM, Christopher Michael wrote: Are you ok if I fix this (use g_source_remove_poll there). Or are you already planning to fix this ?? Fixed upstream now :) Go ahead and fix it. I've just started a new job, and am a bit short on time right now. I did manage to get efl/ecore building (gah! bullet! dependencies! gah!) and will do some testing, but don't wait for me. Mike That's why --disable-physics is in all my build scripts ;) dh -- Get 100% visibility into Java/.NET code with AppDynamics Lite! It's a free troubleshooting tool designed for production. Get down to code-level detail for bottlenecks, with 2% overhead. Download for free and get started troubleshooting in minutes. http://pubads.g.doubleclick.net/gampad/clk?id=48897031iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
