Re: [E-devel] snaps
On Sat, 15 Jan 2011 09:01:08 +0100 Michael Taubert said: > Well, as this discussion arised, I would like to ask for comments, hints, or > tips for http://obs.scyphodroid.de:82/ > > There are my packages I've build for openSUSE 11.2/3 that I'm using. I'm not > that skilled packager, so you probably will find something to improve. > > I thought about to update these packages on an occasional base from svn. I'm > going to use these packages primary for enna development. > > But please be aware that this is a very small vserver. I'm not sure about how > much traffic it will stand. :) > > best regards, > Michael you'll want to now use 1.0 release :) also keep track of bugfix releases - 1.0.1, 1.0.2 etc. etc. - package and release those when they roll around. :) -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] elm_label patch(bugfix of key_value_replace func)
On Thu, 13 Jan 2011 16:10:23 +0900 Hyoyoung Chang said: how does this relate to your patches from 11/01/2011 with wrap mode stuff? i see some potential overlap. is the re a chance you can collect this patch and those from the 11th of jan int a patch set that also implement enums? > Dear Elementary developers. > > It's a bugfix patch at elm_label. > Revised some char iteration and fix potential null ptr ref in > strbuf_key_value_replace. > > Thank you. > > --- > Hyoyoung CHANG > Engineer > > SAMSUNG ELECTRONICS, Co., Ltd. > E-mail: hyoyoung.ch...@samsung.com > --- > -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] FOSDEM 2011
On Fri, 14 Jan 2011 11:49:30 +0100 Nicolas Aguirre said: > Hi, > > FOSDEM will take place in 3 weeks now in Brussel, the 5-6 February 2011. and just in time... EFL 1.0 :) > As some of you already know, Enlightenment will have a stand. Most of > members of the french association will be there, and if more E devs > and users we will be there we will be pleased to meet them and share > our ideas and dreams about this so beautifull project. (Or at least > take a drink :)) wish i could be there - but schedules have conspired to not allow that. good luck though and all the best! :) > If you want to help us for the stand, let us know. > > We would like to present the best of Efl and E's world on the stand. > And in this way, I would like to know what kind of goodies we could > present to visitors, what's your feeling about that. > > I think a regular x86 PC with the last version of E installed is a good start. > Softwares installed on it : eve, enjoy, enki, enna, calaos, ephoto, > rage and of course E17. > > I hope that I will be able to have SHR running natively on an HTC > Desire and thus present Illume profile and EFL on embedded devices. > Well it's more or less already the case, but i need more work to have > something presentable on Desire. > > If someone have a Touchscreen it could be a good point for a > demonstration of Calaos, Eve and Enna. (minimal resolution for Calaos > 1024x768) > > I know that Vincent is working hard on his shoot'em up and setting up > a demo on his wince device, that could be another demo of EFL in > embedded world. > > Did you have more ideas about demos that we could present ? More software ? > As usual the network connection in the University will not be > reliable, so we will have to install everything before FOSDEM ! > If someone could have a mirror of the E SVN on an usb disk, it's could be > good. > > Who want to be in charge of different devices and demos ? > Someone has more devices to show with E technos, more softwares ? > > I'm wainting for your good ideas ! > -- > Nicolas Aguirre > Mail: aguirre.nico...@gmail.com > Web: http://www.digital-corner.org > > -- > Protect Your Site and Customers from Malware Attacks > Learn about various malware tactics and how to avoid them. Understand > malware threats, the impact they can have on your business, and how you > can protect your company and customers by using code signing. > http://p.sf.net/sfu/oracle-sfdevnl > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] patch for ecore function used to change the backlight property
On Sun, 16 Jan 2011 16:18:10 +0100 (CET) mathieu.taillefum...@free.fr said: > Hello, > > I wrote three additional functions allowing us yo change the backlight > properties of the screes supporting it. I discover that the functions are > already declared in the headers files but the code was not added so far. The > patch is simple and should be directly applied in the directory > src/lib/ecore_x/xlib after reviewing it. I am open for comments and > suggestions for improving these three functions. ok ecore 1.0 is out. this can now go into ecore 1.1 dev (trunk). first.. patch is broken. - just some errors: ecore_x_randr_12.c: In function ‘ecore_x_randr_screen_backlight_level_set’: ecore_x_randr_12.c:1919: error: ‘_backlight’ undeclared (first use in this function) ecore_x_randr_12.c:1919: error: (Each undeclared identifier is reported only once ecore_x_randr_12.c:1919: error: for each function it appears in.) ecore_x_randr_12.c: In function ‘ecore_x_randr_output_backlight_level_get’: ecore_x_randr_12.c:1967: error: ‘_backlight’ undeclared (first use in this function) ecore_x_randr_12.c: In function ‘ecore_x_randr_output_backlight_level_set’: ecore_x_randr_12.c:2012: warning: ‘return’ with no value, in function returning non-void ecore_x_randr_12.c:2014: error: ‘_backlight’ undeclared (first use in this function) make: *** [ecore_x_randr_12.lo] Error 1 where do you get _backlight from? > I should indicate that I plan to create a module for e17 which controls the > backlight properties but in order to do that I would like to ask a question. that's cool! and you'd need the ecore support for it to work - fine. > I would like to add a timer in this module in order decrease the backlight to > a lower value after 10 seconds of activity for instance. For course the timer > should be deactivited when the keyboard or the mouse are used but > unfortunately I do not know how to create such timer. ecore_timer_add() - grep fore that call all through any code. easy to find examples. but you need to know when inactivity has happened. for that you'd need to look at the xscreensaver extension - you can get idle timeout events. you could also poll every few seconds and get current idle time with ecore_x_screensaver_idle_time_get(); (returns idle time in seconds) -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] elm_transit
On Mon, 17 Jan 2011 16:26:33 +0900 ChunEon Park said: > Here is a minor patch for elm_transit > (indentation & removed unuseful calls - evas_map_smooth_set) in - though man thats a lot of whitespace changing. -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] elm_label patch(bugfix of key_value_replace func)
On Mon, 2011-01-31 at 16:48 +0900, Carsten Haitzler wrote: > how does this relate to your patches from 11/01/2011 with wrap mode stuff? i > see some potential overlap. is the re a chance you can collect this patch and > those from the 11th of jan int a patch set that also implement enums? wrap mode? what patches did he have with wrap mode? -- Tom. -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch] environment parameter - ELM_EFFECT_ENABLE
On Mon, 17 Jan 2011 10:44:51 + (GMT) Jae Hwan Kim
said:
almost right.. you missed adding it to illme and standard profile configs. i
did that for you. in svn.
>
> Hello.
>
> I'm Jaehwan Kim.
>
> I want to add the environment parameter "ELM_EFFECT_ENABLE".
> It will play a role as the enablement for the effect of all widget.
>
> The patch is the following.
>
> Thanks.
>
>
>
> Index: src/lib/elm_config.c
> ===
> --- src/lib/elm_config.c (revision 56080)
> +++ src/lib/elm_config.c (working copy)
> @@ -597,6 +597,7 @@ _desc_init(void)
> ELM_CONFIG_VAL(D, T, inwin_dialogs_enable, T_UCHAR);
> ELM_CONFIG_VAL(D, T, icon_size, T_INT);
> ELM_CONFIG_VAL(D, T, longpress_timeout, T_DOUBLE);
> + ELM_CONFIG_VAL(D, T, effect_enable, T_UCHAR);
> #undef T
> #undef D
> #undef T_INT
> @@ -1136,6 +1137,7 @@ _config_load(void)
> _elm_config->inwin_dialogs_enable = EINA_FALSE;
> _elm_config->icon_size = 32;
> _elm_config->longpress_timeout = 1.0;
> + _elm_config->effect_enable = EINA_TRUE;
> }
>
> static const char *
> @@ -1557,6 +1559,9 @@ _env_get(void)
> if (s) _elm_config->longpress_timeout = atof(s);
> if (_elm_config->longpress_timeout < 0.0)
> _elm_config->longpress_timeout = 0.0;
> +
> + s = getenv("ELM_EFFECT_ENABLE");
> + if (s) _elm_config->effect_enable = !!atoi(s);
> }
>
> void
> Index: src/lib/elm_priv.h
> ===
> --- src/lib/elm_priv.h(revision 56080)
> +++ src/lib/elm_priv.h(working copy)
> @@ -111,6 +111,7 @@ struct _Elm_Config
> Eina_Boolinwin_dialogs_enable;
> int icon_size;
> double longpress_timeout;
> + Eina_Booleffect_enable;
> };
>
> struct _Elm_Module
> Index: config/default/base.src
> ===
> --- config/default/base.src (revision 56080)
> +++ config/default/base.src (working copy)
> @@ -34,4 +34,5 @@ group "Elm_Config" struct {
>value "inwin_dialogs_enable" uchar: 1;
>value "icon_size" int: 32;
>value "longpress_timeout" double: 1.0;
> + value "effect_enable" uchar: 1;
> }
> --
> Protect Your Site and Customers from Malware Attacks
> Learn about various malware tactics and how to avoid them. Understand
> malware threats, the impact they can have on your business, and how you
> can protect your company and customers by using code signing.
> http://p.sf.net/sfu/oracle-sfdevnl
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com
--
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires
February 28th, so secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsight-sfd2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch] environment parameter - ELM_EFFECT_ENABLE
On Tue, 18 Jan 2011 11:12:31 -0200 Gustavo Sverzut Barbieri said: > On Tue, Jan 18, 2011 at 3:11 AM, Jaehwan Kim wrote: > > I understood your suggestion. > > But I want to change the enablement of all widget effect at a time. > > In the setting application like elementary_config, > > if I set effect-off, the effects of all widget are unable. > > Can I implement it with theme parameter? > > As I said, you'll have to change the theme. Elementary_config can > change that, and the theme_hook is already there. You'd have to react > to all of that, also implementing signals to notify the theme to not > do effects in Edje/Embryo. i was thinking that in future we could have a shared "variables" blob too - to avoid needing signals. themes can access this. as such adding this conf var seems like a prudent future-feature - but you are right - it needs more work at various levels to get the information to all the things that implement effects. -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch] elm_genlist patch for group index handling and bug fix
On Tue, 18 Jan 2011 19:10:05 +0900 Daniel Juyung Seo said: thanks! in svn! > Hello, > I attached a small patch for elm_genlist.c > > 1. _item_block_position() fix > This patch realizes group index even there is no sub-items. > There was a request about this. > And it shows that there is no sub-items explicitly. > > 2. Bug Fix > Null check routine was wrong-placed. > I fixed it. > > Thank you. > Daniel Juyung Seo (SeoZ) -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] some bug fix patches
On Fri, 21 Jan 2011 15:18:08 +0900 ChunEon Park said: in svn. :) > Here is the patch again. > > Because the original file is seemed to have somewhat different indentation, > the patch file had a while spaces > even I didn't intend to apply the white space. > > I had to check it again. > > So... > > Please review then apply it. > > Thanks. > > > -Original Message- > From: Daniel Juyung Seo [mailto:seojuyu...@gmail.com] > Sent: Friday, January 21, 2011 11:41 AM > To: Lucas De Marchi > Cc: ChunEon Park; enlightenment-devel@lists.sourceforge.net > Subject: Re: [E-devel] some bug fix patches > > Right. > It looks wrong to me too. > Spank Hermet! > > Daniel Juyung Seo (SeoZ) > > On Fri, Jan 21, 2011 at 10:04 AM, Lucas De Marchi > wrote: > > Hi Hermet > > > > On Wed, Jan 19, 2011 at 9:32 AM, ChunEon Park > wrote: > >> Hi, This is Hermet. > >> > >> Here are simple patches for invalid pointers > >> > >> Please review then apply them. > > > > Patches 001_eet.patch.txt and 002_evas.patch.txt were applied. > > > > > > Patch 001_evas.patch.txt does not look right. Besides the trailing > > whitespaces, it doesn't make sense. Maybe you forgot to save your > > changes before sending? > > > > > > thanks for taking care of this > > > > > > Lucas De Marchi > > > > > > -- > > Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! > > Finally, a world-class log management solution at an even better > price-free! > > Download using promo code Free_Logger_4_Dev2Dev. Offer expires > > February 28th, so secure your free ArcSight Logger TODAY! > > http://p.sf.net/sfu/arcsight-sfd2d > > ___ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch] small patch for elm_main.c
On Wed, 19 Jan 2011 18:31:42 +0900 WooHyun Jung said: you're right! if you have no windows some caches won't be able to be flushed :) in svn! > Hello ~ > > I made small patch for elm_main.c > > In elm_all_flush function, I was suspicious about, > > if _elm_win_list is NULL then following codes should not be called or not. > > > > ejde_file_cache_flush(); > > edje_collection_cache_flush(); > > eet_clearcache(); > > > > I thinks above functions should be called without any consideration about > the state of _elm_win_list. > > Can anybody check about this ? > > Thanks. > -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] elc_ctxpopup
On Thu, 20 Jan 2011 13:40:51 +0900 ChunEon Park said: in svn - though a description of what it fixes would have been nice... :) > Hi, Here is a simple patch for elc_ctxpopup > > Please check then apply it. > > Thanks. > > > Best Regards, > Hermet -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] elm_label patch(bugfix of key_value_replace func)
On Mon, 31 Jan 2011 10:11:52 +0200 Tom Hacohen said: > On Mon, 2011-01-31 at 16:48 +0900, Carsten Haitzler wrote: > > how does this relate to your patches from 11/01/2011 with wrap mode stuff? i > > see some potential overlap. is the re a chance you can collect this patch > > and those from the 11th of jan int a patch set that also implement enums? > > wrap mode? what patches did he have with wrap mode? previous patches added more wrap mode api's and suggested was to make wrap mode an enum - they did several things. this patch seems to play around with the same code as the previous set on a quick scan. i want to know if they will be all coming as a new set. -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] elm_label patch(bugfix of key_value_replace func)
Yeah yeah, I understand now. On Mon, 2011-01-31 at 18:02 +0900, Carsten Haitzler wrote: > On Mon, 31 Jan 2011 10:11:52 +0200 Tom Hacohen > said: > > > On Mon, 2011-01-31 at 16:48 +0900, Carsten Haitzler wrote: > > > how does this relate to your patches from 11/01/2011 with wrap mode > > > stuff? i > > > see some potential overlap. is the re a chance you can collect this patch > > > and those from the 11th of jan int a patch set that also implement enums? > > > > wrap mode? what patches did he have with wrap mode? > > previous patches added more wrap mode api's and suggested was to make wrap > mode > an enum - they did several things. this patch seems to play around with the > same code as the previous set on a quick scan. i want to know if they will be > all coming as a new set. > -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] ecore_file_download() seems broken here
Ok, I rechecked the ecore_file_download() function: On ubuntu it works well now, but on fedora14 is still BROKEN, same behavior of the last week: the function report that the download has started, but nothing is downloaded and no callbacks are called (neither progress_cb or done_cb) The version of curl is the same on both ubuntu and fedora... what else can I check? DaveMDS 2011/1/27 Dave Andreoli : > Hi guys! > > Bad problem just before the release... :( > > On my Fedora14 ecore_file_download() is broken, > the completion/progress callbacks are never called. I can see > this in my applications, in the "elementary map test" and in the > python-ecore example: examples/file/01_ecore_file_download.py > > Download seem to start (no error on start), the "http://"; protocol is > available, but no callbacks are called :/ > > To be sure it's not a problem of mine I'm setting up 3 virtual machine > with clean os, Debian5, Ubuntu10.10 and Fedora14. They will be ready > this evening. > > No one spot the same problem? Can someone give it a try? > > Thanks > DaveMDS > -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch] els_scroller - Cannot click even if it reach to end
On Thu, 20 Jan 2011 07:28:20 + (GMT) 김재환 said:
yes indeed. insivible bounce anim is running and doing nothing - stopping
clicks on inside objects until its over. fixed. in svn! tnx!
>
> Hello all,
>
> I have another issue in scroller when the bounce is off.
> Scroller cannot be clicked even if it reach to edge and animation is end.
> The reason is why the momentum animation is running even if it reach end and
> bounce animation is off. So I change the code that if it reach the edge in
> case of bounce-off, the momentum animation is stoped. The following is the
> patch code. Please check it.
>
> Thanks.
>
>
> Index: src/lib/els_scroller.c
> ===
> --- src/lib/els_scroller.c(revision 56235)
> +++ src/lib/els_scroller.c(working copy)
> @@ -690,6 +690,7 @@ _smart_momentum_animator(void *data)
> Smart_Data *sd;
> double t, dt, p;
> Evas_Coord x, y, dx, dy, px, py, maxx, maxy, minx, miny;
> + Eina_Bool no_bounce_x_end = EINA_FALSE, no_bounce_y_end = EINA_FALSE;
>
> sd = data;
> t = ecore_loop_time_get();
> @@ -738,8 +739,19 @@ _smart_momentum_animator(void *data)
> elm_smart_scroller_child_pos_set(sd->smart_obj, x, y);
> sd->pan_func.max_get(sd->pan_obj, &maxx, &maxy);
> sd->pan_func.min_get(sd->pan_obj, &minx, &miny);
> + if (!sd->bounce_horiz)
> + {
> + if (x <= minx) no_bounce_x_end = EINA_TRUE;
> + if ((x - minx) >= maxx) no_bounce_x_end = EINA_TRUE;
> + }
> +if (!sd->bounce_vert)
> + {
> + if (y <= miny) no_bounce_y_end = EINA_TRUE;
> + if ((y - miny) >= maxy) no_bounce_y_end = EINA_TRUE;
> + }
> if ((dt >= 1.0) ||
> -((sd->down.bounce_x_hold) && (sd->down.bounce_y_hold)))
> +((sd->down.bounce_x_hold) && (sd->down.bounce_y_hold)) ||
> +(no_bounce_x_end && no_bounce_y_end))
> {
> _smart_anim_stop(sd->smart_obj);
>sd->down.momentum_animator = NULL;
> --
> Protect Your Site and Customers from Malware Attacks
> Learn about various malware tactics and how to avoid them. Understand
> malware threats, the impact they can have on your business, and how you
> can protect your company and customers by using code signing.
> http://p.sf.net/sfu/oracle-sfdevnl
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com
--
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires
February 28th, so secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsight-sfd2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch] els_scroller - elm_smart_scroller_child_region_show
On Thu, 20 Jan 2011 06:35:24 + (GMT) Jae Hwan Kim
said:
you are right with your cases. the intent is that when a widget gets focused -
it is made visible IF it is not fully visible. in some cases its impossible to
make ti fully visible (object exceeds scroller bounds in size), so there is
little point moving the scroller at all. so leave it as-is. patch applied to
svn. thanks!
>
> Hello all,
>
> I have some issue in scroller.
> Sometimes the scroller move to wrong region when the child get first focus.
> It use "scroller -> layout -> button".
> So I checked the code and found a suspected thing in
> elm_smart_scroller_child_region_show. Please refer following pictures.
>
> In the pictures, the rect which be written "x, y, w, h" is the area
> which be made with the parameters of "elm_smart_scroller_child_region_show".
> The rect which be written "Pan" is the pan area of the scroller.
>
> If the situation is 1) or 2) and the function is called, the result have to
> be 7). In case of 3) or 4), it have to be 8).
> In case of 5) or 6), it have to remain as it is.
> Is it right??
>
> But if the situation is 6) and the function is called, the result will be 7)
> in current code. I think it is wrong.
> I attached patch code. please find it below the pictures.
> Please check it.
>
> Thanks.
>
> 1)
> ---
> ||
> | x, y, w, h |
> ||
> ---
> -
> | |
> | |
> | |
> |Pan |
> | |
> | |
> | |
> -
>
> 2)
> ---
> ||
> | x, y, w, h |
> -
> | || |
> | --- |
> | |
> |Pan |
> | |
> | |
> | |
> -
>
> 3)
> -
> | |
> | |
> | |
> |Pan |
> | |
> | --- |
> | | ||
> -
> | x, y, w, h |
> ||
> ---
>
> 4)
> -
> | |
> | |
> | |
> |Pan |
> | |
> | |
> | |
> -
> ---
> ||
> | x, y, w, h |
> ||
> ---
>
> 5)
> -
> | |
> | --- |
> | || |
> | | x, y, w, h | |
> | || |
> | --- |
> |Pan |
> -
>
> 6)
> ---
> ||
> - <---Pan
> | | ||
> | | x, y, w, h ||
> | | ||
> -
> ||
> ---
>
> 7)
> -
> | || |
> | | x, y, w, h | |
> | || |
> | --- |
> | |
> |Pan |
> | |
> -
>
> 8)
> -
> | |
> |Pan |
> | |
> | --- |
> | || |
> | | x, y, w, h | |
> | || |
> -
>
> Patch Code
> --
>
> Index: src/lib/els_scroller.c
> ===
> --- src/lib/els_scroller.c(revision 56235)
> +++ src/lib/els_scroller.c(working copy)
> @@ -928,19 +928,11 @@ elm_smart_scroller_child_region_show(Evas_Object *
> sd->pan_func.get(sd->pan_obj, &px, &py);
>
> nx = px;
> - if (x < px) nx = x;
> - else if ((x + w) > (px + (cw - mx)))
> - {
> - nx = x + w - (cw - mx);
> - if (nx > x) nx = x;
> - }
> + if ((x < px) && ((x + w) < (px + (cw - mx nx = x;
> + else if ((x > px) && ((x + w) > (px + (cw - mx nx = x + w - (cw - mx);
> ny = py;
> - if (y < py) ny = y;
> - else if ((y + h) > (py + (ch - my)))
> - {
> - ny = y + h - (ch - my);
> - if (ny > y) ny = y;
> - }
> + if ((y < py) && ((y + h) < (py + (ch - my ny = y;
> + else if ((y > py) && ((y + h) > (py + (ch - my ny = y + h - (ch - my);
> i
Re: [E-devel] [Patch] Removed dead code in elm_genlist.c
On Fri, 21 Jan 2011 11:56:12 +0900 Daniel Juyung Seo said: tnx! in svn! > Hello, > I removed dead macro LONGPRESS_TIMEOUT. > Genlist's longpress_time value is read from _elm_config->longpress_timeout. > > Can anybody please apply this to upstream? > > Thanks. > Daniel Juyung Seo (SeoZ) -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch] elm_genlist patch regarding inlist
On Fri, 21 Jan 2011 20:30:27 +0900 Sohyun Kim said: yup. correct. in svn! :) > Hi, > > I made a patch for elm_genlist. > For getting genlist item from inlist, ELM_GENLIST_ITEM_FROM_INLIST macro > should be used. > > Regards, Sohyun. > -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch] genlist item cache exception handling patch
On Tue, 25 Jan 2011 12:18:29 +0900 Daniel Juyung Seo said: > Hello, > I added "no cached item" handling. > In some case, items should not be cached and should not use caches. hmm indeed change in item class can change the style. interesting that you are doing that. :) > For example, > if there was a state change in item style, it should not be cached > because it remembers the state changes. > And if we use elm_genlist_item_item_class_update() API, > item should not be cached as well. > It needs to be a fresh item style without remembering the state changes. > > Anybody please review this and apply it to upstream code. > > Ps. Btw, there are three pending genlist patches on mailing list other than > this email. > 1. Jan 21 (Sohyun Kim) : [E-devel] [Patch] elm_genlist patch regarding > inlist > 2. Jan 21 (Daniel Juyung Seo) : [E-devel] [Patch] Removed dead code in > elm_genlist.c > 3. Jan 18 (Daniel Juyung Seo) : [E-devel] [Patch] elm_genlist patch for > group index handling and bug fix > Please review them as well. They are small patches :) > > Thanks. > Daniel Juyung Seo (SeoZ) -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch] patch for elm_module
On Tue, 25 Jan 2011 14:46:04 +0900 WooHyun Jung said: i guess thats ok - though i doubt it makes a signficant difference :) in svn! > Hello. > > Mr. Wonguk Jeong made a patch for elm_module. > > This patch is for changing the timing of module loading. > > > > For now, module loading is done in elm_init > > Thus, modules are always loaded, even if the application does not use them. > > > > So this patch deferred the timing of module loading to > "_elm_module_find_as". > > > > Can anyone check about this ? > > Thanks. > -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] Handle ecore signals with a pipe
On Tue, 25 Jan 2011 13:52:22 +0900 Mike McCormack said: > On 01/25/2011 12:10 PM, Lucas De Marchi wrote: > > On Mon, Jan 24, 2011 at 9:56 AM, Mike McCormack > > wrote: > >> > >> The way ecore handles signals is racy. > >> The attached patch uses a pipe to avoid races between signals and > >> select/poll(). > > > > Couldn't we use signalfd instead? It's the most clean way I know. > > Clean, but not portable, as I understand. I could add it with a fallback > to the pipe method. > > There's actually quite a bit of cleaning up to do for ecore signal handling. > > I'm not even sure that it's a good idea for a library (or framework) to > be messing with signal handlers without an explicit request from the > application using it. > > >> A fix for before or after 1.0...? > > > > After, for sure. > > I agree. Was testing the general consensus. Will queue this and work on > cleaning up the rest of it. got a cleaned up patch? yours doesnt apply at all. also i think you removed most but not all the handlers. _ecore_signal_callback_sigrt still had a prototype at any rate reading your diff. -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] elm_transit
On Sat, 22 Jan 2011 21:53:01 +0900 ChunEon Park said: hmm this didnt apply - but i could do it manually as its a small patch. odd. your previous whitespace changes were probably not accounted for. > Hello. > > > > Here is a simple elm_transit.c patch > > > > Please check then apply it. > > > > Thanks. > > > > Best Regards, > > Hermet > -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] ecore_file_download() seems broken here
On Mon, 31 Jan 2011 10:49:14 +0100 Dave Andreoli said: > Ok, I rechecked the ecore_file_download() function: > > On ubuntu it works well now, but on fedora14 is still BROKEN, > same behavior of the last week: > the function report that the download has started, but nothing > is downloaded and no callbacks are called (neither progress_cb or > done_cb) > > The version of curl is the same on both ubuntu and fedora... > what else can I check? now there i can't say why - it's working on unbooty here just fine. i dont have any fedora systems set up to test on - perhaps a curl bug that ubuntu/debian patched? i don't know. > DaveMDS > > > 2011/1/27 Dave Andreoli : > > Hi guys! > > > > Bad problem just before the release... :( > > > > On my Fedora14 ecore_file_download() is broken, > > the completion/progress callbacks are never called. I can see > > this in my applications, in the "elementary map test" and in the > > python-ecore example: examples/file/01_ecore_file_download.py > > > > Download seem to start (no error on start), the "http://"; protocol is > > available, but no callbacks are called :/ > > > > To be sure it's not a problem of mine I'm setting up 3 virtual machine > > with clean os, Debian5, Ubuntu10.10 and Fedora14. They will be ready > > this evening. > > > > No one spot the same problem? Can someone give it a try? > > > > Thanks > > DaveMDS > > > > -- > Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! > Finally, a world-class log management solution at an even better price-free! > Download using promo code Free_Logger_4_Dev2Dev. Offer expires > February 28th, so secure your free ArcSight Logger TODAY! > http://p.sf.net/sfu/arcsight-sfd2d > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Enlightenment @ Cebit 2011
On Sat, 29 Jan 2011 12:02:43 +0100 Leif Middelschulte said: yes - free badges. accommodation, travel etc. - so far undiscussed. no meeting point yet, but that's a "final detail" i'd say. as of right now it's everybody's own responsibility to get to the show, but as i said - thats as of right now. nothing discussed yet. i'd say it's open to discussion and options. this all depends on who wants to come - how many, etc. etc. i guess. we need to decide relatively soon i'd say - so.. i hope everyone who is interested will speak up here in this thread. ping anyone you think should know or be interested. > Hey, > > I'd join as well. When will you guys be there? Is there any meeting > point/date/place yet? > Same question: Do we get free badges in order to help out at the booth? > > BR, > > Leif > > 2011/1/28 Andreas Volz : > > Am Thu, 27 Jan 2011 13:09:26 +0900 schrieb Carsten Haitzler (The > > Rasterman): > > > >> Just thought I'd pipe up here. Getting organised. > >> > >> Thanks to linux-magazin E gets some booth space @ Cebit 2011. Who > >> wants to join in? By this i mean - who wants to help "hang out" at > >> the booth? It's held march 1-5 in Hannover in germany. It's a pretty > >> big show and will be busy. I'll end up there all week - anyone > >> interested in coming... speak up! :) > > > > I'm from germany (300 km distance) and thought about joining. Car > > traveling costs aren't relevant for me, but I'm interested about other > > expenses. I looked for a hotel booking around this time in hannover and > > it costs ~100-200€/night. Do you've any idea about Cebit ticket costs? > > > > regards > > Andreas > > > > -- > > Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! > > Finally, a world-class log management solution at an even better price-free! > > Download using promo code Free_Logger_4_Dev2Dev. Offer expires > > February 28th, so secure your free ArcSight Logger TODAY! > > http://p.sf.net/sfu/arcsight-sfd2d > > ___ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > -- > Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! > Finally, a world-class log management solution at an even better price-free! > Download using promo code Free_Logger_4_Dev2Dev. Offer expires > February 28th, so secure your free ArcSight Logger TODAY! > http://p.sf.net/sfu/arcsight-sfd2d > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Enlightenment @ Cebit 2011
On Fri, 28 Jan 2011 22:23:04 +0100 Andreas Volz said: > Am Thu, 27 Jan 2011 13:09:26 +0900 schrieb Carsten Haitzler (The > Rasterman): > > > Just thought I'd pipe up here. Getting organised. > > > > Thanks to linux-magazin E gets some booth space @ Cebit 2011. Who > > wants to join in? By this i mean - who wants to help "hang out" at > > the booth? It's held march 1-5 in Hannover in germany. It's a pretty > > big show and will be busy. I'll end up there all week - anyone > > interested in coming... speak up! :) > > I'm from germany (300 km distance) and thought about joining. Car > traveling costs aren't relevant for me, but I'm interested about other > expenses. I looked for a hotel booking around this time in hannover and > it costs ~100-200€/night. Do you've any idea about Cebit ticket costs? well here is what i know for sure - if you are going to volunteer to help out - there's free entry of course to the show as you'll get passes to come in. right now beyond that nothing has been planned or discussed. -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Enlightenment @ Cebit 2011
On Thu, 27 Jan 2011 17:27:49 +0100 Simon Busch said: > On 27.01.2011 05:09, Carsten Haitzler (The Rasterman) wrote: > > Just thought I'd pipe up here. Getting organised. > > > > Thanks to linux-magazin E gets some booth space @ Cebit 2011. Who wants to > > join in? By this i mean - who wants to help "hang out" at the booth? It's > > held march 1-5 in Hannover in germany. It's a pretty big show and will be > > busy. I'll end up there all week - anyone interested in coming... speak > > up! :) > > > > I will be there but don't have time to "hang out" at the booth. But I > would really like to meet some of e17 hackers at the Cebit! well listen in for more details. -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Enlightenment @ Cebit 2011
On Wed, 26 Jan 2011 23:28:06 -0500 Mike Blumenkrantz said: > On Thu, 27 Jan 2011 13:09:26 +0900 > Carsten Haitzler (The Rasterman) wrote: > > > Just thought I'd pipe up here. Getting organised. > > > > Thanks to linux-magazin E gets some booth space @ Cebit 2011. Who wants to > > join in? By this i mean - who wants to help "hang out" at the booth? It's > > held march 1-5 in Hannover in germany. It's a pretty big show and will be > > busy. I'll end up there all week - anyone interested in coming... speak > > up! :) > > > Me, possibly! Have to check my schedule around that time, but if I'm around > it would be cool to go. Plus I've never been to Germany :) beer. bretzels. fried up stuff. potatoes. yum. :) -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: englebass IN trunk/efreet: . src/lib
On Mon, Jan 31, 2011 at 12:27 PM, Enlightenment SVN
wrote:
> Log:
> Fix memleak
Shouldn't that patch be backported to 1.0 branch also ?
> Author: englebass
> Date: 2011-01-31 03:27:46 -0800 (Mon, 31 Jan 2011)
> New Revision: 56587
> Trac: http://trac.enlightenment.org/e/changeset/56587
>
> Modified:
> trunk/efreet/ChangeLog trunk/efreet/src/lib/efreet_icon.c
>
> Modified: trunk/efreet/ChangeLog
> ===
> --- trunk/efreet/ChangeLog 2011-01-31 10:47:53 UTC (rev 56586)
> +++ trunk/efreet/ChangeLog 2011-01-31 11:27:46 UTC (rev 56587)
> @@ -9,3 +9,7 @@
> 2011-01-30 Carsten Haitzler (The Rasterman)
>
> Fix tests to not build clearenv related code if not available
> +
> +2011-01-31 Sebastian Dransfeld
> +
> + * Fix memleak, free cache icons after retrival
>
> Modified: trunk/efreet/src/lib/efreet_icon.c
> ===
> --- trunk/efreet/src/lib/efreet_icon.c 2011-01-31 10:47:53 UTC (rev 56586)
> +++ trunk/efreet/src/lib/efreet_icon.c 2011-01-31 11:27:46 UTC (rev 56587)
> @@ -456,6 +456,7 @@
> cache = efreet_cache_icon_find(theme, tmp);
> value = efreet_cache_icon_lookup_icon(cache, size);
> if (!value) INFO("lookup for `%s` failed in theme `%s` with %p.",
> icon, theme_name, cache);
> + efreet_cache_icon_free(cache);
> #else
> value = efreet_icon_find_helper(theme, tmp, size);
> #endif
> @@ -476,6 +477,7 @@
> cache = efreet_cache_icon_fallback_find(icon);
> value = efreet_cache_icon_fallback_lookup_path(cache);
> if (!value) INFO("lookup for `%s` failed in fallback too with %p.",
> icon, cache);
> + efreet_cache_icon_fallback_free(cache);
> }
> #else
> value = efreet_icon_fallback_icon(icon);
> @@ -541,6 +543,7 @@
> if (!strcmp(cache->theme, theme->name.internal))
> {
> value = efreet_cache_icon_lookup_icon(cache, size);
> + efreet_cache_icon_free(cache);
> break;
> }
> else
>
>
> --
> Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
> Finally, a world-class log management solution at an even better price-free!
> Download using promo code Free_Logger_4_Dev2Dev. Offer expires
> February 28th, so secure your free ArcSight Logger TODAY!
> http://p.sf.net/sfu/arcsight-sfd2d
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
>
--
Cedric BAIL
--
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires
February 28th, so secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsight-sfd2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: englebass IN trunk/efreet: . src/lib
On 01/31/2011 01:08 PM, Cedric BAIL wrote:
> On Mon, Jan 31, 2011 at 12:27 PM, Enlightenment SVN
> wrote:
>> Log:
>> Fix memleak
>
> Shouldn't that patch be backported to 1.0 branch also ?
Yup.
Working on it.
Sebastian
>
>> Author: englebass
>> Date: 2011-01-31 03:27:46 -0800 (Mon, 31 Jan 2011)
>> New Revision: 56587
>> Trac: http://trac.enlightenment.org/e/changeset/56587
>>
>> Modified:
>> trunk/efreet/ChangeLog trunk/efreet/src/lib/efreet_icon.c
>>
>> Modified: trunk/efreet/ChangeLog
>> ===
>> --- trunk/efreet/ChangeLog 2011-01-31 10:47:53 UTC (rev 56586)
>> +++ trunk/efreet/ChangeLog 2011-01-31 11:27:46 UTC (rev 56587)
>> @@ -9,3 +9,7 @@
>> 2011-01-30 Carsten Haitzler (The Rasterman)
>>
>> Fix tests to not build clearenv related code if not available
>> +
>> +2011-01-31 Sebastian Dransfeld
>> +
>> + * Fix memleak, free cache icons after retrival
>>
>> Modified: trunk/efreet/src/lib/efreet_icon.c
>> ===
>> --- trunk/efreet/src/lib/efreet_icon.c 2011-01-31 10:47:53 UTC (rev 56586)
>> +++ trunk/efreet/src/lib/efreet_icon.c 2011-01-31 11:27:46 UTC (rev 56587)
>> @@ -456,6 +456,7 @@
>> cache = efreet_cache_icon_find(theme, tmp);
>> value = efreet_cache_icon_lookup_icon(cache, size);
>> if (!value) INFO("lookup for `%s` failed in theme `%s` with %p.",
>> icon, theme_name, cache);
>> +efreet_cache_icon_free(cache);
>> #else
>> value = efreet_icon_find_helper(theme, tmp, size);
>> #endif
>> @@ -476,6 +477,7 @@
>> cache = efreet_cache_icon_fallback_find(icon);
>> value = efreet_cache_icon_fallback_lookup_path(cache);
>> if (!value) INFO("lookup for `%s` failed in fallback too with %p.",
>> icon, cache);
>> +efreet_cache_icon_fallback_free(cache);
>> }
>> #else
>> value = efreet_icon_fallback_icon(icon);
>> @@ -541,6 +543,7 @@
>> if (!strcmp(cache->theme, theme->name.internal))
>> {
>> value = efreet_cache_icon_lookup_icon(cache, size);
>> +efreet_cache_icon_free(cache);
>> break;
>> }
>> else
>>
>>
>> --
>> Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
>> Finally, a world-class log management solution at an even better price-free!
>> Download using promo code Free_Logger_4_Dev2Dev. Offer expires
>> February 28th, so secure your free ArcSight Logger TODAY!
>> http://p.sf.net/sfu/arcsight-sfd2d
>> ___
>> enlightenment-svn mailing list
>> enlightenment-...@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>>
>>
>
>
>
--
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires
February 28th, so secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsight-sfd2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Enlightenment @ Cebit 2011
On Mon, 31 Jan 2011 20:14:59 +0900 Carsten Haitzler (The Rasterman) wrote: > On Wed, 26 Jan 2011 23:28:06 -0500 Mike Blumenkrantz said: > > > On Thu, 27 Jan 2011 13:09:26 +0900 > > Carsten Haitzler (The Rasterman) wrote: > > > > > Just thought I'd pipe up here. Getting organised. > > > > > > Thanks to linux-magazin E gets some booth space @ Cebit 2011. Who wants to > > > join in? By this i mean - who wants to help "hang out" at the booth? It's > > > held march 1-5 in Hannover in germany. It's a pretty big show and will be > > > busy. I'll end up there all week - anyone interested in coming... speak > > > up! :) > > > > > Me, possibly! Have to check my schedule around that time, but if I'm around > > it would be cool to go. Plus I've never been to Germany :) > > beer. bretzels. fried up stuff. potatoes. yum. :) > I'll know by the end of the week if I'm going. -- Mike Blumenkrantz Zentific: NULL pointer dereferences now 50% off! -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] evas build problem
Hi, What have I done wrong now: make[1]: Entering directory `/home/sebastid/scm/e/evas/src/lib/engines/common' make[1]: *** No rule to make target `evas_bidi_utils.c', needed by `evas_bidi_utils.lo'. Stop. The evas_bidi_utils.c file is in the language subdir, and there is a special Makefile handler for evas_bidi_utils.lo to use language/evas_bidi_utils.c, but it seems to not work as it should. System: Ubuntu 10.10 automake (GNU automake) 1.11.1 autoconf (GNU Autoconf) 2.67 Sebastian -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] evas build problem
Hey, run: make distclean Always a good idea when stuff don't work. -- Tom. On Mon, 2011-01-31 at 14:13 +0100, Sebastian Dransfeld wrote: > Hi, > > What have I done wrong now: > > make[1]: Entering directory > `/home/sebastid/scm/e/evas/src/lib/engines/common' > make[1]: *** No rule to make target `evas_bidi_utils.c', needed by > `evas_bidi_utils.lo'. Stop. > > The evas_bidi_utils.c file is in the language subdir, and there is a > special Makefile handler for evas_bidi_utils.lo to use > language/evas_bidi_utils.c, but it seems to not work as it should. > > System: > Ubuntu 10.10 > automake (GNU automake) 1.11.1 > autoconf (GNU Autoconf) 2.67 > > > Sebastian > > -- > Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! > Finally, a world-class log management solution at an even better price-free! > Download using promo code Free_Logger_4_Dev2Dev. Offer expires > February 28th, so secure your free ArcSight Logger TODAY! > http://p.sf.net/sfu/arcsight-sfd2d > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] evas build problem
Hi, you are not alone :) try this dirty hack: cd /home/sebastid/scm/e/evas/src/lib/engines/common ln -s language/evas_*.* . then make again; "for me i works" :) Thanks, Danny 2011/1/31 Sebastian Dransfeld > Hi, > > What have I done wrong now: > > make[1]: Entering directory > `/home/sebastid/scm/e/evas/src/lib/engines/common' > make[1]: *** No rule to make target `evas_bidi_utils.c', needed by > `evas_bidi_utils.lo'. Stop. > > The evas_bidi_utils.c file is in the language subdir, and there is a > special Makefile handler for evas_bidi_utils.lo to use > language/evas_bidi_utils.c, but it seems to not work as it should. > > System: > Ubuntu 10.10 > automake (GNU automake) 1.11.1 > autoconf (GNU Autoconf) 2.67 > > > Sebastian > > > -- > Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! > Finally, a world-class log management solution at an even better > price-free! > Download using promo code Free_Logger_4_Dev2Dev. Offer expires > February 28th, so secure your free ArcSight Logger TODAY! > http://p.sf.net/sfu/arcsight-sfd2d > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] evas build problem
Works! On 01/31/2011 02:19 PM, Tom Hacohen wrote: > Hey, > > run: > make distclean > > Always a good idea when stuff don't work. > > -- > Tom. > > On Mon, 2011-01-31 at 14:13 +0100, Sebastian Dransfeld wrote: >> Hi, >> >> What have I done wrong now: >> >> make[1]: Entering directory >> `/home/sebastid/scm/e/evas/src/lib/engines/common' >> make[1]: *** No rule to make target `evas_bidi_utils.c', needed by >> `evas_bidi_utils.lo'. Stop. >> >> The evas_bidi_utils.c file is in the language subdir, and there is a >> special Makefile handler for evas_bidi_utils.lo to use >> language/evas_bidi_utils.c, but it seems to not work as it should. >> >> System: >> Ubuntu 10.10 >> automake (GNU automake) 1.11.1 >> autoconf (GNU Autoconf) 2.67 >> >> >> Sebastian >> >> -- >> Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! >> Finally, a world-class log management solution at an even better price-free! >> Download using promo code Free_Logger_4_Dev2Dev. Offer expires >> February 28th, so secure your free ArcSight Logger TODAY! >> http://p.sf.net/sfu/arcsight-sfd2d >> ___ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] evas build problem
NO! That's plain bad. :) The rule of thumb in the open source world (at least for me) is: "If you find yourself doing something ugly, you are probably doing it wrong and should ask someone how to do it right." I live my life according to this rule :) -- Tom. On Mon, 2011-01-31 at 15:23 +0200, Иван Сусанин wrote: > Hi, > > you are not alone :) > > try this dirty hack: > > cd /home/sebastid/scm/e/evas/src/lib/engines/common > ln -s language/evas_*.* . > > then make again; "for me i works" :) > > Thanks, > Danny > > 2011/1/31 Sebastian Dransfeld > > > Hi, > > > > What have I done wrong now: > > > > make[1]: Entering directory > > `/home/sebastid/scm/e/evas/src/lib/engines/common' > > make[1]: *** No rule to make target `evas_bidi_utils.c', needed by > > `evas_bidi_utils.lo'. Stop. > > > > The evas_bidi_utils.c file is in the language subdir, and there is a > > special Makefile handler for evas_bidi_utils.lo to use > > language/evas_bidi_utils.c, but it seems to not work as it should. > > > > System: > > Ubuntu 10.10 > > automake (GNU automake) 1.11.1 > > autoconf (GNU Autoconf) 2.67 > > > > > > Sebastian > > > > > > -- > > Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! > > Finally, a world-class log management solution at an even better > > price-free! > > Download using promo code Free_Logger_4_Dev2Dev. Offer expires > > February 28th, so secure your free ArcSight Logger TODAY! > > http://p.sf.net/sfu/arcsight-sfd2d > > ___ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > -- > Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! > Finally, a world-class log management solution at an even better price-free! > Download using promo code Free_Logger_4_Dev2Dev. Offer expires > February 28th, so secure your free ArcSight Logger TODAY! > http://p.sf.net/sfu/arcsight-sfd2d > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Enlightenment @ Cebit 2011
On Fri, Jan 28, 2011 at 22:23, Andreas Volz wrote: > Am Thu, 27 Jan 2011 13:09:26 +0900 schrieb Carsten Haitzler (The > Rasterman): > >> Just thought I'd pipe up here. Getting organised. >> >> Thanks to linux-magazin E gets some booth space @ Cebit 2011. Who >> wants to join in? By this i mean - who wants to help "hang out" at >> the booth? It's held march 1-5 in Hannover in germany. It's a pretty >> big show and will be busy. I'll end up there all week - anyone >> interested in coming... speak up! :) > > I'm from germany (300 km distance) and thought about joining. Car > traveling costs aren't relevant for me, but I'm interested about other > expenses. I looked for a hotel booking around this time in hannover and > it costs ~100-200€/night. Do you've any idea about Cebit ticket costs? > > regards > Andreas I've never heard of anyone paying for Cebit tickets. If you can't get company tickets, just use Google to find one of the hundreds of free contingents. Cebit usually throws out contingents of about 99% non-company visitors for various magazines and so on who usually give them away. There is no reason to spend a cent on tickets if you have a disposable E-Mail-Address. These tickets won't get you in certain closed areas though (not that it should matter). (Whoops, was supposed to go to all, sry for the overhead, Andreas) -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] evas build problem
Well, i"ll preffer to make it build now, than wait for help. If you can make it work - let it work. :) 2011/1/31 Tom Hacohen > NO! That's plain bad. :) > The rule of thumb in the open source world (at least for me) is: > "If you find yourself doing something ugly, you are probably doing it > wrong and should ask someone how to do it right." > > I live my life according to this rule :) > > -- > Tom. > > On Mon, 2011-01-31 at 15:23 +0200, Иван Сусанин wrote: > > Hi, > > > > you are not alone :) > > > > try this dirty hack: > > > > cd /home/sebastid/scm/e/evas/src/lib/engines/common > > ln -s language/evas_*.* . > > > > then make again; "for me i works" :) > > > > Thanks, > > Danny > > > > 2011/1/31 Sebastian Dransfeld > > > > > Hi, > > > > > > What have I done wrong now: > > > > > > make[1]: Entering directory > > > `/home/sebastid/scm/e/evas/src/lib/engines/common' > > > make[1]: *** No rule to make target `evas_bidi_utils.c', needed by > > > `evas_bidi_utils.lo'. Stop. > > > > > > The evas_bidi_utils.c file is in the language subdir, and there is a > > > special Makefile handler for evas_bidi_utils.lo to use > > > language/evas_bidi_utils.c, but it seems to not work as it should. > > > > > > System: > > > Ubuntu 10.10 > > > automake (GNU automake) 1.11.1 > > > autoconf (GNU Autoconf) 2.67 > > > > > > > > > Sebastian > > > > > > > > > > -- > > > Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! > > > Finally, a world-class log management solution at an even better > > > price-free! > > > Download using promo code Free_Logger_4_Dev2Dev. Offer expires > > > February 28th, so secure your free ArcSight Logger TODAY! > > > http://p.sf.net/sfu/arcsight-sfd2d > > > ___ > > > enlightenment-devel mailing list > > > enlightenment-devel@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > -- > > Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! > > Finally, a world-class log management solution at an even better > price-free! > > Download using promo code Free_Logger_4_Dev2Dev. Offer expires > > February 28th, so secure your free ArcSight Logger TODAY! > > http://p.sf.net/sfu/arcsight-sfd2d > > ___ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] evas build problem
Actually, that's also a very good motto, hm... maybe I'll have to adjust mine a bit to include yours as well. :) -- Tom. On Mon, 2011-01-31 at 15:28 +0200, Иван Сусанин wrote: > Well, i"ll preffer to make it build now, than wait for help. > If you can make it work - let it work. > > :) > > > 2011/1/31 Tom Hacohen > NO! That's plain bad. :) > The rule of thumb in the open source world (at least for me) > is: > "If you find yourself doing something ugly, you are probably > doing it > wrong and should ask someone how to do it right." > > I live my life according to this rule :) > > -- > Tom. > > > On Mon, 2011-01-31 at 15:23 +0200, Иван Сусанин wrote: > > Hi, > > > > you are not alone :) > > > > try this dirty hack: > > > > cd /home/sebastid/scm/e/evas/src/lib/engines/common > > ln -s language/evas_*.* . > > > > then make again; "for me i works" :) > > > > Thanks, > > Danny > > > > 2011/1/31 Sebastian Dransfeld > > > > > Hi, > > > > > > What have I done wrong now: > > > > > > make[1]: Entering directory > > > `/home/sebastid/scm/e/evas/src/lib/engines/common' > > > make[1]: *** No rule to make target `evas_bidi_utils.c', > needed by > > > `evas_bidi_utils.lo'. Stop. > > > > > > The evas_bidi_utils.c file is in the language subdir, and > there is a > > > special Makefile handler for evas_bidi_utils.lo to use > > > language/evas_bidi_utils.c, but it seems to not work as it > should. > > > > > > System: > > > Ubuntu 10.10 > > > automake (GNU automake) 1.11.1 > > > autoconf (GNU Autoconf) 2.67 > > > > > > > > > Sebastian > > > > > > > > > > > -- > > > Special Offer-- Download ArcSight Logger for FREE (a $49 > USD value)! > > > Finally, a world-class log management solution at an even > better > > > price-free! > > > Download using promo code Free_Logger_4_Dev2Dev. Offer > expires > > > February 28th, so secure your free ArcSight Logger TODAY! > > > http://p.sf.net/sfu/arcsight-sfd2d > > > ___ > > > enlightenment-devel mailing list > > > enlightenment-devel@lists.sourceforge.net > > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > -- > > Special Offer-- Download ArcSight Logger for FREE (a $49 USD > value)! > > Finally, a world-class log management solution at an even > better price-free! > > Download using promo code Free_Logger_4_Dev2Dev. Offer > expires > > February 28th, so secure your free ArcSight Logger TODAY! > > http://p.sf.net/sfu/arcsight-sfd2d > > ___ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] ChangeLog
On Mon, 31 Jan 2011 16:30:14 +0900 Carsten Haitzler (The Rasterman) wrote: > On Sun, 30 Jan 2011 22:27:45 +0100 (CET) Vincent Torri > said: > > > > > > > On Sun, 30 Jan 2011, Carsten Haitzler (The Rasterman) wrote: > > > > > On Sun, 30 Jan 2011 08:47:25 -0500 Mike Blumenkrantz > > > said: > > > > > >> On Sun, 30 Jan 2011 14:24:27 +0100 > > >> s...@tango.flipp.net wrote: > > >> > > > > Hey, > > > > raster, you did an error on the date in the ChangeLog. Again, i tell > > you: use moap. With moap: > > > > * you can't forget to update the ChangeLog (if necessary) > > * you can't make an error on the date > > * you can't make an error on the author of the patch or forget to add > > it > > * you can't forget to commit one file (you still can forget to add > > a file though) > > > > without it or without another similar tool, well, you can have these > > problems > > > > Vincent > > >>> > > >>> And moap does git svn merge against remotes/git-svn instead of git svn > > >>> rebase, and without telling. Stay away if you use git-svn. > > >>> > > >>> Sebastian > > >>> > > >>> > > >> oh god thanks for the heads up > > > > > > as i said.. no silver bullet :) new tool. new unknowns and side-effects. > > > jumping all over some new tool is not something you do instantly without > > > care :) > > > > and ? Like seb said: "Stay away if you use git-svn". That does not prevent > > the use of moap in the other cases > > didn't say it does - i said that jumping all over it instantly is going to > have side-effects (for at least some people). so moving to use it overnight > for everyone is probably not a smart move. > Personally, I use VC (Vtorri Changelog). It's a very simple system which automatically sends you email reminders any time you forget to update the changelog with your commit. -- Mike Blumenkrantz Zentific: NULL pointer dereferences now 50% off! -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] ChangeLog
On Mon, 2011-01-31 at 09:28 -0500, Mike Blumenkrantz wrote: > Personally, I use VC (Vtorri Changelog). It's a very simple system which > automatically sends you email reminders any time you forget to update the > changelog with your commit. > But that's not a new tool, it's have been used in e for years now... -- Tom. -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] ChangeLog
On Mon, 31 Jan 2011 14:32:41 + Tom Hacohen wrote: > On Mon, 2011-01-31 at 09:28 -0500, Mike Blumenkrantz wrote: > > Personally, I use VC (Vtorri Changelog). It's a very simple system which > > automatically sends you email reminders any time you forget to update the > > changelog with your commit. > > > > But that's not a new tool, it's have been used in e for years now... > > -- > Tom. > If it ain't broke, don't fix it. -- Mike Blumenkrantz Zentific: NULL pointer dereferences now 50% off! -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] ChangeLog
On Mon, Jan 31, 2011 at 3:28 PM, Mike Blumenkrantz wrote: > On Mon, 31 Jan 2011 16:30:14 +0900 > Carsten Haitzler (The Rasterman) wrote: >> On Sun, 30 Jan 2011 22:27:45 +0100 (CET) Vincent Torri >> said: >> > On Sun, 30 Jan 2011, Carsten Haitzler (The Rasterman) wrote: >> > > On Sun, 30 Jan 2011 08:47:25 -0500 Mike Blumenkrantz >> > > said: >> > >> On Sun, 30 Jan 2011 14:24:27 +0100 >> > >> s...@tango.flipp.net wrote: >> > Hey, >> > >> > raster, you did an error on the date in the ChangeLog. Again, i tell >> > you: use moap. With moap: >> > >> > * you can't forget to update the ChangeLog (if necessary) >> > * you can't make an error on the date >> > * you can't make an error on the author of the patch or forget to >> > add >> > it >> > * you can't forget to commit one file (you still can forget to add >> > a file though) >> > >> > without it or without another similar tool, well, you can have these >> > problems >> > >> > Vincent >> > >>> >> > >>> And moap does git svn merge against remotes/git-svn instead of git svn >> > >>> rebase, and without telling. Stay away if you use git-svn. >> > >>> >> > >>> Sebastian >> > >>> >> > >>> >> > >> oh god thanks for the heads up >> > > >> > > as i said.. no silver bullet :) new tool. new unknowns and side-effects. >> > > jumping all over some new tool is not something you do instantly without >> > > care :) >> > >> > and ? Like seb said: "Stay away if you use git-svn". That does not prevent >> > the use of moap in the other cases >> >> didn't say it does - i said that jumping all over it instantly is going to >> have side-effects (for at least some people). so moving to use it overnight >> for everyone is probably not a smart move. >> > Personally, I use VC (Vtorri Changelog). It's a very simple system which > automatically sends you email reminders any time you forget to update the > changelog with your commit. You forgot to speak about the SPANK ! That come with it ! -- Cedric BAIL -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] ChangeLog
2011/1/31 Cedric BAIL : > On Mon, Jan 31, 2011 at 3:28 PM, Mike Blumenkrantz wrote: >> On Mon, 31 Jan 2011 16:30:14 +0900 >> Carsten Haitzler (The Rasterman) wrote: >>> On Sun, 30 Jan 2011 22:27:45 +0100 (CET) Vincent Torri >>> said: >>> > On Sun, 30 Jan 2011, Carsten Haitzler (The Rasterman) wrote: >>> > > On Sun, 30 Jan 2011 08:47:25 -0500 Mike Blumenkrantz >>> > > said: >>> > >> On Sun, 30 Jan 2011 14:24:27 +0100 >>> > >> s...@tango.flipp.net wrote: >>> > Hey, >>> > >>> > raster, you did an error on the date in the ChangeLog. Again, i tell >>> > you: use moap. With moap: >>> > >>> > * you can't forget to update the ChangeLog (if necessary) >>> > * you can't make an error on the date >>> > * you can't make an error on the author of the patch or forget to >>> > add >>> > it >>> > * you can't forget to commit one file (you still can forget to add >>> > a file though) >>> > >>> > without it or without another similar tool, well, you can have these >>> > problems >>> > >>> > Vincent >>> > >>> >>> > >>> And moap does git svn merge against remotes/git-svn instead of git svn >>> > >>> rebase, and without telling. Stay away if you use git-svn. >>> > >>> >>> > >>> Sebastian >>> > >>> >>> > >>> >>> > >> oh god thanks for the heads up >>> > > >>> > > as i said.. no silver bullet :) new tool. new unknowns and side-effects. >>> > > jumping all over some new tool is not something you do instantly without >>> > > care :) >>> > >>> > and ? Like seb said: "Stay away if you use git-svn". That does not prevent >>> > the use of moap in the other cases >>> >>> didn't say it does - i said that jumping all over it instantly is going to >>> have side-effects (for at least some people). so moving to use it overnight >>> for everyone is probably not a smart move. >>> >> Personally, I use VC (Vtorri Changelog). It's a very simple system which >> automatically sends you email reminders any time you forget to update the >> changelog with your commit. > > You forgot to speak about the SPANK ! That come with it ! vtorri doesn't spank. He just stares at you until you want to rip your own soul out of guilt. > -- > Cedric BAIL > > -- > Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! > Finally, a world-class log management solution at an even better price-free! > Download using promo code Free_Logger_4_Dev2Dev. Offer expires > February 28th, so secure your free ArcSight Logger TODAY! > http://p.sf.net/sfu/arcsight-sfd2d > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Windows and edje externals
Hey, in elementary, the edje externals search the icons in PACKAGE_DATA_DIR (see elementary/src/edje_externals/private.h, at the end). Would it be reasonnable to first check if the env var ELM_DATA_DIR is set and use its value, and, if not, to use PACKAGE_DATA_DIR ? (Note that ELM_DATA_DIR is already an env var that elementary is checking (see elm_main.c) Vincent -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [patch] add randr backlevel to ecore
Hello,
Since the merge window is open, I would like to submit this patch for ecore. To
make it short, it is a modified version of the patch I send two weeks ago. It
implement backlight control through xrand extension.
MathieuIndex: xlib/ecore_x_randr_12.c
===
--- xlib/ecore_x_randr_12.c (revision 56606)
+++ xlib/ecore_x_randr_12.c (working copy)
@@ -1904,3 +1904,149 @@
Ecore_X_Randr_Unset);
#endif
}
+
+/**
+ * @brief set up the backlight level to the given level.
+ * @param root the window's screen which will be set.
+ * @param level of the backlight between 0 and 100
+ */
+
+EAPI void
+ecore_x_randr_screen_backlight_level_set(Ecore_X_Window root, double level)
+{
+#ifdef ECORE_XRANDR
+ RANDR_CHECK_1_2_RET();
+
+ /*
+* maybe move this in the init part the module.
+* Initialize it if not already initialized
+*/
+
+ if((level < 0)||(level > 100))
+ {
+ WRN("Wrong value for the backlight level. It should be between 0 and 100.");
+ return;
+ }
+
+ if(_backlight == None)
+ _backlight = XInternAtom (_ecore_x_disp, RANDR_PROPERTY_BACKLIGHT, True);
+
+ // Clearly the server does not support it.
+ if(_backlight == None)
+ {
+ ERR("Backlight property is not suppported on this server");
+ return;
+ }
+
+ /* get the ressources */
+ XRRScreenResources *resources = _ecore_x_randr_get_screen_resources (_ecore_x_disp, root);
+
+ int o;
+
+ if (!resources) return;
+ for (o = 0; o < resources->noutput; o++)
+ {
+ Ecore_X_Randr_Output output = resources->outputs[o];
+ if (ecore_x_randr_output_backlight_level_get(root, output) != -1)
+ {
+ ecore_x_randr_output_backlight_level_set(root, output, level);
+ }
+ }
+ XRRFreeScreenResources (resources);
+#endif
+}
+
+/*
+ * @brief get the backlight level of the given output
+ * @param root window which's screen should be queried
+ * @param output from which the backlight level should retrieved
+ * @return the backlight level
+ */
+
+
+EAPI double
+ecore_x_randr_output_backlight_level_get(Ecore_X_Window root,
+ Ecore_X_Randr_Output output)
+{
+#ifdef ECORE_XRANDR
+ RANDR_CHECK_1_2_RET(-1);
+ unsigned long nitems;
+ unsigned long bytes_after;
+ unsigned char *prop;
+ Atom actual_type;
+ int actual_format;
+ long value;
+
+ if(_backlight == None)
+ _backlight = XInternAtom (_ecore_x_disp, RANDR_PROPERTY_BACKLIGHT, True);
+ if(_backlight == None)
+ {
+ ERR("Backlight property is not suppported on this server");
+ return -1;
+ }
+
+ if(!_ecore_x_randr_output_validate(root, output))
+ return -1;
+
+ if (XRRGetOutputProperty (_ecore_x_disp, output, _backlight,
+ 0, 4, False, False, None,
+ &actual_type, &actual_format,
+ &nitems, &bytes_after, &prop) != Success) {
+ WRN("Backlight not supported on this output");
+ return -1;
+ }
+
+ if (actual_type != XA_INTEGER || nitems != 1 || actual_format != 32)
+ value = -1;
+ else
+ value = *((long *) prop);
+ free (prop);
+ return value;
+#else
+ return -1;
+#endif
+}
+
+/*
+ * @brief set the backlight level of a given output
+ * @param root window which's screen should be queried
+ * @param output that should be set
+ * @param level for which the backlight should be set
+ * @return EINA_TRUE in case of success
+ */
+
+EAPI Eina_Bool
+ecore_x_randr_output_backlight_level_set(Ecore_X_Window root,
+ Ecore_X_Randr_Output output,
+ double level)
+{
+#ifdef ECORE_XRANDR
+ RANDR_CHECK_1_2_RET(EINA_FALSE);
+ if(!_ecore_x_randr_output_validate(root, output))
+return;
+
+ XRRPropertyInfo *info = XRRQueryOutputProperty (_ecore_x_disp, output, _backlight);
+ if (info)
+{
+ if (info->range && info->num_values == 2)
+ {
+ double min = info->values[0];
+ double max = info->values[1];
+ double tmp = (level * (max - min) / 100) + min;
+ long new = tmp;
+ if (new > max) new = max;
+ if (new < min) new = min;
+
+ XRRChangeOutputProperty (_ecore_x_disp, output, _backlight, XA_INTEGER, 32,
+ PropModeReplace, (unsigned char *) &new, 1);
+ XFlush (_ecore_x_disp);
+ }
+ free(info);
+ return EINA_TRUE;
+}
+
+ return EINA_FALSE;
+#else
+ return EINA_FALSE;
+#endif
+}
--
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires
February 28th, so secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsight-sfd2d___
enlightenment-devel mailing list
enli
Re: [E-devel] Edje animation bug
Thanks a lot, Cedric. You've been nothing but helpful when dealing with unexpected behaviors. I truly wasn't expecting the inner GROUP's events to propagate to the upper one. I changed my "show" program and it worked perfectly. Cheers, Eduardo. On Fri, Jan 28, 2011 at 7:31 PM, Cedric BAIL wrote: > On Fri, Jan 28, 2011 at 9:08 PM, Eduardo Felipe > wrote: >> I was trying to animate the position of a GROUP part of an Edje but no >> matter what transition time I chose it just jumped to the final >> description, without animating to it. >> >> I talked to Cedric on #edevel and he also gets the same behavior. He >> found out that the transition is not taken into account at all. >> >> Here is an .edc that triggers the bug: http://pastebin.com/1cTA3CdN >> >> I would appreciate any pointers as where to look and what to do. > > I finally understood why we got this behaviour. In fact the GROUP > instantiate another edje object. So you will get a show event from the > main object and another from "grid:". Because you catch both of them > in your program, the first STATE_SET does start the animation and the > second call just jump to the end of this animation. > So not a bug, just an expected behaviour, maybe not that obvious ! > -- > Cedric BAIL > -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: davemds trunk/ecore/src/lib/ecore_con
2011/1/31 Enlightenment SVN : > Log: > :/ setting a const char * param to NULL ?? and after the return ?? :O > random spank > > Author: davemds > Date: 2011-01-31 10:48:50 -0800 (Mon, 31 Jan 2011) > New Revision: 56611 > Trac: http://trac.enlightenment.org/e/changeset/56611 > > Modified: > trunk/ecore/src/lib/ecore_con/ecore_con_url.c > > Modified: trunk/ecore/src/lib/ecore_con/ecore_con_url.c > === > --- trunk/ecore/src/lib/ecore_con/ecore_con_url.c 2011-01-31 17:29:24 > UTC (rev 56610) > +++ trunk/ecore/src/lib/ecore_con/ecore_con_url.c 2011-01-31 18:48:50 > UTC (rev 56611) > @@ -321,7 +321,6 @@ > return url_con; > #else > return NULL; > - url = NULL; > #endif > } > > > > -- > Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! > Finally, a world-class log management solution at an even better price-free! > Download using promo code Free_Logger_4_Dev2Dev. Offer expires > February 28th, so secure your free ArcSight Logger TODAY! > http://p.sf.net/sfu/arcsight-sfd2d > ___ > enlightenment-svn mailing list > enlightenment-...@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > I guess it's for shut up compiler warnings is'nt it ? -- Nicolas Aguirre Mail: aguirre.nico...@gmail.com Web: http://enna.geexbox.org Blog: http://dev.enlightenment.fr/~captainigloo/ -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: davemds trunk/ecore/src/lib/ecore_con
"Enlightenment SVN" writes: > Log: > :/ setting a const char * param to NULL ?? and after the return ?? :O > random spank > > Author: davemds > Date: 2011-01-31 10:48:50 -0800 (Mon, 31 Jan 2011) > New Revision: 56611 > Trac: http://trac.enlightenment.org/e/changeset/56611 > > Modified: > trunk/ecore/src/lib/ecore_con/ecore_con_url.c > > Modified: trunk/ecore/src/lib/ecore_con/ecore_con_url.c > === > --- trunk/ecore/src/lib/ecore_con/ecore_con_url.c 2011-01-31 17:29:24 UTC > (rev 56610) > +++ trunk/ecore/src/lib/ecore_con/ecore_con_url.c 2011-01-31 18:48:50 UTC > (rev 56611) > @@ -321,7 +321,6 @@ > return url_con; > #else > return NULL; > - url = NULL; > #endif > } If we enter the #else, we need to use the `url' parameter, otherwise the compiler will complain about unused parameters. You could replace url = NULL; with (void)url; so that the compiler is happy and nobody gets spanked :) -- Raphael Kubo da Costa ProFUSION embedded systems http://profusion.mobi -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: davemds trunk/ecore/src/lib/ecore_con
On Mon, 31 Jan 2011 17:00:21 -0200 Raphael Kubo da Costa wrote: > "Enlightenment SVN" writes: > > > Log: > > :/ setting a const char * param to NULL ?? and after the > > return ?? :O random spank > > > > Author: davemds > > Date: 2011-01-31 10:48:50 -0800 (Mon, 31 Jan 2011) > > New Revision: 56611 > > Trac: http://trac.enlightenment.org/e/changeset/56611 > > > > Modified: > > trunk/ecore/src/lib/ecore_con/ecore_con_url.c > > > > Modified: trunk/ecore/src/lib/ecore_con/ecore_con_url.c > > === > > --- trunk/ecore/src/lib/ecore_con/ecore_con_url.c 2011-01-31 > > 17:29:24 UTC (rev 56610) +++ > > trunk/ecore/src/lib/ecore_con/ecore_con_url.c 2011-01-31 > > 18:48:50 UTC (rev 56611) @@ -321,7 +321,6 @@ return url_con; > > #else > > return NULL; > > - url = NULL; > > #endif > > } > > If we enter the #else, we need to use the `url' parameter, otherwise > the compiler will complain about unused parameters. The compiler is not bitching about unreachable code? signature.asc Description: PGP signature -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: davemds trunk/ecore/src/lib/ecore_con
David Seikel writes: > On Mon, 31 Jan 2011 17:00:21 -0200 Raphael Kubo da Costa > wrote: > >> "Enlightenment SVN" writes: >> >> > Log: >> > :/ setting a const char * param to NULL ?? and after the >> > return ?? :O random spank >> > >> > Author: davemds >> > Date: 2011-01-31 10:48:50 -0800 (Mon, 31 Jan 2011) >> > New Revision: 56611 >> > Trac: http://trac.enlightenment.org/e/changeset/56611 >> > >> > Modified: >> > trunk/ecore/src/lib/ecore_con/ecore_con_url.c >> > >> > Modified: trunk/ecore/src/lib/ecore_con/ecore_con_url.c >> > === >> > --- trunk/ecore/src/lib/ecore_con/ecore_con_url.c 2011-01-31 >> > 17:29:24 UTC (rev 56610) +++ >> > trunk/ecore/src/lib/ecore_con/ecore_con_url.c 2011-01-31 >> > 18:48:50 UTC (rev 56611) @@ -321,7 +321,6 @@ return url_con; >> > #else >> > return NULL; >> > - url = NULL; >> > #endif >> > } >> >> If we enter the #else, we need to use the `url' parameter, otherwise >> the compiler will complain about unused parameters. > > The compiler is not bitching about unreachable code? I've never compiled this code without libcurl, so I don't know. If it does, (void)url; return NULL; might be more appropriate. -- Raphael Kubo da Costa ProFUSION embedded systems http://profusion.mobi -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Efreet Segfault
Hi Seb, Getting a nasty segfault with current efreet trunk. Here is the bt: #0 0x0058cb02 in strrchr () from /lib/libc.so.6 #1 0x0030862b in efreet_cache_icon_fallback_lookup_path (icon=0x81bcd18) at efreet_icon.c:838 #2 0x003089ce in efreet_icon_path_find (theme_name=0x81bc088 "Buuf-Deuce", icon=0xb78f61e3 "elementary", size=64) at efreet_icon.c:343 #3 0x0809a970 in _e_configure_efreet_desktop_update () at e_configure.c:335 #4 0x0809abcb in _configure_job (data=0x0) at e_configure.c:242 #5 0x001ee3c2 in _ecore_job_event_handler (data=0x0, type=11, ev=0x843d220) at ecore_job.c:119 #6 0x001ead16 in _ecore_event_call () at ecore_events.c:641 #7 0x001efcf7 in _ecore_main_loop_iterate_internal (once_only=0) at ecore_main.c:1529 #8 0x001eff87 in ecore_main_loop_begin () at ecore_main.c:680 #9 0x0806d1aa in main (argc=1, argv=0xb364) at e_main.c:1158 Cheers, dh -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Circular dependency when calculating part
Hello, my elementary application changes some edje label by using the param interface. Sometimes when updating this error message: ERR<1478>:edje edje_calc.c:1689 _edje_part_recalc() Circular dependency when calculating part "sb_vbar". Already calculating X [01] axes. Need to calculate XY [03] axes ERR<1478>:edje edje_calc.c:1689 _edje_part_recalc() Circular dependency when calculating part "sb_vbar". Already calculating X [01] axes. Need to calculate X [01] axes ERR<1478>:edje edje_calc.c:1689 _edje_part_recalc() Circular dependency when calculating part "sb_vbar". Already calculating X [01] axes. Need to calculate X [01] axes ERR<1478>:edje edje_calc.c:1689 _edje_part_recalc() Circular dependency when calculating part "elm.swallow.content". Already calculating XY [03] axes. Need to calculate X [01] axes ERR<1478>:edje edje_calc.c:1689 _edje_part_recalc() Circular dependency when calculating part "elm.dragable.hbar". Already calculating XY [03] axes. Need to calculate XY [03] axes Do you think it's an application bug or a library bug? BTW: seems to arrive more often if I update the label faster. regards Andreas -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] Handle ecore signals with a pipe
On 01/31/2011 07:29 PM, Carsten Haitzler (The Rasterman) wrote:
got a cleaned up patch? yours doesnt apply at all. also i think you removed
most but not all the handlers. _ecore_signal_callback_sigrt still had a
prototype at any rate reading your diff.
Attached.
The handlers were all merged into one, which sends the signal information over
a pipe.
thanks,
Mike
>From a28d9b60d8a0f3e46fde1926c411a8398e74317b Mon Sep 17 00:00:00 2001
From: Mike McCormack
Date: Mon, 24 Jan 2011 20:36:20 +0900
Subject: [PATCH] Handle ecore signals with a pipe
This removes a race condition in the main loop where
a signal could come after the signal check, and before
entering the select loop, possibly resulting in a hang.
In practice, this hang wouldn't be seen due to other activity
in the main loop.
---
trunk/ecore/src/lib/ecore/ecore_signal.c | 269 --
1 files changed, 110 insertions(+), 159 deletions(-)
diff --git a/trunk/ecore/src/lib/ecore/ecore_signal.c b/trunk/ecore/src/lib/ecore/ecore_signal.c
index f072c06..0a0c038 100644
--- a/trunk/ecore/src/lib/ecore/ecore_signal.c
+++ b/trunk/ecore/src/lib/ecore/ecore_signal.c
@@ -17,20 +17,13 @@
/* valgrind in some versions/setups uses SIGRT's... hmmm */
#undef SIGRTMIN
+static int _ecore_signal_pipe[2];
+
typedef void (*Signal_Handler)(int sig, siginfo_t *si, void *foo);
static void _ecore_signal_callback_set(int sig, Signal_Handler func);
static void _ecore_signal_callback_ignore(int sig, siginfo_t *si, void *foo);
-static void _ecore_signal_callback_sigchld(int sig, siginfo_t *si, void *foo);
-static void _ecore_signal_callback_sigusr1(int sig, siginfo_t *si, void *foo);
-static void _ecore_signal_callback_sigusr2(int sig, siginfo_t *si, void *foo);
-static void _ecore_signal_callback_sighup(int sig, siginfo_t *si, void *foo);
-static void _ecore_signal_callback_sigquit(int sig, siginfo_t *si, void *foo);
-static void _ecore_signal_callback_sigint(int sig, siginfo_t *si, void *foo);
-static void _ecore_signal_callback_sigterm(int sig, siginfo_t *si, void *foo);
-#ifdef SIGPWR
-static void _ecore_signal_callback_sigpwr(int sig, siginfo_t *si, void *foo);
-#endif
+static void _ecore_signal_callback_write_pipe(int sig, siginfo_t *si, void *foo);
#ifdef SIGRTMIN
static void _ecore_signal_callback_sigrt(int sig, siginfo_t *si, void *foo);
@@ -99,6 +92,9 @@ _ecore_signal_shutdown(void)
sigterm_count = 0;
sig_count = 0;
+ close(_ecore_signal_pipe[0]);
+ close(_ecore_signal_pipe[1]);
+
#ifdef SIGRTMIN
for (i = 0; i < num; i++)
{
@@ -123,24 +119,110 @@ _ecore_signal_shutdown(void)
#endif
}
+Eina_Bool
+_ecore_signal_pipe_read(void *data, Ecore_Fd_Handler *fdh)
+{
+ siginfo_t si;
+ int sig = -1;
+ int r;
+ int n;
+
+ r = read(_ecore_signal_pipe[0], &si, sizeof si);
+ if (r != sizeof si)
+ {
+WRN("failed to read signal\n");
+return;
+ }
+
+ sig = si.si_signo;
+
+ switch (sig)
+ {
+ case SIGCHLD:
+ n = sigchld_count++;
+ sig_count++;
+ if (n < MAXSIGQ)
+ sigchld_info[n] = si;
+ break;
+ case SIGUSR1:
+ n = sigusr1_count++;
+ sig_count++;
+ if (n < MAXSIGQ)
+ sigusr1_info[n] = si;
+ break;
+ case SIGUSR2:
+ n = sigusr2_count++;
+ sig_count++;
+ if (n < MAXSIGQ)
+ sigusr2_info[n] = si;
+ break;
+ case SIGHUP:
+ n = sighup_count++;
+ sig_count++;
+ if (n < MAXSIGQ)
+ sighup_info[n] = si;
+ break;
+ case SIGQUIT:
+ n = sigquit_count++;
+ sig_count++;
+ if (n < MAXSIGQ)
+ sigquit_info[n] = si;
+ break;
+ case SIGINT:
+ n = sigint_count++;
+ sig_count++;
+ if (n < MAXSIGQ)
+ sigint_info[n] = si;
+ break;
+ case SIGTERM:
+ n = sigterm_count++;
+ sig_count++;
+ if (n < MAXSIGQ)
+ sigterm_info[n] = si;
+ break;
+#ifdef SIGPWR
+ case SIGPWR:
+ n = sigpwr_count++;
+ sig_count++;
+ if (n < MAXSIGQ)
+ sigpwr_info[n] = si;
+ break;
+#endif
+ default:
+ ERR("unknown signal %d\n", sig);
+ break;
+ }
+}
+
void
_ecore_signal_init(void)
{
#ifdef SIGRTMIN
int i, num = SIGRTMAX - SIGRTMIN;
#endif
+ int pfd[2];
+ int r;
+
+ r = pipe(_ecore_signal_pipe);
+ if (r < 0)
+ {
+ ERR("pipe failed (%d)\n", r);
+ exit(1);
+ }
+ ecore_main_fd_handler_add(_ecore_signal_pipe[0], ECORE_FD_READ,
+ &_ecore_signal_pipe_read, NULL, NULL, NULL);
_ecore_signal_callback_set(SIGPIPE, _ecore_signal_callback_ignore);
_ecore_signal_callback_set(SIGALRM, _ecore_signal_callback_ignore);
- _ecore_signal_callback_set(SIGCHLD, _ecore_signal_callback_sigchld);
- _ecore_signal_callback_set(SIGUSR1, _ecore_signal_callback_sigusr1);
- _ecore_signa
Re: [E-devel] ChangeLog
On Mon, 31 Jan 2011 14:32:41 + Tom Hacohen said: > On Mon, 2011-01-31 at 09:28 -0500, Mike Blumenkrantz wrote: > > Personally, I use VC (Vtorri Changelog). It's a very simple system which > > automatically sends you email reminders any time you forget to update the > > changelog with your commit. > > > > But that's not a new tool, it's have been used in e for years now... hahahahaha! :) -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] Handle ecore signals with a pipe
On Tue, 01 Feb 2011 14:44:10 +0900 Mike McCormack said: in svrn... > On 01/31/2011 07:29 PM, Carsten Haitzler (The Rasterman) wrote: > > > got a cleaned up patch? yours doesnt apply at all. also i think you removed > > most but not all the handlers. _ecore_signal_callback_sigrt still had a > > prototype at any rate reading your diff. > > Attached. > > The handlers were all merged into one, which sends the signal information over > a pipe. > > thanks, > > Mike -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [PATCH] Remove SIGRT stuff
Unused, and doesn't work as it stands. Delete...
>From 9c69d092477801a6f7e59241d5652e6390e66046 Mon Sep 17 00:00:00 2001
From: Mike McCormack
Date: Mon, 24 Jan 2011 20:59:37 +0900
Subject: [PATCH] Remove SIGRT stuff
---
trunk/ecore/src/lib/ecore/ecore_signal.c | 86 --
1 files changed, 0 insertions(+), 86 deletions(-)
diff --git a/trunk/ecore/src/lib/ecore/ecore_signal.c b/trunk/ecore/src/lib/ecore/ecore_signal.c
index 0a0c038..772e2dd 100644
--- a/trunk/ecore/src/lib/ecore/ecore_signal.c
+++ b/trunk/ecore/src/lib/ecore/ecore_signal.c
@@ -15,7 +15,6 @@
/* make mono happy - this is evil though... */
#undef SIGPWR
/* valgrind in some versions/setups uses SIGRT's... hmmm */
-#undef SIGRTMIN
static int _ecore_signal_pipe[2];
@@ -25,10 +24,6 @@ static void _ecore_signal_callback_set(int sig, Signal_Handler func);
static void _ecore_signal_callback_ignore(int sig, siginfo_t *si, void *foo);
static void _ecore_signal_callback_write_pipe(int sig, siginfo_t *si, void *foo);
-#ifdef SIGRTMIN
-static void _ecore_signal_callback_sigrt(int sig, siginfo_t *si, void *foo);
-#endif
-
static Eina_Bool _ecore_signal_exe_exit_delay(void *data);
//#define MAXSIGQ 256 // 32k
@@ -45,9 +40,6 @@ static volatile sig_atomic_t sigterm_count = 0;
#ifdef SIGPWR
static volatile sig_atomic_t sigpwr_count = 0;
#endif
-#ifdef SIGRTMIN
-static volatile sig_atomic_t *sigrt_count = NULL;
-#endif
static volatile siginfo_t sigchld_info[MAXSIGQ];
static volatile siginfo_t sigusr1_info[MAXSIGQ];
@@ -59,17 +51,10 @@ static volatile siginfo_t sigterm_info[MAXSIGQ];
#ifdef SIGPWR
static volatile siginfo_t sigpwr_info[MAXSIGQ];
#endif
-#ifdef SIGRTMIN
-static volatile siginfo_t *sigrt_info[MAXSIGQ];
-#endif
void
_ecore_signal_shutdown(void)
{
-#ifdef SIGRTMIN
- int i, num = SIGRTMAX - SIGRTMIN;
-#endif
-
_ecore_signal_callback_set(SIGPIPE, (Signal_Handler) SIG_DFL);
_ecore_signal_callback_set(SIGALRM, (Signal_Handler) SIG_DFL);
_ecore_signal_callback_set(SIGCHLD, (Signal_Handler) SIG_DFL);
@@ -94,29 +79,6 @@ _ecore_signal_shutdown(void)
close(_ecore_signal_pipe[0]);
close(_ecore_signal_pipe[1]);
-
-#ifdef SIGRTMIN
- for (i = 0; i < num; i++)
- {
-_ecore_signal_callback_set(SIGRTMIN + i, (Signal_Handler) SIG_DFL);
-sigrt_count[i] = 0;
- }
-
- if (sigrt_count)
- {
-free((sig_atomic_t *) sigrt_count);
-sigrt_count = NULL;
- }
-
- for (i = 0; i < MAXSIGQ; i++)
- {
-if (sigrt_info[i])
- {
- free((siginfo_t *) sigrt_info[i]);
- sigrt_info[i] = NULL;
- }
- }
-#endif
}
Eina_Bool
@@ -197,9 +159,6 @@ _ecore_signal_pipe_read(void *data, Ecore_Fd_Handler *fdh)
void
_ecore_signal_init(void)
{
-#ifdef SIGRTMIN
- int i, num = SIGRTMAX - SIGRTMIN;
-#endif
int pfd[2];
int r;
@@ -224,20 +183,6 @@ _ecore_signal_init(void)
#ifdef SIGPWR
_ecore_signal_callback_set(SIGPWR, _ecore_signal_callback_write_pipe);
#endif
-
-#ifdef SIGRTMIN
- sigrt_count = calloc(1, sizeof(sig_atomic_t) * num);
- assert(sigrt_count);
-
- for (i = 0; i < MAXSIGQ; i++)
- {
-sigrt_info[i] = calloc(1, sizeof(siginfo_t) * num);
-assert(sigrt_info[i]);
- }
-
- for (i = 0; i < num; i++)
- _ecore_signal_callback_set(SIGRTMIN + i, _ecore_signal_callback_sigrt);
-#endif
}
int
@@ -249,9 +194,6 @@ _ecore_signal_count_get(void)
void
_ecore_signal_call(void)
{
-#ifdef SIGRTMIN
- int i, num = SIGRTMAX - SIGRTMIN;
-#endif
volatile sig_atomic_t n;
sigset_t oldset, newset;
@@ -269,10 +211,6 @@ _ecore_signal_call(void)
#ifdef SIGPWR
sigaddset(&newset, SIGPWR);
#endif
-#ifdef SIGRTMIN
- for (i = 0; i < num; i++)
- sigaddset(&newset, SIGRTMIN + i);
-#endif
sigprocmask(SIG_BLOCK, &newset, &oldset);
if (sigchld_count > MAXSIGQ)
WRN("%i SIGCHLD in queue. max queue size %i. losing "
@@ -494,30 +432,6 @@ _ecore_signal_call(void)
sigpwr_count = 0;
#endif
-#ifdef SIGRTMIN
- for (i = 0; i < num; i++)
- {
-if (sigrt_count[i] > MAXSIGQ)
- WRN("%i SIGRT%i in queue. max queue size %i. losing "
- "siginfo for extra signals.", i + 1, sigrt_count[i], MAXSIGQ);
-for (n = 0; n < sigrt_count[i]; n++)
- {
- Ecore_Event_Signal_Realtime *e;
-
- if ((e = _ecore_event_signal_realtime_new()))
- {
- e->num = i;
-
- if ((n < MAXSIGQ) && (sigrt_info[n][i].si_signo))
-e->data = sigrt_info[n][i];
-
- ecore_event_add(ECORE_EVENT_SIGNAL_REALTIME, e, NULL, NULL);
- }
- sig_count--;
- }
-sigrt_count[i] = 0;
- }
-#endif
sigprocmask(SIG_SETMASK, &oldset, NULL);
}
--
1.7.0.4
--
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Fi
Re: [E-devel] E SVN: raster IN trunk/ecore: . src/lib/ecore
wouldn't it be possible to do a script that apply a patch against trunk
and a branch if needed ?
Vincent
On Mon, 31 Jan 2011, Enlightenment SVN wrote:
> Log:
> From: Mike McCormack
> Subject: Re: [E-devel] [PATCH] Handle ecore signals with a pipe
>
> This removes a race condition in the main loop where
> a signal could come after the signal check, and before
> entering the select loop, possibly resulting in a hang.
>
> In practice, this hang wouldn't be seen due to other activity
> in the main loop.
>
>
>
> Author: raster
> Date: 2011-01-31 21:56:15 -0800 (Mon, 31 Jan 2011)
> New Revision: 56613
> Trac: http://trac.enlightenment.org/e/changeset/56613
>
> Modified:
> trunk/ecore/ChangeLog trunk/ecore/src/lib/ecore/ecore_signal.c
>
> Modified: trunk/ecore/ChangeLog
> ===
> --- trunk/ecore/ChangeLog 2011-01-31 18:57:13 UTC (rev 56612)
> +++ trunk/ecore/ChangeLog 2011-02-01 05:56:15 UTC (rev 56613)
> @@ -15,3 +15,7 @@
> * Fix: ecore-evas CAN send "render done" messages even if not
> waiting for sync counter when using gl engine. new semi-sync
> mode to account for that.
> +
> +2011-02-01 Mike McCormack
> +
> +* Use pipe to catch signals to avoid signal loss race
>
> Modified: trunk/ecore/src/lib/ecore/ecore_signal.c
> ===
> --- trunk/ecore/src/lib/ecore/ecore_signal.c 2011-01-31 18:57:13 UTC (rev
> 56612)
> +++ trunk/ecore/src/lib/ecore/ecore_signal.c 2011-02-01 05:56:15 UTC (rev
> 56613)
> @@ -17,20 +17,13 @@
> /* valgrind in some versions/setups uses SIGRT's... hmmm */
> #undef SIGRTMIN
>
> +static int _ecore_signal_pipe[2];
> +
> typedef void (*Signal_Handler)(int sig, siginfo_t *si, void *foo);
>
> static void _ecore_signal_callback_set(int sig, Signal_Handler func);
> static void _ecore_signal_callback_ignore(int sig, siginfo_t *si, void *foo);
> -static void _ecore_signal_callback_sigchld(int sig, siginfo_t *si, void
> *foo);
> -static void _ecore_signal_callback_sigusr1(int sig, siginfo_t *si, void
> *foo);
> -static void _ecore_signal_callback_sigusr2(int sig, siginfo_t *si, void
> *foo);
> -static void _ecore_signal_callback_sighup(int sig, siginfo_t *si, void *foo);
> -static void _ecore_signal_callback_sigquit(int sig, siginfo_t *si, void
> *foo);
> -static void _ecore_signal_callback_sigint(int sig, siginfo_t *si, void *foo);
> -static void _ecore_signal_callback_sigterm(int sig, siginfo_t *si, void
> *foo);
> -#ifdef SIGPWR
> -static void _ecore_signal_callback_sigpwr(int sig, siginfo_t *si, void *foo);
> -#endif
> +static void _ecore_signal_callback_write_pipe(int sig, siginfo_t *si, void
> *foo);
>
> #ifdef SIGRTMIN
> static void _ecore_signal_callback_sigrt(int sig, siginfo_t *si, void *foo);
> @@ -99,6 +92,9 @@
>sigterm_count = 0;
>sig_count = 0;
>
> + close(_ecore_signal_pipe[0]);
> + close(_ecore_signal_pipe[1]);
> +
> #ifdef SIGRTMIN
>for (i = 0; i < num; i++)
> {
> @@ -123,24 +119,110 @@
> #endif
> }
>
> +Eina_Bool
> +_ecore_signal_pipe_read(void *data, Ecore_Fd_Handler *fdh)
> +{
> + siginfo_t si;
> + int sig = -1;
> + int r;
> + int n;
> +
> + r = read(_ecore_signal_pipe[0], &si, sizeof si);
> + if (r != sizeof si)
> + {
> +WRN("failed to read signal\n");
> +return;
> + }
> +
> + sig = si.si_signo;
> +
> + switch (sig)
> + {
> + case SIGCHLD:
> + n = sigchld_count++;
> + sig_count++;
> + if (n < MAXSIGQ)
> + sigchld_info[n] = si;
> + break;
> + case SIGUSR1:
> + n = sigusr1_count++;
> + sig_count++;
> + if (n < MAXSIGQ)
> + sigusr1_info[n] = si;
> + break;
> + case SIGUSR2:
> + n = sigusr2_count++;
> + sig_count++;
> + if (n < MAXSIGQ)
> + sigusr2_info[n] = si;
> + break;
> + case SIGHUP:
> + n = sighup_count++;
> + sig_count++;
> + if (n < MAXSIGQ)
> + sighup_info[n] = si;
> + break;
> + case SIGQUIT:
> + n = sigquit_count++;
> + sig_count++;
> + if (n < MAXSIGQ)
> + sigquit_info[n] = si;
> + break;
> + case SIGINT:
> + n = sigint_count++;
> + sig_count++;
> + if (n < MAXSIGQ)
> + sigint_info[n] = si;
> + break;
> + case SIGTERM:
> + n = sigterm_count++;
> + sig_count++;
> + if (n < MAXSIGQ)
> + sigterm_info[n] = si;
> + break;
> +#ifdef SIGPWR
> + case SIGPWR:
> + n = sigpwr_count++;
> + sig_count++;
> + if (n < MAXSIGQ)
> + sigpwr_info[n] = si;
> + break;
> +#endif
> + default:
> + ERR("unknown signal %d\n", sig);
> + break;
> + }
> +}
> +
> void
> _ecore_signal_init(void)
> {
> #ifdef SIGRTMIN
>int i, num = SIGRT
Re: [E-devel] E SVN: raster IN trunk/ecore: . src/lib/ecore
On Tue, 1 Feb 2011 07:13:20 +0100 (CET) Vincent Torri
said:
in this case i dont intend to apply to the branch. its a slightly "major"
change.
>
> wouldn't it be possible to do a script that apply a patch against trunk
> and a branch if needed ?
>
> Vincent
>
> On Mon, 31 Jan 2011, Enlightenment SVN wrote:
>
> > Log:
> > From: Mike McCormack
> > Subject: Re: [E-devel] [PATCH] Handle ecore signals with a pipe
> >
> > This removes a race condition in the main loop where
> > a signal could come after the signal check, and before
> > entering the select loop, possibly resulting in a hang.
> >
> > In practice, this hang wouldn't be seen due to other activity
> > in the main loop.
> >
> >
> >
> > Author: raster
> > Date: 2011-01-31 21:56:15 -0800 (Mon, 31 Jan 2011)
> > New Revision: 56613
> > Trac: http://trac.enlightenment.org/e/changeset/56613
> >
> > Modified:
> > trunk/ecore/ChangeLog trunk/ecore/src/lib/ecore/ecore_signal.c
> >
> > Modified: trunk/ecore/ChangeLog
> > ===
> > --- trunk/ecore/ChangeLog 2011-01-31 18:57:13 UTC (rev 56612)
> > +++ trunk/ecore/ChangeLog 2011-02-01 05:56:15 UTC (rev 56613)
> > @@ -15,3 +15,7 @@
> > * Fix: ecore-evas CAN send "render done" messages even if not
> > waiting for sync counter when using gl engine. new semi-sync
> > mode to account for that.
> > +
> > +2011-02-01 Mike McCormack
> > +
> > +* Use pipe to catch signals to avoid signal loss race
> >
> > Modified: trunk/ecore/src/lib/ecore/ecore_signal.c
> > ===
> > --- trunk/ecore/src/lib/ecore/ecore_signal.c2011-01-31 18:57:13 UTC
> > (rev 56612) +++ trunk/ecore/src/lib/ecore/ecore_signal.c2011-02-01
> > 05:56:15 UTC (rev 56613) @@ -17,20 +17,13 @@
> > /* valgrind in some versions/setups uses SIGRT's... hmmm */
> > #undef SIGRTMIN
> >
> > +static int _ecore_signal_pipe[2];
> > +
> > typedef void (*Signal_Handler)(int sig, siginfo_t *si, void *foo);
> >
> > static void _ecore_signal_callback_set(int sig, Signal_Handler func);
> > static void _ecore_signal_callback_ignore(int sig, siginfo_t *si, void
> > *foo); -static void _ecore_signal_callback_sigchld(int sig, siginfo_t *si,
> > void *foo); -static void _ecore_signal_callback_sigusr1(int sig, siginfo_t
> > *si, void *foo); -static void _ecore_signal_callback_sigusr2(int sig,
> > siginfo_t *si, void *foo); -static void _ecore_signal_callback_sighup(int
> > sig, siginfo_t *si, void *foo); -static void _ecore_signal_callback_sigquit
> > (int sig, siginfo_t *si, void *foo); -static void
> > _ecore_signal_callback_sigint(int sig, siginfo_t *si, void *foo); -static
> > void _ecore_signal_callback_sigterm(int sig, siginfo_t *si, void *foo);
> > -#ifdef SIGPWR -static void _ecore_signal_callback_sigpwr(int sig,
> > siginfo_t *si, void *foo); -#endif
> > +static void _ecore_signal_callback_write_pipe(int sig, siginfo_t *si, void
> > *foo);
> >
> > #ifdef SIGRTMIN
> > static void _ecore_signal_callback_sigrt(int sig, siginfo_t *si, void *foo);
> > @@ -99,6 +92,9 @@
> >sigterm_count = 0;
> >sig_count = 0;
> >
> > + close(_ecore_signal_pipe[0]);
> > + close(_ecore_signal_pipe[1]);
> > +
> > #ifdef SIGRTMIN
> >for (i = 0; i < num; i++)
> > {
> > @@ -123,24 +119,110 @@
> > #endif
> > }
> >
> > +Eina_Bool
> > +_ecore_signal_pipe_read(void *data, Ecore_Fd_Handler *fdh)
> > +{
> > + siginfo_t si;
> > + int sig = -1;
> > + int r;
> > + int n;
> > +
> > + r = read(_ecore_signal_pipe[0], &si, sizeof si);
> > + if (r != sizeof si)
> > + {
> > +WRN("failed to read signal\n");
> > +return;
> > + }
> > +
> > + sig = si.si_signo;
> > +
> > + switch (sig)
> > + {
> > + case SIGCHLD:
> > + n = sigchld_count++;
> > + sig_count++;
> > + if (n < MAXSIGQ)
> > + sigchld_info[n] = si;
> > + break;
> > + case SIGUSR1:
> > + n = sigusr1_count++;
> > + sig_count++;
> > + if (n < MAXSIGQ)
> > + sigusr1_info[n] = si;
> > + break;
> > + case SIGUSR2:
> > + n = sigusr2_count++;
> > + sig_count++;
> > + if (n < MAXSIGQ)
> > + sigusr2_info[n] = si;
> > + break;
> > + case SIGHUP:
> > + n = sighup_count++;
> > + sig_count++;
> > + if (n < MAXSIGQ)
> > + sighup_info[n] = si;
> > + break;
> > + case SIGQUIT:
> > + n = sigquit_count++;
> > + sig_count++;
> > + if (n < MAXSIGQ)
> > + sigquit_info[n] = si;
> > + break;
> > + case SIGINT:
> > + n = sigint_count++;
> > + sig_count++;
> > + if (n < MAXSIGQ)
> > + sigint_info[n] = si;
> > + break;
> > + case SIGTERM:
> > + n = sigterm_count++;
> > + sig_count++;
> > + if (n < MAXSIGQ)
> > +
Re: [E-devel] E SVN: raster IN trunk/ecore: . src/lib/ecore
On Tue, 1 Feb 2011, Carsten Haitzler (The Rasterman) wrote:
> On Tue, 1 Feb 2011 07:13:20 +0100 (CET) Vincent Torri
> said:
>
> in this case i dont intend to apply to the branch. its a slightly "major"
> change.
ok. And about my question ?
Vincent
>
>>
>> wouldn't it be possible to do a script that apply a patch against trunk
>> and a branch if needed ?
>>
>> Vincent
>>
>> On Mon, 31 Jan 2011, Enlightenment SVN wrote:
>>
>>> Log:
>>> From: Mike McCormack
>>> Subject: Re: [E-devel] [PATCH] Handle ecore signals with a pipe
>>>
>>> This removes a race condition in the main loop where
>>> a signal could come after the signal check, and before
>>> entering the select loop, possibly resulting in a hang.
>>>
>>> In practice, this hang wouldn't be seen due to other activity
>>> in the main loop.
>>>
>>>
>>>
>>> Author: raster
>>> Date: 2011-01-31 21:56:15 -0800 (Mon, 31 Jan 2011)
>>> New Revision: 56613
>>> Trac: http://trac.enlightenment.org/e/changeset/56613
>>>
>>> Modified:
>>> trunk/ecore/ChangeLog trunk/ecore/src/lib/ecore/ecore_signal.c
>>>
>>> Modified: trunk/ecore/ChangeLog
>>> ===
>>> --- trunk/ecore/ChangeLog 2011-01-31 18:57:13 UTC (rev 56612)
>>> +++ trunk/ecore/ChangeLog 2011-02-01 05:56:15 UTC (rev 56613)
>>> @@ -15,3 +15,7 @@
>>> * Fix: ecore-evas CAN send "render done" messages even if not
>>> waiting for sync counter when using gl engine. new semi-sync
>>> mode to account for that.
>>> +
>>> +2011-02-01 Mike McCormack
>>> +
>>> +* Use pipe to catch signals to avoid signal loss race
>>>
>>> Modified: trunk/ecore/src/lib/ecore/ecore_signal.c
>>> ===
>>> --- trunk/ecore/src/lib/ecore/ecore_signal.c2011-01-31 18:57:13 UTC
>>> (rev 56612) +++ trunk/ecore/src/lib/ecore/ecore_signal.c2011-02-01
>>> 05:56:15 UTC (rev 56613) @@ -17,20 +17,13 @@
>>> /* valgrind in some versions/setups uses SIGRT's... hmmm */
>>> #undef SIGRTMIN
>>>
>>> +static int _ecore_signal_pipe[2];
>>> +
>>> typedef void (*Signal_Handler)(int sig, siginfo_t *si, void *foo);
>>>
>>> static void _ecore_signal_callback_set(int sig, Signal_Handler func);
>>> static void _ecore_signal_callback_ignore(int sig, siginfo_t *si, void
>>> *foo); -static void _ecore_signal_callback_sigchld(int sig, siginfo_t *si,
>>> void *foo); -static void _ecore_signal_callback_sigusr1(int sig, siginfo_t
>>> *si, void *foo); -static void _ecore_signal_callback_sigusr2(int sig,
>>> siginfo_t *si, void *foo); -static void _ecore_signal_callback_sighup(int
>>> sig, siginfo_t *si, void *foo); -static void _ecore_signal_callback_sigquit
>>> (int sig, siginfo_t *si, void *foo); -static void
>>> _ecore_signal_callback_sigint(int sig, siginfo_t *si, void *foo); -static
>>> void _ecore_signal_callback_sigterm(int sig, siginfo_t *si, void *foo);
>>> -#ifdef SIGPWR -static void _ecore_signal_callback_sigpwr(int sig,
>>> siginfo_t *si, void *foo); -#endif
>>> +static void _ecore_signal_callback_write_pipe(int sig, siginfo_t *si, void
>>> *foo);
>>>
>>> #ifdef SIGRTMIN
>>> static void _ecore_signal_callback_sigrt(int sig, siginfo_t *si, void *foo);
>>> @@ -99,6 +92,9 @@
>>>sigterm_count = 0;
>>>sig_count = 0;
>>>
>>> + close(_ecore_signal_pipe[0]);
>>> + close(_ecore_signal_pipe[1]);
>>> +
>>> #ifdef SIGRTMIN
>>>for (i = 0; i < num; i++)
>>> {
>>> @@ -123,24 +119,110 @@
>>> #endif
>>> }
>>>
>>> +Eina_Bool
>>> +_ecore_signal_pipe_read(void *data, Ecore_Fd_Handler *fdh)
>>> +{
>>> + siginfo_t si;
>>> + int sig = -1;
>>> + int r;
>>> + int n;
>>> +
>>> + r = read(_ecore_signal_pipe[0], &si, sizeof si);
>>> + if (r != sizeof si)
>>> + {
>>> +WRN("failed to read signal\n");
>>> +return;
>>> + }
>>> +
>>> + sig = si.si_signo;
>>> +
>>> + switch (sig)
>>> + {
>>> + case SIGCHLD:
>>> + n = sigchld_count++;
>>> + sig_count++;
>>> + if (n < MAXSIGQ)
>>> + sigchld_info[n] = si;
>>> + break;
>>> + case SIGUSR1:
>>> + n = sigusr1_count++;
>>> + sig_count++;
>>> + if (n < MAXSIGQ)
>>> + sigusr1_info[n] = si;
>>> + break;
>>> + case SIGUSR2:
>>> + n = sigusr2_count++;
>>> + sig_count++;
>>> + if (n < MAXSIGQ)
>>> + sigusr2_info[n] = si;
>>> + break;
>>> + case SIGHUP:
>>> + n = sighup_count++;
>>> + sig_count++;
>>> + if (n < MAXSIGQ)
>>> + sighup_info[n] = si;
>>> + break;
>>> + case SIGQUIT:
>>> + n = sigquit_count++;
>>> + sig_count++;
>>> + if (n < MAXSIGQ)
>>> + sigquit_info[n] = si;
>>> + break;
>>> + case SIGINT:
>>> + n = sigint_count++;
>>> + sig_count++;
>>> + if (n < MAXSIGQ)
>>> + sigint_info[n] = si;
>>> + break;
>>> +
Re: [E-devel] E SVN: raster IN trunk/ecore: . src/lib/ecore
On Tue, 1 Feb 2011 07:30:02 +0100 (CET) Vincent Torri
said:
>
>
> On Tue, 1 Feb 2011, Carsten Haitzler (The Rasterman) wrote:
>
> > On Tue, 1 Feb 2011 07:13:20 +0100 (CET) Vincent Torri
> > said:
> >
> > in this case i dont intend to apply to the branch. its a slightly "major"
> > change.
>
> ok. And about my question ?
thats if you have it as a patch - a commit wont have a patch.. well unless u
dig it out from svn or remember to svn diff before u commit and make a patch..
and that assumes the patch applies. as time goes on patches will apply less
and less, so long-term yes, its possible to make a script, but it will fail
more and more as time goes on... so its savings i believe will be moot.
> Vincent
>
> >
> >>
> >> wouldn't it be possible to do a script that apply a patch against trunk
> >> and a branch if needed ?
> >>
> >> Vincent
> >>
> >> On Mon, 31 Jan 2011, Enlightenment SVN wrote:
> >>
> >>> Log:
> >>> From: Mike McCormack
> >>> Subject: Re: [E-devel] [PATCH] Handle ecore signals with a pipe
> >>>
> >>> This removes a race condition in the main loop where
> >>> a signal could come after the signal check, and before
> >>> entering the select loop, possibly resulting in a hang.
> >>>
> >>> In practice, this hang wouldn't be seen due to other activity
> >>> in the main loop.
> >>>
> >>>
> >>>
> >>> Author: raster
> >>> Date: 2011-01-31 21:56:15 -0800 (Mon, 31 Jan 2011)
> >>> New Revision: 56613
> >>> Trac: http://trac.enlightenment.org/e/changeset/56613
> >>>
> >>> Modified:
> >>> trunk/ecore/ChangeLog trunk/ecore/src/lib/ecore/ecore_signal.c
> >>>
> >>> Modified: trunk/ecore/ChangeLog
> >>> ===
> >>> --- trunk/ecore/ChangeLog 2011-01-31 18:57:13 UTC (rev 56612)
> >>> +++ trunk/ecore/ChangeLog 2011-02-01 05:56:15 UTC (rev 56613)
> >>> @@ -15,3 +15,7 @@
> >>> * Fix: ecore-evas CAN send "render done" messages even if not
> >>> waiting for sync counter when using gl engine. new semi-sync
> >>> mode to account for that.
> >>> +
> >>> +2011-02-01 Mike McCormack
> >>> +
> >>> +* Use pipe to catch signals to avoid signal loss race
> >>>
> >>> Modified: trunk/ecore/src/lib/ecore/ecore_signal.c
> >>> ===
> >>> --- trunk/ecore/src/lib/ecore/ecore_signal.c 2011-01-31 18:57:13
> >>> UTC (rev 56612) +++ trunk/ecore/src/lib/ecore/ecore_signal.c
> >>> 2011-02-01 05:56:15 UTC (rev 56613) @@ -17,20 +17,13 @@
> >>> /* valgrind in some versions/setups uses SIGRT's... hmmm */
> >>> #undef SIGRTMIN
> >>>
> >>> +static int _ecore_signal_pipe[2];
> >>> +
> >>> typedef void (*Signal_Handler)(int sig, siginfo_t *si, void *foo);
> >>>
> >>> static void _ecore_signal_callback_set(int sig, Signal_Handler func);
> >>> static void _ecore_signal_callback_ignore(int sig, siginfo_t *si, void
> >>> *foo); -static void _ecore_signal_callback_sigchld(int sig, siginfo_t *si,
> >>> void *foo); -static void _ecore_signal_callback_sigusr1(int sig, siginfo_t
> >>> *si, void *foo); -static void _ecore_signal_callback_sigusr2(int sig,
> >>> siginfo_t *si, void *foo); -static void _ecore_signal_callback_sighup(int
> >>> sig, siginfo_t *si, void *foo); -static void
> >>> _ecore_signal_callback_sigquit (int sig, siginfo_t *si, void *foo);
> >>> -static void _ecore_signal_callback_sigint(int sig, siginfo_t *si, void
> >>> *foo); -static void _ecore_signal_callback_sigterm(int sig, siginfo_t
> >>> *si, void *foo); -#ifdef SIGPWR -static void _ecore_signal_callback_sigpwr
> >>> (int sig, siginfo_t *si, void *foo); -#endif
> >>> +static void _ecore_signal_callback_write_pipe(int sig, siginfo_t *si,
> >>> void *foo);
> >>>
> >>> #ifdef SIGRTMIN
> >>> static void _ecore_signal_callback_sigrt(int sig, siginfo_t *si, void
> >>> *foo); @@ -99,6 +92,9 @@
> >>>sigterm_count = 0;
> >>>sig_count = 0;
> >>>
> >>> + close(_ecore_signal_pipe[0]);
> >>> + close(_ecore_signal_pipe[1]);
> >>> +
> >>> #ifdef SIGRTMIN
> >>>for (i = 0; i < num; i++)
> >>> {
> >>> @@ -123,24 +119,110 @@
> >>> #endif
> >>> }
> >>>
> >>> +Eina_Bool
> >>> +_ecore_signal_pipe_read(void *data, Ecore_Fd_Handler *fdh)
> >>> +{
> >>> + siginfo_t si;
> >>> + int sig = -1;
> >>> + int r;
> >>> + int n;
> >>> +
> >>> + r = read(_ecore_signal_pipe[0], &si, sizeof si);
> >>> + if (r != sizeof si)
> >>> + {
> >>> +WRN("failed to read signal\n");
> >>> +return;
> >>> + }
> >>> +
> >>> + sig = si.si_signo;
> >>> +
> >>> + switch (sig)
> >>> + {
> >>> + case SIGCHLD:
> >>> + n = sigchld_count++;
> >>> + sig_count++;
> >>> + if (n < MAXSIGQ)
> >>> + sigchld_info[n] = si;
> >>> + break;
> >>> + case SIGUSR1:
> >>> + n = sigusr1_count++;
> >>> + sig_count++;
> >>> + if (n < MAXSIGQ)
> >>> + sigusr1_info[n] = si;
> >>> + break;
> >>> + case
Re: [E-devel] E SVN: englebass IN trunk/efreet: . src/bin
On Mon, 31 Jan 2011 03:45:09 -0800 "Enlightenment SVN"
said:
just as an fyi - this kind of change is "really minor" and doesnt deserve a
changelog imho - it's fixing some spelling internally of some comment or
function. it affects no-one and wont be useful to put in a published list of
changes we have made between versions.
basically put into changelog what is worth telling people about when 1.1 comes
out. :)
> Log:
> Correct english
>
> Author: englebass
> Date: 2011-01-31 03:45:09 -0800 (Mon, 31 Jan 2011)
> New Revision: 56599
> Trac: http://trac.enlightenment.org/e/changeset/56599
>
> Modified:
> trunk/efreet/ChangeLog trunk/efreet/src/bin/efreet_icon_cache_create.c
>
> Modified: trunk/efreet/ChangeLog
> ===
> --- trunk/efreet/ChangeLog2011-01-31 11:44:56 UTC (rev 56598)
> +++ trunk/efreet/ChangeLog2011-01-31 11:45:09 UTC (rev 56599)
> @@ -58,3 +58,6 @@
>
> * Create one cache file for each theme
>
> +2011-01-XX Sebastian Dransfeld
> +
> + * Correct english
>
> Modified: trunk/efreet/src/bin/efreet_icon_cache_create.c
> ===
> --- trunk/efreet/src/bin/efreet_icon_cache_create.c 2011-01-31
> 11:44:56 UTC (rev 56598) +++
> trunk/efreet/src/bin/efreet_icon_cache_create.c 2011-01-31 11:45:09
> UTC (rev 56599) @@ -50,7 +50,7 @@ }
>
> static Eina_Bool
> -_cache_extention_lookup(const char *ext)
> +_cache_extension_lookup(const char *ext)
> {
> unsigned int i;
>
> @@ -82,7 +82,7 @@
> continue;
>
> ext = strrchr(entry->path + entry->name_start, '.');
> -if (!ext || !_cache_extention_lookup(ext))
> +if (!ext || !_cache_extension_lookup(ext))
> continue;
>
> /* icon with known extension */
> @@ -180,7 +180,7 @@
> continue;
>
> ext = strrchr(entry->path + entry->name_start, '.');
> -if (!ext || !_cache_extention_lookup(ext))
> +if (!ext || !_cache_extension_lookup(ext))
> continue;
>
> /* icon with known extension */
>
>
> --
> Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
> Finally, a world-class log management solution at an even better price-free!
> Download using promo code Free_Logger_4_Dev2Dev. Offer expires
> February 28th, so secure your free ArcSight Logger TODAY!
> http://p.sf.net/sfu/arcsight-sfd2d
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
--
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com
--
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires
February 28th, so secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsight-sfd2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
