Re: [E-devel] [Patch][elc_ctxpopup] Remove
Thanks! In SVN. But I removed elm_widget_subobject_del in elm_ctxpopup_hover_parent_set from your patch. Existing elm_widget_subobject_add will do elm_widget_subobject_del if there's any existing parent object. Thanks. Daniel Juyung Seo (SeoZ) On Tue, May 22, 2012 at 10:38 AM, Bluezery wrote: > 2012/5/21 Daniel Juyung Seo : >> Yes, Hermet is right. >> Btw, bluezery, is there any problem with this code? >> Daniel Juyung Seo (SeoZ) > > No problem actually :) > But elm_win holds NULL sub-object after ctx_popup is deleted. This is > a potential problem. > And error message is unpleasant to me :( > >> On Mon, May 21, 2012 at 7:13 PM, ChunEon Park wrote: >>> No. It should be called when parent is changed with >>> elm_ctxpopup_hover_parent_set. >>> In this case, parent wouldn't be deleted. > > Yes, you're right. > I fixed my patch. elm_widget_sub_object_del() is called in > elm_ctxpopup_hover_parent_set(), not in _parent_cut_off(). > > But in this patch, _parent_cut_off() function do not cut off all > parent things. There may need to change the function name. > >>> >>> >>> >>> >>> -Regards, Hermet- >>> >>> -Original Message- >>> From: "Bluezery">>> To: "Enlightenment developer >>> list" ; >>> Cc: >>> Sent: 2012-05-21 (월) 17:32:15 >>> Subject: [E-devel] [Patch][elc_ctxpopup] Remove >>> >>> Hello, >>> >>> When ctx_popup is deleted, it calls "elm_widget_sub_object_del(parent, >>> popup)" so that ctx_popup's parent can delete it's sub_ojbect, >>> "ctx_popup". >>> But this is not needed because parent already deletes it's sub-object >>> in elm_widget.c >>> >>> Thanks >>> >>> -- >>> BRs, >>> Kim. >>> -- >>> Live Security Virtual Conference >>> Exclusive live event will cover all the ways today's security and >>> threat landscape has changed and how IT managers can respond. Discussions >>> will include endpoint security, mobile security and the latest in malware >>> threats. >>> http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ >>> enlightenment-devel mailing list >>> enlightenment-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >>> -- >>> Live Security Virtual Conference >>> Exclusive live event will cover all the ways today's security and >>> threat landscape has changed and how IT managers can respond. Discussions >>> will include endpoint security, mobile security and the latest in malware >>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >>> ___ >>> enlightenment-devel mailing list >>> enlightenment-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> >> -- >> Live Security Virtual Conference >> Exclusive live event will cover all the ways today's security and >> threat landscape has changed and how IT managers can respond. Discussions >> will include endpoint security, mobile security and the latest in malware >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >> ___ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > -- > BRs, > Kim. -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Bug report - keybindings don't work while Everything is open
On 22/05/12 02:37, Carsten Haitzler (The Rasterman) wrote: > i tested with all of the country codes supported and its a smattering of about > 30% of them that behave this way. That's just odd. > someone needs to add ecore-x api for that :) > * Tom stares at dh/you. :) -- Tom. -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [Patch] elm_notify - delete event callbacks when parent window is deleted
Hi all. When I use elm_notify, I got a crash in the deleting routine. (you can test it in elementary_test > Video) When parent window of elm_notify is deleted, elm_notify set its parent to NULL. However, it doesn't delete event callbacks of the parent window. In the smart_del callback of elm_notify, it tries to delete event callbacks of parent window. However, its parent is already set to NULL, the deleting is skipped. Then the widget data gets freed. In this case, when other objects in the window are deleted, they can create the parent window's event (e.g. CHANGED_SIZE_HINTS,,) Please find a patch to delete event callbacks when parent window is deleted. Regards, Sohyun elm_notify.patch.txt Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch][Efreet] Add parameter checking to exported API (efreet_desktop)
On Tue, May 22, 2012 at 12:48 PM, Christopher Michael wrote: > On 05/21/12 16:34, Sebastian Dransfeld wrote: >> On 05/21/2012 08:24 AM, Bluezery wrote: >>> Hello, >>> >>> Some efreet APIs do not check input parameters. So I add checking by >>> using EINA_SAFETY_ON_XXX(). >>> ISO/IEC statndards says that "If an argument to a function has an >>> invalid value, behavior is undefined" . But this is just for the >>> primitive functions such as libc. I think that parameter checking is >>> needed in at least EFL exported APIs > > This I 150% support (Not the use of Eina, but rather the checking) !! > Exported APIs need to be clean > > EFL needs lots of param checking. Has been missing for a bit of time > now. I try to add it as I go, but not everyone is supportive. Some do > see it as a "wasted variable check" ... but I would rather KNOW that the > stuff I am working with IS valid first, before I start to work with it > ;) ... If not, then what's left ? A Guess that the variable is valid ??? > No thanks ;) Actually the EINA_SAFETY is something that could be turned off at build time, so the cost at runtime would be zero on a production build. This also means that if you use EINA_SAFETY, apps will be warned about there unwise usage. Prefer direct check if you want them to always work. I do consider that for example *_free(*) should always work on NULL, so better to not use EINA_SAFETY. Sorry I don't have much time to check your patch now. Maybe will do next week. -- Cedric BAIL -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: hermet trunk/elementary/src/lib
Nope. When you call elm_ctxpopup_add(), wd->parent is NULL. It doesn't print out warnings even wd->parent is NULL but it is better to avoid doing a series of unnecessary calls. So I reverted your commit. Thanks. Daniel Juyung Seo (SeoZ) On Tue, May 22, 2012 at 4:09 PM, Enlightenment SVN wrote: > Log: > elementary/ctxpopup - but there would be no parent NULL case. > > > > Author: hermet > Date: 2012-05-22 00:09:13 -0700 (Tue, 22 May 2012) > New Revision: 71303 > Trac: http://trac.enlightenment.org/e/changeset/71303 > > Modified: > trunk/elementary/src/lib/elc_ctxpopup.c > > Modified: trunk/elementary/src/lib/elc_ctxpopup.c > === > --- trunk/elementary/src/lib/elc_ctxpopup.c 2012-05-22 07:05:07 UTC (rev > 71302) > +++ trunk/elementary/src/lib/elc_ctxpopup.c 2012-05-22 07:09:13 UTC (rev > 71303) > @@ -215,7 +215,7 @@ > _parent_cut_off(Evas_Object *obj) > { > Widget_Data *wd = elm_widget_data_get(obj); > - if (!wd || !wd->parent) return; > + if (!wd) return; > > evas_object_event_callback_del_full(wd->parent, > EVAS_CALLBACK_DEL, > > > -- > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > ___ > enlightenment-svn mailing list > enlightenment-...@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] Wayland: Port ecore to the wl_seat
Patch in svn now. I modified it slightly for efl formatting. Thank You :) Dh > -Original Message- > From: zhiwen...@linux.intel.com [mailto:zhiwen...@linux.intel.com] > Sent: 21 May 2012 15:17 > To: enlightenment-devel@lists.sourceforge.net > Subject: [E-devel] [PATCH] Wayland: Port ecore to the wl_seat > > From: Alex Wu > > This commit tracks the changes in wayland input protocol from > wl_input_device to wl_seat. > --- > src/lib/ecore_wayland/Ecore_Wayland.h |6 +- > src/lib/ecore_wayland/ecore_wl_input.c | 133 +-- > > src/lib/ecore_wayland/ecore_wl_window.c | 14 ++-- > 3 files changed, 104 insertions(+), 49 deletions(-) > > diff --git a/src/lib/ecore_wayland/Ecore_Wayland.h > b/src/lib/ecore_wayland/Ecore_Wayland.h > index 2d4ac51..15f6b7f 100644 > --- a/src/lib/ecore_wayland/Ecore_Wayland.h > +++ b/src/lib/ecore_wayland/Ecore_Wayland.h > @@ -119,7 +119,11 @@ struct _Ecore_Wl_Output > struct _Ecore_Wl_Input > { > Ecore_Wl_Display *display; > - struct wl_input_device *input_device; > + struct wl_seat *seat; > + struct wl_pointer *pointer; > + struct wl_keyboard *keyboard; > + struct wl_touch *touch; > + > struct wl_data_device *data_device; > > Ecore_Wl_Window *pointer_focus; > diff --git a/src/lib/ecore_wayland/ecore_wl_input.c > b/src/lib/ecore_wayland/ecore_wl_input.c > index 1627bc1..9f2c894 100644 > --- a/src/lib/ecore_wayland/ecore_wl_input.c > +++ b/src/lib/ecore_wayland/ecore_wl_input.c > @@ -41,19 +41,21 @@ > #define MOD_CONTROL_MASK 0x04 > > /* local function prototypes */ > -static void _ecore_wl_input_cb_motion(void *data, struct > wl_input_device *input_device __UNUSED__, unsigned int timestamp, > wl_fixed_t sx, wl_fixed_t sy); > -static void _ecore_wl_input_cb_button(void *data, struct > wl_input_device *input_device __UNUSED__, unsigned int serial, unsigned > int timestamp, unsigned int button, unsigned int state); > -static void _ecore_wl_input_cb_axis(void *data, struct wl_input_device > *input_device __UNUSED__, unsigned int timestamp, unsigned int axis, > int value); > -static void _ecore_wl_input_cb_key(void *data, struct wl_input_device > *input_device __UNUSED__, unsigned int serial, unsigned int timestamp, > unsigned int key, unsigned int state); > -static void _ecore_wl_input_cb_pointer_enter(void *data, struct > wl_input_device *input_device __UNUSED__, unsigned int serial, struct > wl_surface *surface, wl_fixed_t sx, wl_fixed_t sy); > -static void _ecore_wl_input_cb_pointer_leave(void *data, struct > wl_input_device *input_device __UNUSED__, unsigned int serial, struct > wl_surface *surface); > -static void _ecore_wl_input_cb_keyboard_enter(void *data, struct > wl_input_device *input_device __UNUSED__, unsigned int serial, struct > wl_surface *surface, struct wl_array *keys __UNUSED__); > -static void _ecore_wl_input_cb_keyboard_leave(void *data, struct > wl_input_device *input_device __UNUSED__, unsigned int serial, struct > wl_surface *surface); > -static void _ecore_wl_input_cb_touch_down(void *data, struct > wl_input_device *input_device __UNUSED__, unsigned int serial, unsigned > int timestamp, struct wl_surface *surface __UNUSED__, int id > __UNUSED__, wl_fixed_t x, wl_fixed_t y); > -static void _ecore_wl_input_cb_touch_up(void *data, struct > wl_input_device *input_device __UNUSED__, unsigned int serial, unsigned > int timestamp, int id __UNUSED__); > -static void _ecore_wl_input_cb_touch_motion(void *data, struct > wl_input_device *input_device __UNUSED__, unsigned int timestamp, int > id __UNUSED__, wl_fixed_t x, wl_fixed_t y); > -static void _ecore_wl_input_cb_touch_frame(void *data __UNUSED__, > struct wl_input_device *input_device __UNUSED__); > -static void _ecore_wl_input_cb_touch_cancel(void *data __UNUSED__, > struct wl_input_device *input_device __UNUSED__); > +static void _ecore_wl_input_seat_handle_capabilities(void *data, > struct wl_seat *seat, enum wl_seat_capability caps); > + > +static void _ecore_wl_input_cb_pointer_enter(void *data, struct > wl_pointer *pointer __UNUSED__, unsigned int serial, struct wl_surface > *surface, wl_fixed_t sx, wl_fixed_t sy); > +static void _ecore_wl_input_cb_pointer_leave(void *data, struct > wl_pointer *pointer __UNUSED__, unsigned int serial, struct wl_surface > *surface); > +static void _ecore_wl_input_cb_pointer_motion(void *data, struct > wl_pointer *pointer __UNUSED__, unsigned int timestamp, wl_fixed_t sx, > wl_fixed_t sy); > +static void _ecore_wl_input_cb_pointer_button(void *data, struct > wl_pointer *pointer __UNUSED__, unsigned int serial, unsigned int > timestamp, unsigned int button, unsigned int state); > +static void _ecore_wl_input_cb_pointer_axis(void *data, struct > wl_pointer *pointer __UNUSED__, unsigned int timestamp, unsigned int > axis, int value); > +static void _ecore_wl_input_cb_keyboard_enter(void *data, struct > wl_keyboard *keyboard __UNUSED__, unsigned int serial, struct > wl_surface *surface, struct wl_array
Re: [E-devel] E SVN: hermet trunk/elementary/src/lib
I don't understand how ctxpopup is added without parent. If It is so you should fix that point first. -Regards, Hermet-You should fix that point first. -Original Message- From: "Daniel Juyung Seo"To: ; Cc: ; Sent: 2012-05-22 (화) 17:11:01 Subject: Re: [E-devel] E SVN: hermet trunk/elementary/src/lib Nope. When you call elm_ctxpopup_add(), wd->parent is NULL. It doesn't print out warnings even wd->parent is NULL but it is better to avoid doing a series of unnecessary calls. So I reverted your commit. Thanks. Daniel Juyung Seo (SeoZ) On Tue, May 22, 2012 at 4:09 PM, Enlightenment SVN @enlightenment.org> wrote: > Log: > elementary/ctxpopup - but there would be no parent NULL case. > > > > Author: hermet > Date: 2012-05-22 00:09:13 -0700 (Tue, 22 May 2012) > New Revision: 71303 > Trac: http://trac.enlightenment.org/e/changeset/71303 > > Modified: > trunk/elementary/src/lib/elc_ctxpopup.c > > Modified: trunk/elementary/src/lib/elc_ctxpopup.c > === > --- trunk/elementary/src/lib/elc_ctxpopup.c 2012-05-22 07:05:07 UTC (rev 71302) > +++ trunk/elementary/src/lib/elc_ctxpopup.c 2012-05-22 07:09:13 UTC (rev 71303) > @@ -215,7 +215,7 @@ > _parent_cut_off(Evas_Object *obj) > { >Widget_Data *wd = elm_widget_data_get(obj); > - if (!wd || !wd->parent) return; > + if (!wd) return; > >evas_object_event_callback_del_full(wd->parent, >EVAS_CALLBACK_DEL, > > > -- > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > ___ > enlightenment-svn mailing list > enlightenment-...@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: hermet trunk/elementary/src/lib
Nope. When you call elm_ctxpopup_add() it calls elm_ctxpopup_hover_parent_set(). In elm_ctxpopup_hover_parent_set() calls _parent_cut_off(). At this moment there is no parent yet. So there is a possibility that parent is NULL when _parent_cut_off() is called. Of course we can check parent and do not call _parent_cut_off() in elm_ctxpopup_hover_parent_set(), but this is a matter of choice. I just chose to fix _parent_cut_off(). Thanks. Daniel Juyung Seo (SeoZ) On Tue, May 22, 2012 at 5:18 PM, ChunEon Park wrote: > I don't understand how ctxpopup is added without parent. > > > > If It is so you should fix that point first. > > > > > > > -Regards, Hermet-You should fix that point first. > > > > -Original Message- > From: "Daniel Juyung Seo"> To: ; > Cc: ; > Sent: 2012-05-22 (화) 17:11:01 > Subject: Re: [E-devel] E SVN: hermet trunk/elementary/src/lib > > Nope. > When you call elm_ctxpopup_add(), wd->parent is NULL. > It doesn't print out warnings even wd->parent is NULL but it is better > to avoid doing a series of unnecessary calls. > So I reverted your commit. > Thanks. > > Daniel Juyung Seo (SeoZ) > > On Tue, May 22, 2012 at 4:09 PM, Enlightenment SVN > @enlightenment.org> wrote: > > Log: > > elementary/ctxpopup - but there would be no parent NULL case. > > > > > > > > Author: hermet > > Date: 2012-05-22 00:09:13 -0700 (Tue, 22 May 2012) > > New Revision: 71303 > > Trac: http://trac.enlightenment.org/e/changeset/71303 > > > > Modified: > > trunk/elementary/src/lib/elc_ctxpopup.c > > > > Modified: trunk/elementary/src/lib/elc_ctxpopup.c > > === > > --- trunk/elementary/src/lib/elc_ctxpopup.c 2012-05-22 07:05:07 UTC > (rev 71302) > > +++ trunk/elementary/src/lib/elc_ctxpopup.c 2012-05-22 07:09:13 UTC > (rev 71303) > > @@ -215,7 +215,7 @@ > > _parent_cut_off(Evas_Object *obj) > > { > > Widget_Data *wd = elm_widget_data_get(obj); > > - if (!wd || !wd->parent) return; > > + if (!wd) return; > > > > evas_object_event_callback_del_full(wd->parent, > > EVAS_CALLBACK_DEL, > > > > > > > -- > > Live Security Virtual Conference > > Exclusive live event will cover all the ways today's security and > > threat landscape has changed and how IT managers can respond. Discussions > > will include endpoint security, mobile security and the latest in malware > > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > ___ > > enlightenment-svn mailing list > > enlightenment-...@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > > -- > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > -- > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] python-elementary: Add missing callbacks and AnchorInfo for AnchorHoverInfo in Entry widget.
If you want to contribute directly to the svn, send us an info.txt (just like the other ones in devs/) and your public ssh key. Thank you for your work on python-elementary. -- Boris Faure -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: hermet trunk/elementary/src/lib
My fault. -Regards, Hermet- -Original Message- From: "Daniel Juyung Seo"To: "Enlightenment developer list" ; Cc: ; Sent: 2012-05-22 (화) 17:22:43 Subject: Re: [E-devel] E SVN: hermet trunk/elementary/src/lib Nope. When you call elm_ctxpopup_add() it calls elm_ctxpopup_hover_parent_set(). In elm_ctxpopup_hover_parent_set() calls _parent_cut_off(). At this moment there is no parent yet. So there is a possibility that parent is NULL when _parent_cut_off() is called. Of course we can check parent and do not call _parent_cut_off() in elm_ctxpopup_hover_parent_set(), but this is a matter of choice. I just chose to fix _parent_cut_off(). Thanks. Daniel Juyung Seo (SeoZ) On Tue, May 22, 2012 at 5:18 PM, ChunEon Park @naver.com> wrote: > I don't understand how ctxpopup is added without parent. > > > > If It is so you should fix that point first. > > > > > > > -Regards, Hermet-You should fix that point first. > > > > -Original Message- > From: "Daniel Juyung Seo" > To: ; > Cc: ; > Sent: 2012-05-22 (화) 17:11:01 > Subject: Re: [E-devel] E SVN: hermet trunk/elementary/src/lib > > Nope. > When you call elm_ctxpopup_add(), wd->parent is NULL. > It doesn't print out warnings even wd->parent is NULL but it is better > to avoid doing a series of unnecessary calls. > So I reverted your commit. > Thanks. > > Daniel Juyung Seo (SeoZ) > > On Tue, May 22, 2012 at 4:09 PM, Enlightenment SVN > @enlightenment.org> wrote: > > Log: > > elementary/ctxpopup - but there would be no parent NULL case. > > > > > > > > Author: hermet > > Date: 2012-05-22 00:09:13 -0700 (Tue, 22 May 2012) > > New Revision: 71303 > > Trac: http://trac.enlightenment.org/e/changeset/71303 > > > > Modified: > > trunk/elementary/src/lib/elc_ctxpopup.c > > > > Modified: trunk/elementary/src/lib/elc_ctxpopup.c > > === > > --- trunk/elementary/src/lib/elc_ctxpopup.c 2012-05-22 07:05:07 UTC (rev 71302) > > +++ trunk/elementary/src/lib/elc_ctxpopup.c 2012-05-22 07:09:13 UTC (rev 71303) > > @@ -215,7 +215,7 @@ > > _parent_cut_off(Evas_Object *obj) > > { > >Widget_Data *wd = elm_widget_data_get(obj); > > - if (!wd || !wd->parent) return; > > + if (!wd) return; > > > >evas_object_event_callback_del_full(wd->parent, > >EVAS_CALLBACK_DEL, > > > > > > -- > > Live Security Virtual Conference > > Exclusive live event will cover all the ways today's security and > > threat landscape has changed and how IT managers can respond. Discussions > > will include endpoint security, mobile security and the latest in malware > > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > ___ > > enlightenment-svn mailing list > > enlightenment-...@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > > -- > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > -- > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mai
Re: [E-devel] [Patch] elm_notify - delete event callbacks when parent window is deleted
In SVN. Thanks! Daniel Juyung Seo (SeoZ) On Tue, May 22, 2012 at 4:46 PM, Sohyun Kim wrote: > > Hi all. > When I use elm_notify, I got a crash in the deleting routine. (you can test > it in elementary_test > Video) > > When parent window of elm_notify is deleted, elm_notify set its parent to > NULL. > However, it doesn't delete event callbacks of the parent window. > > In the smart_del callback of elm_notify, it tries to delete event callbacks > of parent window. > However, its parent is already set to NULL, the deleting is skipped. > Then the widget data gets freed. > In this case, when other objects in the window are deleted, they can create > the parent window's event (e.g. CHANGED_SIZE_HINTS,,) > > Please find a patch to delete event callbacks when parent window is deleted. > > Regards, Sohyun > > -- > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster trunk/elementary/src/lib
On Tue, 22 May 2012 00:08:36 -0300 Gustavo Lima Chaves said: > * Carsten Haitzler [2012-05-22 08:42:00 +0900]: > > > On Mon, 21 May 2012 11:17:32 -0300 Gustavo Lima Chaves > > said: > > > > > * Enlightenment SVN [2012-05-20 21:17:11 > > > -0700]: > > > > > > > Log: > > > > due to use obj structure if sd->api is null.. we have crashes - eg if > > > > webkit not supported. fix this. (no no changelog as ita part of the > > > > whole new structure changes) > > > > > > I wonder how is this code path where sd->api does not exist... Could > > > you explain better or show me backtrace, please? > > > > sd->api was NULL. the code assumed it was never null. how? elm_web widget > > was created and played with in the documentation test apps that we > > screenshot for the docs. since my elm built without webkit support... the > > elm_web widget was only partly filled in. :) > > OK, I'll look better at elm web's code and try to find this booboo -- > a quick look on the 1st answer didn't raise anything. If I find it, > I'll fix it properly and remove those checks of absurd/totally wrong > conditions, OK? :) sure. but then we need to make sure we dont get into this absurd condition earlier along the way :) > > > > > BR, > > > > > > Glima. > > > > > > > > > > > > > > > > > > > Author: raster > > > > Date: 2012-05-20 21:17:11 -0700 (Sun, 20 May 2012) > > > > New Revision: 71263 > > > > Trac: http://trac.enlightenment.org/e/changeset/71263 > > > > > > > > Modified: > > > > trunk/elementary/src/lib/elm_widget.c > > > > > > > > Modified: trunk/elementary/src/lib/elm_widget.c > > > > === > > > > --- trunk/elementary/src/lib/elm_widget.c 2012-05-21 01:43:44 UTC > > > > (rev 71262) +++ trunk/elementary/src/lib/elm_widget.c 2012-05-21 > > > > 04:17:11 UTC (rev 71263) @@ -594,6 +594,7 @@ > > > > API_ENTRY return EINA_FALSE; > > > > > > > > if (_elm_legacy_is(obj)) return !!COMPAT_SMART_DATA(sd)->focus_next; > > > > + if (!sd->api) return EINA_FALSE; > > > > return sd->api->focus_next && > > > >(sd->api->focus_next != > > > > _elm_widget_focus_next_func_unimplemented); } > > > > @@ -604,6 +605,7 @@ > > > > API_ENTRY return EINA_FALSE; > > > > > > > > if (_elm_legacy_is(obj)) return !!COMPAT_SMART_DATA > > > > (sd)->focus_direction; > > > > + if (!sd->api) return EINA_FALSE; > > > > return sd->api->focus_direction && > > > >(sd->api->focus_direction != > > > > _elm_widget_focus_direction_func_unimplemented); > > > > @@ -813,6 +815,7 @@ > > > > > > > > focus_order++; > > > > sd->focus_order = focus_order; > > > > + if (!sd->api) return; > > > > if (sd->top_win_focused) > > > > { > > > > sd->focused = EINA_TRUE; > > > > @@ -1183,6 +1186,8 @@ > > > > EINA_LIST_FOREACH(sd->tooltips, l, tt) elm_tooltip_theme(tt); > > > > EINA_LIST_FOREACH(sd->cursors, l, cur) elm_cursor_theme(cur); > > > > > > > > + if (!sd->api) return EINA_FALSE; > > > > + > > > > ret &= sd->api->theme(obj); > > > > > > > > return ret; > > > > @@ -1226,6 +1231,7 @@ > > > > if (sd->hover_obj) elm_widget_theme(sd->hover_obj); > > > > EINA_LIST_FOREACH(sd->tooltips, l, tt) elm_tooltip_theme(tt); > > > > EINA_LIST_FOREACH(sd->cursors, l, cur) elm_cursor_theme(cur); > > > > + if (!sd->api) return; > > > > sd->api->theme(obj); > > > > } > > > > > > > > @@ -1480,6 +1486,7 @@ > > > > API_ENTRY return EINA_FALSE; > > > > EINA_SAFETY_ON_TRUE_RETURN_VAL(obj == sobj, EINA_FALSE); > > > > > > > > + if (!sd->api) return EINA_FALSE; > > > > if (!_elm_legacy_is(obj)) return sd->api->sub_object_add(obj, sobj); > > > > > > > > /* this part will go away once all widgets are migrated to the new > > > > schema */ @@ -1543,6 +1550,7 @@ > > > > > > > > if (!sobj) return EINA_FALSE; > > > > > > > > + if (!sd->api) return EINA_FALSE; > > > > if (!_elm_legacy_is(obj)) return sd->api->sub_object_del(obj, sobj); > > > > > > > > /* this part will go away once all widgets are migrated to the new > > > > schema */ @@ -1996,6 +2004,7 @@ > > > > sd = evas_object_smart_data_get(parent); > > > > if ((!sd) || (!_elm_widget_is(obj))) > > > >return EINA_FALSE; //Not Elm Widget > > > > +if (!sd->api) return EINA_FALSE; > > > > > > > > if (sd->api->event(parent, obj, type, event_info)) > > > >return EINA_TRUE; > > > > @@ -2260,6 +2269,8 @@ > > > > || (elm_widget_tree_unfocusable_get(obj))) > > > > return EINA_FALSE; > > > > > > > > + if (!sd->api) return EINA_FALSE; > > > > + > > > > /* Try use hook */ > > > > if (_elm_widget_focus_direction_manager_is(obj)) > > > > return sd->api->focus_direction(obj, base, degree, direction, > > > > weight); @@ -2373,6 +2384,8 @@ > > > > || (elm_widget_tree_unfocusa
Re: [E-devel] [PATCH] python-elementary: Add missing callbacks and AnchorInfo for AnchorHoverInfo in Entry widget.
See attachments. 2012/5/22 Boris Faure : > If you want to contribute directly to the svn, send us an info.txt > (just like the other ones in devs/) and your public ssh key. > Thank you for your work on python-elementary. > -- > Boris Faure Login: kuuko IRC Nick: kuuko Name: Kai Huuhko Location: Helsinki, Finland E-Mail:kai.huu...@gmail.com WWW: http://www.kaihuuhko.com/ Managing: none Contributing: Python bindings Platform: Funtoo (Linux) GeoData: 60.230490 24.926659 id_rsa.pub Description: Binary data -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] python-elementary: Add missing callbacks and AnchorInfo for AnchorHoverInfo in Entry widget.
You're in! Welcome! -- Boris Faure -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] python-elementary: Add missing callbacks and AnchorInfo for AnchorHoverInfo in Entry widget.
Thanks! I'll commit the patches I have pending on this list once I get everything set up. 2012/5/22 Boris Faure : > You're in! Welcome! > -- > Boris Faure -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: billiob IN trunk/devs: . kuuko
congratulations! with great power comes great responsibility. On May 22, 2012 6:42 PM, "Enlightenment SVN" wrote: > Log: > welcome to kuuko! > > Author: billiob > Date: 2012-05-22 02:42:27 -0700 (Tue, 22 May 2012) > New Revision: 71310 > Trac: http://trac.enlightenment.org/e/changeset/71310 > > Added: > trunk/devs/kuuko/ trunk/devs/kuuko/id_rsa.pub trunk/devs/kuuko/info.txt > > > > -- > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > ___ > enlightenment-svn mailing list > enlightenment-...@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: kuuko IN trunk/BINDINGS/python/python-elementary: elementary include/elementary
great! this is your first commit as a committer. i bet you are doing good job for efl :) On May 22, 2012 8:27 PM, "Enlightenment SVN" wrote: > Log: > python-elementary: Align Panel to C api. > > > Author: kuuko > Date: 2012-05-22 04:26:36 -0700 (Tue, 22 May 2012) > New Revision: 71317 > Trac: http://trac.enlightenment.org/e/changeset/71317 > > Modified: > > trunk/BINDINGS/python/python-elementary/elementary/elementary.c_elementary_panel.pxi > trunk/BINDINGS/python/python-elementary/include/elementary/c_elementary.pxd > > Modified: > trunk/BINDINGS/python/python-elementary/elementary/elementary.c_elementary_panel.pxi > === > --- > trunk/BINDINGS/python/python-elementary/elementary/elementary.c_elementary_panel.pxi >2012-05-22 11:13:15 UTC (rev 71316) > +++ > trunk/BINDINGS/python/python-elementary/elementary/elementary.c_elementary_panel.pxi >2012-05-22 11:26:36 UTC (rev 71317) > @@ -49,17 +49,4 @@ > def toggle(self): > elm_panel_toggle(self.obj) > > -def content_set(self, c_evas.Object content): > -cdef c_evas.Evas_Object *o > -if content is not None: > -o = content.obj > -else: > -o = NULL > -elm_object_part_content_set(self.obj, NULL, o) > - > -property content: > -def __set__(self, c_evas.Object content): > -self.content_set(content) > - > - > _elm_widget_type_register("panel", Panel) > > Modified: > trunk/BINDINGS/python/python-elementary/include/elementary/c_elementary.pxd > === > --- > trunk/BINDINGS/python/python-elementary/include/elementary/c_elementary.pxd > 2012-05-22 11:13:15 UTC (rev 71316) > +++ > trunk/BINDINGS/python/python-elementary/include/elementary/c_elementary.pxd > 2012-05-22 11:26:36 UTC (rev 71317) > @@ -211,10 +211,10 @@ > ELM_OBJECT_SELECT_MODE_MAX > > ctypedef enum Elm_Panel_Orient: > -ELM_PANEL_ORIENT_TOP, > -ELM_PANEL_ORIENT_BOTTOM, > -ELM_PANEL_ORIENT_LEFT, > -ELM_PANEL_ORIENT_RIGHT, > +ELM_PANEL_ORIENT_TOP > +ELM_PANEL_ORIENT_BOTTOM > +ELM_PANEL_ORIENT_LEFT > +ELM_PANEL_ORIENT_RIGHT > > ctypedef enum Elm_Policy: > ELM_POLICY_QUIT > @@ -1004,13 +1004,13 @@ > evas.c_evas.Eina_List *elm_menu_item_subitems_get(Elm_Object_Item > *item) > void elm_menu_item_icon_name_set(Elm_Object_Item *it, const_char_ptr > icon) > > -# Panel > +# Panel (api:DONE cb:N/A test:TODO doc:TODO) > evas.c_evas.Evas_Object *elm_panel_add(evas.c_evas.Evas_Object *parent) > -void elm_panel_orient_set(evas.c_evas.Evas_Object *obj, > Elm_Panel_Orient orient) > -Elm_Panel_Orient elm_panel_orient_get(evas.c_evas.Evas_Object *obj) > -void elm_panel_hidden_set(evas.c_evas.Evas_Object *obj, > evas.c_evas.Eina_Bool hidden) > -evas.c_evas.Eina_Bool elm_panel_hidden_get(evas.c_evas.Evas_Object > *obj) > -void elm_panel_toggle(evas.c_evas.Evas_Object *obj) > +void elm_panel_orient_set(evas.c_evas.Evas_Object > *obj, Elm_Panel_Orient orient) > +Elm_Panel_Orient elm_panel_orient_get(evas.c_evas.Evas_Object > *obj) > +void elm_panel_hidden_set(evas.c_evas.Evas_Object > *obj, evas.c_evas.Eina_Bool hidden) > +evas.c_evas.Eina_Boolelm_panel_hidden_get(evas.c_evas.Evas_Object > *obj) > +void elm_panel_toggle(evas.c_evas.Evas_Object > *obj) > > # Progressbar object (api:DONE cb:DONE test:DONE doc:TODO) > evas.c_evas.Evas_Object *elm_progressbar_add(evas.c_evas.Evas_Object > *parent) > > > > -- > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > ___ > enlightenment-svn mailing list > enlightenment-...@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: jaehwan trunk/elementary/src/lib
changelog please. and for the backport as well. On May 22, 2012 7:33 PM, "Enlightenment SVN" wrote: > Log: > The parent of elm_menu_add shouldn't be a edje object. > > > Author: jaehwan > Date: 2012-05-22 03:33:14 -0700 (Tue, 22 May 2012) > New Revision: 71314 > Trac: http://trac.enlightenment.org/e/changeset/71314 > > Modified: > trunk/elementary/src/lib/elm_toolbar.c > > Modified: trunk/elementary/src/lib/elm_toolbar.c > === > --- trunk/elementary/src/lib/elm_toolbar.c 2012-05-22 10:28:15 UTC > (rev 71313) > +++ trunk/elementary/src/lib/elm_toolbar.c 2012-05-22 10:33:14 UTC > (rev 71314) > @@ -576,7 +576,7 @@ > static void > _item_menu_create(Widget_Data *wd, Elm_Toolbar_Item *item) > { > - item->o_menu = elm_menu_add(VIEW(item)); > + item->o_menu = elm_menu_add(WIDGET(item)); >item->menu = EINA_TRUE; >if (wd->menu_parent) > elm_menu_parent_set(item->o_menu, wd->menu_parent); > > > > -- > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > ___ > enlightenment-svn mailing list > enlightenment-...@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] python-elementary: Add missing callbacks and AnchorInfo for AnchorHoverInfo in Entry widget.
On Tue, 22 May 2012 13:09:49 +0300 Kai Huuhko wrote: > Thanks! I'll commit the patches I have pending on this list once I get > everything set up. > > 2012/5/22 Boris Faure : > > You're in! Welcome! Yay! Congratulations and welcome. -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. signature.asc Description: PGP signature -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Cedric is lazy to.
On Tue, 22 May 2012 10:26:03 +1000 David Seikel wrote: > Just a reminder to Cedric to fix up what he broke in edje_cc. It > falls asleep quite often, never stopping. He said last night in IRC > that disabling glib integration will fix that, but it made no > difference. > > Trying to compile latest SVN I have to "killall -TERM edje_cc" all the > damn time. Seems to be about half of the time it's needed. That was painful. Had to kill edje_cc every few minutes, but I was busy doing other stuff. So the entire SVN compile took all day. I should have just put "sleep 300; killall -KILL edje_cc" in a loop. -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. signature.asc Description: PGP signature -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: jaehwan IN trunk/elementary: . data/themes/widgets src/bin src/lib
Hi, what's the use case in setting a maximum number of items manually? To me this seems like a hack. It should be defined based on the available space. Otherwise you'll get horrible user interfaces by changing screen resolution, or even screen orientation in mobile devices. Then please explain why it's needed, or remove such api. Regards, -- Gustavo On Tue, May 22, 2012 at 2:18 AM, Enlightenment SVN < no-re...@enlightenment.org> wrote: > Log: > Toolbar: Add the more panel feature in toolbar. When it is the > ELM_TOOLBAR_SHRINK_EXPAND mode and the max item is set, the items over max > number are located in more panel. > The APIs are added for this feature.(elm_toolbar_more_item_get, > elm_toolbar_items_max_set/get) > > > Author: jaehwan > Date: 2012-05-21 22:18:12 -0700 (Mon, 21 May 2012) > New Revision: 71297 > Trac: http://trac.enlightenment.org/e/changeset/71297 > > Modified: > trunk/elementary/ChangeLog > trunk/elementary/data/themes/widgets/toolbar.edc > trunk/elementary/src/bin/test_toolbar.c > trunk/elementary/src/lib/elm_toolbar.c > trunk/elementary/src/lib/elm_toolbar.h > > Modified: trunk/elementary/ChangeLog > === > --- trunk/elementary/ChangeLog 2012-05-22 04:55:49 UTC (rev 71296) > +++ trunk/elementary/ChangeLog 2012-05-22 05:18:12 UTC (rev 71297) > @@ -77,3 +77,9 @@ > >* Fix fileselector selection done bug and pass the right string. > > +2012-05-22 Jaehwan Kim > + > + * Toolbar: Add the more panel feature in toolbar. > +When it is the ELM_TOOLBAR_SHRINK_EXPAND mode and the max item is > set, > +the items over max number are located in more panel. > +The APIs are added for this feature.(elm_toolbar_more_item_get, > elm_toolbar_items_max_set/get) > > Modified: trunk/elementary/data/themes/widgets/toolbar.edc > === > --- trunk/elementary/data/themes/widgets/toolbar.edc2012-05-22 > 04:55:49 UTC (rev 71296) > +++ trunk/elementary/data/themes/widgets/toolbar.edc2012-05-22 > 05:18:12 UTC (rev 71297) > @@ -131,6 +131,175 @@ >} > } > > +group { name: "elm/toolbar/more/default"; > + images { > + image: "toolbar_separator_h.png" COMP; > + } > + parts { > + part { name: "base"; > + mouse_events: 1; > + description { state: "default" 0.0; > +rel1.relative: 0.0 0.0; > +rel2.relative: 1.0 0.0; > +image { > + normal: "bt_dis_base.png"; > + border: 4 4 4 4; > +} > +image.middle: SOLID; > + } > + description { state: "open" 0.0; > +inherit: "default" 0.0; > +rel2.relative: 1.0 1.0; > + } > + description { state: "open2" 0.0; > +inherit: "default" 0.0; > +rel2.relative: 1.0 2.0; > + } > + } > + part { name: "clipper"; > + type: RECT; > + mouse_events: 0; > + description { > +state: "default" 0.0; > +fixed: 1 1; > +rel1 { > + to: "base"; > +} > +rel2 { > + to: "base"; > +} > + } > + description { state: "open" 0.0; > +inherit: "default" 0.0; > +rel2.relative: 1.0 1.0; > + } > + description { state: "open2" 0.0; > +inherit: "default" 0.0; > +rel2.relative: 1.0 0.5; > + } > + } > + part { name: "clipper2"; > + type: RECT; > + mouse_events: 0; > + description { > +state: "default" 0.0; > +fixed: 1 1; > +rel1 { > + relative: 0.0 0.5; > + to: "base"; > +} > +rel2 { > + to: "base"; > +} > + } > + description { state: "open" 0.0; > +inherit: "default" 0.0; > +rel1.relative: 0.0 1.0; > + } > + description { state: "open2" 0.0; > +inherit: "default" 0.0; > +rel1.relative: 0.0 0.5; > + } > + } > + part { name: "elm.swallow.content"; > + clip_to: "clipper"; > + type: SWALLOW; > + description { > +state: "default" 0.0; > +fixed: 1 1; > +rel1.to: "clipper"; > +rel2.to: "clipper"; > + } > + } > + part { name: "elm.swallow.content2"; > + clip_to: "clipper2"; > + type: SWALLOW; > + description { > +state: "default" 0.0; > +fixed: 1 1; > +rel1.to: "clipper2"; > +rel2.to: "clipper2"; > + } > + } > + part { name: "separator2"; > + clip_to: "clipper2"; > + description { state: "default" 0.0; > +min: 2 3; > +max: 3; > +fixed: 1 1;
Re: [E-devel] Issue with xkbswitch
On 21/05/12 14:13, Carsten Haitzler (The Rasterman) wrote: > xkbswitch stuff will run the setxkbmap pretty much instantly - try stracing e. > my bet is x itself is taking a while to reconfigure the kbdmap server-side? > I guess that sometimes it just takes xkbswitch to start (and finish)... We can only solve it with ecore_x... -- Tom. -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib
On Mon, May 21, 2012 at 10:35 PM, Enlightenment SVN wrote: > cnp_debug("Got some HTML: Checking encoding is useful\n"); > data = notify->data; > + char *stripstr = malloc(sizeof(char) * (data->length + 1)); sizeof(char) is 1 by definition. Just malloc(data->length + 1). > ddata.format = ELM_SEL_FORMAT_HTML; > - ddata.data = data->data; > + ddata.data = stripstr; > ddata.len = data->length; Haven't checked the code to see how ddata.data is used afterwards, but this looks pretty wrong to me. -- Leandro -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Signal hooks on elm_icon
Hi, people. As you can see, there are signal callback hooks on elm_icon objects, in Elementary. Problem is this is an unused (none of the known themes listening to signals on icons) *and inconsistent* feature, since icons may as well be sole images (no Edje). Would it be OK to remove it or will I have to support it and mark as deprecated for an eventual next major release? Best regards, -- Gustavo Lima Chaves Computer Engineer @ ProFUSION Embedded Systems -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] python-elementary: Add missing callbacks and AnchorInfo for AnchorHoverInfo in Entry widget.
2012/5/22 Kai Huuhko > Thanks! I'll commit the patches I have pending on this list once I get > everything set up. > Super!! welcome :) > > 2012/5/22 Boris Faure : > > You're in! Welcome! > > -- > > Boris Faure > > > -- > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib
On Wed, May 23, 2012 at 1:02 AM, Leandro Pereira wrote: > On Mon, May 21, 2012 at 10:35 PM, Enlightenment SVN > wrote: >> cnp_debug("Got some HTML: Checking encoding is useful\n"); >> data = notify->data; >> + char *stripstr = malloc(sizeof(char) * (data->length + 1)); > > sizeof(char) is 1 by definition. Just malloc(data->length + 1). ok > >> ddata.format = ELM_SEL_FORMAT_HTML; >> - ddata.data = data->data; >> + ddata.data = stripstr; >> ddata.len = data->length; > > Haven't checked the code to see how ddata.data is used afterwards, but > this looks pretty wrong to me. then mail me after checking :P i added free stripstr routine. Thanks > > -- > Leandro > > -- > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib
The most I prefer is to use sizeof( variable ); No harmful for performance and would be better if the buffer type is changed. -Original Message- From: "Enlightenment SVN" To: ; Cc: Sent: 2012-05-23 (수) 09:53:08 Subject: E SVN: hyoyoung trunk/elementary/src/lib Log: elementary/cnp: don't calc sizeof char at buffer malloc Author: hyoyoung Date: 2012-05-22 17:53:07 -0700 (Tue, 22 May 2012) New Revision: 71337 Trac: http://trac.enlightenment.org/e/changeset/71337 Modified: trunk/elementary/src/lib/elm_cnp.c Modified: trunk/elementary/src/lib/elm_cnp.c === --- trunk/elementary/src/lib/elm_cnp.c2012-05-23 00:51:11 UTC (rev 71336) +++ trunk/elementary/src/lib/elm_cnp.c2012-05-23 00:53:07 UTC (rev 71337) @@ -785,7 +785,7 @@ char *mkupstr; data = notify->data; - str = malloc(sizeof(char) * (data->length + 1)); + str = malloc((data->length + 1)); if (!str) return 0; strncpy(str, (char *)data->data, data->length); str[data->length] = '\0'; @@ -840,7 +840,7 @@ } else { -stripstr = p = malloc(data->length * sizeof(char) + 1); +stripstr = p = malloc(data->length + 1); if (!stripstr) return 0; memcpy(stripstr, data->data, data->length); stripstr[data->length] = 0; @@ -985,7 +985,7 @@ cnp_debug("Got some HTML: Checking encoding is useful\n"); data = notify->data; - char *stripstr = malloc(sizeof(char) * (data->length + 1)); + char *stripstr = malloc(data->length + 1); if (!stripstr) return 0; strncpy(stripstr, (char *)data->data, data->length); stripstr[data->length] = '\0'; -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-svn mailing list enlightenment-...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-svn -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib
FYI, sizeof will be computed at the compile time. -Original Message- From: "ChunEon Park"To: ; ; Cc: Sent: 2012-05-23 (수) 10:49:24 Subject: Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib The most I prefer is to use sizeof( variable ); No harmful for performance and would be better if the buffer type is changed. -Original Message- From: "Enlightenment SVN" @enlightenment.org> To: @lists.sourceforge.net>; Cc: Sent: 2012-05-23 (수) 09:53:08 Subject: E SVN: hyoyoung trunk/elementary/src/lib Log: elementary/cnp: don't calc sizeof char at buffer malloc Author: hyoyoung Date: 2012-05-22 17:53:07 -0700 (Tue, 22 May 2012) New Revision: 71337 Trac: http://trac.enlightenment.org/e/changeset/71337 Modified: trunk/elementary/src/lib/elm_cnp.c Modified: trunk/elementary/src/lib/elm_cnp.c === --- trunk/elementary/src/lib/elm_cnp.c2012-05-23 00:51:11 UTC (rev 71336) +++ trunk/elementary/src/lib/elm_cnp.c2012-05-23 00:53:07 UTC (rev 71337) @@ -785,7 +785,7 @@ char *mkupstr; data = notify->data; - str = malloc(sizeof(char) * (data->length + 1)); + str = malloc((data->length + 1)); if (!str) return 0; strncpy(str, (char *)data->data, data->length); str[data->length] = '\0'; @@ -840,7 +840,7 @@ } else { -stripstr = p = malloc(data->length * sizeof(char) + 1); +stripstr = p = malloc(data->length + 1); if (!stripstr) return 0; memcpy(stripstr, data->data, data->length); stripstr[data->length] = 0; @@ -985,7 +985,7 @@ cnp_debug("Got some HTML: Checking encoding is useful\n"); data = notify->data; - char *stripstr = malloc(sizeof(char) * (data->length + 1)); + char *stripstr = malloc(data->length + 1); if (!stripstr) return 0; strncpy(stripstr, (char *)data->data, data->length); stripstr[data->length] = '\0'; -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-svn mailing list enlightenment-...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-svn -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib
Maybe it's best time to talk about sizeof(char) Do we need to sizeof(char)? I just that is problem of coding convention. such as (a == 0) and (!a). Is there any predefined convention about this case? On Wed, May 23, 2012 at 10:52 AM, ChunEon Park wrote: > FYI, sizeof will be computed at the compile time. > > > -Original Message- > From: "ChunEon Park"> To: ; > ; > Cc: > Sent: 2012-05-23 (수) 10:49:24 > Subject: Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib > > > The most I prefer is to use sizeof( variable ); > > > No harmful for performance and would be better if the buffer type is changed. > > > > > -Original Message- > From: "Enlightenment SVN" @enlightenment.org> > To: @lists.sourceforge.net>; > Cc: > Sent: 2012-05-23 (수) 09:53:08 > Subject: E SVN: hyoyoung trunk/elementary/src/lib > > > Log: > elementary/cnp: don't calc sizeof char at buffer malloc > > > > Author: hyoyoung > Date: 2012-05-22 17:53:07 -0700 (Tue, 22 May 2012) > New Revision: 71337 > Trac: http://trac.enlightenment.org/e/changeset/71337 > > > Modified: > trunk/elementary/src/lib/elm_cnp.c > > > Modified: trunk/elementary/src/lib/elm_cnp.c > === > --- trunk/elementary/src/lib/elm_cnp.c2012-05-23 00:51:11 UTC (rev 71336) > +++ trunk/elementary/src/lib/elm_cnp.c2012-05-23 00:53:07 UTC (rev 71337) > @@ -785,7 +785,7 @@ > char *mkupstr; > > > data = notify->data; > - str = malloc(sizeof(char) * (data->length + 1)); > + str = malloc((data->length + 1)); > if (!str) return 0; > strncpy(str, (char *)data->data, data->length); > str[data->length] = '\0'; > @@ -840,7 +840,7 @@ > } > else > { > - stripstr = p = malloc(data->length * sizeof(char) + 1); > + stripstr = p = malloc(data->length + 1); > if (!stripstr) return 0; > memcpy(stripstr, data->data, data->length); > stripstr[data->length] = 0; > @@ -985,7 +985,7 @@ > > > cnp_debug("Got some HTML: Checking encoding is useful\n"); > data = notify->data; > - char *stripstr = malloc(sizeof(char) * (data->length + 1)); > + char *stripstr = malloc(data->length + 1); > if (!stripstr) return 0; > strncpy(stripstr, (char *)data->data, data->length); > stripstr[data->length] = '\0'; > > > > > -- > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > ___ > enlightenment-svn mailing list > enlightenment-...@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > -- > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: jaehwan IN trunk/elementary: . data/themes/widgets src/bin src/lib
Dear Gustavo 2012년 5월 23일 수요일에 Gustavo Sverzut Barbieri님이 작성: > Hi, > > what's the use case in setting a maximum number of items manually? > If we want to expand the size of items as window size, we will use ELM_TOOLBAR_SHRINK_EXPAND mode. At that time, if the items are more than what we want to show, we should limit the number of visible items. So I limited by using maximum number. If I want to show 5 items among the 12 items regardless of window size, is there any other method? > To me this seems like a hack. It should be defined based on the available > space. Otherwise you'll get horrible user interfaces by changing screen > resolution, or even screen orientation in mobile devices. > In current toolbar, there are more item. If the more item is clicked, the menu widget is shown the below of toolbar. It is shown not available space, too. I think the location of more panel is not a problem. If there are some ugly user interface by changing resolution, I'll fix it. Thanks for your advice and if there is any alternative, please explain it. Regards, -- Jaehwan Kim. > > Then please explain why it's needed, or remove such api. > > Regards, > -- Gustavo > > On Tue, May 22, 2012 at 2:18 AM, Enlightenment SVN < > no-re...@enlightenment.org> wrote: > > > Log: > > Toolbar: Add the more panel feature in toolbar. When it is the > > ELM_TOOLBAR_SHRINK_EXPAND mode and the max item is set, the items over > max > > number are located in more panel. > > The APIs are added for this feature.(elm_toolbar_more_item_get, > > elm_toolbar_items_max_set/get) > > > > > > Author: jaehwan > > Date: 2012-05-21 22:18:12 -0700 (Mon, 21 May 2012) > > New Revision: 71297 > > Trac: http://trac.enlightenment.org/e/changeset/71297 > > > > Modified: > > trunk/elementary/ChangeLog > > trunk/elementary/data/themes/widgets/toolbar.edc > > trunk/elementary/src/bin/test_toolbar.c > > trunk/elementary/src/lib/elm_toolbar.c > > trunk/elementary/src/lib/elm_toolbar.h > > > > Modified: trunk/elementary/ChangeLog > > === > > --- trunk/elementary/ChangeLog 2012-05-22 04:55:49 UTC (rev 71296) > > +++ trunk/elementary/ChangeLog 2012-05-22 05:18:12 UTC (rev 71297) > > @@ -77,3 +77,9 @@ > > > >* Fix fileselector selection done bug and pass the right string. > > > > +2012-05-22 Jaehwan Kim > > + > > + * Toolbar: Add the more panel feature in toolbar. > > +When it is the ELM_TOOLBAR_SHRINK_EXPAND mode and the max item > is > > set, > > +the items over max number are located in more panel. > > +The APIs are added for this feature.(elm_toolbar_more_item_get, > > elm_toolbar_items_max_set/get) > > > > Modified: trunk/elementary/data/themes/widgets/toolbar.edc > > === > > --- trunk/elementary/data/themes/widgets/toolbar.edc2012-05-22 > > 04:55:49 UTC (rev 71296) > > +++ trunk/elementary/data/themes/widgets/toolbar.edc2012-05-22 > > 05:18:12 UTC (rev 71297) > > @@ -131,6 +131,175 @@ > >} > > } > > > > +group { name: "elm/toolbar/more/default"; > > + images { > > + image: "toolbar_separator_h.png" COMP; > > + } > > + parts { > > + part { name: "base"; > > + mouse_events: 1; > > + description { state: "default" 0.0; > > +rel1.relative: 0.0 0.0; > > +rel2.relative: 1.0 0.0; > > +image { > > + normal: "bt_dis_base.png"; > > + border: 4 4 4 4; > > +} > > +image.middle: SOLID; > > + } > > + description { state: "open" 0.0; > > +inherit: "default" 0.0; > > +rel2.relative: 1.0 1.0; > > + } > > + description { state: "open2" 0.0; > > +inherit: "default" 0.0; > > +rel2.relative: 1.0 2.0; > > + } > > + } > > + part { name: "clipper"; > > + type: RECT; > > + mouse_events: 0; > > + description { > > +state: "default" 0.0; > > +fixed: 1 1; > > +rel1 { > > + to: "base"; > > +} > > +rel2 { > > + to: "base"; > > + -- > Gustavo Sverzut Barbieri > http://profusion.mobi embedded systems > -- > MSN: barbi...@gmail.com > Skype: gsbarbieri > Mobile: +55 (19) 9225-2202 > > -- > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.so