[EPEL-devel] Re: Requesting branches for epel9
On Thu, Dec 16, 2021 at 6:26 AM Matthew Miller wrote: > > On Tue, Dec 14, 2021 at 06:31:04AM -0500, Stephen John Smoogen wrote: > > > Where is that checklist? I found > > I don't know myself. > > Fair -- a lot of this stuff is individual experience and wisdom that we > haven't recorded, but need to. > > > > > But it seems like "request an EPEL branch" should generally be either > > > "Okay! > > > Doing that automatically now" or "Oh, this is in EL, sorry"*. What are the > > > other cases? > > > > As far as I know this isn't about requesting EPEL branches, as much as > > requesting any branches by hand. If I add something to Fedora rawhide > > and then ask for a F34 branch, the same issues can happen. Remember > > our build infrastructure is a pile of band-aids on top of duct tape on > > top of bungee cords. Lots of tools are written for a toolchain which > > existed years ago and have been hacked to make it work with whatever > > new initiative that comes into play. 'Unexpected' side effects and > > corner cases happen all the time and the fixing of them tends to add > > new ones. > > Sure. But also, asking people to spend a lot of their time running > grunt-work tasks means that they have less time to fix when things break, > let alone re-engineer away some of that tech debt. It seems like we should > be able to automate the simple cases (adding F34 and F35 branches should be > even easier, since we don't have the "is it in EL?" question even). > It is also possible to automate the "is it in EL?" question too, since we now have access to a Koji instance we can query for that information. According to the CentOS Stream 9 contributor guide[1], if it's in c9s-compose, then it's published content. [1]: https://docs.centos.org/en-US/stream-contrib/quickstart/#_whats_going_on_with_package_x -- 真実はいつも一つ！/ Always, there's only one truth! ___ epel-devel mailing list -- epel-devel@lists.fedoraproject.org To unsubscribe send an email to epel-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/epel-devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[EPEL-devel] Re: Requesting branches for epel9
On Wed, Dec 15, 2021 at 05:46:18PM +0100, Miroslav Suchý wrote: > Dne 14. 12. 21 v 17:12 Matthew Miller napsal(a): > > > > But it seems like "request an EPEL branch" should generally be either > > > > "Okay! > > > > Doing that automatically now" or "Oh, this is in EL, sorry"*. What are > > > > the > > > > other cases? > > > As far as I know this isn't about requesting EPEL branches, as much as > > > requesting any branches by hand. If I add something to Fedora rawhide > > > and then ask for a F34 branch, the same issues can happen. Remember > > > our build infrastructure is a pile of band-aids on top of duct tape on > > > top of bungee cords. Lots of tools are written for a toolchain which > > > existed years ago and have been hacked to make it work with whatever > > > new initiative that comes into play. 'Unexpected' side effects and > > > corner cases happen all the time and the fixing of them tends to add > > > new ones. > > Sure. But also, asking people to spend a lot of their time running > > grunt-work tasks means that they have less time to fix when things break, > > let alone re-engineer away some of that tech debt. It seems like we should > > be able to automate the simple cases (adding F34 and F35 branches should be > > even easier, since we don't have the "is it in EL?" question even). > > *nod* > > So ... the question is how can I help? Can you document the check-list? I > volunteer to start writing the script. So, I suspect the epel-devel list isn't really the place to discuss this (I would think devel list + direct engagement with releng folks). That said, fedscm-admin _does_ do a bunch of checks currently. For branch requests for existing packages it checks that the requestor is a maintainer of that package and then just auto approves it. Those requests could potentially be automated (we have talked about it in releng land, but it's also a bit difficult due to all the perms you have to have). For new packages it does a bunch of checks like 'is the reviewer in the packager group', did the reviewer set 'fedora-review: +', are the requested branches valid, etc, etc https://pagure.io/fedscm-admin/blob/main/f/fedscm_admin/utils.py#_285 I can't speak for the current folks doing the processing, but I did this for 3-4 years a long time ago. When I did it I looked for a lot of things it was hard to automate checks for, like "Did this review check list a bunch of things, or just say 'ok, approved'". I would typically look closely at those and find things that were missed. I also recall several reviews that I blocked due to legal reasons where the reviewer didn't understand things correctly. That said, the volume of new packages is pretty high these days so I don't know how much extra scrutiny they are really getting. Perhaps it's time to just completely automate it and have better ways to clean up if something bad gets in. kevin signature.asc Description: PGP signature ___ epel-devel mailing list -- epel-devel@lists.fedoraproject.org To unsubscribe send an email to epel-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/epel-devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[EPEL-devel] Re: Requesting branches for epel9
Dne 14. 12. 21 v 17:12 Matthew Miller napsal(a): But it seems like "request an EPEL branch" should generally be either "Okay! Doing that automatically now" or "Oh, this is in EL, sorry"*. What are the other cases? As far as I know this isn't about requesting EPEL branches, as much as requesting any branches by hand. If I add something to Fedora rawhide and then ask for a F34 branch, the same issues can happen. Remember our build infrastructure is a pile of band-aids on top of duct tape on top of bungee cords. Lots of tools are written for a toolchain which existed years ago and have been hacked to make it work with whatever new initiative that comes into play. 'Unexpected' side effects and corner cases happen all the time and the fixing of them tends to add new ones. Sure. But also, asking people to spend a lot of their time running grunt-work tasks means that they have less time to fix when things break, let alone re-engineer away some of that tech debt. It seems like we should be able to automate the simple cases (adding F34 and F35 branches should be even easier, since we don't have the "is it in EL?" question even). *nod* So ... the question is how can I help? Can you document the check-list? I volunteer to start writing the script. Miroslav ___ epel-devel mailing list -- epel-devel@lists.fedoraproject.org To unsubscribe send an email to epel-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/epel-devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[EPEL-devel] Re: Requesting branches for epel9
On Tue, Dec 14, 2021 at 06:31:04AM -0500, Stephen John Smoogen wrote: > > Where is that checklist? I found > I don't know myself. Fair -- a lot of this stuff is individual experience and wisdom that we haven't recorded, but need to. > > But it seems like "request an EPEL branch" should generally be either "Okay! > > Doing that automatically now" or "Oh, this is in EL, sorry"*. What are the > > other cases? > > As far as I know this isn't about requesting EPEL branches, as much as > requesting any branches by hand. If I add something to Fedora rawhide > and then ask for a F34 branch, the same issues can happen. Remember > our build infrastructure is a pile of band-aids on top of duct tape on > top of bungee cords. Lots of tools are written for a toolchain which > existed years ago and have been hacked to make it work with whatever > new initiative that comes into play. 'Unexpected' side effects and > corner cases happen all the time and the fixing of them tends to add > new ones. Sure. But also, asking people to spend a lot of their time running grunt-work tasks means that they have less time to fix when things break, let alone re-engineer away some of that tech debt. It seems like we should be able to automate the simple cases (adding F34 and F35 branches should be even easier, since we don't have the "is it in EL?" question even). -- Matthew Miller Fedora Project Leader ___ epel-devel mailing list -- epel-devel@lists.fedoraproject.org To unsubscribe send an email to epel-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/epel-devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[EPEL-devel] Re: Requesting branches for epel9
On Mon, 13 Dec 2021 at 22:20, Matthew Miller wrote: > > On Mon, Dec 13, 2021 at 09:40:19AM -0500, Stephen John Smoogen wrote: > > It is a fairly manual process where a person volunteers to sit in > > front of the firehose every day and deal with these requests. The > > person who has to process them has a checklist of policy items they > > have to confirm/check to make sure the branch is possible. > > Where is that checklist? I found I don't know myself. > https://docs.pagure.org/releng/sop_process_dist_git_requests.html, but it > refers to a tool which is deprecated in favor of another one, at > https://pagure.io/fedscm-admin/, but none of those places have a clear > articulation of the policy items. > > I get human sanity check of new package requests is good, although really > ideally I would hope that wouldn't fall to the rel-eng/scm firehose > volunteers. > > But it seems like "request an EPEL branch" should generally be either "Okay! > Doing that automatically now" or "Oh, this is in EL, sorry"*. What are the > other cases? > As far as I know this isn't about requesting EPEL branches, as much as requesting any branches by hand. If I add something to Fedora rawhide and then ask for a F34 branch, the same issues can happen. Remember our build infrastructure is a pile of band-aids on top of duct tape on top of bungee cords. Lots of tools are written for a toolchain which existed years ago and have been hacked to make it work with whatever new initiative that comes into play. 'Unexpected' side effects and corner cases happen all the time and the fixing of them tends to add new ones. > > * I'm very sad that this isn't "So, would you like to do it anyway, and then > make a module?", but c'est la vie -- Stephen J Smoogen. Let us be kind to one another, for most of us are fighting a hard battle. -- Ian MacClaren ___ epel-devel mailing list -- epel-devel@lists.fedoraproject.org To unsubscribe send an email to epel-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/epel-devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[EPEL-devel] Re: Requesting branches for epel9
On Mon, Dec 13, 2021 at 09:40:19AM -0500, Stephen John Smoogen wrote: > It is a fairly manual process where a person volunteers to sit in > front of the firehose every day and deal with these requests. The > person who has to process them has a checklist of policy items they > have to confirm/check to make sure the branch is possible. Where is that checklist? I found https://docs.pagure.org/releng/sop_process_dist_git_requests.html, but it refers to a tool which is deprecated in favor of another one, at https://pagure.io/fedscm-admin/, but none of those places have a clear articulation of the policy items. I get human sanity check of new package requests is good, although really ideally I would hope that wouldn't fall to the rel-eng/scm firehose volunteers. But it seems like "request an EPEL branch" should generally be either "Okay! Doing that automatically now" or "Oh, this is in EL, sorry"*. What are the other cases? * I'm very sad that this isn't "So, would you like to do it anyway, and then make a module?", but c'est la vie -- Matthew Miller Fedora Project Leader ___ epel-devel mailing list -- epel-devel@lists.fedoraproject.org To unsubscribe send an email to epel-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/epel-devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[EPEL-devel] Re: Requesting branches for epel9
On Mon, 13 Dec 2021 at 09:25, Miroslav Suchý wrote: > > Hi. > > I have two questions regarding epel9: > > 1) I have requested dozen of epe9 branches for my packages. It was 20+ hours > ago. E.g. > https://pagure.io/releng/fedora-scm-requests/issue/39402 > Is it manual process? Or is the automation broken? > It is a fairly manual process where a person volunteers to sit in front of the firehose every day and deal with these requests. The person who has to process them has a checklist of policy items they have to confirm/check to make sure the branch is possible. > 2) It was quite pain to go through all my packages and find which ones > actually have EPEL version. And which ones are in > RHEL9 now. I would actually appreciate if there were mass package request. > Closing such BZ as WONTFIX is a) rare b) much > easier than come up with the list. Does someone plan to do such mass report > for EPEL9? Or should I do that? Or is it bad > idea? > No idea on this one. -- Stephen J Smoogen. Let us be kind to one another, for most of us are fighting a hard battle. -- Ian MacClaren ___ epel-devel mailing list -- epel-devel@lists.fedoraproject.org To unsubscribe send an email to epel-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/epel-devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[EPEL-devel] Re: Requesting branches for epel9
On 13. 12. 21 15:25, Miroslav Suchý wrote: Hi. I have two questions regarding epel9: 1) I have requested dozen of epe9 branches for my packages. It was 20+ hours ago. E.g. https://pagure.io/releng/fedora-scm-requests/issue/39402 Is it manual process? Or is the automation broken? The tickets are processed by automated scripts that are run manually by a couple of heroes. This quite unfortunately combines disadvantages of both automated and manual approach: - it takes a long time for requests to be processed - nobody needs to check the requests for sanity A FESCo ticket that touches this topic is https://pagure.io/fesco/issue/2115 2) It was quite pain to go through all my packages and find which ones actually have EPEL version. And which ones are in RHEL9 now... Note that fedpkg request-branch epel9 *should* fail if the component is already present in CentOS Stream 9: [python3.9 (rawhide)]$ fedpkg request-branch epel9 Could not execute request_branch: This package is already an EL package, therefore it cannot be in EPEL. If this is a mistake or you have an exception, please contact the Release Engineering team. -- Miro Hrončok -- Phone: +420777974800 IRC: mhroncok ___ epel-devel mailing list -- epel-devel@lists.fedoraproject.org To unsubscribe send an email to epel-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/epel-devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
