Re: [Evolution-hackers] Rethinking account management

2010-12-19 Thread Matthew Barnes 
On Sun, 2010-12-19 at 18:38 +, Rob Bradford wrote:
> > Signals:void(*load_error)   (ESourceRegistry *registry,
> > GFile *file,
> > GQuark error_domain,
> > gint error_code,
> > const gchar *error_message);
> 
> There is obviously a reason why you wrote this .. but I can't see it.
> Why can't you use const GError * here?

I've been second guessing myself on that too.  I think it was because I
was worried someone would write a signal handler that improperly frees
the GError, or propagates it, or some other memory-corrupting operation.
But I guess I was just being overly paranoid.  A const GError should
work fine.

___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers

Re: [Evolution-hackers] Rethinking account management

2010-12-19 Thread Rob Bradford 
>
> (I'm leaning away from having URI keys, favoring instead URI components
>  as separate keys from which a complete URI string can be formed.)

As someone who's used ESource in the past ..  I always found the old
way of doing it oh-so-confusing. I even added the following code to
dates:


/*
 * Also ensure that the sources contained within this
 * group have an appropriate uri setup. Removing the
 * absolute uri in favour of a relative one.
 */
source_list = e_source_group_peek_sources (group);

for (GSList *source_list_it = source_list; 
source_list_it != NULL;
source_list_it = g_slist_next 
(source_list_it))
{
ESource *source = (ESource 
*)source_list_it->data;

if (g_str_equal (e_source_peek_relative_uri 
(source), ""))
{
const gchar *uri = 
e_source_peek_absolute_uri (source);
gchar *path = g_filename_from_uri (uri, 
NULL, NULL);
gchar *base_name = g_path_get_basename 
(path);

e_source_set_absolute_uri (source, 
NULL);
e_source_set_relative_uri (source, 
base_name);

g_free (base_name);
g_free (path);
}
}

g_free (path);
g_free (new_uri);

Cheers,

Rob
___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers