[ewg] [PATCH] IB/iser: release host lock before error handling

[Erez Zilber]

Tziporet,

Please accept this patch. It fixes a bug in an error scenario in open-iscsi. 
This bug can lead to a deadlock.

In RH4 kernels, the scsi host template eh callbacks are called with
the host lock held. The reason that scsi-ml took this lock is more
historical and this locking was removed later. the open-iscsi eh
callbacks must release this lock when entering the function and lock
it again when exiting the function.

Signed-off-by: Erez Zilber <[EMAIL PROTECTED]>
---
 .../2.6.9_U3/release_host_lock_before_eh.patch |   63 
+++
 .../2.6.9_U4/release_host_lock_before_eh.patch |   63 
+++
 .../2.6.9_U5/release_host_lock_before_eh.patch |   63 
+++
 3 files changed, 189 insertions(+), 0 deletions(-)

diff --git a/kernel_patches/backport/2.6.9_U3/release_host_lock_before_eh.patch 
b/kernel_patches/backport/2.6.9_U3/release_host_lock_before_eh.patch
new file mode 100644
index 000..475b3f5
--- /dev/null
+++ b/kernel_patches/backport/2.6.9_U3/release_host_lock_before_eh.patch
@@ -0,0 +1,63 @@
+diff -rup linux-2.6.20/drivers/scsi/libiscsi.c 
linux-2.6.20-host-lock-fix/drivers/scsi/libiscsi.c
+--- linux-2.6.20/drivers/scsi/libiscsi.c   2007-02-04 20:44:54.0 
+0200
 linux-2.6.20-host-lock-fix/drivers/scsi/libiscsi.c 2007-06-10 
16:32:51.0 +0300
+@@ -972,12 +972,14 @@ int iscsi_eh_host_reset(struct scsi_cmnd
+   struct iscsi_conn *conn = session->leadconn;
+   int fail_session = 0;
+ 
++  spin_unlock_irq(host->host_lock);
+   spin_lock_bh(&session->lock);
+   if (session->state == ISCSI_STATE_TERMINATE) {
+ failed:
+   debug_scsi("failing host reset: session terminated "
+  "[CID %d age %d]\n", conn->id, session->age);
+   spin_unlock_bh(&session->lock);
++  spin_lock_irq(host->host_lock);
+   return FAILED;
+   }
+ 
+@@ -1009,6 +1011,7 @@ failed:
+   else
+   goto failed;
+   spin_unlock_bh(&session->lock);
++  spin_lock_irq(host->host_lock);
+ 
+   return SUCCESS;
+ }
+@@ -1162,17 +1165,20 @@ static void fail_command(struct iscsi_co
+ 
+ int iscsi_eh_abort(struct scsi_cmnd *sc)
+ {
++  struct Scsi_Host *shost = sc->device->host;
+   struct iscsi_cmd_task *ctask;
+   struct iscsi_conn *conn;
+   struct iscsi_session *session;
+   int rc;
+ 
++  spin_unlock_irq(shost->host_lock);
+   /*
+* if session was ISCSI_STATE_IN_RECOVERY then we may not have
+* got the command.
+*/
+   if (!sc->SCp.ptr) {
+   debug_scsi("sc never reached iscsi layer or it completed.\n");
++  spin_lock_irq(shost->host_lock);
+   return SUCCESS;
+   }
+ 
+@@ -1257,6 +1263,7 @@ success_cleanup:
+ 
+ success_rel_mutex:
+   mutex_unlock(&conn->xmitmutex);
++  spin_lock_irq(shost->host_lock);
+   return SUCCESS;
+ 
+ failed:
+@@ -1264,6 +1271,7 @@ failed:
+   mutex_unlock(&conn->xmitmutex);
+ 
+   debug_scsi("abort failed [sc %lx itt 0x%x]\n", (long)sc, ctask->itt);
++  spin_lock_irq(shost->host_lock);
+   return FAILED;
+ }
+ EXPORT_SYMBOL_GPL(iscsi_eh_abort);
diff --git a/kernel_patches/backport/2.6.9_U4/release_host_lock_before_eh.patch 
b/kernel_patches/backport/2.6.9_U4/release_host_lock_before_eh.patch
new file mode 100644
index 000..475b3f5
--- /dev/null
+++ b/kernel_patches/backport/2.6.9_U4/release_host_lock_before_eh.patch
@@ -0,0 +1,63 @@
+diff -rup linux-2.6.20/drivers/scsi/libiscsi.c 
linux-2.6.20-host-lock-fix/drivers/scsi/libiscsi.c
+--- linux-2.6.20/drivers/scsi/libiscsi.c   2007-02-04 20:44:54.0 
+0200
 linux-2.6.20-host-lock-fix/drivers/scsi/libiscsi.c 2007-06-10 
16:32:51.0 +0300
+@@ -972,12 +972,14 @@ int iscsi_eh_host_reset(struct scsi_cmnd
+   struct iscsi_conn *conn = session->leadconn;
+   int fail_session = 0;
+ 
++  spin_unlock_irq(host->host_lock);
+   spin_lock_bh(&session->lock);
+   if (session->state == ISCSI_STATE_TERMINATE) {
+ failed:
+   debug_scsi("failing host reset: session terminated "
+  "[CID %d age %d]\n", conn->id, session->age);
+   spin_unlock_bh(&session->lock);
++  spin_lock_irq(host->host_lock);
+   return FAILED;
+   }
+ 
+@@ -1009,6 +1011,7 @@ failed:
+   else
+   goto failed;
+   spin_unlock_bh(&session->lock);
++  spin_lock_irq(host->host_lock);
+ 
+   return SUCCESS;
+ }
+@@ -1162,17 +1165,20 @@ static void fail_command(struct iscsi_co
+ 
+ int iscsi_eh_abort(struct scsi_cmnd *sc)
+ {
++  struct Scsi_Host *shost = sc->device->host;
+   struct iscsi_cmd_task *ctask;
+   struct iscsi_conn *conn;
+  

[ewg] Re: suggested fix in iscsi RHEL backport

[Erez Zilber]

Michael S. Tsirkin wrote:

> Hi!
> I noticed that RHEL backports include a copy of include/scsi/iscsi_proto.h 
> from
> upstream kernel which is a large file, so carrying it around is a maintainance
> problem going forward.  Since this header includes protocol definitions, I 
> think
> we should check it out from upstream, always.
>
> Code for such a change can be found here:
> git.openfabrics.org/~mst/ofed_1_2_devel.git ofed_1_2
>
> Erez, do you agree?
> Can you take a look and comment whether we can include this in OFED 1.2?
>
>   

I agree.

Thanks,
Erez

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Re: [ofa-general] OFED 1.x (Gen 2) based SRP target code released!

[Erez Zilber]

>>> 
>> I'm trying to build srpt according to the instructions, but it does
>> not get built at all. Here's what I did:
>>
>> tar xzf OFED-1.2-rc3.tgz
>> cd OFED-1.2-rc3/SRPMS
>> rpm2cpio ofa_kernel-1.2-rc3.src.rpm |cpio -i
>> tar xzf ofa_kernel-1.2.tgz
>> cd ofa_kernel-1.2
>> patch -p1 < ~/srpt_inc/add_srpt_01.patch
>> patch -p1 < ~/srpt_inc/add_srpt_03.patch
>>   
>
> You forget to
> patch -p1 < ~/srpt_inc/add_srpt_04.patch
>
> -vu
You may want to add it to the README file (it is not mentioned there).
Is it documented anywhere in openfabrics wiki?

Erez


 


___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Mentioning bug #536 in the release notes

[Erez Zilber]

Tziporet, Michael,


I think that something should be said in the release notes about bug
#536. Something like:


When upgrading from older OFED versions, the installation script doesn't
stop the old OFED version before uninstalling it. Therefore, it is
recommended to stop the old OFED stack and only then upgrade to OFED 1.2.


Also, uninstalling OFED 1.2 doesn't stop the stack. It is recommended to
stop OFED before uninstalling it.


-- 

____

Erez Zilber | 972-9-971-7689

Software Engineer, Storage Team

Voltaire – _The Grid Backbone_

__

www.voltaire.com <http://www.voltaire.com/>



___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] [PATCH] IB/iser: fix wrong error message in open-iscsi installation

[Erez Zilber]

Tziporet, Vlad,


This patch fixes an error message in an installation script (build_env.sh). 
Please approve.

diff --git a/build_env.sh b/build_env.sh
index b757155..1781915 100644
--- a/build_env.sh
+++ b/build_env.sh
@@ -1336,7 +1336,7 @@ check_open_iscsi()
 else
 if [ "X${upgrade_open_iscsi}" != "Xyes" ]; then
 err_echo "Please uninstall 
${open_iscsi_rpm_name} before installing ${PACKAGE} with iSER support."
-echo "  Or put \"upgrade_open_iscsi=yes\" in 
the $CONFIG"
+echo "  Or put \"upgrade_open_iscsi=y\" in 
$CONFIG"
 exit 1
 fi
 fi
-- 
____

Erez Zilber   |  972-9-971-7689

Software Engineer, Storage Team

Voltaire – _The Grid Backbone_

 __

 www.voltaire.com <http://www.voltaire.com/>

<mailto:[EMAIL PROTECTED]>

  


___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Re: [PATCH] IB/iser: fix wrong error message in open-iscsi installation

[Erez Zilber]

Sorry. My mistake (I thought that since all other entries in ofed.conf use y/n, 
this one does the same).

Erez

Vladimir Sokolovsky wrote:
> Hi Erez,
> The original message seems to be right:
> In unattended installation you check  if [ "X${upgrade_open_iscsi}" !=
> "Xyes" ]; then ...
> 
> So, the message should include "yes" and not "y".
> 
> Regards,
> Vladimir
> 
> 
>> -Original Message-
>> From: Erez Zilber [mailto:[EMAIL PROTECTED]
>> Sent: Tuesday, June 12, 2007 2:17 PM
>> To: Tziporet Koren; Vladimir Sokolovsky
>> Cc: ewg@lists.openfabrics.org
>> Subject: [PATCH] IB/iser: fix wrong error message in
>> open-iscsi installation
>>
>> Tziporet, Vlad,
>>
>>
>> This patch fixes an error message in an installation script
>> (build_env.sh). Please approve.
>>
>> diff --git a/build_env.sh b/build_env.sh index b757155..1781915 100644
>> --- a/build_env.sh
>> +++ b/build_env.sh
>> @@ -1336,7 +1336,7 @@ check_open_iscsi()
>>  else
>>  if [ "X${upgrade_open_iscsi}" !=
>> "Xyes" ]; then
>>  err_echo "Please uninstall
>> ${open_iscsi_rpm_name} before installing ${PACKAGE} with iSER
>> support."
>> -echo "  Or put
>> \"upgrade_open_iscsi=yes\" in the $CONFIG"
>> +echo "  Or put
>> \"upgrade_open_iscsi=y\" in $CONFIG"
>>  exit 1
>>  fi
>>  fi
>> --
>> 
>>
>> Erez Zilber   |  972-9-971-7689
>>
>> Software Engineer, Storage Team
>>
>> Voltaire - _The Grid Backbone_
>>
>>  __
>>
>>  www.voltaire.com <http://www.voltaire.com/>
>>
>> <mailto:[EMAIL PROTECTED]>
>>
>> 
>>
>>
>>
> 



___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Re: [ofa-general] ANNOUNCE ofed backports for 2.6.22 kernel bits

[Erez Zilber]

> Erez, and other iser maintainers, I had a problem with RHEL4 iscsi backports
> (scsi_flush_work isn't exported) I decided that since it isn't
> called on older kernels it's reasonably safe to just comment it out,
> but would be interested to hear you opinion.
> See it in this sub-directory:
> kernel_patches/backport/2.6.9_U2/libiscsi_no_flush_to_2_6_9.patch
>   

This leads me to something that I thought about in the past. Old kernels
(i.e. the RH4 kernels) don't have the SCSI work queue. Therefore, I used
schedule_work instead of scsi_queue_work. Now, I cannot replace
scsi_flush_work with flush_workqueue because I'm using a workqueue which
does not belong to me (and, therefore, I cannot flush it).

I'm thinking about adding a backport that will create a workqueue for
each session in open-iscsi. With this, I can queue & flush. Mike - what
do you think about that? I think that creating a workqueue in open-iscsi
per session will be the closer thing to the SCSI workqueue that we have
in new kernels.

Erez

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Mentioning bug #536 in the release notes

[Erez Zilber]

Erez Zilber wrote:

> Tziporet, Michael,
>
>
> I think that something should be said in the release notes about bug
> #536. Something like:
>
>
> When upgrading from older OFED versions, the installation script doesn't
> stop the old OFED version before uninstalling it. Therefore, it is
> recommended to stop the old OFED stack and only then upgrade to OFED 1.2.
>
>
> Also, uninstalling OFED 1.2 doesn't stop the stack. It is recommended to
> stop OFED before uninstalling it.
>
>   
Tziporet,

What do you think? I think that it is worth mentioning because 2 days
ago I already saw that happening in our Boston office. They could not
understand why OFED 1.2 isn't functioning. The reason was that they
upgraded OFED 1.1 to 1.2 without stopping the stack. Mentioning that in
the release notes can really help.

Erez

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Re: [PATCH] IB/iser: make all fixes patches apply on full kernel source

[Erez Zilber]

Michael S. Tsirkin wrote:

> Since we'll have RC6, I'd like to add the following cosmetic change:
> move iscsi_scsi_makefile from kernel_patches/fixes to ofed_scripts,
> and use a softlink to put in in place.
>
> The solves the following problem: if I do "git clone" on ofed
> tree without -n, and try to apply the fixes patchset,
> I get a conflict on iscsi_scsi_makefile.patch simply because
> the makefile that this patch attempts to create is part
> of upstream kernel already.
>
> I think this is 0-risk and carries real benefit for developers
> who'll need to support OFED 1.2.
>
> Erez, do you agree? If yes, I'll ask Tziporet to approve, too.
>
I'm ok with it.


Thanks,

Erez


___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Re: [ofa-general] [PATCH 1/2] IB/iser: add open-iscsi over iSER support for RHAS4 in OFED scripts

[Erez Zilber]

Erez Zilber wrote:

> Add support for open-iscsi over iSER in RHAS4 in OFED's scripts.
>
> Signed-off-by: Erez Zilber <[EMAIL PROTECTED]>
> ---
>  build.sh |2 +-
>  build_env.sh |4 ++--
>  install.sh   |2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/build.sh b/build.sh
> index d54c55d..be2d1e6 100755
> --- a/build.sh
> +++ b/build.sh
> @@ -344,7 +344,7 @@ open-iscsi()
>  SuSE)
>   ex "$MV -f 
> ${RPM_DIR}/RPMS/$build_arch/${OPEN_ISCSI_SUSE_NAME}-${OPEN_ISCSI_VERSION}.${build_arch}.rpm
>  $RPMS"
>   ;;
> -redhat5)
> +redhat|redhat5)
>   ex "$MV -f 
> ${RPM_DIR}/RPMS/$build_arch/${OPEN_ISCSI_REDHAT_NAME}-${OPEN_ISCSI_VERSION}.${build_arch}.rpm
>  $RPMS"
>  ;;
>   *)
> diff --git a/build_env.sh b/build_env.sh
> index 6e65b21..49821b4 100644
> --- a/build_env.sh
> +++ b/build_env.sh
> @@ -135,7 +135,7 @@ IB_KERNEL_PACKAGES="${IB_KERNEL_PACKAGES
>  # Iser
>  # Currently iSER is supported only on SLES10 & RHEL5
>  case ${K_VER} in
> -2.6.16.*-*-*|2.6.*.el5)
> +2.6.16.*-*-*|2.6.*.el5|2.6.9-*.EL*)
>  IB_KERNEL_PACKAGES="${IB_KERNEL_PACKAGES} ib_iser"
>  ;;
>  esac
> @@ -1998,7 +1998,7 @@ set_package_deps()
>  ib_iser)
>   # Currently iSER is supported only on SLES10 & RHEL5
>  case ${K_VER} in
> -2.6.16.*-*-*|2.6.*.el5)
> +2.6.16.*-*-*|2.6.*.el5|2.6.9-*.EL*)
>  OFA_KERNEL_PACKAGES=$(echo "$OFA_KERNEL_PACKAGES 
> ib_verbs ${ll_driver} ib_iser" | tr -s ' ' '\n' | sort -n | uniq)
>  OFA_PACKAGES=$(echo "$OFA_PACKAGES kernel-ib" | 
> tr -s ' ' '\n' | sort -n | uniq)
>  EXTRA_PACKAGES=$(echo "$EXTRA_PACKAGES 
> open-iscsi" | tr -s ' ' '\n' | sort -rn | uniq)
> diff --git a/install.sh b/install.sh
> index f9ed6da..dadc144 100755
> --- a/install.sh
> +++ b/install.sh
> @@ -990,7 +990,7 @@ #fi
>  err_echo 
> "${OPEN_ISCSI_SUSE_NAME}-${OPEN_ISCSI_VERSION}.${build_arch}.rpm not found 
> under ${RPMS}."
>  fi
>  ;;
> -redhat5)
> +redhat|redhat5)
>   if [ -f 
> ${RPMS}/${OPEN_ISCSI_REDHAT_NAME}-${OPEN_ISCSI_VERSION}.${build_arch}.rpm ]; 
> then
>  ex "$RPM -Uhv --oldpackage 
> ${RPMS}/${OPEN_ISCSI_REDHAT_NAME}-${OPEN_ISCSI_VERSION}.${build_arch}.rpm"
>  else
>   

Vlad,

It seems that commit 553e284ffb2f380dc8d1451bfb3ad40165f04112 in
ofed_1_2_scripts.git is different from the patch that I submitted. For
example:

My patch:

@@ -135,7 +135,7 @@ IB_KERNEL_PACKAGES="${IB_KERNEL_PACKAGES
 # Iser
 # Currently iSER is supported only on SLES10 & RHEL5
 case ${K_VER} in
-2.6.16.*-*-*|2.6.*.el5)
+2.6.16.*-*-*|2.6.*.el5|2.6.9-*.EL*)
 IB_KERNEL_PACKAGES="${IB_KERNEL_PACKAGES} ib_iser"
 ;;
 esac


patch applied in ofed_1_2_scripts.git:
@@ -135,7 +135,7 @@ IB_KERNEL_PACKAGES="${IB_KERNEL_PACKAGES
 # Iser
 # Currently iSER is supported only on SLES10 & RHEL5
 case ${K_VER} in
-2.6.16.*-*-*|2.6.*.el5)
+2.6.16.*-*-*|2.6.*.el5|2.6.9-[3-5]*.EL*) <-- this line is different
 IB_KERNEL_PACKAGES="${IB_KERNEL_PACKAGES} ib_iser"
 ;;
 esac

Why is that?

Erez


___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Re: [ofa-general] [PATCH 1/2] IB/iser: add open-iscsi over iSER support for RHAS4 in OFED scripts

[Erez Zilber]

Vladimir Sokolovsky wrote:

>> Vlad,
>>
>> It seems that commit 553e284ffb2f380dc8d1451bfb3ad40165f04112 in
>> ofed_1_2_scripts.git is different from the patch that I submitted. For
>> example:
>>
>> My patch:
>>
>> @@ -135,7 +135,7 @@ IB_KERNEL_PACKAGES="${IB_KERNEL_PACKAGES
>>  # Iser
>>  # Currently iSER is supported only on SLES10 & RHEL5
>>  case ${K_VER} in
>> -2.6.16.*-*-*|2.6.*.el5)
>> +2.6.16.*-*-*|2.6.*.el5|2.6.9-*.EL*)
>>  IB_KERNEL_PACKAGES="${IB_KERNEL_PACKAGES} ib_iser"
>>  ;;
>>  esac
>>
>>
>> patch applied in ofed_1_2_scripts.git:
>> @@ -135,7 +135,7 @@ IB_KERNEL_PACKAGES="${IB_KERNEL_PACKAGES
>>  # Iser
>>  # Currently iSER is supported only on SLES10 & RHEL5
>>  case ${K_VER} in
>> -2.6.16.*-*-*|2.6.*.el5)
>> +2.6.16.*-*-*|2.6.*.el5|2.6.9-[3-5]*.EL*) <-- this line is
>> different
>>  IB_KERNEL_PACKAGES="${IB_KERNEL_PACKAGES} ib_iser"
>>  ;;
>>  esac
>>
>> Why is that?
>>
>> Erez
>
> You have added backport patches for RHEL4.0 U3, U4, U5.
> 2.6.9-*.EL* matches also U2. So, installation fails on RHEL 4.0 U2
> with your patch.
>
> Vladimir

You are right and I agree with your fix. Next time, just let me know if
you don't apply a patch as is.

Thanks,
Erez


___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Re: add_open_iscsi_h.patch

[Erez Zilber]

Michael S. Tsirkin wrote:

> Erez, add_open_iscsi_h currently does:
>
> -#include 
> +#include "iscsi_if.h"
>
> why is ths bit needed?
>

Strange. I remember that I couldn't build OFED 1.2 without it in the
past. I tried to rebuild it without this now, and it compiles
successfully, so let's remove that code.

Erez

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Re: add_open_iscsi_h.patch

[Erez Zilber]

Michael S. Tsirkin wrote:

> > Quoting Erez Zilber <[EMAIL PROTECTED]>:
> > Subject: Re: add_open_iscsi_h.patch
> >
> > Michael S. Tsirkin wrote:
> >
> > > Erez, add_open_iscsi_h currently does:
> > >
> > > -#include 
> > > +#include "iscsi_if.h"
> > >
> > > why is ths bit needed?
> > >
> >
> > Strange. I remember that I couldn't build OFED 1.2 without it in the
> > past. I tried to rebuild it without this now, and it compiles
> > successfully, so let's remove that code.
>
> OK, I killed these patches completely and things still build fine.
> Vlad, please pull my tree into ofed_kernel.
>
Yes, it also works for me. I guess that these are all leftovers.


Erez


___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Re: add_open_iscsi_h.patch

[Erez Zilber]

Michael S. Tsirkin wrote:

> > Quoting Erez Zilber <[EMAIL PROTECTED]>:
> > Subject: Re: add_open_iscsi_h.patch
> >
> > Michael S. Tsirkin wrote:
> >
> > > > Quoting Erez Zilber <[EMAIL PROTECTED]>:
> > > > Subject: Re: add_open_iscsi_h.patch
> > > >
> > > > Michael S. Tsirkin wrote:
> > > >
> > > > > Erez, add_open_iscsi_h currently does:
> > > > >
> > > > > -#include 
> > > > > +#include "iscsi_if.h"
> > > > >
> > > > > why is ths bit needed?
> > > > >
> > > >
> > > > Strange. I remember that I couldn't build OFED 1.2 without it in the
> > > > past. I tried to rebuild it without this now, and it compiles
> > > > successfully, so let's remove that code.
> > >
> > > OK, I killed these patches completely and things still build fine.
> > > Vlad, please pull my tree into ofed_kernel.
> > >
> > Yes, it also works for me. I guess that these are all leftovers.
>
> Deleted. Hmm. Do we want to kill them in 1.2.c too?
>
Yes (why not?)


Erez

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Re: add_open_iscsi_h.patch

[Erez Zilber]

Michael S. Tsirkin wrote:

> > Quoting Erez Zilber <[EMAIL PROTECTED]>:
> > Subject: Re: add_open_iscsi_h.patch
> >
> > Michael S. Tsirkin wrote:
> >
> > > > Quoting Erez Zilber <[EMAIL PROTECTED]>:
> > > > Subject: Re: add_open_iscsi_h.patch
> > > >
> > > > Michael S. Tsirkin wrote:
> > > >
> > > > > > Quoting Erez Zilber <[EMAIL PROTECTED]>:
> > > > > > Subject: Re: add_open_iscsi_h.patch
> > > > > >
> > > > > > Michael S. Tsirkin wrote:
> > > > > >
> > > > > > > Erez, add_open_iscsi_h currently does:
> > > > > > >
> > > > > > > -#include 
> > > > > > > +#include "iscsi_if.h"
> > > > > > >
> > > > > > > why is ths bit needed?
> > > > > > >
> > > > > >
> > > > > > Strange. I remember that I couldn't build OFED 1.2 without
> it in the
> > > > > > past. I tried to rebuild it without this now, and it compiles
> > > > > > successfully, so let's remove that code.
> > > > >
> > > > > OK, I killed these patches completely and things still build fine.
> > > > > Vlad, please pull my tree into ofed_kernel.
> > > > >
> > > > Yes, it also works for me. I guess that these are all leftovers.
> > >
> > > Deleted. Hmm. Do we want to kill them in 1.2.c too?
> > >
> > Yes (why not?)
>
> Donnu. It's in bugfix-only mode after all. You decide.
>

OK. Let's do it for OFED 1.3 only. This is not really a bug fix.

Erez

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Why isn't kfifo get built with ib-core for RH4?

[Erez Zilber]

Michael,


I saw that kfifo that was built with ib-core for RH4 was removed:


http://www2.openfabrics.org/git/?p=~vlad/ofed_kernel.git;a=commit;h=afe4186a2b383e58d9937d0b2fe2ddfb03cd7268


Why was it removed? open-iscsi cannot be loaded without it. If nobody
else is using it, I can move it to iscsi_scsi_addons.patch and build it
with libiscsi.


Thanks,

-- 



Erez Zilber | 972-9-971-7689

Software Engineer, Storage Team

Voltaire – _The Grid Backbone_

__

www.voltaire.com <http://www.voltaire.com/>



___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] [PATCH 0/4]: add kfifo from upstream for SLES9 & RH4

[Erez Zilber]

Michael S. Tsirkin wrote:
>> Quoting Erez Zilber <[EMAIL PROTECTED]>:
>> Subject: Why isn't kfifo get built with ib-core for RH4?
>>
>> Michael,
>>
>>
>> I saw that kfifo that was built with ib-core for RH4 was removed:
>>
>>
>> http://www2.openfabrics.org/git/?p=~vlad/ofed_kernel.git;a=commit;h=afe4186a2b383e58d9937d0b2fe2ddfb03cd7268
> 
> I can't think of a reason. Likely just an oversight.
> 
>> Why was it removed? open-iscsi cannot be loaded without it. If nobody
>> else is using it,
> 
> This was added here:
> ac758ec6bff062844a5a42141aa5da492b2cb02b
> so I think it's needed by Chelsio.
> Steve?
>   
>> I can move it to iscsi_scsi_addons.patch and build it
>> with libiscsi.
> 
> I think we should just re-add it in core. Patch?
> 
> While we are at it: as a separate cleanup,
> can you please remove the file from kernel_addons/./backport
> and just check out the file from kernel/kfifo.c.
> Just like we do with e.g. klist.c. OK?
> 

The following patches add kfifo to ibcore (for SLES9 & RH4). kfifo is taken 
from upstream code.

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] [PATCH 1/4]: Checkout kfifo.c from upstream

[Erez Zilber]

Checkout kfifo.c from kernel.org.

diff --git a/ofed_scripts/ofed_checkout.sh b/ofed_scripts/ofed_checkout.sh
index 86fc8b8..6c16835 100755
--- a/ofed_scripts/ofed_checkout.sh
+++ b/ofed_scripts/ofed_checkout.sh
@@ -36,6 +36,7 @@ ex git checkout $1 `git-ls-tree -r --name-only $1 \
 include/scsi/iscsi_if.h \
 include/scsi/libiscsi.h \
 include/scsi/scsi_transport_iscsi.h \
+kernel/kfifo.c \
 lib/klist.c \
 `
 ex git update-ref HEAD $1

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] [PATCH 2/4]: rm kfifo.c from kernel_addons

[Erez Zilber]

rm kfifo.c from kernel_addons (SLES9 & RH4) since it is checked out from 
upstream code.

Signed-off-by: Erez Zilber <[EMAIL PROTECTED]>

diff --git a/kernel_addons/backport/2.6.5_sles9_sp3/include/src/kfifo.c 
b/kernel_addons/backport/2.6.5_sles9_sp3/include/src/kfifo.c
deleted file mode 100644
index 5d1d907..000
--- a/kernel_addons/backport/2.6.5_sles9_sp3/include/src/kfifo.c
+++ /dev/null
@@ -1,196 +0,0 @@
-/*
- * A simple kernel FIFO implementation.
- *
- * Copyright (C) 2004 Stelian Pop <[EMAIL PROTECTED]>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
- *
- */
-
-#include 
-#include 
-#include 
-#include 
-#include 
-
-/**
- * kfifo_init - allocates a new FIFO using a preallocated buffer
- * @buffer: the preallocated buffer to be used.
- * @size: the size of the internal buffer, this have to be a power of 2.
- * @gfp_mask: get_free_pages mask, passed to kmalloc()
- * @lock: the lock to be used to protect the fifo buffer
- *
- * Do NOT pass the kfifo to kfifo_free() after use ! Simply free the
- * struct kfifo with kfree().
- */
-struct kfifo *kfifo_init(unsigned char *buffer, unsigned int size,
-gfp_t gfp_mask, spinlock_t *lock)
-{
-   struct kfifo *fifo;
-
-   /* size must be a power of 2 */
-   BUG_ON(size & (size - 1));
-
-   fifo = kmalloc(sizeof(struct kfifo), gfp_mask);
-   if (!fifo)
-   return ERR_PTR(-ENOMEM);
-
-   fifo->buffer = buffer;
-   fifo->size = size;
-   fifo->in = fifo->out = 0;
-   fifo->lock = lock;
-
-   return fifo;
-}
-EXPORT_SYMBOL(kfifo_init);
-
-/**
- * kfifo_alloc - allocates a new FIFO and its internal buffer
- * @size: the size of the internal buffer to be allocated.
- * @gfp_mask: get_free_pages mask, passed to kmalloc()
- * @lock: the lock to be used to protect the fifo buffer
- *
- * The size will be rounded-up to a power of 2.
- */
-struct kfifo *kfifo_alloc(unsigned int size, gfp_t gfp_mask, spinlock_t *lock)
-{
-   unsigned char *buffer;
-   struct kfifo *ret;
-
-   /*
-* round up to the next power of 2, since our 'let the indices
-* wrap' tachnique works only in this case.
-*/
-   if (size & (size - 1)) {
-   BUG_ON(size > 0x8000);
-   size = roundup_pow_of_two(size);
-   }
-
-   buffer = kmalloc(size, gfp_mask);
-   if (!buffer)
-   return ERR_PTR(-ENOMEM);
-
-   ret = kfifo_init(buffer, size, gfp_mask, lock);
-
-   if (IS_ERR(ret))
-   kfree(buffer);
-
-   return ret;
-}
-EXPORT_SYMBOL(kfifo_alloc);
-
-/**
- * kfifo_free - frees the FIFO
- * @fifo: the fifo to be freed.
- */
-void kfifo_free(struct kfifo *fifo)
-{
-   kfree(fifo->buffer);
-   kfree(fifo);
-}
-EXPORT_SYMBOL(kfifo_free);
-
-/**
- * __kfifo_put - puts some data into the FIFO, no locking version
- * @fifo: the fifo to be used.
- * @buffer: the data to be added.
- * @len: the length of the data to be added.
- *
- * This function copies at most 'len' bytes from the 'buffer' into
- * the FIFO depending on the free space, and returns the number of
- * bytes copied.
- *
- * Note that with only one concurrent reader and one concurrent
- * writer, you don't need extra locking to use these functions.
- */
-unsigned int __kfifo_put(struct kfifo *fifo,
-unsigned char *buffer, unsigned int len)
-{
-   unsigned int l;
-
-   len = min(len, fifo->size - fifo->in + fifo->out);
-
-   /*
-* Ensure that we sample the fifo->out index -before- we
-* start putting bytes into the kfifo.
-*/
-
-   smp_mb();
-
-   /* first put the data starting from fifo->in to buffer end */
-   l = min(len, fifo->size - (fifo->in & (fifo->size - 1)));
-   memcpy(fifo->buffer + (fifo->in & (fifo->size - 1)), buffer, l);
-
-   /* then put the rest (if any) at the beginning of the buffer */
-   memcpy(fifo->buffer, buffer + l, len - l);
-
-   /*
-* Ensure that we add the bytes to the kfifo -before-
-* we update the fifo->in index.
-*/
-
-   smp_wmb();
-
-   fifo->in += len;
-
-   return len;
-}
-EXPORT_SYMBOL(__kfifo_put);
-
-/**
-

[ewg] [PATCH 3/4]: use kfifo from upstream instead of addons for SLES9

[Erez Zilber]

use kfifo from upstream instead of kernel_addons for SLES9.

Signed-off-by: Erez Zilber <[EMAIL PROTECTED]>
---
 .../linux_stuff_to_2_6_5-7_244.patch   |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git 
a/kernel_patches/backport/2.6.5_sles9_sp3/linux_stuff_to_2_6_5-7_244.patch 
b/kernel_patches/backport/2.6.5_sles9_sp3/linux_stuff_to_2_6_5-7_244.patch
index 390e57d..c9b5e4c 100644
--- a/kernel_patches/backport/2.6.5_sles9_sp3/linux_stuff_to_2_6_5-7_244.patch
+++ b/kernel_patches/backport/2.6.5_sles9_sp3/linux_stuff_to_2_6_5-7_244.patch
@@ -32,7 +32,7 @@ index 000..58cf933
 --- /dev/null
 +++ b/drivers/infiniband/core/kfifo.c
 @@ -0,0 +1 @@
-+#include "src/kfifo.c"
++#include "../../kernel/kfifo.c"
 diff --git a/drivers/infiniband/core/Makefile 
b/drivers/infiniband/core/Makefile
 index 50fb1cd..456bfd0 100644
 --- a/drivers/infiniband/core/Makefile
-- 
1.5.2


___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] [PATCH 4/4]: Add kfifo to ibcore for RH4

[Erez Zilber]

Add kfifo to ibcore for RH4. kfifo is taken from upstream code.

Signed-off-by: Erez Zilber <[EMAIL PROTECTED]>

diff --git a/kernel_patches/backport/2.6.9_U2/linux_stuff_to_2_6_17.patch 
b/kernel_patches/backport/2.6.9_U2/linux_stuff_to_2_6_17.patch
index c437e83..e51c3a7 100644
--- a/kernel_patches/backport/2.6.9_U2/linux_stuff_to_2_6_17.patch
+++ b/kernel_patches/backport/2.6.9_U2/linux_stuff_to_2_6_17.patch
@@ -12,6 +12,13 @@ index 000..58cf933
 +++ b/drivers/infiniband/core/netevent.c
 @@ -0,0 +1 @@
 +#include "src/netevent.c"
+diff --git a/drivers/infiniband/core/kfifo.c b/drivers/infiniband/core/kfifo.c
+new file mode 100644
+index 000..58cf933
+--- /dev/null
 b/drivers/infiniband/core/kfifo.c
+@@ -0,0 +1 @@
++#include "../../kernel/kfifo.c"
 diff --git a/drivers/infiniband/core/Makefile 
b/drivers/infiniband/core/Makefile
 index 50fb1cd..456bfd0 100644
 --- a/drivers/infiniband/core/Makefile
@@ -20,4 +27,4 @@ index 50fb1cd..456bfd0 100644
  
  ib_uverbs-y :=uverbs_main.o uverbs_cmd.o 
uverbs_marshall.o
 +
-+ib_core-y +=  genalloc.o netevent.o
++ib_core-y +=  genalloc.o netevent.o kfifo.o
diff --git a/kernel_patches/backport/2.6.9_U3/linux_stuff_to_2_6_17.patch 
b/kernel_patches/backport/2.6.9_U3/linux_stuff_to_2_6_17.patch
index c437e83..e51c3a7 100644
--- a/kernel_patches/backport/2.6.9_U3/linux_stuff_to_2_6_17.patch
+++ b/kernel_patches/backport/2.6.9_U3/linux_stuff_to_2_6_17.patch
@@ -12,6 +12,13 @@ index 000..58cf933
 +++ b/drivers/infiniband/core/netevent.c
 @@ -0,0 +1 @@
 +#include "src/netevent.c"
+diff --git a/drivers/infiniband/core/kfifo.c b/drivers/infiniband/core/kfifo.c
+new file mode 100644
+index 000..58cf933
+--- /dev/null
 b/drivers/infiniband/core/kfifo.c
+@@ -0,0 +1 @@
++#include "../../kernel/kfifo.c"
 diff --git a/drivers/infiniband/core/Makefile 
b/drivers/infiniband/core/Makefile
 index 50fb1cd..456bfd0 100644
 --- a/drivers/infiniband/core/Makefile
@@ -20,4 +27,4 @@ index 50fb1cd..456bfd0 100644
  
  ib_uverbs-y :=uverbs_main.o uverbs_cmd.o 
uverbs_marshall.o
 +
-+ib_core-y +=  genalloc.o netevent.o
++ib_core-y +=  genalloc.o netevent.o kfifo.o
diff --git a/kernel_patches/backport/2.6.9_U4/linux_stuff_to_2_6_17.patch 
b/kernel_patches/backport/2.6.9_U4/linux_stuff_to_2_6_17.patch
index c437e83..e51c3a7 100644
--- a/kernel_patches/backport/2.6.9_U4/linux_stuff_to_2_6_17.patch
+++ b/kernel_patches/backport/2.6.9_U4/linux_stuff_to_2_6_17.patch
@@ -12,6 +12,13 @@ index 000..58cf933
 +++ b/drivers/infiniband/core/netevent.c
 @@ -0,0 +1 @@
 +#include "src/netevent.c"
+diff --git a/drivers/infiniband/core/kfifo.c b/drivers/infiniband/core/kfifo.c
+new file mode 100644
+index 000..58cf933
+--- /dev/null
 b/drivers/infiniband/core/kfifo.c
+@@ -0,0 +1 @@
++#include "../../kernel/kfifo.c"
 diff --git a/drivers/infiniband/core/Makefile 
b/drivers/infiniband/core/Makefile
 index 50fb1cd..456bfd0 100644
 --- a/drivers/infiniband/core/Makefile
@@ -20,4 +27,4 @@ index 50fb1cd..456bfd0 100644
  
  ib_uverbs-y :=uverbs_main.o uverbs_cmd.o 
uverbs_marshall.o
 +
-+ib_core-y +=  genalloc.o netevent.o
++ib_core-y +=  genalloc.o netevent.o kfifo.o
diff --git a/kernel_patches/backport/2.6.9_U5/linux_stuff_to_2_6_17.patch 
b/kernel_patches/backport/2.6.9_U5/linux_stuff_to_2_6_17.patch
index c437e83..e51c3a7 100644
--- a/kernel_patches/backport/2.6.9_U5/linux_stuff_to_2_6_17.patch
+++ b/kernel_patches/backport/2.6.9_U5/linux_stuff_to_2_6_17.patch
@@ -12,6 +12,13 @@ index 000..58cf933
 +++ b/drivers/infiniband/core/netevent.c
 @@ -0,0 +1 @@
 +#include "src/netevent.c"
+diff --git a/drivers/infiniband/core/kfifo.c b/drivers/infiniband/core/kfifo.c
+new file mode 100644
+index 000..58cf933
+--- /dev/null
 b/drivers/infiniband/core/kfifo.c
+@@ -0,0 +1 @@
++#include "../../kernel/kfifo.c"
 diff --git a/drivers/infiniband/core/Makefile 
b/drivers/infiniband/core/Makefile
 index 50fb1cd..456bfd0 100644
 --- a/drivers/infiniband/core/Makefile
@@ -20,4 +27,4 @@ index 50fb1cd..456bfd0 100644
  
  ib_uverbs-y :=uverbs_main.o uverbs_cmd.o 
uverbs_marshall.o
 +
-+ib_core-y +=  genalloc.o netevent.o
++ib_core-y +=  genalloc.o netevent.o kfifo.o

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] [PATCH 0/2] IB/iser: move open-iscsi crypto functions to kernel_addons

[Erez Zilber]

The following patches move open-iscsi crypto functions from kernel_patches to 
kernel_addons. By doing so, we also solve a bug in iscsi tx hash that caused an 
oops when crc32c was used for data digest.

Vlad - can you include this fix for OFED 1.2.1? 

-- 


Erez Zilber   |  972-9-971-7689

Software Engineer, Storage Team

Voltaire – _The Grid Backbone_

 __

 www.voltaire.com <http://www.voltaire.com/>

<mailto:[EMAIL PROTECTED]>

  


___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] [PATCH 1/2] IB/iser: move open-iscsi crypto functions to kernel_addons (SLES10, RHEL5)

[Erez Zilber]

move open-iscsi crypto functions to kernel_addons (SLES10, RHEL5)

Signed-off-by: Erez Zilber <[EMAIL PROTECTED]>
---
 .../backport/2.6.16_sles10/include/linux/crypto.h  |   54 
 .../2.6.16_sles10_sp1/include/linux/crypto.h   |   54 
 .../backport/2.6.18_FC6/include/linux/crypto.h |   54 
 .../2.6.16_sles10/open-iscsi-tx-hash-fixes.patch   |  278 
 .../open-iscsi-tx-hash-fixes.patch |  278 
 .../2.6.18_FC6/open-iscsi-tx-hash-fixes.patch  |  278 
 6 files changed, 162 insertions(+), 834 deletions(-)
 create mode 100644 kernel_addons/backport/2.6.16_sles10/include/linux/crypto.h
 create mode 100644 
kernel_addons/backport/2.6.16_sles10_sp1/include/linux/crypto.h
 create mode 100644 kernel_addons/backport/2.6.18_FC6/include/linux/crypto.h
 delete mode 100644 
kernel_patches/backport/2.6.16_sles10/open-iscsi-tx-hash-fixes.patch
 delete mode 100644 
kernel_patches/backport/2.6.16_sles10_sp1/open-iscsi-tx-hash-fixes.patch
 delete mode 100644 
kernel_patches/backport/2.6.18_FC6/open-iscsi-tx-hash-fixes.patch

diff --git a/kernel_addons/backport/2.6.16_sles10/include/linux/crypto.h 
b/kernel_addons/backport/2.6.16_sles10/include/linux/crypto.h
new file mode 100644
index 000..0f02f6f
--- /dev/null
+++ b/kernel_addons/backport/2.6.16_sles10/include/linux/crypto.h
@@ -0,0 +1,54 @@
+#ifndef BACKPORT_LINUX_CRYPTO_H
+#define BACKPORT_LINUX_CRYPTO_H
+
+#include_next 
+
+#define CRYPTO_ALG_ASYNC   0x0080
+
+struct hash_desc
+{
+   struct crypto_tfm *tfm;
+   u32 flags;
+};
+
+static inline int crypto_hash_init(struct hash_desc *desc)
+{
+   crypto_digest_init(desc->tfm);
+   return 0;
+}
+
+static inline int crypto_hash_digest(struct hash_desc *desc,
+struct scatterlist *sg,
+unsigned int nbytes, u8 *out)
+{
+   crypto_digest_digest(desc->tfm, sg, (nbytes+(PAGE_SIZE-1)) / PAGE_SIZE, 
out);
+   return nbytes;
+}
+
+static inline int crypto_hash_update(struct hash_desc *desc,
+struct scatterlist *sg,
+unsigned int nbytes)
+{
+   crypto_digest_update(desc->tfm, sg, (nbytes+(PAGE_SIZE-1)) / PAGE_SIZE);
+   return nbytes;
+}
+
+static inline int crypto_hash_final(struct hash_desc *desc, u8 *out)
+{
+   crypto_digest_final(desc->tfm, out);
+   return 0;
+}
+
+static inline struct crypto_tfm *crypto_alloc_hash(const char *alg_name,
+   u32 type, u32 mask)
+{
+   struct crypto_tfm *ret = crypto_alloc_tfm(alg_name ,type);
+   return ret ? ret : ERR_PTR(-ENOMEM);
+}
+
+static inline void crypto_free_hash(struct crypto_tfm *tfm)
+{
+   crypto_free_tfm(tfm);
+}
+
+#endif
diff --git a/kernel_addons/backport/2.6.16_sles10_sp1/include/linux/crypto.h 
b/kernel_addons/backport/2.6.16_sles10_sp1/include/linux/crypto.h
new file mode 100644
index 000..0f02f6f
--- /dev/null
+++ b/kernel_addons/backport/2.6.16_sles10_sp1/include/linux/crypto.h
@@ -0,0 +1,54 @@
+#ifndef BACKPORT_LINUX_CRYPTO_H
+#define BACKPORT_LINUX_CRYPTO_H
+
+#include_next 
+
+#define CRYPTO_ALG_ASYNC   0x0080
+
+struct hash_desc
+{
+   struct crypto_tfm *tfm;
+   u32 flags;
+};
+
+static inline int crypto_hash_init(struct hash_desc *desc)
+{
+   crypto_digest_init(desc->tfm);
+   return 0;
+}
+
+static inline int crypto_hash_digest(struct hash_desc *desc,
+struct scatterlist *sg,
+unsigned int nbytes, u8 *out)
+{
+   crypto_digest_digest(desc->tfm, sg, (nbytes+(PAGE_SIZE-1)) / PAGE_SIZE, 
out);
+   return nbytes;
+}
+
+static inline int crypto_hash_update(struct hash_desc *desc,
+struct scatterlist *sg,
+unsigned int nbytes)
+{
+   crypto_digest_update(desc->tfm, sg, (nbytes+(PAGE_SIZE-1)) / PAGE_SIZE);
+   return nbytes;
+}
+
+static inline int crypto_hash_final(struct hash_desc *desc, u8 *out)
+{
+   crypto_digest_final(desc->tfm, out);
+   return 0;
+}
+
+static inline struct crypto_tfm *crypto_alloc_hash(const char *alg_name,
+   u32 type, u32 mask)
+{
+   struct crypto_tfm *ret = crypto_alloc_tfm(alg_name ,type);
+   return ret ? ret : ERR_PTR(-ENOMEM);
+}
+
+static inline void crypto_free_hash(struct crypto_tfm *tfm)
+{
+   crypto_free_tfm(tfm);
+}
+
+#endif
diff --git a/kernel_addons/backport/2.6.18_FC6/include/linux/crypto.h 
b/kernel_addons/backport/2.6.18_FC6/include/linux/crypto.h
new file mode 100644
index 000..0f02f6f
--- /dev/null
+++ b/kernel_addons/backport/2.6.18_FC6/include/linux/crypto.h
@@ -0,0 +1,54 @@
+#ifndef BACKPORT_LINUX_CRYPTO_H
+#define BACKPORT_LINUX_CRYPTO_H
+
+#include_nex

[ewg] [PATCH 2/2] IB/iser: move open-iscsi crypto functions to kernel_addons (RHEL4)

[Erez Zilber]

move open-iscsi crypto functions to kernel_addons (RHEL4)

Signed-off-by: Erez Zilber <[EMAIL PROTECTED]>
---
 .../backport/2.6.9_U3/include/linux/crypto.h   |   55 ++--
 .../backport/2.6.9_U4/include/linux/crypto.h   |   55 ++--
 .../backport/2.6.9_U5/include/linux/crypto.h   |   55 ++--
 .../backport/2.6.9_U3/add_open_iscsi.patch |   94 
 .../backport/2.6.9_U4/add_open_iscsi.patch |   94 
 .../backport/2.6.9_U5/add_open_iscsi.patch |   94 
 6 files changed, 147 insertions(+), 300 deletions(-)

diff --git a/kernel_addons/backport/2.6.9_U3/include/linux/crypto.h 
b/kernel_addons/backport/2.6.9_U3/include/linux/crypto.h
index aecccde..0f02f6f 100644
--- a/kernel_addons/backport/2.6.9_U3/include/linux/crypto.h
+++ b/kernel_addons/backport/2.6.9_U3/include/linux/crypto.h
@@ -1,11 +1,54 @@
-#ifndef LINUX_CRYPTO_BACKPORT_H
-#define LINUX_CRYPTO_BACKPORT_H
+#ifndef BACKPORT_LINUX_CRYPTO_H
+#define BACKPORT_LINUX_CRYPTO_H
 
 #include_next 
 
-#define crypto_hash_init(desc) crypto_digest_init(*desc)
-#define crypto_hash_digest(desc, sg, nbytes, out) crypto_digest_digest(*desc, 
sg, 1, out)
-#define crypto_hash_update(desc, sg, nbytes) crypto_digest_update(*desc, sg, 1)
-#define crypto_hash_final(desc, out) crypto_digest_final(*desc, out)
+#define CRYPTO_ALG_ASYNC   0x0080
+
+struct hash_desc
+{
+   struct crypto_tfm *tfm;
+   u32 flags;
+};
+
+static inline int crypto_hash_init(struct hash_desc *desc)
+{
+   crypto_digest_init(desc->tfm);
+   return 0;
+}
+
+static inline int crypto_hash_digest(struct hash_desc *desc,
+struct scatterlist *sg,
+unsigned int nbytes, u8 *out)
+{
+   crypto_digest_digest(desc->tfm, sg, (nbytes+(PAGE_SIZE-1)) / PAGE_SIZE, 
out);
+   return nbytes;
+}
+
+static inline int crypto_hash_update(struct hash_desc *desc,
+struct scatterlist *sg,
+unsigned int nbytes)
+{
+   crypto_digest_update(desc->tfm, sg, (nbytes+(PAGE_SIZE-1)) / PAGE_SIZE);
+   return nbytes;
+}
+
+static inline int crypto_hash_final(struct hash_desc *desc, u8 *out)
+{
+   crypto_digest_final(desc->tfm, out);
+   return 0;
+}
+
+static inline struct crypto_tfm *crypto_alloc_hash(const char *alg_name,
+   u32 type, u32 mask)
+{
+   struct crypto_tfm *ret = crypto_alloc_tfm(alg_name ,type);
+   return ret ? ret : ERR_PTR(-ENOMEM);
+}
+
+static inline void crypto_free_hash(struct crypto_tfm *tfm)
+{
+   crypto_free_tfm(tfm);
+}
 
 #endif
diff --git a/kernel_addons/backport/2.6.9_U4/include/linux/crypto.h 
b/kernel_addons/backport/2.6.9_U4/include/linux/crypto.h
index aecccde..0f02f6f 100644
--- a/kernel_addons/backport/2.6.9_U4/include/linux/crypto.h
+++ b/kernel_addons/backport/2.6.9_U4/include/linux/crypto.h
@@ -1,11 +1,54 @@
-#ifndef LINUX_CRYPTO_BACKPORT_H
-#define LINUX_CRYPTO_BACKPORT_H
+#ifndef BACKPORT_LINUX_CRYPTO_H
+#define BACKPORT_LINUX_CRYPTO_H
 
 #include_next 
 
-#define crypto_hash_init(desc) crypto_digest_init(*desc)
-#define crypto_hash_digest(desc, sg, nbytes, out) crypto_digest_digest(*desc, 
sg, 1, out)
-#define crypto_hash_update(desc, sg, nbytes) crypto_digest_update(*desc, sg, 1)
-#define crypto_hash_final(desc, out) crypto_digest_final(*desc, out)
+#define CRYPTO_ALG_ASYNC   0x0080
+
+struct hash_desc
+{
+   struct crypto_tfm *tfm;
+   u32 flags;
+};
+
+static inline int crypto_hash_init(struct hash_desc *desc)
+{
+   crypto_digest_init(desc->tfm);
+   return 0;
+}
+
+static inline int crypto_hash_digest(struct hash_desc *desc,
+struct scatterlist *sg,
+unsigned int nbytes, u8 *out)
+{
+   crypto_digest_digest(desc->tfm, sg, (nbytes+(PAGE_SIZE-1)) / PAGE_SIZE, 
out);
+   return nbytes;
+}
+
+static inline int crypto_hash_update(struct hash_desc *desc,
+struct scatterlist *sg,
+unsigned int nbytes)
+{
+   crypto_digest_update(desc->tfm, sg, (nbytes+(PAGE_SIZE-1)) / PAGE_SIZE);
+   return nbytes;
+}
+
+static inline int crypto_hash_final(struct hash_desc *desc, u8 *out)
+{
+   crypto_digest_final(desc->tfm, out);
+   return 0;
+}
+
+static inline struct crypto_tfm *crypto_alloc_hash(const char *alg_name,
+   u32 type, u32 mask)
+{
+   struct crypto_tfm *ret = crypto_alloc_tfm(alg_name ,type);
+   return ret ? ret : ERR_PTR(-ENOMEM);
+}
+
+static inline void crypto_free_hash(struct crypto_tfm *tfm)
+{
+   crypto_free_tfm(tfm);
+}
 
 #endif
diff --git a/kernel_addons/backport/2.6.9_U5/include/linux/crypto.h 
b/kernel_addons/backport/2.6.9_U

[ewg] Re: [ofa-general] OFED 1.2.c-9 is available

[Erez Zilber]

Tziporet,


Does 1.2.c-9 also include FMR support? Else, should we wait for 1.2.c-10?


Thanks,

Erez


Tziporet Koren wrote:

> Hi All,
>
> OFED 1.2.c-9 is available now on the OFA server under:
> _http://www.openfabrics.org/builds/connectx/release/_
> Note: this release was tested with FW 2.1.000 that will soon be
> available on Mellanox web site for download.
>
> Supported Platforms and Operating Systems
> =
> o CPU architectures:
> - x86_64
> - x86
> - ppc64
> - ia64
>
> o Linux Operating Systems:
> - RedHat EL4 up3: 2.6.9-34.ELsmp
> - RedHat EL4 up4: 2.6.9-42.ELsmp
> - RedHat EL4 up5: 2.6.9-55.ELsmp
> - RedHat EL5: 2.6.18-8.el5
> - SLES10: 2.6.16.21-0.8-smp
> - kernel.org: 2.6.20.x
> - SLES10 SP1: 2.6.16.46-0.12-smp (partially tested)
>
> Main changes from OFED 1.2.c-8:
> =
> 1. Kernel oops in IPoIB on restart of the driver.
> 2. IPoIB CM is now the default.
> 3. MPI with SRQ is supported.
> 4. Itanium is now supported.
>
> mlx4 Fixed Bugs and Enhancements
> ===
> - Added support for PCI-Ex gen2 devices; device IDs: 26418 and 26428.
> - Query QP and query SRQ are now supported.
> - Internal error flow was added.
> - Number of QPs that can be attached to the same multicast group was
> increased to 56.
> - SRQ is now supported.
> - Fork is now supported.
>
> ConnectX specific known issues and limitations
> ===
> - The following commands and/or features are not supported:
>   o Resize CQ
>   o FMRs
>   o APM
>   o SQD
> - ibstat does not present all entries. Use ibv_devinfo instead.
> - To load the driver on machines with 64KB default page size UAR bar
> must be
>   enlarged. 64KB page size is the default of PPC with RHEL5 and
> Itanium with
>   64KB page size enabled.
>   Perform the following three steps:
>   1. Add the following line in the firmware configuration (INI) file
> under the
>  [HCA] section:
>log2_uar_bar_megabytes = 5
>   2. Burn a modified firmware image with the changed INI file
>   3. Reboot the system
>
>
>
> Tziporet Koren
> Software Director
> Mellanox Technologies
> mailto: [EMAIL PROTECTED] 
> Tel +972-4-9097200, ext 380
>
> 
>
> ___
> general mailing list
> [EMAIL PROTECTED]
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
>
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general


___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Re: [PATCH 0/2] IB/iser: move open-iscsi crypto functions to kernel_addons

[Erez Zilber]

Michael S. Tsirkin wrote:

>> Quoting Erez Zilber <[EMAIL PROTECTED]>:
>> Subject: [PATCH 0/2] IB/iser: move open-iscsi crypto functions to 
>> kernel_addons
>>
>> The following patches move open-iscsi crypto functions from kernel_patches 
>> to kernel_addons. By doing so, we also solve a bug in iscsi tx hash that 
>> caused an oops when crc32c was used for data digest.
>> 
>
> Great, these patches were really fragile.
>
>   
I saw that these patches are not in 1.2.c-10. Will they be in 1.2.c-11?
This is a real bug fix.

Thanks,
Erez

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] [PATCH 0/2] IB/iser: move open-iscsi crypto functions to kernel_addons

[Erez Zilber]

Vladimir Sokolovsky wrote:

> Erez Zilber wrote:
>> The following patches move open-iscsi crypto functions from
>> kernel_patches to kernel_addons. By doing so, we also solve a bug in
>> iscsi tx hash that caused an oops when crc32c was used for data digest.
>>
>> Vlad - can you include this fix for OFED 1.2.1?
>
> Hi Erez,
> Both patches failed to be applied to
> git://git.openfabrics.org/~vlad/ofed_1_2 for both ofed_1_2 and
> ofed_1_2_c branches.
> Please check,
I will resend both patches.

Erez

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] [PATCH 1/2 - v2] IB/iser: move open-iscsi crypto functions to kernel_addons (SLES10, RHEL5)

[Erez Zilber]

move open-iscsi crypto functions to kernel_addons (SLES10, RHEL5)

Signed-off-by: Erez Zilber <[EMAIL PROTECTED]>
---
 .../backport/2.6.16_sles10/include/linux/crypto.h  |   54 
 .../2.6.16_sles10_sp1/include/linux/crypto.h   |   54 
 .../backport/2.6.18_FC6/include/linux/crypto.h |   54 
 .../2.6.16_sles10/open-iscsi-tx-hash-fixes.patch   |  277 
 .../open-iscsi-tx-hash-fixes.patch |  277 
 .../2.6.18_FC6/open-iscsi-tx-hash-fixes.patch  |  277 
 6 files changed, 162 insertions(+), 831 deletions(-)
 create mode 100644 kernel_addons/backport/2.6.16_sles10/include/linux/crypto.h
 create mode 100644 
kernel_addons/backport/2.6.16_sles10_sp1/include/linux/crypto.h
 create mode 100644 kernel_addons/backport/2.6.18_FC6/include/linux/crypto.h
 delete mode 100644 
kernel_patches/backport/2.6.16_sles10/open-iscsi-tx-hash-fixes.patch
 delete mode 100644 
kernel_patches/backport/2.6.16_sles10_sp1/open-iscsi-tx-hash-fixes.patch
 delete mode 100644 
kernel_patches/backport/2.6.18_FC6/open-iscsi-tx-hash-fixes.patch

diff --git a/kernel_addons/backport/2.6.16_sles10/include/linux/crypto.h 
b/kernel_addons/backport/2.6.16_sles10/include/linux/crypto.h
new file mode 100644
index 000..0f02f6f
--- /dev/null
+++ b/kernel_addons/backport/2.6.16_sles10/include/linux/crypto.h
@@ -0,0 +1,54 @@
+#ifndef BACKPORT_LINUX_CRYPTO_H
+#define BACKPORT_LINUX_CRYPTO_H
+
+#include_next 
+
+#define CRYPTO_ALG_ASYNC   0x0080
+
+struct hash_desc
+{
+   struct crypto_tfm *tfm;
+   u32 flags;
+};
+
+static inline int crypto_hash_init(struct hash_desc *desc)
+{
+   crypto_digest_init(desc->tfm);
+   return 0;
+}
+
+static inline int crypto_hash_digest(struct hash_desc *desc,
+struct scatterlist *sg,
+unsigned int nbytes, u8 *out)
+{
+   crypto_digest_digest(desc->tfm, sg, (nbytes+(PAGE_SIZE-1)) / PAGE_SIZE, 
out);
+   return nbytes;
+}
+
+static inline int crypto_hash_update(struct hash_desc *desc,
+struct scatterlist *sg,
+unsigned int nbytes)
+{
+   crypto_digest_update(desc->tfm, sg, (nbytes+(PAGE_SIZE-1)) / PAGE_SIZE);
+   return nbytes;
+}
+
+static inline int crypto_hash_final(struct hash_desc *desc, u8 *out)
+{
+   crypto_digest_final(desc->tfm, out);
+   return 0;
+}
+
+static inline struct crypto_tfm *crypto_alloc_hash(const char *alg_name,
+   u32 type, u32 mask)
+{
+   struct crypto_tfm *ret = crypto_alloc_tfm(alg_name ,type);
+   return ret ? ret : ERR_PTR(-ENOMEM);
+}
+
+static inline void crypto_free_hash(struct crypto_tfm *tfm)
+{
+   crypto_free_tfm(tfm);
+}
+
+#endif
diff --git a/kernel_addons/backport/2.6.16_sles10_sp1/include/linux/crypto.h 
b/kernel_addons/backport/2.6.16_sles10_sp1/include/linux/crypto.h
new file mode 100644
index 000..0f02f6f
--- /dev/null
+++ b/kernel_addons/backport/2.6.16_sles10_sp1/include/linux/crypto.h
@@ -0,0 +1,54 @@
+#ifndef BACKPORT_LINUX_CRYPTO_H
+#define BACKPORT_LINUX_CRYPTO_H
+
+#include_next 
+
+#define CRYPTO_ALG_ASYNC   0x0080
+
+struct hash_desc
+{
+   struct crypto_tfm *tfm;
+   u32 flags;
+};
+
+static inline int crypto_hash_init(struct hash_desc *desc)
+{
+   crypto_digest_init(desc->tfm);
+   return 0;
+}
+
+static inline int crypto_hash_digest(struct hash_desc *desc,
+struct scatterlist *sg,
+unsigned int nbytes, u8 *out)
+{
+   crypto_digest_digest(desc->tfm, sg, (nbytes+(PAGE_SIZE-1)) / PAGE_SIZE, 
out);
+   return nbytes;
+}
+
+static inline int crypto_hash_update(struct hash_desc *desc,
+struct scatterlist *sg,
+unsigned int nbytes)
+{
+   crypto_digest_update(desc->tfm, sg, (nbytes+(PAGE_SIZE-1)) / PAGE_SIZE);
+   return nbytes;
+}
+
+static inline int crypto_hash_final(struct hash_desc *desc, u8 *out)
+{
+   crypto_digest_final(desc->tfm, out);
+   return 0;
+}
+
+static inline struct crypto_tfm *crypto_alloc_hash(const char *alg_name,
+   u32 type, u32 mask)
+{
+   struct crypto_tfm *ret = crypto_alloc_tfm(alg_name ,type);
+   return ret ? ret : ERR_PTR(-ENOMEM);
+}
+
+static inline void crypto_free_hash(struct crypto_tfm *tfm)
+{
+   crypto_free_tfm(tfm);
+}
+
+#endif
diff --git a/kernel_addons/backport/2.6.18_FC6/include/linux/crypto.h 
b/kernel_addons/backport/2.6.18_FC6/include/linux/crypto.h
new file mode 100644
index 000..0f02f6f
--- /dev/null
+++ b/kernel_addons/backport/2.6.18_FC6/include/linux/crypto.h
@@ -0,0 +1,54 @@
+#ifndef BACKPORT_LINUX_CRYPTO_H
+#define BACKPORT_LINUX_CRYPTO_H
+
+#include_nex

[ewg] [PATCH 2/2 - v2] IB/iser: move open-iscsi crypto functions to kernel_addons (RHEL4)

[Erez Zilber]

move open-iscsi crypto functions to kernel_addons (RHEL4)

Signed-off-by: Erez Zilber <[EMAIL PROTECTED]>
---
 .../backport/2.6.9_U3/include/linux/crypto.h   |   55 --
 .../backport/2.6.9_U4/include/linux/crypto.h   |   55 --
 .../backport/2.6.9_U5/include/linux/crypto.h   |   55 --
 .../backport/2.6.9_U3/add_open_iscsi.patch |   83 
 .../backport/2.6.9_U4/add_open_iscsi.patch |   83 
 .../backport/2.6.9_U5/add_open_iscsi.patch |   83 
 6 files changed, 147 insertions(+), 267 deletions(-)

diff --git a/kernel_addons/backport/2.6.9_U3/include/linux/crypto.h 
b/kernel_addons/backport/2.6.9_U3/include/linux/crypto.h
index aecccde..0f02f6f 100644
--- a/kernel_addons/backport/2.6.9_U3/include/linux/crypto.h
+++ b/kernel_addons/backport/2.6.9_U3/include/linux/crypto.h
@@ -1,11 +1,54 @@
-#ifndef LINUX_CRYPTO_BACKPORT_H
-#define LINUX_CRYPTO_BACKPORT_H
+#ifndef BACKPORT_LINUX_CRYPTO_H
+#define BACKPORT_LINUX_CRYPTO_H
 
 #include_next 
 
-#define crypto_hash_init(desc) crypto_digest_init(*desc)
-#define crypto_hash_digest(desc, sg, nbytes, out) crypto_digest_digest(*desc, 
sg, 1, out)
-#define crypto_hash_update(desc, sg, nbytes) crypto_digest_update(*desc, sg, 1)
-#define crypto_hash_final(desc, out) crypto_digest_final(*desc, out)
+#define CRYPTO_ALG_ASYNC   0x0080
+
+struct hash_desc
+{
+   struct crypto_tfm *tfm;
+   u32 flags;
+};
+
+static inline int crypto_hash_init(struct hash_desc *desc)
+{
+   crypto_digest_init(desc->tfm);
+   return 0;
+}
+
+static inline int crypto_hash_digest(struct hash_desc *desc,
+struct scatterlist *sg,
+unsigned int nbytes, u8 *out)
+{
+   crypto_digest_digest(desc->tfm, sg, (nbytes+(PAGE_SIZE-1)) / PAGE_SIZE, 
out);
+   return nbytes;
+}
+
+static inline int crypto_hash_update(struct hash_desc *desc,
+struct scatterlist *sg,
+unsigned int nbytes)
+{
+   crypto_digest_update(desc->tfm, sg, (nbytes+(PAGE_SIZE-1)) / PAGE_SIZE);
+   return nbytes;
+}
+
+static inline int crypto_hash_final(struct hash_desc *desc, u8 *out)
+{
+   crypto_digest_final(desc->tfm, out);
+   return 0;
+}
+
+static inline struct crypto_tfm *crypto_alloc_hash(const char *alg_name,
+   u32 type, u32 mask)
+{
+   struct crypto_tfm *ret = crypto_alloc_tfm(alg_name ,type);
+   return ret ? ret : ERR_PTR(-ENOMEM);
+}
+
+static inline void crypto_free_hash(struct crypto_tfm *tfm)
+{
+   crypto_free_tfm(tfm);
+}
 
 #endif
diff --git a/kernel_addons/backport/2.6.9_U4/include/linux/crypto.h 
b/kernel_addons/backport/2.6.9_U4/include/linux/crypto.h
index aecccde..0f02f6f 100644
--- a/kernel_addons/backport/2.6.9_U4/include/linux/crypto.h
+++ b/kernel_addons/backport/2.6.9_U4/include/linux/crypto.h
@@ -1,11 +1,54 @@
-#ifndef LINUX_CRYPTO_BACKPORT_H
-#define LINUX_CRYPTO_BACKPORT_H
+#ifndef BACKPORT_LINUX_CRYPTO_H
+#define BACKPORT_LINUX_CRYPTO_H
 
 #include_next 
 
-#define crypto_hash_init(desc) crypto_digest_init(*desc)
-#define crypto_hash_digest(desc, sg, nbytes, out) crypto_digest_digest(*desc, 
sg, 1, out)
-#define crypto_hash_update(desc, sg, nbytes) crypto_digest_update(*desc, sg, 1)
-#define crypto_hash_final(desc, out) crypto_digest_final(*desc, out)
+#define CRYPTO_ALG_ASYNC   0x0080
+
+struct hash_desc
+{
+   struct crypto_tfm *tfm;
+   u32 flags;
+};
+
+static inline int crypto_hash_init(struct hash_desc *desc)
+{
+   crypto_digest_init(desc->tfm);
+   return 0;
+}
+
+static inline int crypto_hash_digest(struct hash_desc *desc,
+struct scatterlist *sg,
+unsigned int nbytes, u8 *out)
+{
+   crypto_digest_digest(desc->tfm, sg, (nbytes+(PAGE_SIZE-1)) / PAGE_SIZE, 
out);
+   return nbytes;
+}
+
+static inline int crypto_hash_update(struct hash_desc *desc,
+struct scatterlist *sg,
+unsigned int nbytes)
+{
+   crypto_digest_update(desc->tfm, sg, (nbytes+(PAGE_SIZE-1)) / PAGE_SIZE);
+   return nbytes;
+}
+
+static inline int crypto_hash_final(struct hash_desc *desc, u8 *out)
+{
+   crypto_digest_final(desc->tfm, out);
+   return 0;
+}
+
+static inline struct crypto_tfm *crypto_alloc_hash(const char *alg_name,
+   u32 type, u32 mask)
+{
+   struct crypto_tfm *ret = crypto_alloc_tfm(alg_name ,type);
+   return ret ? ret : ERR_PTR(-ENOMEM);
+}
+
+static inline void crypto_free_hash(struct crypto_tfm *tfm)
+{
+   crypto_free_tfm(tfm);
+}
 
 #endif
diff --git a/kernel_addons/backport/2.6.9_U5/include/linux/crypto.h 
b/kernel_addons/backport/2

Re: [ewg] OFED 1.2.c-11 is available

[Erez Zilber]

Tziporet,


Can you add the following as a known issue:


"open-iscsi over TCP does not support usage of data digest on RedHat EL/AS 4 
up3,
up4 & up5."

Note that this comment should be added to OFED release notes, not to
iSER release notes. This is not an iSER bug (it's a bug in the backport
for open-iscsi).

Thanks,
Erez


Tziporet Koren wrote:

> Hi All,
>
> OFED 1.2.c-11 is available now on the OFA server under:
> _http://www.openfabrics.org/builds/connectx/release/_
> Note: This release supports FW 2.1.000 that is available on Mellanox
> web site for download
>   and FW 2.2.0 that will be released soon
>
> Supported Platforms and Operating Systems
> =
> o CPU architectures:
> - x86_64
> - x86
> - ppc64
> - ia64
>
> o Linux Operating Systems:
> - RedHat EL4 up3: 2.6.9-34.ELsmp
> - RedHat EL4 up4: 2.6.9-42.ELsmp
> - RedHat EL4 up5: 2.6.9-55.ELsmp
> - RedHat EL5: 2.6.18-8.el5
> - SLES10: 2.6.16.21-0.8-smp
> - kernel.org: 2.6.20.x and 2.6.22.x
> - SLES10 SP1: 2.6.16.46-0.12-smp (partially tested)
>
> Main changes from OFED 1.2.c-10:
> 
> - Merged all 1.2 branch patches to 1.2.c
> - mad: Fix address handle leak in mad_rmpp
> - mlx4
> - Added support for interrupt moderation for create cq to
> support ipoib.
> - Display the following device information via sysfs:
> board_id, fw_ver,
>   hw_rev and hca_type. As a result ibstat presenting all entries.
> - Fixed destroy special QPs.
> - Fixed the work completion opcode for RDMA_READ operation
> - opensm:
> - Sets the time a packet can live in the Head of Queue of a
> port that
>   drives a CA port to approximately 1 second.
> - Number of dropped packets due to HOQ that will stall the CA
> was increased
>  to 7 (instead of 1).
> - IPoIB:
> - Add interrupt moderation support for IPoIB UD
> - NAPI is available using a module parameter
> - Fixed a leak in ipoib_transport_dev_init
> - Fixed kernel oops in IPoIB download
> - New MVAPICH package (mvapich-0.9.9-1451):
> - mpirun_rsh fixes:
>   * Check that we do not overflow command line size
>   * better handling for accept
> - Fix for memory allocations whose size is bigger than 2^31-1
> - Fix for multiple communicator problem
> - Fix for MPI_Finalize segmentation fault
> - RDS:
> - rds_poll() always returns POLLOUT.  If you try to send and get
>   EWOULDBLOCK because the remote receiver is congested then
> you don't get
>   to wait for POLLOUT to be raised before sending again --
> it's always
>   raised.  This is worked around by implementing some kind of
> exponential
>   back-off while retrying the send.  This can be done by
> increasing the
>   timeout given to poll().  At each poll() timeout expiry the
> send is
>   tried again.
> - Set max send and receive scatter/gather list size to 2 in
> the QP attributes.
>   The second sge used for RDS header.
> - Added rs_poll_flag to rds_socket structure to indicate the
> back pressure
>   status and send space availability.
> - Added MODULE_VERSION.
> - ehca:
> - Added support for RHEL4 up5
>
>
> Tested ULPs
> ===
> The following ULPs are tested:
> o OpenSM
> o MPI (MVAPICH and Open MPI)
> o IPoIB UD and CM
> o SDP
> o SRP
> o iSER
> o RDS
>
> ConnectX specific known issues and limitations
> ==
> - The following features are not supported:
>   o Resize CQ
>   o APM
>   o SQD
> - To load the driver on machines with 64KB default page size UAR bar
> must be
>   enlarged. 64KB page size is the default of PPC with RHEL5 and
> Itanium with
>   64KB page size enabled.
>   Perform the following three steps:
>   1. Add the following line in the firmware configuration (INI) file
> under the
>  [HCA] section:
>log2_uar_bar_megabytes = 5
>   2. Burn a modified firmware image with the changed INI file
>   3. Reboot the system
>
>
> Tziporet Koren
> Software Director
> Mellanox Technologies
> mailto: [EMAIL PROTECTED] 
> Tel +972-4-9097200, ext 380
>
> 
>
> ___
> ewg mailing list
> ewg@lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] [PATCH 0/2] IB/iser: move open-iscsi crypto functions to kernel_addons

[Erez Zilber]

Michael S. Tsirkin wrote:

>> Please pull from git://git.openfabrics.org/~/scm/linux-2.6.git ofed_1_2_c
>> 
>
> Is the URL wrong?
>
>   
Sorry. I guess that I have something against correct git urls lately :-)

Anyway, here's the correct url:

git://git.openfabrics.org/~erezz/linux-2.6.git ofed_1_2_c

Erez

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] [PATCH 0/2] IB/iser: move open-iscsi crypto functions to kernel_addons

[Erez Zilber]

Vladimir Sokolovsky wrote:

> This should be linux-2.6, not kernel-2.6
>
> In any case we took this commit:
>
> commit f558f506f0c10c8af664dd1f20d35ce26b19b133
> Author: Erez Zilber <[EMAIL PROTECTED]>
> Date:   Tue Aug 7 09:21:18 2007 +0300
>
> move open-iscsi crypto functions to kernel_addons (SLES10, RHEL5)
>
> Signed-off-by: Erez Zilber <[EMAIL PROTECTED]>
>
>
>
> Regards,
> Vladimir
>
>
>   
Vlad,

Please pull from git://git.openfabrics.org/~/scm/linux-2.6.git ofed_1_2_c

I've added a patch that fixes the data digest problems that we had in
RH4. So, you'll need 2 patches from that tree:

   1. commit 71652046d3a0b9adb3d9428b4506a0e4331b2882: move open-iscsi
  crypto functions to kernel_addons (RHEL4)
   2. commit e0d0bfa2c9d3035274c5a245827bc6b3df71195d: open-iscsi:
  Change scatterlist len in crypto_digest_update calls to 1


Will you be able to add it to the next 1.2.c build before the GA version?

Thanks,
Erez


___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] OFED 1.2.c-11 is available

[Erez Zilber]

Tziporet Koren wrote:

> Erez Zilber wrote:
> > Tziporet,
> >
> >
> > Can you add the following as a known issue:
> >
> >
> > "open-iscsi over TCP does not support usage of data digest on RedHat
> EL/AS 4 up3,
> > up4 & up5."
> >
> > Note that this comment should be added to OFED release notes, not to
> > iSER release notes. This is not an iSER bug (it's a bug in the backport
> > for open-iscsi).
> >
> > Thanks,
> > Erez
> >
> >  
> Will do in next build
>
> tziporet
>

Tziporet,


We were able to fix that problem, and Vlad already pulled the fix.
Therefore, the known issue that I wanted to add is irrelevant.


Erez



___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] ib_local_sa.ko is not created

[Erez Zilber]

Vlad,


I'm trying to build & run ofa_kernel from
git://git.openfabrics.org/~vlad/ofed_kernel.git ofed_kernel


I'm running the following configure cmd:


./configure --with-core-mod --with-ipoib-mod --with-mthca-mod
--with-mlx4-mod --with-iser-mod


However, ib_local_sa.ko is not created after I run `make`:


[EMAIL PROTECTED] ofed_kernel]# ll drivers/infiniband/core/*.ko
-rw-r--r-- 1 root root 467132 Aug 23 2007 drivers/infiniband/core/ib_cm.ko
-rw-r--r-- 1 root root 1239100 Aug 23 2007
drivers/infiniband/core/ib_core.ko
-rw-r--r-- 1 root root 761570 Aug 23 2007 drivers/infiniband/core/ib_mad.ko
-rw-r--r-- 1 root root 744899 Aug 23 2007 drivers/infiniband/core/ib_sa.ko
-rw-r--r-- 1 root root 232824 Aug 23 2007 drivers/infiniband/core/iw_cm.ko


Did I miss something?


Thanks,

-- 

____

Erez Zilber | 972-9-971-7689

Software Engineer, Storage Solutions Team

Voltaire – _The Grid Backbone_

__

www.voltaire.com <http://www.voltaire.com/>



___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Re: ib_local_sa.ko is not created

[Erez Zilber]

Michael S. Tsirkin wrote:

> IIRC this tree includes new local sa bits from Sean which
> are interated as part of sa module.
>

Do you mean to say that the sa module already contains ib_local_sa in
it? Anyway, I'm interested in rdma_cm, and when I try to load it, it
looks for ib_local_sa:

[EMAIL PROTECTED] ~]# modprobe rdma_cm
WARNING: Error inserting ib_local_sa
(/lib/modules/2.6.9-42.ELsmp/kernel/drivers/infiniband/core/ib_local_sa.ko):
Unknown symbol in module, or unknown parameter (see dmesg)
FATAL: Error inserting rdma_cm
(/lib/modules/2.6.9-42.ELsmp/kernel/drivers/infiniband/core/rdma_cm.ko):
Unknown symbol in module, or unknown parameter (see dmesg)
[EMAIL PROTECTED] ~]# dmesg -c
ib_local_sa: disagrees about version of symbol ib_unregister_client
ib_local_sa: Unknown symbol ib_unregister_client
[...]

It disagrees about the symbol version because my machine still has the
original ib_local_sa module that comes with RH4 up4. How can we solve
this problem?

Thanks,
Erez

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] open-iscsi-generic should not be in ofed.conf

[Erez Zilber]

Vlad,


I saw that an entry called "open-iscsi-generic" was added to ofed.conf
for OFED 1.3. Why? It wasn't there in OFED 1.2. If the user selects to
install iSER, open-iscsi should be also installed. I don't see a
situation where you want to install open-iscsi (as part of OFED) without
iSER.


-- 

________

Erez Zilber | 972-9-971-7689

Software Engineer, Storage Solutions Team

Voltaire – _The Grid Backbone_

__

www.voltaire.com <http://www.voltaire.com/>



___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] [PATCH] stop OFED before uninstalling it

[Erez Zilber]

stop OFED before uninstalling it

Signed-off-by: Erez Zilber <[EMAIL PROTECTED]>
---
 uninstall.sh |5 +
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/uninstall.sh b/uninstall.sh
index 177b8a1..89ee3f1 100755
--- a/uninstall.sh
+++ b/uninstall.sh
@@ -110,6 +110,11 @@ uninstall()
 {
 local RC=0
 local OLD_PREFIX=""
+
+echo "Stopping OFED stack"
+echo
+/etc/init.d/openibd stop
+
 echo
 echo "Removing ${PACKAGE} Software installations"
 echo
-- 
1.5.2

-- 
________

Erez Zilber   |  972-9-971-7689

Software Engineer, Storage Solutions Team

Voltaire – _The Grid Backbone_

 __

 www.voltaire.com <http://www.voltaire.com/>

<mailto:[EMAIL PROTECTED]>

  


___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] [PATCH] stop OFED before uninstalling it

[Erez Zilber]

Tziporet Koren wrote:

> Erez Zilber wrote:
>> stop OFED before uninstalling it
>>
>> Signed-off-by: Erez Zilber <[EMAIL PROTECTED]>
>> ---
>>  uninstall.sh |5 +
>>  1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/uninstall.sh b/uninstall.sh
>> index 177b8a1..89ee3f1 100755
>> --- a/uninstall.sh
>> +++ b/uninstall.sh
>> @@ -110,6 +110,11 @@ uninstall()
>>  {
>>  local RC=0
>>  local OLD_PREFIX=""
>> +
>> +echo "Stopping OFED stack"
>> +echo
>> +/etc/init.d/openibd stop
>> +
>>  echo
>>  echo "Removing ${PACKAGE} Software installations"
>>  echo
>>   
>
> What would the install do if this is failing or machine hang?
>
> Tziporet
>

The user will have to stop OFED at some point. If we don't stop OFED
while uninstalling, he will stop it later (and then the machine may hang).

The motivation for this patch is: if the user installs OFED over an
older version (while the old version is running), he will eventually
have a new version of OFED installed with an old loaded version. This
may lead to strange scenarios. For example: if the user tries to load
iSER, modprobe will fail because iSER (from the new OFED version) cannot
use the loaded OFED modules (from the old version). Of course, this can
happen with any OFED module.

Actually, this fix is related to bug #536. Maybe we should move this
discussion to bugzilla.

Erez

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] [PATCH] add upgrade section to OFED Installation Guide

[Erez Zilber]

>> >>  
>> >
>> > What would the install do if this is failing or machine hang?
>> >
>> > Tziporet
>> >
>>
>> The user will have to stop OFED at some point. If we don't stop OFED
>> while uninstalling, he will stop it later (and then the machine may hang).
>>
>> The motivation for this patch is: if the user installs OFED over an
>> older version (while the old version is running), he will eventually
>> have a new version of OFED installed with an old loaded version. This
>> may lead to strange scenarios. For example: if the user tries to load
>> iSER, modprobe will fail because iSER (from the new OFED version) cannot
>> use the loaded OFED modules (from the old version). Of course, this can
>> happen with any OFED module.
>>
>> Actually, this fix is related to bug #536. Maybe we should move this
>> discussion to bugzilla.
> 
> NAK.
> This would break e.g. systems which rely on ipoib for connectivity.

You're right.

> 
> iSER failing with clear version conflict message seems like a minor problem.
> How about just documenting this?  How about producing a message telling
> the user
> to reboot?

iSER is just an example. It can happen with any OFED component. I suggest to 
add the following warning to the documentation:

If the user runs an old OFED version, and upgrades to a
new version, the old version is still loaded even after
upgrading. We should warn the user about that.

Signed-off-by: Erez Zilber <[EMAIL PROTECTED]>
---
 OFED_Installation_Guide.txt |   17 +
 1 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/OFED_Installation_Guide.txt b/OFED_Installation_Guide.txt
index ccc01d5..12a94da 100644
--- a/OFED_Installation_Guide.txt
+++ b/OFED_Installation_Guide.txt
@@ -16,8 +16,9 @@ Table of contents
  6.  Building OFED RPMs
  7.  IPoIB Configuration
  8.  Uninstalling OFED
- 9.  Configuration
- 10. Related Documentation
+ 9.  Upgrading OFED
+ 10. Configuration
+ 11. Related Documentation
 
 
 ==
@@ -340,9 +341,17 @@ There are two ways to uninstall OFED:
 2) Using the script uninstall.sh. The script resides under OFED-X.X.X/
and under the installation  directory.
 
+==
+9. Upgrading OFED
+==
+
+If an old OFED version is installed, it may be upgraded by installing a
+new OFED version as described in section 5. Note that if the old OFED
+version was loaded before upgrading, you need to restart OFED or reboot
+your machine in order to start the new OFED stack.
 
 ==
-9. Configuration
+10. Configuration
 ==
 
 Most of the OFED components can be configured or reconfigured after
@@ -362,7 +371,7 @@ Note: After the installer completes, information about the 
OFED
   /etc/infiniband/info.
 
 ==
-10. Related Documentation
+11. Related Documentation
 ==
 
 OFED documentation is located in the ofed-docs RPM.  After
-- 
1.5.2


___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] open-iscsi-generic should not be in ofed.conf

[Erez Zilber]

Erez Zilber wrote:


Vlad,


I saw that an entry called "open-iscsi-generic" was added to ofed.conf
for OFED 1.3. Why? It wasn't there in OFED 1.2. If the user selects to
install iSER, open-iscsi should be also installed. I don't see a
situation where you want to install open-iscsi (as part of OFED) without
iSER.


Vlad?
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] [PATCH] add upgrade section to OFED Installation Guide

[Erez Zilber]

iSER is just an example. It can happen with any OFED component. I 
suggest to add the following warning to the documentation:


If the user runs an old OFED version, and upgrades to a
new version, the old version is still loaded even after
upgrading. We should warn the user about that.

Signed-off-by: Erez Zilber <[EMAIL PROTECTED]>
---
 OFED_Installation_Guide.txt |   17 +
 1 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/OFED_Installation_Guide.txt b/OFED_Installation_Guide.txt
index ccc01d5..12a94da 100644
--- a/OFED_Installation_Guide.txt
+++ b/OFED_Installation_Guide.txt
@@ -16,8 +16,9 @@ Table of contents
  6.  Building OFED RPMs
  7.  IPoIB Configuration
  8.  Uninstalling OFED
- 9.  Configuration
- 10. Related Documentation
+ 9.  Upgrading OFED
+ 10. Configuration
+ 11. Related Documentation


 ==
@@ -340,9 +341,17 @@ There are two ways to uninstall OFED:
 2) Using the script uninstall.sh. The script resides under OFED-X.X.X/
and under the installation  directory.

+==
+9. Upgrading OFED
+==
+
+If an old OFED version is installed, it may be upgraded by installing a
+new OFED version as described in section 5. Note that if the old OFED
+version was loaded before upgrading, you need to restart OFED or reboot
+your machine in order to start the new OFED stack.

 ==
-9. Configuration
+10. Configuration
 ==

 Most of the OFED components can be configured or reconfigured after
@@ -362,7 +371,7 @@ Note: After the installer completes, information 
about the OFED

   /etc/infiniband/info.

 ==
-10. Related Documentation
+11. Related Documentation
 ==

 OFED documentation is located in the ofed-docs RPM.  After
--
1.5.2



Tziporet,

Can you add this fix to the documentation?

Thanks,
Erez
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] [PATCH 0/2] IB/iser: iSCSI & iSER fixes for RH4 in OFED 1.3

[Erez Zilber]

The following patches fix bugs in open-iscsi over iSER for the RH4 backport in 
OFED 1.3.

-- 



Erez Zilber | 972-9-971-7689

Software Engineer, Storage Solutions Team

Voltaire – _The Grid Backbone_

__

www.voltaire.com <http://www.voltaire.com/>



___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] [PATCH 1/2] IB/iser: add iscsi session workqueue for old kernels

[Erez Zilber]

The scsi workqueue does not exist in old kernels (e.g RH4).
For such kernels, a session should have its own queue.

Signed-off-by: Erez Zilber <[EMAIL PROTECTED]>
---
 .../backport/2.6.9_U3/add_iscsi_session_wq.patch   |  135 
 .../2.6.9_U3/libiscsi_no_flush_to_2_6_9.patch  |   31 -
 .../backport/2.6.9_U4/add_iscsi_session_wq.patch   |  135 
 .../2.6.9_U4/libiscsi_no_flush_to_2_6_9.patch  |   31 -
 .../backport/2.6.9_U5/add_iscsi_session_wq.patch   |  135 
 .../2.6.9_U5/libiscsi_no_flush_to_2_6_9.patch  |   31 -
 6 files changed, 405 insertions(+), 93 deletions(-)
 create mode 100644 kernel_patches/backport/2.6.9_U3/add_iscsi_session_wq.patch
 delete mode 100644 
kernel_patches/backport/2.6.9_U3/libiscsi_no_flush_to_2_6_9.patch
 create mode 100644 kernel_patches/backport/2.6.9_U4/add_iscsi_session_wq.patch
 delete mode 100644 
kernel_patches/backport/2.6.9_U4/libiscsi_no_flush_to_2_6_9.patch
 create mode 100644 kernel_patches/backport/2.6.9_U5/add_iscsi_session_wq.patch
 delete mode 100644 
kernel_patches/backport/2.6.9_U5/libiscsi_no_flush_to_2_6_9.patch

diff --git a/kernel_patches/backport/2.6.9_U3/add_iscsi_session_wq.patch 
b/kernel_patches/backport/2.6.9_U3/add_iscsi_session_wq.patch
new file mode 100644
index 000..877952f
--- /dev/null
+++ b/kernel_patches/backport/2.6.9_U3/add_iscsi_session_wq.patch
@@ -0,0 +1,135 @@
+diff --git a/drivers/infiniband/ulp/iser/iser_initiator.c 
b/drivers/infiniband/ulp/iser/iser_initiator.c
+index 9ea5b9a..751b963 100644
+--- a/drivers/infiniband/ulp/iser/iser_initiator.c
 b/drivers/infiniband/ulp/iser/iser_initiator.c
+@@ -612,7 +612,7 @@ void iser_snd_completion(struct iser_desc *tx_desc)
+ 
+   if (resume_tx) {
+   iser_dbg("%ld resuming tx\n",jiffies);
+-  scsi_queue_work(conn->session->host, &conn->xmitwork);
++  queue_work(conn->session->wq, &conn->xmitwork);
+   }
+ 
+   if (tx_desc->type == ISCSI_TX_CONTROL) {
+diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
+index a21455d..7f9eb42 100644
+--- a/drivers/scsi/iscsi_tcp.c
 b/drivers/scsi/iscsi_tcp.c
+@@ -415,7 +415,7 @@ iscsi_r2t_rsp(struct iscsi_conn *conn, struct 
iscsi_cmd_task *ctask)
+   tcp_ctask->xmstate |= XMSTATE_SOL_HDR_INIT;
+   list_move_tail(&ctask->running, &conn->xmitqueue);
+ 
+-  scsi_queue_work(session->host, &conn->xmitwork);
++  queue_work(session->wq, &conn->xmitwork);
+   conn->r2t_pdus_cnt++;
+   spin_unlock(&session->lock);
+ 
+@@ -1044,7 +1044,7 @@ iscsi_write_space(struct sock *sk)
+ 
+   tcp_conn->old_write_space(sk);
+   debug_tcp("iscsi_write_space: cid %d\n", conn->id);
+-  scsi_queue_work(conn->session->host, &conn->xmitwork);
++  queue_work(conn->session->wq, &conn->xmitwork);
+ }
+ 
+ static void
+diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
+index 5606d1e..1611caf 100644
+--- a/drivers/scsi/libiscsi.c
 b/drivers/scsi/libiscsi.c
+@@ -87,8 +87,7 @@ iscsi_update_cmdsn(struct iscsi_session *session, struct 
iscsi_nopin *hdr)
+*/
+   if (!list_empty(&session->leadconn->xmitqueue) ||
+   __kfifo_len(session->leadconn->mgmtqueue))
+-  scsi_queue_work(session->host,
+-  &session->leadconn->xmitwork);
++  queue_work(session->wq, &session->leadconn->xmitwork);
+   }
+ }
+ EXPORT_SYMBOL_GPL(iscsi_update_cmdsn);
+@@ -863,7 +862,7 @@ int iscsi_queuecommand(struct scsi_cmnd *sc, void 
(*done)(struct scsi_cmnd *))
+   list_add_tail(&ctask->running, &conn->xmitqueue);
+   spin_unlock(&session->lock);
+ 
+-  scsi_queue_work(host, &conn->xmitwork);
++  queue_work(session->wq, &conn->xmitwork);
+   return 0;
+ 
+ reject:
+@@ -942,7 +941,7 @@ int iscsi_conn_send_pdu(struct iscsi_cls_conn *cls_conn, 
struct iscsi_hdr *hdr,
+   if (!__iscsi_conn_send_pdu(conn, hdr, data, data_size))
+   err = -EPERM;
+   spin_unlock_bh(&session->lock);
+-  scsi_queue_work(session->host, &conn->xmitwork);
++  queue_work(session->wq, &conn->xmitwork);
+   return err;
+ }
+ EXPORT_SYMBOL_GPL(iscsi_conn_send_pdu);
+@@ -1066,7 +1065,7 @@ static int iscsi_exec_abort_task(struct scsi_cmnd *sc,
+   debug_scsi("abort set timeout [itt 0x%x]\n", ctask->itt);
+   }
+   spin_unlock_bh(&session->lock);
+-  scsi_queue_work(session->host, &conn->xmitwork);
++  queue_work(session->wq, &conn->xmitwork);
+ 
+   /*
+* block eh thread until:
+@@ -1231,7 +1230,7 @@ int iscsi_eh_abort(struct scsi_cmnd *sc)
+* make 

[ewg] [PATCH 2/2] IB/iser: handle non-sg data with the new sg list api

[Erez Zilber]

In old kerenels (e.g. RH4), the data buffer of a scsi cmd may be a single
data buffer or an sg array. If a single data buffer is used, the new sg list
api doesn't handle it correctly.

Signed-off-by: Erez Zilber <[EMAIL PROTECTED]>
---
 .../backport/2.6.9_U3/iser_cmd_to_2_6_22.patch |   16 
 .../backport/2.6.9_U4/iser_cmd_to_2_6_22.patch |   16 
 .../backport/2.6.9_U5/iser_cmd_to_2_6_22.patch |   16 
 3 files changed, 48 insertions(+), 0 deletions(-)
 create mode 100644 kernel_patches/backport/2.6.9_U3/iser_cmd_to_2_6_22.patch
 create mode 100644 kernel_patches/backport/2.6.9_U4/iser_cmd_to_2_6_22.patch
 create mode 100644 kernel_patches/backport/2.6.9_U5/iser_cmd_to_2_6_22.patch

diff --git a/kernel_patches/backport/2.6.9_U3/iser_cmd_to_2_6_22.patch 
b/kernel_patches/backport/2.6.9_U3/iser_cmd_to_2_6_22.patch
new file mode 100644
index 000..e34c23a
--- /dev/null
+++ b/kernel_patches/backport/2.6.9_U3/iser_cmd_to_2_6_22.patch
@@ -0,0 +1,16 @@
+diff -rup ofa_kernel-1.3-orig/drivers/infiniband/ulp/iser/iser_initiator.c 
ofa_kernel-1.3-sg-fix/drivers/infiniband/ulp/iser/iser_initiator.c
+--- ofa_kernel-1.3-orig/drivers/infiniband/ulp/iser/iser_initiator.c   
2007-09-10 13:11:06.0 +0300
 ofa_kernel-1.3-sg-fix/drivers/infiniband/ulp/iser/iser_initiator.c 
2007-09-10 13:12:38.0 +0300
+@@ -354,6 +354,12 @@ int iser_send_command(struct iscsi_conn 
+   if (scsi_sg_count(sc)) { /* using a scatter list */
+   data_buf->buf  = scsi_sglist(sc);
+   data_buf->size = scsi_sg_count(sc);
++  } else if (sc->request_bufflen) {
++  /* using a single buffer - convert it into one entry SG */
++  sg_init_one(&data_buf->sg_single,
++  sc->request_buffer, sc->request_bufflen);
++  data_buf->buf = &data_buf->sg_single;
++  data_buf->size = 1;
+   }
+ 
+   data_buf->data_len = scsi_bufflen(sc);
diff --git a/kernel_patches/backport/2.6.9_U4/iser_cmd_to_2_6_22.patch 
b/kernel_patches/backport/2.6.9_U4/iser_cmd_to_2_6_22.patch
new file mode 100644
index 000..e34c23a
--- /dev/null
+++ b/kernel_patches/backport/2.6.9_U4/iser_cmd_to_2_6_22.patch
@@ -0,0 +1,16 @@
+diff -rup ofa_kernel-1.3-orig/drivers/infiniband/ulp/iser/iser_initiator.c 
ofa_kernel-1.3-sg-fix/drivers/infiniband/ulp/iser/iser_initiator.c
+--- ofa_kernel-1.3-orig/drivers/infiniband/ulp/iser/iser_initiator.c   
2007-09-10 13:11:06.0 +0300
 ofa_kernel-1.3-sg-fix/drivers/infiniband/ulp/iser/iser_initiator.c 
2007-09-10 13:12:38.0 +0300
+@@ -354,6 +354,12 @@ int iser_send_command(struct iscsi_conn 
+   if (scsi_sg_count(sc)) { /* using a scatter list */
+   data_buf->buf  = scsi_sglist(sc);
+   data_buf->size = scsi_sg_count(sc);
++  } else if (sc->request_bufflen) {
++  /* using a single buffer - convert it into one entry SG */
++  sg_init_one(&data_buf->sg_single,
++  sc->request_buffer, sc->request_bufflen);
++  data_buf->buf = &data_buf->sg_single;
++  data_buf->size = 1;
+   }
+ 
+   data_buf->data_len = scsi_bufflen(sc);
diff --git a/kernel_patches/backport/2.6.9_U5/iser_cmd_to_2_6_22.patch 
b/kernel_patches/backport/2.6.9_U5/iser_cmd_to_2_6_22.patch
new file mode 100644
index 000..e34c23a
--- /dev/null
+++ b/kernel_patches/backport/2.6.9_U5/iser_cmd_to_2_6_22.patch
@@ -0,0 +1,16 @@
+diff -rup ofa_kernel-1.3-orig/drivers/infiniband/ulp/iser/iser_initiator.c 
ofa_kernel-1.3-sg-fix/drivers/infiniband/ulp/iser/iser_initiator.c
+--- ofa_kernel-1.3-orig/drivers/infiniband/ulp/iser/iser_initiator.c   
2007-09-10 13:11:06.0 +0300
 ofa_kernel-1.3-sg-fix/drivers/infiniband/ulp/iser/iser_initiator.c 
2007-09-10 13:12:38.0 +0300
+@@ -354,6 +354,12 @@ int iser_send_command(struct iscsi_conn 
+   if (scsi_sg_count(sc)) { /* using a scatter list */
+   data_buf->buf  = scsi_sglist(sc);
+   data_buf->size = scsi_sg_count(sc);
++  } else if (sc->request_bufflen) {
++  /* using a single buffer - convert it into one entry SG */
++  sg_init_one(&data_buf->sg_single,
++  sc->request_buffer, sc->request_bufflen);
++  data_buf->buf = &data_buf->sg_single;
++  data_buf->size = 1;
+   }
+ 
+   data_buf->data_len = scsi_bufflen(sc);
-- 
1.5.3


___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] RE: [PATCH 0/2] IB/iser: iSCSI & iSER fixes for RH4 in OFED 1.3

[Erez Zilber]

>> Quoting Erez Zilber <[EMAIL PROTECTED]>:
>> Subject: [PATCH 0/2] IB/iser: iSCSI & iSER fixes for RH4 in OFED 1.3
>>
>> The following patches fix bugs in open-iscsi over iSER for the RH4 backport 
>> in OFED 1.3.
> 
> can you pls stick this in a git tree so I can pull?

No problem. I thought that you can take the patch from the e-mail. Anyway, the 
git tree is here:
 
git://git.openfabrics.org/~erezz/linux-2.6.git ofed_kernel
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Re: [PATCH 0/2] IB/iser: iSCSI & iSER fixes for RH4 in OFED 1.3

[Erez Zilber]

>> 
>
> What about
> kernel_patches/backport/2.6.9_U5/iser_cmd_to_2_6_22.patch
>
> given the name, isn't it needed in other kernels up to 2.6.22 too?
>
>   

You're right. I've just fixed that in the git tree. I hope it's ok now.

Erez

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: [PATCH 0/2] IB/iser: iSCSI & iSER fixes for RH4 in OFED 1.3

[Erez Zilber]

Erez Zilber wrote:

>>> 
>>>   
>> What about
>> kernel_patches/backport/2.6.9_U5/iser_cmd_to_2_6_22.patch
>>
>> given the name, isn't it needed in other kernels up to 2.6.22 too?
>>
>>   
>> 
>
> You're right. I've just fixed that in the git tree. I hope it's ok now.
>
> Erez
>   

Michael?

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Re: ofed 1.3 kernel tree updated to 2.6.23-rc8

[Erez Zilber]

Michael S. Tsirkin wrote:


Hello!
I have updated the OFED 1.3 kernel tree at
git://git.openfabrics.org/ofed_1_3/linux-2.6.git ofed_kernel
to upstream 2.6.23-rc8.

I have resolved minor conflicts in libiscsi backports for RHEL4,
and everything seems to build fine now. iSER maintainers, please
verify that I did the right thing.

--
MST

Those fixes are problematic because you didn't merge the patches that I 
sent 2 weeks ago:  
http://lists.openfabrics.org/pipermail/ewg/2007-September/004576.html


I suggest that you merge them first, and then we can see if there are 
any conflicts.


Thanks,
Erez
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: ofed 1.3 kernel tree updated to 2.6.23-rc8

[Erez Zilber]

Erez Zilber wrote:


Michael S. Tsirkin wrote:
>
> Hello!
> I have updated the OFED 1.3 kernel tree at
> git://git.openfabrics.org/ofed_1_3/linux-2.6.git ofed_kernel
> to upstream 2.6.23-rc8.
>
> I have resolved minor conflicts in libiscsi backports for RHEL4,
> and everything seems to build fine now. iSER maintainers, please
> verify that I did the right thing.
>
> --
> MST
>
Those fixes are problematic because you didn't merge the patches that I
sent 2 weeks ago: 
http://lists.openfabrics.org/pipermail/ewg/2007-September/004576.html


I suggest that you merge them first, and then we can see if there are
any conflicts.



Vlad,

I've adjusted the patches that I sent 2 weeks ago to fit 2.6.23-rc8. 
Please pull it from git://git.openfabrics.org/~erezz/linux-2.6.git 
ofed_kernel


Thanks,
Erez
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Re: iSER issues for OFED 1.3

[Erez Zilber]

Vladimir Sokolovsky wrote:


> -Original Message-
> From: Erez Zilber [mailto:[EMAIL PROTECTED]
> Sent: Monday, October 08, 2007 5:29 PM
> To: Vladimir Sokolovsky
> Subject: Re: iSER issues for OFED 1.3
>
>
> >> -Original Message-
> >> From: Erez Zilber [mailto:[EMAIL PROTECTED]
> >> Sent: Monday, October 08, 2007 1:19 PM
> >> To: Vladimir Sokolovsky
> >> Subject: iSER issues for OFED 1.3
> >>
> >> Vlad,
> >>
> >> The are some iSER related open issues in OFED 1.3 that we need to
> >> complete:
> >>
> >> * I have some fixes that I need you to merge:
> >>   http://lists.openfabrics.org/pipermail/ewg/2007-
> >> October/004638.html
> >>
> >
> > Working on this now.
> >
>
> Thanks
>

kernel_patches/backport/2.6.9_U2/libiscsi_no_flush_to_2_6_9.patch is
broken:

Applying patch libiscsi_no_flush_to_2_6_9.patch
patching file drivers/scsi/libiscsi.c
Hunk #1 FAILED at 1225.
Hunk #2 succeeded at 1640 (offset 32 lines).
Hunk #3 FAILED at 1784.
2 out of 3 hunks FAILED -- rejects in file drivers/scsi/libiscsi.c
Patch libiscsi_no_flush_to_2_6_9.patch does not apply (enforce with -f)

Please test your patches with ofed_scripts/ofed_makedist.sh



I didn't know that this patch ever existed. open-iscsi is not supported 
on RH4 up2, so why should this happen? The installation script in OFED 
1.2 prevented that.




> >
> >> * I sent you an e-mail yesterday (for some reason, I don't see
> it
> >> on
> >>   the ewg list) about separating iscsi modules from the
> ofa_kernel
> >> rpm.
> >>
> >
> > I suggest to take ib-bonding as an example
> >
>
> I spoke with MoniS about that. He says that no IB module uses the
> bonding module symbols. This is different from what we have in iSER:
> iSER uses symbols from open-iscsi. If the open-iscsi rpm looks like
the
> bonding rpm, it won't work because iSER will be later get built (in
the
> ofa_kernel rpm) against the old open-iscsi symbols (from the distro).
> What do you suggest to do?
>

You can create Module.symvers file for the new open-iscsi symbols and
then copy this file into iSER subdirectory before compiling iSER.



This is really problematic because it means that we need to do the 
following:


   * Compile open-iscsi and create the binary open-iscsi rpm.
   * Open the ofa_kernel src rpm and copy Module.symvers into it.
   * Create the ofa_kernel src rpm again and compile it.

Unless you have another idea, I think that we should consider not 
separating iSCSI from the ofa_kernel rpm. It will be not as clean as we 
wanted in the first place, but the code will be simpler and easier to 
maintain.


Erez
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: iSER issues for OFED 1.3

[Erez Zilber]

Vladimir Sokolovsky wrote:


Erez Zilber wrote:
> Vladimir Sokolovsky wrote:
>>
>> > -Original Message-----
>> > From: Erez Zilber [mailto:[EMAIL PROTECTED]
>> > Sent: Monday, October 08, 2007 5:29 PM
>> > To: Vladimir Sokolovsky
>> > Subject: Re: iSER issues for OFED 1.3
>> >
>> >
>> > >> -Original Message-
>> > >> From: Erez Zilber [mailto:[EMAIL PROTECTED]
>> > >> Sent: Monday, October 08, 2007 1:19 PM
>> > >> To: Vladimir Sokolovsky
>> > >> Subject: iSER issues for OFED 1.3
>> > >>
>> > >> Vlad,
>> > >>
>> > >> The are some iSER related open issues in OFED 1.3 that we need to
>> > >> complete:
>> > >>
>> > >> * I have some fixes that I need you to merge:
>> > >>   http://lists.openfabrics.org/pipermail/ewg/2007-
>> > >> October/004638.html
>> > >>
>> > >
>> > > Working on this now.
>> > >
>> >
>> > Thanks
>> >
>>
>> kernel_patches/backport/2.6.9_U2/libiscsi_no_flush_to_2_6_9.patch is
>> broken:
>>
>> Applying patch libiscsi_no_flush_to_2_6_9.patch
>> patching file drivers/scsi/libiscsi.c
>> Hunk #1 FAILED at 1225.
>> Hunk #2 succeeded at 1640 (offset 32 lines).
>> Hunk #3 FAILED at 1784.
>> 2 out of 3 hunks FAILED -- rejects in file drivers/scsi/libiscsi.c
>> Patch libiscsi_no_flush_to_2_6_9.patch does not apply (enforce with -f)
>>
>> Please test your patches with ofed_scripts/ofed_makedist.sh
>>
>
> I didn't know that this patch ever existed. open-iscsi is not supported
> on RH4 up2, so why should this happen? The installation script in OFED
> 1.2 prevented that.
>

In any case your last commits break this patch.
Should I remove it from the backports?



I don't think that I committed anything for RH4 up2. This patch 
(kernel_patches/backport/2.6.9_U2/libiscsi_no_flush_to_2_6_9.patch) was 
added by MST at some point. I don't need it. Feel free to throw it away.



>>
>> > >
>> > >> * I sent you an e-mail yesterday (for some reason, I don't see
>> > it
>> > >> on
>> > >>   the ewg list) about separating iscsi modules from the
>> > ofa_kernel
>> > >> rpm.
>> > >>
>> > >
>> > > I suggest to take ib-bonding as an example
>> > >
>> >
>> > I spoke with MoniS about that. He says that no IB module uses the
>> > bonding module symbols. This is different from what we have in iSER:
>> > iSER uses symbols from open-iscsi. If the open-iscsi rpm looks like
>> the
>> > bonding rpm, it won't work because iSER will be later get built (in
>> the
>> > ofa_kernel rpm) against the old open-iscsi symbols (from the distro).
>> > What do you suggest to do?
>> >
>>
>> You can create Module.symvers file for the new open-iscsi symbols and
>> then copy this file into iSER subdirectory before compiling iSER.
>>
>
> This is really problematic because it means that we need to do the
> following:
>
>* Compile open-iscsi and create the binary open-iscsi rpm.
Right.

>* Open the ofa_kernel src rpm and copy Module.symvers into it.
>* Create the ofa_kernel src rpm again and compile it.
>
Why is that?
open-iscsi RPM can include its Module.symvers and install it.
Then ofa_kernel rpmbuild process should copy this file into iSER 
subdirectory and run make.


> Unless you have another idea, I think that we should consider not
> separating iSCSI from the ofa_kernel rpm. It will be not as clean as we
> wanted in the first place, but the code will be simpler and easier to
> maintain.
>
Why do you want to separate iSCSI from ofa_kernel?
I am OK with leaving iSCSI as is.



Let's leave it like that.

Erez
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Re: [ofa-general] OFED October 22 meeting summary on OFED 1.3 alphastatus and beta tasks

[Erez Zilber]

Tziporet Koren wrote:


OFED October 8 meeting summary on OFED 1.3 alpha status and beta tasks:

Meeting summary:

1. Alpha release status:
* Cisco - tested only RHEL 4 & 5 on x86_64 systems
* Qlogic - in general looks good
* Intel - test Intel MPI on 16 nodes cluster on RHEL 5.1
* Voltaire - partial regression SLES10 SP1 Redhat 5; few on RHEL 4 up5
* Mellanox - regression tests pass on all HCAs. Tested SLES10, RHEL 4 up
4 & up5 , RHEL 5
* IBM - test mainly SLES10 SP1 on PPC; solve issues in ehca with their
new HCA;
see issues with 32 bits library

2. MPI status:
* MVAPICH - We wish to integrate the 1.0 code by the end of this week.
In this way it will be ready for the OFED beta release next week - need
DK approval
* Open MPI - Open MPI v1.2.4 is sufficient for OFED 1.3. It contains a
critical fix for ConnectX hardware that will greatly improve the
point-to-point latency for small messages.
Open MPI v1.3 is far enough away that we're not ready for anything newer
to go into OFED 1.3.
* VMAPICH 2 - ready for the release.

3. Tasks that should completed for the beta:
1. Integrate all SDP features - Jim (Mellanox) - will be
completed this week
2. Complete RDS work - Vlad (Mellanox) - on work
3. Apply patches that fix warning of backport patches - Vlad
(Mellanox)
4. Fix compilation problems on PPC with 32 bits - Vlad
(Mellanox) -
 Nam please open a bug on this issue
5. Add qperf test from Qlogic - Johann (Qlogic) - on work
6. Rebase kernel code on 2.6.24 rc1 (depending it's
availability)
   Will require changes in the bonding module too.
7. Support RHEL 5 up1 - Woody & Vlad - done
8. SPEC files should be part of each user space package - each
owner should take the spec file
9. Multiple uDAPL libs (1.0 & 2.0)
 10. iSER - update the open iscsi package 



Done


 11. nes - need to update some backport patches (Gleb)

* Beta target date will be decided in next week meeting based on the
progress of the above


4. OFED meetings:
* Starting next week we will move to weekly meetings to have a better
tracking for the release progress
* Jeff S. will send the meeting schedule and details

5. NFS-RDMA:
* NFS-RDMA will be part of Linux kernel 2.6.24
* Thus it will be in OFED 1.3 kernel, but we need backport patches to
support the distros
* Bill Boas will speak to OGC (Tom Tucker and Steve Wise) to see if this
can be done for the beta, at least for the latest OSes (e.g. RHEL5,
SLES10 SP1)

6. Developers' summit:
* All people requested to review the agenda Johann will publish and make
sure all subjects we wish to discuss are covered.

___
general mailing list
[EMAIL PROTECTED]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general

To unsubscribe, please visit 
http://openib.org/mailman/listinfo/openib-general



___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] iSER for stgt - wiki page

[Erez Zilber]

The following wiki page is a quick start guide for running an iSCSI over
iSER target through the open-source stgt project:


https://wiki.openfabrics.org/tiki-index.php?page=ISER-target


For more information about stgt: http://stgt.berlios.de/


I hope that you find it helpful.


-- 



Erez Zilber | 972-9-971-7689

Software Engineer, Storage Solutions

Voltaire – _The Grid Backbone_

__

www.voltaire.com <http://www.voltaire.com/>




--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To post to this group, send email to [EMAIL PROTECTED]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at http://groups.google.com/group/open-iscsi
-~--~~~~--~~--~--~---

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Re: [ofa-general] iSER for stgt - wiki page

[Erez Zilber]

Sufficool, Stanley wrote:

> Does anyone know a source for Windows initiators for iSER?
>

Currently, there's no open-source iSER initiator for Windows. However,
we (Voltaire) are working on it.

-- 

____

Erez Zilber | 972-9-971-7689

Software Engineer, Storage Solutions

Voltaire – _The Grid Backbone_

__

www.voltaire.com <http://www.voltaire.com/>



___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Re: ofed_kernel merged with 2.6.24-rc1 patches update required

[Erez Zilber]

Vladimir Sokolovsky wrote:


Hello,
There is a new branch "ofed_kernel_2_6_24_rc1" under 
git://git.openfabrics.org/ofed_1_3/linux-2.6.git


All patches from kernel_patches/fixes that were applied in 2.6.24-rc1 
were removed from kernel_patches/fixes directory.
The "problematic" patches from kernel_patches/fixes were moved to the 
kernel_patches/attic directory.


Backport patches and fixes should be updated according to the new 
kernel tree.
The easy way to do so is using "ofed_scripts/ofed_makedist.sh" utility 
which creates tgz file for every supported kernel with all relevant 
patches applied.


We want to move to the new branch on this Wednesday (31 Oct 2007)
Please send me updated backport patches and fixes by tomorrow.


Regards,
Vladimir



Vlad,

I'm trying to run ofed_makedist.sh according to the instructions from 
https://wiki.openfabrics.org/tiki-index.php?page=HOWTO+Build+OFA+kernel+package:


[EMAIL PROTECTED] linux-2.6]# ./ofed_scripts/ofed_makedist.sh
git clone -q -s -n /home/erezz/work/ofed/linux-2.6 
/tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11

pushd /tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11
/tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11 
/home/erezz/work/ofed/linux-2.6
/home/erezz/work/ofed/linux-2.6/ofed_scripts/ofed_checkout.sh 
e9f4951c8b3e2e784860545edf93b83189e34ce6 
379afb8172cceb63872bd1ce8d1b318abf18bcf9 >> 
/tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11.log
/home/erezz/work/ofed/linux-2.6/ofed_scripts/ofed_patch.sh 
--with-backport=2.6.11 >> 
/tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11.log
Failed executing 
/home/erezz/work/ofed/linux-2.6/ofed_scripts/ofed_patch.sh 
--with-backport=2.6.11 >> 
/tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11.log
   
/tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11/kernel_patches/backport/2.6.11/ipoib_8111_to_2_6_16.patch

patching file drivers/infiniband/ulp/ipoib/ipoib.h
Hunk #1 succeeded at 350 (offset 20 lines).
patching file drivers/infiniband/ulp/ipoib/ipoib_main.c
Hunk #2 FAILED at 856.
Hunk #3 succeeded at 897 (offset -8 lines).
Hunk #4 succeeded at 916 with fuzz 2 (offset -1 lines).
Hunk #5 succeeded at 932 (offset -8 lines).
1 out of 5 hunks FAILED -- saving rejects to file 
drivers/infiniband/ulp/ipoib/ipoib_main.c.rej
Failed to apply patch: 
/tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11/kernel_patches/backport/2.6.11/ipoib_8111_to_2_6_16.patch

Build failed in /tmp/build-ofed_kernel-nm2119
See log file /tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11.log

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: ofed_kernel merged with 2.6.24-rc1 patches update required

[Erez Zilber]

Tziporet Koren wrote:

Erez Zilber wrote:


Vlad,

I'm trying to run ofed_makedist.sh according to the instructions from 
https://wiki.openfabrics.org/tiki-index.php?page=HOWTO+Build+OFA+kernel+package: 



[EMAIL PROTECTED] linux-2.6]# ./ofed_scripts/ofed_makedist.sh
git clone -q -s -n /home/erezz/work/ofed/linux-2.6 
/tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11

pushd /tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11
/tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11 
/home/erezz/work/ofed/linux-2.6
/home/erezz/work/ofed/linux-2.6/ofed_scripts/ofed_checkout.sh 
e9f4951c8b3e2e784860545edf93b83189e34ce6 
379afb8172cceb63872bd1ce8d1b318abf18bcf9 >> 
/tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11.log
/home/erezz/work/ofed/linux-2.6/ofed_scripts/ofed_patch.sh 
--with-backport=2.6.11 >> 
/tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11.log
Failed executing 
/home/erezz/work/ofed/linux-2.6/ofed_scripts/ofed_patch.sh 
--with-backport=2.6.11 >> 
/tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11.log
   
/tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11/kernel_patches/backport/2.6.11/ipoib_8111_to_2_6_16.patch 


patching file drivers/infiniband/ulp/ipoib/ipoib.h
Hunk #1 succeeded at 350 (offset 20 lines).
patching file drivers/infiniband/ulp/ipoib/ipoib_main.c
Hunk #2 FAILED at 856.
Hunk #3 succeeded at 897 (offset -8 lines).
Hunk #4 succeeded at 916 with fuzz 2 (offset -1 lines).
Hunk #5 succeeded at 932 (offset -8 lines).
1 out of 5 hunks FAILED -- saving rejects to file 
drivers/infiniband/ulp/ipoib/ipoib_main.c.rej
Failed to apply patch: 
/tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11/kernel_patches/backport/2.6.11/ipoib_8111_to_2_6_16.patch 


Build failed in /tmp/build-ofed_kernel-nm2119
See log file /tmp/build-ofed_kernel-nm2119/ofed_kernel-2.6.11.log


We are aware of this
Eli will work to fix these


Different problems now:

thyme:/home/erezz/work/ofed/linux-2.6 # ./ofed_scripts/ofed_makedist.sh
git clone -q -s -n /home/erezz/work/ofed/linux-2.6 
/tmp/build-ofed_kernel-rB1017/ofed_kernel-2.6.11
Initialized empty Git repository in 
/tmp/build-ofed_kernel-rB1017/ofed_kernel-2.6.11/.git/

pushd /tmp/build-ofed_kernel-rB1017/ofed_kernel-2.6.11
/tmp/build-ofed_kernel-rB1017/ofed_kernel-2.6.11 
/home/erezz/work/ofed/linux-2.6
/home/erezz/work/ofed/linux-2.6/ofed_scripts/ofed_checkout.sh 
b2d3675c40b61182b184ddf476d3c733ede164fd 
b0138854a4fe4de7c65a78876cf15cb186e66c21 >> 
/tmp/build-ofed_kernel-rB1017/ofed_kernel-2.6.11.log
/home/erezz/work/ofed/linux-2.6/ofed_scripts/ofed_patch.sh 
--with-backport=2.6.11 >> 
/tmp/build-ofed_kernel-rB1017/ofed_kernel-2.6.11.log

chmod -R u+rw .pc
chmod: cannot access `.pc': No such file or directory
Failed executing chmod -R u+rw .pc
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: ofed_kernel merged with 2.6.24-rc1 patches update required

[Erez Zilber]

Vladimir Sokolovsky wrote:

Erez,
Do you have "quilt" installed?


Regards,
Vladimir
  



No. Do I need quilt in order to build/test OFED?

Erez
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: ofed_kernel merged with 2.6.24-rc1 patches update required

[Erez Zilber]

OK. Let me know when you apply it and I will try to rerun 
ofed_makedist.sh. Just to make sure that I understand - does this fix 
allow the script to run without having quilt installed?


Erez

Vladimir Sokolovsky wrote:

No, only for ofed_makedist.sh.
Ralph Campbell already sent me the patch that fix this issue. I will
apply it shortly.


Regards,
Vladimir


  

-Original Message-
From: Erez Zilber [mailto:[EMAIL PROTECTED]
Sent: Tuesday, November 06, 2007 10:21 AM
To: Vladimir Sokolovsky
Cc: OpenFabricsEWG
Subject: Re: [ewg] Re: ofed_kernel merged with 2.6.24-rc1 patches
update required

Vladimir Sokolovsky wrote:


Erez,
Do you have "quilt" installed?


Regards,
Vladimir


  

No. Do I need quilt in order to build/test OFED?

Erez


___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: ofed_kernel merged with 2.6.24-rc1 patches update required

[Erez Zilber]

open-iscsi & iSER backport patches work ok for the following distros:

   * SLES 10
   * SLES 10 sp1
   * RHEL 5
   * RHEL 5 up1
   * RHAS4 up4
   * RHAS4 up5

I wasn't able to test open-iscsi over iSER for the following distros 
(because other patches fail):


   * RHAS4 up3 - could not apply 2.6.9_U3/core_4807_to_2_6_9.patch


FYI - Some other distros (that open-iscsi over iSER is not supported on) 
fail:


   * SLES 9 sp3 - could not apply 2.6.5_sles9_sp3/core_4807_to_2_6_9.patch
   * RHAS4 up2 - could not apply 2.6.9_U2/core_4807_to_2_6_9.patch

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: ofed_kernel merged with 2.6.24-rc1 patches update required

[Erez Zilber]

Tziporet Koren wrote:

> Erez Zilber wrote:
> >
> >
> > I wasn't able to test open-iscsi over iSER for the following distros
> > (because other patches fail):
> >
> >* RHAS4 up3 - could not apply 2.6.9_U3/core_4807_to_2_6_9.patch
> >* SLES 9 sp3 - could not apply
> > 2.6.5_sles9_sp3/core_4807_to_2_6_9.patch
> >* RHAS4 up2 - could not apply 2.6.9_U2/core_4807_to_2_6_9.patch
> >
> We do not support these OSes in OFED 1.3
>

If they are not supported, the ofed_makedist script should skip them.
Currently, it stops whenever a backport fails. It doesn't proceed beyond
SLES 9 sp3. Vlad - what do you think?

Erez

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Did OFED 1.3 move to 2.6.24-rc1?

[Erez Zilber]

Vlad,

I saw that the last 3 daily builds failed because of compilation errors 
in iSER. I guess that it is because you moved to 2.6.24-rc1, correct? I 
don't understand why didn't I catch this bug last week with the 
ofed_makedist script.


Anyway, which branch should I put the fix in? ofed_kernel? 
ofed_kernel_2_6_24_rc1?


Erez
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Re: [Fwd: [ofa-general] ofa_1_3_kernel 20071118-0200 daily build status]

[Erez Zilber]

Vladimir Sokolovsky wrote:

Hi Erez,
Are you going to prepare backport patches for ISER?

Regards,
Vladimir
  

Vlad,

Please pull from git.openfabrics.org/~erezz/linux-2.6.git (I'm currently 
pushing it)


It should fix the compilation problems in open-iscsi & iSER.

Erez
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] [PATCH] IB/iser: added kernel_patches/fixes/iser-Add-missing-counter-incrementation-in-iser.patch

[Erez Zilber]

Vlad,

I've added a patch for iSER that was pushed upstream and will be hopefully 
included in the next 2.6.24 rc.

Please pull from git://git.openfabrics.org/~erezz/linux-2.6.git ofed_kernel
 
Thanks,
Erez

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Why do we need RHAS4 up2 & up3 on kernel_addons?

[Erez Zilber]

Vlad,

I saw that you removed RHAS4 up2 & up3 from kernel backports. I think
that you can also delete them from kernel addons.

Erez
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] [PATCH] IB/iser: renamed backport patches & deleted unnecessary patches

[Erez Zilber]

Vlad,

I renamed some of the iSCSI/iSER backport patches and deleted some
unnecessary patches.

Please pull from git://git.openfabrics.org/~erezz/linux-2.6.git ofed_kernel

Thanks,
Erez
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] [PATCH] IB/iser: update open-iscsi kernel code to release 2.0-865.15

[Erez Zilber]

Vlad,

I've updated open-iscsi kernel code to release 2.0-865.15.

Please pull from git://git.openfabrics.org/~erezz/linux-2.6.git ofed_kernel

Thanks,
Erez
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Re: Merging ofed_kernel with 2.6.24-rc5

[Erez Zilber]

Vladimir Sokolovsky wrote:
>
> Hi Erez,
> I am trying to merge 2.6.24-rc5 into ofed_kernel git tree.
> The following patch:
> iscsi-sync-kernel-code-with-release-2.0-865.15.patch is broken after
> the merge.
>
> To reproduce: clone ~vlad/ofed_kernel_test.git ofatest
>

I don't see the ofatest branch on this git tree.

> Now at patch ipoib_selector_updated.patch
>   
> /tmp/build-ofed_kernel-c26987/ofed_kernel-2.6.11/kernel_patches/fixes/iscsi-sync-kernel-code-with-release-2.0-865.15.patch
> /usr/bin/quilt --quiltrc 
> /tmp/build-ofed_kernel-c26987/ofed_kernel-2.6.11/patches/quiltrc import 
> /tmp/build-ofed_kernel-c26987/ofed_kernel-2.6.11/kernel_patches/fixes/iscsi-sync-kernel-code-with-release-2.0-865.15.patch
> Importing patch 
> /tmp/build-ofed_kernel-c26987/ofed_kernel-2.6.11/kernel_patches/fixes/iscsi-sync-kernel-code-with-release-2.0-865.15.patch
>  (stored as iscsi-sync-kernel-code-with-release-2.0-865.15.patch)
> /usr/bin/quilt --quiltrc 
> /tmp/build-ofed_kernel-c26987/ofed_kernel-2.6.11/patches/quiltrc push 
> patches/iscsi-sync-kernel-code-with-release-2.0-865.15.patch
> Applying patch iscsi-sync-kernel-code-with-release-2.0-865.15.patch
> patching file drivers/scsi/iscsi_tcp.c
> Hunk #3 FAILED at 200.
> Hunk #10 FAILED at 418.
>
>   

Are you trying to apply this patch on 2.6.11 or am I missing something?

Erez
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Re: Merging ofed_kernel with 2.6.24-rc5

[Erez Zilber]

> Sorry, I meant ~vlad/ofed_kernel_test.git ofed_kernel branch.
>
> ./ofed_scripts/ofed_makedist.sh - applies patches from
> kernel_patches/fixes
> first and then patches from kernel_patches/backports following kernel
> version.
>
> Your patch is under kernel_patches/fixes and it fails on any kernel.
>
> - Vladimir
>

I see that the script fails on something with IPoIB:

patching file drivers/infiniband/ulp/ipoib/ipoib_main.c
Hunk #2 succeeded at 783 (offset 3 lines).
Hunk #3 succeeded at 918 (offset 3 lines).
Hunk #4 succeeded at 987 (offset 3 lines).
   
/tmp/build-ofed_kernel-d30977/ofed_kernel-2.6.11/kernel_patches/fixes/ipoib_0040_checksum-offload.patch
patching file drivers/infiniband/ulp/ipoib/ipoib.h
patching file drivers/infiniband/ulp/ipoib/ipoib_cm.c
patching file drivers/infiniband/ulp/ipoib/ipoib_ib.c
patching file drivers/infiniband/ulp/ipoib/ipoib_main.c
Hunk #1 succeeded at 1123 (offset 3 lines).
Hunk #2 succeeded at 1184 (offset 3 lines).
   
/tmp/build-ofed_kernel-d30977/ofed_kernel-2.6.11/kernel_patches/fixes/ipoib_0050_Add-LSO-support.patch
patching file drivers/infiniband/ulp/ipoib/ipoib.h
patching file drivers/infiniband/ulp/ipoib/ipoib_cm.c
patching file drivers/infiniband/ulp/ipoib/ipoib_ib.c
patching file drivers/infiniband/ulp/ipoib/ipoib_main.c
Hunk #1 succeeded at 716 (offset 3 lines).
Hunk #2 succeeded at 1206 (offset 3 lines).
   
/tmp/build-ofed_kernel-d30977/ofed_kernel-2.6.11/kernel_patches/fixes/ipoib_0060_ethtool-support.patch
patching file drivers/infiniband/ulp/ipoib/Makefile
patching file drivers/infiniband/ulp/ipoib/ipoib.h
patching file drivers/infiniband/ulp/ipoib/ipoib_etool.c
patching file drivers/infiniband/ulp/ipoib/ipoib_main.c
Hunk #1 succeeded at 974 (offset 3 lines).
   
/tmp/build-ofed_kernel-d30977/ofed_kernel-2.6.11/kernel_patches/fixes/ipoib_0070_modiy_cq_params.patch
patching file drivers/infiniband/ulp/ipoib/ipoib.h
patching file drivers/infiniband/ulp/ipoib/ipoib_etool.c
   
/tmp/build-ofed_kernel-d30977/ofed_kernel-2.6.11/kernel_patches/fixes/ipoib_0080_broadcast_null.patch
patching file drivers/infiniband/ulp/ipoib/ipoib_main.c
Reversed (or previously applied) patch detected!  Assume -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file
drivers/infiniband/ulp/ipoib/ipoib_main.c.rej
Failed to apply patch:
/tmp/build-ofed_kernel-d30977/ofed_kernel-2.6.11/kernel_patches/fixes/ipoib_0080_broadcast_null.patch
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: Merging ofed_kernel with 2.6.24-rc5

[Erez Zilber]

Please pull from git://git.openfabrics.org/~erezz/ ofed_kernel_test.git
ofed_kernel

It still fails (but not in open-iscsi/iSER patches):

   
/tmp/build-ofed_kernel-NNC630/ofed_kernel-2.6.11/kernel_patches/fixes/mlx4_0140_modify_qp_check.patch
patching file drivers/net/mlx4/qp.c
Reversed (or previously applied) patch detected!  Assume -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file drivers/net/mlx4/qp.c.rej
Failed to apply patch:
/tmp/build-ofed_kernel-NNC630/ofed_kernel-2.6.11/kernel_patches/fixes/mlx4_0140_modify_qp_check.patch

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: Merging ofed_kernel with 2.6.24-rc5

[Erez Zilber]

Vladimir Sokolovsky wrote:
>
> Erez Zilber wrote:
> > Please pull from git://git.openfabrics.org/~erezz/ ofed_kernel_test.git
> > ofed_kernel
> >
> > It still fails (but not in open-iscsi/iSER patches):
> >
> >   
> >
> /tmp/build-ofed_kernel-NNC630/ofed_kernel-2.6.11/kernel_patches/fixes/mlx4_0140_modify_qp_check.patch
> > patching file drivers/net/mlx4/qp.c
> > Reversed (or previously applied) patch detected!  Assume -R? [n]
> > Apply anyway? [n]
> > Skipping patch.
> > 1 out of 1 hunk ignored -- saving rejects to file
> drivers/net/mlx4/qp.c.rej
> > Failed to apply patch:
> >
> /tmp/build-ofed_kernel-NNC630/ofed_kernel-2.6.11/kernel_patches/fixes/mlx4_0140_modify_qp_check.patch
> >
>
> Thanks,
> Now iscsi backport patch for 2.6.18 fails:
>
> Applying patch open-iscsi-tx-hash-fixes.patch
> patching file drivers/scsi/iscsi_tcp.c
> Hunk #1 succeeded at 109 (offset 3 lines).
> Hunk #2 succeeded at 469 (offset 3 lines).
> Hunk #3 succeeded at 649 (offset 3 lines).
> Hunk #4 succeeded at 677 (offset 3 lines).
> Hunk #5 succeeded at 694 (offset 4 lines).
> Hunk #6 succeeded at 748 (offset 4 lines).
> Hunk #7 succeeded at 767 (offset 4 lines).
> Hunk #8 succeeded at 813 (offset 4 lines).
> Hunk #9 succeeded at 887 (offset 4 lines).
> Hunk #10 succeeded at 908 (offset 4 lines).
> Hunk #11 succeeded at 1211 (offset 4 lines).
> Hunk #12 FAILED at 1469.
> Hunk #13 FAILED at 1502.
> Hunk #14 succeeded at 1536 (offset 4 lines).
> Hunk #15 succeeded at 1824 (offset 3 lines).
> Hunk #16 succeeded at 1873 (offset 3 lines).
> Hunk #17 succeeded at 1884 (offset 3 lines).
> 2 out of 17 hunks FAILED -- rejects in file drivers/scsi/iscsi_tcp.c
> patching file drivers/scsi/iscsi_tcp.h
> Patch open-iscsi-tx-hash-fixes.patch does not apply (enforce with -f)
>
Please pull from git://git.openfabrics.org/~erezz/ ofed_kernel_test.git
ofed_kernel

For some reason, there were backport patches for 2.6.18 & 2.6.18_suse10_2.

Erez
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] separating open-iscsi packages

[Erez Zilber]

Vlad,

We would like to separate the open-iscsi userspace package into 2
packages: one for RH4 (open-iscsi-rh4.git) and another one for SLES 10 &
RHEL5 (open-iscsi.git). This will help us solving bug #804. Can you add
this support to install.pl?

Thanks,
Erez

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] New features for OFED 1.4

[Erez Zilber]

Tziporet Koren wrote:
>
> I wish to collect requirements for new features for OFED 1.4
> Please reply with any request you have (features of existing modules,
> new modules etc.)
>
> Thanks,
> Tziporet
>
Tziporet,

Voltaire will add support for stgt (SCSI target). It includes support
for iSCSI over iSER/TCP. For more info about stgt with iSER support:

http://stgt.berlios.de/

https://wiki.openfabrics.org/tiki-index.php?page=ISER-target

Erez
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] separating open-iscsi packages

[Erez Zilber]

Vladimir Sokolovsky wrote:
>
> Erez Zilber wrote:
> > Vlad,
> >
> > We would like to separate the open-iscsi userspace package into 2
> > packages: one for RH4 (open-iscsi-rh4.git) and another one for SLES 10 &
> > RHEL5 (open-iscsi.git). This will help us solving bug #804. Can you add
> > this support to install.pl?
> >
> > Thanks,
> > Erez
> >
>
> Hi Erez,
> I am busy with other tasks.
> If you are going to make these changes, please make sure to update:
>
> 1) build_ofed.sh script (git://git.openfabrics.org/~vlad/ofabuild.git
> ofed_1_3) - get_open_iscsi function.
> 2) install.pl script
> (git://git.openfabrics.org/~vlad/ofed_1_3_scripts.git master)
>
> Regards,
> Vladimir
>

I made the required changes in build_ofed.sh, and was able to build the
OFED package:

./build_ofed.sh -v 1.3-rc1

Now, when I try to build OFED, I get the following error:

[EMAIL PROTECTED] OFED-1.3-rc1]# ./install.pl -c ofed.conf
Unsupported package: dapl

Below is the list of OFED packages that you have chosen
(some may have been added by the installer due to package dependencies):

kernel-ib
ofed-scripts
libibverbs
libibverbs-devel
libibverbs-devel-static
libibverbs-utils
libmthca
libmlx4
mstflint
libibcommon
libibcommon-devel
libibumad
libibumad-devel
opensm-libs
opensm-devel
ibutils
libibmad
libibmad-devel
infiniband-diags
ofed-docs
open-iscsi-generic

Uninstalling the previous version of OFED
Build ofa_kernel RPM
Running rpmbuild --rebuild --define '_topdir /var/tmp/OFED_topdir'
--define 'configure_options   --with-core-mod --with-user_mad-mod
--with-user_access-mod --with-addr_trans-mod --with-mthca-mod
--with-mlx4-mod --with-ipoib-mod --with-iser-mod' --define
'build_kernel_ib 1' --define 'build_kernel_ib_devel 1' --define
'KVERSION 2.6.9-42.ELsmp' --define 'K_SRC
/lib/modules/2.6.9-42.ELsmp/build' --define 'network_dir
/etc/sysconfig/network-scripts' --define '_prefix /usr'
/home/erezz/work/ofed/ofabuild.git/OFED-1.3-rc1/SRPMS/ofa_kernel-1.3-ofed20071224.src.rpm
Install kernel-ib RPM:
Running rpm -iv
/home/erezz/work/ofed/ofabuild.git/OFED-1.3-rc1/RPMS/redhat-release-4AS-5.5/kernel-ib-1.3-2.6.9_42.ELsmp.x86_64.rpm
Build ofed-scripts RPM
Running  rpmbuild --rebuild --define '_topdir /var/tmp/OFED_topdir'
--target x86_64 --define '_prefix /usr' --define '_exec_prefix /usr'
--define '_sysconfdir /etc' --define '_usr /usr'
/home/erezz/work/ofed/ofabuild.git/OFED-1.3-rc1/SRPMS/ofed-scripts-1.3-0.src.rpm
Install ofed-scripts RPM:
Running rpm -iv
/home/erezz/work/ofed/ofabuild.git/OFED-1.3-rc1/RPMS/redhat-release-4AS-5.5/ofed-scripts-1.3-0.x86_64.rpm
Build libibverbs RPM
Running  rpmbuild --rebuild --define '_topdir /var/tmp/OFED_topdir'
--target x86_64 --define '_prefix /usr' --define '_exec_prefix /usr'
--define '_sysconfdir /etc' --define '_usr /usr'
/home/erezz/work/ofed/ofabuild.git/OFED-1.3-rc1/SRPMS/libibverbs-1.1.1-0.1.ofed20071224.src.rpm
Failed to build libibverbs RPM
See /tmp/OFED.18324.logs/libibverbs.rpmbuild.log

Here's libibverbs.rpmbuild.log:

Building target platforms: x86_64
Building for target x86_64
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.519
+ umask 022
+ cd /var/tmp/OFED_topdir/BUILD
+ LANG=C
+ export LANG
+ unset DISPLAY
+ cd /var/tmp/OFED_topdir/BUILD
+ rm -rf libibverbs-1.1.1
+ /usr/bin/gzip -dc
/var/tmp/OFED_topdir/SOURCES/libibverbs-1.1.1-0.1.ofed20071224.tar.gz
+ tar -xf -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd libibverbs-1.1.1
++ /usr/bin/id -u
+ '[' 0 = 0 ']'
+ /bin/chown -Rhf root .
++ /usr/bin/id -u
+ '[' 0 = 0 ']'
+ /bin/chgrp -Rhf root .
+ /bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ exit 0
Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.519
+ umask 022
+ cd /var/tmp/OFED_topdir/BUILD
+ cd libibverbs-1.1.1
+ LANG=C
+ export LANG
+ unset DISPLAY
+ CFLAGS='-O2 -g -pipe -m64'
+ export CFLAGS
+ CXXFLAGS='-O2 -g -pipe -m64'
+ export CXXFLAGS
+ FFLAGS='-O2 -g -pipe -m64'
+ export FFLAGS
++ find . -name config.guess -o -name config.sub
+ ./configure --build=x86_64-redhat-linux-gnu
--host=x86_64-redhat-linux-gnu --target=x86_64-redhat-linux-gnu
--program-prefix= --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin
--sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share
--includedir=/usr/include --libdir=/usr/lib64 --libexecdir=/usr/libexec
--localstatedir=/var --sharedstatedir=/usr/com --mandir=/usr/share/man
--infodir=/usr/share/info
/var/tmp/rpm-tmp.519: line 34: ./configure: No such file or directory
error: Bad exit status from /var/tmp/rpm-tmp.519 (%build)


RPM build errors:
Bad exit status from /var/tmp/rpm-tmp.519 (%build)

What is the problem here?

Thanks,
Erez
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] separating open-iscsi packages

[Erez Zilber]

Vladimir Sokolovsky wrote:
>
> Erez Zilber wrote:
> > Vladimir Sokolovsky wrote:
> >> Erez Zilber wrote:
> >>> Vlad,
> >>>
> >>> We would like to separate the open-iscsi userspace package into 2
> >>> packages: one for RH4 (open-iscsi-rh4.git) and another one for
> SLES 10 &
> >>> RHEL5 (open-iscsi.git). This will help us solving bug #804. Can
> you add
> >>> this support to install.pl?
> >>>
> >>> Thanks,
> >>> Erez
> >>>
> >> Hi Erez,
> >> I am busy with other tasks.
> >> If you are going to make these changes, please make sure to update:
> >>
> >> 1) build_ofed.sh script (git://git.openfabrics.org/~vlad/ofabuild.git
> >> ofed_1_3) - get_open_iscsi function.
> >> 2) install.pl script
> >> (git://git.openfabrics.org/~vlad/ofed_1_3_scripts.git master)
> >>
> >> Regards,
> >> Vladimir
> >>
> >
> > I made the required changes in build_ofed.sh, and was able to build the
> > OFED package:
> >
> > ./build_ofed.sh -v 1.3-rc1
> >
> > Now, when I try to build OFED, I get the following error:
> >
> > [EMAIL PROTECTED] OFED-1.3-rc1]# ./install.pl -c ofed.conf
> > Unsupported package: dapl
> >
> > Below is the list of OFED packages that you have chosen
> > (some may have been added by the installer due to package dependencies):
> >
> > kernel-ib
> > ofed-scripts
> > libibverbs
> > libibverbs-devel
> > libibverbs-devel-static
> > libibverbs-utils
> > libmthca
> > libmlx4
> > mstflint
> > libibcommon
> > libibcommon-devel
> > libibumad
> > libibumad-devel
> > opensm-libs
> > opensm-devel
> > ibutils
> > libibmad
> > libibmad-devel
> > infiniband-diags
> > ofed-docs
> > open-iscsi-generic
> >
> > Uninstalling the previous version of OFED
> > Build ofa_kernel RPM
> > Running rpmbuild --rebuild --define '_topdir /var/tmp/OFED_topdir'
> > --define 'configure_options   --with-core-mod --with-user_mad-mod
> > --with-user_access-mod --with-addr_trans-mod --with-mthca-mod
> > --with-mlx4-mod --with-ipoib-mod --with-iser-mod' --define
> > 'build_kernel_ib 1' --define 'build_kernel_ib_devel 1' --define
> > 'KVERSION 2.6.9-42.ELsmp' --define 'K_SRC
> > /lib/modules/2.6.9-42.ELsmp/build' --define 'network_dir
> > /etc/sysconfig/network-scripts' --define '_prefix /usr'
> >
> /home/erezz/work/ofed/ofabuild.git/OFED-1.3-rc1/SRPMS/ofa_kernel-1.3-ofed20071224.src.rpm
> > Install kernel-ib RPM:
> > Running rpm -iv
> >
> /home/erezz/work/ofed/ofabuild.git/OFED-1.3-rc1/RPMS/redhat-release-4AS-5.5/kernel-ib-1.3-2.6.9_42.ELsmp.x86_64.rpm
> > Build ofed-scripts RPM
> > Running  rpmbuild --rebuild --define '_topdir /var/tmp/OFED_topdir'
> > --target x86_64 --define '_prefix /usr' --define '_exec_prefix /usr'
> > --define '_sysconfdir /etc' --define '_usr /usr'
> >
> /home/erezz/work/ofed/ofabuild.git/OFED-1.3-rc1/SRPMS/ofed-scripts-1.3-0.src.rpm
> > Install ofed-scripts RPM:
> > Running rpm -iv
> >
> /home/erezz/work/ofed/ofabuild.git/OFED-1.3-rc1/RPMS/redhat-release-4AS-5.5/ofed-scripts-1.3-0.x86_64.rpm
> > Build libibverbs RPM
> > Running  rpmbuild --rebuild --define '_topdir /var/tmp/OFED_topdir'
> > --target x86_64 --define '_prefix /usr' --define '_exec_prefix /usr'
> > --define '_sysconfdir /etc' --define '_usr /usr'
> >
> /home/erezz/work/ofed/ofabuild.git/OFED-1.3-rc1/SRPMS/libibverbs-1.1.1-0.1.ofed20071224.src.rpm
> > Failed to build libibverbs RPM
> > See /tmp/OFED.18324.logs/libibverbs.rpmbuild.log
> >
> > Here's libibverbs.rpmbuild.log:
> >
> > Building target platforms: x86_64
> > Building for target x86_64
> > Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.519
> > + umask 022
> > + cd /var/tmp/OFED_topdir/BUILD
> > + LANG=C
> > + export LANG
> > + unset DISPLAY
> > + cd /var/tmp/OFED_topdir/BUILD
> > + rm -rf libibverbs-1.1.1
> > + /usr/bin/gzip -dc
> > /var/tmp/OFED_topdir/SOURCES/libibverbs-1.1.1-0.1.ofed20071224.tar.gz
> > + tar -xf -
> > + STATUS=0
> > + '[' 0 -ne 0 ']'
> > + cd libibverbs-1.1.1
> > ++ /usr/bin/id -u
> > + '[' 0 = 0 ']'
> > + /bin/chown -Rhf root .
> > ++ /usr/bin/id -u
> > + '[' 0 

Re: [ewg] separating open-iscsi packages

[Erez Zilber]

> Vlad,
>
> Please pull the following:
>
> git://git.openfabrics.org/~erezz/ofabuild.git ofed_1_3
> git://git.openfabrics.org/~erezz/ofed_1_3_scripts.git master
> git://git.openfabrics.org/~erezz/linux-2.6-RHAS4-fix.git ofed_kernel
>

I'm still pushing ~erezz/linux-2.6-RHAS4-fix.git, so it may take a few
minutes...

Erez
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] [PATCH] IB/iser: updates for iSER release notes for OFED 1.3

[Erez Zilber]

updates for iSER release notes for OFED 1.3

Signed-off-by: Erez Zilber <[EMAIL PROTECTED]>
---
 iser_release_notes.txt |   36 +---
 1 files changed, 25 insertions(+), 11 deletions(-)

diff --git a/iser_release_notes.txt b/iser_release_notes.txt
index 70786ad..aa1bf7c 100644
--- a/iser_release_notes.txt
+++ b/iser_release_notes.txt
@@ -20,35 +20,49 @@
 
SLES 10
SLES 10 sp1
+   RHAS 4 up4
+   RHAS 4 up5
+   RHAS 4 up6
RHEL 5
+   RHEL 5.1
 
The release has been tested against Voltaire iSCSI over iSER target
-   running in Voltaire's IB/Fibre-Channel router. It was also tested
-   against FalconStor's iSCSI over iSER target (IPStor).
+   running in Voltaire's IB/Fibre-Channel router (SR4G).
 
 * Installation/upgrade of open-iscsi
If iSER is selected to be installed with OFED, open-iscsi will be also
installed (or upgraded if another version of open-iscsi is already
installed).  Installing/upgrading open-iscsi is required for iSER to
-   work properly.
+   work properly. Before installing OFED, please make sure that no version
+   of open-iscsi is installed or add the following key to your ofed.conf
+   file: upgrade_open_iscsi=yes. Using this key will remove any old version
+   of open-iscsi.
 
-* Known issues 
+   If an older version of open-iscsi was installed, it is recommended to
+   delete its records before running open-iscsi. This can easily be done by
+   running the following command (while open-iscsi is stopped):
+
+   rm -rf /etc/iscsi/nodes/* /etc/iscsi/send_targets/*
+
+   Then, open-iscsi may be started, and targets may be discovered by 
running
+   'iscsi_discovery '.
 
-   SCSI command aborts may cause some instabilities
-   
 * iSER links
 
-   WIKI pages
+   Wiki pages
 
-   information on building/configuring/running the open iscsi initiator w.
-   iSER https://wiki.openfabrics.org/tiki-index.php?page=iSER
+   Information on building/configuring/running the open iscsi initiator 
over
+   iSER: https://wiki.openfabrics.org/tiki-index.php?page=iSER
 
IETF pages
 
iSCSI and iSER specifications come out of the IETF IP storage (IPS) work
-   group http://www.ietf.org/html.charters/ips-charter.html.
+   group.
+
+   iSCSI specification:http://www.ietf.org/rfc/rfc3720.txt
+   iSER specification: http://www.ietf.org/rfc/rfc5046.txt
 
-   "ABOUT" page
+   "About" page
 
general and detailed information on iSCSI and iSER 
http://www.voltaire.com/Products/Server_Products/iSER_iSCSI_RDMA
-- 
1.5.3.7


___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] [PATCH] IB/iser: Add iSER fix that will be merged into 2.6.25

[Erez Zilber]

This fix adds a printk before initiating a BUG() when
receiving an unhandled RDMA-CM event.

Signed-off-by: Erez Zilber <[EMAIL PROTECTED]>
---
 ...nformation_about_unhandled_RDMA_CM_events.patch |   33 
 1 files changed, 33 insertions(+), 0 deletions(-)
 create mode 100644 
kernel_patches/fixes/iser_01_Print_information_about_unhandled_RDMA_CM_events.patch

diff --git 
a/kernel_patches/fixes/iser_01_Print_information_about_unhandled_RDMA_CM_events.patch
 
b/kernel_patches/fixes/iser_01_Print_information_about_unhandled_RDMA_CM_events.patch
new file mode 100644
index 000..4b96c8f
--- /dev/null
+++ 
b/kernel_patches/fixes/iser_01_Print_information_about_unhandled_RDMA_CM_events.patch
@@ -0,0 +1,33 @@
+Print information about unhandled RDMA CM events
+
+Some RDMA CM events are not supported or not handled in iSER.
+This patch adds some info (printk) for the user about them.
+
+Signed-off-by: Erez Zilber <[EMAIL PROTECTED]>
+---
+ drivers/infiniband/ulp/iser/iser_verbs.c |6 ++
+ 1 files changed, 2 insertions(+), 4 deletions(-)
+
+diff --git a/drivers/infiniband/ulp/iser/iser_verbs.c 
b/drivers/infiniband/ulp/iser/iser_verbs.c
+index 654a4dc..675d00b 100644
+--- a/drivers/infiniband/ulp/iser/iser_verbs.c
 b/drivers/infiniband/ulp/iser/iser_verbs.c
+@@ -475,13 +475,11 @@ static int iser_cma_handler(struct rdma_cm_id *cma_id, 
struct rdma_cm_event *eve
+   iser_disconnected_handler(cma_id);
+   break;
+   case RDMA_CM_EVENT_DEVICE_REMOVAL:
++  iser_err("Device removal is currently unsupported\n");
+   BUG();
+   break;
+-  case RDMA_CM_EVENT_CONNECT_RESPONSE:
+-  BUG();
+-  break;
+-  case RDMA_CM_EVENT_CONNECT_REQUEST:
+   default:
++  iser_err("Unexpected RDMA CM event (%d)\n", event->event);
+   break;
+   }
+   return ret;
+-- 
+1.5.3.7
+
-- 
1.5.3.7


___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] [ANNOUNCE] open iSCSI over iSER target RPM is available

[Erez Zilber]

stgt (SCSI target) is an open-source framework for storage target
drivers. It supports iSCSI over iSER among other storage target drivers.

Voltaire added a git tree for stgt that will be added to OFED 1.4:
http://www2.openfabrics.org/git/?p=~dorons/tgt.git;a=summary

Until OFED 1.4 gets released, it is possible to install the stgt RPM on
top of OFED 1.3. For more details about how to install and use stgt,
please refer to https://wiki.openfabrics.org/tiki-index.php?page=ISER-target

Some performance numbers that were measured by OSC (using SDR cards):

* READ: 920 MB/sec
* WRITE: 850 MB/sec

We hope to have DDR measurements numbers soon.

-- 



Erez Zilber | 972-9-971-7689

Software Engineer, Storage Solutions

Voltaire – _The Grid Backbone_

www.voltaire.com <http://www.voltaire.com/>
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: [ofa-general] [ANNOUNCE] open iSCSI over iSER target RPMis available

[Erez Zilber]

> > * READ: 920 MB/sec
> > * WRITE: 850 MB/sec
>
> Not getting anything even remotely close to this.  Are there more
> details on configuration somewhere?  I followed the web page as indicated.
>

Are you running iSCSI over TCP or iSCSI over iSER (over InfiniBand)? Our
results are with iSER.

Erez
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Re: [Stgt-devel] [ANNOUNCE] open iSCSI over iSER target RPM is available

[Erez Zilber]

Bart Van Assche wrote:
> On Feb 5, 2008 3:41 PM, Erez Zilber <[EMAIL PROTECTED]> wrote:
>   
>> stgt (SCSI target) is an open-source framework for storage target
>> drivers. It supports iSCSI over iSER among other storage target drivers.
>>
>> Voltaire added a git tree for stgt that will be added to OFED 1.4:
>> http://www2.openfabrics.org/git/?p=~dorons/tgt.git;a=summary
>>
>> Until OFED 1.4 gets released, it is possible to install the stgt RPM on
>> top of OFED 1.3. For more details about how to install and use stgt,
>> please refer to https://wiki.openfabrics.org/tiki-index.php?page=ISER-target
>>
>> Some performance numbers that were measured by OSC (using SDR cards):
>>
>> * READ: 920 MB/sec
>> * WRITE: 850 MB/sec
>>
>> We hope to have DDR measurements numbers soon.
>> 
>
> Hello Erez,
>
> Can you please post more information about how these numbers were
> obtained (test program and configuration parameters) ?
>
> Bart Van Assche.
>   

I will post more info. As mentioned above, I still didn't have a chance
to run performance tests myself. The numbers are taken from measurements
done in OSC by Pete Wyckoff.

Anyway, after I run the performance tests (also on DDR cards), I will
post instructions in the wiki page.

Erez
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [Stgt-devel] [ewg] Re: [ofa-general] [ANNOUNCE] open iSCSI over iSER target RPMis available

[Erez Zilber]

Joe Landman wrote:
>
> Erez Zilber wrote:
> >>> * READ: 920 MB/sec
> >>> * WRITE: 850 MB/sec
> >> Not getting anything even remotely close to this.  Are there more
> >> details on configuration somewhere?  I followed the web page as
> indicated.
> >>
> >
> > Are you running iSCSI over TCP or iSCSI over iSER (over InfiniBand)? Our
> > results are with iSER.
>
> I followed the instructions on the web pages that were pointed to for
> iSER.  Are there updated pages?
>

For the initiator side, you can see the documentation that comes with
OFED. For the target side, use the wiki page (updated it only last week):

https://wiki.openfabrics.org/tiki-index.php?page=ISER-target

I saw that you were asking about a RPM. There are RPMs for SuSE & RedHat
on the wiki page. These RPMs will be included in OFED 1.4.

Erez

>   Is there a way to tell whether or not
> the RDMA path is being used?
>

Yes - on the initiator side, do the following:

seed1:~ # iscsiadm -m session
iser: [1] 192.168.10.63:3260,1 iqn.2001-04.com.noni-seed1

You can see that iSER is used.

On the target side, do the following:

noni:~ # tgtadm --lld iscsi --op show --mode target
Target 1: iqn.2001-04.com.noni-seed1
System information:
Driver: iscsi
Status: running
I_T nexus information:
I_T nexus: 1
Initiator: iqn.seed1
Connection: 0
RDMA IP Address: 192.168.10.81 <-- "RDMA IP Address"
means that iSER is used
LUN information:
LUN: 0
Type: controller
SCSI ID: deadbeaf1:0
SCSI SN: beaf10
Size: 0
Online: Yes
Poweron/Reset: Yes
Removable media: No
Backing store: No backing store
LUN: 1
Type: disk
SCSI ID: deadbeaf1:1
SCSI SN: beaf11
Size: 82G
Online: Yes
Poweron/Reset: No
Removable media: No
Backing store: /dev/sds
Account information:
ACL information:
ALL

Erez
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] OFED 1.3 RC4 release is available

[Erez Zilber]

Moni Shoua wrote:
> Tziporet Koren wrote:
>   
>> Hi, OFED 1.3 RC3 release is available on
>> http://www.openfabrics.org/builds/ofed-1.3/release/OFED-1.3-rc4.tgz
>> 
>>
>> To get BUILD_ID run ofed_info
>> Please report any issues in bugzilla https://bugs.openfabrics.org/ The
>> RC5 (Gold) release is expected on February 18
>>
>> Tziporet & Vlad
>> 
>> 
> Hi,
> Is it possible to get a list of changes (taken from git log) with each RC?
> This could be very helpful for testers who want to focus their efforts.
>
>   
Also, putting a tag in ofed_1_3/linux-2.6.git for each RC would help. I
see that there were tags for older RCs, but not for rc4. Can you fix
that for rc5?

Thanks,
Erez
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] [PATCH] Set openibd service to stop before iscsi service

[Erez Zilber]

Vladimir Sokolovsky wrote:
> Doron Shoham wrote:
>> Vladimir Sokolovsky wrote:
>>> Doron Shoham wrote:
>>>>  iscsi service should start after openibd service.
>>>>  iscsi service should stop before openibd service.
>>>>
>>>> Signed-off-by: Doron Shoham <[EMAIL PROTECTED]>
>>>> ---
>>> Hi Doron,
>>> Why can't you just put in the /etc/init.d/iscsi:
>>>
>>> # chkconfig: 2345 16 84
>>
>> Why is openibd's start 15 and stop 85?
>> will it always be correct?
> 
> Because the network start is 10 and stop is 90.
> This is correct for now...
> 
>>
>>> And in the /etc/init.d/open-iscsi:
>>> Required-Start: openibd
>>>
>>> And then update ofa_kernel.spec to set
>>> Required-Stop: open-iscsi
>>> In case that iser was selected and OS is SuSE.
>>
>> You are right.
>> I'll do it that way.
>>
>>> This will change about 5 lines of code instead of about 150 lines of
>>> your patch.
>>>
>>> Regards,
>>> Vladimir
>>
>> I'll make a new patch.
>>
>> Thanks,
>> Doron
>>
> 
> Tell me if you need help with ofa_kernel.spec.
> 
> 

open-iscsi depends on the openibd service.
If iSER is selected and the OS is SuSE, edit the openibd
init script and add open-iscsi to its Required-Stop.

Signed-off-by: Doron Shoham <[EMAIL PROTECTED]>
Signed-off-by: Erez Zilber <[EMAIL PROTECTED]>
---
 ofed_scripts/ofa_kernel.spec |   12 +---
 1 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/ofed_scripts/ofa_kernel.spec b/ofed_scripts/ofa_kernel.spec
index 954dd0c..eed2484 100755
--- a/ofed_scripts/ofa_kernel.spec
+++ b/ofed_scripts/ofa_kernel.spec
@@ -428,12 +428,18 @@ perl -i -ne 'if ([EMAIL PROTECTED]/bin/bash@) {
 fi
 
 if [ -f /etc/SuSE-release ]; then
-perl -i -ne 'if ([EMAIL PROTECTED]/bin/bash@) {
+local_fs='$local_fs'
+network='$network'
+openiscsi=''
+%if %{build_iser}
+openiscsi='open-iscsi'
+%endif
+perl -i -ne "if ([EMAIL PROTECTED]/bin/bash@) {
 print [EMAIL PROTECTED]/bin/bash
 ### BEGIN INIT INFO
 # Provides:   openibd
 # Required-Start: $local_fs $network
-# Required-Stop: opensmd
+# Required-Stop: opensmd $openiscsi
 # Default-Start:  2 3 5
 # Default-Stop: 0 1 2 6
 # Description:Activates/Deactivates InfiniBand Driver to \
@@ -442,7 +448,7 @@ if [ -f /etc/SuSE-release ]; then
 @;
  } else {
  print;
- }' /etc/init.d/openibd
+ }" /etc/init.d/openibd
 
 if ! ( /sbin/insserv openibd > /dev/null 2>&1 ); then
 true
-- 
1.5.3.8

Vlad,

I've also made a change in open-iscsi's init script, so it will start after 
openibd and stop before openibd. With this, I think that the solution is 
complete.

Erez

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] [PATCH] Set openibd service to stop before iscsi service

[Erez Zilber]

>
> Vlad,
>
> I've also made a change in open-iscsi's init script, so it will start
> after openibd and stop before openibd. With this, I think that the
> solution is complete.
>
> Erez
>
Vlad,

Will you be able to take this patch in time for RC5?

Thanks,
Erez
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: cannot install SCST with SRP support

[Erez Zilber]

Vu,

We were able to build and run SCST on SLES 10. Now, when I try to build
it for 2.6.24, I get errors:

onion:/home/erezz/work/tmp/scst-srpt/scst # patch -p0 <
../srpt_inc/scst_r245.patch
patching file include/scsi_tgt.h
patching file src/scst_targ.c
onion:/home/erezz/work/tmp/scst-srpt/scst # make
cd src && make all
make[1]: Entering directory `/home/erezz/work/tmp/scst-srpt/scst/src'
make -C /lib/modules/2.6.24-smp/build
SUBDIRS=/home/erezz/work/tmp/scst-srpt/scst/src BUILD_DEV=m
make[2]: Entering directory `/usr/src/linux-2.6.24'
LD /home/erezz/work/tmp/scst-srpt/scst/src/built-in.o
CC [M] /home/erezz/work/tmp/scst-srpt/scst/src/scst_main.o
/home/erezz/work/tmp/scst-srpt/scst/src/scst_main.c:50:2: warning:
#warning Patch scst_exec_req_fifo-.patch was not applied
on your kernel and STRICT_SERIALIZING isn't defined. Pass-through dev
handlers will not be supported.
/home/erezz/work/tmp/scst-srpt/scst/src/scst_main.c: In function
‘exit_scst’:
/home/erezz/work/tmp/scst-srpt/scst/src/scst_main.c:1622: error:
implicit declaration of function ‘DECLARE_MUTEX_LOCKED’
/home/erezz/work/tmp/scst-srpt/scst/src/scst_main.c:1622: error: ‘shm’
undeclared (first use in this function)
/home/erezz/work/tmp/scst-srpt/scst/src/scst_main.c:1622: error: (Each
undeclared identifier is reported only once
/home/erezz/work/tmp/scst-srpt/scst/src/scst_main.c:1622: error: for
each function it appears in.)
make[3]: *** [/home/erezz/work/tmp/scst-srpt/scst/src/scst_main.o] Error 1
make[2]: *** [_module_/home/erezz/work/tmp/scst-srpt/scst/src] Error 2
make[2]: Leaving directory `/usr/src/linux-2.6.24'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/home/erezz/work/tmp/scst-srpt/scst/src'
make: *** [all] Error 2

What is the problem here?

Thanks,
Erez
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] OFED March 24 meeting summary on OFED 1.4 plans

[Erez Zilber]

>
> *OFED 1.4:*
> 1. Kernel base: since we target 1.4 release to Sep we target the
> kernel base to be 2.6.27
> This is a good target, but we may need to stay with 2.6.26 if the
> kernel progress will not be aligned.
>
> 2. Suggestions for new features:
>
> * NFS-RDMA
> * Verbs: Reliable Multicast (to be presented at Sonoma)
> * SDP - Zero copy (There was a question on IPv6 support - seems no
>   one interested for now)
> * IPoIB - continue with performance enhancements
> * Xsigo new virtual NIC
> * New vendor HW support - non was reported so far (IBM and Chelsio
>   - do you have something?)
> * OpenSM:
>   o Incremental routing
>   o Temporary SA DB - to answer queries and a heavy sweep is done
>   o APM - disjoint paths (?)
>   o MKey manager (?)
>   o Sasha to send more management features
> * MPI:
>   o Open MPI 1.3
>   o APM support in MPI
>   o mvapich ???
> * uDAPl
>   o Extensions for new APIs (like XRC) - ?
>   o uDAPL provider for interop between Windows & Linux
>   o 1.2 and 2.0 will stay
>

As I wrote in an earlier discussion (~2 months ago), we plan to add tgt
(SCSI target) with iSCSI over iSER (and TCP of course) support. The git
tree for tgt already exists on the ofa server.

Erez

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] [PATCH]: Set open-iscsi for auto-startup when installing OFED

[Erez Zilber]

Vlad,


Please pull from git://git.openfabrics.org/~erezz/ofed_1_3_scripts.git.
We would like to include this patch in OFED 1.3.1.


Thanks,

-- 



Erez Zilber | 972-9-971-7689

Software Engineer, Storage Solutions

Voltaire – _The Grid Backbone_

__

www.voltaire.com <http://www.voltaire.com/>



___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Re: Removing the transport module before iscsid

[Erez Zilber]

Mike Christie wrote:
> Erez Zilber wrote:
>   
>> Mike Christie wrote:
>>     
>>> Erez Zilber wrote:
>>>   
>>>   
>>>> Mike,
>>>>
>>>> We're trying to solve a problem, but first the motivation: a user may
>>>> want to stop the InfiniBand modules (/etc/init.d/openibd stop) while
>>>> open-iscsi is running. In order to do that, we must remove ib_iser.
>>>>
>>>> Now, the question: is it ok to modprobe -r ib_iser (or iscsi_tcp) before
>>>> 
>>>> 
>>> It is and it isn't :)
>>>
>>>   
>>>   
>>>> stopping iscsid? From what I see in the init.d scripts in open-iscsi, we
>>>> kill iscsid first. Is there a reason for that?
>>>>
>>>> 
>>>> 
>>> We kill iscsid first because it has a ref to scsi_transport_iscsi (load 
>>> that module and run iscsid and then do a lsmod). So if you ran iscsid, 
>>> then just modprobe -r ib_iser, it would leave scsi_transport_iscsi loaded.
>>>
>>>   
>>>   
>> If I run /etc/init.d/openibd stop, it will (with a patch that I'm going
>> to submit) call iscsi_conn_failure for all iSER connections, and then
>> remove ib_iser. scsi_transport_iscsi will be removed later when
>> 
>
>
> This does not sound right or even possible with current kernels. If a 
> session is runing and scsi_devices exists for it and if a user has a 
> device open then there are references to the ib_iser module.
>
> If the user does a close then it needs the scsi_host_tempalte that was 
> allocated in the ib_iser module. For libiscsi/scsi_transport_iscsi there 
> is similar problems with the those modules accessing the iscsi_transport 
> struct allocated in the module.
>
> The thing is that scsi-ml should be incrementing the ib_iser refcount if 
> a device is open. And open-iscsi should be incrementing the ib_iser 
> refctoun if there is a session. So you should not be able to remove the 
> ib_iser module if there are connections.
>
>   

I'm adding Vlad & openfabrics-ewg to this discussion, as it seems
relevant for OFED.

Mike - you're right. I guess that I missed something here. My patch
(http://groups.google.com/group/open-iscsi/browse_frm/thread/2c99cce2956ac4d7)
only allows the removal of the HCA driver (e.g. ib_mthca). This is
better than the BUG() call that we had there until now.

The motivation was to allow users to stop openibd even while open-iscsi
is running. The problem is that even after removing the HCA driver,
ib_iser is still referenced and cannot be unloaded (unless
/etc/init.d/open-iscsi stop is called). Therefore, most of the IB stack
cannot be unloaded (rdma_cm, ib_cm, ib_core etc).

Here's my suggestion: in addition to this patch (which is good if a user
decides to remove only ib_mthca), we should add some code to
/etc/init.d/openibd that will check if open-iscsi is loaded and if there
are iSER sessions. If yes, openibd will not stop until the user logs out
from the iSER sessions. When there are no more iSER sessions, openibd
will stop and will also remove ib_iser which is required for the removal
of other IB modules. Mike - the removal of ib_iser will require the
other patch that we talked about (deleting the iSER transport entry from
the transport list).

If everyone's ok with this, I will make the required changes and send a
patch.

Erez
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] [PATCH 0/2] IB/iser: Do not stop openibd while modules are used by open-iscsi

[Erez Zilber]

The following series of patches fixes a bug that occurs when a user tries to 
stop openibd while open-iscsi is running and there are active iSER sessions.

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] [PATCH 1/2] IB/iser: Logout from open-iscsi over iSER sessions before stopping openibd

[Erez Zilber]

Some users may try to stop openibd while open-iscsi over iSER is
running. When stopping openibd, the script should check if there
are open-iscsi sessions that use the iSER transport and ask the
user to logout from these sessions before shutting down openibd.

Signed-off-by: Erez Zilber <[EMAIL PROTECTED]>
---
 ofed_scripts/openibd |   13 +
 1 files changed, 13 insertions(+), 0 deletions(-)

diff --git a/ofed_scripts/openibd b/ofed_scripts/openibd
index 4e317a7..0e1325d 100755
--- a/ofed_scripts/openibd
+++ b/ofed_scripts/openibd
@@ -1190,6 +1190,19 @@ stop()
 fi
 done
 
+# Check if open-iscsi is running and if there are open iSER sessions
+if [ $(pidof iscsid | wc -w) -gt 0 ]; then
+iser_session_cnt=$(iscsiadm -m session 2>&1 | grep -c "^iser")
+
+if [ $iser_session_cnt -gt 0 ]; then
+echo
+echo "Please logout from all open-iscsi over iSER 
sessions"
+echo "Then run \"$0 $ACTION\""
+echo
+exit 1
+fi
+fi
+
 # Stop Gen1 modules if they are UP after uninstall
 if is_module ib_tavor; then
 stop_gen1
-- 
1.5.4.4


___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] [PATCH 2/2] IB/iser: Ask the user to stop open-iscsi before stopping openibd on RH4

[Erez Zilber]

In RedHat 4, some OFED kernel modules (including open-iscsi modules)
use symbols that are encapsulated in ib_core (e.g. kfifo). ib_core
may not be unloaded before open-iscsi is unloaded. Therefore, disconnecting
from open-iscsi over iSER sessions is not suffiecient if the user tries to
stop openibd. The user must be prompted to stop open-iscsi before stopping
openibd.

Signed-off-by: Erez Zilber <[EMAIL PROTECTED]>
---
 ofed_scripts/ofa_kernel.spec |7 +++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/ofed_scripts/ofa_kernel.spec b/ofed_scripts/ofa_kernel.spec
index eed2484..01411e7 100755
--- a/ofed_scripts/ofa_kernel.spec
+++ b/ofed_scripts/ofa_kernel.spec
@@ -455,6 +455,13 @@ if [ -f /etc/SuSE-release ]; then
 fi
 fi
 
+# If it's RH4, open-iscsi must be stopped before openibd
+if [[ -f /etc/redhat-release && $(grep -c "Red Hat Enterprise Linux AS release 
4" /etc/redhat-release) -eq 1 ]]; then
+cat /etc/init.d/openibd | sed -e 's/Please logout from all open-iscsi over 
iSER sessions/Please stop open-iscsi: \/etc\/init.d\/iscsi stop/' > 
/etc/init.d/openibd.$$
+mv /etc/init.d/openibd.$$ /etc/init.d/openibd
+chmod +x /etc/init.d/openibd
+fi
+
 %if %{build_kernel_ib}
 echo >> %{IB_CONF_DIR}/openib.conf
 echo "# Load UCM module" >> %{IB_CONF_DIR}/openib.conf
-- 
1.5.4.4


___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Re: [ofa-general] resolve conflict between OFED 1.3 and 2.6.18 with ISCSI

[Erez Zilber]

Brian J. Murrell wrote:

> I have run into a conflict trying to build a matching kernel and
> kernel-ib pair for OFED 1.3 and RHEL5's 2.6.18 kernel (although I
> suspect this will apply to generally any kernel of the same vintage).
>   

General comment - in the future, I suggest that you send OFED related
e-mails also to the EWG list and to me (I maintain iSER in OFED &
kernel.org).

> The problem is that OFED 1.3 appears to include/provide some iSCSI
> support, such as drivers/scsi/scsi_transport_iscsi.c for one example
> which is the "SCSI_ISCSI_ATTRS" kernel attribute.  The 2.6.18 RHEL5
> kernel can provide the same capability if one decides to configure it
> into the kernel build.
>   

OFED 1.3 provides open-iscsi 2.0-865.15 (userspace & kernel). This
version is newer than the version that is shipped with RHEL5. It also
has full iSER support.

> So the question arises, do I want to have the kernel provide it or have
> kernel-ib provide it.  It's not quite that easy though.
>
> If I disable it in the kernel, I also disable dependent drivers such as
> SCSI_QLA_ISCSI (QLogic ISP4XXX host adapter family support).  In order
> to disable it in the kernel-ib build I need to disable "iser" support
> with "--without-iser-mod", which seems a bit like throwing the baby out
> with the bathwater.
>   

Yeah, it is an open-iscsi transport, so you must have open-iscsi in
order to use this driver. With OFED 1.3, qla4xxx is not included. We
only included the TCP & iSER transports.

> The reason I need to disable this in one place or another is that if my
> kernel RPM is providing scsi_transport_iscsi.ko and so is kernel-ib, I
> get an RPM conflict as the two files are in the same location in
> the /lib/modules/$(uname -r) tree.
>   

Of course. You can't have open-iscsi modules twice.

> So how to resolve?  I don't think it can be resolved easily currently.
> I think the ofa_kernel build system needs to be more intelligent about
> what's selected in the kernel and not providing duplicate capabilities.
> IOW, I should be able to select CONFIG_SCSI_ISCSI_ATTRS=m in my
> kernel .config and CONFIG_INFINIBAND_ISER=m in my ofa_kernel
> configuration and ofa_kernel should figure out if it needs to provide
> SCSI_ISCSI_ATTRS (i.e. build scsi_transport_iscsi.ko) or whether the
> kernel is configured to and will be providing it.
>   

OFED is shipped with its own version of open-iscsi because I don't want
to support multiple versions of open-iscsi (each distro has its own
version of open-iscsi). Also, having a newer version of open-iscsi
(which we have in OFED) fixes many bugs and adds new features (which is
good).

Is qla4xxx the only problem that you have with open-iscsi in OFED?

Erez

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Re: [ofa-general] resolve conflict between OFED 1.3 and 2.6.18 with ISCSI

[Erez Zilber]

>> Is qla4xxx the only problem that you have with open-iscsi in OFED?
>> 
>
> Looking through the kernel Kconfig files, it does appear that
> SCSI_QLA_ISCSI is the only driver needing SCSI_ISCSI_ATTRS that isn't in
> the OFED 1.3 release.
>   

I'm not sure if there's a real demand for this transport for OFED users,
is there? Adding qla4xxx will require backport patches for all supported
distros, and we don't have the HW to test it. Therefore, unless it's
really important for enough OFED users, I don't think that we should add it.

BTW - I don't mind if other people add the required code to OFED 1.4 for
qla4xxx support.

Erez

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Re: [ofa-general] resolve conflict between OFED 1.3 and 2.6.18 with ISCSI

[Erez Zilber]

Brian J. Murrell wrote:

> On Mon, 2008-04-14 at 16:50 +0300, Erez Zilber wrote:
>   
>> I'm not sure if there's a real demand for this transport for OFED users,
>> is there?
>> 
>
> Maybe I'm not seeing the bigger picture but it seems pretty orthogonal
> to me.  Does using OFED 1.3 preclude using a qla4xxx host adapter?  IOW,
> is there anything inherent in using OFED 1.3 as the networking fabric on
> a (say) storage server that uses a QLogic ISP4XXX adapter to access it's
> storage?
>   

In theory, I don't think that we cannot add qla4xxx to open-iscsi in
OFED 1.3. The only problem is that someone actually has to do that. BTW
- you can't use open-iscsi from OFED 1.3 with qla4xxx from the distro
kernel because they may not work together.

>   
>> Adding qla4xxx will require backport patches for all supported
>> distros, and we don't have the HW to test it.
>> 
>
> Yeah, the old conundrum.
>
>   
>> Therefore, unless it's
>> really important for enough OFED users, I don't think that we should add it.
>> 
>
> Well, given the alternative that it's completely unbuildable in the
> kernel when you choose OFED's iscsi options, is including the qla4xxx in
> the OFED distribution, even untested so bad?
>   

I don't mind, but I'm not sure if Voltaire will do that. We need to make
a decision on that.

>   
>> BTW - I don't mind if other people add the required code to OFED 1.4 for
>> qla4xxx support.
>> 
>
> ~sigh~  Yeah.
>
> I wonder how many (if any) of our userbase we are going to upset if we
> cease providing the qla4xxx driver in our kernels.  On the other hand, I
> wonder how many we'd upset by not providing iSER and the newer
> open-iscsi modules.
>
>   

Yeah, I understand. Let me get back to you on this issue.

Erez

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] Re: [ofa-general] resolve conflict between OFED 1.3 and 2.6.18 with ISCSI

[Erez Zilber]

> >  
> >> BTW - I don't mind if other people add the required code to OFED
> 1.4 for
> >> qla4xxx support.
> >>
> >
> > ~sigh~  Yeah.
> >
> > I wonder how many (if any) of our userbase we are going to upset if we
> > cease providing the qla4xxx driver in our kernels.  On the other hand, I
> > wonder how many we'd upset by not providing iSER and the newer
> > open-iscsi modules.
> >
> >  
>
> Yeah, I understand. Let me get back to you on this issue.
>

Brian,

Voltaire will not be able to add qla4xxx support to open-iscsi in OFED
1.4. I understand that this may be important for some people, so if you
(or anyone else) wants to add it, we can help with some info about
open-iscsi and its backports & scripts in OFED (but we can't do the
backports and testing ourselves).

Erez
___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] [PATCH 2/2] IB/iser: Ask the user to stop open-iscsi before stopping openibd on RH4

[Erez Zilber]

Vladimir Sokolovsky wrote:

> Erez Zilber wrote:
> > In RedHat 4, some OFED kernel modules (including open-iscsi modules)
> > use symbols that are encapsulated in ib_core (e.g. kfifo). ib_core
> > may not be unloaded before open-iscsi is unloaded. Therefore,
> disconnecting
> > from open-iscsi over iSER sessions is not suffiecient if the user
> tries to
> > stop openibd. The user must be prompted to stop open-iscsi before
> stopping
> > openibd.
> >
> > Signed-off-by: Erez Zilber <[EMAIL PROTECTED]>
> > ---
> >  ofed_scripts/ofa_kernel.spec |7 +++
> >  1 files changed, 7 insertions(+), 0 deletions(-)
> >
> > diff --git a/ofed_scripts/ofa_kernel.spec b/ofed_scripts/ofa_kernel.spec
> > index eed2484..01411e7 100755
> > --- a/ofed_scripts/ofa_kernel.spec
> > +++ b/ofed_scripts/ofa_kernel.spec
> > @@ -455,6 +455,13 @@ if [ -f /etc/SuSE-release ]; then
> >  fi
> >  fi
> > 
> > +# If it's RH4, open-iscsi must be stopped before openibd
> > +if [[ -f /etc/redhat-release && $(grep -c "Red Hat Enterprise Linux
> AS release 4" /etc/redhat-release) -eq 1 ]]; then
> > +cat /etc/init.d/openibd | sed -e 's/Please logout from all
> open-iscsi over iSER sessions/Please stop open-iscsi:
> \/etc\/init.d\/iscsi stop/' > /etc/init.d/openibd.$$
> > +mv /etc/init.d/openibd.$$ /etc/init.d/openibd
> > +chmod +x /etc/init.d/openibd
> > +fi
> > +
> >  %if %{build_kernel_ib}
> >  echo >> %{IB_CONF_DIR}/openib.conf
> >  echo "# Load UCM module" >> %{IB_CONF_DIR}/openib.conf
>
> Erez,
> I changed your patch with the patch below:
> See, if this is OK.
>
>  From b0409a7d6a1e8f2cfc1de69994420622c6d70b50 Mon Sep 17 00:00:00 2001
> From: Vladimir Sokolovsky <[EMAIL PROTECTED]>
> Date: Mon, 21 Apr 2008 11:59:14 +0300
> Subject: [PATCH] In RedHat 4, some OFED kernel modules (including
> open-iscsi modules)
> use symbols that are encapsulated in ib_core (e.g. kfifo). ib_core
> may not be unloaded before open-iscsi is unloaded. Therefore,
> disconnecting
> from open-iscsi over iSER sessions is not suffiecient if the user tries to
> stop openibd. The user must be prompted to stop open-iscsi before stopping
> openibd.
>
> Signed-off-by: Erez Zilber <[EMAIL PROTECTED]>
> Signed-off-by: Vladimir Sokolovsky <[EMAIL PROTECTED]>
> ---
>   ofed_scripts/openibd |7 ++-
>   1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/ofed_scripts/openibd b/ofed_scripts/openibd
> index 0e1325d..8272def 100755
> --- a/ofed_scripts/openibd
> +++ b/ofed_scripts/openibd
> @@ -1196,7 +1196,12 @@ stop()
>
>   if [ $iser_session_cnt -gt 0 ]; then
>   echo
> -echo "Please logout from all open-iscsi over
> iSER sessions"
> +# If it's RH4, open-iscsi must be stopped
> before openibd
> +if [[ -f /etc/redhat-release && $(grep -c
> "Red Hat Enterprise Linux AS release 4" /etc/redhat-release) -eq 1 ]];
> then
> +echo "Please stop open-iscsi:
> /etc/init.d/iscsi stop"
> +else
> +echo "Please logout from all open-iscsi
> over iSER sessions"
> +fi
>   echo "Then run \"$0 $ACTION\""
>   echo
>   exit 1
> --
> 1.5.2.5
>
>
I'm ok with your fix.

Erez

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Re: [ofa-general] [PATCH 1/1] RPM Spec files

[Erez Zilber]

Mike Heinz wrote:

> Installation of OFED 1.3.0.0.4 onto a Kusu/OCS cluster does not fully
> succeed because of some missing dependencies in the RPM spec files. This
> is because Kusu installs nodes over a network by presenting a pool of
> RPMs to be installed and letting RPM figure out the order to install
> them in. Without the dependencies we ended up with oddities like the
> kernel drivers being installed before the /usr/bin directory had been
> populated, causing the install script to fail.
>  
> I was able to work around this by manually expanding some of the source
> RPM files, altering the spec file and repackaging the source RPM. This
> allowed me to build binary RPMs (via the install script) that could be
> installed on a Kusu cluster.
>  
> Here are the proposed changes. If there is a better/preferred way of
> submitting this suggestion, please let me know.
>   

Some general comments:

* OFED issues are discussed in the ewg list. You should send patches
  to that list.
* You have patches for multiple git trees (bonding, open-iscsi etc).
  You should separate them to multiple patches. Each patch should
  have a separate e-mail message (and add the maintainer to the
  thread). The best thing to do is to create a patch set.
* Please create the patches against the relevant git trees. It will
  make it easier to apply them.

See more comments below.

>  
> --- ../../original/ib-bonding.spec  2008-04-22 12:54:12.0
> -0400
> +++ ib-bonding.spec 2008-04-22 12:43:07.0 -0400
> @@ -20,6 +20,7 @@
>  Group   : Applications/System
>  License : GPL
>  BuildRoot:  %{_tmppath}/%{name}-%{version}-root
> +PreReq : coreutils
>  
>  %description
>  This package provides a bonding device which is capable of enslaving
> --- ../../original/ofa_kernel.spec  2008-04-22 12:54:13.0
> -0400
> +++ ofa_kernel.spec 2008-04-22 12:45:40.0 -0400
> @@ -111,6 +111,9 @@
>  BuildRequires: sysfsutils-devel
>  
>  %package -n kernel-ib
> +PreReq: coreutils
> +PreReq: kernel
> +PreReq: pciutils
>  Version: %{_version}
>  Release: %{krelver}
>  Summary: Infiniband Driver and ULPs kernel modules
> @@ -119,6 +122,10 @@
>  Core, HW and ULPs kernel modules
>  
>  %package -n kernel-ib-devel
> +PreReq: coreutils
> +PreReq: kernel
> +PreReq: pciutils
> +Requires: kernel-ib
>  Version: %{_version}
>  Release: %{krelver}
>  Summary: Infiniband Driver and ULPs kernel modules sources
> --- ../../original/open-iscsi-generic.spec  2008-04-22
>   

If this change is relevant for open-iscsi.git, it is also relevant for
open-iscsi-rh4.git. BTW - you can see the list of git trees here:
http://www.openfabrics.org/git/

Erez

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Moving responsibility for iSER & iSCSI related issues

[Erez Zilber]

Hi,


After ~4 years of working on iSER & iSCSI, I'm moving on and will be
involved from a different perspective. Therefore, I will be unable to
continue my current maintainership responsibility for iSER related
issues. I want to thank everyone for the great work that I had the
chance to be part of.


Eli Dorfman ([EMAIL PROTECTED]) will be taking over my maintainership of
iSER code for kernel.org. Eli has already started doing that work.


Doron Shoham ([EMAIL PROTECTED]) will be responsible for iSER and
iSCSI related issues in OFED (i.e. open-iscsi, iSER & stgt). All
relevant git trees will move from my trees to his.


These changes will be effective as of 19/5/08. After that, if you need
anything, I will be available on [EMAIL PROTECTED]


Erez


___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Need to change iSER module owner in Bugzilla

[Erez Zilber]

Tziporet,


The new owner of the iSER module in Bugzilla is Doron Shoham. Who should
make this change in Bugzilla's definitions?


-- 

____

Erez Zilber | 972-9-971-7689

Software Engineer, Storage Solutions

Voltaire – _The Grid Backbone_

__

www.voltaire.com <http://www.voltaire.com/>



___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Re: [ewg] version number of rpms on OFED-1.3.1

[Erez Zilber]

Doron Shoham wrote:

> Hi,
>
> Some of the RPMs that will be included in OFED 1.3.1 will be different
> in content from the ones in OFED 1.3. (e.g. open-iscsi)
> Therefore, I think that those RPMs must have a different version number.
>
> Is there already a convention for that?
> Else, we need to define one.
>

Tziporet, Vlad,

We can define our own convention for the open-iscsi RPM. However, I
think that it would be better to define a convention that will be used
for all RPMs in OFED.

Erez

___
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg