[Bug 541792] Review Request: woff - Encoding and Decoding for Web Open Font Format(Woff)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=541792 Nicolas Mailhot changed: What|Removed |Added CC||fedora-fonts-bugs-l...@redh ||at.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 487913] Review Request: culmus-fancy-fonts - Fancy fonts for Hebrew
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487913 Nicolas Mailhot changed: What|Removed |Added Flag||needinfo?(dan...@cs.technio ||n.ac.il) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 487913] Review Request: culmus-fancy-fonts - Fancy fonts for Hebrew
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487913 --- Comment #7 from Nicolas Mailhot 2009-11-28 06:06:13 EDT --- This srpm does not build at all. Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.vWyOk7 + umask 022 + cd /builddir/build/BUILD + LANG=C + export LANG + unset DISPLAY + cd /builddir/build/BUILD + rm -rf culmus-fancy-0.20051122 + /usr/bin/gzip -dc /builddir/build/SOURCES/comix.tar.gz + /bin/tar -xf - + STATUS=0 + '[' 0 -ne 0 ']' + cd culmus-fancy-0.20051122 /var/tmp/rpm-tmp.vWyOk7: line 34: cd: culmus-fancy-0.20051122: No such file or directory RPM build errors: error: Bad exit status from /var/tmp/rpm-tmp.vWyOk7 (%prep) Bad exit status from /var/tmp/rpm-tmp.vWyOk7 (%prep) Child returncode was: 1 EXCEPTION: Command failed. See logs for output. It is not easy to write a multi-source srpm. It is definitely not recommended to try when you can go without. Since in your case, upstream already publishes each font set in a separate tar.gz, why don't you just do one simple mono-source srpm per tar.gz, instead of trying to force them all to collaborate in a single monster srpm ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 487913] Review Request: culmus-fancy-fonts - Fancy fonts for Hebrew
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487913 Dan Kenigsberg changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NOTABUG -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 477387] [fonts-hebrew-fancy] Please convert to new font packaging guidelines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477387 Bug 477387 depends on bug 487913, which changed state. Bug 487913 Summary: Review Request: culmus-fancy-fonts - Fancy fonts for Hebrew https://bugzilla.redhat.com/show_bug.cgi?id=487913 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||NOTABUG -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 487913] Review Request: culmus-fancy-fonts - Fancy fonts for Hebrew
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487913 Dan Kenigsberg changed: What|Removed |Added Attachment #367959|0 |1 is obsolete|| Flag|needinfo?(dan...@cs.technio | |n.ac.il)| --- Comment #8 from Dan Kenigsberg 2009-11-28 06:38:12 EDT --- Created an attachment (id=374387) --> (https://bugzilla.redhat.com/attachment.cgi?id=374387) srpm with fixes to several of the problems you are perfectly correct. I should not waste any more of your or anybody else's time about this. I just wanted to leave a useful rpm behind, but uploaded a broken old attempt instead. thanks for your help. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
File fontpackages-1.36.tar.xz uploaded to lookaside cache by nim
A file has been added to the lookaside cache for fontpackages: 145e2684017fc2f593d1abd018bfb343 fontpackages-1.36.tar.xz ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
rpms/fontpackages/devel .cvsignore, 1.25, 1.26 fontpackages.spec, 1.32, 1.33 import.log, 1.28, 1.29 sources, 1.25, 1.26
Author: nim Update of /cvs/extras/rpms/fontpackages/devel In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv24145/devel Modified Files: .cvsignore fontpackages.spec import.log sources Log Message: 1.36 Index: .cvsignore === RCS file: /cvs/extras/rpms/fontpackages/devel/.cvsignore,v retrieving revision 1.25 retrieving revision 1.26 diff -u -p -r1.25 -r1.26 --- .cvsignore 23 Nov 2009 20:42:19 - 1.25 +++ .cvsignore 28 Nov 2009 11:54:06 - 1.26 @@ -1 +1 @@ -fontpackages-1.35.tar.xz +fontpackages-1.36.tar.xz Index: fontpackages.spec === RCS file: /cvs/extras/rpms/fontpackages/devel/fontpackages.spec,v retrieving revision 1.32 retrieving revision 1.33 diff -u -p -r1.32 -r1.33 --- fontpackages.spec 23 Nov 2009 20:42:19 - 1.32 +++ fontpackages.spec 28 Nov 2009 11:54:07 - 1.33 @@ -3,7 +3,7 @@ %global rpmmacrodir %{_sysconfdir}/rpm/ Name:fontpackages -Version: 1.35 +Version: 1.36 Release: 1%{?dist} Summary: Common directory and macro definitions used by font packages @@ -46,7 +46,8 @@ create font packages. %package tools Summary: Tools used to check fonts and font packages -Requires: fontconfig, fontforge, mutt, make +Requires: fontconfig, fontforge +Requires: wget, mutt, make Requires: rpmlint, yum-utils, fedora-packager %description tools @@ -133,6 +134,9 @@ rm -fr %{buildroot} %{_bindir}/* %changelog +* Sat Nov 28 2009 Nicolas Mailhot +- 1.36-1 + * Mon Nov 23 2009 Nicolas Mailhot - 1.35-1 Index: import.log === RCS file: /cvs/extras/rpms/fontpackages/devel/import.log,v retrieving revision 1.28 retrieving revision 1.29 diff -u -p -r1.28 -r1.29 --- import.log 23 Nov 2009 20:42:19 - 1.28 +++ import.log 28 Nov 2009 11:54:07 - 1.29 @@ -26,3 +26,4 @@ fontpackages-1_32-1_fc13:HEAD:fontpackag fontpackages-1_33-1_fc13:HEAD:fontpackages-1.33-1.fc13.src.rpm:1258836076 fontpackages-1_34-1_fc13:HEAD:fontpackages-1.34-1.fc13.src.rpm:1258902754 fontpackages-1_35-1_fc13:HEAD:fontpackages-1.35-1.fc13.src.rpm:1259008917 +fontpackages-1_36-1_fc13:HEAD:fontpackages-1.36-1.fc13.src.rpm:1259409227 Index: sources === RCS file: /cvs/extras/rpms/fontpackages/devel/sources,v retrieving revision 1.25 retrieving revision 1.26 diff -u -p -r1.25 -r1.26 --- sources 23 Nov 2009 20:42:19 - 1.25 +++ sources 28 Nov 2009 11:54:07 - 1.26 @@ -1 +1 @@ -889ebe16ea65deb3e5ce14612a2f94ec fontpackages-1.35.tar.xz +145e2684017fc2f593d1abd018bfb343 fontpackages-1.36.tar.xz ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
File fontpackages-1.37.tar.xz uploaded to lookaside cache by nim
A file has been added to the lookaside cache for fontpackages: 3d4bf7609a75e183c8e252bc9b563138 fontpackages-1.37.tar.xz ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
rpms/fontpackages/devel .cvsignore, 1.26, 1.27 fontpackages.spec, 1.33, 1.34 import.log, 1.29, 1.30 sources, 1.26, 1.27
Author: nim Update of /cvs/extras/rpms/fontpackages/devel In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv1414/devel Modified Files: .cvsignore fontpackages.spec import.log sources Log Message: 1.37 Index: .cvsignore === RCS file: /cvs/extras/rpms/fontpackages/devel/.cvsignore,v retrieving revision 1.26 retrieving revision 1.27 diff -u -p -r1.26 -r1.27 --- .cvsignore 28 Nov 2009 11:54:06 - 1.26 +++ .cvsignore 28 Nov 2009 12:32:08 - 1.27 @@ -1 +1 @@ -fontpackages-1.36.tar.xz +fontpackages-1.37.tar.xz Index: fontpackages.spec === RCS file: /cvs/extras/rpms/fontpackages/devel/fontpackages.spec,v retrieving revision 1.33 retrieving revision 1.34 diff -u -p -r1.33 -r1.34 --- fontpackages.spec 28 Nov 2009 11:54:07 - 1.33 +++ fontpackages.spec 28 Nov 2009 12:32:08 - 1.34 @@ -3,7 +3,7 @@ %global rpmmacrodir %{_sysconfdir}/rpm/ Name:fontpackages -Version: 1.36 +Version: 1.37 Release: 1%{?dist} Summary: Common directory and macro definitions used by font packages @@ -135,7 +135,7 @@ rm -fr %{buildroot} %changelog * Sat Nov 28 2009 Nicolas Mailhot -- 1.36-1 +- 1.37-1 * Mon Nov 23 2009 Nicolas Mailhot - 1.35-1 Index: import.log === RCS file: /cvs/extras/rpms/fontpackages/devel/import.log,v retrieving revision 1.29 retrieving revision 1.30 diff -u -p -r1.29 -r1.30 --- import.log 28 Nov 2009 11:54:07 - 1.29 +++ import.log 28 Nov 2009 12:32:08 - 1.30 @@ -27,3 +27,4 @@ fontpackages-1_33-1_fc13:HEAD:fontpackag fontpackages-1_34-1_fc13:HEAD:fontpackages-1.34-1.fc13.src.rpm:1258902754 fontpackages-1_35-1_fc13:HEAD:fontpackages-1.35-1.fc13.src.rpm:1259008917 fontpackages-1_36-1_fc13:HEAD:fontpackages-1.36-1.fc13.src.rpm:1259409227 +fontpackages-1_37-1_fc13:HEAD:fontpackages-1.37-1.fc13.src.rpm:1259411507 Index: sources === RCS file: /cvs/extras/rpms/fontpackages/devel/sources,v retrieving revision 1.26 retrieving revision 1.27 diff -u -p -r1.26 -r1.27 --- sources 28 Nov 2009 11:54:07 - 1.26 +++ sources 28 Nov 2009 12:32:08 - 1.27 @@ -1 +1 @@ -145e2684017fc2f593d1abd018bfb343 fontpackages-1.36.tar.xz +3d4bf7609a75e183c8e252bc9b563138 fontpackages-1.37.tar.xz ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Issue 107254] Incorrect ToUnicode table mapping for ligatures in PDF
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=107254 User nmailhot changed the following: What|Old value |New value CC|'hdu' |'fedorafonts,hdu' - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Issue 95057] Export to PDF: Umlaute / diacritics and space problems with Type 1 font
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=95057 User nmailhot changed the following: What|Old value |New value CC|''|'fedorafonts' - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Issue 87686] Problem with accent in vertical text when exporting to PDF
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=87686 User nmailhot changed the following: What|Old value |New value CC|'hdu' |'fedorafonts,hdu' - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 533919] Review Request: mplus fonts - The M+ family of fonts designed by Coji Morishita
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533919 Nicolas Mailhot changed: What|Removed |Added Status|NEW |ASSIGNED CC||fedora-fonts-bugs-l...@redh ||at.com AssignedTo|nob...@fedoraproject.org|nicolas.mail...@laposte.net Flag||fedora-review?, ||needinfo?(igshaan.mes...@gm ||ail.com) --- Comment #1 from Nicolas Mailhot 2009-11-28 09:57:38 EDT --- Here is my package review. Sorry it took longer than usual, was busy hacking a packager checker script (and given m+ is composed of 43 files, I'm so glad I took the time to finish the script before looking at it; could not have done the same level of review manually) This is an awesome font set, thank you very much for packaging it! Anyway, the review: 1. (not blocking) you don't include any fontconfig files, they would make your user's life a lot easier (however, CJK is quite a mess in fontconfig, so maybe it's better that way for now. Let's see what CJK users think of it) 2. (not blocking) rpmlint complains at the licensing string. I know the MPlus license has been approved by spot, so it's not a legal problem. However I fear all the repo-checking scripts will complain at you because of that. Please open a fedora rpmlint bug so the license gets added to its list. (however upstream would have made our life easier by using a standard font license such as the OFL or the GPL with font exception) 3. (not blocking) rpmlint complains some of the lines you used in descriptions are too long. Please break them in smaller (<80) bits 4. (blocking) same problem for at least one for your summaries 5. (not blocking) it seems rpmlint grew a spell-checker in fedora-devel. Please fix the spelling mistakes it has identified (ie everything which is not a human name) 6. (blocking) please make sure your Source0 is a full URL pointing to the source file. That will make your future packager life a lot easier (we have many sf-hosted projects in Fedora, so it can be done) 7. (not blocking) you don't need to repeat the "Group:User Interface/X" line in Fedora releases with a recent rpm 8. (not blocking) it would be nice if each sub-package had a different summary. What is the difference between 1c and 2c ? 9. (blocking) m++ipa.pe is a build script, it has nothing to do in %doc 10. (not blocking) you don't need to specify %dir %{_fontdir} in the common subpackage, it will be added automatically to each font subpackage 11. (not blocking) it's mostly cosmetic, but it would be nice if the font files cased the style names they declare (ie "Bold" instead of "bold"). Apps are not always smart enough to correct this 12. (not blocking) a few font files declare an "heavy" weight. The standard qualifier for "heavy" is "Black". That means weight selection won't work as expected in apps not smart enough to try every possible "Black" legacy alias. Please ask upstream to change this (also please have upstream check they did mean "Black" and not some other weight). Standard style qualifiers and their meaning have been described by Microsoft in the following whitepaper: http://blogs.msdn.com/text/attachment/2249036.ashx 13. (not blocking) the fonts fall just short of complete coverage for several languages and unicode blocks (we only test if a language/block needs less than 10 glyphs to be finished). Please relay upstream so it gets a chance to complete them (for example, ab is incomplete because the Unicode consortium added two glyphs to it this year IIRC) 14. (not blocking) it would be nice if upstream included the text of their license in the fonts copyright field, and not just "Copyright(c) 2009 M+ FONTS PROJECT" without licensing info 15. (not blocking) it would be nice if upstream released a source archive with source files and build scripts, so we can re-build in Fedora using our own fontforge version (that helps finding bugs in fontforge, and as our fontforge improves, so do the fonts we build with it) Please fix whatever you can and relay the requests to upstream when appropriate. I'll attach the output of latest repo-font-audit for your package so you have a copy of rpmlint errors, font naming warnings, and font coverage analysis. There are a lot of requests here but your package is quite complex. Given the number of packaged font files both you and upstream did a very good job, I've seen much worse in packages that only included a couple font files. NEEDINFO for now -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are recei
[Bug 533919] Review Request: mplus fonts - The M+ family of fonts designed by Coji Morishita
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533919 --- Comment #2 from Nicolas Mailhot 2009-11-28 10:02:31 EDT --- Created an attachment (id=374418) --> (https://bugzilla.redhat.com/attachment.cgi?id=374418) repo-font-audit data for this package -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
File fontpackages-1.38.tar.xz uploaded to lookaside cache by nim
A file has been added to the lookaside cache for fontpackages: 5c1ec4068beca311a2f01f1940958e19 fontpackages-1.38.tar.xz ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
rpms/fontpackages/devel .cvsignore, 1.27, 1.28 fontpackages.spec, 1.34, 1.35 import.log, 1.30, 1.31 sources, 1.27, 1.28
Author: nim Update of /cvs/extras/rpms/fontpackages/devel In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv18417/devel Modified Files: .cvsignore fontpackages.spec import.log sources Log Message: 1.38 Index: .cvsignore === RCS file: /cvs/extras/rpms/fontpackages/devel/.cvsignore,v retrieving revision 1.27 retrieving revision 1.28 diff -u -p -r1.27 -r1.28 --- .cvsignore 28 Nov 2009 12:32:08 - 1.27 +++ .cvsignore 28 Nov 2009 15:44:21 - 1.28 @@ -1 +1 @@ -fontpackages-1.37.tar.xz +fontpackages-1.38.tar.xz Index: fontpackages.spec === RCS file: /cvs/extras/rpms/fontpackages/devel/fontpackages.spec,v retrieving revision 1.34 retrieving revision 1.35 diff -u -p -r1.34 -r1.35 --- fontpackages.spec 28 Nov 2009 12:32:08 - 1.34 +++ fontpackages.spec 28 Nov 2009 15:44:21 - 1.35 @@ -3,7 +3,7 @@ %global rpmmacrodir %{_sysconfdir}/rpm/ Name:fontpackages -Version: 1.37 +Version: 1.38 Release: 1%{?dist} Summary: Common directory and macro definitions used by font packages @@ -135,7 +135,8 @@ rm -fr %{buildroot} %changelog * Sat Nov 28 2009 Nicolas Mailhot -- 1.37-1 +- 1.38-1 +— Bugfix release * Mon Nov 23 2009 Nicolas Mailhot - 1.35-1 Index: import.log === RCS file: /cvs/extras/rpms/fontpackages/devel/import.log,v retrieving revision 1.30 retrieving revision 1.31 diff -u -p -r1.30 -r1.31 --- import.log 28 Nov 2009 12:32:08 - 1.30 +++ import.log 28 Nov 2009 15:44:21 - 1.31 @@ -28,3 +28,4 @@ fontpackages-1_34-1_fc13:HEAD:fontpackag fontpackages-1_35-1_fc13:HEAD:fontpackages-1.35-1.fc13.src.rpm:1259008917 fontpackages-1_36-1_fc13:HEAD:fontpackages-1.36-1.fc13.src.rpm:1259409227 fontpackages-1_37-1_fc13:HEAD:fontpackages-1.37-1.fc13.src.rpm:1259411507 +fontpackages-1_38-1_fc13:HEAD:fontpackages-1.38-1.fc13.src.rpm:1259423037 Index: sources === RCS file: /cvs/extras/rpms/fontpackages/devel/sources,v retrieving revision 1.27 retrieving revision 1.28 diff -u -p -r1.27 -r1.28 --- sources 28 Nov 2009 12:32:08 - 1.27 +++ sources 28 Nov 2009 15:44:21 - 1.28 @@ -1 +1 @@ -3d4bf7609a75e183c8e252bc9b563138 fontpackages-1.37.tar.xz +5c1ec4068beca311a2f01f1940958e19 fontpackages-1.38.tar.xz ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 477387] [fonts-hebrew-fancy] Please convert to new font packaging guidelines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477387 Bug 477387 depends on bug 487913, which changed state. Bug 487913 Summary: Review Request: culmus-fancy-fonts - Fancy fonts for Hebrew https://bugzilla.redhat.com/show_bug.cgi?id=487913 What|Old Value |New Value Status|CLOSED |ASSIGNED Resolution|NOTABUG | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 487913] Review Request: culmus-fancy-fonts - Fancy fonts for Hebrew
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487913 Nicolas Mailhot changed: What|Removed |Added Keywords||Reopened Status|CLOSED |ASSIGNED Resolution|NOTABUG | --- Comment #9 from Nicolas Mailhot 2009-11-28 10:59:02 EDT --- Please calm down, I couldn't guess you already went through the multi-source spec hackery in an unpublished srpm. Given you did it this way I'll review the result. I still think it would have been faster to drop the multi-sourcing and propose several srpms, but there is no need to go back now if the result works -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 487913] Review Request: culmus-fancy-fonts - Fancy fonts for Hebrew
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487913 Nicolas Mailhot changed: What|Removed |Added Flag||needinfo?(dan...@cs.technio ||n.ac.il) --- Comment #10 from Nicolas Mailhot 2009-11-28 11:36:05 EDT --- Anyway, review check: 1. (informative) I'm afraid you're going to receive "bad font naming" warnings for Comix regularly. The current font naming is acceptable, however some of the very aggressive font name munging we have to perform because of the brokeness in other Fedora fonts seems to result in a spurious warning in your case (and I don't see how to avoid this without renouncing to detect the other broken fonts) 2. (not blocking) fontlint does not like anka, please relay upstream 3. (not blocking) you do not need to repeat "Group: User Interface/X" in Fedora releases that use a recent rpm 4. (not blocking) you do not need to require the common subpackage in your compat subpackage 5. (blocking) you don't want to obsolete fonts-hebrew-fancy < 0.20051122-7, you want to obsolete fonts-hebrew-fancy < 0.20051122-9 (assuming you'll never build anything newer as fonts-hebrew-fancy) 6. (not blocking) I'm sure users would appreciate descriptions that tell them the difference between each of those subpackages 7. (not blocking) you don't need the "%dir %{_fontdir}" in common, it will be auto-added to every font subpackage 8. (not blocking) your fontconfig rules are incomplete, you need to use the complete substitution pattern documented in /usr/share/fontconfig/templates/substitution-font-template-* 9. (not blocking) the way you package the licensing file is dangerous, if upstream ever changes the licensing file in one package but not the others you'll end up shipping the wrong legal info 10. (not blocking) some of the fonts have broken encoding in their copyright info when opened by gnome-font-viewer (no idea which one of gnome-font-viewer or the fonts is broken) 11. (not blocking) it would be nice if upstream's license included the FSF font exception that make a GPL font safe to use in a PDF (Looking at all those clm fonts I realise we should have used clm and not culmus as foundry prefix in the naming of culmus font rpms. Bah, not worth fixing it now) Anyway, apart from the broken obsolete, everything else can be fixed over time after Fedora import. Please fix the obsolete so I can approve this package -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
File fontpackages-1.39.tar.xz uploaded to lookaside cache by nim
A file has been added to the lookaside cache for fontpackages: f2cc943a755422ff2d100c7e8d723f2a fontpackages-1.39.tar.xz ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
rpms/fontpackages/devel .cvsignore, 1.28, 1.29 fontpackages.spec, 1.35, 1.36 import.log, 1.31, 1.32 sources, 1.28, 1.29
Author: nim Update of /cvs/extras/rpms/fontpackages/devel In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv6719/devel Modified Files: .cvsignore fontpackages.spec import.log sources Log Message: 1.39 Index: .cvsignore === RCS file: /cvs/extras/rpms/fontpackages/devel/.cvsignore,v retrieving revision 1.28 retrieving revision 1.29 diff -u -p -r1.28 -r1.29 --- .cvsignore 28 Nov 2009 15:44:21 - 1.28 +++ .cvsignore 28 Nov 2009 17:02:46 - 1.29 @@ -1 +1 @@ -fontpackages-1.38.tar.xz +fontpackages-1.39.tar.xz Index: fontpackages.spec === RCS file: /cvs/extras/rpms/fontpackages/devel/fontpackages.spec,v retrieving revision 1.35 retrieving revision 1.36 diff -u -p -r1.35 -r1.36 --- fontpackages.spec 28 Nov 2009 15:44:21 - 1.35 +++ fontpackages.spec 28 Nov 2009 17:02:46 - 1.36 @@ -3,7 +3,7 @@ %global rpmmacrodir %{_sysconfdir}/rpm/ Name:fontpackages -Version: 1.38 +Version: 1.39 Release: 1%{?dist} Summary: Common directory and macro definitions used by font packages @@ -135,7 +135,7 @@ rm -fr %{buildroot} %changelog * Sat Nov 28 2009 Nicolas Mailhot -- 1.38-1 +- 1.39-1 — Bugfix release * Mon Nov 23 2009 Nicolas Mailhot Index: import.log === RCS file: /cvs/extras/rpms/fontpackages/devel/import.log,v retrieving revision 1.31 retrieving revision 1.32 diff -u -p -r1.31 -r1.32 --- import.log 28 Nov 2009 15:44:21 - 1.31 +++ import.log 28 Nov 2009 17:02:47 - 1.32 @@ -29,3 +29,4 @@ fontpackages-1_35-1_fc13:HEAD:fontpackag fontpackages-1_36-1_fc13:HEAD:fontpackages-1.36-1.fc13.src.rpm:1259409227 fontpackages-1_37-1_fc13:HEAD:fontpackages-1.37-1.fc13.src.rpm:1259411507 fontpackages-1_38-1_fc13:HEAD:fontpackages-1.38-1.fc13.src.rpm:1259423037 +fontpackages-1_39-1_fc13:HEAD:fontpackages-1.39-1.fc13.src.rpm:1259427747 Index: sources === RCS file: /cvs/extras/rpms/fontpackages/devel/sources,v retrieving revision 1.28 retrieving revision 1.29 diff -u -p -r1.28 -r1.29 --- sources 28 Nov 2009 15:44:21 - 1.28 +++ sources 28 Nov 2009 17:02:47 - 1.29 @@ -1 +1 @@ -5c1ec4068beca311a2f01f1940958e19 fontpackages-1.38.tar.xz +f2cc943a755422ff2d100c7e8d723f2a fontpackages-1.39.tar.xz ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 225617] Merge Review: bitmap-fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225617 Nicolas Mailhot changed: What|Removed |Added Status|NEW |ASSIGNED CC|nicolas.mail...@laposte.net | AssignedTo|nob...@fedoraproject.org|nicolas.mail...@laposte.net Flag||fedora-review?, ||needinfo?(nob...@fedoraproj ||ect.org) --- Comment #34 from Nicolas Mailhot 2009-11-28 12:32:26 EDT --- Ok, looking at this srpm, most of the warnings and errors are gone. Good! However: 1. (not blocking) fontlint does not like any of the resulting font files, they all need fixing but I guess it's not worse than before 2. (not blocking) the lucida typewriter files declare broken style naming that really needs fixing or apps won't be happy 3. (not blocking) all the files have almost-complete (but not complete) coverage of one or more unicode blocks (probably reflects unicode changes since they were last updated) 4. (blocking) License: Lucida is probably wrong for the base package, it should be GPLv2 and MIT 5. (not blocking) Requires: fontpackages-filesystem is not needed for the base package 6. (blocking) since the bitmap-fonts package does not exist anymore, it needs to be garbage-collected. Please add an Obsoletes: bitmap-fonts < 0.3-14 to the bitmap-fixed-fonts subpackage (let's not be fancy, it's not worth it) It seems I was a little optimistic before, this package needs some tweaking yet. But it has progressed a lot -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 225617] Merge Review: bitmap-fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225617 Nicolas Mailhot changed: What|Removed |Added Flag||needinfo?(psatp...@redhat.c ||om) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 225617] Merge Review: bitmap-fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225617 --- Comment #35 from Nicolas Mailhot 2009-11-28 12:35:03 EDT --- Created an attachment (id=374438) --> (https://bugzilla.redhat.com/attachment.cgi?id=374438) repo-font-audit test results for this package -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 225617] Merge Review: bitmap-fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225617 Nicolas Mailhot changed: What|Removed |Added Flag|needinfo?(nob...@fedoraproj | |ect.org)| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
[Bug 541792] Review Request: woff - Encoding and Decoding for Web Open Font Format(Woff)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=541792 Nicolas Mailhot changed: What|Removed |Added Flag||needinfo?(pnem...@redhat.co ||m) --- Comment #1 from Nicolas Mailhot 2009-11-28 12:42:53 EDT --- IMHO woff is a terrible idea, a waste of resources, will only muddy waters, and I doubt defining a new format just in case ie may want to pick it up sometime will end up well, but I guess that if this format starts being used in the field we may as well be able to decode it. However, this package does not even build in mock + umask 022 + cd /builddir/build/BUILD + cd woff-0.20091126 + LANG=C + export LANG + unset DISPLAY + make 'CFLAGS=-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic' -j2 cc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -c -o sfnt2woff.o sfnt2woff.c cc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -c -o woff.o woff.c cc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -c -o woff2sfnt.o woff2sfnt.c woff.c:43:18: error: zlib.h: No such file or directory woff.c: In function 'woffEncode': woff.c:255: error: 'uLong' undeclared (first use in this function) woff.c:255: error: (Each undeclared identifier is reported only once woff.c:255: error: for each function it appears in.) woff.c:255: error: expected ';' before 'sourceLen' woff.c:276: error: 'sourceLen' undeclared (first use in this function) woff.c:280: error: 'destLen' undeclared (first use in this function) woff.c:280: warning: implicit declaration of function 'compressBound' woff.c:287: warning: implicit declaration of function 'compress2' woff.c:287: error: 'Bytef' undeclared (first use in this function) woff.c:287: error: expected expression before ')' token woff.c:288: error: expected ')' before 'Bytef' woff.c:288: warning: type defaults to 'int' in declaration of 'type name' woff.c:288: warning: cast from pointer to integer of different size woff.c:289: error: 'Z_OK' undeclared (first use in this function) woff.c:135: warning: unused variable 'tableBase' woff.c: In function 'rebuildWoff': woff.c:406: warning: unused variable 'tableData' woff.c: In function 'woffSetMetadata': -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
File fontpackages-1.40.tar.xz uploaded to lookaside cache by nim
A file has been added to the lookaside cache for fontpackages: a0e5cc0a64a05ecbf0a4ac0f1c90d51a fontpackages-1.40.tar.xz ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list
rpms/fontpackages/devel .cvsignore, 1.29, 1.30 fontpackages.spec, 1.36, 1.37 import.log, 1.32, 1.33 sources, 1.29, 1.30
Author: nim Update of /cvs/extras/rpms/fontpackages/devel In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv18983/devel Modified Files: .cvsignore fontpackages.spec import.log sources Log Message: 1.40 Index: .cvsignore === RCS file: /cvs/extras/rpms/fontpackages/devel/.cvsignore,v retrieving revision 1.29 retrieving revision 1.30 diff -u -p -r1.29 -r1.30 --- .cvsignore 28 Nov 2009 17:02:46 - 1.29 +++ .cvsignore 28 Nov 2009 20:04:24 - 1.30 @@ -1 +1 @@ -fontpackages-1.39.tar.xz +fontpackages-1.40.tar.xz Index: fontpackages.spec === RCS file: /cvs/extras/rpms/fontpackages/devel/fontpackages.spec,v retrieving revision 1.36 retrieving revision 1.37 diff -u -p -r1.36 -r1.37 --- fontpackages.spec 28 Nov 2009 17:02:46 - 1.36 +++ fontpackages.spec 28 Nov 2009 20:04:24 - 1.37 @@ -3,7 +3,7 @@ %global rpmmacrodir %{_sysconfdir}/rpm/ Name:fontpackages -Version: 1.39 +Version: 1.40 Release: 1%{?dist} Summary: Common directory and macro definitions used by font packages @@ -47,8 +47,8 @@ create font packages. Summary: Tools used to check fonts and font packages Requires: fontconfig, fontforge -Requires: wget, mutt, make -Requires: rpmlint, yum-utils, fedora-packager +Requires: curl, make, mutt +Requires: fedora-packager, rpmlint, yum-utils %description tools This package contains tools used to check fonts and font packages @@ -135,7 +135,7 @@ rm -fr %{buildroot} %changelog * Sat Nov 28 2009 Nicolas Mailhot -- 1.39-1 +- 1.40-1 — Bugfix release * Mon Nov 23 2009 Nicolas Mailhot Index: import.log === RCS file: /cvs/extras/rpms/fontpackages/devel/import.log,v retrieving revision 1.32 retrieving revision 1.33 diff -u -p -r1.32 -r1.33 --- import.log 28 Nov 2009 17:02:47 - 1.32 +++ import.log 28 Nov 2009 20:04:24 - 1.33 @@ -30,3 +30,4 @@ fontpackages-1_36-1_fc13:HEAD:fontpackag fontpackages-1_37-1_fc13:HEAD:fontpackages-1.37-1.fc13.src.rpm:1259411507 fontpackages-1_38-1_fc13:HEAD:fontpackages-1.38-1.fc13.src.rpm:1259423037 fontpackages-1_39-1_fc13:HEAD:fontpackages-1.39-1.fc13.src.rpm:1259427747 +fontpackages-1_40-1_fc13:HEAD:fontpackages-1.40-1.fc13.src.rpm:1259438431 Index: sources === RCS file: /cvs/extras/rpms/fontpackages/devel/sources,v retrieving revision 1.29 retrieving revision 1.30 diff -u -p -r1.29 -r1.30 --- sources 28 Nov 2009 17:02:47 - 1.29 +++ sources 28 Nov 2009 20:04:24 - 1.30 @@ -1 +1 @@ -f2cc943a755422ff2d100c7e8d723f2a fontpackages-1.39.tar.xz +a0e5cc0a64a05ecbf0a4ac0f1c90d51a fontpackages-1.40.tar.xz ___ Fedora-fonts-bugs-list mailing list Fedora-fonts-bugs-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list