[Bug 474992] Review Request: libirman - Library for IRMAN hardware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474992 --- Comment #22 from Jan ONDREJ ondr...@salstar.sk 2009-05-17 03:01:29 EDT --- %changelog * Sun May 17 2009 Ján ONDREJ (SAL) ondrejj(at)salstar.sk - 0.4.5-3 - added libtoolize to fix build for f11 Builds for f11 now. http://www.salstar.sk/pub/fedora/SPECS/libirman.spec http://www.salstar.sk/pub/fedora/SRPMS/10/libirman-0.4.5-3.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 494199] Review Request: drascula-international - Subtitles for Drascula: The Vampire Strikes Back
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=494199 Hans de Goede hdego...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Hans de Goede hdego...@redhat.com 2009-05-17 04:17:10 EDT --- (In reply to comment #6) Okay. That seems to fit. This package is APPROVED! Thanks! New Package CVS Request === Package Name: drascula-international Short Description: Subtitles for Drascula: The Vampire Strikes Back Owners:jwrdegoede Branches: F-10 F-11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 480056] Review Request: libchamplain-gtk - Gtk+ widget wrapper for libchamplain
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480056 --- Comment #6 from Denis Leroy de...@poolshark.org 2009-05-17 04:26:19 EDT --- Hi Debarshi, Sorry for the delay. Let's get it over with, can you post updates to your spec and srpm ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498246] Review Request: towhee - A Monte Carlo molecular simulation code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498246 --- Comment #5 from Jussi Lehtola jussi.leht...@iki.fi 2009-05-17 04:37:16 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498248] Review Request: viewmol - An open source graphical front end for computational chemistry programs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498248 --- Comment #3 from Jussi Lehtola jussi.leht...@iki.fi 2009-05-17 04:51:01 EDT --- I've contacted chemical-mime upstream to ask them to add the missing types. In the mean time, I've included them into this package. http://theory.physics.helsinki.fi/~jzlehtol/rpms/viewmol.spec http://theory.physics.helsinki.fi/~jzlehtol/rpms/viewmol-2.4.1-2.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498248] Review Request: viewmol - An open source graphical front end for computational chemistry programs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498248 --- Comment #4 from Christoph Wickert fed...@christoph-wickert.de 2009-05-17 05:05:47 EDT --- (In reply to comment #2) Done. I'll post the new spec after you have reviewed other stuff as well. What other stuff are you referring to? Anwthing else than bug # 498246? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 501006] Review Request: xine-ui - A skinned xlib-based gui for xine-lib
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=501006
Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #12 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-05-17
05:14:07 EDT ---
(In reply to comment #6)
?? About aaxine
- Well, currently launching aaxine on CUI (with framebuffer, vga=791)
by $ aaxine some_file
! Well, I found that aaxine accepts the option used
by aalib as shown in src/aaui/main.c:
-
638 #ifdef AA
639/*
640 * AALib help and option-parsing
641 */
642if (!aa_parseoptions(NULL, NULL, argc, argv)) {
643 print_usage();
644 goto failure;
645}
646 #endif
-
Then:
(In reply to comment #7)
(In reply to comment #6)
For -8:
* Desktop file
- Remove Application category. This category is marked as
deprecated. ref:
http://www.redhat.com/archives/fedora-extras-list/2006-October/msg00723.html
Removed.
- You can use --remove-category option of desktop-file-install
(as you are already using --add-category) instead of using sed.
-
This package (xine-ui) is APPROVED by mtasaka
-
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498248] Review Request: viewmol - An open source graphical front end for computational chemistry programs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498248 --- Comment #5 from Jussi Lehtola jussi.leht...@iki.fi 2009-05-17 05:41:14 EDT --- (In reply to comment #4) (In reply to comment #2) Done. I'll post the new spec after you have reviewed other stuff as well. What other stuff are you referring to? Anwthing else than bug # 498246? No, I was thinking that I'd belay posting a new spec until you have done the review, then I could have fixed everything at once. However I've now posted a new specsrpm which update the desktop database (and add the mime types as well). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 501006] Review Request: xine-ui - A skinned xlib-based gui for xine-lib
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501006 Jussi Lehtola jussi.leht...@iki.fi changed: What|Removed |Added Flag||fedora-cvs? --- Comment #13 from Jussi Lehtola jussi.leht...@iki.fi 2009-05-17 05:43:37 EDT --- True. Thanks for the review! New Package CVS Request === Package Name: xine-ui Short Description: A skinned xlib-based gui for xine-lib Owners: jussilehtola Branches: F-9 F-10 F-11 EL-5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 494197] Review Request: drascula-music - Background music for Drascula: The Vampire Strikes Back
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=494197 --- Comment #6 from Hans de Goede hdego...@redhat.com 2009-05-17 05:51:14 EDT --- (In reply to comment #5) The following items need to be addressed: 1. Is this really GPLv2+? the readme doesn't state so. Maybe the same mistake as in the drascula-international package? Ack, same mistake as drascula-international package, should have checked that while I was at it, sorry. Here is a new version with this fixed: Spec URL: http://people.atrpms.net/~hdegoede/drascula-music.spec SRPM URL: http://people.atrpms.net/~hdegoede/drascula-music-1.0-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491519] Review Request: openttd-opengfx - OpenGFX replacement graphics for OpenTTD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491519 Hans de Goede hdego...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #18 from Hans de Goede hdego...@redhat.com 2009-05-17 05:58:16 EDT --- (In reply to comment #17) It builds from source now: Great! http://koji.fedoraproject.org/koji/taskinfo?taskID=1358203 New SPEC: http://heffer.fedorapeople.org/review/openttd-opengfx.spec New SRPM: http://heffer.fedorapeople.org/review/openttd-opengfx-0-0.3.alpha4.2.fc11.src.rpm Full review done: Approved ! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491518] Review Request: openttd - Transport system simulation game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491518 Hans de Goede hdego...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491518] Review Request: openttd - Transport system simulation game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491518 Hans de Goede hdego...@redhat.com changed: What|Removed |Added CC||hdego...@redhat.com AssignedTo|nob...@fedoraproject.org|hdego...@redhat.com Flag||fedora-review? --- Comment #6 from Hans de Goede hdego...@redhat.com 2009-05-17 06:07:03 EDT --- (In reply to comment #5) Few notes about the package: - We must patch it to hide country flags from network server list I've asked them to replace them in graphics, but there is no guarantee that they will do it: https://secure.openttd.org/bugs/task/2771 Hmm, you write there: The reason behind this report is Fedora's policy of handling flags. They must be split (or removed completely) to a subpackage that is not installed by default. This was caused by some political case. Is this actual policy (as in written down somewhere and approved by Fesco) ? or just something which was decided adhoc somewhere ? - Please update it to 0.7.0-RC2. Ack. - Would be good to generate AI docs from src/ai/api/Doxyfile and put them to subpackage. This IMHO makes no sense, this is an internal API, which is not exported so no need to buid or include the docs. - Macros issue in opengfx package is not addressed. ?? As promised I will review this, but it looks like we first need to address the flags issue sigh, assigning to me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491519] Review Request: openttd-opengfx - OpenGFX replacement graphics for OpenTTD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491519 --- Comment #19 from Alexey Torkhov atork...@gmail.com 2009-05-17 06:13:18 EDT --- I'm suggesting to add %check that does checking that md5 sums in *.obg are correspondent to ones that were built by grfcodec. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491519] Review Request: openttd-opengfx - OpenGFX replacement graphics for OpenTTD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491519 --- Comment #21 from Felix Kaechele fe...@fetzig.org 2009-05-17 06:18:59 EDT --- Okay. I'll try implementing that and then put a new spec online before requesting CVS. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491519] Review Request: openttd-opengfx - OpenGFX replacement graphics for OpenTTD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491519 --- Comment #20 from Hans de Goede hdego...@redhat.com 2009-05-17 06:16:24 EDT --- (In reply to comment #19) I'm suggesting to add %check that does checking that md5 sums in *.obg are correspondent to ones that were built by grfcodec. That sounds like a good plan, yes, esp. wrt network play, Felix ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491518] Review Request: openttd - Transport system simulation game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491518 --- Comment #8 from Alexey Torkhov atork...@gmail.com 2009-05-17 06:18:54 EDT --- (In reply to comment #6) As promised I will review this, but it looks like we first need to address the flags issue sigh, assigning to me. I'm thinking, that we can just hide language column with flags. If such solution would be acceptable, I can come with a patch for it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 494197] Review Request: drascula-music - Background music for Drascula: The Vampire Strikes Back
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=494197 Felix Kaechele fe...@fetzig.org changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #7 from Felix Kaechele fe...@fetzig.org 2009-05-17 06:16:17 EDT --- Great! This package is APPROVED then as well. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491518] Review Request: openttd - Transport system simulation game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491518 --- Comment #7 from Alexey Torkhov atork...@gmail.com 2009-05-17 06:16:32 EDT --- (In reply to comment #6) Hmm, you write there: The reason behind this report is Fedora's policy of handling flags. They must be split (or removed completely) to a subpackage that is not installed by default. This was caused by some political case. Is this actual policy (as in written down somewhere and approved by Fesco) ? or just something which was decided adhoc somewhere ? The policy https://fedoraproject.org/wiki/TomCallaway/Flags was approved on one of FESCo meetings as per https://fedorahosted.org/fesco/ticket/110 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491518] Review Request: openttd - Transport system simulation game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491518 --- Comment #9 from Hans de Goede hdego...@redhat.com 2009-05-17 06:24:06 EDT --- (In reply to comment #7) (In reply to comment #6) Hmm, you write there: The reason behind this report is Fedora's policy of handling flags. They must be split (or removed completely) to a subpackage that is not installed by default. This was caused by some political case. Is this actual policy (as in written down somewhere and approved by Fesco) ? or just something which was decided adhoc somewhere ? The policy https://fedoraproject.org/wiki/TomCallaway/Flags was approved on one of FESCo meetings as per https://fedorahosted.org/fesco/ticket/110 Ah I wasn't aware of this policy, glad I mist the flame fest one that one :) (In reply to comment #8) (In reply to comment #6) As promised I will review this, but it looks like we first need to address the flags issue sigh, assigning to me. I'm thinking, that we can just hide language column with flags. If such solution would be acceptable, I can come with a patch for it. Would there then still be a way for the user to find out the server language from the pick a server UI ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491518] Review Request: openttd - Transport system simulation game
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491518
--- Comment #10 from Alexey Torkhov atork...@gmail.com 2009-05-17 06:34:25
EDT ---
(In reply to comment #6)
- Would be good to generate AI docs from src/ai/api/Doxyfile and put them to
subpackage.
This IMHO makes no sense, this is an internal API, which is not exported
so no need to buid or include the docs.
This is only script external API that is used by squirrel AI scripts. And it
could be used by AI writers as scripts are easily added as plugins.
- Macros issue in opengfx package is not addressed.
Macro usage is not consistent there - it is mixing rm and %{__rm} there for
instance. I think, all macros like %{__rm} should be replaced in favour of
simple commands.
(In reply to comment #9)
Ah I wasn't aware of this policy, glad I mist the flame fest one that one :)
Hehe.
(In reply to comment #8)
(In reply to comment #6)
As promised I will review this, but it looks like we first need to address
the flags issue sigh, assigning to me.
I'm thinking, that we can just hide language column with flags. If such
solution would be acceptable, I can come with a patch for it.
Would there then still be a way for the user to find out the server language
from the pick a server UI ?
Yes, when user clicks on individual server line, server language will be shown
on server details panel. But in such, there won't be simple way to fast search
for particular language - user will have to click on each server if he wants to
find server where is that particular language spoken.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491518] Review Request: openttd - Transport system simulation game
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491518
--- Comment #11 from Alexey Torkhov atork...@gmail.com 2009-05-17 07:02:19
EDT ---
(In reply to comment #10)
- Macros issue in opengfx package is not addressed.
Macro usage is not consistent there - it is mixing rm and %{__rm} there for
instance. I think, all macros like %{__rm} should be replaced in favour of
simple commands.
Oh, that was fixed in new srpms. I was looking at old spec link.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499394] Review Request: ampache - web based audio/video streaming application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499394 --- Comment #10 from Paulo Roma Cavalcanti pro...@gmail.com 2009-05-17 07:03:13 EDT --- (In reply to comment #9) Several of your install commands don't use -p and thus don't preserve timestamps. This can be done, but the files being installed are my own source. Additionally, your cp commands don't consistently use the same parameters, and while technically correct, may be something you want to look out, though it's certainly not a blocker, more of a style issue if anything. I used cp -a, which according to the manual, is the same as -cdpR Why are you deleting the man page? You just copied the file there just a few lines earlier The man page would go to the doc directory (/usr/share/doc/ampache). I just installed it in the appropriate place, /usr/share/man/man1/, and removed it to avoid the same file being in two different places. Furthermore, if I kept a copy in the doc dir, rpmlint would complain it is not compressed. [ke4...@nalleyt61 SPECS]$ rpmlint ./ampache.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [ke4...@nalleyt61 SPECS]$ rpmlint ../SRPMS/ampache-3.5-8.fc10.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [ke4...@nalleyt61 SPECS]$ rpmlint ../RPMS/noarch/ampache-3.5-8.fc10.noarch.rpm ampache.noarch: E: non-executable-script /usr/share/ampache/locale/base/gather-messages.sh 0644 ampache.noarch: W: non-standard-uid /var/log/ampache apache ampache.noarch: W: non-standard-gid /etc/ampache.cfg apache ampache.noarch: E: non-readable /etc/ampache.cfg 0640 1 packages and 0 specfiles checked; 2 errors, 2 warnings. The modules directory contains a lot of 3rd party packages, such as getid3 from http://getid3.sourceforge.net/ and pear xml rpc from http://pear.php.net/package/XML_RPC There appear to be plenty of these. Unfortunately the packaging guidelines don't permit including other software packages within a single package. Unfortunately this is a common problem with web applications since much of their target audience is shared hosting where the user doesn't have control over the host. If these already exist in fedora you can get either symlink or modify the source to look elsewhere. If they don't you'll need to get those packaged as well and symlink or modify source to point to them. I saw a similar issue with gallery2, which released a new version symlinked to php-Smarty. Well, I did not find getid3 in Fedora, and probably several of the others are not also. But to pack and review all of them should take ages to complete ... I am keeping ampache in ATrpms, and I have already incorporated almost all of your suggestions in the current release (I will just move the server root to /usr/share in the next release). Eventually, these applications will be packed (I can do some of them), and we can return to this review in the future. Thanks anyway. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481224] Review Request: rabbitmq-server - An AMQP server written in Erlang
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481224 --- Comment #22 from Peter Lemenkov lemen...@gmail.com 2009-05-17 07:29:29 EDT --- (In reply to comment #21) But after discussion about the requirement for a -devel package with the rabbitmq development team, we are reluctant to split the package in this way. While the rabbitmq server can run without the .hrl files, they have uses that are not restricted to development activities: They are useful to allow interaction with the server at the erlang command line, for administration and monitoring. So we don't believe that they fall into the same category as the header files of a library, as described in the Devel packages section of the packaging guidelines. The problem is that we (I mean people, who interested in getting more erlang software into Fedora/EPEL) still haven't a rules/policy for packaging erlang applications and libraries. Among (still very few) erlang-related packages in Fedora/EPEL, some packaged splitted into main and *-devel subpackage, while others - not (erlang itself). After some thinking about this issue, I finally agreed with you - we should bundle hrl-files with main package, and this mine request should be ignored. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491518] Review Request: openttd - Transport system simulation game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491518 --- Comment #12 from Hans de Goede hdego...@redhat.com 2009-05-17 07:47:19 EDT --- (In reply to comment #10) (In reply to comment #6) - Would be good to generate AI docs from src/ai/api/Doxyfile and put them to subpackage. This IMHO makes no sense, this is an internal API, which is not exported so no need to buid or include the docs. This is only script external API that is used by squirrel AI scripts. And it could be used by AI writers as scripts are easily added as plugins. Ah, ok then indeed it would be good to package this in a sub-package. (In reply to comment #8) (In reply to comment #6) As promised I will review this, but it looks like we first need to address the flags issue sigh, assigning to me. I'm thinking, that we can just hide language column with flags. If such solution would be acceptable, I can come with a patch for it. Would there then still be a way for the user to find out the server language from the pick a server UI ? Yes, when user clicks on individual server line, server language will be shown on server details panel. But in such, there won't be simple way to fast search for particular language - user will have to click on each server if he wants to find server where is that particular language spoken. Hmm, not ideal but I guess just hiding the flags column in the UI is an ok solution then. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 494197] Review Request: drascula-music - Background music for Drascula: The Vampire Strikes Back
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=494197 Hans de Goede hdego...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from Hans de Goede hdego...@redhat.com 2009-05-17 07:50:27 EDT --- New Package CVS Request === Package Name: drascula-music Short Description: Background music for Drascula: The Vampire Strikes Back Owners:jwrdegoede Branches: F-11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491518] Review Request: openttd - Transport system simulation game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491518 --- Comment #13 from Felix Kaechele fe...@fetzig.org 2009-05-17 07:56:04 EDT --- Okay. Here's something to play with: 0.7.1-RC1 I added the docs tarball from upstream and put it in the package as a docs subpackage. It should contain everything that is needed to develop OTTD addons such as AI etc. SPEC: http://heffer.fedorapeople.org/review/openttd.spec SRPM: http://heffer.fedorapeople.org/review/openttd-0.7.1-0.1.rc1.fc11.src.rpm Alexey, if you had a patch for the flag issue that would be awesome. BTW: I updated the opengfx spec to match the one that is in the srpm. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476398] Review Request: eclib - A Library for Doing Computations on Elliptic Curves
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476398 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Flag||needinfo?(al...@users.sourc ||eforge.net) --- Comment #45 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-05-17 08:10:45 EDT --- Alex, ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 497441] Review Request: mumble - Voice chat application
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=497441
--- Comment #64 from Igor Jurišković juriskovic.i...@gmail.com 2009-05-17
08:18:53 EDT ---
(In reply to comment #62)
Created an attachment (id=344291)
-- (https://bugzilla.redhat.com/attachment.cgi?id=344291) [details]
Patch to compile on dist-f10-updates-candidate
For -10:
* BR
- BR: qt3-sqlite should not be needed. This uses Qt4, not
Qt3.
I uploaded wrong spec file. It was already removed at the time you wrote this.
* About mumble-server user directory
- Well, -d %{buildroot}%{_datadir}/%{name}/ is definitely wrong,
this directory should be used only when building this package.
I would suggest -d %{_localstatedir}/lib/mumble-server/
Done.
* Requires
- Needed Requires(pre) or so are still missing for murmur subpackage:
https://fedoraproject.org/wiki/Packaging/SysVInitScript#Initscripts_in_spec_file_scriptlets
Done.
* Build failure
- The attached patch will make this package compile on
F-11/F-10 (F-12 not checked)
http://koji.fedoraproject.org/koji/taskinfo?taskID=1358131
http://koji.fedoraproject.org/koji/taskinfo?taskID=1358127
Included.
* Devel files in main package
--
ln -s %{_libdir}/libmumble.so.%{version} %{buildroot}%{_libdir}/libmumble.so
--
- I guess %_libdir/libmumble.so is not needed.
It is needed. Mumble will complain loudly if it cant find libmumble.so.
Thorvald said this few post back.
Note that rpmlint warns about this:
--
mumble.i586: W: devel-file-in-non-devel-package /usr/lib/libmumble.so
--
* Service enabled by default
--
murmur.i586: W: service-default-enabled /etc/rc.d/init.d/murmur
--
- Installing murmur package enables murmur service by default
on level 345:
--
# chkconfig --list murmur
murmur 0:off 1:off 2:off 3:on 4:on 5:on 6:off
--
These should be disabled by default.
In murmur init script, # Default-Start: item should have no
level.
Fixed.
* Init script fix
--
diff -uN mumble-1.1.8-9.fc9.src/murmur.init
mumble-1.1.8-10.fc10.src/murmur.init
--- mumble-1.1.8-9.fc9.src/murmur.init 2009-04-30 01:03:18.0 +0900
+++ mumble-1.1.8-10.fc10.src/murmur.init2009-05-15 08:32:48.0
+0900
@@ -52,7 +52,7 @@
RETVAL=$?
echo
if [ $RETVAL -eq 0 ]; then
- /bin/rm -f $lockfile $pidfile 2 /dev/null success ||
failure
+ /bin/rm -f $lockfile $pidfile 2 /dev/null || failure
fi
}
--
- I guess || failure can also be removed.
This was already changed at the time you wrote this. I accidently uploaded
wrong spec and srpm.
* undefined non-weak symbols
--
mumble.i586: W: undefined-non-weak-symbol /usr/lib/libmumble.so.1.1.8
glAttachShader
mumble.i586: W: undefined-non-weak-symbol /usr/lib/libmumble.so.1.1.8 glEnable
mumble.i586: W: undefined-non-weak-symbol /usr/lib/libmumble.so.1.1.8
glTexCoordPointer
(and so many)
--
- libmumble.so has undefined non-weak symbols. As
this package does not provide -devel subpackage, currently this
can be ignored, however it is preferable that this issue
is fixed.
! You can also check this issue by
$ ldd -r /usr/lib/libmumble.so.1 /dev/null
This can be fixed by making libmumble.so linked against libGL.so.
Thorvald answered this. I'm leaving this as is.
* Permission
--
install -pD -m0664 man/murmurd.1 %{buildroot}%{_mandir}/man1/
install -pD -m0664 man/mumble* %{buildroot}%{_mandir}/man1/
--
- These should be 0644 permission
Again, wrong spec file. :(
(In reply to comment #60)
* Installation directory
--
install -pD -m0755 release/murmurd %{buildroot}%{_sbindir}/murmurd
ln -s ../sbin/murmurd %{buildroot}%{_bindir}/%{name}-server
--
[Bug 446841] Review Request: python-sippy - B2BUA SIP call controlling component
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=446841
--- Comment #12 from Peter Lemenkov lemen...@gmail.com 2009-05-17 08:37:18
EDT ---
(In reply to comment #11)
OK, this does build on F11, rpmlint is clean, the versioning is proper and
%description looks OK to me. However, you still have the conditional
%if 0%{?fedora} = 8
which will always be satisfied. Is there some reason you can't remove that?
It will not help your epel builds, because %fedora is never defined there.
I just revised this spec-file and found that the requirement for
python-setuptools is superfluous - I removed it (along with pkgconfig - another
leftover)
Koji scratch builds for F-11 and EL-5
http://koji.fedoraproject.org/koji/taskinfo?taskID=1358724
http://koji.fedoraproject.org/koji/taskinfo?taskID=1358726
http://peter.fedorapeople.org/python-sippy.spec
http://peter.fedorapeople.org/python-sippy-0-0.8.20090429cvs.fc10.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 497572] Review Request: peppy - Editor written in python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497572 Jonathan Underwood jonathan.underw...@gmail.com changed: What|Removed |Added CC||jonathan.underw...@gmail.co ||m --- Comment #18 from Jonathan Underwood jonathan.underw...@gmail.com 2009-05-17 08:36:22 EDT --- On F-10, after installation of peppy-0.9.27-3.fc10.noarch $ peppy Traceback (most recent call last): File /usr/bin/peppy, line 13, in module import peppy.main File /usr/lib/python2.5/site-packages/peppy/main.py, line 10, in module import wx ImportError: No module named wx This is due to a missing Requires: wxPython Jussi: when doing a review, it's always worth installing a package into a chroot to see if it runs properly and pulls in all the correct packages and no more. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 497572] Review Request: peppy - Editor written in python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497572 --- Comment #19 from Jonathan Underwood jonathan.underw...@gmail.com 2009-05-17 08:38:47 EDT --- Also, there's a newer upstream version peppy-0.9.86.tar.bz2 - it'd be nice to update the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 497572] Review Request: peppy - Editor written in python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497572 --- Comment #20 from Jussi Lehtola jussi.leht...@iki.fi 2009-05-17 09:07:51 EDT --- (In reply to comment #19) Also, there's a newer upstream version peppy-0.9.86.tar.bz2 - it'd be nice to update the package. $ HEAD http://peppy.flipturn.org/archive/peppy-0.9.86.tar.bz2 reports Last-Modified: Thu, 14 May 2009 18:19:31 GMT so the new version has been released only a couple of days ago. (In reply to comment #18) On F-10, after installation of peppy-0.9.27-3.fc10.noarch $ peppy Traceback (most recent call last): File /usr/bin/peppy, line 13, in module import peppy.main File /usr/lib/python2.5/site-packages/peppy/main.py, line 10, in module import wx ImportError: No module named wx This is due to a missing Requires: wxPython ?? peppy-0.9.27-3 already Requires: wxPython. For me it works fine. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491518] Review Request: openttd - Transport system simulation game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491518 --- Comment #14 from Alexey Torkhov atork...@gmail.com 2009-05-17 09:17:38 EDT --- (In reply to comment #13) I added the docs tarball from upstream and put it in the package as a docs subpackage. It should contain everything that is needed to develop OTTD addons such as AI etc. Seems, docs tarball they distribute is documentation for whole internal API. And we want only docs for AI API. It is simple to generate, just call doxygen from src/ai/api dir (doxygen should be in BR). Alexey, if you had a patch for the flag issue that would be awesome. The simplest patch I used is just hiding flag: http://atorkhov.fedorapeople.org/openttd-0.7.0-hide-flag.patch The idea of representing languages by two-letter ISO codes does not work well is this case - they have Brazilian and Portuguese languages/flags but it will be represented by pt code. It should be either long code pt_BR/pt_PT which is not very good for users, or some shortening of full language name. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 497572] Review Request: peppy - Editor written in python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497572 --- Comment #21 from Jonathan Underwood jonathan.underw...@gmail.com 2009-05-17 09:21:04 EDT --- # yum --enablerepo=updates-testing install peppy Loaded plugins: fastestmirror, refresh-packagekit Loading mirror speeds from cached hostfile * updates-testing: ftp.esat.net * rpmfusion-nonfree-updates: fr2.rpmfind.net * fedora: ftp.esat.net * rpmfusion-free-updates: fr2.rpmfind.net * rpmfusion-free: fr2.rpmfind.net * updates: ftp.esat.net * rpmfusion-nonfree: fr2.rpmfind.net updates-testing | 3.0 kB 00:00 updates-testing/primary_db | 510 kB 00:01 Setting up Install Process Parsing package install arguments Resolving Dependencies -- Running transaction check --- Package peppy.noarch 0:0.9.27-3.fc10 set to be updated -- Processing Dependency: python-enchant for package: peppy -- Running transaction check --- Package python-enchant.x86_64 0:1.3.1-2.fc9 set to be updated -- Finished Dependency Resolution Dependencies Resolved Package ArchVersion RepositorySize Installing: peppy noarch 0.9.27-3.fc10 updates-testing 1.8 M Installing for dependencies: python-enchant x86_64 1.3.1-2.fc9 fedora 107 k Transaction Summary Install 2 Package(s) Update 0 Package(s) Remove 0 Package(s) Total download size: 1.9 M Is this ok [y/N]: y Downloading Packages: (1/2): python-enchant-1.3.1-2.fc9.x86_64.rpm | 107 kB 00:00 (2/2): peppy-0.9.27-3.fc10.noarch.rpm| 1.8 MB 00:02 Total 655 kB/s | 1.9 MB 00:02 Running rpm_check_debug Running Transaction Test Finished Transaction Test Transaction Test Succeeded Running Transaction Installing : python-enchant 1/2 Installing : peppy2/2 Installed: peppy.noarch 0:0.9.27-3.fc10 Dependency Installed: python-enchant.x86_64 0:1.3.1-2.fc9 Complete! [r...@m1210 jgu]# exit exit [...@m1210 ~]$ [...@m1210 ~]$ [...@m1210 ~]$ peppy Traceback (most recent call last): File /usr/bin/peppy, line 13, in module import peppy.main File /usr/lib/python2.5/site-packages/peppy/main.py, line 10, in module import wx ImportError: No module named wx So, for whatever reason, it doesn't pull in wxPython. $ rpm -q --requires peppy /usr/bin/env /usr/bin/python python(abi) = 2.5 python-enchant rpmlib(CompressedFileNames) = 3.0.4-1 rpmlib(PartialHardlinkSets) = 4.0.4-1 rpmlib(PayloadFilesHavePrefix) = 4.0-1 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 497572] Review Request: peppy - Editor written in python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497572 --- Comment #22 from Jonathan Underwood jonathan.underw...@gmail.com 2009-05-17 09:31:23 EDT --- (In reply to comment #20) (In reply to comment #19) Also, there's a newer upstream version peppy-0.9.86.tar.bz2 - it'd be nice to update the package. $ HEAD http://peppy.flipturn.org/archive/peppy-0.9.86.tar.bz2 reports Last-Modified: Thu, 14 May 2009 18:19:31 GMT so the new version has been released only a couple of days ago. Yes, sure, was only mentioning it in passing for information, wasn't a criticism. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500926] Review Request: me-tv - GNOME desktop application for watching digital television
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500926 --- Comment #20 from Zarko (grof) zarko.pin...@gmail.com 2009-05-17 09:36:01 EDT --- Now, xine-ui going to Fedora, so I prepared me-tv to use xine-ui. http://wiki.open.hr/~zpintar/fedora10/SPECS/me-tv.spec http://wiki.open.hr/~zpintar/fedora10/SRPMS/me-tv-0.8.12-3.fc10.src.rpm Please, take a look. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 497572] Review Request: peppy - Editor written in python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497572 --- Comment #23 from Fedora Update System upda...@fedoraproject.org 2009-05-17 10:01:13 EDT --- peppy-0.9.86-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/peppy-0.9.86-1.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 497572] Review Request: peppy - Editor written in python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497572 --- Comment #24 from Fedora Update System upda...@fedoraproject.org 2009-05-17 10:06:22 EDT --- peppy-0.9.86-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/peppy-0.9.86-1.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459874] Review Request: zeromq - Fast messaging system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459874 --- Comment #22 from Peter Lemenkov lemen...@gmail.com 2009-05-17 10:40:32 EDT --- I'll try to find why it's failed to build in F-11. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 497572] Review Request: peppy - Editor written in python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497572 --- Comment #25 from Jussi Lehtola jussi.leht...@iki.fi 2009-05-17 10:52:20 EDT --- (In reply to comment #21) So, for whatever reason, it doesn't pull in wxPython. $ rpm -q --requires peppy /usr/bin/env /usr/bin/python python(abi) = 2.5 python-enchant rpmlib(CompressedFileNames) = 3.0.4-1 rpmlib(PartialHardlinkSets) = 4.0.4-1 rpmlib(PayloadFilesHavePrefix) = 4.0-1 True. This is quite odd. Anyway, the rpm of the new version requires wxPython, so it should work as expected. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476398] Review Request: eclib - A Library for Doing Computations on Elliptic Curves
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476398 Alex Lancaster al...@users.sourceforge.net changed: What|Removed |Added Flag|fedora-review?, |fedora-review+ |needinfo?(al...@users.sourc | |eforge.net) | --- Comment #46 from Alex Lancaster al...@users.sourceforge.net 2009-05-17 10:52:12 EDT --- koji scratch build for F-11: http://koji.fedoraproject.org/koji/taskinfo?taskID=1358794 -static subpackage now appears to pass rpmlint tests: $ rpmlint eclib-20080310-7.p7.fc11.i586.rpm eclib-devel-20080310-7.p7.fc11.i586.rpm eclib-static-20080310-7.p7.fc11.i586.rpm eclib.i586: W: shared-lib-calls-exit /usr/lib/librankntl.so.20080310 e...@glibc_2.0 eclib-devel.i586: W: no-documentation eclib-static.i586: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 3 warnings. So, marking this as APPROVED. (The rawhide/F-12 fails to build because of issues with the dependent packages like pari-devel not yet being rebuilt: http://koji.fedoraproject.org/koji/taskinfo?taskID=1358789 this will probably go away soon, and shouldn't hold up building the package, even if only for F-11/F-10 initially). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476398] Review Request: eclib - A Library for Doing Computations on Elliptic Curves
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476398 --- Comment #47 from Michael Schwendt bugs.mich...@gmx.net 2009-05-17 12:15:49 EDT --- No, ntl in devel now builds a shared lib and no ntl-static anymore: http://koji.fedoraproject.org/koji/buildinfo?buildID=98367 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500437] Review Request: cnetworkmanager - Command-line client for NetworkManager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500437 --- Comment #13 from Kevin Fenzi ke...@tummy.com 2009-05-17 12:42:10 EDT --- Hey Jochen: What blockers for approval remain? Let me know and I will try and get them fixed up. Thanks again for reviewing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 497572] Review Request: peppy - Editor written in python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497572 --- Comment #26 from Jonathan Underwood jonathan.underw...@gmail.com 2009-05-17 13:46:22 EDT --- Can confirm that packages fixes the Reequires: # rpm -Uvh peppy-0.9.86-1.fc10.noarch.rpm Preparing...### [100%] 1:peppy ### [100%] [r...@m1210 ~]# rpm -q --requires peppy /usr/bin/env /usr/bin/python python(abi) = 2.5 python-enchant rpmlib(CompressedFileNames) = 3.0.4-1 rpmlib(PartialHardlinkSets) = 4.0.4-1 rpmlib(PayloadFilesHavePrefix) = 4.0-1 wxPython Thanks much. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500437] Review Request: cnetworkmanager - Command-line client for NetworkManager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500437 --- Comment #14 from Jochen Schmitt joc...@herr-schmitt.de 2009-05-17 14:10:14 EDT --- The blocker is the issue reported on comment #12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500437] Review Request: cnetworkmanager - Command-line client for NetworkManager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500437 Milos Jakubicek xja...@fi.muni.cz changed: What|Removed |Added CC||xja...@fi.muni.cz --- Comment #15 from Milos Jakubicek xja...@fi.muni.cz 2009-05-17 14:38:47 EDT --- Jochen, the problem described in comment #12 is really not related to packaging (I wouldn't even call it a bug, if you have a cli for NM and you don't run NM, it is obvious that you get an error NM is not running:), please don't delay the review because of this -- thank you very much in advance...! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500437] Review Request: cnetworkmanager - Command-line client for NetworkManager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500437 Jochen Schmitt joc...@herr-schmitt.de changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #16 from Jochen Schmitt joc...@herr-schmitt.de 2009-05-17 14:43:13 EDT --- OK, I will APPROVE your package. But in may be nice, if you can create a new release of the application which show a better error message in this case bacause the error message which I have got is not very helpful for an user. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 458090] Review Request: LuxRender - Lux Renderer, an unbiased rendering system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458090 --- Comment #34 from Jochen Schmitt joc...@herr-schmitt.de 2009-05-17 14:46:32 EDT --- I have build the -22 release for F-11 and F-10. It will be nice, if you can bundeled it which your update request. At least I want to offer you the co-maintainership for blender if you want. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226508] Merge Review: tvtime
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226508 Jussi Lehtola jussi.leht...@iki.fi changed: What|Removed |Added Status|NEW |ASSIGNED CC||jussi.leht...@iki.fi AssignedTo|nob...@fedoraproject.org|jussi.leht...@iki.fi Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498073] Review Request: python-ekg - Community Health Reporter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498073 --- Comment #4 from Yaakov Nemoy loupgaroubl...@gmail.com 2009-05-17 15:19:23 EDT --- BTW, to anyone declaring intent to review, there is a new version upstream, ping here to let me know to upload the latest upstream. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226508] Merge Review: tvtime
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226508 --- Comment #2 from Jussi Lehtola jussi.leht...@iki.fi 2009-05-17 15:31:51 EDT --- Created an attachment (id=344353) -- (https://bugzilla.redhat.com/attachment.cgi?id=344353) Patch to fix desktop file install and rpmlint warnings -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226508] Merge Review: tvtime
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226508 Jussi Lehtola jussi.leht...@iki.fi changed: What|Removed |Added CC|t...@redhat.com |kars...@redhat.com, ||tsmet...@redhat.com --- Comment #3 from Jussi Lehtola jussi.leht...@iki.fi 2009-05-17 15:34:59 EDT --- Apply the patch above to devel branch and make build; then I'll do a full review. Also, please fix the source URL: prdownloads.sourceforge.net should be downloads.sourceforge.net -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 490354] Review Request: emacs-elib - The Emacs Lisp Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490354 Jochen Schmitt joc...@herr-schmitt.de changed: What|Removed |Added Status|NEW |ASSIGNED CC||joc...@herr-schmitt.de Flag||fedora-review? --- Comment #1 from Jochen Schmitt joc...@herr-schmitt.de 2009-05-17 15:33:36 EDT --- Good: + Package name matches naming guildlines + Buildroot will be cleaned at the beginning of %clean and %install * Specification of the Buildroot is ok. Bad: - Basename of the SPEC file doesn't machtes package name - URL doesn't shows on proper project homepage - Source doesn't contains full qualified URL - Please change BuildArchitecures into BuildArch: - Source are not in separe el subpackage (/Packaging/Emacs#Packaging_of_source_elisp_files) - Specification of the installation destination on fullfill Emace Packaging guulldline (/Packaging/Emacs#GNU_Emacs) - Package doesn't contains correct Changelog you have to specified version-release on it Your package seems to need a lot of love. I want to suggest that you should read the packaging guildlines and the guildlines for emacs packages carefully. If you can demonstrate in your next approach, that you have understand this guildlines, I may be willing to sponsor you. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 501130] Review Request: drbdlinks - A program for managing links into a DRBD shared partition
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=501130
Jochen Schmitt joc...@herr-schmitt.de changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||joc...@herr-schmitt.de
Flag||fedora-review?
--- Comment #2 from Jochen Schmitt joc...@herr-schmitt.de 2009-05-17
16:07:26 EDT ---
Good:
+ Basename of the SPEC file matches with package name.
+ Name of the package fullfill naming guildines.
+ Package has proper RPM-group
+ URL tag show on proper project homepage
+ Package contains most recent release of the software
+ Could download upstream tar ball via spectool -g
+ Package tar ball matches with upstream
(md5sum: c11b38dfa60d8d07b55746a957b48b19 )
* Package contains valid License tag
+ License tag state GPLv2 as an valid OSS license
+ Header of the source file has GPLv2 license note
+ Package has verbatin copy of the license text
+ Package has proper defintion of the Buildroot
+ Buildroot will be cleaned at the beginning of %clean and %install
+ %doc stanza is small, so we need no extra doc subpackage
+ Package contains proper Changelog
+ Local build works fine
+ Rpmlint is quiete on source rpm
+ Koji build works fine.
Bad:
- Initscripts should be install on %{_initrddir}
(Unproper usage of rpm macros)
- don't put a file on %{_localstatedir}/run.
you should only create a directory on it
- Who should owned %{_sysconfdir}/ha.d ?
- Rpmlint complaints on binary rpm:
$ rpmlint drbdlinks-1.16-1.fc10.noarch.rpm
drbdlinks.noarch: W: missing-lsb-keyword Default-Stop in
/etc/rc.d/init.d/drbdlinksclean
drbdlinks.noarch: E: subsys-not-used /etc/rc.d/init.d/drbdlinksclean
drbdlinks.noarch: W: incoherent-init-script-name drbdlinksclean
1 packages and 0 specfiles checked; 1 errors, 2 warnings.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 501130] Review Request: drbdlinks - A program for managing links into a DRBD shared partition
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=501130
--- Comment #3 from Robert Scheck redhat-bugzi...@linuxnetz.de 2009-05-17
16:17:11 EDT ---
(In reply to comment #2)
- Initscripts should be install on %{_initrddir}
(Unproper usage of rpm macros)
I want to package drbdlinks for all active branches and this is only possible
without macro usage currently, look for %{_initrddir} vs. %{_initdir} or so.
- don't put a file on %{_localstatedir}/run.
you should only create a directory on it
Upstream initscript doesn't do that as well. And drbdlinks isn't a daemon. It
also can be triggered by heartbeat. Thus /var/run doesn't make sense.
- Who should owned %{_sysconfdir}/ha.d ?
Heartbeat owns that directory. But heartbeat is optional, drbdlinks can be
used with and without.
drbdlinks.noarch: W: missing-lsb-keyword Default-Stop in
/etc/rc.d/init.d/drbdlinksclean
If no Default-Start, no Default-Stop. The line has not to exist, if it is
not filled, IIRC.
drbdlinks.noarch: E: subsys-not-used /etc/rc.d/init.d/drbdlinksclean
drbdlinks.noarch: W: incoherent-init-script-name drbdlinksclean
As explained above.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500242] Pre-Review Request: maven-wagon - Tools to manage artifacts and deployment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500242 Fernando Nasser fnas...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Fernando Nasser fnas...@redhat.com 2009-05-17 21:22:06 EDT --- New Package CVS Request === Package Name: maven-wagon Short Description: Tools to manage artifacts and deployment Owners: fnasser, dbhole Branches: devel InitialCC: jkeating -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500243] Pre-Review Request: saxpath - Simple API for XPath
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500243 --- Comment #9 from Fernando Nasser fnas...@redhat.com 2009-05-17 21:26:53 EDT --- New Package CVS Request === Package Name: saxpath Short Description: Simple API for XPath Owners: fnasser, dbhole Branches: devel InitialCC: jkeating -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500245] Pre-Review Request: aqute-bndlib - BND Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500245 Fernando Nasser fnas...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Fernando Nasser fnas...@redhat.com 2009-05-17 21:24:20 EDT --- New Package CVS Request === Package Name: aqute-bndlib Short Description: BND Library Owners: fnasser, dbhole Branches: devel InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500245] Pre-Review Request: aqute-bndlib - BND Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500245 --- Comment #3 from Fernando Nasser fnas...@redhat.com 2009-05-17 21:37:19 EDT --- Oops! InitialCC: jkeating -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500247] Pre-Review Request: plexus-containers - Containers for Plexus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500247 Fernando Nasser fnas...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Fernando Nasser fnas...@redhat.com 2009-05-17 21:38:59 EDT --- New Package CVS Request === Package Name: plexus-containers Short Description: Containers for Plexus Owners: fnasser, dbhole Branches: devel InitialCC: jkeating -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500246] Pre-Review Request: plexus-classworlds - Plexus Classworlds Classloader Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500246 Fernando Nasser fnas...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #14 from Fernando Nasser fnas...@redhat.com 2009-05-17 21:36:18 EDT --- New Package CVS Request === Package Name: plexus-classworlds Short Description: Plexus Classworlds Classloader Framework Owners: fnasser, dbhole Branches: devel InitialCC: jkeating -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500251] Pre-Review Request: dumbster - Fake SMTP Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500251 --- Comment #5 from Fernando Nasser fnas...@redhat.com 2009-05-17 23:30:18 EDT --- Fixed license. Changed spec file so that it uses export from the RELEASE_1_6 tag. Replaced the source tar ball with that. Spec URL: http://people.fedoraproject.org/~fnasser/dumbster.spec SRPM URL: http://people.fedoraproject.org/~fnasser/dumbster-1.6-7.jpp6.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500249] Pre-Review Request: plexus-digest - Plexus Digest / Hashcode Components
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500249 --- Comment #2 from Fernando Nasser fnas...@redhat.com 2009-05-17 22:08:40 EDT --- Spec URL: http://people.fedoraproject.org/~fnasser/plexus-digest.spec SRPM URL: http://people.fedoraproject.org/~fnasser/plexus-digest-1.0-8.jpp6.src.rpm Thanks for the pre-review! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500252] Pre-Review Request: plexus-mail-sender - Plexus Archiver Component
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500252 --- Comment #6 from Fernando Nasser fnas...@redhat.com 2009-05-17 22:36:45 EDT --- It seems most files have the MIT license, 4 have the ASL 2.0 license and this one, even in the last tag http://svn.codehaus.org/plexus/tags/plexus-mail-sender-1.0-alpha-7/plexus-mail-sender-api/src/main/java/org/codehaus/plexus/mailsender/util/DateFormatUtils.java does not have one. It is a very small (2-line) utility class and I counted 6 references. We could try and patch it out but the lines added will have to be identical to these two lines we are suppressing -- I can't see a different way to do this in Java. There are java source files in the plexus stuff everywhere BTW, they should be covered by: http://plexus.codehaus.org/get-involved.html which is the official project header that should be added to every file. I don't know if Deepak would be able to convince maven to build without this plexus-mail-sender thing. So I fixed the License to: MIT, ASL 2.0 and Plexus and re-uploaded: Spec URL: http://people.fedoraproject.org/~fnasser/plexus-mail-sender.spec SRPM URL: http://people.fedoraproject.org/~fnasser/plexus-mail-sender-1.0-0.a2.8.jpp6.src.rpm Does it help? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500253] Pre-Review Request: directory-naming - Directory Naming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500253 Fernando Nasser fnas...@redhat.com changed: What|Removed |Added Flag||fedora-review? --- Comment #2 from Fernando Nasser fnas...@redhat.com 2009-05-17 23:36:48 EDT --- License fixed. Thanks for the pre-review! Spec URL: http://people.fedoraproject.org/~fnasser/directory-naming.spec SRPM URL: http://people.fedoraproject.org/~fnasser/directory-naming-0.8-4.jpp6.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500248] Pre-Review Request: plexus-cli - Command Line Interface facilitator for Plexus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500248 --- Comment #2 from Fernando Nasser fnas...@redhat.com 2009-05-17 22:02:29 EDT --- Sources moved upstream, fixed URL. Fixed license. Assuming the text below applies to the whole plexus project: http://plexus.codehaus.org/get-involved.html But the truth is, in this particular subproject that header is not to be found in any file. Sort of weird. Anyway, the new spec file is in place and the SRPM is now: SRPM URL: http://people.fedoraproject.org/~fnasser/plexus-cli-1.2-6.jpp6.src.rpm Thanks for catching the SVN URL problem. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500437] Review Request: cnetworkmanager - Command-line client for NetworkManager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500437 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #17 from Kevin Fenzi ke...@tummy.com 2009-05-18 00:06:32 EDT --- Thanks Jochen! New Package CVS Request === Package Name: cnetworkmanager Short Description: Command-line client for NetworkManager Owners: kevin Branches: devel F-11 F-10 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 494197] Review Request: drascula-music - Background music for Drascula: The Vampire Strikes Back
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=494197 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #9 from Kevin Fenzi ke...@tummy.com 2009-05-18 00:17:10 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 494199] Review Request: drascula-international - Subtitles for Drascula: The Vampire Strikes Back
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=494199 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #10 from Kevin Fenzi ke...@tummy.com 2009-05-18 00:18:54 EDT --- cvs done. (The music was only branched for devel/F-11, did you mean for there to be a F-10 in that request as well?) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500245] Pre-Review Request: aqute-bndlib - BND Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500245 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #4 from Kevin Fenzi ke...@tummy.com 2009-05-18 00:21:55 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500246] Pre-Review Request: plexus-classworlds - Plexus Classworlds Classloader Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500246 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #15 from Kevin Fenzi ke...@tummy.com 2009-05-18 00:23:35 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500242] Pre-Review Request: maven-wagon - Tools to manage artifacts and deployment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500242 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #7 from Kevin Fenzi ke...@tummy.com 2009-05-18 00:20:04 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 501006] Review Request: xine-ui - A skinned xlib-based gui for xine-lib
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501006 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #14 from Kevin Fenzi ke...@tummy.com 2009-05-18 00:27:16 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500437] Review Request: cnetworkmanager - Command-line client for NetworkManager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500437 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #18 from Kevin Fenzi ke...@tummy.com 2009-05-18 00:26:13 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500247] Pre-Review Request: plexus-containers - Containers for Plexus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500247 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #5 from Kevin Fenzi ke...@tummy.com 2009-05-18 00:24:43 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 501099] Review Request: perl-XML-Feed - Syndication feed parser and auto-discovery
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501099 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #1 from Parag AN(पराग) panem...@gmail.com 2009-05-18 00:33:07 EDT --- Review: + package builds in mock (rawhide i586). koji Build = http://koji.fedoraproject.org/koji/taskinfo?taskID=1357657 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 04d0c175f9bbabc8ba8373d2d6b6ed338bacaab2 XML-Feed-0.43.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=21, Tests=378, 7 wallclock secs ( 0.10 usr 0.04 sys + 6.04 cusr 0.63 csys = 6.81 CPU) + Packageperl-XML-Feed-0.43-1.fc12.noarch = Provides: perl(XML::Feed) = 0.43 perl(XML::Feed::Content) perl(XML::Feed::Enclosure) perl(XML::Feed::Entry) perl(XML::Feed::Entry::Format::Atom) perl(XML::Feed::Entry::Format::RSS) perl(XML::Feed::Format::Atom) perl(XML::Feed::Format::RSS) Requires: perl(Carp) perl(DateTime::Format::Mail) perl(DateTime::Format::W3CDTF) perl(Feed::Find) perl(LWP::UserAgent) perl(List::Util) perl(Module::Pluggable) perl(Scalar::Util) perl(URI::Fetch) perl(XML::Atom::Content) perl(XML::Atom::Entry) perl(XML::Atom::Feed) perl(XML::Atom::Util) perl(XML::Feed::Content) perl(base) perl(strict) + Not a GUI application APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 501098] Review Request: perl-XML-RSS-LibXML - XML::RSS with XML::LibXML
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501098 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #1 from Parag AN(पराग) panem...@gmail.com 2009-05-18 00:33:25 EDT --- Review: + package builds in mock (rawhide i586). koji Build = http://koji.fedoraproject.org/koji/taskinfo?taskID=1357637 + rpmlint is silent for SRPM and for RPM. + source files match upstream url a44ad501b84d1fd31c4d77e80fdd927f67ebc5aa XML-RSS-LibXML-0.3004.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=34, Tests=701, 8 wallclock secs ( 0.06 usr 0.05 sys + 7.53 cusr 0.62 csys = 8.26 CPU) + Package perl-XML-RSS-LibXML-0.3004-1.fc12.noarch = Provides: perl(XML::RSS::LibXML) = 0.3004 perl(XML::RSS::LibXML::ImplBase) perl(XML::RSS::LibXML::MagicElement) = 0.02 perl(XML::RSS::LibXML::Namespaces) perl(XML::RSS::LibXML::Null) perl(XML::RSS::LibXML::V0_9) perl(XML::RSS::LibXML::V0_91) perl(XML::RSS::LibXML::V1_0) perl(XML::RSS::LibXML::V2_0) Requires: perl(Carp) perl(DateTime::Format::Mail) perl(DateTime::Format::W3CDTF) perl(UNIVERSAL::require) perl(XML::LibXML) perl(XML::LibXML::XPathContext) perl(XML::RSS::LibXML::MagicElement) perl(XML::RSS::LibXML::Namespaces) perl(base) perl(overload) perl(strict) perl(vars) perl(warnings) + Not a GUI application APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500437] Review Request: cnetworkmanager - Command-line client for NetworkManager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500437 --- Comment #19 from Fedora Update System upda...@fedoraproject.org 2009-05-18 01:09:23 EDT --- cnetworkmanager-0.8.4-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/cnetworkmanager-0.8.4-2.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500437] Review Request: cnetworkmanager - Command-line client for NetworkManager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500437 --- Comment #20 from Fedora Update System upda...@fedoraproject.org 2009-05-18 01:18:40 EDT --- cnetworkmanager-0.8.4-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/cnetworkmanager-0.8.4-2.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 501223] New: Review Request: tuxmath - Educational math tutor for children
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: tuxmath - Educational math tutor for children https://bugzilla.redhat.com/show_bug.cgi?id=501223 Summary: Review Request: tuxmath - Educational math tutor for children Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: jo...@x-tnd.be QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora SPEC URL: http://rpms.ulysses.fr/SPECS/tuxmath.spec SRPM URL: http://rpms.ulysses.fr/SRPMS/tuxmath-1.7.2-1.fc10.src.rpm Description: An educational math software for children, just like TuxTyping for words :) rpmlint on SRPM is clean. rpmlint on RPM gives: tuxmath.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/tuxmath-1.7.2/OFL.txt I think we can ignore the rpmlint here. Package builds fine in mock under F-10 for both F-10 and F-9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 497283] Review Request: perl-Syntax-Highlight-Engine-Kate - Port to Perl of the syntax highlight engine of the Kate texteditor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497283 Marcela Maslanova mmasl...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 500959] Review Request: perl-Task-Padre-Plugin-Deps - Task::Padre::Plugin::Deps Perl module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=500959 Bug 500959 depends on bug 497283, which changed state. Bug 497283 Summary: Review Request: perl-Syntax-Highlight-Engine-Kate - Port to Perl of the syntax highlight engine of the Kate texteditor https://bugzilla.redhat.com/show_bug.cgi?id=497283 What|Old Value |New Value Resolution||RAWHIDE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 498204] Review Request: perl-Wx-Perl-DataWalker - implement subclass that shows relatively simple structure
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498204 Marcela Maslanova mmasl...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
