[Bug 472639] Review Request: Scilab - Numerical Analysis toolkit

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472639


Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

Version|9   |rawhide




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 495322] Review Request: python-cmd2 - Enhancements for Python's cmd module

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495322


Silas Sewell si...@sewell.ch changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||WONTFIX




--- Comment #5 from Silas Sewell si...@sewell.ch  2009-06-10 02:00:18 EDT ---
I've decided to use python-cly and I'm not interested in pursuing this package.

I'll keep the SRPM/SPEC available if anyone would like to take it over.

Closing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 504746] Review Request: perl-Text-PDF - Module for manipulating PDF files

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504746


Chris Weyl cw...@alumni.drew.edu changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Comment #5 from Chris Weyl cw...@alumni.drew.edu  2009-06-10 02:11:52 EDT 
---
Thanks for the review! :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 504736] Review Request: perl-File-ChangeNotify - Watch for changes to files, cross-platform style

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504736


Chris Weyl cw...@alumni.drew.edu changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Comment #6 from Chris Weyl cw...@alumni.drew.edu  2009-06-10 02:11:55 EDT 
---
Thanks for the review! :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 503336] Review Request: newsbeuter - console based feed reader

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503336


Jan Klepek jan.kle...@hp.com changed:

   What|Removed |Added

 CC||jan.kle...@hp.com




--- Comment #4 from Jan Klepek jan.kle...@hp.com  2009-06-10 02:15:49 EDT ---
Summary:The Mutt of Feed Readers

I don't think that this is good summary. 
Better would be imho Configurable text-based feed reader, because it much
more describe what is content of package. The Mutt of Feed Readers tell
nothing to somebody who doesn't know mutt (if you refer to mail client) and for
me it looks like commercial.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 501960] Review Request: webinject - Web/HTTP Test Tool

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=501960


Jan Klepek jan.kle...@hp.com changed:

   What|Removed |Added

 CC||jan.kle...@hp.com
 Depends on||501957




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 501957] Review Request: perl-Tk--ProgressBar-Mac - Mac ProgressBar for Perl::Tk

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=501957


Jan Klepek jan.kle...@hp.com changed:

   What|Removed |Added

 Blocks||501960




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 465372] Review Request: chntpw - Change passwords in Windows SAM files

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=465372





--- Comment #17 from Conrad Meyer kon...@tylerc.org  2009-06-10 03:34:53 EDT 
---
I have no interest in EPEL; Richard is totally free to take it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 497756] Review Request: lpg - LALR Parser Generator

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497756


Mat Booth fed...@matbooth.co.uk changed:

   What|Removed |Added

 Blocks||485460




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 504405] Review Request: jaxodraw - A Java program for drawing Feynman diagrams

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504405





--- Comment #5 from Jussi Lehtola jussi.leht...@iki.fi  2009-06-10 04:29:45 
EDT ---
Upstream has now confirmed the licensing situation. There is nothing nonfree in
the package, only GPL and LPPL.

http://theory.physics.helsinki.fi/~jzlehtol/rpms/jaxodraw.spec
http://theory.physics.helsinki.fi/~jzlehtol/rpms/jaxodraw-2.0-2.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 495692] Review Request: tslib - Touchscreen Access Library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495692


Nicolas Chauvet (kwizart) kwiz...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #10 from Nicolas Chauvet (kwizart) kwiz...@gmail.com  2009-06-10 
05:47:35 EDT ---
New Package CVS Request
===
Package Name: tslib
Short Description: Touchscreen Access Library
Owners: kwizart
Branches: devel F-11 F-10 EL-5
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 495692] Review Request: tslib - Touchscreen Access Library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495692





--- Comment #9 from Nicolas Chauvet (kwizart) kwiz...@gmail.com  2009-06-10 
05:46:38 EDT ---
(In reply to comment #8)
 APPROVED
 
 [...]
 
 Some observations, though:
And again, some very good comments.

 * Version 1.0 of tslib uses version 0.0 in its SONAME and in the pkg-config
Indeed, but until they change the API without bumping the release field, we can
still assure they are using it right despite it could have been done better.

 * The modules/plugins pollute the automatic RPM Provides (and hence the
 metadata) with their *.so names:
 
 $ rpm -qp --provides tslib-1.0-1.fc10.i386.rpm|grep -e so[^.]
It should be possible for the rpm dependency extractor to filter them as soon
as it discovers that they are module to be used with dlopen ?
It would be wondefull.

 * Asking upstream to run autogen.sh prior to creating the source tarball would
 be helpful.  
Yep, despite it could lead to problem once the sources are generated with a
version of libtool patched in an incompatible way. (experienced with vlc in
F-11: a binary failed to link with a just built library unless rpath as used at
build time which I've explicitely forbidden).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 226197] Merge Review: nfs-utils-lib

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226197


Steve Dickson ste...@redhat.com changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||RAWHIDE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 504809] Review Request: system-config-selinux - SELinux configuration GUI

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504809





--- Comment #4 from Roman Rakus rra...@redhat.com  2009-06-10 06:59:59 EDT ---
ad 1) fixed

ad 2) selinux-polgengui.desktop is in srpm

ad 3) Uses connsolhelper, like 99% of others. This is meant to be separate
package, which I will take care of and fix many bugs including rework to use
PolicyKit

ad 4) I don't know

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 503617] Review Request: senamirmir-washra-fonts - Fonts for the Geʼez (Ethiopic) script

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503617


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #1 from Parag AN(पराग) panem...@gmail.com  2009-06-10 07:02:46 
EDT ---
koji build = http://koji.fedoraproject.org/koji/taskinfo?taskID=1400997
verified upstream source as
96bd3826de65d96cfc00e1752658a0f20de19e71  washra-fonts-4.1.zip

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 495412] Review Request: flamerobin - Graphical client for Firebird

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495412





--- Comment #18 from Peter Lemenkov lemen...@gmail.com  2009-06-10 07:08:11 
EDT ---
REVIEW:

+ rpmlint is almost silent - it only complains about empty sections, which
should be removed (however it's a purely cosmetic change):

[pe...@workplace Desktop]$ rpmlint flamerobin-*
flamerobin.i386: W: empty-%post
flamerobin.i386: W: empty-%postun
flamerobin.i386: W: empty-%posttrans
2 packages and 0 specfiles checked; 0 errors, 3 warnings.
[pe...@workplace Desktop]$

+ The package is named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.

+/- The package meets the Packaging Guidelines with one remaining issue -
doc-files are listed twice. First - as %doc, second - as a contents of
%{_datadir}/%{name}/docs. I advice you to add

rm -rf $RPM_BUILD_ROOT%{_datadir}/%{name}/docs

at the end of the %install section. Btw, maybe it's better to list docs as
%doc docs/* rather than %doc docs ? 

+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The License field in the package spec file matches the actual license.
+ The  file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The package successfully compiles and builds into binary rpms on at least one
primary architecture. See links above.
+ All build dependencies are listed in BuildRequires.
+ A package owns all directories that it creates.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ The package consistently uses macros. There is a single place where the
$RPM_BUILD_ROOT is used instead of %{buildroot} - this may be ignored.
+ The package contains code, or permissible content.
+ No large documentation files.
+ Everything, the package includes as %doc, does not affect the runtime of the
application.
+ The package includes a %{name}.desktop file, and that file is properly
installed (checked with desktop-file-validate in the %install section).
+ The package does not own files or directories already owned by other
packages. 
+ At the beginning of %install, the package runs rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ All filenames in rpm packages are valid UTF-8.

Conclusion:

* consider to remove empty sections from spec-file
* remove duplicated docs from $RPM_BUILD_ROOT%{_datadir}/%{name}

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 481333] Review Request: sugar-update-control - Activity update control panel for Sugar

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481333


Steven M. Parrish smparr...@gmail.com changed:

   What|Removed |Added

 CC||smparr...@gmail.com




--- Comment #23 from Steven M. Parrish smparr...@gmail.com  2009-06-10 
07:29:31 EDT ---
Thanks for the report.  New builds have been submitted. If you have any other
issues please open a new report. 

Thanks

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 504809] Review Request: system-config-selinux - SELinux configuration GUI

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504809





--- Comment #5 from Jaroslav Reznik jrez...@redhat.com  2009-06-10 07:28:20 
EDT ---
Package Review
==

Key:
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [!] Package meets the Packaging Guidelines.
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
 Tested on: builds in Koji
 [x] Rpmlint output: 

rpmlint system-config-selinux-2.0.62-13.fc10.noarch.rpm
system-config-selinux.noarch: W: no-documentation
- no doc
system-config-selinux.noarch: W: no-dependency-on usermode
system-config-selinux.noarch: W: no-dependency-on usermode
- depends on usermode-gtk, is it enough?

SRPM  SPEC clean

 [-] Package is not relocatable.
 [x] Buildroot is correct
 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
 License type: GPLv2+
 [-] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [!] Sources used to build the package matches the upstream source, as provided
in the spec URL.
 - Can't get sources.
 [x] All build dependencies are listed in BuildRequires, except for any that
are
listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
 [x] Package consistently uses macros.
 [-] Large documentation files are in a -doc subpackage, if required.
 [-] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Package does not contain any libtool archives (.la).
 [!] Package contains a properly installed %{name}.desktop file if it is a GUI
application.

=== SUGGESTED ITEMS ===
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in koji.
 - http://koji.fedoraproject.org/koji/taskinfo?taskID=1403234
 [x] Package should compile and build into binary rpms on all supported
architectures.
 [?] Package functions as described.
 - not tested yet, I'll check final one
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files are correct.
 [-] File based requires are sane.

=== SUMMARY ===
- Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1403234
- Please publish tarball to default fedorahosted.org release directory
  (https://fedorahosted.org/releases/s/y/system-config-selinux)
- do not apply vendor tag in desktop-file-install 
  (http://fedoraproject.org/wiki/Packaging/Guidelines#desktop)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 505014] New: Review Request: perl-Alien-SeleniumRC - Packages the Selenium Remote Control server

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-Alien-SeleniumRC - Packages the Selenium Remote 
Control server

https://bugzilla.redhat.com/show_bug.cgi?id=505014

   Summary: Review Request: perl-Alien-SeleniumRC - Packages the
Selenium Remote Control server
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: emmanuel.sey...@club-internet.fr
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL:
http://people.parinux.org/~seyman/fedora/perl-Alien-SeleniumRC/perl-Alien-SeleniumRC.spec
SRPM URL:
http://people.parinux.org/~seyman/fedora/perl-Alien-SeleniumRC/perl-Alien-SeleniumRC-1.00-1.fc11.src.rpm
Description:
Selenium Remote Control is a test tool that allows you to write automated
web application UI tests in any programming language against any HTTP
website using any mainstream JavaScript-enabled browser. It provides a
Selenium Server, which can automatically start/stop/control any supported
browser. It works by using Selenium Core, a pure-HTML+JS library that
performs automated tasks in JavaScript.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 505017] New: Review Request: eclipse-veditor - Eclipse-based Verilog/VHDL plugin

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: eclipse-veditor - Eclipse-based Verilog/VHDL plugin

https://bugzilla.redhat.com/show_bug.cgi?id=505017

   Summary: Review Request: eclipse-veditor - Eclipse-based
Verilog/VHDL plugin
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: chitl...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://chitlesh.fedorapeople.org/RPMS/eclipse-veditor.spec
SRPM URL:
http://chitlesh.fedorapeople.org/RPMS/eclipse-veditor-0.6.3-1.fc11.src.rpm
Description: 
Eclipse Verilog editor is a plugin for the Eclipse IDE.
It provides Verilog(IEEE-1364) and VHDL language specific code
viewer, contents outline, code assist etc. It helps coding and
debugging in hardware development based on Verilog or VHDL.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 503617] Review Request: senamirmir-washra-fonts - Fonts for the Geʼez (Ethiopic) script

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503617


Nicolas Mailhot nicolas.mail...@laposte.net changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #2 from Nicolas Mailhot nicolas.mail...@laposte.net  2009-06-10 
07:59:02 EDT ---
Many thanks!

New Package CVS Request
===
Package Name: senamirmir-washra-font
Short Description: Fonts for the Geʼez (Ethiopic) script
Owners: nim
Branches: F11  devel
InitialCC: fonts-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 505014] Review Request: perl-Alien-SeleniumRC - Packages the Selenium Remote Control server

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=505014


Marcela Maslanova mmasl...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|mmasl...@redhat.com




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 505014] Review Request: perl-Alien-SeleniumRC - Packages the Selenium Remote Control server

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=505014





--- Comment #1 from Marcela Maslanova mmasl...@redhat.com  2009-06-10 
08:37:03 EDT ---
OK rpmlint on every package.
OK name of package accords to the Naming Guidelines.
OK spec file name match the base package %{name}.
OK package meet the Packaging Guidelines.
OK package has a good license.
OK spec file is written in American English.
OK spec file for the package must be legible.
FAIL The sources used to build the package must match the upstream source.
  srpm 8dfe7a67b2246e6ceb85a912fd642687 != 92a34ab58b49a6b70053a35d7bb57469 src
OK successful koji compilation.
OK correct BuildRequires, Requires.
OK proper use of %find_lang macro.
OK shared library must call ldconfig in %post and %postun.
OK relocatable package must state this fact.
OK package must own their directories.
OK permissions on files must be set properly.
OK %clean section with rm -rf %{buildroot}.
OK consistent use of macros.
OK package contains code, or permissable content.
OK large documentation go in a -doc subpackage.
OK %doc must not affect the runtime of the application.
OK header files must be in a -devel package.
OK static libraries must be in a -static package.
OK pkgconfig(.pc) files must 'Requires: pkgconfig'.
OK library files with a suffix (.so) must go in -devel.
OK usually devel packages must require the base package.
OK Remove .la libtool archives.
OK GUI applications must include a %{name}.desktop file.
OK %install section starts with rm -rf %{buildroot}.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 503336] Review Request: newsbeuter - console based feed reader

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503336





--- Comment #5 from Byron Clark by...@theclarkfamily.name  2009-06-10 
08:40:02 EDT ---
(In reply to comment #4)
 I don't think that this is good summary. 

I replaced the summary.

Spec URL: http://theclarkfamily.name/fedora/newsbeuter.spec
SRPM URL: http://theclarkfamily.name/fedora/newsbeuter-2.0-5.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 502614] Review Request: stfl - STFL implements a curses-based widget set for text terminals

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502614


Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 CC||jussi.leht...@iki.fi
 Blocks||177841(FE-NEEDSPONSOR)




--- Comment #8 from Jussi Lehtola jussi.leht...@iki.fi  2009-06-10 08:54:07 
EDT ---
You are not supposed to use both python_sitelib and python_sitearch. If the
package contains architecture specific components you need to use sitearch,
else sitelib.

If you're building on 32-bit, these will point to the same location. On 64-bit
architectures the build will fail.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 503336] Review Request: newsbeuter - console based feed reader

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503336


Jan Klepek jan.kle...@hp.com changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|jan.kle...@hp.com
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 505014] Review Request: perl-Alien-SeleniumRC - Packages the Selenium Remote Control server

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=505014





--- Comment #2 from Emmanuel Seyman emmanuel.sey...@club-internet.fr  
2009-06-10 09:10:26 EDT ---
(In reply to comment #1)

 FAIL The sources used to build the package must match the upstream source.
   srpm 8dfe7a67b2246e6ceb85a912fd642687 != 92a34ab58b49a6b70053a35d7bb57469 
 src

Downloading the upstream sources once again, I still get a md5sum of
8dfe7a67b2246e6ceb85a912fd642687. I've tried two different CPAN mirrors and
can't see what I'm doing wrong.

Marcela, do you remember which you downloaded the tarball from ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 505014] Review Request: perl-Alien-SeleniumRC - Packages the Selenium Remote Control server

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=505014


Marcela Maslanova mmasl...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-review+




--- Comment #3 from Marcela Maslanova mmasl...@redhat.com  2009-06-10 
09:21:28 EDT ---
Hm, I tried again and it's matching. Never mind, it looks all right now.
ACCEPT

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 505014] Review Request: perl-Alien-SeleniumRC - Packages the Selenium Remote Control server

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=505014


Emmanuel Seyman emmanuel.sey...@club-internet.fr changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #4 from Emmanuel Seyman emmanuel.sey...@club-internet.fr  
2009-06-10 09:25:12 EDT ---
:-)

Thanks for the review! Requesting CVS.

New Package CVS Request
===
Package Name: perl-Alien-SeleniumRC
Short Description: Packages the Selenium Remote Control server
Owners: eseyman
Branches: F-10 F-11
InitialCC: perl-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 502614] Review Request: stfl - STFL implements a curses-based widget set for text terminals

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502614





--- Comment #9 from Byron Clark by...@theclarkfamily.name  2009-06-10 
09:29:35 EDT ---
(In reply to comment #8)
 You are not supposed to use both python_sitelib and python_sitearch. If the
 package contains architecture specific components you need to use sitearch,
 else sitelib.

The build now only uses python_sitearch.  This also included modifying a patch
to the stfl buildsystem.  The patch has been submitted upstream.

Spec URL: http://theclarkfamily.name/fedora/stfl.spec
SRPM URL: http://theclarkfamily.name/fedora/stfl-0.20-5.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 226197] Merge Review: nfs-utils-lib

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226197


Tom spot Callaway tcall...@redhat.com changed:

   What|Removed |Added

   Keywords||Reopened
 Status|CLOSED  |ASSIGNED
 Resolution|RAWHIDE |




--- Comment #3 from Tom spot Callaway tcall...@redhat.com  2009-06-10 
09:36:17 EDT ---
Reopening. No one did a review here!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 226197] Merge Review: nfs-utils-lib

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226197





--- Comment #4 from Steve Dickson ste...@redhat.com  2009-06-10 09:46:18 EDT 
---
oops... sorry about that... I though this was about the licensing problems...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 505046] New: Review Request: perl-Config-Auto - Magical config file parser

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-Config-Auto - Magical config file parser

https://bugzilla.redhat.com/show_bug.cgi?id=505046

   Summary: Review Request: perl-Config-Auto - Magical config file
parser
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: emmanuel.sey...@club-internet.fr
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL:
http://people.parinux.org/~seyman/fedora/perl-Config-Auto/perl-Config-Auto.spec
SRPM URL:
http://people.parinux.org/~seyman/fedora/perl-Config-Auto/perl-Config-Auto-0.20-1.fc11.src.rpm
Description:
This module was written after having to write Yet Another Config File
Parser for some variety of colon-separated config. It searches the filesystem
for the program's configuration file, basing itself on the program's name
and returns a data structure based on the file's contents.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 495412] Review Request: flamerobin - Graphical client for Firebird

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495412





--- Comment #19 from Philippe Makowski makowski.fed...@gmail.com  2009-06-10 
09:49:27 EDT ---
ok
* consider to remove empty sections from spec-file
made
* remove duplicated docs from $RPM_BUILD_ROOT%{_datadir}/%{name}  
made

I also removed the no need  BuildRequires:ImageMagick


changes made :
Spec URL: http://ibphoenix.fr//fedora/flamerobin.spec

http://koji.fedoraproject.org/koji/taskinfo?taskID=1403525

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 225794] Merge Review: ghostscript-fonts

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225794





--- Comment #10 from Tim Waugh twa...@redhat.com  2009-06-10 10:00:33 EDT ---
(In reply to comment #9)
 - Change
  Requires(post): /usr/bin/mkfontscale /usr/bin/mkfontdir
 to
  Requires(post): xorg-x11-font-utils
 as this is the package that provides those since Fedora Core 2 (2004).

Done.

 - I'm not totally sure you need
  Requires(post): fontconfig
  Requires(postun): fontconfig
 as you already have Requires: fontconfig. Besides, this is probably
 automatically picked up by rpm. Doesn't hurt having them, though.

Left alone.

 - Change references to /etc to %{_sysconfdir}

Done.

 - Setting umask is probably not necessary as this is done by rpm.
 - Replace `which mkfontdir` with plain mkfontdir.

Not sure about these.  The scriptlets were copied from urw-fonts, so if they
need fixing they ought to be fixed in both places.

 - Drop
  %dir %{catalogue}
 in %files section, as
  $ rpm -qf /etc/X11/fontpath.d/
  filesystem-2.4.19-1.fc10.i386
 is already owned on every installation.

Done.

 - I can't find a single mention of a license in the tarball!  

No, *sigh*.  Tom Callaway looked into the licenses in July last year, and there
haven't been any developments since then.

5.50-21.fc12 built.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 495412] Review Request: flamerobin - Graphical client for Firebird

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495412


Peter Lemenkov lemen...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #20 from Peter Lemenkov lemen...@gmail.com  2009-06-10 10:03:20 
EDT ---
Ok,

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 505046] Review Request: perl-Config-Auto - Magical config file parser

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=505046


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
 AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 226197] Merge Review: nfs-utils-lib

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226197





--- Comment #5 from Michael Schwendt mschwe...@gmail.com  2009-06-10 10:03:57 
EDT ---
Well, there are some good review findings in the bottom half of comment 1. To
add to that, the Requires(pre): /sbin/ldconfig is completely superfluous
because the packages doesn't contain a pre scriptlet at all.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 225794] Merge Review: ghostscript-fonts

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225794





--- Comment #11 from Jussi Lehtola jussi.leht...@iki.fi  2009-06-10 10:10:53 
EDT ---
(In reply to comment #10)
  - Setting umask is probably not necessary as this is done by rpm.
  - Replace `which mkfontdir` with plain mkfontdir.
 
 Not sure about these.  The scriptlets were copied from urw-fonts, so if they
 need fixing they ought to be fixed in both places.

urw-fonts hasn't been through a merge review, so you really can't trust that
the packaging is sane on all accounts.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 502065] Review Request: slashem - Super Lotsa Added Stuff Hack - Extended Magic

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502065





--- Comment #4 from Jerry James loganje...@gmail.com  2009-06-10 10:17:42 EDT 
---
The spec URL given in comment #3 shows the original spec file.  The SRPM URL in
the same comment gives me an HTTP 404.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 225794] Merge Review: ghostscript-fonts

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225794


Tim Waugh twa...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




--- Comment #12 from Tim Waugh twa...@redhat.com  2009-06-10 10:22:48 EDT ---
OK, 5.50-22.fc12 built with all suggestions applied.  Thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 502065] Review Request: slashem - Super Lotsa Added Stuff Hack - Extended Magic

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502065





--- Comment #5 from Iain Arnell iarn...@gmail.com  2009-06-10 10:28:25 EDT ---
Sorry 'bout that - I managed to do everything except upload the new versions.
All should be good now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 502065] Review Request: slashem - Super Lotsa Added Stuff Hack - Extended Magic

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502065


Jerry James loganje...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #6 from Jerry James loganje...@gmail.com  2009-06-10 10:32:48 EDT 
---
Looks good.  I can't wait to start wasting still more hours of my life on a
rogue derivative. :-)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 226036] Merge Review: liboil

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226036





--- Comment #4 from Bastien Nocera bnoc...@redhat.com  2009-06-10 10:46:09 
EDT ---
(In reply to comment #1)
 I reviewed this package. There are some issues, questions and suggestions that
 I'll bring into your attention.
 
 * The latest version is not packaged! Please update to the latest version.

Latest version is in devel

 * The HACKING file should be packaged, possibly in the %doc of devel

Done

 ? The examples directory can go into the %doc of devel too.

The code in examples are too complicated to be used stand-alone.

 ? Some files in m4 and the file missing indicates  GPLv2+ license.But I 
 don't
 think these make their way into the package, so I guess BSD is good enough.

OK

 * I don't think glib2-devel is required to build the package. I built an
 identical package in mock without BR'in glib2-devel. Some of the examples
 require glib2-devel. So if you are going to package those examples you'll need
 to require glib2-devel in the devel subpackage.

It's optional, but used. From configure.ac:
PKG_CHECK_MODULES(GLIB, glib-2.0, HAVE_GLIB=yes, HAVE_GLIB=no)
AC_SUBST(GLIB_LIBS)
AC_SUBST(GLIB_CFLAGS)
AC_ARG_ENABLE(glib,
AC_HELP_STRING([--disable-glib],[disable usage of glib]),
[case ${enableval} in
  yes) HAVE_GLIB=yes ;;
  no) HAVE_GLIB=no ;;
  *) AC_MSG_ERROR(bad value ${enableval} for --disable-glib) ;;
esac])
AM_CONDITIONAL(HAVE_GLIB, test x$HAVE_GLIB = xyes)

 * A package must own all directories that it creates. If it does not create a
 directory that it uses, then it should require a package which does create 
 that
 directory. The directory %{_datadir}/gtk-doc/html/ is created but not owned. 
 So
 the devel package should require gtk-doc which is the rightful owner of that
 directory.

Done

 ! Try to make use of the %{name} macro.

Done in the few places where it makes sense.

 * From the SPEC file:
# multi-jobbed make makes the build fail:
# ./build_prototypes_doc liboilfuncs-doc.h
# /bin/sh: ./build_prototypes_doc: No such file or directory
make %{?_smp_mflags}
 Isn't there a contradiction here? What is that commented-out section for?

I removed the comment.

 * From the SPEC file:
# Disable Altivec, so that liboil doesn't SIGILL on non-Altivec PPCs
# See https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=252179#c15
#sed -i 's/CFLAGS=$CFLAGS -maltivec/CFLAGS=$CFLAGS 
 -fno-tree-vectorize
 -Wa,-maltivec/' configure
#sed -i 's/LIBOIL_CFLAGS -maltivec/LIBOIL_CFLAGS -fno-tree-vectorize
 -Wa,-maltivec/' configure
 Do we still need these lines in the SPEC file?

Nope, removed.

Should all be fixed in 0.3.16-2

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 225794] Merge Review: ghostscript-fonts

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225794


Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

   Keywords||Reopened
 Status|CLOSED  |ASSIGNED
 Resolution|RAWHIDE |




--- Comment #13 from Jussi Lehtola jussi.leht...@iki.fi  2009-06-10 10:50:34 
EDT ---
Uh, not so fast, I'll still do the review in full :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 226034] Merge Review: libmusicbrainz

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226034





--- Comment #24 from Bastien Nocera bnoc...@redhat.com  2009-06-10 10:54:46 
EDT ---
(In reply to comment #22)
 I also noticed that there is one occurrence of rm that should be converted to
 %{__rm} for macro consistency.  

Done

(In reply to comment #7)
 I did a full review on this package. Everything seems fine except
 
 * docs/mb_howto.txt should be included among %doc, or maybe in devel's %doc

Done

 * the examples directory should be included in devel's %doc

Done

 Other than these two things the package yields Fedora Guidelines.
 
 A question: Isn't it time to rename this package as libmusicbrainz2 and call
 libmusicbrainz3 as libmusicbrainz? Is there a particular reason why this is 
 not
 done yet?  

This would be a pretty pointless shuffling of package names.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 502065] Review Request: slashem - Super Lotsa Added Stuff Hack - Extended Magic

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502065


Iain Arnell iarn...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #7 from Iain Arnell iarn...@gmail.com  2009-06-10 10:54:36 EDT ---
New Package CVS Request
===
Package Name: slashem
Short Description: Super Lotsa Added Stuff Hack - Extended Magic
Owners: iarnell
Branches: F-10 F-11
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 493250] Review Request: perl-Goo-Canvas -- Goo::Canvas Perl interface to the GooCanvas

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=493250


Liang Suilong liangsuil...@gmail.com changed:

   What|Removed |Added

   Flag|needinfo?(liangsuil...@gmai |
   |l.com)  |




--- Comment #29 from Liang Suilong liangsuil...@gmail.com  2009-06-10 
11:06:15 EDT ---
Mamoru Tasaka,

Just need I replace rename with mv?

and %file should like this?

%files
%defattr(-,root,root,-)
%doc Changes goocanvas.typemap maps README
%{_bindir}/*
%{_mandir}/man3/
%{_mandir}/man1/
%{perl_vendorarch}/auto/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 225794] Merge Review: ghostscript-fonts

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225794


Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE
   Flag|fedora-review?  |fedora-review+




--- Comment #14 from Jussi Lehtola jussi.leht...@iki.fi  2009-06-10 11:07:16 
EDT ---
rpmlint output is clean.


MUST: The spec file for the package is legible and macros are used
consistently. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the 
Licensing Guidelines. OK

MUST: The License field in the package spec file must match the actual license.
?
- No license information available.

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. N/A
MUST: Optflags are used and time stamps preserved. OK
MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. N/A
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. N/A
MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. OK
MUST: Desktop files are installed properly. N/A
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK

I trust spot's legal opinion in the license issue, so the package is

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 501223] Review Request: tuxmath - Educational math tutor for children

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=501223


Johan Cwiklinski jo...@x-tnd.be changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #7 from Johan Cwiklinski jo...@x-tnd.be  2009-06-10 11:11:39 EDT 
---
New Package CVS Request
===
Package Name: tuxmath
Short Description: Educational math tutor for children
Owners: trasher
Branches: F-10 F-11
InitialCC: trasher

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 492224] Review Request: gnome-mud - MUD client for GNOME desktop

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492224





--- Comment #13 from Sean Middleditch s...@middleditch.us  2009-06-10 
11:12:13 EDT ---
No, my intention was to package 0.11.2.  I just wasn't aware that running a
make dist from the 0.11.2 branch was producing something different than what
upstream put on their FTP servers; their SVN branch just isn't what was used to
make that tarball.  Not a biggie, I will just replace with upstream's official
release and retest.

For the AUTHORS file then, I would call iconv in the spec file... at which
point?  During install?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 225794] Merge Review: ghostscript-fonts

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225794





--- Comment #15 from Tim Waugh twa...@redhat.com  2009-06-10 11:14:53 EDT ---
Thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 504077] Review Request: gnusim8085 - Intel 8085 assembly language simulator

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504077


Rangeen Basu Roy Chowdhury sherry...@gmail.com changed:

   What|Removed |Added

 Depends on||505080




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 495412] Review Request: flamerobin - Graphical client for Firebird

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495412


Philippe Makowski makowski.fed...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #21 from Philippe Makowski makowski.fed...@gmail.com  2009-06-10 
11:47:17 EDT ---
New Package CVS Request
===
Package Name: flamerobin
Short Description: database administration tool for Firebird DBMS based on
wxgtk
toolkit
Owners: pmakowski
Branches: F-10 F-11 EL-4 EL-5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 501960] Review Request: webinject - Web/HTTP Test Tool

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=501960


Jan Klepek jan.kle...@hp.com changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|jan.kle...@hp.com
   Flag||fedora-review?




--- Comment #2 from Jan Klepek jan.kle...@hp.com  2009-06-10 11:54:10 EDT ---
1] Source should be URL-like
http://fedoraproject.org/wiki/Packaging/SourceURL

2] Summary would be nicer like web/http testing tool

3] no desktop file present
http://fedoraproject.org/wiki/Packaging/Guidelines#desktop

4] files duplicated
http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles

5] why to have all files with 0755 permissions?
http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions

6] this application looks for me like dead, the latest version is from Jan 4,
2006.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 504748] Review Request: perl-PDF-Reuse - Reuse and mass produce PDF documents

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504748


Bug 504748 depends on bug 504746, which changed state.

Bug 504746 Summary: Review Request: perl-Text-PDF - Module for manipulating PDF 
files
https://bugzilla.redhat.com/show_bug.cgi?id=504746

   What|Old Value   |New Value

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE



--- Comment #4 from Chris Weyl cw...@alumni.drew.edu  2009-06-10 11:58:27 EDT 
---
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=1403722

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 226036] Merge Review: liboil

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226036





--- Comment #5 from Orcan 'oget' Ogetbil oget.fed...@gmail.com  2009-06-10 
13:08:35 EDT ---
Thank you Bastien,
There is this minor issue that is unfortunately a blocker:

The %doc HACKING line must come after defattr(-,root,root,-)

Please fix this so we can close the bug.

Thanks again!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 226034] Merge Review: libmusicbrainz

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226034





--- Comment #25 from Orcan 'oget' Ogetbil oget.fed...@gmail.com  2009-06-10 
13:16:39 EDT ---
Thanks!

The 
   %doc docs/mb_howto.txt examples/README.examples examples/*.c examples/*.cpp
line must come after
   %defattr(-,root,root,-)

Afaict this is the only outstanding issue left.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 226034] Merge Review: libmusicbrainz

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226034





--- Comment #26 from Bastien Nocera bnoc...@redhat.com  2009-06-10 13:21:56 
EDT ---
Done in -10

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 226036] Merge Review: liboil

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226036





--- Comment #6 from Bastien Nocera bnoc...@redhat.com  2009-06-10 13:20:42 
EDT ---
Done in -3

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 492224] Review Request: gnome-mud - MUD client for GNOME desktop

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492224





--- Comment #14 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp  2009-06-10 
13:25:07 EDT ---
(In reply to comment #13)
 For the AUTHORS file then, I would call iconv in the spec file... at which
 point?  During install?  

At %prep is the best.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 226034] Merge Review: libmusicbrainz

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226034


Orcan 'oget' Ogetbil oget.fed...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




--- Comment #27 from Orcan 'oget' Ogetbil oget.fed...@gmail.com  2009-06-10 
13:34:00 EDT ---
Yay! All good.

--
This merge review (libmusicbrainz) is APPROVED by oget
--

Closing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 226034] Merge Review: libmusicbrainz

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226034


Orcan 'oget' Ogetbil oget.fed...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 226036] Merge Review: liboil

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226036


Orcan 'oget' Ogetbil oget.fed...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE
   Flag|fedora-review?  |fedora-review+




--- Comment #7 from Orcan 'oget' Ogetbil oget.fed...@gmail.com  2009-06-10 
13:35:55 EDT ---
All issues have been addressed. Thanks for the updates.

--
This merge review (liboil) is APPROVED by oget
--

Closing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 504489] Review Request: proguard - Java class file shrinker, optimizer, obfuscator and preverifier

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504489





--- Comment #7 from François Kooman fkoo...@tuxed.net  2009-06-10 14:14:30 
EDT ---
I've updated the package again considering your remarks.

Spec URL: http://fkooman.fedorapeople.org/proguard/proguard.spec
SRPM URL: http://fkooman.fedorapeople.org/proguard/proguard-4.3-4.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 504489] Review Request: proguard - Java class file shrinker, optimizer, obfuscator and preverifier

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504489


François Kooman fkoo...@tuxed.net changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #8 from François Kooman fkoo...@tuxed.net  2009-06-10 14:17:22 
EDT ---
New Package CVS Request
===
Package Name: proguard
Short Description: Java class file shrinker, optimizer, obfuscator and
preverifier
Owners: fkooman
Branches: F-10 F-11
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 493250] Review Request: perl-Goo-Canvas -- Goo::Canvas Perl interface to the GooCanvas

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=493250





--- Comment #30 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp  2009-06-10 
14:36:42 EDT ---
(In reply to comment #29)
 Just need I replace rename with mv?
- Well, I don't know what you meant here, however the problem
  on the my comment 27 is that after perl pure_install the
  installed scripts are actually under %buildroot%_bindir, not
  under %_bindir

 
 and %file should like this?
 
 %files
 %defattr(-,root,root,-)
 %doc Changes goocanvas.typemap maps README
 %{_bindir}/*
 %{_mandir}/man3/
 %{_mandir}/man1/
 %{perl_vendorarch}/auto/  
- No. Still the directories
  %_mandir/man3
  %_mandir/man1
  %perl_verdorarch/auto
  _themselves_ are owned, which should not.

  Note:
---
%files
foo/
---
  (where foo is a directory) means the directory foo/
  itself and all files/directories/etc under foo/, while
---
%files
foo/*
---
  means all files/directories/etc under foo/ (if no hidden
  files are under foo/), but does not contain foo/ directory
  itself.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 501854] Review Request: lcdf-typetools - The LCDF Typetools for manipulating OpenType fonts

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=501854


Orcan 'oget' Ogetbil oget.fed...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|oget.fed...@gmail.com
   Flag|fedora-review?  |fedora-review+




--- Comment #2 from Orcan 'oget' Ogetbil oget.fed...@gmail.com  2009-06-10 
14:52:23 EDT ---
I'm done reviewing this. There are two minor issues to be resolved:

- rpmlint is silent

- There are certain files in the source, such as
   include/lcdf/hashmap.cc
   include/lcdf/vector.cc
   include/lcdf/clp.h
   liblcdf/string.cc
   liblcdf/error.cc
   liblcdf/vectorv.cc
   liblcdf/clp.c
   liblcdf/straccum.cc
that are under MIT license. But since during the compilation, they are linked
to GPL parts of the code, and since GPL is stricter than MIT, the overall
license as GPLv2+ is acceptable.

- koji rawhide build is fine:
   http://koji.fedoraproject.org/koji/taskinfo?taskID=1403904

* The directory
   %{_datadir}/lcdf-typetools/
is unowned! This needs attention.

* Please include the COPYING file in %doc, as required by the guidelines.


Please do these changes before you commit.

-
This package (lcdf-typetools) is APPROVED by oget
-

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 453422] Review Request: songbird - Mozilla based multimedia player

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453422





--- Comment #69 from Stephen Lau ste...@songbirdnest.com  2009-06-10 15:07:20 
EDT ---
(In reply to comment #67) ...

Hey Tom,
Thanks very much for the detailed reply and points... I'm bringing them up with
our lawyers and execs to see what we can and can't address.  I expect this will
take a while (as anything involving management and/or legal seems to do), but
just wanted to let you know I'm looking into it and not ignoring it.

cheers,
steve

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 453422] Review Request: songbird - Mozilla based multimedia player

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453422





--- Comment #68 from Stephen Lau ste...@songbirdnest.com  2009-06-10 15:05:13 
EDT ---
(In reply to comment #66)
 (In reply to comment #65)
  stuff just for Linux since it's entirely possible we could deliver 
  binary-only
  components again in the future for Linux users.
 
 I don't want to get much involved with this review, but why not just let
 gstreamer deal with the codecs mess? And if you want to provide some
 binary-only codecs, why not to make repository of them and let PackageKit use
 it as (optional of course) additional source of codecs?
 
 But, that's just off-topic to the issue of EULA.  

Sorry for the confusion, but I was talking about proprietary/binary-only
add-ons (in the sense of Songbird add-ons which are like Firefox add-ons...
packaged in .xpis, that augment the app by giving it new skins, or new
functionality).

The codecs themselves are all managed by GStreamer as you'd expect.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 505138] New: Review Request: trac-peerreview-plugin - Framework for realtime code review within Trac

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: trac-peerreview-plugin - Framework for realtime code 
review within Trac

https://bugzilla.redhat.com/show_bug.cgi?id=505138

   Summary: Review Request: trac-peerreview-plugin - Framework for
realtime code review within Trac
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: chitl...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://chitlesh.fedorapeople.org/RPMS/trac-peerreview-plugin.spec
SRPM URL:
http://chitlesh.fedorapeople.org/RPMS/trac-peerreview-plugin-0.11-1.svn5357.fc11.src.rpm
Description:
A Distributed Peer-Review Plug-in for TRAC Project
Management System.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 498845] Review Request: R-msm - Multi-state Markov and hidden Markov models in continuous time

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=498845


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #7 from Jason Tibbitts ti...@math.uh.edu  2009-06-10 15:37:18 EDT 
---
OK, this builds fine, the check section passes and the license clarification is
fine.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 500928] Review Request: python-sqlparse - Non-validating SQL parser for Python

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=500928


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #6 from Jason Tibbitts ti...@math.uh.edu  2009-06-10 15:53:45 EDT 
---
Looks good; the test suite runs fine:
  Ran 55 tests in 0.130s
  OK

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 500928] Review Request: python-sqlparse - Non-validating SQL parser for Python

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=500928


Dave Malcolm dmalc...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #7 from Dave Malcolm dmalc...@redhat.com  2009-06-10 16:02:50 EDT 
---
Thanks

New Package CVS Request
===
Package Name: python-sqlparse
Short Description: Non-validating SQL parser for Python
Owners: dmalcolm
Branches: 
InitialCC: 

(i.e. just for devel for now)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 505154] New: Tracker for reviews of Science and Technology related packages

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Tracker for reviews of Science and Technology related packages

https://bugzilla.redhat.com/show_bug.cgi?id=505154

   Summary: Tracker for reviews of Science and Technology related
packages
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: jussi.leht...@iki.fi
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


This is a tracker bug for Fedora Science and Technology related packages used
instead of the wiki.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 472639] Review Request: Scilab - Numerical Analysis toolkit

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472639


Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 Blocks||505154




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 484386] Review Request: gri - A language for scientific illustration

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484386


Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 Blocks||505154




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 470830] Review Request: open64 - The Open64 compiler suite (C, C++, Fortran)

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470830


Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 Blocks||505154




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 453703] Review Request: trilinos - A collection of libraries of numerical algorithms

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453703


Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 Blocks||505154




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 451744] Review Request: root - The CERN analyzer for high to medium energy physics

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=451744


Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 Blocks||505154




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 504430] Review Request: healpy - A python wrapper of the healpix library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504430


Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 Blocks||505154




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 474787] Review Request: stxxl - C++ STL drop-in replacement for extremely large datasets

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474787


Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 Blocks||505154




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 489686] Review Request: armadillo - fast C++ matrix library with interfaces to LAPACK and ATLAS

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=489686


Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 Blocks||505154




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 496742] Review Request: elfelli - Visualisation tool for flux lines

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=496742


Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 Blocks||505154




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 505154] Tracker for reviews of Science and Technology related packages

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=505154


Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 Depends on||451744(root), 453703,
   ||470830, 484386, 474787,
   ||472639, 489686, 496742,
   ||504430




--- Comment #1 from Jussi Lehtola jussi.leht...@iki.fi  2009-06-10 16:22:52 
EDT ---
Adding existing trackers from the SciTech SIG page.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 505155] New: Review Request: libcap-ng - An alternative posix capabilities library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: libcap-ng - An alternative posix capabilities library

https://bugzilla.redhat.com/show_bug.cgi?id=505155

   Summary: Review Request: libcap-ng - An alternative posix
capabilities library
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: sgr...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Spec URL: http://people.redhat.com/sgrubb/libcap-ng/libcap-ng.spec
SRPM URL: http://people.redhat.com/sgrubb/libcap-ng/libcap-ng-0.4-1.src.rpm
Description: Libcap-ng is a library that makes using posix capabilities easier
and provides utilities to analyze your system for privileged apps.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 504424] Review Request: ruby-json - A JSON implementation in Ruby

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504424


Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 Blocks||505154




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 505154] Tracker for reviews of Science and Technology related packages

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=505154


Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 Depends on|504424  |




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 505154] Tracker for reviews of Science and Technology related packages

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=505154


Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 Depends on||504405




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 504405] Review Request: jaxodraw - A Java program for drawing Feynman diagrams

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504405


Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 Blocks||505154




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 505154] Tracker for reviews of Science and Technology related packages

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=505154


Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 Depends on||504424




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 485652] Review Request: navit - Car navigation system with routing engine

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485652





--- Comment #8 from Fabian Affolter fab...@bernewireless.net  2009-06-10 
16:30:58 EDT ---
(In reply to comment #5)
 The spec contributed by Fabian is clearly based on my Mandriva spec (see, for
 comparison,
 http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/navit/current/SPECS/navit.spec?view=markup
 ) - it would have been polite to acknowledge this in the submission, Fabian.

Yes, your spec file provides some lines to the Fedora spec file, especially the
patches.  

(In reply to comment #6)
 forgot to mention, mine has some improvements over Fabian's, like dropping .la
 files.

In my spec file the following line takes care about the .la files
find %{buildroot} -name '*.la' -exec rm -f {} ';'

as suggest in the Packaging guidelines.

(In reply to comment #7)
 btw, I think the -devel package is bogus...the 'libraries' are just plugins,
 they shouldn't have been installed as shared libraries by navit in the first
 place. they should only contain .so files (not .so.0.0.0 and .so.0) and these
 should be in the main package(s).

It's good to have versioned plugins ;-) I agree that they should go in the main
packages.

 I don't know why Fabian removed the split of different rendering engines from
 my package. The reason they were split is to reduce dependencies - if you roll
 them all together, as Fabian did, you have to have libqt4 installed to install
 navit even if you have no intention of ever using the QT renderer. ditto cegui
 etc.

I can't remember why I did this...perhaps the reason is simple: Just
misremember. My spec file is still in an early stage (see %file section). The
intention was to build a working prototype and then do the cleaning.

Aout the map: I personally see no reason to include a sample map because this
blow the package size up and have only gain for a few users.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 504424] Review Request: ruby-json - A JSON implementation in Ruby

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504424


Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 CC||jussi.leht...@iki.fi
 Blocks|505154  |




--- Comment #1 from Jussi Lehtola jussi.leht...@iki.fi  2009-06-10 16:28:42 
EDT ---
Whoops, copy paste error.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 465372] Review Request: chntpw - Change passwords in Windows SAM files

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=465372


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #18 from Jason Tibbitts ti...@math.uh.edu  2009-06-10 16:52:58 
EDT ---
CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 495692] Review Request: tslib - Touchscreen Access Library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495692


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #11 from Jason Tibbitts ti...@math.uh.edu  2009-06-10 16:54:15 
EDT ---
CVS done.

BTW, we pay no attention to Cvsextras Commits these days.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 451744] Review Request: root - The CERN analyzer for high to medium energy physics

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=451744





--- Comment #26 from Orcan 'oget' Ogetbil oget.fed...@gmail.com  2009-06-10 
16:55:43 EDT ---
May I ask: Who is working on this package? juanucleus? Joseph? Kostas? Thomas?
Jochen? I have a feeling that everybody is waiting for someone to step forward.

If anyone points to a SPEC file that we can proceed from, I'd be grateful.
There are a few SPEC files posted above but I don't know who want(s) to be the
maintainer(s).

Please don't be afraid to raise your hand.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 505014] Review Request: perl-Alien-SeleniumRC - Packages the Selenium Remote Control server

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=505014


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #5 from Jason Tibbitts ti...@math.uh.edu  2009-06-10 16:57:58 EDT 
---
CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 503617] Review Request: senamirmir-washra-fonts - Fonts for the Geʼez (Ethiopic) script

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503617


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #3 from Jason Tibbitts ti...@math.uh.edu  2009-06-10 16:57:17 EDT 
---
CVS done.

Note, branch names are like F-11; don't include characters like ''.
I cannot guarantee that the UTF-8 character made it all the way through the
probably 20 tools that handled it on the way into the system, so please
double-check

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 465372] Review Request: chntpw - Change passwords in Windows SAM files

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=465372





--- Comment #19 from Richard W.M. Jones rjo...@redhat.com  2009-06-10 
17:03:17 EDT ---
Thanks Jason.

Conrad - if you do need access to the EL-5 branch then just make
the acl change request through pkgdb and I'll approve it straight away.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Bug 465372] Review Request: chntpw - Change passwords in Windows SAM files

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=465372





--- Comment #20 from Conrad Meyer kon...@tylerc.org  2009-06-10 17:06:37 EDT 
---
Sure -- thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review