[Bug 512636] Review Request: ibus-table-xinhua - Xin Hua table of IBus Table.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=512636
--- Comment #1 from Parag AN(पराग) 2009-07-21 02:47:04
EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1488962
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
18b35b4e6ba0241937ba5aea0115455fd034fefc
ibus-table-xinhua-1.2.0.20090720.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ ibus-table-createdb scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application
Suggestion:
1) use configure instead autogen.sh
2) you already requires ibus-table then what is need to own
%dir %{_datadir}/ibus-table
%dir %{_datadir}/ibus-table/icons
%dir %{_datadir}/ibus-table/tables
3) drop
BuildRequires:gettext-devel >= 0.17, automake >= 1.10
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512639] Review Request: ibus-table-translit - Translit table for IBus Table.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=512639
--- Comment #1 from Parag AN(पराग) 2009-07-21 02:47:12
EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1488960
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
fa34ab48dc174452c4d667ac9384d39727497190
ibus-table-translit-1.2.0.20090720.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ ibus-table-createdb scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application
Suggestion:
1) use configure instead autogen.sh
2)you already requires ibus-table then what is need to own
%dir %{_datadir}/ibus-table
%dir %{_datadir}/ibus-table/icons
%dir %{_datadir}/ibus-table/tables
3)drop
BuildRequires:gettext-devel >= 0.17, automake >= 1.10
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512637] Review Request: ibus-table-quick - Quick table of IBus Table.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=512637
--- Comment #1 from Parag AN(पराग) 2009-07-21 02:47:09
EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1488958
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
943e44d03f0829e4cb0345b755cf1e7ab87c241c
ibus-table-quick-1.2.0.20090720.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ ibus-table-createdb scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application
Suggestion:
1) use configure instead autogen.sh
2) update README in upstream which is for ibus-table-canejie.
3) you already requires ibus-table then what is need to own
%dir %{_datadir}/ibus-table
%dir %{_datadir}/ibus-table/icons
%dir %{_datadir}/ibus-table/tables
4) drop
BuildRequires:gettext-devel >= 0.17, automake >= 1.10
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507377] Review Request: jana - An interface library for time-related PIM
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507377 --- Comment #4 from Parag AN(पराग) 2009-07-21 02:13:37 EDT --- will check this package this week -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512646] Review Request: ibus-table-array30 - Array 30 table of IBus Table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512646 Parag AN(पराग) changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||DUPLICATE AssignedTo|panem...@gmail.com |nob...@fedoraproject.org Flag|fedora-review? | --- Comment #1 from Parag AN(पराग) 2009-07-21 01:58:17 EDT --- *** This bug has been marked as a duplicate of 511196 *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511196] Review Request: ibus-table-array30 - Array30 Chinese input method for ibus-table
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511196 Parag AN(पराग) changed: What|Removed |Added CC||ccha...@redhat.com --- Comment #6 from Parag AN(पराग) 2009-07-21 01:58:17 EDT --- *** Bug 512646 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512724] Review Request: perl-Devel-FindRef - Track down reference problems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512724 Parag AN(पराग) changed: What|Removed |Added Status|NEW |ASSIGNED CC||panem...@gmail.com AssignedTo|nob...@fedoraproject.org|panem...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512723] Review Request: perl-Socket-GetAddrInfo - RFC 2553's "getaddrinfo" and "getnameinfo" functions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512723 Parag AN(पराग) changed: What|Removed |Added Status|NEW |ASSIGNED CC||panem...@gmail.com AssignedTo|nob...@fedoraproject.org|panem...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 468516] Review Request: verilator - A fast simulator of synthesizable Verilog HDL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468516 --- Comment #42 from Lane 2009-07-21 01:17:03 EDT --- The "fedora_cvs" flag is not editable for me. How do I make it editable? Perhaps I am not part of the "fedorabugs" group? Or perhaps I am misunderstanding the instructions. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512663] Review Request: langpack-support - Meta packages for Yum langpack support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512663 --- Comment #3 from Jens Petersen 2009-07-21 00:09:34 EDT --- (In reply to comment #1) > Why not build by parsing iso-codes? (Woo, automation!) But seriously so you have a "sketch" or example of how to do it? I am not really sure but if we avoid the package name it might be possible? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512663] Review Request: langpack-support - Meta packages for Yum langpack support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512663 --- Comment #2 from Jens Petersen 2009-07-20 23:09:59 EDT --- It did cross my mind for the language names at least. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 489014] Review Request: gnome-do-plugins - Plugins for Gnome Do
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489014 --- Comment #60 from Jason Tibbitts 2009-07-20 22:37:25 EDT --- It can take quite some time. Go to http://bugz.fedoraproject.org/gnome-do-plugins >From there you can see the status of any builds and updates, and download the packages directly if you don't want to wait for them to be released as stable updates. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 489014] Review Request: gnome-do-plugins - Plugins for Gnome Do
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489014 --- Comment #59 from cschol2...@gmail.com 2009-07-20 22:24:49 EDT --- I don't see the package when searching for 'yum search gnome-do-plugins'. Does it take some time to show up in the repos? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512217] Review Request: geany-plugins - A bundle of plugins for Geany
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512217 --- Comment #28 from Christoph Wickert 2009-07-20 20:10:36 EDT --- (In reply to comment #27) > or is Christoph taking the review as well? No need to, I trust in you and Jochen. I think we all (including Dominic) did a pretty great job so far and the spec is in good shape. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 510734] Review Request: x11vnc - VNC server for the current X11 session
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=510734
--- Comment #15 from manuel wolfshant 2009-07-20
19:55:58 EDT ---
(In reply to comment #13)
> > - does not build in rawhide:
> > https://koji.fedoraproject.org/koji/taskinfo?taskID=1484978 - probably a
> > missing build requirement since X11/extensions/XInput.h can't be found
> Oops. I was built it only on Fedora 11, my mistake.
> Add BR: /usr/include/X11/extensions/XInput.h; In F12 it is located in
> libXi-devel but in previous versions in xorg-x11-proto-devel so, to do not
> make
> conditional requires, require explicit file.
Although technically your solution is correct, I think that performance wise it
is better to use:
%if 0%{?fedora} >= 12
BuildRequires: libXi-devel
%else
BuildRequires: xorg-x11-proto-devel
%endif
>
> Now it built successful:
> http://koji.fedoraproject.org/koji/taskinfo?taskID=1487807
http://koji.fedoraproject.org/koji/taskinfo?taskID=1487918 (F11)
http://koji.fedoraproject.org/koji/taskinfo?taskID=1487913 (rawhide)
http://koji.fedoraproject.org/koji/taskinfo?taskID=1487923 (EL-5)
Mind that EL-5 build fails because of the lzo dependency (
http://koji.fedoraproject.org/koji/getfile?taskID=1487925&name=build.log ):
ultra.c:11:21: error: minilzo.h: No such file or directory
ultra.c: In function 'rfbSendOneRectEncodingUltra':
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509310] Review Request: gpointing-device-settings - Configuration tool for pointing devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509310 --- Comment #10 from Gianluca Sforna 2009-07-20 19:40:58 EDT --- OK, applied some changes (same SPEC URL) Added Obsoletes/Provides gsynaptics (please double check those) (In reply to comment #9) > Before I post the full review, here are some issues I've found so far: > > * sources: TODO > - please fix Source0 according to the example in the guidelines: > http://fedoraproject.org/wiki/Packaging:SourceURL > (you should also verify that spectool -g works correctly and retrieves the > source file Fixed, but unfortunately I can't use the common example with sf.jp > > * subpackage for libgpds: TODO > - the naming is not consistent: > packagename: libgpds > library name: libgpds (incl. SONAME) > include path for header files: /usr/include/gpointing-device-settings > pkgconfig file: libgpointing-device-settings.pc > library flags in the pkgconfig file: -lgpointing-device-settings > - at least the last problem must be fixed - otherwise the pkgconfig file can't > be used to link anything against this library > - preferably also the include path and the pkgconfig file name could be fixed > I am not sure how should I fix that. any pointers? > * BuildRequires: TODO > - if there is no specific reason, only gettext (and not gettext-devel) should > be a BR Fixed > > * package owns all directories that it creates: TODO > - files are copied into /usr/lib/gnome-settings-daemon-2.0, but it is neither > owned by this package nor is the owner of this directory required > - I suggest to add: Requires: gnome-settings-daemon good catch: added > > * the corresponding gsynaptics configuration dialog has a menu item in System > -> Preferences -> Touchpad > - IMHO the same should be done for gpointing-device-settings - please create > an > appropriate *.desktop file As far as I understand it, that is something like a test program I'd rather not expose to end users in the menu -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 510734] Review Request: x11vnc - VNC server for the current X11 session
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=510734 --- Comment #14 from Pavel Alexeev (aka Pahan-Hubbitus) 2009-07-20 18:45:45 EDT --- My 2 cent in embed/shared minilzo discussion. A also want see all libraries in system only in 1 exemplar (where it is possible off course) to have slender system where all on self places. And, one small note: (In reply to comment #10) > Even if I also don't like the large patch to use the external (mini)lzo > library, I still think it is the correct way: About what large patch you are speaking? There few string cuts, and size only to file deletion. I can delete it in spec by 1 command... or even this is not necessary! So I only ask: It there any real advantages to use static build? Speed? Size? For what we should try change existing guidelines? Why shared linking should be with full lzo, not minimalistic minilzo, if it is enough? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 510734] Review Request: x11vnc - VNC server for the current X11 session
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=510734
--- Comment #13 from Pavel Alexeev (aka Pahan-Hubbitus)
2009-07-20 18:35:42 EDT ---
(In reply to comment #8)
> - lots of rpmlint errors:
> * README/AUTHORS not UTF-8, please convert them in the %prep section via iconv
> (please make sure to preserve the timestamp, e.g. by using "touch -c -r
> old_file"
> * wrong permissions of some of the *.c files, please change the permission to
> 644 in the %prep section
Excuse me - I don't understand you. *.c files it is sources and they only built
and do not go in any packages. Why I shoud care about its permissions? And what
mean "wrong" in this context? BTW rpmlint offcourse silent about it.
> - the indentation seems to be broken - just open the file with vim or gedit
No. Just I use tabsize = 5 spaces.
> - please delete the commented Packager: and Vendor: tags, it should be
> sufficient to add to your first changelog entry that this spec file is based
> on
> a version from Dag Wieers
>
> - delete the old non-Fedora changelog entries
Ok, I slightly modify it - add historical packagers in changelog, and clear it.
> - correct the Source: line
> * use Source0 for the primary source file
Renamed. Is there any difference in it? I remember it may have sense in
patches... in sources too?
> * for sf.net please use something like this:
> http://downloads.sourceforge.net/libvncserver/%{name}-%{version}.tar.gz
> * see also http://fedoraproject.org/wiki/Packaging:SourceURL for details
> * verify via "spectool -g x11vnc.spec" whether the sources can be downloaded
> using the provided URL
Sorry, it is historical URL, some time ago it was correct as i remember.
Fixed.
> - does not build in rawhide:
> https://koji.fedoraproject.org/koji/taskinfo?taskID=1484978 - probably a
> missing build requirement since X11/extensions/XInput.h can't be found
Oops. I was built it only on Fedora 11, my mistake.
Add BR: /usr/include/X11/extensions/XInput.h; In F12 it is located in
libXi-devel but in previous versions in xorg-x11-proto-devel so, to do not make
conditional requires, require explicit file.
Now it built successful:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1487807
> - check for spelling mistakes in the comments ;-) ("pathc")
I'm try, seriously. My English skills is very low. So do not hesitate point me
on such errors too.
>
> - the source as well as the built package contain some java clients:
> * only the server components are mentioned in the %description
> * if the clients should be shipped, then put them into separate sub-package
> * it is not allowed to use the pre-built JARs
> * preferably the pre-built JARs should not even be shipped in the sources (see
> http://fedoraproject.org/wiki/Packaging:Java for details)
Off course! Such binaries removed in %install stage.
> - "Requires: minilzo" is wrong, since there is no package "minilzo". Since
> x11vnc is linked against libminilzo.so.0, the dependency should be
> automatically added to the binary rpm:
> rpm --requires -qp ~rpmbuild/RPMS/i386/x11vnc-0.9.8-3.fc10.i386.rpm |grep lzo
> libminilzo.so.0
Fixed.
> - would it be an option to use the system's libvncserver library instead of
> the
> internal one? (--use-system-libvncserver
This is very interesting question. I think it is will be "right" solution.
Additionally it completely solve minilzo problem as I can understand.
I try use it now (add --with-system-libvncserver). Add BR libvncserver-devel
But I have errors (
http://koji.fedoraproject.org/koji/getfile?taskID=1487784&name=build.log )
several "undefined reference" like:
/builddir/build/BUILD/x11vnc-0.9.8/x11vnc/connections.c:3161: undefined
reference to `rfbUnregisterTightVNCFileTransferExtension'
x11vnc-connections.o: In function `client_gone':
/builddir/build/BUILD/x11vnc-0.9.8/x11vnc/connections.c:726: undefined
reference to `rfbRegisterTightVNCFileTransferExtension'
x11vnc-help.o:make[3]: Leaving directory
`/builddir/build/BUILD/x11vnc-0.9.8/x11vnc'
In function `print_help':
/builddir/build/BUILD/x11vnc-0.9.8/x11vnc/help.c:4862: undefined reference to
`rfbRegisterTightVNCFileTransferExtension'
Disable this option now, but continue investigation there...
>
> - when you upload a new version, please also provide also a link to the spec
> file - this makes it easier to just have a quick look at it
I'm each time upload new spec-file with new src.rpm one. But as it is not
versioned (have not version in name) I just omit it link each time, because it
is present in initial report. Sorry for confusion.
http://hubbitus.net.ru/rpm/Fedora11/x11vnc/x11vnc-0.9.8-4.fc11.src.rpm
http://hubbitus.net.ru/rpm/Fedora11/x11vnc/x11vnc.spec
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
[Bug 509310] Review Request: gpointing-device-settings - Configuration tool for pointing devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509310 --- Comment #9 from Christian Krause 2009-07-20 18:07:13 EDT --- Before I post the full review, here are some issues I've found so far: * sources: TODO - please fix Source0 according to the example in the guidelines: http://fedoraproject.org/wiki/Packaging:SourceURL (you should also verify that spectool -g works correctly and retrieves the source file * subpackage for libgpds: TODO - the naming is not consistent: packagename: libgpds library name: libgpds (incl. SONAME) include path for header files: /usr/include/gpointing-device-settings pkgconfig file: libgpointing-device-settings.pc library flags in the pkgconfig file: -lgpointing-device-settings - at least the last problem must be fixed - otherwise the pkgconfig file can't be used to link anything against this library - preferably also the include path and the pkgconfig file name could be fixed * BuildRequires: TODO - if there is no specific reason, only gettext (and not gettext-devel) should be a BR * package owns all directories that it creates: TODO - files are copied into /usr/lib/gnome-settings-daemon-2.0, but it is neither owned by this package nor is the owner of this directory required - I suggest to add: Requires: gnome-settings-daemon * the corresponding gsynaptics configuration dialog has a menu item in System -> Preferences -> Touchpad - IMHO the same should be done for gpointing-device-settings - please create an appropriate *.desktop file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512217] Review Request: geany-plugins - A bundle of plugins for Geany
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512217 --- Comment #27 from Jonathan Underwood 2009-07-20 17:42:42 EDT --- Excellent. Where are we with the review - is Christian mentoring and Jochen reviewing the package, or is Christoph taking the review as well? Dominic - I'd happily welcome help on the main geany package as well if you wanted - request co-maintainership of that package in pkgdb when you're all set up as a fedora contributor. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509936] Review Request: tortoisehg - Mercurial gui tools and nautilus plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509936 --- Comment #3 from Mads Kiilerich 2009-07-20 17:33:18 EDT --- Thanks for the comments. Previous tar balls didn't contain po files but only mo files, so there were no need for gettext on build time. Upstream has changed that now and I added gettext as build requirement. I just _knew_ the license was GPLv2 and failed to review it... Upstream has clarified that it is GPLv2 - see http://n2.nabble.com/-thg-dev--TortoiseHg-license-tp3286436p3286246.html and http://n2.nabble.com/-thg-dev--TortoiseHg-license-tp3286436p3289824.html . A copy of iniparse has been dropped. A few files are under the more permissive GPLv2+, but this project is GPLv2 anyway. I have updated the spec to temporarily use the development branch where these changes are included. http://kiilerich.com/tortoisehg.spec http://kiilerich.com/tortoisehg-0.8-4.6da01818c9ea.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 501573] Review Request: ndoutils - Stores data from Nagios in a database
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=501573
--- Comment #14 from Steve Traylen 2009-07-20 17:28:54
EDT ---
Thanks for all the comments, hopefully all addressed:
http://cern.ch/steve.traylen/ndoutils-rpm/ndoutils-1.4-0.4.b7.fc11.src.rpm
http://cern.ch/steve.traylen/ndoutils-rpm/ndoutils.spec
from the .spec file:
- Patch ndomod.o to be ndomod.so since it was a shared object.
- Move ndomod.so from /usr/lib to /usr/lib/nagios/brokers
- Change URL to better one.
- Change SourceURL to fedora package guideline for sourceforge.
- Completely removed postgres support. The documents clearly state
it is not supported.
In particular postgres is mentioned as not being supported in the docs and
moreover in the new b8 release it is even removed from the configure
options. Consequently I have removed all traces of postgres support. It
can be added later.
In fact the .a file in /usr/lib was a .so file but hardcoded to be a .a.
This is now patched to be a .so. Concerning your question about where it
should go this ndomod.so is the same to nagios as say mod_alias.so is to
httpd. So I put in /usr/lib/nagios/brokers which makes a lot more sense.
A good koji build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1487645
rpmlint ndoutils-1.4-0.4.b7.fc11.src.rpm \
ndoutils-1.4-0.4.b7.fc11.x86_64.rpm \
ndoutils-mysql-1.4-0.4.b7.fc11.x86_64.rpm
ndoutils.x86_64: W: non-standard-uid /var/cache/ndoutils nagios
ndoutils.x86_64: W: non-standard-uid /var/run/ndoutils nagios
ndoutils.x86_64: W: non-standard-uid /var/log/ndoutils nagios
ndoutils.x86_64: W: log-files-without-logrotate /var/log/ndoutils
ndoutils.x86_64: W: incoherent-init-script-name ndo2db ('ndoutils',
'ndoutilsd')
which are all explained above.
Steve.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507958] Review Request: eclipse-rse - Eclipse Remote System Explorer framework
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=507958
--- Comment #2 from Jeff Johnston 2009-07-20 17:16:46
EDT ---
(In reply to comment #1)
> Thanks for the submission, Jeff. A few comments:
>
> - I think you're missing Requires on eclipse-cdt and eclipse-emf
done
> - will we move to 3.1 once we get a Galileo CDT build?
Yes. CDT 6.0 only requires RSE >= 3.0.
> - please use either %{buildroot} or $RPM_BUILD_ROOT but not both
done
> - we should perhaps have Eclipse in the Summary field
done
> - I think "framework" can be dropped from the Summary field
ok, done
> - please change the permissions on the fetch script to avoid this rpmlint
> warning:
>
> eclipse-rse.src: W: strange-permission fetch-rse.sh 0775
>
done
> - you should probably mark a top-level feature's about.html as %doc
done. I get a warning about file being specified twice, but I don't see any
other examples in any of the other eclipse projects.
> - you should look for @build@ and replace it with the same qualifier that
> upstream uses. In fact, you should use forceContextQualifier (see
> eclipse-mylyn.spec for an example) to ensure our versions are the same as
> upstream's for 3.0.3
>
I can't use forceContextQualifier because the versions are being set by map
files. The RSE project has many version qualifiers for the various plugins and
features. It does not create a single build id for a release and none of the
qualifiers are filled in for the various tags. I have fixed this by using the
map files to a) fetch the plugins/features for the tarball b) create a
featureVersions.properties and pluginVersions.properties file from the same map
files. Both a and b are performed in the fetch-rse.sh script. The build now
matches the upstream version numbers, including the suffixes which are used for
features. I have opened an RFE for pdebuild to allow map files to be specified
which should make this easier for future rpm packaging.
> The package builds for me, follows the packaging guidelines, and functions in
> Eclipse. Thanks for the high quality submission. Once the minor issues above
> are cleaned up, I will approve this.
Thanks.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507958] Review Request: eclipse-rse - Eclipse Remote System Explorer framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507958 --- Comment #3 from Jeff Johnston 2009-07-20 17:17:36 EDT --- I forgot to mention that I have overwritten the spec file and SRPM: Spec URL: ftp://sources.redhat.com/pub/newlib/eclipse-rse.spec SRPM URL: ftp://sources.redhat.com/pub/newlib/eclipse-rse-3.0.3-1.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509990] Review Request: CVE-2008-0166_fingerprints - Fingerprints of the keys affected by CVE-2008-0166
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509990 Milos Jakubicek changed: What|Removed |Added CC||xja...@fi.muni.cz Flag|fedora-review? |fedora-review+, fedora-cvs? --- Comment #12 from Milos Jakubicek 2009-07-20 17:14:43 EDT --- You set fedora-review?, I guess you wanted fedora-cvs? => correcting. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512217] Review Request: geany-plugins - A bundle of plugins for Geany
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512217 --- Comment #26 from Dominic Hopf 2009-07-20 17:06:19 EDT --- (In reply to comment #25) > Yes, you're right - I'd missed that enchant requires libhunspell. More coffee > needed. Don't worry about that. Just for Information: Upstream is planning to release geany-plugins-0.17.1 soon. This version will include miscellaneous fixes and also fill up the zero-length documentation files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509990] Review Request: CVE-2008-0166_fingerprints - Fingerprints of the keys affected by CVE-2008-0166
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509990 Jan F. Chadima changed: What|Removed |Added AssignedTo|mc...@redhat.com|ska...@redhat.com Flag|fedora-review+ |fedora-review? --- Comment #11 from Jan F. Chadima 2009-07-20 16:49:50 EDT --- New Package CVS Request === Package Name: openssh-blacklist Short Description: Fingerprints of the openssh keys affected by CVE-2008-0166 Owners: jfch Branches: F-10 F-11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509990] Review Request: CVE-2008-0166_fingerprints - Fingerprints of the keys affected by CVE-2008-0166
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509990 Matej Cepl changed: What|Removed |Added AssignedTo|ska...@redhat.com |mc...@redhat.com Flag|fedora-review? |fedora-review+ --- Comment #10 from Matej Cepl 2009-07-20 16:42:12 EDT --- Yeah, like it. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 506339] Review Request: XZ Utils - LZMA Utils with newer file format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=506339 Toshio Ernie Kuratomi changed: What|Removed |Added CC||a.bad...@gmail.com Flag|fedora-cvs+ |fedora-cvs? --- Comment #34 from Toshio Ernie Kuratomi 2009-07-20 16:22:37 EDT --- Talked with notting. We want to branch this so it's available in infrastructure. Builders will be running with a copy from the builder-rpms repo for now but long term it's better to have it in epel. Package Change Request == Package Name: xz New Branches: EL-5 Owners: toshio -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512500] Review Request: multimedia-menus - Categorization for the GNOME/KDE Audio&Video/Multimedia menu
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512500 --- Comment #7 from Orcan 'oget' Ogetbil 2009-07-20 16:13:36 EDT --- Thanks Rahul, I will definitely do that. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512270] Review Request: quitcount - A tool for people who quit smoking
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512270 --- Comment #10 from Fedora Update System 2009-07-20 16:00:34 EDT --- quitcount-1.4.1-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/quitcount-1.4.1-2.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512270] Review Request: quitcount - A tool for people who quit smoking
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512270 --- Comment #9 from Fedora Update System 2009-07-20 16:00:29 EDT --- quitcount-1.4.1-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/quitcount-1.4.1-2.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 464430] Review Request: k12linux-quick-start-guide - Doc describing how to enable LTSP on Fedora Live LTSP.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=464430 Warren Togami changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||CURRENTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512748] Adding new package to f11, f12 - matahari
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512748 --- Comment #4 from Jason Tibbitts 2009-07-20 14:44:51 EDT --- We're welcome to improvements to the documentation, but I recall there's even a request not to open separate tickets in http://fedoraproject.org/wiki/CVS_admin_requests -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483421] Review Request: apophysis-j - Fractal flame editor and creator, based on Apophysis
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483421 --- Comment #5 from Ian Weller 2009-07-20 14:33:07 EDT --- Will talk to upstream. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512748] Adding new package to f11, f12 - matahari
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512748 --- Comment #3 from Arjun Roy 2009-07-20 13:57:11 EDT --- Woops. Anyways, the documentation didn't make it clear that one reuses the same ticket to request cvs. Back to the other one, then. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511148] Review Request: matahari - qmf agent for host management
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511148 Arjun Roy changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from Arjun Roy 2009-07-20 13:58:03 EDT --- New Package CVS Request === Package Name: matahari Short Description: host qmf agent used by ovirt Owners: arjunroy Branches: F-11 F-12 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 --- Comment #24 from Fedora Update System 2009-07-20 13:31:47 EDT --- xylib-0.4-4.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/xylib-0.4-4.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507660] Review Request: xylib - Library for reading x-y data from several file formats
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507660 --- Comment #25 from Fedora Update System 2009-07-20 13:31:53 EDT --- xylib-0.4-4.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/xylib-0.4-4.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512725] Review Request: perl-Devel-Refcount - Obtain the REFCNT value of a referent
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=512725
Ralf Corsepius changed:
What|Removed |Added
CC||rc040...@freenet.de
--- Comment #1 from Ralf Corsepius 2009-07-20 13:24:04
EDT ---
2 remarks:
* ...
%{perl_vendorarch}/*
%exclude %dir %{perl_vendorarch}/auto/
I for one find using
%{perl_vendorarch}/Devel
%{perl_vendorarch}/auto/Devel
much more readable and less error-prone
* Nicolas, are you familiar with cpanspec?
Me thinks, you might be one of the very few persons who are still manually
writing perl-specs from scratch.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503586] Review Request: python-tgext-crud - Crud Controller Extension for TG2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503586 Luke Macken changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #8 from Luke Macken 2009-07-20 13:23:13 EDT --- New Package CVS Request === Package Name: python-tgext-crud Short Description: Crud Controller Extension for TG2 Owners: lmacken Branches: F-10 F-11 EL-5 InitialCC: johnp -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511938] Review Request: cld - Coarse locking daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511938 Jeff Garzik changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503586] Review Request: python-tgext-crud - Crud Controller Extension for TG2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503586 --- Comment #7 from John (J5) Palmieri 2009-07-20 13:18:29 EDT --- approved -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512748] Adding new package to f11, f12 - matahari
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512748 Jason Tibbitts changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 489014] Review Request: gnome-do-plugins - Plugins for Gnome Do
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489014 --- Comment #58 from Juan Manuel Rodriguez 2009-07-20 13:02:36 EDT --- Thanks Toshio and Kevin! Package has been built and commited for F11 and Rawhide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503672] Review Request: python-webpy - A simple web framework for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503672 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||0.32-3.el4 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503672] Review Request: python-webpy - A simple web framework for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503672 Fedora Update System changed: What|Removed |Added Fixed In Version|0.32-3.el4 |0.32-3.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503672] Review Request: python-webpy - A simple web framework for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503672 --- Comment #25 from Fedora Update System 2009-07-20 12:56:43 EDT --- python-webpy-0.32-3.el4 has been pushed to the Fedora EPEL 4 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 503672] Review Request: python-webpy - A simple web framework for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=503672 --- Comment #26 from Fedora Update System 2009-07-20 12:57:22 EDT --- python-webpy-0.32-3.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508954] Review Request: volume_key - An utility for manipulating storage encryption keys and passphrases
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508954 Jochen Schmitt changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #12 from Jochen Schmitt 2009-07-20 12:26:42 EDT --- O; as far as I can see you package is ok and can APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511938] Review Request: cld - Coarse locking daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511938 --- Comment #17 from Mike Bonnet 2009-07-20 12:19:14 EDT --- Package review is complete, and cld is available in Koji. https://koji.fedoraproject.org/koji/packageinfo?packageID=8850 You can go ahead and close this bug with NEXTRELEASE. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512748] Adding new package to f11, f12 - matahari
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512748 Itamar Reis Peixoto changed: What|Removed |Added Status|NEW |CLOSED CC||ita...@ispbrasil.com.br Resolution||DUPLICATE --- Comment #2 from Itamar Reis Peixoto 2009-07-20 12:20:22 EDT --- you should request cvs at BZ #511148 and you don't need to specify F-12 branch, because it's current devel (F-12 = devel ) and it's automatically created. *** This bug has been marked as a duplicate of 511148 *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511148] Review Request: matahari - qmf agent for host management
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511148 --- Comment #6 from Itamar Reis Peixoto 2009-07-20 12:20:22 EDT --- *** Bug 512748 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512748] Adding new package to f11, f12 - matahari
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512748 --- Comment #1 from Arjun Roy 2009-07-20 12:15:29 EDT --- Approved at : https://bugzilla.redhat.com/show_bug.cgi?id=511148 More info at: http://arjunroy.fedorapeople.org/matahari/index.html Matahari is a host qmf agent used by ovirt for node management, but isn't specific to ovirt. Thus, it is a separate package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512748] New: Adding new package to f11, f12 - matahari
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Adding new package to f11, f12 - matahari https://bugzilla.redhat.com/show_bug.cgi?id=512748 Summary: Adding new package to f11, f12 - matahari Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: ar...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: --- Arjun Roy changed: What|Removed |Added Flag||fedora-cvs? New Package CVS Request === Package Name: matahari Short Description: host qmf agent used by ovirt Owners: arjunroy Branches: F-11 F-12 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512729] Review Request: perl-IO-Async - A collection of modules that implement asynchronous filehandle IO
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512729 --- Comment #1 from Nicolas Chauvet (kwizart) 2009-07-20 11:29:04 EDT --- Spec URL: http://kwizart.fedorapeople.org/review/perl-IO-Async.spec SRPM URL: http://kwizart.fedorapeople.org/review/perl-IO-Async-0.22-1.fc11.src.rpm Description: A collection of modules that implement asynchronous filehandle IO Changelog: Update to 0.22 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 489014] Review Request: gnome-do-plugins - Plugins for Gnome Do
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489014 --- Comment #57 from Fedora Update System 2009-07-20 11:26:32 EDT --- gnome-do-plugins-0.8.1-4.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/gnome-do-plugins-0.8.1-4.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512729] Review Request: perl-IO-Async - A collection of modules that implement asynchronous filehandle IO
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512729 Nicolas Chauvet (kwizart) changed: What|Removed |Added Blocks||512553 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512727] New: Review Request: perl-Async-MergePoint - Resynchronise diverged control flow
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-Async-MergePoint - Resynchronise diverged control flow https://bugzilla.redhat.com/show_bug.cgi?id=512727 Summary: Review Request: perl-Async-MergePoint - Resynchronise diverged control flow Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: kwiz...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://kwizart.fedorapeople.org/review/perl-Async-MergePoint.spec SRPM URL: http://kwizart.fedorapeople.org/review/perl-Async-MergePoint-0.03-1.fc11.src.rpm Description: Resynchronise diverged control flow -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512729] New: Review Request: perl-IO-Async - A collection of modules that implement asynchronous filehandle IO
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-IO-Async - A collection of modules that implement asynchronous filehandle IO https://bugzilla.redhat.com/show_bug.cgi?id=512729 Summary: Review Request: perl-IO-Async - A collection of modules that implement asynchronous filehandle IO Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: kwiz...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://kwizart.fedorapeople.org/review/perl-IO-Async.spec SRPM URL: http://kwizart.fedorapeople.org/review/perl-IO-Async-0.21-1.fc11.src.rpm Description: A collection of modules that implement asynchronous filehandle IO -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512729] Review Request: perl-IO-Async - A collection of modules that implement asynchronous filehandle IO
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512729 Nicolas Chauvet (kwizart) changed: What|Removed |Added Depends on||512723, 512726, 512727 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512727] Review Request: perl-Async-MergePoint - Resynchronise diverged control flow
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512727 Nicolas Chauvet (kwizart) changed: What|Removed |Added Blocks||512729 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512723] Review Request: perl-Socket-GetAddrInfo - RFC 2553's "getaddrinfo" and "getnameinfo" functions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512723 Nicolas Chauvet (kwizart) changed: What|Removed |Added Blocks||512729 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512726] Review Request: perl-Test-Refcount - Assert reference counts on objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512726 Nicolas Chauvet (kwizart) changed: What|Removed |Added Blocks||512729 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511246] Review Request: pacemaker - cman/rgmanager alternative
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511246 --- Comment #4 from Andrew Beekhof 2009-07-20 11:09:52 EDT --- Oh, and I forgot to mention that it no longer needs an updated version of corosync to compile. The current one from rawhide is sufficient. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512726] New: Review Request: perl-Test-Refcount - Assert reference counts on objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-Test-Refcount - Assert reference counts on objects https://bugzilla.redhat.com/show_bug.cgi?id=512726 Summary: Review Request: perl-Test-Refcount - Assert reference counts on objects Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: kwiz...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://kwizart.fedorapeople.org/review/perl-Test-Refcount.spec SRPM URL: http://kwizart.fedorapeople.org/review/perl-Test-Refcount-0.05-1.fc11.src.rpm Description: Assert reference counts on objects -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512724] Review Request: perl-Devel-FindRef - Track down reference problems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512724 Nicolas Chauvet (kwizart) changed: What|Removed |Added Blocks||512726 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512726] Review Request: perl-Test-Refcount - Assert reference counts on objects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512726 Nicolas Chauvet (kwizart) changed: What|Removed |Added Depends on||512724, 512725 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512725] Review Request: perl-Devel-Refcount - Obtain the REFCNT value of a referent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512725 Nicolas Chauvet (kwizart) changed: What|Removed |Added Blocks||512726 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512724] New: Review Request: perl-Devel-FindRef - Track down reference problems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-Devel-FindRef - Track down reference problems https://bugzilla.redhat.com/show_bug.cgi?id=512724 Summary: Review Request: perl-Devel-FindRef - Track down reference problems Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: kwiz...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://kwizart.fedorapeople.org/review/perl-Devel-FindRef.spec SRPM URL: http://kwizart.fedorapeople.org/review/perl-Devel-FindRef-1.42-1.fc11.src.rpm Description: Track down reference problems -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 508954] Review Request: volume_key - An utility for manipulating storage encryption keys and passphrases
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508954 --- Comment #11 from Miloslav Trmač 2009-07-20 11:03:18 EDT --- If the rest is OK as well, could you formally approve the review, please? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512725] New: Review Request: perl-Devel-Refcount - Obtain the REFCNT value of a referent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-Devel-Refcount - Obtain the REFCNT value of a referent https://bugzilla.redhat.com/show_bug.cgi?id=512725 Summary: Review Request: perl-Devel-Refcount - Obtain the REFCNT value of a referent Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: kwiz...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://kwizart.fedorapeople.org/review/perl-Devel-Refcount.spec SRPM URL: http://kwizart.fedorapeople.org/review/perl-Devel-Refcount-0.06-1.fc11.src.rpm Description: Obtain the REFCNT value of a referent -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511246] Review Request: pacemaker - cman/rgmanager alternative
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511246 --- Comment #3 from Andrew Beekhof 2009-07-20 10:59:05 EDT --- New spec and source rpm (this time for f12): http://oss.clusterlabs.org/~beekhof/fedora/pacemaker.spec http://oss.clusterlabs.org/~beekhof/fedora/pacemaker-1.0.4-2.fc12.src.rpm Conducted a self-review based on http://fedoraproject.org/wiki/Packaging/ReviewGuidelines and made a number of improvements. In particular the spec now references the upstream tarball, the summaries are a little better and (after reading the discussion regarding #!env python fedora-packaging) the wrong-script-interpreter errors have been removed. Here is the new rpmlint output (previous explanations of the remaining errors and warnings still apply): rpmlint ~/rpmbuild/RPMS/x86_64/*pace* pacemaker.spec libpacemaker3.x86_64: W: shared-lib-calls-exit /usr/lib64/libcrmcluster.so.1.0.0 e...@glibc_2.2.5 libpacemaker3.x86_64: W: shared-lib-calls-exit /usr/lib64/libpengine.so.3.0.0 e...@glibc_2.2.5 libpacemaker3.x86_64: W: shared-lib-calls-exit /usr/lib64/libcib.so.1.0.1 e...@glibc_2.2.5 libpacemaker3.x86_64: W: no-documentation libpacemaker-devel.x86_64: W: no-dependency-on libpacemaker/libpacemaker-libs/liblibpacemaker libpacemaker-devel.x86_64: W: no-documentation pacemaker.x86_64: E: non-standard-dir-perm /var/lib/pengine 0750 pacemaker.x86_64: E: non-standard-dir-perm /var/lib/heartbeat/crm 0750 pacemaker.x86_64: E: script-without-shebang /usr/share/pacemaker/constraints-1.0.rng pacemaker.x86_64: E: script-without-shebang /usr/share/pacemaker/crm.dtd pacemaker.x86_64: E: script-without-shebang /usr/share/pacemaker/pacemaker.rng pacemaker.x86_64: E: script-without-shebang /usr/share/pacemaker/rule-1.0.rng pacemaker.x86_64: E: script-without-shebang /usr/share/pacemaker/score.rng pacemaker.x86_64: E: script-without-shebang /usr/share/pacemaker/nvset-1.0.rng pacemaker.x86_64: E: script-without-shebang /usr/share/pacemaker/upgrade06.xsl pacemaker.x86_64: E: script-without-shebang /usr/share/pacemaker/pacemaker-1.0.rng pacemaker.x86_64: E: script-without-shebang /usr/share/pacemaker/resources-1.0.rng pacemaker.x86_64: E: non-standard-dir-perm /var/run/crm 0750 pacemaker.x86_64: E: script-without-shebang /usr/share/pacemaker/crm-transitional.dtd pacemaker.spec:166: E: hardcoded-library-path in /usr/lib/ocf pacemaker.spec:167: E: hardcoded-library-path in /usr/lib/ocf/resource.d pacemaker.spec:168: E: hardcoded-library-path in /usr/lib/ocf/resource.d/pacemaker 4 packages and 1 specfiles checked; 16 errors, 6 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512723] New: Review Request: perl-Socket-GetAddrInfo - RFC 2553's "getaddrinfo" and "getnameinfo" functions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-Socket-GetAddrInfo - RFC 2553's "getaddrinfo" and "getnameinfo" functions https://bugzilla.redhat.com/show_bug.cgi?id=512723 Summary: Review Request: perl-Socket-GetAddrInfo - RFC 2553's "getaddrinfo" and "getnameinfo" functions Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: kwiz...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://kwizart.fedorapeople.org/review/perl-Socket-GetAddrInfo.spec SRPM URL: http://kwizart.fedorapeople.org/review/perl-Socket-GetAddrInfo-0.12-1.fc11.src.rpm Description: RFC 2553's "getaddrinfo" and "getnameinfo" functions -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512663] Review Request: langpack-support - Meta packages for Yum langpack support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512663 --- Comment #1 from Bill Nottingham 2009-07-20 10:52:34 EDT --- Why not build by parsing iso-codes? (Woo, automation!) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 506339] Review Request: XZ Utils - LZMA Utils with newer file format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=506339 --- Comment #33 from Bill Nottingham 2009-07-20 10:49:25 EDT --- (In reply to comment #31) > Will F-10/F-11 users (for instance: package reviewers) be able to open SRPMs > made in rawhide? IMHO, at the least, xz could be held at the testing repos for > some time. If we don't flip the default in rawhide, sure! (Obviously) If we do change the default, we'd need an updated package. I was going to leave the timing of that up to the RPM maintainers, though. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507089] Review Request: olpc-powerd - power management for the XO laptop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507089 --- Comment #7 from Paul Fox 2009-07-20 10:32:48 EDT --- i believe i've addressed all of the FIX issues listed above. rpmlint now gives 0 warnings/0 errors -- however, my development machine is currently fedora 9. i did nothing for the "false positive" error that cwickert reported. regarding comment #5, for the "unsafe" rm -- i changed powerd to clean up after itself, so that the rm in the uninstall is no longer needed. i had the best intentions of testing the install/remove/upgrade paths for the scriptlets this weekend, but was not able to. i agree, given my reading of the spec, with cwickert's proposed implementation in comment #4, and have applied it verbatim. so: here are the new pre-release srpm and spec: http://dev.laptop.org/~pgf/rpms/srpms/olpc-powerd-8-1.20090720git702fd8e.src.rpm http://dev.laptop.org/~pgf/rpms/srpms/olpc-powerd.spec-8-1.20090720git702fd8e and an f-9 rpm: http://dev.laptop.org/~pgf/rpms/olpc-powerd-8-1.20090720git702fd8e.fc9.i386.rpm i will test at earliest opportunity, but if someone else tests sooner, please let me know. many thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 491694] Review Request: Anyterm - Web based terminal emulator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491694 --- Comment #30 from Mohammed Morsi 2009-07-20 10:06:20 EDT --- http://koji.fedoraproject.org/koji/taskinfo?taskID=1486707 rpmlint ~/rpmbuild/RPMS/x86_64/anyterm-1.1.29-8.fc10.x86_64.rpm anyterm.x86_64: W: unstripped-binary-or-object /usr/sbin/anytermd 1 packages and 0 specfiles checked; 0 errors, 1 warnings. (couldn't get this fixed, see above, adding -i to rpmlint doesn't help, but it doesn't seem to affect anything) rpmlint ~/rpmbuild/RPMS/x86_64/anyterm-httpd-1.1.29-8.fc10.x86_64.rpm anyterm-httpd.x86_64: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. (as discussed above, this package is self-documenting, no documentation needed / appropriate for this) rpmlint ~/rpmbuild/SRPMS/anyterm-1.1.29-8.fc10.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 507106] Review Request: msp430-libc - C library for use with GCC on Texas Instruments MSP430 microcontrollers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507106 --- Comment #3 from Robert Spanton 2009-07-20 10:10:04 EDT --- Hey, I've just updated this to own /usr/msp430/include: Spec URL: http://users.ecs.soton.ac.uk/rds/rpm/mspgcc/msp430-libc.spec SRPM URL: http://users.ecs.soton.ac.uk/rds/rpm/mspgcc/msp430-libc-0-2.20090620cvs.fc11.src.rpm Rob -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512574] Review Request: perl-Titanium - Strong, lightweight web application famework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512574 Parag AN(पराग) changed: What|Removed |Added Status|NEW |ASSIGNED CC||panem...@gmail.com AssignedTo|nob...@fedoraproject.org|panem...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512646] Review Request: ibus-table-array30 - Array 30 table of IBus Table.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512646 Parag AN(पराग) changed: What|Removed |Added Status|NEW |ASSIGNED CC||panem...@gmail.com AssignedTo|nob...@fedoraproject.org|panem...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511246] Review Request: pacemaker - cman/rgmanager alternative
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511246 --- Comment #2 from Lon Hohberger 2009-07-20 09:52:22 EDT --- Hey, can we get this reviewed? I don't have the proper powers to do so, but I've gone over it a couple of times with Fabio and Andrew here, and I think the package is pretty high quality. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225725] Merge Review: elinks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225725 Tyler Owen changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||CURRENTRELEASE Flag|needinfo?(tyler.l.o...@gmai | |l.com) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512674] Review Request: python-iwlib - Python module to interface with iwlib
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512674 Dan Horák changed: What|Removed |Added Status|NEW |ASSIGNED CC||d...@danny.cz AssignedTo|nob...@fedoraproject.org|d...@danny.cz Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 505356] Review Request: php-PHPMailer - PHP email transport class with a lot of features
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505356 --- Comment #7 from Patrick Monnerat 2009-07-20 08:43:39 EDT --- The URL change (redirection) is very new: next RPM will be updated accordingly. About the "Require" comment: I agree with you, but no usable php (either php or php-cli) will be brought in if you "yum install php-PHPMailer". Only php-common. The best solution would be something like "Provide: php-runtime" in php and php-cli, that can be "Require"d in other modules (a bit like "webserver" in apache and other http servers). Thanks for you comments above. I will wait your review before issuing the next release. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 446989] Review Request: python-epsilon - A small utility package that depends on tools too recent for Twisted
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=446989
Yaakov Nemoy changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+,
||needinfo?(mauricio.teixeira
||@gmail.com)
--- Comment #9 from Yaakov Nemoy 2009-07-20
07:52:03 EDT ---
MUST: rpmlint must be run on every package. The output should be posted in the
review.[1]
python-epsilon.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 7, tab: line
16)
-- Not a show stopper, but should be fixed before going to rawhide.
MUST: The package must be named according to the Package Naming Guidelines .
-- CHECK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. [2] .
-- CHECK
MUST: The package must meet the Packaging Guidelines .
-- CHECK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
-- CHECK
MUST: The License field in the package spec file must match the actual license.
[3]
-- CHECK
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.[4]
-- CHECK
MUST: The spec file must be written in American English. [5]
-- CHECK
If you could call technical language 'English' :P
MUST: The spec file for the package MUST be legible. [6]
-- CHECK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
-- CHECK
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. [7]
-- CHECK
MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. [8]
-- CHECK
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
-- CHECK
MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9]
-- CHECK
MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun. [10]
-- CHECK
MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker. [11]
-- CHECK
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory. [12]
-- CHECK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. [13]
-- CHECK
MUST: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line. [14]
-- CHECK
MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT). [15]
-- CHECK
MUST: Each package must consistently use macros. [16]
-- CHECK
MUST: The package must contain code, or permissable content. [17]
-- CHECK
MUST: Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity). [18]
-- CHECK
MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present. [18]
-- CHECK
MUST: Header files must be in a -devel package. [19]
-- CHECK
MUST: Static libraries must be in a -static package. [20]
-- CHECK
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for
directory ownership and usability). [21]
-- CHECK
MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package. [19]
-- CHE
[Bug 512500] Review Request: multimedia-menus - Categorization for the GNOME/KDE Audio&Video/Multimedia menu
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512500 Rahul Sundaram changed: What|Removed |Added CC||sunda...@redhat.com --- Comment #6 from Rahul Sundaram 2009-07-20 07:15:01 EDT --- Just a note that if you want to change the fd.o categories, you should consider posting to xdg-list http://lists.freedesktop.org/mailman/listinfo/xdg I don't expect it to change anything immediately but would be good to share ideas. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509990] Review Request: CVE-2008-0166_fingerprints - Fingerprints of the keys affected by CVE-2008-0166
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509990 --- Comment #9 from Jan F. Chadima 2009-07-20 06:56:29 EDT --- I've changed name of package as propossed to openssh-blacklist, aded URL to upstream. Now the package is awailable at Spec URL: http://www.benhur.prf.cuni.cz/medved-7/wydobitki/fedora/openssh-blacklist/openssh-blacklist.spec SRPM URL: http://www.benhur.prf.cuni.cz/medved-7/wydobitki/fedora/openssh-blacklist/openssh-blacklist-0.7-1.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512674] New: Review Request: python-iwlib - Python module to interface with iwlib
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: python-iwlib - Python module to interface with iwlib https://bugzilla.redhat.com/show_bug.cgi?id=512674 Summary: Review Request: python-iwlib - Python module to interface with iwlib Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: jpope...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: --- Spec URL: http://jpopelka.fedorapeople.org/python-iwlib.spec SRPM URL: http://jpopelka.fedorapeople.org/python-iwlib-0.1-1.fc11.src.rpm Description: Python bindings for the iwlib kernel interface, that provides functions to examine the wireless network devices installed on the system. This package will be used by system-config-network instead of rhpl.iwlib. I ripped out the rhpl.iwlib, because rhpl will probably be dropped for Fedora 12. See: https://bugzilla.redhat.com/show_bug.cgi?id=508988 This is my first package, but I'm already sponsored. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511895] Review Request: clutter-imcontext - IMContext Framework Library for Clutter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511895 --- Comment #5 from Peter Robinson 2009-07-20 06:19:06 EDT --- SRPM: http://pbrobinson.fedorapeople.org/clutter-imcontext-0.1.2-3.fc11.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1486257 Updated. The license issue has been clarified and I've put a note in the spec file until the next release which will fix the issue completely. Response below and quoted in the spec file. http://lists.moblin.org/pipermail/dev/2009-July/005522.html I've updated all of the above. Thanks -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 477683] Review Request: fltk2 - C++ user interface toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477683 --- Comment #19 from Michal Nowak 2009-07-20 05:57:06 EDT --- http://mnowak.fedorapeople.org/fltk2/fltk2-2.0.x-0.13.r6829.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511276] Review Request: comoonics-base-py - Comoonics minimum baselibraries written in Python
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=511276
--- Comment #6 from Nils Philippsen 2009-07-20 05:53:50
EDT ---
First round :-). I'd appreciate if you would check the issues listed below in
your other packages pending review, this would make their reviews so much
simpler. Thanks!
Items marked "GOOD" or "PASS" fulfil the guidelines or they don't apply to this
package.
Items marked "CHECK" aren't covered by the guidelines but you should check and
fix them anyway in my opinion.
Items marked "BAD" violate the guidelines in some point and need to be fixed.
- BAD: rpmlint run on comoonics-base-py-0-1-1.src.rpm flags errors/warnings:
comoonics-base-py.src: E: description-line-too-long comoonics.ComDataObject:
abstract basic DOM-Based class that is base for any other DOM-Based class
comoonics-base-py.src: E: description-line-too-long comooncis.ComExceptions:
the library provides a base class for all comoonics exceptions.
comoonics-base-py.src: E: description-line-too-long comoonics.ComSystem:
library for some commonly used functions to execute commands.
--> description lines must be 79 characters or shorter, please shorten (and fix
the typo "comooncis.ComExceptions:..." while you're at it)
comoonics-base-py.src: E: no-changelogname-tag
--> start and maintain a package changelog, see
https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs
comoonics-base-py.src: W: invalid-license GPL
--> I've looked at a few source files which state that they are licensed under
GPL version 3 or later, this would make the license "GPLv3+". It would be nice
if the package contained a README making this explicit for the whole package as
well as a copy of the license (since you're upstream, this should be no
problem). Be sure to bump the upstream/tarball version when you do this though.
comoonics-base-py.src: W: non-coherent-filename comoonics-base-py-0-1-1.src.rpm
comoonics-base-py-0.1-1.src.rpm
--> I think this is only some typo from copying the file over to your
webserver, correct?
comoonics-base-py.src:17: W: hardcoded-packager-tag Marc
--> please get rid of the Packager:/Vendor: lines, see
https://fedoraproject.org/wiki/Packaging/Guidelines#Tags
comoonics-base-py.src:38: W: setup-not-quiet
--> use "%setup -q" -- by the way, what's the business with
%version/%unmangled_version? As it is, they're the same and packages should
have the same version number as their upstream as well. If you're thinking
about alpha/beta versions, please see
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Version for
more info -- you (as upstream) will make your life (as packager) much easier
then. Also, using "%define name foo", then "Name: %name" and the like is
unnecessary, if you just define name, versino, release the normal way, the
corresponding macros will be set as well.
comoonics-base-py.src: E: no-cleaning-of-buildroot %install
1 packages and 0 specfiles checked; 5 errors, 4 warnings.
--> clean the build root as described in
https://fedoraproject.org/wiki/Packaging/Guidelines#Tags (just like in %clean)
before installing
- GOOD: package name according to guidelines:
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Addon_Packages_.28python_modules.29
(only fix the source rpm file name please)
- GOOD: spec file named properly
- GOOD/CHECK: licensing mostly clear (see above, an added README would be good)
and according to licensing guidelines
https://fedoraproject.org/wiki/Packaging/LicensingGuidelines
- CHECK: license files are not shipped as documentation, but they aren't
shipped in the upstream tarball, see
https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text --
since you're upstream you really should ship it though ;-)
- GOOD: the spec file is written in American English
- GOOD: the spec file is legible
- CHECK: no source tarball URL, it would be good if the tarball used were
directly available -- see https://fedoraproject.org/wiki/Packaging/SourceURL
- BAD: doesn't build in mock for x86_64/Rawhide
- BAD: no build dependencies listed
--> at least python-devel is missing as a build dependency (and a dependency of
the generated installable package), see
http://fedoraproject.org/wiki/Packaging:Python
- PASS: doesn't ship locale files
- PASS: no libraries shipped
- BAD/CHECK: package is made relocatable (Prefix: ...), please remove or
justify its use,
https://fedoraproject.org/wiki/Packaging/Guidelines#RelocatablePackages
- BAD: not all shipped directories owned by package, direct dependency or
filesystem
--> instead of using the file list generated by your setup.py, define
%python_sitelib at the top of your spec file and simply list the directory
containing your module, see http://fedoraproject.org/wiki/Packaging:Python :
%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print get_pyt
[Bug 493246] Review Request: Shutter -- a feature-rich screenshot program.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=493246 --- Comment #23 from Liang Suilong 2009-07-20 05:43:53 EDT --- Jan Klepek Here is a new srpm and spec file. SRPM:http://liangsuilong.fedorapeople.org/shutter/shutter-0.80-3.fc11.src.rpm SPEC:http://liangsuilong.fedorapeople.org/shutter/shutter.spec I have listed perl(X11::Protocol) in requires. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512663] New: Review Request: langpack-support - Meta packages for Yum langpack support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: langpack-support - Meta packages for Yum langpack support https://bugzilla.redhat.com/show_bug.cgi?id=512663 Summary: Review Request: langpack-support - Meta packages for Yum langpack support Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: peter...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: --- Spec URL: http://petersen.fedorapeople.org/langpack-support/langpack-support.spec SRPM URL: http://petersen.fedorapeople.org/langpack-support/langpack-support-0.0-1.fc11.src.rpm Description: See https://fedoraproject.org/wiki/Features/YumLangpackPlugin The package should provide the langpack meta packages for each language with langpacks in Fedora. There will be a separate package review for the yum plugin itself soon which I will link to this bug. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512663] Review Request: langpack-support - Meta packages for Yum langpack support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512663 Jens Petersen changed: What|Removed |Added Alias||langpack-support -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 510533] Review Request: ghc-editline - Haskell editline library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=510533 --- Comment #6 from Yaakov Nemoy 2009-07-20 04:38:59 EDT --- Please don't forget to close this bug once you have a package built and pushed to rawhide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509310] Review Request: gpointing-device-settings - Configuration tool for pointing devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509310 --- Comment #8 from Gianluca Sforna 2009-07-20 04:42:04 EDT --- sorry, does not look like the right stuff, digging further... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 509310] Review Request: gpointing-device-settings - Configuration tool for pointing devices
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509310 Gianluca Sforna changed: What|Removed |Added Flag|needinfo?(gia...@gmail.com) | --- Comment #7 from Gianluca Sforna 2009-07-20 04:37:52 EDT --- Here is the schema file /schemas/apps/gnome_settings_daemon/plugins/pointing-device/active /apps/gnome_settings_daemon/plugins/pointing-device/active gnome-settings-daemon bool TRUE Enable pointing-device plugin Set to True to enable the plugin to manage GPointingDeviceSettings settings. /schemas/apps/gnome_settings_daemon/plugins/pointing-device/priority /apps/gnome_settings_daemon/plugins/pointing-device/priority gnome-settings-daemon int 7 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 511212] Review Request: cluster-glue - reusable clustering components
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511212 --- Comment #2 from Andrew Beekhof 2009-07-20 04:26:18 EDT --- New spec + source rpm uploaded: http://oss.clusterlabs.org/~beekhof/fedora/cluster-glue.spec http://oss.clusterlabs.org/~beekhof/fedora/cluster-glue-0.9-3.fc12.src.rpm In particular, Source0 is now a reference to the package's Mercurial repo. Conducted a self-review using http://fedoraproject.org/wiki/Packaging/ReviewGuidelines and it is my assessment that the package meets all the requirements. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 512585] Review Request: perl-Algorithm-IncludeExclude - Build and evaluate include/exclude lists
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512585 Iain Arnell changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #6 from Iain Arnell 2009-07-20 04:22:06 EDT --- Thanks for the review! :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
