[Bug 244593] Review Request: pgbouncer - Lightweight connection pooler for PostgreSQL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=244593 Devrim GUNDUZ <[EMAIL PROTECTED]> changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #34 from Devrim GUNDUZ <[EMAIL PROTECTED]> 2008-08-31 14:25:38 EDT --- Thanks. Pushed package to repositories. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244593] Review Request: pgbouncer - Lightweight connection pooler for PostgreSQL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=244593 --- Comment #33 from Kevin Fenzi <[EMAIL PROTECTED]> 2008-08-30 17:00:25 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244593] Review Request: pgbouncer - Lightweight connection pooler for PostgreSQL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=244593 --- Comment #32 from Devrim GUNDUZ <[EMAIL PROTECTED]> 2008-08-30 13:43:57 EDT --- New Package CVS Request === Package Name: pgbouncer Short Description: Lightweight connection pooler for PostgreSQL Owners: devrim Branches: F-8 F-9 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244593] Review Request: pgbouncer - Lightweight connection pooler for PostgreSQL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=244593 --- Comment #31 from Devrim GUNDUZ <[EMAIL PROTECTED]> 2008-08-30 13:41:16 EDT --- BTW, I just added >= 1.3b to libevent-devel dependency -- this version explicitly asks for that (which is available in F-8 + -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244593] Review Request: pgbouncer - Lightweight connection pooler for PostgreSQL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=244593 --- Comment #30 from Mamoru Tasaka <[EMAIL PROTECTED]> 2008-08-30 13:23:04 EDT --- Okay. This package (pgbouncer) is APPROVED by mtasaka -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244593] Review Request: pgbouncer - Lightweight connection pooler for PostgreSQL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=244593 --- Comment #29 from Devrim GUNDUZ <[EMAIL PROTECTED]> 2008-08-30 08:54:44 EDT --- Hi Mamoru, http://developer.postgresql.org/~devrim/rpms/other/pgbouncer/pgbouncer.spec http://developer.postgresql.org/~devrim/rpms/other/pgbouncer/pgbouncer-1.2.3-3.f9.src.rpm Applied the two changes you suggested. Regards, Devrim -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244593] Review Request: pgbouncer - Lightweight connection pooler for PostgreSQL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=244593 --- Comment #28 from Mamoru Tasaka <[EMAIL PROTECTED]> 2008-08-29 13:56:23 EDT --- For 1.2.3-2: * %postun scriptlet - Now Requires(postun) is needed: https://fedoraproject.org/wiki/Packaging/SysVInitScript#Initscripts_in_spec_file_scriptlets * rpmlint issue --- pgbouncer.i386: E: init-script-non-executable /etc/rc.d/init.d/pgbouncer --- - /etc/rc.d/init.d/pgbouncer must have 0755 permission. Fix these 2 issues and I guess I can approve this package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244593] Review Request: pgbouncer - Lightweight connection pooler for PostgreSQL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=244593 Devrim GUNDUZ <[EMAIL PROTECTED]> changed: What|Removed |Added Flag|needinfo?([EMAIL PROTECTED] | |mpt.com)| --- Comment #27 from Devrim GUNDUZ <[EMAIL PROTECTED]> 2008-08-29 02:45:16 EDT --- Here is the new spec and srpm: http://developer.postgresql.org/~devrim/rpms/other/pgbouncer/pgbouncer.spec http://developer.postgresql.org/~devrim/rpms/other/pgbouncer/pgbouncer-1.2.3-2.f9.src.rpm rpmlint is clean, and I believe I applied all changes you suggested. Regards, Devrim -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244593] Review Request: pgbouncer - Lightweight connection pooler for PostgreSQL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=244593 Mamoru Tasaka <[EMAIL PROTECTED]> changed: What|Removed |Added Flag||needinfo?([EMAIL PROTECTED] ||mpt.com) --- Comment #26 from Mamoru Tasaka <[EMAIL PROTECTED]> 2008-08-29 02:16:50 EDT --- ping again? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244593] Review Request: pgbouncer - Lightweight connection pooler for PostgreSQL
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=244593
--- Comment #25 from Mamoru Tasaka <[EMAIL PROTECTED]> 2008-08-12 12:17:34 EDT
---
For 1.2.3-1:
* Requires(preun)
https://fedoraproject.org/wiki/Packaging/SysVInitScripts#Initscripts_in_spec_file_scriptlets
- %preun uses /sbin/service and "Requires(preun): initscripts" is needed
! %postun
- Would you consider to add %postun section as described in
https://fedoraproject.org/wiki/Packaging/SysVInitScripts#Initscripts_in_spec_file_scriptlets
(If there is a reason adding this %postun must be avoided, it
is no problem)
* cflags/install flags
- build.log shows
-
201 make[1]: Leaving directory `/builddir/build/BUILD/pgbouncer-1.2.3/doc'
202 gcc -c -o lib/client.o src/client.c -DHAVE_CONFIG_H -O2 -g -pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
-fasynchronous-unwind-tables -Wall -Wextra -Wno-unused-parameter
-Wno-missing-field-initializers -Wmissing-prototypes -Wpointer-arith
-Wendif-labels -Wdeclaration-after-statement -Wold-style-definition
-Wstrict-prototypes -Wundef -Wformat -Wnonnull -Wstrict-overflow
-fomit-frame-pointer -I./include -I./include
269 mkdir -p
/builddir/build/BUILDROOT/pgbouncer-1.2.3-1.fc10.i386/usr/share/doc/pgbouncer
270 install -s -m 755 ./pgbouncer
/builddir/build/BUILDROOT/pgbouncer-1.2.3-1.fc10.i386/usr/bin
-
-- -fomit-frame-pointer makes debugging very difficult
-- "install -s" removes debugging information and makes failure of
debuginfo rpm
So both are forbidden on Fedora.
For this package the following can fix these issues:
-
sed -i.fedora \
-e 's|-fomit-frame-pointer||' \
-e '/BININSTALL/s|-s||' \
configure
-
* Timestamps
- When installing files by "cp" or "install", add "-p" option to
keep timestamps on them.
* Permission
-
pgbouncer.src: W: strange-permission pgbouncer.init 0775
pgbouncer.i386: E: executable-marked-as-config-file /etc/sysconfig/pgbouncer
pgbouncer.i386: E: script-without-shebang /etc/sysconfig/pgbouncer
-
- All files in the srpm must have 0644 permission.
- %_sysconfdir/sysconfig/pgbouncer must have 0644 permission.
* %config
-
pgbouncer.i386: W: conffile-without-noreplace-flag /etc/sysconfig/pgbouncer
-
- Would you explain why you don't want to use
%config(noreplace) %{_sysconfdir}/sysconfig/%{name}?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244593] Review Request: pgbouncer - Lightweight connection pooler for PostgreSQL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=244593 Mamoru Tasaka <[EMAIL PROTECTED]> changed: What|Removed |Added Summary|Review Request: |Review Request: pgbouncer - |postgresql-pgbouncer - |Lightweight connection |Lightweight connection |pooler for PostgreSQL |pooler for PostgreSQL | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
