[Bug 494845] Review Request: xdrfile - A small C-library for reading and writing GROMACS trr and xtc files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=494845 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||1.1-2.fc10 Resolution|NEXTRELEASE |ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 494845] Review Request: xdrfile - A small C-library for reading and writing GROMACS trr and xtc files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=494845 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|1.1-2.fc10 |1.1-2.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 494845] Review Request: xdrfile - A small C-library for reading and writing GROMACS trr and xtc files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=494845 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2009-07-11 13:27:18 EDT --- xdrfile-1.1-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 494845] Review Request: xdrfile - A small C-library for reading and writing GROMACS trr and xtc files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=494845 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2009-07-11 13:32:55 EDT --- xdrfile-1.1-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 494845] Review Request: xdrfile - A small C-library for reading and writing GROMACS trr and xtc files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=494845 Jussi Lehtola jussi.leht...@iki.fi changed: What|Removed |Added Blocks|505154 | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 494845] Review Request: xdrfile - A small C-library for reading and writing GROMACS trr and xtc files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=494845 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #13 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-06-16 12:45:18 EDT --- Now closing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 494845] Review Request: xdrfile - A small C-library for reading and writing GROMACS trr and xtc files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=494845 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2009-06-15 05:40:10 EDT --- xdrfile-1.1-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/xdrfile-1.1-2.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 494845] Review Request: xdrfile - A small C-library for reading and writing GROMACS trr and xtc files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=494845 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2009-06-15 05:41:34 EDT --- xdrfile-1.1-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/xdrfile-1.1-2.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 494845] Review Request: xdrfile - A small C-library for reading and writing GROMACS trr and xtc files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=494845 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #10 from Kevin Fenzi ke...@tummy.com 2009-06-14 14:54:21 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 494845] Review Request: xdrfile - A small C-library for reading and writing GROMACS trr and xtc files
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=494845
--- Comment #7 from Jussi Lehtola jussi.leht...@iki.fi 2009-06-13 05:28:28
EDT ---
(In reply to comment #6)
Some notes:
* URL, Source0
- Currently the written URL seems invalid and I could not
any files from the URL written as %SOURCE0
Ugh, they're migrating their web pages to a new wiki. Fixed URL to point to old
wiki.
When I made the package the FTP site had xdrfile-1.1b.tar.gz which fixed the
license issue. I see it has now been renamed to xdrfile-1.1.tar.gz, since the
files are binary equal. Which means that the default %setup doesn't work. Must
make a bug about this upstream.
* About checking size
-
[ -s ChangeLog ] exit 1 # exit if file has non-zero size
-
- Well I guess it is better that you check the tarball and
ChangeLog file by yourself instead of resorting to
such method...
Well, currently the file has no content, so I want to be notified automatically
if at some stage later on it gains content.
* Timestamp
- It is preferred to keep timestamps on installed files
(for this package especially for header files) by:
-
make install DESTDIR=%{buildroot} INSTALL=install -p
-
This method usually works for Makefiles generated by
recent autotools.
Whoops, fixed.
http://theory.physics.helsinki.fi/~jzlehtol/rpms/xdrfile.spec
http://theory.physics.helsinki.fi/~jzlehtol/rpms/xdrfile-1.1-2.fc11.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 494845] Review Request: xdrfile - A small C-library for reading and writing GROMACS trr and xtc files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=494845 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #8 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-06-13 14:14:48 EDT --- Okay. -- This package (xdrfile) is APPROVED by mtasaka -- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 494845] Review Request: xdrfile - A small C-library for reading and writing GROMACS trr and xtc files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=494845 Jussi Lehtola jussi.leht...@iki.fi changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Jussi Lehtola jussi.leht...@iki.fi 2009-06-13 14:33:00 EDT --- Thanks for the review! New Package CVS Request === Package Name: xdrfile Short Description: A small C-library for reading and writing GROMACS trr and xtc files Owners: jussilehtola Branches: F-10 F-11 EL-5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 494845] Review Request: xdrfile - A small C-library for reading and writing GROMACS trr and xtc files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=494845 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|mtas...@ioa.s.u-tokyo.ac.jp Flag||fedora-review? --- Comment #5 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-06-12 11:40:15 EDT --- Will review shortly. Instead I would appreciate it if you review either of my review requests (bug 504707, bug 504709 or bug 505406). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 494845] Review Request: xdrfile - A small C-library for reading and writing GROMACS trr and xtc files
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=494845
--- Comment #6 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2009-06-12
12:14:50 EDT ---
Some notes:
* URL, Source0
- Currently the written URL seems invalid and I could not
any files from the URL written as %SOURCE0
* About checking size
-
[ -s ChangeLog ] exit 1 # exit if file has non-zero size
-
- Well I guess it is better that you check the tarball and
ChangeLog file by yourself instead of resorting to
such method...
* Timestamp
- It is preferred to keep timestamps on installed files
(for this package especially for header files) by:
-
make install DESTDIR=%{buildroot} INSTALL=install -p
-
This method usually works for Makefiles generated by
recent autotools.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 494845] Review Request: xdrfile - A small C-library for reading and writing GROMACS trr and xtc files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=494845 Jussi Lehtola jussi.leht...@iki.fi changed: What|Removed |Added Blocks||505154 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 494845] Review Request: xdrfile - A small C-library for reading and writing GROMACS trr and xtc files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=494845 --- Comment #4 from Jussi Lehtola jussi.leht...@iki.fi 2009-05-18 14:35:03 EDT --- This should fix all problems. http://theory.physics.helsinki.fi/~jzlehtol/rpms/xdrfile.spec http://theory.physics.helsinki.fi/~jzlehtol/rpms/xdrfile-1.1b-1.fc10.src.rpm rpmlint output: xdrfile-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 1 warnings. This is not a problem since -devel requires the main package which includes the documentation. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 494845] Review Request: xdrfile - A small C-library for reading and writing GROMACS trr and xtc files
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=494845
--- Comment #3 from Jussi Lehtola jussi.leht...@iki.fi 2009-04-08 08:14:32
EDT ---
(In reply to comment #2)
Currently there's no license included and two header files
specify the GPLv2+ license instead of BSD.
This asks for a licence clarification from upstream.
Yes, that's in the bug report I sent upstream.
# Move include files to %{_includedir} instead
mv %{buildroot}/%{_includedir}/%{name}/* %{buildroot}/%{_includedir}
rmdir %{buildroot}/%{_includedir}/%{name}
Better ask upstream for confirmation and a fix in the tarball. The headers
need
this change for 'include xdrfile.h' to work, but it changes the API because
users of this library can no longer #include xdrfile/xdrfile.h.
True. I suggested moving the headers in the same bug report. Now one just has
to wait until upstream reacts.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 494845] Review Request: xdrfile - A small C-library for reading and writing GROMACS trr and xtc files
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=494845
--- Comment #2 from Michael Schwendt bugs.mich...@gmx.net 2009-04-08
07:36:45 EDT ---
Currently there's no license included and two header files
specify the GPLv2+ license instead of BSD.
This asks for a licence clarification from upstream.
xdrfile.x86_64: E: zero-length /usr/share/doc/xdrfile-1.0/README
xdrfile.x86_64: E: zero-length /usr/share/doc/xdrfile-1.0/ChangeLog
xdrfile.x86_64: E: zero-length /usr/share/doc/xdrfile-1.0/AUTHORS
xdrfile.x86_64: E: zero-length /usr/share/doc/xdrfile-1.0/COPYING
xdrfile.x86_64: E: zero-length /usr/share/doc/xdrfile-1.0/NEWS
Hint: There are ways to avoid this.
%prep
%setup ...
## Exit build if these %doc files become non-empty and are added to %files.
[ -s AUTHORS ] exit 1# exit if file has non-zero size
#[ -s AUTHORS ] || exit 1 # exit if file has zero size
[ -s COPYING ] exit 1
#[ -s COPYING ] || exit 1
%files
...
#doc AUTHORS
#doc COPYING
...
%post devel -p /sbin/ldconfig
%postun devel -p /sbin/ldconfig
These are wrong and ought to be deleted.
# Move include files to %{_includedir} instead
mv %{buildroot}/%{_includedir}/%{name}/* %{buildroot}/%{_includedir}
rmdir %{buildroot}/%{_includedir}/%{name}
Better ask upstream for confirmation and a fix in the tarball. The headers need
this change for 'include xdrfile.h' to work, but it changes the API because
users of this library can no longer #include xdrfile/xdrfile.h.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 494845] Review Request: xdrfile - A small C-library for reading and writing GROMACS trr and xtc files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=494845 --- Comment #1 from Jussi Lehtola jussi.leht...@iki.fi 2009-04-08 06:44:29 EDT --- I left in the empty files for the moment, since I'm waiting for a fix from upstream ( http://bugzilla.gromacs.org/show_bug.cgi?id=312 ). Currently there's no license included and two header files specify the GPLv2+ license instead of BSD. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
