[Bug 499979] Review Request: mingw32-libssh2 - MinGW Windows library implementation of the SSH2 protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499979 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2009-05-25 17:16:18 EDT --- mingw32-libssh2-1.1-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499979] Review Request: mingw32-libssh2 - MinGW Windows library implementation of the SSH2 protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499979 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||1.1-2.fc10 Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499979] Review Request: mingw32-libssh2 - MinGW Windows library implementation of the SSH2 protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499979 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2009-05-25 17:25:05 EDT --- mingw32-libssh2-1.1-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499979] Review Request: mingw32-libssh2 - MinGW Windows library implementation of the SSH2 protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499979 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|1.1-2.fc10 |1.1-2.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499979] Review Request: mingw32-libssh2 - MinGW Windows library implementation of the SSH2 protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499979 --- Comment #6 from Fedora Update System upda...@fedoraproject.org 2009-05-24 08:54:59 EDT --- mingw32-libssh2-1.1-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/mingw32-libssh2-1.1-2.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499979] Review Request: mingw32-libssh2 - MinGW Windows library implementation of the SSH2 protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499979 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2009-05-24 09:00:43 EDT --- mingw32-libssh2-1.1-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/mingw32-libssh2-1.1-2.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499979] Review Request: mingw32-libssh2 - MinGW Windows library implementation of the SSH2 protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499979 Thomas Sailer t.sai...@alumni.ethz.ch changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|t.sai...@alumni.ethz.ch Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499979] Review Request: mingw32-libssh2 - MinGW Windows library implementation of the SSH2 protocol
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=499979
Thomas Sailer t.sai...@alumni.ethz.ch changed:
What|Removed |Added
CC||t.sai...@alumni.ethz.ch
--- Comment #1 from Thomas Sailer t.sai...@alumni.ethz.ch 2009-05-22
06:48:49 EDT ---
Fedora review mingw32-libssh2-1.1-1.fc11.src.rpm 2009-05-22
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1370201
rpmlint output:
$ rpmlint mingw32-libssh2*
mingw32-libssh2-static.noarch: E:
arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libssh2.a
mingw32-libssh2-static.noarch: W: no-documentation
4 packages and 1 specfiles checked; 1 errors, 1 warnings.
As per Packaging/MinGW, these errors can be ignored.
+ OK
! needs attention
+ rpmlint output
+ Package is named according to Fedora MinGW packaging guidelines
+ Specfile name matches the package base name
+ Package follows the Fedora MinGW packaging guidelines
version seems to be slightly ahead of native (1.1 vs. 1.0) please try to
stick to the native version
+ License meets guidelines and is acceptable to Fedora
BSD
+ License matches the actual package license
It is also the same as in the corresponding Fedora libssh2 package
+ The package contains the license file (COPYING)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm
f8a3eb9bb814e0a5a2bb76a5423f5129 libssh2-1.1.tar.gz
f8a3eb9bb814e0a5a2bb76a5423f5129 x/libssh2-1.1.tar.gz
n/a Package builds in mock
n/a ExcludeArch bugs filed
+ BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and
%postun
+ Does not use Prefix: /usr
+ Package owns all directories it creates
+ No duplicate files in %files
+ %files has %defattr
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ Consistent use of macros
+ Package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
Fedora MinGW guidelines allow headers in main package
+ Static libraries should be in -static
+ Packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a -devel must require the fully versioned base
n/a Packages should not contain libtool .la files
Fedora MinGW guidelines allow .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Packages must not own files or directories owned by other packages
+ %install begins with rm -rf $RPM_BUILD_ROOT
+ Filenames must be valid UTF-8
! use %global instead of %define
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499979] Review Request: mingw32-libssh2 - MinGW Windows library implementation of the SSH2 protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499979 --- Comment #2 from Erik van Pienbroek erik-fed...@vanpienbroek.nl 2009-05-22 09:01:57 EDT --- (In reply to comment #1) + Package follows the Fedora MinGW packaging guidelines version seems to be slightly ahead of native (1.1 vs. 1.0) please try to stick to the native version Yeah I know, but there was a message on the fedora-mingw mailing list recently that we were advised to upgrade to version 1.1 as it contains several win32 optimalisations: http://lists.fedoraproject.org/pipermail/fedora-mingw/2009-May/001355.html ! use %global instead of %define A lot of MinGW packages we have use these %define's. I think we should check every MinGW package which is in Fedora now and fix the packages if necessary. For this package I've replaced the %define's with %global's: Spec URL: http://www.ftd4linux.nl/contrib/mingw32-libssh2.spec SRPM URL: http://www.ftd4linux.nl/contrib/mingw32-libssh2-1.1-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499979] Review Request: mingw32-libssh2 - MinGW Windows library implementation of the SSH2 protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499979 Thomas Sailer t.sai...@alumni.ethz.ch changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #3 from Thomas Sailer t.sai...@alumni.ethz.ch 2009-05-22 09:13:55 EDT --- APPROVED by sailer -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499979] Review Request: mingw32-libssh2 - MinGW Windows library implementation of the SSH2 protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499979 Erik van Pienbroek erik-fed...@vanpienbroek.nl changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Erik van Pienbroek erik-fed...@vanpienbroek.nl 2009-05-22 11:12:29 EDT --- New Package CVS Request === Package Name: mingw32-libssh2 Short Description: MinGW Windows library implementation of the SSH2 protocol Owners: epienbro rjones Branches: F-10 F-11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499979] Review Request: mingw32-libssh2 - MinGW Windows library implementation of the SSH2 protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499979 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Status|NEW |ASSIGNED Flag|fedora-cvs? |fedora-cvs+ --- Comment #5 from Kevin Fenzi ke...@tummy.com 2009-05-23 01:36:50 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 499979] Review Request: mingw32-libssh2 - MinGW Windows library implementation of the SSH2 protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499979 Erik van Pienbroek erik-fed...@vanpienbroek.nl changed: What|Removed |Added Blocks||499987 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
