[Bug 502490] Review Request: rubygem-state_machine - Adds support for creating state machines for attributes on any Ruby class
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502490 Darryl L. Pierce changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #12 from Darryl L. Pierce 2009-07-14 08:57:10 EDT --- Everything's good. Thanks, guys. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502490] Review Request: rubygem-state_machine - Adds support for creating state machines for attributes on any Ruby class
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502490 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #11 from Kevin Fenzi 2009-07-14 00:37:49 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502490] Review Request: rubygem-state_machine - Adds support for creating state machines for attributes on any Ruby class
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502490 Darryl L. Pierce changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502490] Review Request: rubygem-state_machine - Adds support for creating state machines for attributes on any Ruby class
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502490 --- Comment #10 from Darryl L. Pierce 2009-07-13 11:38:52 EDT --- New Package CVS Request === Package Name: rubygem-state_machine Short Description: Adds support for creating state machines for attributes on any Ruby class Owners: mcpierce Branches: F-10 F-11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502490] Review Request: rubygem-state_machine - Adds support for creating state machines for attributes on any Ruby class
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=502490
Michal Ingeli changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #9 from Michal Ingeli 2009-07-13 11:22:22 EDT ---
(In reply to comment #8)
> (In reply to comment #7)
> > Looks fine, just few more things.
> > - package must own %{geminstdir}
> > "file /usr/lib/ruby/gems/1.8/gems/state_machine-0.7.4 is not owned by any
> > package"
"%{geminstdir}" must be listed as "%dir %{geminstdir}", because listing
directory works recursively. So now you can see a lot of twice listed files in
build.log. I am approving this package, but you should fix this before import.
> > - put examples into %doc
OK
> Thank you for the advice. I've made the necessary changes, updated files are
> as
> follows:
>
> Updated SPEC: http://mcpierce.fedorapeople.org/rpms/rubygem-state_machine.spec
> Updated SRPM:
> http://mcpierce.fedorapeople.org/rpms/rubygem-state_machine-0.7.4-4.fc11.src.rpm
> Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1471250
One more advice, look at [1] and replace %define with %global.
APPROVED
[1] https://fedoraproject.org/wiki/PackagingDrafts/global_preferred_over_define
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502490] Review Request: rubygem-state_machine - Adds support for creating state machines for attributes on any Ruby class
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=502490
--- Comment #8 from Darryl L. Pierce 2009-07-13 09:08:36
EDT ---
(In reply to comment #7)
> Looks fine, just few more things.
> - package must own %{geminstdir}
> "file /usr/lib/ruby/gems/1.8/gems/state_machine-0.7.4 is not owned by any
> package"
> - put examples into %doc
Thank you for the advice. I've made the necessary changes, updated files are as
follows:
Updated SPEC: http://mcpierce.fedorapeople.org/rpms/rubygem-state_machine.spec
Updated SRPM:
http://mcpierce.fedorapeople.org/rpms/rubygem-state_machine-0.7.4-4.fc11.src.rpm
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1471250
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502490] Review Request: rubygem-state_machine - Adds support for creating state machines for attributes on any Ruby class
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=502490
--- Comment #7 from Michal Ingeli 2009-07-12 13:19:57 EDT ---
Looks fine, just few more things.
- package must own %{geminstdir}
"file /usr/lib/ruby/gems/1.8/gems/state_machine-0.7.4 is not owned by any
package"
- put examples into %doc
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502490] Review Request: rubygem-state_machine - Adds support for creating state machines for attributes on any Ruby class
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=502490
--- Comment #6 from Darryl L. Pierce 2009-07-11 10:42:48
EDT ---
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > > > - file listed twice
> > > > > warning: File listed twice:
> > > > > /usr/lib/ruby/gems/1.8/gems/state_machine-0.7.4/LICENSE
> > >
> > > You can see this warning at the end of build.log [1].
> >
> > I'm not sure what the issue is there. The spec file does not mention it more
> > than once, and the file only shows up once in the gem itself. Any
> > recommendation on how to proceed, and is this a blocker for review?
>
> Yes, it is a blocker. According to [1][2] files can be listend only once. It's
> quite easy fix. You should replace the "%{gemdir}/gems/%{gemname}-%{version}/"
> entry with "dir %{geminstdir}" and list all entries in that directory
> separately. Just note that examples, tests, rdoc and so should be listed as
> %doc.
>
> [1] https://fedoraproject.org/wiki/Packaging/ReviewGuidelines#cite_ref-12
> [2] https://bugzilla.redhat.com/show_bug.cgi?id=504469#c7
Thanks for the advice. I've fixed the aforementioned bugs in the srpm and rpm,
and both check out clean for me:
Updated SPEC: http://mcpierce.fedorapeople.org/rpms/rubygem-state_machine.spec
Updated SRPM:
http://mcpierce.fedorapeople.org/rpms/rubygem-state_machine-0.7.4-3.fc11.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502490] Review Request: rubygem-state_machine - Adds support for creating state machines for attributes on any Ruby class
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=502490
--- Comment #5 from Michal Ingeli 2009-07-09 16:52:42 EDT ---
(In reply to comment #4)
> (In reply to comment #3)
> > > > - file listed twice
> > > > warning: File listed twice:
> > > > /usr/lib/ruby/gems/1.8/gems/state_machine-0.7.4/LICENSE
> >
> > You can see this warning at the end of build.log [1].
>
> I'm not sure what the issue is there. The spec file does not mention it more
> than once, and the file only shows up once in the gem itself. Any
> recommendation on how to proceed, and is this a blocker for review?
Yes, it is a blocker. According to [1][2] files can be listend only once. It's
quite easy fix. You should replace the "%{gemdir}/gems/%{gemname}-%{version}/"
entry with "dir %{geminstdir}" and list all entries in that directory
separately. Just note that examples, tests, rdoc and so should be listed as
%doc.
[1] https://fedoraproject.org/wiki/Packaging/ReviewGuidelines#cite_ref-12
[2] https://bugzilla.redhat.com/show_bug.cgi?id=504469#c7
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502490] Review Request: rubygem-state_machine - Adds support for creating state machines for attributes on any Ruby class
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502490 --- Comment #4 from Darryl L. Pierce 2009-07-09 16:06:32 EDT --- (In reply to comment #3) > > > - file listed twice > > > warning: File listed twice: > > > /usr/lib/ruby/gems/1.8/gems/state_machine-0.7.4/LICENSE > > You can see this warning at the end of build.log [1]. I'm not sure what the issue is there. The spec file does not mention it more than once, and the file only shows up once in the gem itself. Any recommendation on how to proceed, and is this a blocker for review? > > Updated spec: > > http://mcpierce.fedorapeople.org/rpms/rubygem-state_machine.spec > > Updated SRPM: > > http://mcpierce.fedorapeople.org/rpms/rubygem-state_machine-0.7.4-2.fc11.noarch.rpm > > (note, this is not srpm) Sorry, my bad, I pasted the wrong URL. The correct one is: http://mcpierce.fedorapeople.org/rpms/rubygem-state_machine-0.7.4-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502490] Review Request: rubygem-state_machine - Adds support for creating state machines for attributes on any Ruby class
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502490 --- Comment #3 from Michal Ingeli 2009-07-09 15:47:01 EDT --- (In reply to comment #2) > (In reply to comment #1) > > - bad license. should be MIT [1] > Fixed. OK > > - missing require for ruby(abi) > Fixed. OK > > - file listed twice > > warning: File listed twice: > > /usr/lib/ruby/gems/1.8/gems/state_machine-0.7.4/LICENSE You can see this warning at the end of build.log [1]. > > - rubygem-state_machine.src: W: mixed-use-of-spaces-and-tabs (spaces: line > > 33, > > tab: line 7) > > Hmmm. I don't see this error. I did a scratch build, then downloaded and ran > rpmlint on the RPM and saw no complaints. Can you tell me how you produced > this? > > (mcpie...@mcpierce-laptop:rubygem-state_machine)$ rpmlint > ~/Download/rubygem-state_machine-0.7.4-2.fc11.noarch.rpm > 1 packages and 0 specfiles checked; 0 errors, 0 warnings. You should run rpmlint on both result rpm and src rpm. This warning is from src rpm. > Updated spec: http://mcpierce.fedorapeople.org/rpms/rubygem-state_machine.spec > Updated SRPM: > http://mcpierce.fedorapeople.org/rpms/rubygem-state_machine-0.7.4-2.fc11.noarch.rpm (note, this is not srpm) > Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1446813 [1] http://koji.fedoraproject.org/koji/getfile?taskID=1446816&name=build.log sorry for late response -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502490] Review Request: rubygem-state_machine - Adds support for creating state machines for attributes on any Ruby class
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502490 --- Comment #2 from Darryl L. Pierce 2009-07-01 09:07:30 EDT --- (In reply to comment #1) > - bad license. should be MIT [1] Fixed. > - missing require for ruby(abi) Fixed. > - file listed twice > warning: File listed twice: > /usr/lib/ruby/gems/1.8/gems/state_machine-0.7.4/LICENSE > - rubygem-state_machine.src: W: mixed-use-of-spaces-and-tabs (spaces: line 33, > tab: line 7) Hmmm. I don't see this error. I did a scratch build, then downloaded and ran rpmlint on the RPM and saw no complaints. Can you tell me how you produced this? (mcpie...@mcpierce-laptop:rubygem-state_machine)$ rpmlint ~/Download/rubygem-state_machine-0.7.4-2.fc11.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Updated spec: http://mcpierce.fedorapeople.org/rpms/rubygem-state_machine.spec Updated SRPM: http://mcpierce.fedorapeople.org/rpms/rubygem-state_machine-0.7.4-2.fc11.noarch.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1446813 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 502490] Review Request: rubygem-state_machine - Adds support for creating state machines for attributes on any Ruby class
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502490 Michal Ingeli changed: What|Removed |Added Status|NEW |ASSIGNED CC||m...@v3.sk AssignedTo|nob...@fedoraproject.org|m...@v3.sk Flag||fedora-review? --- Comment #1 from Michal Ingeli 2009-06-30 19:30:04 EDT --- - bad license. should be MIT [1] - missing require for ruby(abi) - file listed twice warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/state_machine-0.7.4/LICENSE - rubygem-state_machine.src: W: mixed-use-of-spaces-and-tabs (spaces: line 33, tab: line 7) You can inspire by review made by Mamoru Tasaka for recent ruby gem review [2]. [1] https://fedoraproject.org/wiki/Licensing/MIT#Modern_Style_with_sublicense [2] https://bugzilla.redhat.com/show_bug.cgi?id=504469 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
