[Bug 530754] Review Request: scour - A script to clean SVG files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530754 Jeff Schiller changed: What|Removed |Added CC||codedr...@gmail.com --- Comment #9 from Jeff Schiller 2009-11-25 12:29:07 EDT --- fwiw, I downloaded and tried the attachment 367321 with the latest version of scour (0.22) and it seems to convert perfectly. I also tried it with 0.21 and the same result. Btw, by default, scour converts files to have width="100%" and height="100%" which I've found out recently causes problems in some viewers (browsers are fine, but Eye on Gnome has a problem for instance). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 530754] Review Request: scour - A script to clean SVG files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530754 Jason Tibbitts changed: What|Removed |Added Flag|fedora-review? | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 530754] Review Request: scour - A script to clean SVG files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530754 --- Comment #7 from Kevin Kofler 2009-11-03 18:55:42 EDT --- There's no need to split the package into several subpackages, and splitting %files with comments is also not needed. It's enough to use "and" in the License tag and to add a comment above it saying e.g.: # svg_regex.py is BSD, the rest is ASL 2.0 See also: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios According to that guideline page, it is sufficient to EITHER split %files with comments specifying the license OR use a comment like the above OR refer to a %doc file which tells what part is under what license (such files are sometimes shipped by upstream, in which case it's enough to reference them). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 530754] Review Request: scour - A script to clean SVG files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530754 --- Comment #6 from Thomas Spura 2009-11-03 14:58:11 EDT --- Here is an exemple for the license issue: bug #532590 current SPEC: http://v3.sk/~lkundrak/SPECS/yaws.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 530754] Review Request: scour - A script to clean SVG files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530754 --- Comment #5 from Thomas Spura 2009-11-03 11:00:34 EDT --- Created an attachment (id=367321) --> (https://bugzilla.redhat.com/attachment.cgi?id=367321) Test case for scour With this file, it only shows white and that's it... License issue: """ you *HAVE* to add a comment, why you choose multiple licensing and split the files in the %files section, too. If you want to split the files into several subpackages, as suggested there, is your choice ;) """ You don't need to to a different package for just the single file, just comment it in the code, why you have a multiple license... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 530754] Review Request: scour - A script to clean SVG files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530754 --- Comment #4 from Ben Boeckel 2009-11-03 09:38:04 EDT --- (In reply to comment #3) > Problems: > - Package does not work as described on my pc. Odd. Could you post the source SVGs that didn't work? I'll do more tests here on more files and see if I can reproduce the issues. > - rpmlint: remove the sheband, see > http://fedoraproject.org/wiki/PackagingTricks#Remove_shebang_from_files It was executable here, so the shebang line got missed. Will fix. > - license issue, as described above. Well, from what I can tell, the svg_regex.py is from Inkscape which is BSD. Putting a Requires: on inkscape is sort of counter-productive to what (at least I would) use this for: taking an SVG and making it easier to edit in a text editor and not having to lug inkscape around. Unfortunately this means it's not using the "system copy" and I doubt inkscape will be splitting just to poke this one file out. I don't like shipping this file, but Requires: inkscape is just too much. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 530754] Review Request: scour - A script to clean SVG files
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530754
--- Comment #3 from Thomas Spura 2009-10-28
08:35:35 EDT ---
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines
[x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Tested on:
[] devel/i386
[] devel/x86_64
[] F11/i386
[x] F11/x86_64
__
[!] Rpmlint output:
$ rpmlint scour.spec scour-0.21-2.fc11.src.rpm
noarch/scour-0.21-2.fc11.noarch.rpm
scour.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/yocto_css.py 0644 /usr/bin/env
2 packages and 1 specfiles checked; 1 errors, 0 warnings.
__
[x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
__
[!] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
From
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios
you *HAVE* to add a comment, why you choose multiple licensing and split the
files in the %files section, too. If you want to split the files into several
subpackages, as suggested there, is your choice ;)
__
[x] License field in the package spec file matches the actual license.
License type: BSD and ASL 2.0
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
Upstream source: bfa8ddd75e72b734064385b7279d8dbb
Build source:bfa8ddd75e72b734064385b7279d8dbb
[x] Package is not known to require ExcludeArch
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly.
[-] ldconfig called in %post and %postun if required.
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package has a %clean section, which contains rm -rf %{buildroot}.
[x] Package consistently uses macros.
[-] Large documentation files are in a -doc subpackage, if required.
[x] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -devel subpackage, if present.
[-] Package requires pkgconfig, if .pc files are present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages, if present.
[-] Package does not contain any libtool archives (.la).
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[-] Package does not own files or directories owned by other packages.
=== SUGGESTED ITEMS ===
[x] Latest version is packaged.
[x] Package should compile and build into binary rpms on all supported
architectures.
http://koji.fedoraproject.org/koji/taskinfo?taskID=1774382
[!] Package functions as described (no hardware to test with).
I tried to compess some images, but without result. They could not be
opened afterwards or are 10% bigger and not openable.
Could you provide a test image, which works for you?
[x] Scriptlets must be sane, if used.
[-] The placement of pkgconfig(.pc) files is correct.
Problems:
- Package does not work as described on my pc.
- rpmlint: remove the sheband, see
http://fedoraproject.org/wiki/PackagingTricks#Remove_shebang_from_files
- license issue, as described above.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 530754] Review Request: scour - A script to clean SVG files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530754 --- Comment #2 from Ben Boeckel 2009-10-27 17:21:32 EDT --- Spec URL: http://benboeckel.net/packaging/scour/scour.spec SRPM URL: http://benboeckel.net/packaging/scour/scour-0.21-2.fc12.src.rpm Fixed. I also did 755 for the main executable to be safe. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 530754] Review Request: scour - A script to clean SVG files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530754 Thomas Spura changed: What|Removed |Added Status|NEW |ASSIGNED CC||toms...@fedoraproject.org AssignedTo|nob...@fedoraproject.org|toms...@fedoraproject.org Flag||fedora-review? --- Comment #1 from Thomas Spura 2009-10-27 04:50:41 EDT --- $ rpmls noarch/scour-0.21-1.fc11.noarch.rpm -rwxr-xr-x /usr/bin/scour -rwxr-xr-x /usr/lib/python2.6/site-packages/svg_regex.py -rw-r--r-- /usr/lib/python2.6/site-packages/svg_regex.pyc -rw-r--r-- /usr/lib/python2.6/site-packages/svg_regex.pyo -rwxr-xr-x /usr/lib/python2.6/site-packages/yocto_css.py -rw-r--r-- /usr/lib/python2.6/site-packages/yocto_css.pyc -rw-r--r-- /usr/lib/python2.6/site-packages/yocto_css.pyo drwxr-xr-x /usr/share/doc/scour-0.21 -rw-r--r-- /usr/share/doc/scour-0.21/LICENSE -rw-r--r-- /usr/share/doc/scour-0.21/NOTICE -rw-r--r-- /usr/share/doc/scour-0.21/README.txt -rw-r--r-- /usr/share/doc/scour-0.21/release-notes.html yocto_css.py and svg_regex.py are executable, but should not be. Please set the permission with 'install -p -m 644'. I'll review this, after you updated this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
