[Bug 550599] Review Request: themonospot-console - console application to scan multimedia files

2010-01-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550599


Bug 550599 depends on bug 550594, which changed state.

Bug 550594 Summary: Review request: themonospot-base - core component of 
Themonospot suite
https://bugzilla.redhat.com/show_bug.cgi?id=550594

   What|Old Value   |New Value

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 550599] Review Request: themonospot-console - console application to scan multimedia files

2010-01-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550599


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #12 from Kevin Fenzi ke...@tummy.com  2010-01-04 15:21:39 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 550599] Review Request: themonospot-console - console application to scan multimedia files

2010-01-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550599





--- Comment #11 from Armando Basile hmandevt...@gmail.com  2010-01-02 
16:00:24 EDT ---
New Package CVS Request
===
Package Name: themonospot-console
Short Description: Console application for Themonospot suite
Owners: hman-it
Branches: F-11 F-12
InitialCC: mtasaka
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 550599] Review Request: themonospot-console - console application to scan multimedia files

2010-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550599





--- Comment #8 from Armando Basile hmandevt...@gmail.com  2010-01-01 08:43:22 
EDT ---
SPEC URL:
http://www.integrazioneweb.com/repository/SPECS/fedora/themonospot-console.spec
SRPM URL:
http://www.integrazioneweb.com/repository/SRPMS/fedora/themonospot-console-0.1.1-3.fc12.src.rpm

changed:
- added themonospot-base-devel as BuildRequire

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 550599] Review Request: themonospot-console - console application to scan multimedia files

2010-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550599


Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #9 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp  2010-01-01 
11:33:20 EDT ---
Okay.


   This package (themonospot~console) is APPROVED by mtasaka


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 550599] Review Request: themonospot-console - console application to scan multimedia files

2010-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550599





--- Comment #10 from Armando Basile hmandevt...@gmail.com  2010-01-01 
12:58:31 EDT ---
New Package CVS Request
===
Package Name: themonospot-console
Short Description: Console application for Themonospot suite
Owners: hman
Branches: F-11 F-12
InitialCC: mtas...@ioa.s.u-tokyo.ac.jp
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 550599] Review Request: themonospot-console - console application to scan multimedia files

2010-01-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550599


Armando Basile hmandevt...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 550599] Review Request: themonospot-console - console application to scan multimedia files

2009-12-31 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550599





--- Comment #7 from Armando Basile hmandevt...@gmail.com  2009-12-31 14:43:52 
EDT ---
SPEC URL:
http://www.integrazioneweb.com/repository/SPECS/fedora/themonospot-console.spec
SRPM URL:
http://www.integrazioneweb.com/repository/SRPMS/fedora/themonospot-console-0.1.1-2.fc12.src.rpm

changes:
- only mono-devel as BuildRequire

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 550599] Review Request: themonospot-console - console application to scan multimedia files

2009-12-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550599





--- Comment #6 from Armando Basile hmandevt...@gmail.com  2009-12-30 10:33:00 
EDT ---
SPEC URL:
http://www.integrazioneweb.com/repository/SPECS/fedora/themonospot-console.spec
SRPM URL:
http://www.integrazioneweb.com/repository/SRPMS/fedora/themonospot-console-0.1.1-1.fc12.src.rpm

changes:
- folder used is %{libdir}/themonospot
- added copying.gpl

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 550599] Review Request: themonospot-console - console application to scan multimedia files

2009-12-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550599


Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|mtas...@ioa.s.u-tokyo.ac.jp
   Flag||fedora-review?




--- Comment #1 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp  2009-12-29 
03:17:45 EDT ---
Some notes:

* License
  - There is no license information in the tarball. Would you
clarify it (as you are the upstream)?

* (Build)Requires
  - As I wrote in -base review, = 1.2.3 part on 
(Build)Requires: mono-core is not needed (for current Fedora)

  - Also = 0.8.1 part on (Build)Requires: themonospot-console
is not needed either because -core packages to be intoduced
into Fedora satisfies this version dependency on every Fedora
branch.
ref: the last sentence in
https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires

* %files
  - %files entry %{_bindir}/%{name}/ is wrong because the last
slash should mean that this %files entry is a directory, while
the actually installed one is a file, not a directory.
(i.e. this should be %{_bindir}/%{name})

! Note
  In reality, current rpm simply ignores the last slash.
  https://bugzilla.redhat.com/show_bug.cgi?id=505995

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 550599] Review Request: themonospot-console - console application to scan multimedia files

2009-12-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550599


Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

 Blocks||550519




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 550599] Review Request: themonospot-console - console application to scan multimedia files

2009-12-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550599





--- Comment #2 from Armando Basile hmandevt...@gmail.com  2009-12-29 04:13:23 
EDT ---
SPEC URL:
http://www.integrazioneweb.com/repository/SPECS/fedora/themonospot-console.spec
SRPM URL:
http://www.integrazioneweb.com/repository/SRPMS/fedora/themonospot-console-0.1.0-2.fc12.src.rpm

changes:
- removed = 1.2.3 from mono-core dependence
- removed = 0.8.1 from themonospot-base dependence
- added themonospot-base-devel to BuildRequires
- removed final / in %{_bindir}/%{name}/ line

for license, should patch tarball (adding gplv2 file) and add patch to spec ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 550599] Review Request: themonospot-console - console application to scan multimedia files

2009-12-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550599





--- Comment #3 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp  2009-12-29 
04:53:21 EDT ---
I have not checked your latest srpm, however:

(In reply to comment #2)
 for license, should patch tarball (adding gplv2 file) and add patch to spec ? 
  

- If you want to modify the tarball itself (i.e. include license
  text in the tarball) please release the new version 
  (i.e. 0.1.0.1, for example)
- If you want not to release the new version for now, for now include the
  license text as SourceX in srpm and package it into binary rpm
  with %doc.

Anyway in the next version please include the license text in
the tarball.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 550599] Review Request: themonospot-console - console application to scan multimedia files

2009-12-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550599





--- Comment #4 from Armando Basile hmandevt...@gmail.com  2009-12-29 06:03:15 
EDT ---
SPEC URL:
http://www.integrazioneweb.com/repository/SPECS/fedora/themonospot-console.spec
SRPM URL:
http://www.integrazioneweb.com/repository/SRPMS/fedora/themonospot-console-0.1.0-3.fc12.src.rpm

changes:
- added Source1 copyng.gpl
- added cp %{SOURCE1} copying.gpl
- added %doc copying.gpl

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 550599] Review Request: themonospot-console - console application to scan multimedia files

2009-12-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550599





--- Comment #5 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp  2009-12-29 
10:42:36 EDT ---
For -3:

* Timestamps
  - Use cp -p to keep timestamps on installed files

! %changelog
  - As I wrote in -base review request, please add new %changelog
entry even during review process.

This review will be accepted once bug 550594 is accepted.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 550599] Review Request: themonospot-console - console application to scan multimedia files

2009-12-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550599


Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

 Depends on||550594
Summary|Themonospot Console |Review Request:
   |application - console   |themonospot-console -
   |application to scan |console application to scan
   |multimedia files|multimedia files




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review