Re: [FFmpeg-devel] [PATCH] confgure: create quick access fate samples link
On Wed, Sep 03, 2014 at 10:29:32PM +0200, Reimar Döffinger wrote: > On 03.09.2014, at 22:09, Michael Niedermayer wrote: > > On Wed, Sep 03, 2014 at 08:46:04PM +0200, Reimar Döffinger wrote: > >> On 03.09.2014, at 18:49, Michael Niedermayer wrote: > >>> This allows using fs/ from the directory where ffmpeg > >>> was build > >>> for example in bug reports. > >>> > >>> Alternatively this could be created from the Makefile > >>> > >>> This of course works only on OS and file-systems which support links > >> > >> Not sure what ln_s is or does, but there are cases where ln -s will have a > >> dummy implementation that does cp instead. > >> Especially for this reason I rather don't like having this as something > >> that is enabled by default. > > > > the code checks if theres real link support before linking the > > fate samples > > if its not supported nothing is created > > Ah, so that's what all that code is there for :) > Then I change my comment to request that you added a comment saying it checks > for working ln. > I'd also suggest that one of the clean make targets should remove the link. > And maybe we should remove it in configure as well before (re-)creating or > does it already handle that, too, and I missed it? the ln_s includes a -f(orce) [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many that live deserve death. And some that die deserve life. Can you give it to them? Then do not be too eager to deal out death in judgement. For even the very wise cannot see all ends. -- Gandalf signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] confgure: create quick access fate samples link
On 03.09.2014, at 22:09, Michael Niedermayer wrote: > On Wed, Sep 03, 2014 at 08:46:04PM +0200, Reimar Döffinger wrote: >> On 03.09.2014, at 18:49, Michael Niedermayer wrote: >>> This allows using fs/ from the directory where ffmpeg >>> was build >>> for example in bug reports. >>> >>> Alternatively this could be created from the Makefile >>> >>> This of course works only on OS and file-systems which support links >> >> Not sure what ln_s is or does, but there are cases where ln -s will have a >> dummy implementation that does cp instead. >> Especially for this reason I rather don't like having this as something that >> is enabled by default. > > the code checks if theres real link support before linking the > fate samples > if its not supported nothing is created Ah, so that's what all that code is there for :) Then I change my comment to request that you added a comment saying it checks for working ln. I'd also suggest that one of the clean make targets should remove the link. And maybe we should remove it in configure as well before (re-)creating or does it already handle that, too, and I missed it? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] confgure: create quick access fate samples link
On Wed, Sep 03, 2014 at 08:46:04PM +0200, Reimar Döffinger wrote: > On 03.09.2014, at 18:49, Michael Niedermayer wrote: > > This allows using fs/ from the directory where ffmpeg > > was build > > for example in bug reports. > > > > Alternatively this could be created from the Makefile > > > > This of course works only on OS and file-systems which support links > > Not sure what ln_s is or does, but there are cases where ln -s will have a > dummy implementation that does cp instead. > Especially for this reason I rather don't like having this as something that > is enabled by default. the code checks if theres real link support before linking the fate samples if its not supported nothing is created [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Old school: Use the lowest level language in which you can solve the problem conveniently. New school: Use the highest level language in which the latest supercomputer can solve the problem without the user falling asleep waiting. signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] confgure: create quick access fate samples link
On 03.09.2014, at 18:49, Michael Niedermayer wrote: > This allows using fs/ from the directory where ffmpeg was > build > for example in bug reports. > > Alternatively this could be created from the Makefile > > This of course works only on OS and file-systems which support links Not sure what ln_s is or does, but there are cases where ln -s will have a dummy implementation that does cp instead. Especially for this reason I rather don't like having this as something that is enabled by default. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH] confgure: create quick access fate samples link
This allows using fs/ from the directory where ffmpeg was build for example in bug reports. Alternatively this could be created from the Makefile This of course works only on OS and file-systems which support links Signed-off-by: Michael Niedermayer --- configure |8 1 file changed, 8 insertions(+) diff --git a/configure b/configure index b1814db..919f2fb 100755 --- a/configure +++ b/configure @@ -5705,3 +5705,11 @@ pkgconfig_generate libpostproc "FFmpeg postprocessing library""$LIBPOS pkgconfig_generate libavresample "Libav audio resampling library" "$LIBAVRESAMPLE_VERSION" "$LIBM" pkgconfig_generate libswscale"FFmpeg image rescaling library" "$LIBSWSCALE_VERSION""$LIBM" pkgconfig_generate libswresample "FFmpeg audio resampling library" "$LIBSWRESAMPLE_VERSION" "$LIBM" + +#Create quick access fate samples link +if test -n "$samples" ;then +echo A > $TMPH +$ln_s -T $TMPH fs +echo B > fs +grep -q B $TMPH && $ln_s -T "$samples" fs +fi -- 1.7.9.5 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
