Re: [FFmpeg-devel] [PATCH 1/2] refine the doc of hlsenc

[Moritz Barsnick]

Hi,
generally speaking, should it also be mentioned how hls_flags are used
(or at least that it takes the flags syntax)?

On Tue, Jul 12, 2016 at 21:35:46 +0800, Steven Liu wrote:

> [PATCH 1/2] refine the doc of hlsenc

Should probably be:
[PATCH ...] doc/muxers: improve hlsenc description

> +@item hls_flags round_durations
> +If this flag is set, the muxer will make the duration info form float point 
> to
> +integer for playlist file segment info.

Let's drop the "If this flag is set", I believe that's implicit anyway.
Suggestion:
+@item hls_flags round_durations
+Round the duration info in the playlist file segment info to integer
+values, instead of using floating point.

> +@item hls_flags discont_starts
> +If this flag is set, it will add the @code{#EXT-X-DISCONTINUITY} tag into the
> +playlist at the first segment infomation's front.

+@item hls_flags discont_starts
+Add the @code{#EXT-X-DISCONTINUITY} tag to the playlist, before the
+first segment's information.

> +@item hls_flags omit_endlist
> +If this flag is set, it will not append the @code{EXT-X-ENDLIST} tag at the 
> end of
> +the playlist.

+@item hls_flags omit_endlist
+Do not append the @code{EXT-X-ENDLIST} tag at the end of the playlist.

I also suggest changing the following, but perhaps (just as my first
suggestion) this could be a separate patch:

 @item hls_segment_filename @var{filename}
-Set the segment filename. Unless hls_flags single_file is set @var{filename}
-is used as a string format with the segment number:
+Set the segment filename. Unless @code{hls_flags single_file} is set,
+@var{filename} is used as a string format with the segment number:
 @example

And

 @item hls_flags split_by_time
-If this flags is set, allow segments to start on frames other than keyframes.
-This improves behavior on some players when the time between keyframes is
-inconsistent, but may make things worse on others, and can cause some oddities
-during seeking. This flag should be used with hls_time option.
+Allow segments to start on frames other than keyframes. This improves
+behavior on some players when the time between keyframes is inconsistent,
+but may make things worse on others, and can cause some oddities during
+seeking. This flag should be used with the @code{hls_time} option.

Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] refine the doc of hlsenc

[Steven Liu]

2016-07-13 4:24 GMT+08:00 Michael Niedermayer :

> On Tue, Jul 12, 2016 at 09:35:46PM +0800, Steven Liu wrote:
> > resend the patch, delete the trailing whitespace and check patch by
> > ./tools/patcheck
> >
> > add the hls_flags round_durations, discont_start, omit_endlist flags
> > describe
> >
> > Signed-off-by: LiuQi 
> > ---
> >  doc/muxers.texi |   12 
> >  1 files changed, 12 insertions(+), 0 deletions(-)
>
> I think a native english speaker should review this and the other
> patch
>
> [...]
>
> Hi Moritz Barsnick,

  Can you help me review this patch?
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] refine the doc of hlsenc

[Michael Niedermayer]

On Tue, Jul 12, 2016 at 09:35:46PM +0800, Steven Liu wrote:
> resend the patch, delete the trailing whitespace and check patch by
> ./tools/patcheck
> 
> add the hls_flags round_durations, discont_start, omit_endlist flags
> describe
> 
> Signed-off-by: LiuQi 
> ---
>  doc/muxers.texi |   12 
>  1 files changed, 12 insertions(+), 0 deletions(-)

I think a native english speaker should review this and the other
patch

[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 1/2] refine the doc of hlsenc

[Steven Liu]

resend the patch, delete the trailing whitespace and check patch by
./tools/patcheck

add the hls_flags round_durations, discont_start, omit_endlist flags
describe

Signed-off-by: LiuQi 
---
 doc/muxers.texi |   12 
 1 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/doc/muxers.texi b/doc/muxers.texi
index 15b63f4..bf5bc82 100644
--- a/doc/muxers.texi
+++ b/doc/muxers.texi
@@ -495,6 +495,18 @@ Will produce the playlist, @file{out.m3u8}, and a
single segment file,
 Segment files removed from the playlist are deleted after a period of time
 equal to the duration of the segment plus the duration of the playlist.

+@item hls_flags round_durations
+If this flag is set, the muxer will make the duration info form float
point to
+integer for playlist file segment info.
+
+@item hls_flags discont_starts
+If this flag is set, it will add the @code{#EXT-X-DISCONTINUITY} tag into
the
+playlist at the first segment infomation's front.
+
+@item hls_flags omit_endlist
+If this flag is set, it will not append the @code{EXT-X-ENDLIST} tag at
the end of
+the playlist.
+
 @item hls_flags split_by_time
 If this flags is set, allow segments to start on frames other than
keyframes.
 This improves behavior on some players when the time between keyframes is
-- 
1.7.1


0001-refine-the-doc-of-hlsenc.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] refine the doc of hlsenc

[Michael Niedermayer]

On Tue, Jul 12, 2016 at 11:55:05AM +0800, Steven Liu wrote:
> add the hls_flags round_durations, discont_start, omit_endlist flags
> describe
> 
[...]

>  muxers.texi |   12 
>  1 file changed, 12 insertions(+)
> 2c76ab4a4f03f11a29c95ef2703d98b4ca31ca83  0001-refine-the-doc-of-hlsenc.patch
> From 7909967dd0206c75a844ff72a1e0c902517175df Mon Sep 17 00:00:00 2001
> From: Steven Liu 
> Date: Tue, 12 Jul 2016 10:19:45 +0800
> Subject: [PATCH 1/2] refine the doc of hlsenc
> 
> add the hls_flags round_durations, discont_start, omit_endlist flags describe
> 
> Signed-off-by: LiuQi 
> ---
>  doc/muxers.texi |   12 
>  1 files changed, 12 insertions(+), 0 deletions(-)
> 
> diff --git a/doc/muxers.texi b/doc/muxers.texi
> index 15b63f4..bf5bc82 100644
> --- a/doc/muxers.texi
> +++ b/doc/muxers.texi
> @@ -495,6 +495,18 @@ Will produce the playlist, @file{out.m3u8}, and a single 
> segment file,
>  Segment files removed from the playlist are deleted after a period of time
>  equal to the duration of the segment plus the duration of the playlist.
>  
> +@item hls_flags round_durations
> +If this flag is set, the muxer will make the duration info form float point 
> to
> +integer for playlist file segment info.
> +
> +@item hls_flags discont_starts
> +If this flag is set, it will add the @code{#EXT-X-DISCONTINUITY} tag into 
> the 
> +playlist at the first segment infomation's front.
> +
> +@item hls_flags omit_endlist

> +If this flag is set, it will not append the @code{EXT-X-ENDLIST} tag at the 
> end of  

trailing whitespace is forbidden in ffmpeg

[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
conveniently.
New school: Use the highest level language in which the latest supercomputer
can solve the problem without the user falling asleep waiting.


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 1/2] refine the doc of hlsenc

[Steven Liu]

add the hls_flags round_durations, discont_start, omit_endlist flags
describe

Signed-off-by: LiuQi 
---
 doc/muxers.texi |   12 
 1 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/doc/muxers.texi b/doc/muxers.texi
index 15b63f4..bf5bc82 100644
--- a/doc/muxers.texi
+++ b/doc/muxers.texi
@@ -495,6 +495,18 @@ Will produce the playlist, @file{out.m3u8}, and a
single segment file,
 Segment files removed from the playlist are deleted after a period of time
 equal to the duration of the segment plus the duration of the playlist.

+@item hls_flags round_durations
+If this flag is set, the muxer will make the duration info form float
point to
+integer for playlist file segment info.
+
+@item hls_flags discont_starts
+If this flag is set, it will add the @code{#EXT-X-DISCONTINUITY} tag into
the
+playlist at the first segment infomation's front.
+
+@item hls_flags omit_endlist
+If this flag is set, it will not append the @code{EXT-X-ENDLIST} tag at
the end of
+the playlist.
+
 @item hls_flags split_by_time
 If this flags is set, allow segments to start on frames other than
keyframes.
 This improves behavior on some players when the time between keyframes is
--
1.7.1


0001-refine-the-doc-of-hlsenc.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel