Re: [FFmpeg-devel] [PATCH 2/2] avcodec: remove anatoliy prores encoder
On 4/26/18, Carl Eugen Hoyos wrote: > 2018-04-26 13:48 GMT+02:00, Paul B Mahol : >> On 4/26/18, Carl Eugen Hoyos wrote: >>> 2018-04-26 13:34 GMT+02:00, Paul B Mahol : On 4/26/18, Carl Eugen Hoyos wrote: > 2018-04-26 13:17 GMT+02:00, Josh de Kock : >> On 2017/06/26 15:09, Paul B Mahol wrote: >>> Rationale: >>> - Slower then other encoder >>> - Less configurable >>> - Does not support alpha profile >>> - Does not set interlaced flag >>> - Worse output quality >>> - No need for 2 encoders >>> >>> Signed-off-by: Paul B Mahol >>> >> Is there any reason this was not pushed? >> I can't seem to see any argument against it. > > It was shown in the past that this encoder is faster, > more efficient and produces better quality. Why are you not telling real truth? >>> >>> This is surprisingly rude: >>> I am always trying to tell the truth, one of the things >>> that make me less happy about contributing here is >>> both that I am not allowed to write the truth anymore. >>> >>> Anyway: In the discussion about adding one of the >>> features you mention above, tests were posted that >>> showed this encoder to produce better (objective, >>> with all its disadvantages) quality using measurably >>> less cycles. >> >> That was with default configuration for both of them. > > Which is not the most likely usecase? Even if it is, that is unfair comparison. Because options and settings are incompatible. I hope you understand this. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 2/2] avcodec: remove anatoliy prores encoder
Paul B Mahol (2018-04-26): > That was with default configuration for both of them. Then please post a patch to enhance the default configuration. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 2/2] avcodec: remove anatoliy prores encoder
2018-04-26 13:48 GMT+02:00, Paul B Mahol : > On 4/26/18, Carl Eugen Hoyos wrote: >> 2018-04-26 13:34 GMT+02:00, Paul B Mahol : >>> On 4/26/18, Carl Eugen Hoyos wrote: 2018-04-26 13:17 GMT+02:00, Josh de Kock : > On 2017/06/26 15:09, Paul B Mahol wrote: >> Rationale: >> - Slower then other encoder >> - Less configurable >> - Does not support alpha profile >> - Does not set interlaced flag >> - Worse output quality >> - No need for 2 encoders >> >> Signed-off-by: Paul B Mahol >> > Is there any reason this was not pushed? > I can't seem to see any argument against it. It was shown in the past that this encoder is faster, more efficient and produces better quality. >>> >>> Why are you not telling real truth? >> >> This is surprisingly rude: >> I am always trying to tell the truth, one of the things >> that make me less happy about contributing here is >> both that I am not allowed to write the truth anymore. >> >> Anyway: In the discussion about adding one of the >> features you mention above, tests were posted that >> showed this encoder to produce better (objective, >> with all its disadvantages) quality using measurably >> less cycles. > > That was with default configuration for both of them. Which is not the most likely usecase? > That's like comparing apples and oranges. > > I fail to see how that makes your statements true. You seem to remember the situation even better than I do, so I really don't understand your comments... >>> None of your claims are really true. >> >> Given how much you embarrassed us in the prores >> discussion, I wonder why you make this claim;-) > > Now, this is just rude. No? > I expected this all the time. You expected all the time that prores actually is 12bit? (I didn't) Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 2/2] avcodec: remove anatoliy prores encoder
On Thu, 26 Apr 2018 13:39:56 +0200 Carl Eugen Hoyos wrote: > 2018-04-26 13:34 GMT+02:00, Paul B Mahol : > > On 4/26/18, Carl Eugen Hoyos wrote: > >> 2018-04-26 13:17 GMT+02:00, Josh de Kock : > >>> On 2017/06/26 15:09, Paul B Mahol wrote: > Rationale: > - Slower then other encoder > - Less configurable > - Does not support alpha profile > - Does not set interlaced flag > - Worse output quality > - No need for 2 encoders > > Signed-off-by: Paul B Mahol > > >>> Is there any reason this was not pushed? > >>> I can't seem to see any argument against it. > >> > >> It was shown in the past that this encoder is faster, > >> more efficient and produces better quality. > > > > Why are you not telling real truth? > > This is surprisingly rude: > I am always trying to tell the truth, one of the things > that make me less happy about contributing here is > both that I am not allowed to write the truth anymore. What would those truths be? Note: insults are not truths. > Anyway: In the discussion about adding one of the > features you mention above, tests were posted that > showed this encoder to produce better (objective, > with all its disadvantages) quality using measurably > less cycles. > > > None of your claims are really true. > > Given how much you embarrassed us in the prores > discussion, I wonder why you make this claim;-) That is surprisingly rude. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 2/2] avcodec: remove anatoliy prores encoder
On 4/26/18, Carl Eugen Hoyos wrote: > 2018-04-26 13:34 GMT+02:00, Paul B Mahol : >> On 4/26/18, Carl Eugen Hoyos wrote: >>> 2018-04-26 13:17 GMT+02:00, Josh de Kock : On 2017/06/26 15:09, Paul B Mahol wrote: > Rationale: > - Slower then other encoder > - Less configurable > - Does not support alpha profile > - Does not set interlaced flag > - Worse output quality > - No need for 2 encoders > > Signed-off-by: Paul B Mahol > Is there any reason this was not pushed? I can't seem to see any argument against it. >>> >>> It was shown in the past that this encoder is faster, >>> more efficient and produces better quality. >> >> Why are you not telling real truth? > > This is surprisingly rude: > I am always trying to tell the truth, one of the things > that make me less happy about contributing here is > both that I am not allowed to write the truth anymore. > > Anyway: In the discussion about adding one of the > features you mention above, tests were posted that > showed this encoder to produce better (objective, > with all its disadvantages) quality using measurably > less cycles. That was with default configuration for both of them. That's like comparing apples and oranges. I fail to see how that makes your statements true. > >> None of your claims are really true. > > Given how much you embarrassed us in the prores > discussion, I wonder why you make this claim;-) Now, this is just rude. I expected this all the time. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 2/2] avcodec: remove anatoliy prores encoder
2018-04-26 13:34 GMT+02:00, Paul B Mahol : > On 4/26/18, Carl Eugen Hoyos wrote: >> 2018-04-26 13:17 GMT+02:00, Josh de Kock : >>> On 2017/06/26 15:09, Paul B Mahol wrote: Rationale: - Slower then other encoder - Less configurable - Does not support alpha profile - Does not set interlaced flag - Worse output quality - No need for 2 encoders Signed-off-by: Paul B Mahol >>> Is there any reason this was not pushed? >>> I can't seem to see any argument against it. >> >> It was shown in the past that this encoder is faster, >> more efficient and produces better quality. > > Why are you not telling real truth? This is surprisingly rude: I am always trying to tell the truth, one of the things that make me less happy about contributing here is both that I am not allowed to write the truth anymore. Anyway: In the discussion about adding one of the features you mention above, tests were posted that showed this encoder to produce better (objective, with all its disadvantages) quality using measurably less cycles. > None of your claims are really true. Given how much you embarrassed us in the prores discussion, I wonder why you make this claim;-) Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 2/2] avcodec: remove anatoliy prores encoder
On Thu, 26 Apr 2018 13:34:12 +0200 Paul B Mahol wrote: > On 4/26/18, Carl Eugen Hoyos wrote: > > 2018-04-26 13:17 GMT+02:00, Josh de Kock : > >> On 2017/06/26 15:09, Paul B Mahol wrote: > >>> Rationale: > >>> - Slower then other encoder > >>> - Less configurable > >>> - Does not support alpha profile > >>> - Does not set interlaced flag > >>> - Worse output quality > >>> - No need for 2 encoders > >>> > >>> Signed-off-by: Paul B Mahol > >>> > >> Is there any reason this was not pushed? > >> I can't seem to see any argument against it. > > > > It was shown in the past that this encoder is faster, > > more efficient and produces better quality. > > Why are you not telling real truth? > > None of your claims are really true. > > I wonder why. Can any of you post numbers? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 2/2] avcodec: remove anatoliy prores encoder
On 4/26/18, Carl Eugen Hoyos wrote: > 2018-04-26 13:17 GMT+02:00, Josh de Kock : >> On 2017/06/26 15:09, Paul B Mahol wrote: >>> Rationale: >>> - Slower then other encoder >>> - Less configurable >>> - Does not support alpha profile >>> - Does not set interlaced flag >>> - Worse output quality >>> - No need for 2 encoders >>> >>> Signed-off-by: Paul B Mahol >>> >> Is there any reason this was not pushed? >> I can't seem to see any argument against it. > > It was shown in the past that this encoder is faster, > more efficient and produces better quality. Why are you not telling real truth? None of your claims are really true. I wonder why. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 2/2] avcodec: remove anatoliy prores encoder
On 2018/04/26 12:26, Carl Eugen Hoyos wrote: 2018-04-26 13:17 GMT+02:00, Josh de Kock : On 2017/06/26 15:09, Paul B Mahol wrote: Rationale: - Slower then other encoder - Less configurable - Does not support alpha profile - Does not set interlaced flag - Worse output quality - No need for 2 encoders Signed-off-by: Paul B Mahol Is there any reason this was not pushed? I can't seem to see any argument against it. It was shown in the past that this encoder is faster, more efficient and produces better quality. I don't know when this has changed. Ok, there was some discussion on IRC, so I was unsure. I will look into it again. -- Josh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 2/2] avcodec: remove anatoliy prores encoder
2018-04-26 13:17 GMT+02:00, Josh de Kock : > On 2017/06/26 15:09, Paul B Mahol wrote: >> Rationale: >> - Slower then other encoder >> - Less configurable >> - Does not support alpha profile >> - Does not set interlaced flag >> - Worse output quality >> - No need for 2 encoders >> >> Signed-off-by: Paul B Mahol >> > Is there any reason this was not pushed? > I can't seem to see any argument against it. It was shown in the past that this encoder is faster, more efficient and produces better quality. I don't know when this has changed. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 2/2] avcodec: remove anatoliy prores encoder
On 2017/06/26 15:09, Paul B Mahol wrote: Rationale: - Slower then other encoder - Less configurable - Does not support alpha profile - Does not set interlaced flag - Worse output quality - No need for 2 encoders Signed-off-by: Paul B Mahol Is there any reason this was not pushed? I can't seem to see any argument against it. -- Josh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 2/2] avcodec: remove anatoliy prores encoder
On Mon, Jun 26, 2017 at 5:09 PM, Paul B Mahol wrote: > Rationale: > - Slower then other encoder > - Less configurable > - Does not support alpha profile > - Does not set interlaced flag > - Worse output quality > - No need for 2 encoders > I agree with this clean-up. Probably needs an API/ABI bump? Jan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH 2/2] avcodec: remove anatoliy prores encoder
Rationale:
- Slower then other encoder
- Less configurable
- Does not support alpha profile
- Does not set interlaced flag
- Worse output quality
- No need for 2 encoders
Signed-off-by: Paul B Mahol
---
doc/encoders.texi | 5 +-
libavcodec/Makefile | 1 -
libavcodec/allcodecs.c | 1 -
libavcodec/proresenc_anatoliy.c | 616
4 files changed, 1 insertion(+), 622 deletions(-)
delete mode 100644 libavcodec/proresenc_anatoliy.c
diff --git a/doc/encoders.texi b/doc/encoders.texi
index a8bee09..37d6378 100644
--- a/doc/encoders.texi
+++ b/doc/encoders.texi
@@ -2367,10 +2367,7 @@ Set physical density of pixels, in dots per meter, unset
by default
Apple ProRes encoder.
-FFmpeg contains 2 ProRes encoders, the prores-aw and prores-ks encoder.
-The used encoder can be chosen with the @code{-vcodec} option.
-
-@subsection Private Options for prores-ks
+@subsection Private Options for prores
@table @option
@item profile @var{integer}
diff --git a/libavcodec/Makefile b/libavcodec/Makefile
index 16dce40..ea47008 100644
--- a/libavcodec/Makefile
+++ b/libavcodec/Makefile
@@ -478,7 +478,6 @@ OBJS-$(CONFIG_PPM_ENCODER) += pnmenc.o
OBJS-$(CONFIG_PRORES_DECODER) += proresdec2.o proresdsp.o proresdata.o
OBJS-$(CONFIG_PRORES_LGPL_DECODER) += proresdec_lgpl.o proresdsp.o
proresdata.o
OBJS-$(CONFIG_PRORES_ENCODER) += proresenc_kostya.o proresdata.o
-OBJS-$(CONFIG_PRORES_AW_ENCODER) += proresenc_anatoliy.o
OBJS-$(CONFIG_PRORES_KS_ENCODER) += proresenc_kostya.o proresdata.o
OBJS-$(CONFIG_PSD_DECODER) += psd.o
OBJS-$(CONFIG_PTX_DECODER) += ptx.o
diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
index 54a9e8c..f291d6a 100644
--- a/libavcodec/allcodecs.c
+++ b/libavcodec/allcodecs.c
@@ -287,7 +287,6 @@ static void register_all(void)
REGISTER_ENCDEC (PNG, png);
REGISTER_ENCDEC (PPM, ppm);
REGISTER_ENCDEC (PRORES,prores);
-REGISTER_ENCODER(PRORES_AW, prores_aw);
REGISTER_ENCODER(PRORES_KS, prores_ks);
REGISTER_DECODER(PRORES_LGPL, prores_lgpl);
REGISTER_DECODER(PSD, psd);
diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c
deleted file mode 100644
index 7ff6ff7..000
--- a/libavcodec/proresenc_anatoliy.c
+++ /dev/null
@@ -1,616 +0,0 @@
-/*
- * Apple ProRes encoder
- *
- * Copyright (c) 2011 Anatoliy Wasserman
- *
- * This file is part of FFmpeg.
- *
- * FFmpeg is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 2.1 of the License, or (at your option) any later version.
- *
- * FFmpeg is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with FFmpeg; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
- */
-
-/**
- * @file
- * Apple ProRes encoder (Anatoliy Wasserman version)
- * Known FOURCCs: 'apch' (HQ), 'apcn' (SD), 'apcs' (LT), 'acpo' (Proxy)
- */
-
-#include "avcodec.h"
-#include "dct.h"
-#include "internal.h"
-#include "put_bits.h"
-#include "bytestream.h"
-#include "fdctdsp.h"
-
-#define DEFAULT_SLICE_MB_WIDTH 8
-
-#define FF_PROFILE_PRORES_PROXY 0
-#define FF_PROFILE_PRORES_LT1
-#define FF_PROFILE_PRORES_STANDARD 2
-#define FF_PROFILE_PRORES_HQ3
-
-static const AVProfile profiles[] = {
-{ FF_PROFILE_PRORES_PROXY,"apco"},
-{ FF_PROFILE_PRORES_LT, "apcs"},
-{ FF_PROFILE_PRORES_STANDARD, "apcn"},
-{ FF_PROFILE_PRORES_HQ, "apch"},
-{ FF_PROFILE_UNKNOWN }
-};
-
-static const int qp_start_table[4] = { 4, 1, 1, 1 };
-static const int qp_end_table[4] = { 8, 9, 6, 6 };
-static const int bitrate_table[5] = { 1000, 2100, 3500, 5400 };
-
-static const uint8_t progressive_scan[64] = {
- 0, 1, 8, 9, 2, 3, 10, 11,
-16, 17, 24, 25, 18, 19, 26, 27,
- 4, 5, 12, 20, 13, 6, 7, 14,
-21, 28, 29, 22, 15, 23, 30, 31,
-32, 33, 40, 48, 41, 34, 35, 42,
-49, 56, 57, 50, 43, 36, 37, 44,
-51, 58, 59, 52, 45, 38, 39, 46,
-53, 60, 61, 54, 47, 55, 62, 63
-};
-
-static const uint8_t QMAT_LUMA[4][64] = {
-{
- 4, 7, 9, 11, 13, 14, 15, 63,
- 7, 7, 11, 12, 14, 15, 63, 63,
- 9, 11, 13, 14, 15, 63, 63, 63,
-11, 11, 13, 14, 63, 63, 63, 63,
-11, 13, 14, 63, 63, 63, 63, 63,
-13, 14, 63, 63, 63, 63, 63, 63,
-13, 63, 63, 63, 63, 63, 63, 63,
-63, 63, 63, 63, 63, 63, 63, 63
-}, {
- 4, 5, 6, 7, 9, 11, 13, 1
