Re: [FFmpeg-devel] Question about "make distclean" after "git pull"

2016-02-18 Thread Mats Peterson

On 02/18/2016 12:45 PM, Nicolas George wrote:

L'octidi 28 pluviôse, an CCXXIV, Nicolas George a écrit :

   There may
have been cases where forgetting distclean would cause bugs more subtle than
that, but I do not remember the specifics.


Just found one: .d files contained the full path of headers for an old
version of libvpx that I just removed, they caused the compiler to still use
them for some reason, and that caused ABI incompatibility with the lib.

Regards,


Ouch. Thanks for the "use case".

Mats

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] Question about "make distclean" after "git pull"

2016-02-18 Thread Nicolas George
L'octidi 28 pluviôse, an CCXXIV, Nicolas George a écrit :
>  There may
> have been cases where forgetting distclean would cause bugs more subtle than
> that, but I do not remember the specifics.

Just found one: .d files contained the full path of headers for an old
version of libvpx that I just removed, they caused the compiler to still use
them for some reason, and that caused ABI incompatibility with the lib.

Regards,

-- 
  Nicolas George


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] Question about "make distclean" after "git pull"

2016-02-16 Thread Ronald S. Bultje
Hi,

On Tue, Feb 16, 2016 at 11:37 AM, Nicolas George  wrote:

> L'octidi 28 pluviôse, an CCXXIV, Mats Peterson a écrit :
> > Is it very important to use a "make distclean" after a "git pull"? It
> > depends on the changes made to the newly pulled code, I guess.
>
> Exactly. The most common issue is when files are renamed or deleted:
> without
> distclean, the dependency files are still there and make will fail because
> it thinks it still needs them.


And the workaround (this happens to me every few days) is:

find . -name '*.d' -exec rm -f {} \;

(in your builddir) - use at your own risk :-).

Ronald
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] Question about "make distclean" after "git pull"

2016-02-16 Thread Mats Peterson

On 02/16/2016 05:37 PM, Nicolas George wrote:

L'octidi 28 pluviôse, an CCXXIV, Mats Peterson a écrit :

Is it very important to use a "make distclean" after a "git pull"? It
depends on the changes made to the newly pulled code, I guess.


Exactly. The most common issue is when files are renamed or deleted: without
distclean, the dependency files are still there and make will fail because
it thinks it still needs them.

So basically: if you forget distclean and it works, then it was probably not
necessary; and if build fails, you know distclean was necessary. There may
have been cases where forgetting distclean would cause bugs more subtle than
that, but I do not remember the specifics.

Regards,



Thanks for this exhaustive answer, Nicolas.

Mats

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] Question about "make distclean" after "git pull"

2016-02-16 Thread Nicolas George
L'octidi 28 pluviôse, an CCXXIV, Mats Peterson a écrit :
> Is it very important to use a "make distclean" after a "git pull"? It
> depends on the changes made to the newly pulled code, I guess.

Exactly. The most common issue is when files are renamed or deleted: without
distclean, the dependency files are still there and make will fail because
it thinks it still needs them.

So basically: if you forget distclean and it works, then it was probably not
necessary; and if build fails, you know distclean was necessary. There may
have been cases where forgetting distclean would cause bugs more subtle than
that, but I do not remember the specifics.

Regards,

-- 
  Nicolas George


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


[FFmpeg-devel] Question about "make distclean" after "git pull"

2016-02-16 Thread Mats Peterson
Is it very important to use a "make distclean" after a "git pull"? It 
depends on the changes made to the newly pulled code, I guess.


Mats

--
Mats Peterson
http://matsp888.no-ip.org/~mats/
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel