Re: [FFmpeg-devel] [PATCH 1/18] avcodec: remove obsolete FF_API_FAST_MALLOC cruft
On 01/10/14 12:31 AM, James Almer wrote: > On 01/10/14 12:18 AM, Michael Niedermayer wrote: >> On Tue, Sep 30, 2014 at 11:57:14PM -0300, James Almer wrote: >>> On 30/09/14 11:34 PM, Michael Niedermayer wrote: On Mon, Sep 15, 2014 at 10:59:39PM +0200, Andreas Cadhalpun wrote: > On 15.09.2014 22:03, Michael Niedermayer wrote: >> On Mon, Sep 15, 2014 at 04:08:49PM -0300, James Almer wrote: >>> On 15/09/14 6:07 AM, Michael Niedermayer wrote: On Sun, Sep 14, 2014 at 10:46:03PM -0300, James Almer wrote: > Signed-off-by: James Almer about the patchset as a whole, not specifically this one we should check if theres any software left around that still uses the symbols before removing the code completely and if so consider to reintroduce them in a 2.4.1 while removing whats unused >>> >>> Pushed the three you reviewed since either no code depended on them, or >>> in the >>> OpenCL case it's an API that nobody has ever been able to use anyway. >>> >>> I'm not exactly interested in looking around to see if any of this >>> deprecated >>> stuff is still used. And IMO reintroducing them in a point release is >>> quite ugly. >>> An exception could be FF_API_DRAWTEXT_OLD_TIMELINE since as Clément >>> pointed in >>> another email might be needed to remain compatible with libav. >> >> probably you only have to wait, as i suspect andreas (in CC) will >> test building all dependant packages in debian against 2.4 > > You're right that I'm currently rebuilding those against 2.4, but I > don't expect any problems there, since I already have rebuilt them > against a git snapshot about two weeks ago and didn't notice > anything problematic. any news ? can these be applied ? >>> >>> Debian packages are all meant to work with libav 9 or 11 api, and all this >>> deprecated >>> code removed in 2.4 was ffmpeg exclusive, so it's unlikely they used any of >>> it. >>> Also, 2.4 has been out for two weeks and nobody complained about their >>> applications >>> breaking because these are no longer available. >>> >>> We could wait a bit more in any case. The entire patchset is just dead code >>> removal. >> >> ok, just dont forget about them, i wont keep track of them anymore >> too much stuff to keep track off > > I'll apply them this weekend, then. Patchset applied, except for "[PATCH 17/18] avfilter: remove obsolete FF_API_DRAWTEXT_OLD_TIMELINE cruft" as we may need to reintroduce that functionality to remain compatible with libav. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 1/18] avcodec: remove obsolete FF_API_FAST_MALLOC cruft
On 01.10.2014 04:34, Michael Niedermayer wrote: On Mon, Sep 15, 2014 at 10:59:39PM +0200, Andreas Cadhalpun wrote: On 15.09.2014 22:03, Michael Niedermayer wrote: On Mon, Sep 15, 2014 at 04:08:49PM -0300, James Almer wrote: On 15/09/14 6:07 AM, Michael Niedermayer wrote: On Sun, Sep 14, 2014 at 10:46:03PM -0300, James Almer wrote: Signed-off-by: James Almer about the patchset as a whole, not specifically this one we should check if theres any software left around that still uses the symbols before removing the code completely and if so consider to reintroduce them in a 2.4.1 while removing whats unused Pushed the three you reviewed since either no code depended on them, or in the OpenCL case it's an API that nobody has ever been able to use anyway. I'm not exactly interested in looking around to see if any of this deprecated stuff is still used. And IMO reintroducing them in a point release is quite ugly. An exception could be FF_API_DRAWTEXT_OLD_TIMELINE since as Clément pointed in another email might be needed to remain compatible with libav. probably you only have to wait, as i suspect andreas (in CC) will test building all dependant packages in debian against 2.4 You're right that I'm currently rebuilding those against 2.4, but I don't expect any problems there, since I already have rebuilt them against a git snapshot about two weeks ago and didn't notice anything problematic. any news ? can these be applied ? In case it wasn't sufficiently clear: There were no problems rebuilding them against FFmpeg 2.4, just as expected. Best regards, Andreas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 1/18] avcodec: remove obsolete FF_API_FAST_MALLOC cruft
On 01/10/14 12:18 AM, Michael Niedermayer wrote: > On Tue, Sep 30, 2014 at 11:57:14PM -0300, James Almer wrote: >> On 30/09/14 11:34 PM, Michael Niedermayer wrote: >>> On Mon, Sep 15, 2014 at 10:59:39PM +0200, Andreas Cadhalpun wrote: On 15.09.2014 22:03, Michael Niedermayer wrote: > On Mon, Sep 15, 2014 at 04:08:49PM -0300, James Almer wrote: >> On 15/09/14 6:07 AM, Michael Niedermayer wrote: >>> On Sun, Sep 14, 2014 at 10:46:03PM -0300, James Almer wrote: Signed-off-by: James Almer >>> >>> about the patchset as a whole, not specifically this one >>> >>> we should check if theres any software left around that still uses >>> the symbols before removing the code completely and if so consider >>> to reintroduce them in a 2.4.1 while removing whats unused >> >> Pushed the three you reviewed since either no code depended on them, or >> in the >> OpenCL case it's an API that nobody has ever been able to use anyway. >> >> I'm not exactly interested in looking around to see if any of this >> deprecated >> stuff is still used. And IMO reintroducing them in a point release is >> quite ugly. >> An exception could be FF_API_DRAWTEXT_OLD_TIMELINE since as Clément >> pointed in >> another email might be needed to remain compatible with libav. > > probably you only have to wait, as i suspect andreas (in CC) will > test building all dependant packages in debian against 2.4 You're right that I'm currently rebuilding those against 2.4, but I don't expect any problems there, since I already have rebuilt them against a git snapshot about two weeks ago and didn't notice anything problematic. >>> >>> any news ? can these be applied ? >> >> Debian packages are all meant to work with libav 9 or 11 api, and all this >> deprecated >> code removed in 2.4 was ffmpeg exclusive, so it's unlikely they used any of >> it. >> Also, 2.4 has been out for two weeks and nobody complained about their >> applications >> breaking because these are no longer available. >> >> We could wait a bit more in any case. The entire patchset is just dead code >> removal. > > ok, just dont forget about them, i wont keep track of them anymore > too much stuff to keep track off I'll apply them this weekend, then. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 1/18] avcodec: remove obsolete FF_API_FAST_MALLOC cruft
On Tue, Sep 30, 2014 at 11:57:14PM -0300, James Almer wrote: > On 30/09/14 11:34 PM, Michael Niedermayer wrote: > > On Mon, Sep 15, 2014 at 10:59:39PM +0200, Andreas Cadhalpun wrote: > >> On 15.09.2014 22:03, Michael Niedermayer wrote: > >>> On Mon, Sep 15, 2014 at 04:08:49PM -0300, James Almer wrote: > On 15/09/14 6:07 AM, Michael Niedermayer wrote: > > On Sun, Sep 14, 2014 at 10:46:03PM -0300, James Almer wrote: > >> Signed-off-by: James Almer > > > > about the patchset as a whole, not specifically this one > > > > we should check if theres any software left around that still uses > > the symbols before removing the code completely and if so consider > > to reintroduce them in a 2.4.1 while removing whats unused > > Pushed the three you reviewed since either no code depended on them, or > in the > OpenCL case it's an API that nobody has ever been able to use anyway. > > I'm not exactly interested in looking around to see if any of this > deprecated > stuff is still used. And IMO reintroducing them in a point release is > quite ugly. > An exception could be FF_API_DRAWTEXT_OLD_TIMELINE since as Clément > pointed in > another email might be needed to remain compatible with libav. > >>> > >>> probably you only have to wait, as i suspect andreas (in CC) will > >>> test building all dependant packages in debian against 2.4 > >> > >> You're right that I'm currently rebuilding those against 2.4, but I > >> don't expect any problems there, since I already have rebuilt them > >> against a git snapshot about two weeks ago and didn't notice > >> anything problematic. > > > > any news ? can these be applied ? > > Debian packages are all meant to work with libav 9 or 11 api, and all this > deprecated > code removed in 2.4 was ffmpeg exclusive, so it's unlikely they used any of > it. > Also, 2.4 has been out for two weeks and nobody complained about their > applications > breaking because these are no longer available. > > We could wait a bit more in any case. The entire patchset is just dead code > removal. ok, just dont forget about them, i wont keep track of them anymore too much stuff to keep track off [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB What does censorship reveal? It reveals fear. -- Julian Assange signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 1/18] avcodec: remove obsolete FF_API_FAST_MALLOC cruft
On 30/09/14 11:34 PM, Michael Niedermayer wrote: > On Mon, Sep 15, 2014 at 10:59:39PM +0200, Andreas Cadhalpun wrote: >> On 15.09.2014 22:03, Michael Niedermayer wrote: >>> On Mon, Sep 15, 2014 at 04:08:49PM -0300, James Almer wrote: On 15/09/14 6:07 AM, Michael Niedermayer wrote: > On Sun, Sep 14, 2014 at 10:46:03PM -0300, James Almer wrote: >> Signed-off-by: James Almer > > about the patchset as a whole, not specifically this one > > we should check if theres any software left around that still uses > the symbols before removing the code completely and if so consider > to reintroduce them in a 2.4.1 while removing whats unused Pushed the three you reviewed since either no code depended on them, or in the OpenCL case it's an API that nobody has ever been able to use anyway. I'm not exactly interested in looking around to see if any of this deprecated stuff is still used. And IMO reintroducing them in a point release is quite ugly. An exception could be FF_API_DRAWTEXT_OLD_TIMELINE since as Clément pointed in another email might be needed to remain compatible with libav. >>> >>> probably you only have to wait, as i suspect andreas (in CC) will >>> test building all dependant packages in debian against 2.4 >> >> You're right that I'm currently rebuilding those against 2.4, but I >> don't expect any problems there, since I already have rebuilt them >> against a git snapshot about two weeks ago and didn't notice >> anything problematic. > > any news ? can these be applied ? Debian packages are all meant to work with libav 9 or 11 api, and all this deprecated code removed in 2.4 was ffmpeg exclusive, so it's unlikely they used any of it. Also, 2.4 has been out for two weeks and nobody complained about their applications breaking because these are no longer available. We could wait a bit more in any case. The entire patchset is just dead code removal. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 1/18] avcodec: remove obsolete FF_API_FAST_MALLOC cruft
On Mon, Sep 15, 2014 at 10:59:39PM +0200, Andreas Cadhalpun wrote: > On 15.09.2014 22:03, Michael Niedermayer wrote: > >On Mon, Sep 15, 2014 at 04:08:49PM -0300, James Almer wrote: > >>On 15/09/14 6:07 AM, Michael Niedermayer wrote: > >>>On Sun, Sep 14, 2014 at 10:46:03PM -0300, James Almer wrote: > Signed-off-by: James Almer > >>> > >>>about the patchset as a whole, not specifically this one > >>> > >>>we should check if theres any software left around that still uses > >>>the symbols before removing the code completely and if so consider > >>>to reintroduce them in a 2.4.1 while removing whats unused > >> > >>Pushed the three you reviewed since either no code depended on them, or in > >>the > >>OpenCL case it's an API that nobody has ever been able to use anyway. > >> > >>I'm not exactly interested in looking around to see if any of this > >>deprecated > >>stuff is still used. And IMO reintroducing them in a point release is quite > >>ugly. > >>An exception could be FF_API_DRAWTEXT_OLD_TIMELINE since as Clément pointed > >>in > >>another email might be needed to remain compatible with libav. > > > >probably you only have to wait, as i suspect andreas (in CC) will > >test building all dependant packages in debian against 2.4 > > You're right that I'm currently rebuilding those against 2.4, but I > don't expect any problems there, since I already have rebuilt them > against a git snapshot about two weeks ago and didn't notice > anything problematic. any news ? can these be applied ? [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB DNS cache poisoning attacks, popular search engine, Google internet authority dont be evil, please signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 1/18] avcodec: remove obsolete FF_API_FAST_MALLOC cruft
On 15.09.2014 22:03, Michael Niedermayer wrote: On Mon, Sep 15, 2014 at 04:08:49PM -0300, James Almer wrote: On 15/09/14 6:07 AM, Michael Niedermayer wrote: On Sun, Sep 14, 2014 at 10:46:03PM -0300, James Almer wrote: Signed-off-by: James Almer about the patchset as a whole, not specifically this one we should check if theres any software left around that still uses the symbols before removing the code completely and if so consider to reintroduce them in a 2.4.1 while removing whats unused Pushed the three you reviewed since either no code depended on them, or in the OpenCL case it's an API that nobody has ever been able to use anyway. I'm not exactly interested in looking around to see if any of this deprecated stuff is still used. And IMO reintroducing them in a point release is quite ugly. An exception could be FF_API_DRAWTEXT_OLD_TIMELINE since as Clément pointed in another email might be needed to remain compatible with libav. probably you only have to wait, as i suspect andreas (in CC) will test building all dependant packages in debian against 2.4 You're right that I'm currently rebuilding those against 2.4, but I don't expect any problems there, since I already have rebuilt them against a git snapshot about two weeks ago and didn't notice anything problematic. Best regards, Andreas PS: FFmpeg is probably going to be accepted into Debian experimental real soon now. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 1/18] avcodec: remove obsolete FF_API_FAST_MALLOC cruft
On Mon, Sep 15, 2014 at 01:19:58PM -0700, Timothy Gu wrote: > On Mon, Sep 15, 2014 at 1:03 PM, Michael Niedermayer wrote: > > On Mon, Sep 15, 2014 at 04:08:49PM -0300, James Almer wrote: > >> I'm not exactly interested in looking around to see if any of this > >> deprecated > >> stuff is still used. And IMO reintroducing them in a point release is > >> quite ugly. > >> An exception could be FF_API_DRAWTEXT_OLD_TIMELINE since as Clément > >> pointed in > >> another email might be needed to remain compatible with libav. > > > > probably you only have to wait, as i suspect andreas (in CC) will > > test building all dependant packages in debian against 2.4 > > FF_API_DRAWTEXT_OLD_TIMELINE deprecates an option, which means that a > rebuild won't show if the application works with FFmpeg or not. yes, that maybe should be put back i meant the other API stuff [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 1/18] avcodec: remove obsolete FF_API_FAST_MALLOC cruft
On Mon, Sep 15, 2014 at 1:03 PM, Michael Niedermayer wrote: > On Mon, Sep 15, 2014 at 04:08:49PM -0300, James Almer wrote: >> I'm not exactly interested in looking around to see if any of this deprecated >> stuff is still used. And IMO reintroducing them in a point release is quite >> ugly. >> An exception could be FF_API_DRAWTEXT_OLD_TIMELINE since as Clément pointed >> in >> another email might be needed to remain compatible with libav. > > probably you only have to wait, as i suspect andreas (in CC) will > test building all dependant packages in debian against 2.4 FF_API_DRAWTEXT_OLD_TIMELINE deprecates an option, which means that a rebuild won't show if the application works with FFmpeg or not. Timothy ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 1/18] avcodec: remove obsolete FF_API_FAST_MALLOC cruft
On Mon, Sep 15, 2014 at 04:08:49PM -0300, James Almer wrote: > On 15/09/14 6:07 AM, Michael Niedermayer wrote: > > On Sun, Sep 14, 2014 at 10:46:03PM -0300, James Almer wrote: > >> Signed-off-by: James Almer > > > > about the patchset as a whole, not specifically this one > > > > we should check if theres any software left around that still uses > > the symbols before removing the code completely and if so consider > > to reintroduce them in a 2.4.1 while removing whats unused > > Pushed the three you reviewed since either no code depended on them, or in > the > OpenCL case it's an API that nobody has ever been able to use anyway. > > I'm not exactly interested in looking around to see if any of this deprecated > stuff is still used. And IMO reintroducing them in a point release is quite > ugly. > An exception could be FF_API_DRAWTEXT_OLD_TIMELINE since as Clément pointed > in > another email might be needed to remain compatible with libav. probably you only have to wait, as i suspect andreas (in CC) will test building all dependant packages in debian against 2.4 [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB You can kill me, but you cannot change the truth. signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 1/18] avcodec: remove obsolete FF_API_FAST_MALLOC cruft
On 15/09/14 6:07 AM, Michael Niedermayer wrote: > On Sun, Sep 14, 2014 at 10:46:03PM -0300, James Almer wrote: >> Signed-off-by: James Almer > > about the patchset as a whole, not specifically this one > > we should check if theres any software left around that still uses > the symbols before removing the code completely and if so consider > to reintroduce them in a 2.4.1 while removing whats unused Pushed the three you reviewed since either no code depended on them, or in the OpenCL case it's an API that nobody has ever been able to use anyway. I'm not exactly interested in looking around to see if any of this deprecated stuff is still used. And IMO reintroducing them in a point release is quite ugly. An exception could be FF_API_DRAWTEXT_OLD_TIMELINE since as Clément pointed in another email might be needed to remain compatible with libav. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 1/18] avcodec: remove obsolete FF_API_FAST_MALLOC cruft
On Sun, Sep 14, 2014 at 10:46:03PM -0300, James Almer wrote: > Signed-off-by: James Almer about the patchset as a whole, not specifically this one we should check if theres any software left around that still uses the symbols before removing the code completely and if so consider to reintroduce them in a 2.4.1 while removing whats unused [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The bravest are surely those who have the clearest vision of what is before them, glory and danger alike, and yet notwithstanding go out to meet it. -- Thucydides signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
