Re: [FFmpeg-devel] [PATCH v2 3/3] avformat/mxfdec: Read Apple private Content Light Level from MXF
tis 2020-10-06 klockan 16:20 +0200 skrev Michael Niedermayer: > On Mon, Oct 05, 2020 at 10:18:32AM +0200, Tomas Härdin wrote: > > tor 2020-10-01 klockan 22:13 +0200 skrev Michael Niedermayer: > > > On Thu, Oct 01, 2020 at 03:29:19PM +0100, Harry Mallon wrote: > > > > > On 30 Sep 2020, at 08:32, Michael Niedermayer > > > > > wrote: > > > > > > > > > > fails on big endian > > > > > > > > > > --- src/tests/ref/fate/mxf-probe-applehdr10 2020-09-28 > > > > > 23:21:12.291897976 +0200 > > > > > +++ tests/data/fate/mxf-probe-applehdr10 2020-09-30 > > > > > 09:31:38.614653806 +0200 > > > > > @@ -14,7 +14,7 @@ > > > > > has_b_frames=0 > > > > > sample_aspect_ratio=1:1 > > > > > display_aspect_ratio=16:9 > > > > > -pix_fmt=yuv422p10le > > > > > +pix_fmt=yuv422p10be > > > > > level=-99 > > > > > color_range=tv > > > > > color_space=bt2020nc > > > > > Test mxf-probe-applehdr10 failed. Look at > > > > > tests/data/fate/mxf-probe-applehdr10.err for details. > > > > > src/tests/Makefile:255: recipe for target 'fate-mxf-probe-applehdr10' > > > > > failed > > > > > make: *** [fate-mxf-probe-applehdr10] Error 1 > > > > > > > > It seems fair that the pixel type is in native endian. > > > > > > maybe but the endianness of the decoder output doesnt belong in the > > > comparission > > > > > > > > > > I'm not really familiar enough with FATE to provide a patch to fix this > > > > though. Do any other FATE tests have wildcards or two versions for big > > > > and little endian? > > > > > > i dont see another probe reference file that contains a le/be format > > > > > > we had le/be issues in other places though where they where fixed by > > > forcing > > > a format with specific endianness in the test IIRC > > > > How about something like this? > > it solves the problem here. > so LGTM Pushed /Tomas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH v2 3/3] avformat/mxfdec: Read Apple private Content Light Level from MXF
On Mon, Oct 05, 2020 at 10:18:32AM +0200, Tomas Härdin wrote: > tor 2020-10-01 klockan 22:13 +0200 skrev Michael Niedermayer: > > On Thu, Oct 01, 2020 at 03:29:19PM +0100, Harry Mallon wrote: > > > > On 30 Sep 2020, at 08:32, Michael Niedermayer > > > > wrote: > > > > > > > > fails on big endian > > > > > > > > --- src/tests/ref/fate/mxf-probe-applehdr10 2020-09-28 > > > > 23:21:12.291897976 +0200 > > > > +++ tests/data/fate/mxf-probe-applehdr102020-09-30 > > > > 09:31:38.614653806 +0200 > > > > @@ -14,7 +14,7 @@ > > > > has_b_frames=0 > > > > sample_aspect_ratio=1:1 > > > > display_aspect_ratio=16:9 > > > > -pix_fmt=yuv422p10le > > > > +pix_fmt=yuv422p10be > > > > level=-99 > > > > color_range=tv > > > > color_space=bt2020nc > > > > Test mxf-probe-applehdr10 failed. Look at > > > > tests/data/fate/mxf-probe-applehdr10.err for details. > > > > src/tests/Makefile:255: recipe for target 'fate-mxf-probe-applehdr10' > > > > failed > > > > make: *** [fate-mxf-probe-applehdr10] Error 1 > > > > > > It seems fair that the pixel type is in native endian. > > > > maybe but the endianness of the decoder output doesnt belong in the > > comparission > > > > > > > I'm not really familiar enough with FATE to provide a patch to fix this > > > though. Do any other FATE tests have wildcards or two versions for big > > > and little endian? > > > > i dont see another probe reference file that contains a le/be format > > > > we had le/be issues in other places though where they where fixed by forcing > > a format with specific endianness in the test IIRC > > How about something like this? it solves the problem here. so LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are too smart to engage in politics are punished by being governed by those who are dumber. -- Plato signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH v2 3/3] avformat/mxfdec: Read Apple private Content Light Level from MXF
tor 2020-10-01 klockan 22:13 +0200 skrev Michael Niedermayer: > On Thu, Oct 01, 2020 at 03:29:19PM +0100, Harry Mallon wrote: > > > On 30 Sep 2020, at 08:32, Michael Niedermayer > > > wrote: > > > > > > fails on big endian > > > > > > --- src/tests/ref/fate/mxf-probe-applehdr10 2020-09-28 > > > 23:21:12.291897976 +0200 > > > +++ tests/data/fate/mxf-probe-applehdr10 2020-09-30 09:31:38.614653806 > > > +0200 > > > @@ -14,7 +14,7 @@ > > > has_b_frames=0 > > > sample_aspect_ratio=1:1 > > > display_aspect_ratio=16:9 > > > -pix_fmt=yuv422p10le > > > +pix_fmt=yuv422p10be > > > level=-99 > > > color_range=tv > > > color_space=bt2020nc > > > Test mxf-probe-applehdr10 failed. Look at > > > tests/data/fate/mxf-probe-applehdr10.err for details. > > > src/tests/Makefile:255: recipe for target 'fate-mxf-probe-applehdr10' > > > failed > > > make: *** [fate-mxf-probe-applehdr10] Error 1 > > > > It seems fair that the pixel type is in native endian. > > maybe but the endianness of the decoder output doesnt belong in the > comparission > > > > I'm not really familiar enough with FATE to provide a patch to fix this > > though. Do any other FATE tests have wildcards or two versions for big and > > little endian? > > i dont see another probe reference file that contains a le/be format > > we had le/be issues in other places though where they where fixed by forcing > a format with specific endianness in the test IIRC How about something like this? /Tomas From 2b98d97f21420f9db90f0bff3f5ae5d88fcac976 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Mon, 5 Oct 2020 10:17:13 +0200 Subject: [PATCH] fate-mxf-probe-applehdr10: Ignore endianness --- tests/fate/mxf.mak | 2 +- tests/ref/fate/mxf-probe-applehdr10 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/fate/mxf.mak b/tests/fate/mxf.mak index 3adef939dc..ca119fa677 100644 --- a/tests/fate/mxf.mak +++ b/tests/fate/mxf.mak @@ -35,7 +35,7 @@ fate-mxf-probe-dv25: CMD = run $(PROBE_FORMAT_STREAMS_COMMAND) -i "$(SRC)" FATE_MXF_PROBE-$(call ENCDEC2, PRORES, PCM_S24LE, MXF) += fate-mxf-probe-applehdr10 fate-mxf-probe-applehdr10: SRC = $(TARGET_SAMPLES)/mxf/Meridian-Apple_ProResProxy-HDR10.mxf -fate-mxf-probe-applehdr10: CMD = run $(PROBE_FORMAT_STREAMS_COMMAND) -i "$(SRC)" +fate-mxf-probe-applehdr10: CMD = run $(PROBE_FORMAT_STREAMS_COMMAND) -i "$(SRC)" | sed -e "s/yuv422p10../yuv422p10/" FATE_MXF_REEL_NAME-$(call ENCDEC2, MPEG2VIDEO, PCM_S16LE, MXF) += fate-mxf-reel_name fate-mxf-reel_name: $(SAMPLES)/mxf/Sony-1.mxf diff --git a/tests/ref/fate/mxf-probe-applehdr10 b/tests/ref/fate/mxf-probe-applehdr10 index 3430670c52..53a767c1cd 100644 --- a/tests/ref/fate/mxf-probe-applehdr10 +++ b/tests/ref/fate/mxf-probe-applehdr10 @@ -14,7 +14,7 @@ closed_captions=0 has_b_frames=0 sample_aspect_ratio=1:1 display_aspect_ratio=16:9 -pix_fmt=yuv422p10le +pix_fmt=yuv422p10 level=-99 color_range=tv color_space=bt2020nc -- 2.20.1 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH v2 3/3] avformat/mxfdec: Read Apple private Content Light Level from MXF
On Thu, Oct 01, 2020 at 03:29:19PM +0100, Harry Mallon wrote: > > > > > On 30 Sep 2020, at 08:32, Michael Niedermayer > > wrote: > > > > On Thu, Sep 17, 2020 at 10:49:31PM +0200, Tomas Härdin wrote: > >> mån 2020-09-14 klockan 12:23 +0200 skrev Tomas Härdin: > >>> ons 2020-09-09 klockan 15:56 +0100 skrev Harry Mallon: > * As embedded by Apple Compressor > > Signed-off-by: Harry Mallon > --- > libavformat/mxfdec.c| 27 + > tests/fate/mxf.mak | 4 + > tests/ref/fate/mxf-probe-applehdr10 | 169 > > >>> > >>> Sweet, I don't have to write the test myself .) > >>> > >>> Just ran FATE, the entire patch set works fine. We just need to get > >>> that sample into the sample suite then all three of them can be > >>> pushed. > >>> I'll see what I can do. > >> > >> FATE suite updated, FATE passes -> patchset pushed > > > > fails on big endian > > > > --- src/tests/ref/fate/mxf-probe-applehdr10 2020-09-28 23:21:12.291897976 > > +0200 > > +++ tests/data/fate/mxf-probe-applehdr102020-09-30 09:31:38.614653806 > > +0200 > > @@ -14,7 +14,7 @@ > > has_b_frames=0 > > sample_aspect_ratio=1:1 > > display_aspect_ratio=16:9 > > -pix_fmt=yuv422p10le > > +pix_fmt=yuv422p10be > > level=-99 > > color_range=tv > > color_space=bt2020nc > > Test mxf-probe-applehdr10 failed. Look at > > tests/data/fate/mxf-probe-applehdr10.err for details. > > src/tests/Makefile:255: recipe for target 'fate-mxf-probe-applehdr10' failed > > make: *** [fate-mxf-probe-applehdr10] Error 1 > > It seems fair that the pixel type is in native endian. maybe but the endianness of the decoder output doesnt belong in the comparission > I'm not really familiar enough with FATE to provide a patch to fix this > though. Do any other FATE tests have wildcards or two versions for big and > little endian? i dont see another probe reference file that contains a le/be format we had le/be issues in other places though where they where fixed by forcing a format with specific endianness in the test IIRC thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is dangerous to be right in matters on which the established authorities are wrong. -- Voltaire signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH v2 3/3] avformat/mxfdec: Read Apple private Content Light Level from MXF
> On 30 Sep 2020, at 08:32, Michael Niedermayer wrote: > > On Thu, Sep 17, 2020 at 10:49:31PM +0200, Tomas Härdin wrote: >> mån 2020-09-14 klockan 12:23 +0200 skrev Tomas Härdin: >>> ons 2020-09-09 klockan 15:56 +0100 skrev Harry Mallon: * As embedded by Apple Compressor Signed-off-by: Harry Mallon --- libavformat/mxfdec.c| 27 + tests/fate/mxf.mak | 4 + tests/ref/fate/mxf-probe-applehdr10 | 169 >>> >>> Sweet, I don't have to write the test myself .) >>> >>> Just ran FATE, the entire patch set works fine. We just need to get >>> that sample into the sample suite then all three of them can be >>> pushed. >>> I'll see what I can do. >> >> FATE suite updated, FATE passes -> patchset pushed > > fails on big endian > > --- src/tests/ref/fate/mxf-probe-applehdr10 2020-09-28 23:21:12.291897976 > +0200 > +++ tests/data/fate/mxf-probe-applehdr10 2020-09-30 09:31:38.614653806 > +0200 > @@ -14,7 +14,7 @@ > has_b_frames=0 > sample_aspect_ratio=1:1 > display_aspect_ratio=16:9 > -pix_fmt=yuv422p10le > +pix_fmt=yuv422p10be > level=-99 > color_range=tv > color_space=bt2020nc > Test mxf-probe-applehdr10 failed. Look at > tests/data/fate/mxf-probe-applehdr10.err for details. > src/tests/Makefile:255: recipe for target 'fate-mxf-probe-applehdr10' failed > make: *** [fate-mxf-probe-applehdr10] Error 1 It seems fair that the pixel type is in native endian. I'm not really familiar enough with FATE to provide a patch to fix this though. Do any other FATE tests have wildcards or two versions for big and little endian? > > [...] > Harry ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH v2 3/3] avformat/mxfdec: Read Apple private Content Light Level from MXF
On Thu, Sep 17, 2020 at 10:49:31PM +0200, Tomas Härdin wrote: > mån 2020-09-14 klockan 12:23 +0200 skrev Tomas Härdin: > > ons 2020-09-09 klockan 15:56 +0100 skrev Harry Mallon: > > > * As embedded by Apple Compressor > > > > > > Signed-off-by: Harry Mallon > > > --- > > > libavformat/mxfdec.c| 27 + > > > tests/fate/mxf.mak | 4 + > > > tests/ref/fate/mxf-probe-applehdr10 | 169 > > > > > > > Sweet, I don't have to write the test myself .) > > > > Just ran FATE, the entire patch set works fine. We just need to get > > that sample into the sample suite then all three of them can be > > pushed. > > I'll see what I can do. > > FATE suite updated, FATE passes -> patchset pushed fails on big endian --- src/tests/ref/fate/mxf-probe-applehdr10 2020-09-28 23:21:12.291897976 +0200 +++ tests/data/fate/mxf-probe-applehdr102020-09-30 09:31:38.614653806 +0200 @@ -14,7 +14,7 @@ has_b_frames=0 sample_aspect_ratio=1:1 display_aspect_ratio=16:9 -pix_fmt=yuv422p10le +pix_fmt=yuv422p10be level=-99 color_range=tv color_space=bt2020nc Test mxf-probe-applehdr10 failed. Look at tests/data/fate/mxf-probe-applehdr10.err for details. src/tests/Makefile:255: recipe for target 'fate-mxf-probe-applehdr10' failed make: *** [fate-mxf-probe-applehdr10] Error 1 [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I have never wished to cater to the crowd; for what I know they do not approve, and what they approve I do not know. -- Epicurus signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH v2 3/3] avformat/mxfdec: Read Apple private Content Light Level from MXF
mån 2020-09-14 klockan 12:23 +0200 skrev Tomas Härdin: > ons 2020-09-09 klockan 15:56 +0100 skrev Harry Mallon: > > * As embedded by Apple Compressor > > > > Signed-off-by: Harry Mallon > > --- > > libavformat/mxfdec.c| 27 + > > tests/fate/mxf.mak | 4 + > > tests/ref/fate/mxf-probe-applehdr10 | 169 > > > > Sweet, I don't have to write the test myself .) > > Just ran FATE, the entire patch set works fine. We just need to get > that sample into the sample suite then all three of them can be > pushed. > I'll see what I can do. FATE suite updated, FATE passes -> patchset pushed /Tomas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH v2 3/3] avformat/mxfdec: Read Apple private Content Light Level from MXF
ons 2020-09-09 klockan 15:56 +0100 skrev Harry Mallon: > * As embedded by Apple Compressor > > Signed-off-by: Harry Mallon > --- > libavformat/mxfdec.c| 27 + > tests/fate/mxf.mak | 4 + > tests/ref/fate/mxf-probe-applehdr10 | 169 Sweet, I don't have to write the test myself .) Just ran FATE, the entire patch set works fine. We just need to get that sample into the sample suite then all three of them can be pushed. I'll see what I can do. /Tomas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".