[Flightgear-devel] toow many bugs on flightgear sources
There is a lot of bugs in the structure of the project None of .cpp/.cxx files include all the files they needs, they includes files which includes other files that this .cpp/.cxx depends on. Then if you modify the first include and the consequence is the first include does nt include the other files needed by the .cpp/.cxx then this .cpp/.cxx doesnt compile and its become to be very expensive to detect which include is missing. In collaborative project its really a problem ! The hierarchy of directory is not good enought, The includes directives are bugged: the files includes with absolute reference path and not relative than we have to guess what include directories to set on the path search: A project doesnt have to set include path for all the subproject: you must use relative path on the source code. The interdepencies are chaotics In first attemp to compil i took 3 days to resolve dependencies. Today, after succesfully compile flightgear since a week, I have got the new jsbsim sources and tried to include it on the Flightgear: then i got a lot of dependencies errors (includes, namespace disapeared ect ...) Before to continue to develop the project, structure and hierarchies must be cleaned !! David Ingels -- ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
[Flightgear-devel] RE : toow many bugs on flightgear sources
Example taken from hasard: the file fg_props.hxx
the begining of the file is:
// fg_props.hxx - Declarations and inline methods for property handling.
// Written by David Megginson, started 2000.
//
// This file is in the Public Domain, and comes with no warranty.
#ifndef __FG_PROPS_HXX
#define __FG_PROPS_HXX 1
#include iosfwd
#include simgear/structure/subsystem_mgr.hxx
#include simgear/math/SGMath.hxx
#include Main/globals.hxx
== it didnt include the file /simgear/props.hxx which defines namespace
props and enum simgear::props:STRING
but later it uses namespace and the enum defined in it:
class FGMakeUpperCase : public SGPropertyChangeListener {
public:
void valueChanged(SGPropertyNode *node) {
if (node-getType() != simgear::props::STRING) == here
return;
char *s = const_castchar *(node-getStringValue());
for (; *s; s++)
*s = toupper(*s);
}
== if any of the 4 files included in top of source doesnt include
/simgear/props.hxx than this file doesnt compile: it s abnormal.
The
#include simgear/structure/subsystem_mgr.hxx
is absolute includes and depends on the search path added on the project
configuration
If the directory hierarchie is well defined, you can set for example a
relative path
#include ../../../../simgear/structure/subsystem_mgr.hxx
the reader of the source can find immediately where the file included is
and can read it quickly without searching.
I am not against include directory path in project configuration for
example to set up dependencys from external project
Like openscenegraph in flightgear, but, simgear is semi-external, like
jsbsim the sources are compiled in flightgear project
Than it can be considered internal and no include path have to be added
on project, or it can be considered external in the form of a simple lib
to link with and include path in the project are added.
there are other examples where the part simgear/ is missing because the
project configuration include the path:
../../../../simgear
other example : the project configuration include the paths :
../../../src
../../../src/include
= its abnormal use only one of the two solution and set #include
directive in accordance
other example:
in my first atempt to compile flightgear i have used
Openscenegraph2.9.7 because in the doc it is say that
openSceneGraph2.9.6 and above is needed
OpenSceneGraph2.9.7 doesnt link, an obscure probleme of zlib version
used in openscenegraph2.9.7. I have decided to delete 2.9.7 and using
OpenSceneGraph2.9.6
Than i can link with 2.9.6 version
There must be someone designed to decide wich version of external
software to use and responsible of the good integration and test of the
external modules.
Do not tell to use Version2.9.6 and above, tell use only version
2.9.6 flightgear validated with 2.9.6.
Okay there are tools to setup a new jsbsim in flightgear for example, i
didnt know that before my mail, but i find its not very normal to have
to using tools.
Ok, i am returning to learn how integrate the new jsbsim in FG.
Cordialy,
David Ingels
-Message d'origine-
De : Frederic Bouvier [mailto:fredfgf...@free.fr]
Envoyé : mercredi 5 mai 2010 17:34
À : FlightGear developers discussions
Objet : Re: [Flightgear-devel] toow many bugs on flightgear sources
Hi David,
your rant could have more weight if you included some examples. Please
be more specific to help us improve the current situation.
-Fred
- Ingels David david.ing...@laposte.net a écrit :
There is a lot of bugs in the structure of the project
--
Frédéric Bouvier
http://my.fotolia.com/frfoto/ Photo gallery - album photo
http://www.youtube.com/user/fgfred64 Videos
--
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel
[Flightgear-devel] RE : toow many bugs on flightgear sources
An other sample : In source JSBSim.cxx : #include JSBSim.hxx #include FDM/JSBSim/FGFDMExec.h #include FDM/JSBSim/FGJSBBase.h #include FDM/JSBSim/initialization/FGInitialCondition.h == absolutes paths, depends on projectconfiguration i have compiling problems because i have copied the new jsbsim version, without scratching the old one, in another position in directory, made another directory in project configuration and removed from compilation the old files. (than i have 2 directorys JSBSIM in my project FlightGear: the old one (configured to not compil) and the new one.) == i want to be capable to switch betwen the two versions if the file was with relativepath it wil search the correct includes and compile : #include JSBSim.hxx #include FGFDMExec.h // same directory as the source jsbsim.cxx #include FGJSBBase.h #include initialization/FGInitialCondition.h // relative to the source compiling (jsbsim.cxx) cordialy david ingels -Message d'origine- De : Frederic Bouvier [mailto:fredfgf...@free.fr] Envoyé : mercredi 5 mai 2010 17:34 À : FlightGear developers discussions Objet : Re: [Flightgear-devel] toow many bugs on flightgear sources Hi David, your rant could have more weight if you included some examples. Please be more specific to help us improve the current situation. -Fred - Ingels David david.ing...@laposte.net a écrit : There is a lot of bugs in the structure of the project -- Frédéric Bouvier http://my.fotolia.com/frfoto/ Photo gallery - album photo http://www.youtube.com/user/fgfred64 Videos -- ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
[Flightgear-devel] RE : can't launch flghtgear when openscenegraphiscompiled in release
Ok, thank you for the advice, David Ingels -Message d'origine- De : Alan Teeder [mailto:ajtee...@v-twin.org.uk] Envoyé : mardi 27 avril 2010 11:40 À : FlightGear developers discussions Objet : Re: [Flightgear-devel] can't launch flghtgear when openscenegraphiscompiled in release From: Frederic Bouvier mailto:fredfgf...@free.fr Sent: Tuesday, April 27, 2010 10:09 AM To: FlightGear developers mailto:flightgear-devel@lists.sourceforge.net discussions Subject: Re: [Flightgear-devel] can't launch flghtgear when openscenegraph iscompiled in release - Alan Teeder a écrit : From: Ingels David mailto:david.ing...@laposte.net Sent: Tuesday, April 27, 2010 12:18 AM To: flightgear-devel@lists.sourceforge.net Subject: [Flightgear-devel] can't launch flghtgear when openscenegraph iscompiled in release I can't launch flghtgear when openscenegraph is compiled in release there is a bug with the linking to zlib.dll I dont understand why Error is Ordinal 55 not found on zlib.dll it seems to be a linking problem with zlib.dll Its only when i compil openscenegraph on other version than debug (release ect...) Help ! David ingels I also had zlib.dll problems. These went away when I re-ordered my PATH environment to ensure that the version of zlib.dll that I wanted was nearer the top. Many programs install their own version of zlib. Depends.exe is the tool you need to find out which dll´´s fgfs (or any other progarm) will actually load at run-time. http://www.dependencywalker.com/ (it is free and recommended by Microsoft at http://technet.microsoft.com/en-us/library/cc738370%28WS.10%29.aspx) It only happens in release mode because the debug build link to zlibd.lib/dll and it is most likely that the only one in the system is the one located in the 3rdparty directory. zlib.dll and other Open Source libraries are often used even by commercial products and there should be one with a different version elsewhere, possibly in c:\windows\system32 -Fred OpenSceneGraph (source or SVN version) has its own set of third party files. In the OpenSceneGraph/3rdpart/bin directory there is both zlib1.dll and zlib1d.dll, and in the 3rdparty/lib directory are the equivalent .lib files. On my system I have used the OPenSceneGraph 3rdparty files as the basis for my FlightGear build. Also be aware that zlib.lib is probably not the one you need, for dll builds you should use zlib1. I have copied zlib.lib into my 3rd party directory as both zlib1.lib and zlib.lib for this reason. (see http://www.zlib.net/DLL_FAQ.txt). Alan -- ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
[Flightgear-devel] compiling ok, but time to load and to be in cockpit is very very long (about 30 minutes)
The loading process is very very long in debug mode, about 30 minutes to be in cockpit and test the game lXml reading after 'loading scenery objects' is the slowing process Bug report: After selecting reset the program crash in reinitialisation of metar , because the metar string is empty : And there is no test of character '\0' I have modified FGPiston and FGPropeller to modelize turbo and supercharger Is there somebody to validate my modification and how to do this ? Cordialy David Ingels -- ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
[Flightgear-devel] hello everybody
Hello,
I am new on flightgear developpement, ia am using MSVC 9.0, i am french,
so excuse me for my english please.
And i am enthusiast to contribute on this project, but it s very hard to
get Flightgear to compile
I got all the sources as described on wiki, but the flightgear solution
doesnt compile because of lack of some include folders and other
problems,
For example fgadmin does nt compile because it cannot find plib/sg.h
because in the configuration of the project it lacks ..\..\..\.. in
the list of include folder
Then i am trying to compil only FlightGear project and there i have this
error:
1i:\developpement\projects\flightgear\source\src\aimodel\aibase.cxx(229
) : error C2228: la partie gauche de '.c_str' doit avoir un
class/struct/union
and the line is :
void FGAIBase::initModel(osg::Node *node)
{
if (model.valid()) {
fgSetString(/ai/models/model-added, props-getPath().c_str());
- buggy line :props-getPath() return const char* and not a
std::string, the .c_str() is already done on GetPath() Method !
} else if (!model_path.empty()) {
SG_LOG(SG_INPUT, SG_WARN, AIBase: Could not load model
model_path);
}
props-setStringValue(submodels/path, _path.c_str());
setDie(false);
}
there is some other problems (simgear project doesnt have the path to
plib include for example)
i dont want to develop only for me but for the community then i dont
want to fix all if it is already fixed
is there a way of having a completely working solution ? before to start
modifying the code
and can you explain me how to validate modification done in code before
to submit it by cvs, i think you have to say it s ok before to make
modification on CVS sources no ?
i think you can compile flightgear :-) then can you help me please
thank you and good day
David Ingels
--
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel
[Flightgear-devel] sorry, it was because ia havent the latest simgear version
I got latest version of simgear from cvs and flightgear project compile then cordialy -- ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
