cvs commit: xml-fop/src/org/apache/fop/svg SVGElement.java
keiron 01/09/13 23:43:57
Modified:src/org/apache/fop/svg SVGElement.java
Log:
fixed potential npe
Revision ChangesPath
1.11 +3 -2 xml-fop/src/org/apache/fop/svg/SVGElement.java
Index: SVGElement.java
===
RCS file: /home/cvs/xml-fop/src/org/apache/fop/svg/SVGElement.java,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- SVGElement.java 2001/09/13 07:49:32 1.10
+++ SVGElement.java 2001/09/14 06:43:57 1.11
@@ -1,5 +1,5 @@
/*
- * $Id: SVGElement.java,v 1.10 2001/09/13 07:49:32 keiron Exp $
+ * $Id: SVGElement.java,v 1.11 2001/09/14 06:43:57 keiron Exp $
* Copyright (C) 2001 The Apache Software Foundation. All rights reserved.
* For details on use and redistribution please refer to the
* LICENSE file included with these sources.
@@ -163,7 +163,8 @@
String baseDir = Configuration.getStringValue(baseDir);
((SVGOMDocument)doc).setURLObject(new URL(baseDir));
} catch (Exception e) {
-log.error(Could not set base URL for svg, e);
+// cannot use log yet
+//log.error(Could not set base URL for svg, e);
}
buildTopLevel(doc, element);
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Antwort: Re: Unable to perform PDF creation
Thank you, this code works. greeting harry Elaxy AG Harry Grüneis Gutenbergstr. 5 D- 82178 Puchheim bei München Tel. +49 (89) 890 130 81 Fax +49 (89) 890 130 89 e-Mail: [EMAIL PROTECTED], Web: http://www.turck.de - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]
RE: Avalon?
+1 for keeping extra libraries to a minimum FOP is great as a client side print tool, but not if it bloats -Original Message- From: COFFMAN Steven [mailto:[EMAIL PROTECTED]] Sent: Thursday, September 13, 2001 10:09 PM To: '[EMAIL PROTECTED]' Subject: RE: Avalon? FOP needs at all levels the ability to log errors and messages. System.out is fine for CLI applications, but not for most embedded applications or servers. We could have used Log4J instead, but the rest of Apache XML is using LogKit and it suited our needs. Avalon is the place where common Design Patterns are implemented as a common component repository. With the combined might of all our projects, we can have confidence that every component is the best designed and best implemented possible, where no one project would have the resources to do so. You are correct that it is theoretically possible to make FOP faster and lighter without using any extra libraries like Avalon. If we made our own custom XML parser optimized for FO, that would also be true, but we still use Xalan and Xerces. We just don't have the resources or interest in pursuing it. -Steve -Original Message- From: Christopher Burkey [mailto:[EMAIL PROTECTED]] Sent: Thursday, September 13, 2001 4:34 PM To: [EMAIL PROTECTED] Subject: Avalon? Hi, In CVS we have org.apache.fop.apps.Driver implementing the org.apache.avalon.framework.logger.Loggable interface. Is there a good reason we are dragging Avalon into our core code base? Maybe someone should extend the Driver class with AvalonDriver so that us client side developers do not have to get involved with the extra server side libraries. Christopher Burkey [EMAIL PROTECTED] President 513-542-3401 eInnovation Inc.http://einnovation.com - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]
Re: running FOP on Tomcat3.2.3
it was a library problem set the library of fop first in your class path - Original Message - From: Liliana Selea [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Thursday, September 13, 2001 7:20 PM Subject: running FOP on Tomcat3.2.3 I tried to run FOP-0.20 on tomcat 3.2.3. I replaced the jaxp.jar from Tomcat/lib with the latest version. I placed the xerces-1.2.3.jar and xalan-2.0.0.jar at he beginning of the Tomcat CLASSPATH(because tomcat uses SAXParser 1 and FOP users SAXParser 2). When I run the servlet, the tomcat server shuts down. If I have the tomcat jars file first in the classpath and then the additional ones ( for FOP) I got an FopException: Namespace not supported by SAXParser Does anybody know what happened? Thanks in advance for help. Liliana Selea - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]
Total page number of a PDF document
Hi! Is it possible to indicate the total page number of the document, e.g. for an output of the type page 3 of 35 ? I did not find something to this question in the documentation or the examples. Thank you first Greetings Viktor Keimes ___ Dr. Viktor Keimes Gerling GKI AB-IM; Spiesergasse 20, D-50597 Köln Tel: +49 (0)221 144-62005 e-Mail: [EMAIL PROTECTED] ___ - This message is intended for the addressee or its representative only. Any form of unauthorized use, publication, reproduction, copying or disclosure of the content of this e-mail is not permitted. If you are not the intended recipient of this e-mail message and its contents, please notify the sender immediately and delete this message and all its attachments subsequently. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]
RE: Total page number of a PDF document
There is an example concerning this in the doco I think but... Put a block like this in the document fo:block border-color=white border-style=solid text-align=end Page fo:page-number/ of fo:page-number-citation ref-id=terminator/ /fo:block and then at the end of the document put a block with the id terminator, like so... fo:block id=terminator / /fo:flow /fo:page-sequence /fo:root Regards, - Paul Smith -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] Sent: 14 September 2001 08:59 To: [EMAIL PROTECTED] Subject: Total page number of a PDF document Hi! Is it possible to indicate the total page number of the document, e.g. for an output of the type page 3 of 35 ? I did not find something to this question in the documentation or the examples. Thank you first Greetings Viktor Keimes ___ Dr. Viktor Keimes Gerling GKI AB-IM; Spiesergasse 20, D-50597 Köln Tel: +49 (0)221 144-62005 e-Mail: [EMAIL PROTECTED] ___ - This message is intended for the addressee or its representative only. Any form of unauthorized use, publication, reproduction, copying or disclosure of the content of this e-mail is not permitted. If you are not the intended recipient of this e-mail message and its contents, please notify the sender immediately and delete this message and all its attachments subsequently. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]
Re: Total page number of a PDF document
Hi One solution is to create an empty block at the end of the document with an id and to use page-number citation toward this block. fo:block id=endofdoc / and fo:block font-size=9pt line-height=15pt text-align=end p. fo:page-number//fo:page-number-citation ref-id=endofdoc//fo:block Hope it helps. Jerome - Original Message - From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Friday, September 14, 2001 09:59 Subject: Total page number of a PDF document Hi! Is it possible to indicate the total page number of the document, e.g. for an output of the type page 3 of 35 ? I did not find something to this question in the documentation or the examples. Thank you first Greetings Viktor Keimes ___ Dr. Viktor Keimes Gerling GKI AB-IM; Spiesergasse 20, D-50597 Köln Tel: +49 (0)221 144-62005 e-Mail: [EMAIL PROTECTED] ___ - This message is intended for the addressee or its representative only. Any form of unauthorized use, publication, reproduction, copying or disclosure of the content of this e-mail is not permitted. If you are not the intended recipient of this e-mail message and its contents, please notify the sender immediately and delete this message and all its attachments subsequently. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]
Extracting image embeddede in XMLfile using XSL????????
hi, the question is some what out of group. any way please help me. I want to extract the image that i embedded in xml file using the img element using xsl stylesheet. that is, if my xml file is: ?xml version=1.0? ?xml-stylesheet type=text/xsl href=a.xsl root img src=a.gif/ /root How my a.xsl would be,so that i get image in browser. i don't want to write img src=a.gif/ in my xsl also. what is the right way to extract. any help will be greately appreciated. regards rajiv __ Terrorist Attacks on U.S. - How can you help? Donate cash, emergency relief information http://dailynews.yahoo.com/fc/US/Emergency_Information/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]
RE: Extracting image embeddede in XMLfile using XSL????????
Hi,
a possible solution is:
xsl:template match=img
fo:external-graphic src={@src}
xsl:apply-templates/
/fo:external-graphic
/xsl:template
this works for XSL-FO, for HTML will became:
xsl:template match=img
img src={@src}
xsl:apply-templates/
/img
/xsl:template
Fabio
PS: if you write xsl:template match=//img this will transform all the
img tags inside your document into anchors or fo:external-graphics
-Original Message-
From: rajeev nair [mailto:[EMAIL PROTECTED]]
Sent: 14 September 2001 10:11
To: [EMAIL PROTECTED]
Subject: Extracting image embeddede in XMLfile using XSL
hi,
the question is some what out of group.
any way please help me.
I want to extract the image that i embedded in xml
file using the img element using xsl stylesheet.
that is, if my xml file is:
?xml version=1.0?
?xml-stylesheet type=text/xsl href=a.xsl
root
img src=a.gif/
/root
How my a.xsl would be,so that i get image in browser.
i don't want to write
img src=a.gif/ in my xsl also.
what is the right way to extract.
any help will be greately appreciated.
regards
rajiv
__
Terrorist Attacks on U.S. - How can you help?
Donate cash, emergency relief information
http://dailynews.yahoo.com/fc/US/Emergency_Information/
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, email: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, email: [EMAIL PROTECTED]
FOP on IBM AS400
Title: FOP on IBM AS400 Hi We are attempting to port our application which uses fop 0.20.1 to the AS400. We seems to have some issues with FOP's use of AWT classes. Has anyone any experience of this environment ? Is it possible to configure FOP not to use AWT or is it fundemental ? We have bmp files as external-graphic's, and we are rendering to PDF,PS and PCL. Stephen Fry CODA Plc
RE: FOP on IBM AS400
Title: FOP on IBM AS400 Maybe irrelevant, but I had a problem when installing an app using FOP onto a linux box with no X on it, and traced the problem to the fact that the standard adobe fonts were not installed. I mended it be adding the rpm package urw-fonts-2.0-8, but it may also be possible to fool it by installing all the fonts you use as extra fonts - see the documentation. Alistair -Original Message-From: Stephen Fry [mailto:[EMAIL PROTECTED]]Sent: Friday, September 14, 2001 11:30 AMTo: 'FOP Dev'Subject: FOP on IBM AS400 Hi We are attempting to port our application which uses fop 0.20.1 to the AS400. We seems to have some issues with FOP's use of AWT classes. Has anyone any experience of this environment ? Is it possible to configure FOP not to use AWT or is it fundemental ? We have bmp files as external-graphic's, and we are rendering to PDF,PS and PCL. Stephen Fry CODA Plc
Re: tall image puts Fop in never-ending loop
Hi Darrel! Use the attributes width and height of the fo:external-graphic element to scale the image to an appropriate size. Bye -- Harald Hett [EMAIL PROTECTED] Gesellschaft für integrierte Systemplanung - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]
How to do pre in PDF...
Hi there! I have a question: I am developing a XSL, that transforms a XML to PDF using FOP. This shall include some code-samples included like one can do using pre in HTML. How can I then convert the newlines into fo:blocks?? Christian __ DIRON Wirtschaftsinformatik GmbH Co. KG Christian Beer ([EMAIL PROTECTED]) Daimlerweg 39-41Tel. : +49(251)979-200 48163 Muenster Fax : +49(251)979-2020 Germany Email: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]
Errors in link positioning
Hi, there are some bugs in FOP 0.20.1 in link positioning: 1) abolutely positioned blocks will completely mess up link positioning for that page 2) links do not take the padding-top attribute into account, while the renderers do. See attached fo and pdf for a demo of this bug. - Mikko Honkala - http://www.x-smiles.org/ demos2.fo demos2.pdf - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]
RE: tall image puts Fop in never-ending loop
The workaround is to tplit the image into two images that fit in a page by manually using Gimp or Photoshop and modifying your FO accordingly. Ideally FOP would do this automatically, but that requires reasonably sophisticated image processing code. Graceful failure or omission of impossibly large objects (with a warning) would be something that's more likely to get implemented at some point, and we would be grateful to accept any patches like that. -Steve -Original Message- From: Darrel Riekhof [mailto:[EMAIL PROTECTED]] Sent: Thursday, September 13, 2001 11:02 PM To: '[EMAIL PROTECTED]' Cc: Rodrigo Rey; Bill Thornton Subject: tall image puts Fop in never-ending loop I tried to insert a jpg that was 800 width by 1035 height. Here is the xsl-fo tag I'm using to do it: fo:block fo:external-graphic xsl:attribute name =src file:xsl:value-of select=location/ /xsl:attribute /fo:external-graphic /fo:block Fop-0.20.1 goes into a never-ending loop, trying to find a page big enough for this image, and I eventually get an out of memory exception. Is there a work-around for this? Darrel - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]
RE: Logs, logs and more logs
Hi Christopher,
Very good points, but I think this is a discussion that needs to
happen at a higher level. FOP needs to cooperate with Cocoon, and Cocoon is
committed to Avalon. If Avalon adopted Trunk, or did something similar, it
would fix FOP and Cocoon at the same time with little effort on FOP's part.
I forwarded your message to the Avalon developer's list at
[EMAIL PROTECTED] Does Trunk's licence allow Avalon devs to
mine it for ideas if they don't decide to adopt it unaltered? Moreover, are
the Trunk team okay with that? The Avalon team does a pretty good job of
giving credit, but sometimes people get upset if they don't totally adopt
their solution. You can subscribe to the Avalon list at
[EMAIL PROTECTED] if you want and I'm sure they'd like
your input, especially if you were willing to review their similar proposal.
(and I lost the link to that...) They're very willing to listen.
-Steve
-Original Message-
From: Christopher Burkey [mailto:[EMAIL PROTECTED]]
Sent: Thursday, September 13, 2001 10:40 PM
To: [EMAIL PROTECTED]
Subject: Logs, logs and more logs
At our company we have have found a solution to the logging dilemma and
think FOP should do the same.
At this point there seems to be several ways to log errors within a Java
application:
1. JDK 1.4's new Logging API's
2. Log4J
3. Log Kit
4. Avalon's Loggable interface
5. Some new JDK compatible API's
The worst part about this situation is that one component might use Log4J
and another part of the same application may depend on Log Kit. So now your
logs are spread all over the place within the same application.( Our
company is writing a Swing application that had this exact problem. )
The solution is:
Logging should be done in the same way JDBC is done. There should be one
set of interfaces and multiple drivers. Log Kit and Log4J considered the
equivalent of JDBC drivers such as Oracle, DB2 etc...
We put together Trunk ( http://www.openinstitute.org/trunk/ ) as a
collection of Interfaces compatible with multiple drivers.
From the Trunk Docs:
LoggingDriver.getDriver()
* liGet the value of the
ttorg.openinstitute.trunk.LoggingDriver/tt system property,
* which must be a class that implements the {@link
LoggingDriver}
interface.
Example Usage:
Logger LOGGER = LoggingDriverFactory.getDriver().getLogger(
SomeApplication.class );
LOGGER.info(Hello world!);
Now FOP can use any driver such as Log4J or Log Kit.
Christopher Burkey [EMAIL PROTECTED]
President 513-542-3401
eInnovation Inc.http://einnovation.com
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, email: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, email: [EMAIL PROTECTED]
How can i extract image from xml file using xsl stylesheet?
hi, this question is some what out of group.anyway please anyone kindly help me. I want to extract image from my xml file using xsl styling. my xml file is: ?xml version=1.0? ?xml-stylesheet type=text/xsl href=a.xsl? root img src=a.gif/ /root What would be my xsl file so that i can get the image extracted from the xml file.I don't want to write img src=a.gif/ again in my xsl also. thanx in advance. rajiv __ Terrorist Attacks on U.S. - How can you help? Donate cash, emergency relief information http://dailynews.yahoo.com/fc/US/Emergency_Information/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]
Printing PDF's with Double-Byte Characters...
Hi, I was able to generate PDF docs with double-byte chracters but now I have problems with printing those docs programmatically. Has anyone tried to do the same thing and made it work? I'd appreciate it if you could share your experience. Thanks. -Linus - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]
jpg compression
Was the ability to handle jpgs natively by FOP included in recent updates? About a month ago, Eric Dalquist, and others talked about a patch for this, but I haven't seen anything about it since. It would really help out, as FOP's current process of converting jpgs to bitmaps, and then zipping them, results in really large pdf size. Any news on this? jw - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]
help please Problem with generation PDF
Hi, I have witten a Servlet that take two file in input (file.xml and file.xsl) my code is: Driver driver = new Driver(); driver.setRenderer(Driver.RENDER_PDF); File xmlFile = new File(c:\\xml_to_pdf.xml); File xslFile = new File(c:\\TransformPDF.xsl); InputHandler inputHandler = new XSLTInputHandler(xmlFile,xslFile); XMLReader parser=createParser(); driver.setOutputStream(new FileOutputStream(outFile.pdf)); driver.render(parser, inputHandler.getInputSource()); and my servlet have a block inside Method render( ) The parser is instantiated correctly I think that there is a problem in the way that i pass the Files!! TOMCAT REPLY ME: building formatting object tree setting up fonts WARNING: Unknown formatting object ^val and then an error inside driven.render() my xml is very simple like this: ?xml version=1.0 encoding=UTF-8? val titleProva di PDF/title sourceSorgente/source date13-09-01/date paragraph number=1 lineQuesta e' una prova di creazione di PDF utilizzando i tag XSL-FO/line /paragraph /val WHY the transform don't know my root element! Please can somebody help me?? Tanks a lot D.Semprini - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]
Re: jpg compression
Dues to school starting I got put behind on this. I've spent a good part of today working on it and should have the files I changed done in a few hours. I don't have the tools to do a diff so I'm going to just post the files to the group and hope some helpfull soul does the diff for me. -Eric Dalquist - Original Message - From: Jim Wright [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Friday, September 14, 2001 4:06 PM Subject: jpg compression Was the ability to handle jpgs natively by FOP included in recent updates? About a month ago, Eric Dalquist, and others talked about a patch for this, but I haven't seen anything about it since. It would really help out, as FOP's current process of converting jpgs to bitmaps, and then zipping them, results in really large pdf size. Any news on this? jw - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]
RE: jpg compression
Thanks, Eric. Any helpful souls out there that can look at this? jw -Original Message- From: Eric Dalquist [mailto:[EMAIL PROTECTED]] Sent: Friday, September 14, 2001 4:08 PM To: [EMAIL PROTECTED] Subject: Re: jpg compression Dues to school starting I got put behind on this. I've spent a good part of today working on it and should have the files I changed done in a few hours. I don't have the tools to do a diff so I'm going to just post the files to the group and hope some helpfull soul does the diff for me. -Eric Dalquist - Original Message - From: Jim Wright [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Friday, September 14, 2001 4:06 PM Subject: jpg compression Was the ability to handle jpgs natively by FOP included in recent updates? About a month ago, Eric Dalquist, and others talked about a patch for this, but I haven't seen anything about it since. It would really help out, as FOP's current process of converting jpgs to bitmaps, and then zipping them, results in really large pdf size. Any news on this? jw - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]
RE: jpg compression
Yeah this would be great!! I'm also waiting for this feature :-) daniel --- Jim Wright [EMAIL PROTECTED] schrieb: Thanks, Eric. Any helpful souls out there that can look at this? jw -Original Message- From: Eric Dalquist [mailto:[EMAIL PROTECTED]] Sent: Friday, September 14, 2001 4:08 PM To: [EMAIL PROTECTED] Subject: Re: jpg compression Dues to school starting I got put behind on this. I've spent a good part of today working on it and should have the files I changed done in a few hours. I don't have the tools to do a diff so I'm going to just post the files to the group and hope some helpfull soul does the diff for me. -Eric Dalquist - Original Message - From: Jim Wright [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Friday, September 14, 2001 4:06 PM Subject: jpg compression Was the ability to handle jpgs natively by FOP included in recent updates? About a month ago, Eric Dalquist, and others talked about a patch for this, but I haven't seen anything about it since. It would really help out, as FOP's current process of converting jpgs to bitmaps, and then zipping them, results in really large pdf size. Any news on this? jw - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED] = Daniel Pfuhl mailto:[EMAIL PROTECTED] __ Do You Yahoo!? Gesendet von Yahoo! Mail - http://mail.yahoo.de - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]
[PATCH] JPG Compression
Attached is the diff for the patch. This is going against the latest release
build. When reading the diff G:\Fop-0.20.1\Fop-0.20.1-clean is the
untouched distribution G:\Fop-0.20.1\Fop-0.20.1-dev is the modified
distribution. It should work y just copying over the attached files and then
deleting src/org/apache/image/GifJpegImage.java since it will not be in use.
If I need to follow this up in any way I'll try my best to help. I hope one
of the commiters can look at this and deem it worthy to patch FOP.
-Eric B Dalquist
diff -r -H
G:\Fop-0.20.1\Fop-0.20.1-clean\src\org\apache\fop\image\AbstractFopImage.java
G:\Fop-0.20.1\Fop-0.20.1-dev\src\org\apache\fop\image\AbstractFopImage.java
23a24
* @author Modified by Eric Dalquist - 9/14/2001 - [EMAIL PROTECTED]
78a80,87
* Image compression type.
*
* Added by Eric Dalquist
*/
protected PDFFilter m_compressionType = null;
/**
253c262,272
return null;
---
/*
* Added by Eric Dalquist
*
* Using the bitsPerPixel var as our flag since many imges will
* have a null m_compressionType even after being loaded
*/
if (this.m_bitsPerPixel == 0)
this.loadImage();
return m_compressionType;
diff -r -H
G:\Fop-0.20.1\Fop-0.20.1-clean\src\org\apache\fop\image\FopImageFactory.java
G:\Fop-0.20.1\Fop-0.20.1-dev\src\org\apache\fop\image\FopImageFactory.java
27a28
* @author Modified by Eric Dalquist - 9/14/2001 - [EMAIL PROTECTED]
100a102,107
/*
* Modified by: Eric Dalquist
* Changed the Jpeg and Gif imageClassNames to the new image classes
*/
102c109
imgClassName = org.apache.fop.image.GifJpegImage;
---
imgClassName = org.apache.fop.image.GifImage;
105c112
imgClassName = org.apache.fop.image.GifJpegImage;
---
imgClassName = org.apache.fop.image.JpegImage;
Only in G:\Fop-0.20.1\Fop-0.20.1-dev\src\org\apache\fop\image: GifImage.java
Only in G:\Fop-0.20.1\Fop-0.20.1-clean\src\org\apache\fop\image: GifJpegImage.java
Only in G:\Fop-0.20.1\Fop-0.20.1-dev\src\org\apache\fop\image: JpegImage.java
Only in G:\Fop-0.20.1\Fop-0.20.1-dev\src\org\apache\fop\pdf: DCTFilter.java
diff -r -H G:\Fop-0.20.1\Fop-0.20.1-clean\src\org\apache\fop\pdf\PDFXObject.java
G:\Fop-0.20.1\Fop-0.20.1-dev\src\org\apache\fop\pdf\PDFXObject.java
68c68,77
// imgStream.addFilter(new FlateFilter());
---
/*
* Added by Eric Dalquist
*
* If the DCT filter hasn't been added to the object we add it
here
*/
if (fopimage.getPDFFilter() != null) {
imgStream.addFilter(fopimage.getPDFFilter());
}
77c86
p = p + /Length + imgStream.getDataLength();
---
p = p + /Length + imgStream.getDataLength() + \n;
JpegImage.java
AbstractFopImage.java
FopImageFactory.java
GifImage.java
PDFXObject.java
DCTFilter.java
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, email: [EMAIL PROTECTED]
RE: [PATCH] JPG Compression
I'm going to give this a try straight away! Thanks a lot. jw -Original Message- From: Eric Dalquist [mailto:[EMAIL PROTECTED]] Sent: Friday, September 14, 2001 5:59 PM To: [EMAIL PROTECTED] Subject: [PATCH] JPG Compression Attached is the diff for the patch. This is going against the latest release build. When reading the diff G:\Fop-0.20.1\Fop-0.20.1-clean is the untouched distribution G:\Fop-0.20.1\Fop-0.20.1-dev is the modified distribution. It should work y just copying over the attached files and then deleting src/org/apache/image/GifJpegImage.java since it will not be in use. If I need to follow this up in any way I'll try my best to help. I hope one of the commiters can look at this and deem it worthy to patch FOP. -Eric B Dalquist - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]
RE: Logs, logs and more logs
Hi Christopher, Very good points, but I think this is a discussion that needs to happen at a higher level. FOP needs to cooperate with Cocoon, and Cocoon is committed to Avalon. If Avalon adopted Trunk, or did something similar, it would fix FOP and Cocoon at the same time with little effort on FOP's part. That sounds like a good solution for all involved. I forwarded your message to the Avalon developer's list at [EMAIL PROTECTED] Does Trunk's licence allow Avalon devs to mine it for ideas if they don't decide to adopt it unaltered? Yes. We use a variant on Sun's Open Industry Standards Source License (see http://www.openinstitute.org/trunk/license.jsp), which is a fairly loose license. Its main restrictions are that those modifications that are made to Trunk itself must adhere to open standards, and/or those standards specified in the accompanying standards document. Moreover, are the Trunk team okay with that? The Avalon team does a pretty good job of giving credit, but sometimes people get upset if they don't totally adopt their solution. You can subscribe to the Avalon list at [EMAIL PROTECTED] if you want and I'm sure they'd like your input, especially if you were willing to review their similar proposal. (and I lost the link to that...) They're very willing to listen. As one of the developers on the Trunk team, I think I can safely say that we do not mind if ideas are mined from Trunk without Trunk being taken wholesale; however, we would appreciate it if the new ideas are fed back into Trunk so that Trunk can be improved. Our main concern is that the addition of Avalon adds a lot of bulk to FOP, unnecessarily. The only use for Avalon in FOP (at least, right now) is the Loggable interface. This definitely, in our minds, does not warrant the inclusion of the entire Avalon library into the mix. One advantage of componentized applications (and frameworks) is that they consist of many loosely coupled pieces, and thus can be split apart into multiple components. If Avalon were split up into multiple very small pieces, and only the pieces that are actually needed (i.e. currently just the logging piece) are shipped with FOP, then we would be happier. This would also help to strictly manage dependencies, not just between applications and Avalon, but within Avalon. We would be happy to start and spearhead an Avalon Trunk project, with the existing Trunk code base if so desired. The idea would then be that it does not depend on much of the rest of Avalon; but rather, the rest of Avalon depends on it. Thanks for reading all this, and we'd love to hear your thoughts! - Eric - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]
