DO NOT REPLY [Bug 38282] - [patch] from-table-column implementation

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38282





--- Additional Comments From [EMAIL PROTECTED]  2006-01-15 23:09 ---
Created an attachment (id=17426)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=17426&action=view)
initial patch


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 38282] - [patch] from-table-column implementation

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38282





--- Additional Comments From [EMAIL PROTECTED]  2006-01-15 23:09 ---
Created an attachment (id=17427)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=17427&action=view)
an example fo-file


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 38282] - [patch] from-table-column implementation

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38282


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Attachment #17426|0   |1
is obsolete||




--- Additional Comments From [EMAIL PROTECTED]  2006-01-29 21:49 ---
Created an attachment (id=17530)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=17530&action=view)
alternative patch

Gerhard,

I finally got around to taking a look at the column-numbers again. In the end,
I think the solution was 
pretty straightforward (see attached patch). 
I managed to make the function applicable to table-cells as well... I only
needed to make sure column-number and number-columns-spanned were treated the
same way as font-size (see alterations to PropertyList). Maybe in the longer
term, some rational ordering of the possibly specified properties needs to be
looked at in a more global sense. (Apart from the above three, are there any
other cases where the property parsing implies knowing the explicit values for
other properties, so we need to make sure they are available first?)

Roughly, I think my patch does more or less the same as yours. Differences are:

* that I preferred to expose the isColumnNumberUsed() method, instead of using
iterators over the columns List (a matter of taste? seemed to result in less
objects being created...)
* replaced the PropertyList reference in TableColumn with a StaticPropertyList
(efficiency+)
* did some cleanup: moved validation/overlapping colnrs to the PropertyMaker

Let me know if this agrees with you...

Cheers,

Andreas

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 38282] - [patch] from-table-column implementation

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38282


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Attachment #17530|0   |1
is obsolete||
 AssignedTo|fop-|[EMAIL PROTECTED]
   |[EMAIL PROTECTED]  |
 Status|NEW |ASSIGNED




--- Additional Comments From [EMAIL PROTECTED]  2006-01-30 19:38 ---
Created an attachment (id=17539)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=17539&action=view)
correction...

Slightly corrected and updated version of the proposed patch.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 38282] - [patch] from-table-column implementation

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38282


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||fop-
   ||[EMAIL PROTECTED]




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

DO NOT REPLY [Bug 38282] - [patch] from-table-column implementation

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38282





--- Additional Comments From [EMAIL PROTECTED]  2006-01-31 22:18 ---
Hi Manuel,

I think it doesn't apply in this particular case... The problem with font-size, 
IIRC, concerns retrieved 
markers (?) Should be no problem here. Column-number 3 will always remain 
column-number 3, 
regardless of whether the table is contained in a marker or not.

I don't know precisely --will have to look it up-- whether a marker that is in 
column-number 3 in a 
table descending from the flow, can be retrieved into a table in the 
static-content and thus end up in a 
different column...

Cheers,

Andreas

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

DO NOT REPLY [Bug 38282] - [patch] from-table-column implementation

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38282





--- Additional Comments From [EMAIL PROTECTED]  2006-01-31 22:37 ---
OK, just looked it up, and it seems like it *is* possible --although I wouldn't 
dream of it myself to do 
so, that's another issue.

Then again: this problem will always pose itself, and it is not so much a 
matter of 'early property 
evaluation'. All properties are evaluated early, and some need to come first 
because of possible 
dependencies of other specified properties (i.e. relative font-sizes or core 
function calls). In itself, this 
isn't wrong, but the solution may be to postpone the whole property evaluation 
cycle for a marker and 
*all* of its descendants until the marker is retrieved (since we cannot 
possibly know how inherited 
properties specified on the retrieve-marker or its containing block will affect 
the properties of the 
markers and its descendants... Maybe this is another case where we absolutely 
need to keep a reference 
to the original PropertyLists instead of binding the individual properties to 
instance variables (?)

I'll apply the patch as is, with a few added comments indicating that markers 
still need to be treated 
with caution.

Cheers,

Andreas

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

DO NOT REPLY [Bug 38282] - [patch] from-table-column implementation

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38282


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

DO NOT REPLY [Bug 38282] [patch] from-table-column implementation

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=38282

Glenn Adams  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

--- Comment #11 from Glenn Adams  2012-04-01 06:54:11 UTC ---
batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.