Re: [foreman-dev] request for write-access to forklift

2017-08-02 Thread Tom McKay 
+2 thanks for your contributions!

On Wed, Aug 2, 2017 at 9:34 AM, Christine Fouant  wrote:

> +1
>
> On Wed, Aug 2, 2017 at 9:26 AM, John Mitsch  wrote:
>
>> +1 You've made a lot of good contributions to forklift!
>>
>> John Mitsch
>> Red Hat Engineering
>> (860)-967-7285 <(860)%20967-7285>
>> irc: jomitsch
>>
>> On Wed, Aug 2, 2017 at 8:57 AM, Ewoud Kohl van Wijngaarden <
>> ew...@kohlvanwijngaarden.nl> wrote:
>>
>>> On Wed, Aug 02, 2017 at 02:45:52PM +0200, Evgeni Golov wrote:
>>>
 I would like to request write access to forklift.

>>>
>>> Big +1 Evgeni has shown great insight in details with his reviews and
>>> high quality PRs.
>>>
>>> I have 19 merged PRs [1] resulting in 19 commits [2].
 If I count it right, I also somehow reviewed 7 PRs [3].

 TIA
 Evgeni

 [1] https://github.com/theforeman/forklift/pulls?page=1&q=is%3Ap
 r+author%3Aevgeni&utf8=%E2%9C%93
 [2] https://github.com/theforeman/forklift/commits?author=evgeni
 [3] https://github.com/theforeman/forklift/pulls?utf8=%E2%9C%93&;
 q=involves%3Aevgeni%20is%3Apr%20

>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "foreman-dev" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to foreman-dev+unsubscr...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "foreman-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to foreman-dev+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
>
> --
>
> Christine Fouant
>
> Software Engineer
>
> Red Hat
>
> 
> 
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Aligning Foreman & Katello git repositories

2017-08-02 Thread Timo Goebel 
Sounds very good to me. Let's do this and find solutions for problems as we go.
If bandwidth is an issue, Cloudflare CDN might be worth checking out for the 
packages.

Timo

> On 2. Aug 2017, at 14:33, Ewoud Kohl van Wijngaarden 
>  wrote:
> 
> Hello all,
> 
> As many of you know we have some overlapping work between Foreman and 
> Katello. This is an effort to reduce some of this. This is only focussing on 
> git repositories but once this is in place this should be easier. It's all 
> proposals and we will need to work out details.
> 
> One might notice that much of this has been talked about before but never 
> reached a conclusion, which is something we tend to do a lot. Let's break the 
> cycle and make some decisions.
> 
> # foreman-bats -> forklift merge
> 
> Currently we have foreman-bats[1] and forklift[2] which both include a 
> vagrant config and bats tests. I'd propose we merge foreman-bats into 
> forklift and deprecate foreman-bats. Most of bats (if not all) should already 
> be there so I believe we just need to verify we can test Foreman using 
> Forklift. Since I added Debian we need to make Ubuntu work and verify Jenkins 
> can still test everything it used to.
> 
> This should be a relative easy task for which a lot of work has already been 
> done.
> 
> Tasks/Challenges I can think of:
> 
> * Add Ubuntu to Forklift
> * Get bats passing on all supported configs
> * Verify foreman-bats is no longer used on CI
> * Add a deprecation warning in foreman-bats' README
> 
> # katello-packaging -> foreman-packaging
> 
> At the moment Foreman packages are maintained in foreman-packaging[3] with an 
> RPM branch for every release (rpm/1.15, rpm/1.16, rpm/develop) and a the same 
> with deb/ for obvious reasons. On the Katello side there is 
> katello-packaging[4] with KATELLO-3.3, KATELLO-3.4 and master.
> 
> There was a discussion in #1541[5] about merging katello-packaging into 
> foreman-packaging, but it didn't reach a conclusion. The general opinions 
> were in favour but there might be space and traffic constraints when actually 
> building the packages.
> 
> My proposal is to revive this effort. Given the practical constraints are 
> related to the hosting it makes sense to me to start with just merging the 
> git repositories. Is it possible to do the builds from a single git 
> repository and end up on different servers for now?
> 
> If that's possible, we can look at finding proper hosting and which yum 
> repositories we should offer.
> 
> # katello modules -> theforeman namespace (including modulesync)
> 
> Right now we have a foreman-installer-modulesync[6] and 
> katello-installer-modulesync[7] to maintain the base layout of modules.  
> These are all very similar and with little effort we can maintain all modules 
> with the same layout.
> 
> The bigger impact is that we need to migrate all modules at least on the 
> github level to the theforeman github namespace. It also implies that when 
> you make changes to modulesync that needs to be applied to about double the 
> modules which can be more effort. The upside is that the overall quality will 
> be higher.
> 
> If this all works well we can look at moving the katello modules to the 
> foreman namespace on the Puppet forge as well but I think that benefit is 
> smaller and will take effort on the (direct) users since the forge doesn't 
> support redirects.
> 
> # katello-installer -> foreman-installer
> 
> Currently the katello-installer[8] builds on the foreman-installer[9] with 
> additional modules and scenarios. Sometimes the katello build breaks on 
> dependencies and then the cache gets out of sync with the foreman thus 
> breaking on older builds as well.
> 
> I'd like to merge this in a single installer with one set of modules and 
> multiple scenarios. The impact is that the installer will be bigger but the 
> katello-installer should be less fragile. It can also simplify packaging.
> 
> Care will need to be taken that the needed repositories are present but there 
> are multiple ways of fixing this. Currently we assume the user has installed 
> the katello release RPM which enables the needed yum repositories but that 
> will not be true anymore if we ship it within foreman-installer.
> 
> We'll also want to remove/disable the katello scenarios on Debian/Ubuntu.
> 
> You may notice I haven't thought this through too much and it may depend on a 
> unified Yum repository structure but there are big usability and reliability 
> wins we can gain.
> 
> [1]: https://github.com/theforeman/foreman-bats
> [2]: https://github.com/theforeman/forklift
> [3]: https://github.com/theforeman/foreman-packaging
> [4]: https://github.com/katello/katello-packaging
> [5]: https://github.com/theforeman/foreman-packaging/pull/1541
> [6]: https://github.com/theforeman/foreman-installer-modulesync
> [7]: https://github.com/katello/foreman-installer-modulesync
> [8]: https://github.com/katello/katello-installer
> [9]: https://github.com/thefore

Re: [foreman-dev] Request to join Katello Installer team in Katello Org

2017-08-02 Thread Christine Fouant 
+1

On Wed, Aug 2, 2017 at 9:31 AM, John Mitsch  wrote:

> +1 from me as well, Chris has been working in the installer for a while
> now.
>
> John Mitsch
> Red Hat Engineering
> (860)-967-7285 <(860)%20967-7285>
> irc: jomitsch
>
> On Tue, Aug 1, 2017 at 3:04 PM, Eric D Helms  wrote:
>
>> +1 from me, Chris has been very involved and adding value to both puppet
>> and installer itself.
>>
>> On Tue, Jul 25, 2017 at 6:54 PM,  wrote:
>>
>>> Hi,
>>>
>>> Since my last request almost a year ago I have been making quite a lot
>>> of commits and they have gone from being pretty awful to alot better and
>>> through that I have been understanding Puppet and Ruby alot better thanks
>>> to people like Stephen Benjamin, Ekohl, and Justin.
>>>
>>> My commits started out as some basic Ruby but went on to more advanced
>>> Ruby and bigger Puppet commits.
>>>
>>> I have also been doing reviews of Puppet PRS mostly from Ekohl.
>>>
>>> Here are some of my PR's both in the Ruby and Puppet:
>>>
>>> https://github.com/Katello/katello-installer/pull/518
>>>
>>> https://github.com/Katello/puppet-katello/pull/175
>>>
>>> https://github.com/Katello/puppet-qpid/pull/51
>>>
>>> https://github.com/Katello/puppet-katello/pull/168/files
>>>
>>> https://github.com/Katello/puppet-qpid/pull/65
>>>
>>> https://github.com/Katello/puppet-qpid/pull/62
>>>
>>> https://github.com/Katello/puppet-pulp/pull/189
>>>
>>> https://github.com/Katello/puppet-katello/pull/162
>>>
>>> https://github.com/Katello/katello-installer/pull/472
>>>
>>> Here are some of the ones I have reviewed around puppet/Ruby recently:
>>>
>>> https://github.com/Katello/puppet-qpid/pull/60
>>>
>>> https://github.com/Katello/puppet-katello/pull/190
>>>
>>> https://github.com/Katello/puppet-katello/pull/198
>>>
>>> Thanks,
>>>
>>> Chris Roberts
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "foreman-dev" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to foreman-dev+unsubscr...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>>
>>
>> --
>> Eric D. Helms
>> Red Hat Engineering
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "foreman-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to foreman-dev+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 

Christine Fouant

Software Engineer

Red Hat




-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] request for write-access to forklift

2017-08-02 Thread Christine Fouant 
+1

On Wed, Aug 2, 2017 at 9:26 AM, John Mitsch  wrote:

> +1 You've made a lot of good contributions to forklift!
>
> John Mitsch
> Red Hat Engineering
> (860)-967-7285 <(860)%20967-7285>
> irc: jomitsch
>
> On Wed, Aug 2, 2017 at 8:57 AM, Ewoud Kohl van Wijngaarden <
> ew...@kohlvanwijngaarden.nl> wrote:
>
>> On Wed, Aug 02, 2017 at 02:45:52PM +0200, Evgeni Golov wrote:
>>
>>> I would like to request write access to forklift.
>>>
>>
>> Big +1 Evgeni has shown great insight in details with his reviews and
>> high quality PRs.
>>
>> I have 19 merged PRs [1] resulting in 19 commits [2].
>>> If I count it right, I also somehow reviewed 7 PRs [3].
>>>
>>> TIA
>>> Evgeni
>>>
>>> [1] https://github.com/theforeman/forklift/pulls?page=1&q=is%3Ap
>>> r+author%3Aevgeni&utf8=%E2%9C%93
>>> [2] https://github.com/theforeman/forklift/commits?author=evgeni
>>> [3] https://github.com/theforeman/forklift/pulls?utf8=%E2%9C%93&;
>>> q=involves%3Aevgeni%20is%3Apr%20
>>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "foreman-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to foreman-dev+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 

Christine Fouant

Software Engineer

Red Hat




-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Request to join Katello Installer team in Katello Org

2017-08-02 Thread John Mitsch 
+1 from me as well, Chris has been working in the installer for a while now.

John Mitsch
Red Hat Engineering
(860)-967-7285
irc: jomitsch

On Tue, Aug 1, 2017 at 3:04 PM, Eric D Helms  wrote:

> +1 from me, Chris has been very involved and adding value to both puppet
> and installer itself.
>
> On Tue, Jul 25, 2017 at 6:54 PM,  wrote:
>
>> Hi,
>>
>> Since my last request almost a year ago I have been making quite a lot of
>> commits and they have gone from being pretty awful to alot better and
>> through that I have been understanding Puppet and Ruby alot better thanks
>> to people like Stephen Benjamin, Ekohl, and Justin.
>>
>> My commits started out as some basic Ruby but went on to more advanced
>> Ruby and bigger Puppet commits.
>>
>> I have also been doing reviews of Puppet PRS mostly from Ekohl.
>>
>> Here are some of my PR's both in the Ruby and Puppet:
>>
>> https://github.com/Katello/katello-installer/pull/518
>>
>> https://github.com/Katello/puppet-katello/pull/175
>>
>> https://github.com/Katello/puppet-qpid/pull/51
>>
>> https://github.com/Katello/puppet-katello/pull/168/files
>>
>> https://github.com/Katello/puppet-qpid/pull/65
>>
>> https://github.com/Katello/puppet-qpid/pull/62
>>
>> https://github.com/Katello/puppet-pulp/pull/189
>>
>> https://github.com/Katello/puppet-katello/pull/162
>>
>> https://github.com/Katello/katello-installer/pull/472
>>
>> Here are some of the ones I have reviewed around puppet/Ruby recently:
>>
>> https://github.com/Katello/puppet-qpid/pull/60
>>
>> https://github.com/Katello/puppet-katello/pull/190
>>
>> https://github.com/Katello/puppet-katello/pull/198
>>
>> Thanks,
>>
>> Chris Roberts
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "foreman-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to foreman-dev+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
>
> --
> Eric D. Helms
> Red Hat Engineering
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] request for write-access to forklift

2017-08-02 Thread John Mitsch 
+1 You've made a lot of good contributions to forklift!

John Mitsch
Red Hat Engineering
(860)-967-7285
irc: jomitsch

On Wed, Aug 2, 2017 at 8:57 AM, Ewoud Kohl van Wijngaarden <
ew...@kohlvanwijngaarden.nl> wrote:

> On Wed, Aug 02, 2017 at 02:45:52PM +0200, Evgeni Golov wrote:
>
>> I would like to request write access to forklift.
>>
>
> Big +1 Evgeni has shown great insight in details with his reviews and high
> quality PRs.
>
> I have 19 merged PRs [1] resulting in 19 commits [2].
>> If I count it right, I also somehow reviewed 7 PRs [3].
>>
>> TIA
>> Evgeni
>>
>> [1] https://github.com/theforeman/forklift/pulls?page=1&q=is%3Ap
>> r+author%3Aevgeni&utf8=%E2%9C%93
>> [2] https://github.com/theforeman/forklift/commits?author=evgeni
>> [3] https://github.com/theforeman/forklift/pulls?utf8=%E2%9C%93&;
>> q=involves%3Aevgeni%20is%3Apr%20
>>
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] request for write-access to forklift

2017-08-02 Thread Eric D Helms 
+! from me

On Wed, Aug 2, 2017 at 8:57 AM, Ewoud Kohl van Wijngaarden <
ew...@kohlvanwijngaarden.nl> wrote:

> On Wed, Aug 02, 2017 at 02:45:52PM +0200, Evgeni Golov wrote:
>
>> I would like to request write access to forklift.
>>
>
> Big +1 Evgeni has shown great insight in details with his reviews and high
> quality PRs.
>
> I have 19 merged PRs [1] resulting in 19 commits [2].
>> If I count it right, I also somehow reviewed 7 PRs [3].
>>
>> TIA
>> Evgeni
>>
>> [1] https://github.com/theforeman/forklift/pulls?page=1&q=is%3Ap
>> r+author%3Aevgeni&utf8=%E2%9C%93
>> [2] https://github.com/theforeman/forklift/commits?author=evgeni
>> [3] https://github.com/theforeman/forklift/pulls?utf8=%E2%9C%93&;
>> q=involves%3Aevgeni%20is%3Apr%20
>>
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Eric D. Helms
Red Hat Engineering

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] request for write-access to forklift

2017-08-02 Thread Ewoud Kohl van Wijngaarden 

On Wed, Aug 02, 2017 at 02:45:52PM +0200, Evgeni Golov wrote:

I would like to request write access to forklift.


Big +1 Evgeni has shown great insight in details with his reviews and 
high quality PRs.



I have 19 merged PRs [1] resulting in 19 commits [2].
If I count it right, I also somehow reviewed 7 PRs [3].

TIA
Evgeni

[1] 
https://github.com/theforeman/forklift/pulls?page=1&q=is%3Apr+author%3Aevgeni&utf8=%E2%9C%93
[2] https://github.com/theforeman/forklift/commits?author=evgeni
[3] 
https://github.com/theforeman/forklift/pulls?utf8=%E2%9C%93&q=involves%3Aevgeni%20is%3Apr%20


--
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[foreman-dev] request for write-access to forklift

2017-08-02 Thread Evgeni Golov 
Ohai,

I would like to request write access to forklift.

I have 19 merged PRs [1] resulting in 19 commits [2].
If I count it right, I also somehow reviewed 7 PRs [3].

TIA
Evgeni

[1] 
https://github.com/theforeman/forklift/pulls?page=1&q=is%3Apr+author%3Aevgeni&utf8=%E2%9C%93
[2] https://github.com/theforeman/forklift/commits?author=evgeni
[3] 
https://github.com/theforeman/forklift/pulls?utf8=%E2%9C%93&q=involves%3Aevgeni%20is%3Apr%20

-- 
Beste Grüße/Kind regards,

Evgeni Golov
Software Engineer

Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Michael Cunningham, Michael
O'Neill, Eric Shander

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[foreman-dev] Aligning Foreman & Katello git repositories

2017-08-02 Thread Ewoud Kohl van Wijngaarden 

Hello all,

As many of you know we have some overlapping work between Foreman and 
Katello. This is an effort to reduce some of this. This is only 
focussing on git repositories but once this is in place this should be 
easier. It's all proposals and we will need to work out details.


One might notice that much of this has been talked about before but 
never reached a conclusion, which is something we tend to do a lot. 
Let's break the cycle and make some decisions.


# foreman-bats -> forklift merge

Currently we have foreman-bats[1] and forklift[2] which both include 
a vagrant config and bats tests. I'd propose we merge foreman-bats into 
forklift and deprecate foreman-bats. Most of bats (if not all) should 
already be there so I believe we just need to verify we can test Foreman 
using Forklift. Since I added Debian we need to make Ubuntu work and 
verify Jenkins can still test everything it used to.


This should be a relative easy task for which a lot of work has already 
been done.


Tasks/Challenges I can think of:

* Add Ubuntu to Forklift
* Get bats passing on all supported configs
* Verify foreman-bats is no longer used on CI
* Add a deprecation warning in foreman-bats' README

# katello-packaging -> foreman-packaging

At the moment Foreman packages are maintained in foreman-packaging[3] 
with an RPM branch for every release (rpm/1.15, rpm/1.16, rpm/develop) 
and a the same with deb/ for obvious reasons. On the Katello side there 
is katello-packaging[4] with KATELLO-3.3, KATELLO-3.4 and master.


There was a discussion in #1541[5] about merging katello-packaging into 
foreman-packaging, but it didn't reach a conclusion. The general 
opinions were in favour but there might be space and traffic constraints 
when actually building the packages.


My proposal is to revive this effort. Given the practical constraints 
are related to the hosting it makes sense to me to start with just 
merging the git repositories. Is it possible to do the builds from a 
single git repository and end up on different servers for now?


If that's possible, we can look at finding proper hosting and which yum 
repositories we should offer.


# katello modules -> theforeman namespace (including modulesync)

Right now we have a foreman-installer-modulesync[6] and 
katello-installer-modulesync[7] to maintain the base layout of modules.  
These are all very similar and with little effort we can maintain all 
modules with the same layout.


The bigger impact is that we need to migrate all modules at least on the 
github level to the theforeman github namespace. It also implies that 
when you make changes to modulesync that needs to be applied to about 
double the modules which can be more effort. The upside is that the 
overall quality will be higher.


If this all works well we can look at moving the katello modules to the 
foreman namespace on the Puppet forge as well but I think that benefit 
is smaller and will take effort on the (direct) users since the forge 
doesn't support redirects.


# katello-installer -> foreman-installer

Currently the katello-installer[8] builds on the foreman-installer[9] 
with additional modules and scenarios. Sometimes the katello build 
breaks on dependencies and then the cache gets out of sync with the 
foreman thus breaking on older builds as well.


I'd like to merge this in a single installer with one set of modules and 
multiple scenarios. The impact is that the installer will be bigger but 
the katello-installer should be less fragile. It can also simplify 
packaging.


Care will need to be taken that the needed repositories are present but 
there are multiple ways of fixing this. Currently we assume the user has 
installed the katello release RPM which enables the needed yum 
repositories but that will not be true anymore if we ship it within 
foreman-installer.


We'll also want to remove/disable the katello scenarios on 
Debian/Ubuntu.


You may notice I haven't thought this through too much and it may depend 
on a unified Yum repository structure but there are big usability and 
reliability wins we can gain.


[1]: https://github.com/theforeman/foreman-bats
[2]: https://github.com/theforeman/forklift
[3]: https://github.com/theforeman/foreman-packaging
[4]: https://github.com/katello/katello-packaging
[5]: https://github.com/theforeman/foreman-packaging/pull/1541
[6]: https://github.com/theforeman/foreman-installer-modulesync
[7]: https://github.com/katello/foreman-installer-modulesync
[8]: https://github.com/katello/katello-installer
[9]: https://github.com/theforeman/foreman-installer

--
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] CREATE host or hostgroup with new fields

2017-08-02 Thread Fairouz el ouazi 
Hi Greg , 
   I did sent you a message i don't know if you get it ? 

Le mercredi 2 août 2017 11:15:39 UTC+2, Greg Sutcliffe a écrit :
>
> It's also worth noting that trying to assist with code problems is 
> almost impossible when we can't see the code. Do you have you plugin 
> available on the public internet somewhere (e.g. GitHub) for us to look 
> at? 
>
> Greg 
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] CREATE host or hostgroup with new fields

2017-08-02 Thread Greg Sutcliffe 
It's also worth noting that trying to assist with code problems is
almost impossible when we can't see the code. Do you have you plugin
available on the public internet somewhere (e.g. GitHub) for us to look
at?

Greg

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] CREATE host or hostgroup with new fields

2017-08-02 Thread Fairouz el ouazi 
Hi, 
  First thank you for  the response , For my situation i m trying to 
develop a plugin for foreman .. and i need to create a list of hosts 
automatically From my platform to Foreman ..The bridge is my plugin so 
instead of using a rest Api of foreman  and creating  host by host with 
making the parameters manually  .. i want to call just a method from 
foreman that create a host and then look to automatize the operation .
   I did in my plugin controller .
   Host.create :name=> test , :manage=> false , :build=> false 
  Hostgroup.create :name=> testgroup 
  So i want to know how can add parameters to the host and hostgroup 
creation 
   
   I tried to do 
   Host.create :name=> test , :manage=> false , :build=> false , 
operatingsystem_id => 1 
  but it doesn't work ??
  
Thanks again for your help 
   

Le mercredi 2 août 2017 08:09:39 UTC+2, oprazak a écrit :
>
> Hi,
> I am not sure what you are trying to do and where you call your method, 
> but it may be a strong parameter issue. We create host(group) by passing it 
> parameters and calling 'save' on it [1]. 
> Notice the 'hostgroup_params' method. It comes from a concern [2] that 
> takes care of whitelisting the params that we want to update. So if you add 
> new fields, you need to make sure they do not get filtered out.
>
> Hope this helps,
> Ondrej Prazak
>  
> [1] 
> https://github.com/theforeman/foreman/blob/develop/app/controllers/hostgroups_controller.rb#L42-L43
> [2] 
> https://github.com/theforeman/foreman/blob/develop/app/controllers/concerns/foreman/controller/parameters/hostgroup.rb
>
> On Tue, Aug 1, 2017 at 10:06 AM, Fairouz el ouazi  > wrote:
>
>> Hi everyone !!
>>
>>  My questions will sound a  bit stupide but i don't know how to call the 
>> method create Host or hostgroup with new fields from my new plugin  ? all i 
>> know is with name and when i add fields value like operating_system id it 
>> doesn't' appears on  foreman UI ? 
>>   
>> Thanks in advance for you help 
>>
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "foreman-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to foreman-dev...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.