[fpc-devel] Closing bug reports or not ?
Hi, excuse me for this question ;-) Closing bug report is task for reporter of bug or is not (so leave it resolved and bug will close somebody later?) ? Thanks Laco. ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] Closing bug reports or not ?
On 09 May 2011, at 09:20, LacaK wrote: Closing bug report is task for reporter of bug or is not (so leave it resolved and bug will close somebody later?) ? It's best if the bug reporter closes it once he's verified that the bug has been fixed. Many people don't do that (maybe we should start asking reporters to do that, like the Lazarus team), so in that case we have to do it. Jonas ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] Issue #0018894 and cross compile fpc 2.4.3
Στις 7/5/2011 8:49 μμ, ο/η Marco van de Voort έγραψε: In our previous episode, dioanni...@artesoft.gr said: is it possible to apply the fix of issue http://bugs.freepascal.org/view.php?id=18894 also to branch fixes_2.4 ? The next 2.4 release is already packed, and probably the branch will be abandonned after that, in favour of a new fixes_2_6 branch based on trunk. Fair enough. Which tag should i use, release_2_4_4 or release_2_4_4_rc1 ? regards, -- Dimitrios Chr. Ioannidis ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] Issue #0018894 and cross compile fpc 2.4.3
In our previous episode, Dimitrios Chr. Ioannidis said: In our previous episode, dioanni...@artesoft.gr said: is it possible to apply the fix of issue http://bugs.freepascal.org/view.php?id=18894 also to branch fixes_2.4 ? The next 2.4 release is already packed, and probably the branch will be abandonned after that, in favour of a new fixes_2_6 branch based on trunk. Fair enough. Which tag should i use, release_2_4_4 or release_2_4_4_rc1 ? release_2_4_4, but there are barely differences with rc1. Most differences are only packaging related ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
[fpc-devel] Re: Can't compile at revision: 17417
On Sun, May 8, 2011 at 5:19 PM, Marcos Douglas m...@delfire.net wrote: I resolved. Path in attachment (copy from /trunk). Hello, somebody can confirm this, please? Thanks. Marcos Douglas ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] Closing bug reports or not ?
Jonas Maebe wrote: On 09 May 2011, at 09:20, LacaK wrote: Closing bug report is task for reporter of bug or is not (so leave it resolved and bug will close somebody later?) ? It's best if the bug reporter closes it once he's verified that the bug has been fixed. Many people don't do that (maybe we should start asking reporters to do that, like the Lazarus team), so in that case we have to do it. Is there a polite way for a reporter who's submitted a fix to ping management when the bug's not been assigned to anybody? -- Mark Morgan Lloyd markMLl .AT. telemetry.co .DOT. uk [Opinions above are the author's, not those of his employers or colleagues] ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] Closing bug reports or not ?
On 09 May 2011, at 12:54, Mark Morgan Lloyd wrote: Is there a polite way for a reporter who's submitted a fix to ping management when the bug's not been assigned to anybody? You can always ask about it here, or add a ping comment to the bug (the latter will put it back at the top of the list of unassigned bugs). Jonas ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
[fpc-devel] Macro Patch
Some days ago I stated that the build-in macros %LINE% and %FILE%, used inside a macro, expand to the wrong (in my opinion) info from the defining context and not to those from the expanding context. That makes them nearly useless, because using them inside a macro for debugging purposes is their main benefit. I wrote two small changes for scanner.pas and fmodule.pas which solve the problem. Maybe the devils are interested in applying it, or something similar. The 'unknown' from my changes are in real Internal-Errors, which should never occur. But changing this let's trying him to find an Environment- Variable with the same name, which gives a Warning. So ... Best regards Jörg Index: compiler/fmodule.pas === --- compiler/fmodule.pas (Revision 17417) +++ compiler/fmodule.pas (Arbeitskopie) @@ -235,6 +235,7 @@ function get_source_file(moduleindex,fileindex : longint) : tinputfile; procedure addloadedunit(hp:tmodule); function find_module_from_symtable(st:tsymtable):tmodule; +function ascend_from_macros(f:tinputfile) : tinputfile; implementation @@ -336,6 +337,13 @@ end; +function ascend_from_macros(f:tinputfile) : tinputfile; + begin +while assigned(f) and f.is_macro do f:=f.next; +ascend_from_macros:=f; + end; + + procedure addloadedunit(hp:tmodule); begin hp.moduleid:=loaded_units.count; Index: compiler/scanner.pas === --- compiler/scanner.pas (Revision 17417) +++ compiler/scanner.pas (Arbeitskopie) @@ -1712,11 +1712,24 @@ hs:=getdatestr else if hs='FILE' then - hs:=current_module.sourcefiles.get_file_name(current_filepos.fileindex) + begin + hp:=ascend_from_macros(current_module.sourcefiles.get_file(current_filepos.fileindex)); + if assigned(hp) then hs:=hp.name^ else hs:='unknown' + end else if hs='LINE' then - hs:=tostr(current_filepos.line) + begin + hp:=ascend_from_macros(current_module.sourcefiles.get_file(current_filepos.fileindex)); + if assigned(hp) then hs:=tostr(hp.saveline_no) else hs:='unknown' + end else +if hs='PATH' then + begin + hp:=ascend_from_macros(current_module.sourcefiles.get_file(current_filepos.fileindex)); + if assigned(hp) then hs:=hp.path^ else hs:='unknown'; + if hs='' then hs:=CurDirRelPath(target_info) + end + else if hs='FPCVERSION' then hs:=version_string else ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] Re: Can't compile at revision: 17417
On Mon, 2011-05-09 at 07:47 -0300, Marcos Douglas wrote: On Sun, May 8, 2011 at 5:19 PM, Marcos Douglas m...@delfire.net wrote: I resolved. Path in attachment (copy from /trunk). Hello, somebody can confirm this, please? A quick look on your patch is that you want to include the 32-bit odbc driver in a 64 bit environment? Probably you are cross-compiling while you don't have the proper .dll's (32 and 64 bit) in your search-path. Joost. ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] Re: Can't compile at revision: 17417
On Mon, May 9, 2011 at 10:04 AM, Joost van der Sluis jo...@cnoc.nl wrote: On Mon, 2011-05-09 at 07:47 -0300, Marcos Douglas wrote: On Sun, May 8, 2011 at 5:19 PM, Marcos Douglas m...@delfire.net wrote: I resolved. Path in attachment (copy from /trunk). Hello, somebody can confirm this, please? A quick look on your patch is that you want to include the 32-bit odbc driver in a 64 bit environment? Probably you are cross-compiling while you don't have the proper .dll's (32 and 64 bit) in your search-path. No. This path was copied from odbcsql.pas in /trunk. I use Win32 only. Marcos Douglas ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] Re: Can't compile at revision: 17417
On Mon, 2011-05-09 at 10:14 -0300, Marcos Douglas wrote: On Mon, May 9, 2011 at 10:04 AM, Joost van der Sluis jo...@cnoc.nl wrote: On Mon, 2011-05-09 at 07:47 -0300, Marcos Douglas wrote: On Sun, May 8, 2011 at 5:19 PM, Marcos Douglas m...@delfire.net wrote: I resolved. Path in attachment (copy from /trunk). Hello, somebody can confirm this, please? A quick look on your patch is that you want to include the 32-bit odbc driver in a 64 bit environment? Probably you are cross-compiling while you don't have the proper .dll's (32 and 64 bit) in your search-path. No. This path was copied from odbcsql.pas in /trunk. I use Win32 only. If you don't use trunk, what are you trying to compile? Joost. ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] Re: Can't compile at revision: 17417
On Mon, May 9, 2011 at 10:29 AM, Joost van der Sluis jo...@cnoc.nl wrote: On Mon, 2011-05-09 at 10:14 -0300, Marcos Douglas wrote: On Mon, May 9, 2011 at 10:04 AM, Joost van der Sluis jo...@cnoc.nl wrote: On Mon, 2011-05-09 at 07:47 -0300, Marcos Douglas wrote: On Sun, May 8, 2011 at 5:19 PM, Marcos Douglas m...@delfire.net wrote: I resolved. Path in attachment (copy from /trunk). Hello, somebody can confirm this, please? A quick look on your patch is that you want to include the 32-bit odbc driver in a 64 bit environment? Probably you are cross-compiling while you don't have the proper .dll's (32 and 64 bit) in your search-path. No. This path was copied from odbcsql.pas in /trunk. I use Win32 only. If you don't use trunk, what are you trying to compile? Sorry my English... I use /fixes_2_4 but I could not to compile (error in first mail). So, I took a look in sources from /trunk. I compared this files (odbcsql) and saw this difference between them (the patch). Marcos Douglas ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
[fpc-devel] Macro Patch
A little further changing is needed to let it work as suspected. Even
if the macro is included via include file. In my first writing I didn't
recognize that the calling of insertmacro for _ID token is done with
mac.fileinfo.line and .fileindex, which is the point of definition.
Changed to current_scanner.line_no and
current_scanner.inputfile.ref_index.
Is this a problem for error recognition?, I think not, because the info
from the defining context is saved in the tmacro class.
Best regards
Jörg
Index: compiler/fmodule.pas
===
--- compiler/fmodule.pas (Revision 17417)
+++ compiler/fmodule.pas (Arbeitskopie)
@@ -235,6 +235,7 @@
function get_source_file(moduleindex,fileindex : longint) : tinputfile;
procedure addloadedunit(hp:tmodule);
function find_module_from_symtable(st:tsymtable):tmodule;
+function ascend_from_macros(f:tinputfile) : tinputfile;
implementation
@@ -336,6 +337,13 @@
end;
+function ascend_from_macros(f:tinputfile) : tinputfile;
+ begin
+while assigned(f) and f.is_macro do f:=f.next;
+ascend_from_macros:=f;
+ end;
+
+
procedure addloadedunit(hp:tmodule);
begin
hp.moduleid:=loaded_units.count;
Index: compiler/scanner.pas
===
--- compiler/scanner.pas (Revision 17417)
+++ compiler/scanner.pas (Arbeitskopie)
@@ -1712,11 +1712,24 @@
hs:=getdatestr
else
if hs='FILE' then
- hs:=current_module.sourcefiles.get_file_name(current_filepos.fileindex)
+ begin
+ hp:=ascend_from_macros(current_module.sourcefiles.get_file(current_filepos.fileindex));
+ if assigned(hp) then hs:=hp.name^ else hs:='unknown'
+ end
else
if hs='LINE' then
- hs:=tostr(current_filepos.line)
+ begin
+ hp:=ascend_from_macros(current_module.sourcefiles.get_file(current_filepos.fileindex));
+ if assigned(hp) then hs:=tostr(hp.saveline_no) else hs:='unknown'
+ end
else
+if hs='PATH' then
+ begin
+ hp:=ascend_from_macros(current_module.sourcefiles.get_file(current_filepos.fileindex));
+ if assigned(hp) then hs:=hp.path^ else hs:='unknown';
+ if hs='' then hs:=CurDirRelPath(target_info)
+ end
+ else
if hs='FPCVERSION' then
hs:=version_string
else
@@ -3473,7 +3486,7 @@
mac.is_used:=true;
inc(yylexcount);
insertmacro(pattern,mac.buftext,mac.buflen,
- mac.fileinfo.line,mac.fileinfo.fileindex);
+ current_scanner.line_no,current_scanner.inputfile.ref_index);
{ handle empty macros }
if c=#0 then
reload;
___
fpc-devel maillist - fpc-devel@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] Re: Can't compile at revision: 17417
On Mon, May 9, 2011 at 10:36 AM, Marcos Douglas m...@delfire.net wrote: On Mon, May 9, 2011 at 10:29 AM, Joost van der Sluis jo...@cnoc.nl wrote: On Mon, 2011-05-09 at 10:14 -0300, Marcos Douglas wrote: On Mon, May 9, 2011 at 10:04 AM, Joost van der Sluis jo...@cnoc.nl wrote: On Mon, 2011-05-09 at 07:47 -0300, Marcos Douglas wrote: On Sun, May 8, 2011 at 5:19 PM, Marcos Douglas m...@delfire.net wrote: I resolved. Path in attachment (copy from /trunk). Hello, somebody can confirm this, please? A quick look on your patch is that you want to include the 32-bit odbc driver in a 64 bit environment? Probably you are cross-compiling while you don't have the proper .dll's (32 and 64 bit) in your search-path. No. This path was copied from odbcsql.pas in /trunk. I use Win32 only. If you don't use trunk, what are you trying to compile? Sorry my English... I use /fixes_2_4 but I could not to compile (error in first mail). So, I took a look in sources from /trunk. I compared this files (odbcsql) and saw this difference between them (the patch). Hi Joost, Did you understand? Marcos Douglas ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
Re: [fpc-devel] Re: Can't compile at revision: 17417
Am Mon, 9 May 2011 17:23:30 -0300 schrieb Marcos Douglas m...@delfire.net: I use /fixes_2_4 but I could not to compile (error in first mail). So, I took a look in sources from /trunk. I compared this files (odbcsql) and saw this difference between them (the patch). Did you understand? I think there are two possibilities: 1) During shutdown (shut off) something in your file system went wrong. You should 'svn up' again. Maybe svn can correct the error, or gives you a hint. 2) It is windows related. For me all works fine. But i´m using linux. ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
[fpc-devel] fppkg question
Hi, I've created a trivial front end for fppkg (see lazarus mailing list) but working on this I realized that they are not grouped in any way. Currently with approx. 70 packages this is not a real problem, but if the system will get used more widely it will be impossible to deduct the purpose (and possibly other info) from the package just by it's name. Therefore I would like to request a new command named info that retrieves the info for a package from packages.xml. I would also like to add some more info in this file for a package: - the topic that organizes the packages (FPC core / DB / buttons / charts / dialogs / etc) - keywords to make it possible to search freely - support contact (official / community) See the following movie on youtube on a plugin system that has some of these features: http://www.youtube.com/watch?v=d9yyJmh3dyUfeature=player_embedded Are / were there any plans ever in this direction? Am I free to create a couple of patches? Regards, Darius___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
