Re: [fpc-pascal] pull request: Add missing CTRL keys to wincrt unit
On 2016-09-14 10:54, Jonas Maebe wrote: > Maybe it would help to mention the fact Indeed. I've updated the description. I hope this will make it clear from now onwards. Now if anybody actually reads such descriptions, that's another matter. ;-) Regards, Graeme -- fpGUI Toolkit - a cross-platform GUI toolkit using Free Pascal http://fpgui.sourceforge.net/ My public PGP key: http://tinyurl.com/graeme-pgp ___ fpc-pascal maillist - fpc-pascal@lists.freepascal.org http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal
Re: [fpc-pascal] pull request: Add missing CTRL keys to wincrt unit
Graeme Geldenhuys wrote: > No worries, many others assume the same. I started the "unofficial" git > mirror Maybe it would help to mention the fact that it is unofficial in the description of your repository. You could also add something like "For submitting patches or bug reports, go to http://bugs.freepascal.org;. Jonas ___ fpc-pascal maillist - fpc-pascal@lists.freepascal.org http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal
Re: [fpc-pascal] pull request: Add missing CTRL keys to wincrt unit
On 2016-09-13 20:01, James Richters wrote: > That was me, Sorry about that, I did not realize it was a read only > repository, I downloaded a fork of it to my desktop a while ago, so when I > had a proposed change to it, I just made a pull request the way I normally > do with git projects. No worries, many others assume the same. I started the "unofficial" git mirror as I find it easier to manage and produce my own patches - and all importantly, patches in multiple "feature branches" so as not to conflict with each other. I then submit those patches via FPC's Mantis system. Maybe some day FPC will move over to Git. ;-) Regards, Graeme ___ fpc-pascal maillist - fpc-pascal@lists.freepascal.org http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal
Re: [fpc-pascal] pull request: Add missing CTRL keys to wincrt unit
That was me, Sorry about that, I did not realize it was a read only repository, I downloaded a fork of it to my desktop a while ago, so when I had a proposed change to it, I just made a pull request the way I normally do with git projects. I have posted the issue here: http://mantis.freepascal.org/view.php?id=30599 and have attached the file to it. I'm not really familiar with this system, so I hope I'm doing it right. -Original Message- From: fpc-pascal-boun...@lists.freepascal.org [mailto:fpc-pascal-boun...@lists.freepascal.org] On Behalf Of Graeme Geldenhuys Sent: Tuesday, September 13, 2016 6:15 AM To: FPC-Pascal users discussions <fpc-pascal@lists.freepascal.org> Subject: Re: [fpc-pascal] pull request: Add missing CTRL keys to wincrt unit > Somebody made a contribution via my Git mirror of the FPC repository. File Changes M packages/graph/src/win32/wincrt.pp (120) Patch Links: https://github.com/graemeg/freepascal/pull/10.patch https://github.com/graemeg/freepascal/pull/10.diff Regards, Graeme ___ fpc-pascal maillist - fpc-pascal@lists.freepascal.org http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal ___ fpc-pascal maillist - fpc-pascal@lists.freepascal.org http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal
Re: [fpc-pascal] pull request: Add missing CTRL keys to wincrt unit
> Somebody made a contribution via my Git mirror of the FPC repository. File Changes M packages/graph/src/win32/wincrt.pp (120) Patch Links: https://github.com/graemeg/freepascal/pull/10.patch https://github.com/graemeg/freepascal/pull/10.diff Regards, Graeme ___ fpc-pascal maillist - fpc-pascal@lists.freepascal.org http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal
[fpc-pascal] pull request: Add missing CTRL keys to wincrt unit
Hi, Somebody made a contribution via my Git mirror of the FPC repository. If somebody is interested in taking a look. The original author was notified that my Git mirror is an unofficial read-only repository. https://github.com/graemeg/freepascal/pull/10 Regards, Graeme ___ fpc-pascal maillist - fpc-pascal@lists.freepascal.org http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal
