Re: [Framework-Team] Two more reviews primed
On Feb 11, 2008, at 9:54 AM, Andreas Zeidler wrote: i'll do another more in depth wrap-up later, but the quick status is that the only PLIPs left now without any reviews are #212 and #215. iirc, tom was planning to do #212 today, so if anyone was up to look into #215 the first round could be completed... here's and updated and condensed status overview: plip reviews planned #187: Working Out-of-the-box WebDAV raphael #201: Improve the UberSelectionWidget UI martijn tom #202: Support inline validation and editing [...] raphael #205: Flexibility Associating Portlet Types [...] andi #207: Allow Custom Portlet Managers andi #208: Adapter-Based Local Role Lookup andi #209: Add buildout to Unified Installer martijn tom #212: Use jQuery Javascript Library tom #213: Prepare for better Syndicationandi #215: Include new KSS versions ?? tom #217: Use Adaptation for Workflow Assignmentandi #218: Increase Restrictions, and Ability to [...] andi #220: Improve browser layer support andi #224: CSRF protection framework raphael andi i left out the not-submitted PLIPs as well as those that have already been reviewed at least twice. nevertheless the remaining list is still quite long, and the deadline is approaching rapidly, so here's another call to the team: * tom, you said you would also look at #201, #209, #215 as well as leftovers. so, can i suggest you pick at least three more, let us know which and post an updated ETA, please? * martijn, as i think we'll have to end up with at least 8 reviews each, it would be great if you do one more as well (and let us know which, too). * raphael, i know you've already done several reviews, but could you please try to post your notes asap? in case there are issues, the authors will need some time to be able to respond to those... * danny, you said you'd be able to work on your reviews starting this week. could you please give us an update about which ones that will be and when you'll finish them as well? * as i said earlier, i will still look into #224, but won't get to do so before the flight back on thursday. so much for the moment — i'll post another summary once everyone has stated which PLIPs they'll tackle. and again, please do so asap, we're quickly running out of time!! cheers, andi -- zeidler it consulting - http://zitc.de/ - [EMAIL PROTECTED] friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.0.5 released! -- http://plone.org/products/plone PGP.sig Description: This is a digitally signed message part ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] Two more reviews primed
On Feb 13, 2008 11:39 AM, Andreas Zeidler [EMAIL PROTECTED] wrote: #205: Flexibility Associating Portlet Types [...] andi #218: Increase Restrictions, and Ability to [...] andi * martijn, as i think we'll have to end up with at least 8 reviews each, it would be great if you do one more as well (and let us know which, too). I have both 205 and 218 on my laptop already, so I'll tackle those next. -- Martijn Pieters ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
[Framework-Team] Re: Updated PLIP review deadline
Hi! Wichert Akkerman wrote: Unfortunately the Plone 3.1 PLIP review deadline has gone by silently without all reviews being finished, which means we need to adjust our timelines. The new, final, ultimate deadline for reviews is: Saturday, February 16 Are there also some new dates for the rest of the process? tagging and such? I would then change the calendar accordingly. -- Christian -- Christian Scholz video blog: http://comlounge.tv COM.lounge blog: http://mrtopf.de/blog Luetticher Strasse 10Skype: HerrTopf 52064 Aachen Homepage: http://comlounge.net Tel: +49 241 400 730 0 E-Mail [EMAIL PROTECTED] Fax: +49 241 979 00 850 IRC: MrTopf, Tao_T connect with me: http://mrtopf.de/connect ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] Re: PLIP 212 ready for review
hello florian, hello martijn,
i've completed my review and committed the notes in the svn bundle.
i repeated the manual tests with windows IE 6.0, but not with 7.0 as i
didn't have the time to install a new windows VM to install IE 7
without overwriting my existing 6.0 but since everything looked just
like in FF/Safari (i.e. the same stuff worked and the same stuff
didn't) i don't expect any big surprises there.
i also looked at some of the .js diffs and really liked what i
saw ;-), http://dev.plone.org/plone/changeset/18810 is a nice example
for that (livesearch.js)
i can't recommend this plip for inclusion in 3.1 in its current state,
however, alle the errors seem minor and easily fixable.
below i would also like to respond to florian's email in the same post
here:
On 12.02.2008, at 23:41, Florian Schulze wrote:
instead i got the following error in jquery.js (via firebug)
a is not a function
[Break on this error] eval(function(p,a,c,k,e,r){e=function(c)
{return(ca?'':e(parseInt(c/a)))+((c=c%a...
Note: this error remained, even after replacing the shipping jquery
version 1.2.2 with the meanwhile current version 1.2.3
This looks like a syntax error in that file. I will look into it.
well, since it's the jquery.js file itself, i kind of doubt it (which
also prompted me to try out the 1.2.3 version) but hey! you're the
expert ;-)
This is either another syntax error, or some issue with the KSS
interaction.
you tell me ;-)
= running unit tests =
running all tests (./bin/instance/test -v -v -s plone) produced the
following result:
Tests with failures:
test_published_news_items
(plone.app.portlets.tests.test_events_portlet.TestRenderer)
test_published_news_items
(plone.app.portlets.tests.test_news_portlet.TestRenderer)
/opt/zope/buildout/eggs/plone.app.workflow-1.0.1.1-py2.4.egg/
plone/app/workflow/tests/onestateworkflow.txt
Total: 1079 tests, 3 failures, 0 errors
I didn't look into this at all, because we didn't change anything
besides JS code and some registrations in JS registry.
true, especially after i now looked into those diffs for myself, i
wouldn't label these failures 'showstoppers' for this plip.
I will look into upgrading the buildout to the latest Plone version
if it isn't already.
that would be cool
best regards,
tom
= code review =
to be done (check migration, look into the js code changes)
Regards,
Florian Schulze
___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team
___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] Re: Updated PLIP review deadline
On Feb 7, 2008, at 1:01 AM, Martin Aspeli wrote: Once you post your reviews (here?) what happens? How does the team arrive at a final yes/no vote? How long does that take? hmm, i can't decide on these, of course, but i'd still like to try and get at least two reviews per PLIP. in case the reviews don't reveal major issues or otherwise warrant further discussion, i think that should do. every member of the team should read all of the submitted review notes and formally vote on the inclusion of the PLIP in question, though. with the deadline on the 16th and a sunday following that i reckon it should be easy enough for everyone to cast their votes by monday. in case not, could you please tell us asap? otherwise we should have a complete set of votes by monday night, at which point i'll post the verdict or rather the recommendations of the framework team. that should leave enough time for merging and last- minute polishing before the alpha freeze, which will presumably be on february 22nd now (assuming we're gonna shift the whole schedule by two weeks). does that sound alright with everyone? For 3.0, each reviewer posted a thread here with the necessary comments, including good points, bad points and recommendations. i guess that's what the trac tickets were created for — the reviewers are supposed to update those with links to their notes, and i've cc'ed the authors when creating them. hmm, i guess that's assuming everyone had put their email address into their trac settings, but i'll make sure to cc everyone again when sending out the results on monday. We then reported back to the author (usually by just CC'ing them on the framework team list threads) and they were told either that it was rejected, or to make the necessary changes (if any) and prepare for merge. Wichert took the final decision on whether to merge or not. that makes sense, of course, and imho we should keep it like that. As a learning point, we (I) should have written down our process properly and handed it over better. i suppose that would have helped a bit here and there, but most of the problems we were seeing were due to lack of time anyway. I apologise for not doing this, relying on doing it verbally and letting you guys (especially Andreas) come up with your own take without too much guidance. no biggie — the important bit was to identify this during the summit, which will hopefully make sure things work better next time. cheers, andi ps: sorry for answering so late, btw. -- zeidler it consulting - http://zitc.de/ - [EMAIL PROTECTED] friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.0.5 released! -- http://plone.org/products/plone PGP.sig Description: This is a digitally signed message part ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] Re: Updated PLIP review deadline
On Feb 13, 2008, at 4:27 AM, Christian Scholz wrote: Wichert Akkerman wrote: Unfortunately the Plone 3.1 PLIP review deadline has gone by silently without all reviews being finished, which means we need to adjust our timelines. The new, final, ultimate deadline for reviews is: Saturday, February 16 Are there also some new dates for the rest of the process? tagging and such? I would then change the calendar accordingly. i would assume the whole schedule will be shifted by two weeks, since that's also the delay in the review process. we'll have to check with wichert, though. nevertheless, i've updated the calendar at http://plone.org/products/plone/releases/3.1/timeline.ics accordingly. cheers, andi -- zeidler it consulting - http://zitc.de/ - [EMAIL PROTECTED] friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.0.5 released! -- http://plone.org/products/plone PGP.sig Description: This is a digitally signed message part ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
