Re: adsl/pppoe no longer connecting on 5.1

2003-06-13 Thread Dag-Erling Smorgrav
David O'Brien [EMAIL PROTECTED] writes:
 Acutally -std=c?9, -std=gnu?9 uses GCC's alloca.  I don't mind finding
 all the alloca uses in the tree and compiling them with -std=gnu99
 instead of -std=c99.

#define alloca(sz) __builtin_alloca(sz)

DES
-- 
Dag-Erling Smorgrav - [EMAIL PROTECTED]
___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to [EMAIL PROTECTED]


Re: adsl/pppoe no longer connecting on 5.1

2003-06-12 Thread Kris Kennaway
On Thu, Jun 12, 2003 at 07:18:12AM +0200, Wiktor Niesiobedzki wrote:
 On Wed, Jun 11, 2003 at 09:50:22PM -0700, Kris Kennaway wrote:
  On Wed, Jun 11, 2003 at 10:48:32PM -0600, Andrew Lankford wrote:
   Can you try backing out bsd.sys.mk to r1.26 and rebuild your world and
   kernel?  Later versions of this file are causing strange problems with
   package builds.
   
   I was a little lazy and just backed out bsd.sys.mk to 1.26 as you
   suggested, rebuilt /usr/lib/ , /usr/include/, and ppp.  My kernel is the
   same as last time.  As a result, ppp's now up and running again.
  
  Thanks, that's actually more useful because it isolates the problem.
  It's probably something in ppp that is misbehaving with CSTD=c99.
  
 alloca(3) function is misbehaving in ppp (namely ether.c). Is this a compiler
 bug?

It looks like gcc's inline alloca implementation allocates chunks in
larger chunks than the alloca.S implementation does.  This (untested)
patch should make the alloca.S behaviour match that of gcc.

Kris

Index: i386/gen/alloca.S
===
RCS file: /usr/home/ncvs/src/lib/libc/i386/gen/alloca.S,v
retrieving revision 1.10
diff -u -r1.10 alloca.S
--- i386/gen/alloca.S   23 Mar 2002 02:44:18 -  1.10
+++ i386/gen/alloca.S   12 Jun 2003 06:00:52 -
@@ -47,8 +47,8 @@
popl%edx/*  pop return addr */
popl%eax/*  pop amount to allocate */
movl%esp,%ecx
-   addl$3,%eax /*  round up to next word */
-   andl$0xfffc,%eax
+   addl$15,%eax/*  round up to next word */
+   andl$0xfff0,%eax
subl%eax,%esp
movl%esp,%eax   /* base of newly allocated space */
pushl   8(%ecx) /* copy possible saved registers */


pgp0.pgp
Description: PGP signature


Re: adsl/pppoe no longer connecting on 5.1

2003-06-12 Thread Kris Kennaway
On Wed, Jun 11, 2003 at 11:05:57PM -0700, Kris Kennaway wrote:

 It looks like gcc's inline alloca implementation allocates chunks in
 larger chunks than the alloca.S implementation does.  This (untested)
 patch should make the alloca.S behaviour match that of gcc.

I suspect that there's a buffer overrun in one of the alloca() buffers
in ppp, that is harmless with gcc's inline version because of the
extra padding.  I haven't spotted it yet though.

Kris


pgp0.pgp
Description: PGP signature


Re: adsl/pppoe no longer connecting on 5.1

2003-06-12 Thread Kris Kennaway
On Thu, Jun 12, 2003 at 07:18:12AM +0200, Wiktor Niesiobedzki wrote:
 On Wed, Jun 11, 2003 at 09:50:22PM -0700, Kris Kennaway wrote:
  On Wed, Jun 11, 2003 at 10:48:32PM -0600, Andrew Lankford wrote:
   Can you try backing out bsd.sys.mk to r1.26 and rebuild your world and
   kernel?  Later versions of this file are causing strange problems with
   package builds.
   
   I was a little lazy and just backed out bsd.sys.mk to 1.26 as you
   suggested, rebuilt /usr/lib/ , /usr/include/, and ppp.  My kernel is the
   same as last time.  As a result, ppp's now up and running again.
  
  Thanks, that's actually more useful because it isolates the problem.
  It's probably something in ppp that is misbehaving with CSTD=c99.
  
 alloca(3) function is misbehaving in ppp (namely ether.c). Is this a compiler
 bug?

Okay, it looks like alloca.S was broken.  My previous patch that
increased the size of allocations was just a gratuitous difference
with the inline version, and is not necessary.  Here's a fix that
seems to get ppp to stop complaining.

Kris

Index: alloca.S
===
RCS file: /usr/home/ncvs/src/lib/libc/i386/gen/alloca.S,v
retrieving revision 1.10
diff -u -r1.10 alloca.S
--- alloca.S23 Mar 2002 02:44:18 -  1.10
+++ alloca.S12 Jun 2003 07:35:03 -
@@ -51,6 +51,7 @@
andl$0xfffc,%eax
subl%eax,%esp
movl%esp,%eax   /* base of newly allocated space */
+   leal24(%esp), %eax
pushl   8(%ecx) /* copy possible saved registers */
pushl   4(%ecx)
pushl   0(%ecx)


pgp0.pgp
Description: PGP signature


Re: adsl/pppoe no longer connecting on 5.1

2003-06-12 Thread Kris Kennaway
On Thu, Jun 12, 2003 at 12:38:36AM -0700, Kris Kennaway wrote:

 Okay, it looks like alloca.S was broken.  My previous patch that
 increased the size of allocations was just a gratuitous difference
 with the inline version, and is not necessary.  Here's a fix that
 seems to get ppp to stop complaining.

Oops, forgot to remove the movl.

Index: alloca.S
===
RCS file: /usr/home/ncvs/src/lib/libc/i386/gen/alloca.S,v
retrieving revision 1.10
diff -u -r1.10 alloca.S
--- alloca.S23 Mar 2002 02:44:18 -  1.10
+++ alloca.S12 Jun 2003 07:41:45 -
@@ -50,7 +50,7 @@
addl$3,%eax /*  round up to next word */
andl$0xfffc,%eax
subl%eax,%esp
-   movl%esp,%eax   /* base of newly allocated space */
+   leal24(%esp), %eax  /* base of newly allocated space */
pushl   8(%ecx) /* copy possible saved registers */
pushl   4(%ecx)
pushl   0(%ecx)

Kris


pgp0.pgp
Description: PGP signature


Re: adsl/pppoe no longer connecting on 5.1

2003-06-12 Thread Kris Kennaway
On Thu, Jun 12, 2003 at 12:44:51AM -0700, Kris Kennaway wrote:

 + leal24(%esp), %eax  /* base of newly allocated space */

After I figured out what the 24(...) meant (add 24 to ...) it's
clear that this isn't a fix (except in the special case of PPPoE
support ;-).  gcc's builtin inline alloca() is tuning that offset
value at compile-time, so alloca.S is just broken (and has been since
386BSD, looks like), but it's beyond my pattern-monkey asm skills to
fix.

Kris


pgp0.pgp
Description: PGP signature


Re: adsl/pppoe no longer connecting on 5.1

2003-06-12 Thread Garrett Wollman
On Thu, 12 Jun 2003 15:38:49 +1000, Tim Robbins [EMAIL PROTECTED] said:

 Misbehaving in what way? CSTD=c99 causes gcc to use alloca() from
 libc instead of its builtin version. Perhaps alloca() in libc is
 broken -- any bugs in it would have been covered up by gcc until
 now.

alloca() in libc is *fundamentally* broken.  Only the compiler can
know the current state of the stack frame, and that information is not
necessarily available to library functions.  On some architectures
it is not even possible for a library function to adjust its caller's
stack frame, which is why alpha, ia64, and sparc64 don't have an
alloca.S (nor an alloca.c for that matter).

-GAWollman

___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to [EMAIL PROTECTED]


Re: adsl/pppoe no longer connecting on 5.1

2003-06-12 Thread Tim Kientzle
Garrett Wollman wrote:

alloca() in libc is *fundamentally* broken.  Only the compiler can
know the current state of the stack frame...


Sounds like alloca() should simply be stricken from libc
on all architectures.
Might also be a good idea to begin removing uses of it.
Searching through the source tree, I note that there's
only a handful of uses of alloca outside of contrib and gnu.
Tim Kientzle

___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to [EMAIL PROTECTED]


Re: adsl/pppoe no longer connecting on 5.1

2003-06-12 Thread Garrett Wollman
On Thu, 12 Jun 2003 11:37:03 -0700, Tim Kientzle [EMAIL PROTECTED] said:

 Sounds like alloca() should simply be stricken from libc
 on all architectures.

Yes.  (For values of `all' being `i386'.)

 Might also be a good idea to begin removing uses of it.

Not necessarily.  There's nothing wrong, intrinsically, with using
alloca(), although much but not all of the purpose has been subsumed
by variable-length arrays which I think are in C99.  One merely has to
be aware that it is not part of Standard C (any more than a thousand
other interfaces in FreeBSD) which must be implemented in the
compiler; therefore, one cannot expect programs which expect alloca(3)
to be available and have the standard semantics to work when compiled
with a strictly conforming compiler.  Most compilers do implement
alloca().

-GAWollman

___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to [EMAIL PROTECTED]


Re: adsl/pppoe no longer connecting on 5.1

2003-06-12 Thread David O'Brien
On Wed, Jun 11, 2003 at 10:32:30PM -0700, Kris Kennaway wrote:
 alloca() is not being inlined when -std is specified.  It is possible
 there's a bug in the libc implementation.  I'm also suspicious that
 some of the ppp data structures have changed size or alignment which
 could be confusing netgraph.

Acutally -std=c?9, -std=gnu?9 uses GCC's alloca.  I don't mind finding
all the alloca uses in the tree and compiling them with -std=gnu99
instead of -std=c99.
___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to [EMAIL PROTECTED]


Re: adsl/pppoe no longer connecting on 5.1

2003-06-12 Thread Bruce Evans
On Thu, 12 Jun 2003, Kris Kennaway wrote:

 On Thu, Jun 12, 2003 at 12:44:51AM -0700, Kris Kennaway wrote:

  +   leal24(%esp), %eax  /* base of newly allocated space */

 After I figured out what the 24(...) meant (add 24 to ...) it's
 clear that this isn't a fix (except in the special case of PPPoE
 support ;-).  gcc's builtin inline alloca() is tuning that offset
 value at compile-time, so alloca.S is just broken (and has been since
 386BSD, looks like), but it's beyond my pattern-monkey asm skills to
 fix.

Something like that is needed just to realign the stack frame.  Alignment
of the (eventual) stack to at least a 16-byte boundary is now required.
Since the required alignment depends on the compiler vendor version and
flags, and possibly on the calling function's environment, this is
impossible to do in all cases.  It may be possible to keep current
gcc cases working by not disturbing the the stack's alignment mod 16
relative to what it was when the function was called.

I don't think misalignment of the stack could cause the current problems.
Those are more likely to be caused by copy possible [sic] saved registers
(see tjr's mail about pushl vs movl to the stack).

Bruce
___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to [EMAIL PROTECTED]


Re: adsl/pppoe no longer connecting on 5.1

2003-06-11 Thread Gerald Mixa
On Wednesday 11 June 2003 13:53, T. Muddletin wrote:

Well, does your DSL Provider really support IPV6 ? Actually for me it seems 
that you try to establish an ipv6 connection, which is rarley supported!
 On my previous FreeBSD version (5.0 April 21 snapshot), my ADSL/pppoe
 setup worked fine... as it always has all the way back to 4.x. Now
 having installed 5.1-RELEASE, with no other changes, ppp no longer can
 seeming no longer connect to my adsl modem. I've been struggling with
 this for days.

 Is anyone else experiencing this, or can anyone suggest any things to
 try? Again I say, my simple config has always worked for me, and i
 can't find any reason to suggest it shouldn't any longer.

 The modem is an OvisLink (I forget the model at the moment). It has
 built in routing/nat capabilities, but I never have used them in the
 past (preferring the control/flexibilty of doing it on on the gateway
 FreeBSD box). With the problems i've been having however, I've had to
 set up the modem to handle the PPPoE itself... it is still plugged
 into the same interface on the FreeBSD box, and when the default route
 is fixed up the FreeBSD box is on the net: so the modem seems to be
 functioning properly, and the cables and interfaces all communicate
 without problems.

 The stumbling block seems to be that FreeBSD's ppp can no longer
 detect carrier on the modem, and so fails. I have tried using set cd
 off and dedicated mode for ppp, but this just then fails at the
 next phase since it still can't seem to communicate with the modem.

 What i see in my ppp.log (lots of logging):

 Jun 11 07:36:58 bee ppp[9076]: Phase: Using interface: tun0
 Jun 11 07:36:58 bee ppp[9076]: Phase: deflink: Created in closed state
 Jun 11 07:36:58 bee ppp[9076]: tun0: Command: default: ident user-ppp
 VERSION (built COMPILATIONDATE) Jun 11 07:36:58 bee ppp[9076]: tun0: Phase:
 PPP Started (interactive mode). Jun 11 07:37:00 bee ppp[9076]: tun0:
 Command: /dev/ttypb: dial dsl Jun 11 07:37:00 bee ppp[9076]: tun0: Command:
 dsl: set log Phase Chat LCP IPCP CCP tun command debug Jun 11 07:37:00 bee
 ppp[9076]: tun0: Command: dsl: set ifaddr 10.0.0.1/0 10.0.0.2/0
 255.255.255.0 0.0.0.0 Jun 11 07:37:00 bee ppp[9076]: tun0: Command: dsl:
 set device PPPoE:xl0 Jun 11 07:37:00 bee ppp[9076]: tun0: Command: dsl: set
 authname [EMAIL PROTECTED] Jun 11 07:37:00 bee ppp[9076]: tun0: Command: dsl:
 set authkey  Jun 11 07:37:00 bee ppp[9076]: tun0: Command: dsl: set
 dial
 Jun 11 07:37:00 bee ppp[9076]: tun0: Command: dsl: set login
 Jun 11 07:37:00 bee ppp[9076]: tun0: Command: dsl: enable lqr
 Jun 11 07:37:00 bee ppp[9076]: tun0: Command: dsl: set lqrperiod 5
 Jun 11 07:37:00 bee ppp[9076]: tun0: Command: dsl: set speed sync
 Jun 11 07:37:00 bee ppp[9076]: tun0: Command: dsl: set cd 5
 Jun 11 07:37:00 bee ppp[9076]: tun0: Command: dsl: set ctsrts off
 Jun 11 07:37:00 bee ppp[9076]: tun0: Command: dsl: add default HISADDR
 Jun 11 07:37:00 bee ppp[9076]: tun0: Debug: wrote -1: cmd = Add, dst =
 0.0.0.0/0, gateway = 10.0.0.2 Jun 11 07:37:00 bee ppp[9076]: tun0: Phase:
 bundle: Establish
 Jun 11 07:37:00 bee ppp[9076]: tun0: Phase: deflink: closed - opening
 Jun 11 07:37:00 bee ppp[9076]: tun0: Debug: List of netgraph node ``xl0:''
 (id 1) hooks: Jun 11 07:37:00 bee ppp[9076]: tun0: Debug:   Found orphans
 - ethernet Jun 11 07:37:00 bee ppp[9076]: tun0: Debug: Connecting netgraph
 socket .:tun0 - [4]::tun0 Jun 11 07:37:00 bee ppp[9076]: tun0: Debug:
 Sending PPPOE_CONNECT to .:tun0 Jun 11 07:37:00 bee ppp[9076]: tun0: Debug:
 Found the following interfaces: Jun 11 07:37:00 bee ppp[9076]: tun0: Debug:
  Index 1, name xl0
 Jun 11 07:37:00 bee ppp[9076]: tun0: Debug:  Index 2, name rl0
 Jun 11 07:37:00 bee ppp[9076]: tun0: Debug:  Index 3, name lo0
 Jun 11 07:37:00 bee ppp[9076]: tun0: Debug:  Index 4, name tun0
 Jun 11 07:37:00 bee ppp[9076]: tun0: Phase: deflink: Connected!
 Jun 11 07:37:00 bee ppp[9076]: tun0: Phase: deflink: opening - dial
 Jun 11 07:37:00 bee ppp[9076]: tun0: Chat: deflink: Dial attempt 1 of 1
 Jun 11 07:37:00 bee ppp[9076]: tun0: Phase: deflink: dial - carrier
 Jun 11 07:37:00 bee ppp[9076]: tun0: Debug: Waiting for carrier
 Jun 11 07:37:03 bee last message repeated 4 times
 Jun 11 07:37:04 bee ppp[9076]: tun0: Phase: deflink: Disconnected!
 Jun 11 07:37:04 bee ppp[9076]: tun0: Phase: deflink: carrier - hangup
 Jun 11 07:37:04 bee ppp[9076]: tun0: Debug: deflink: Close

 monitoring the interface (tcpdump -e -i xl0 not ip) one can see:

 07:47:59.950033 0:1:3:23:ee:f4 Broadcast 8863 32: PPPoE PADI [Host-Uniq
 UTF8] 07:48:01.949617 0:1:3:23:ee:f4 Broadcast 8863 32: PPPoE PADI
 [Host-Uniq UTF8]

 I'd post my config if it would help to see it; but most of it can be
 seen in the log above, and it's really very simple and always had
 worked, so i'm not sure it's relevant in this case.
___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To 

Re: adsl/pppoe no longer connecting on 5.1

2003-06-11 Thread Michael Nottebrock
On Wednesday 11 June 2003 13:53, T. Muddletin wrote:
 On my previous FreeBSD version (5.0 April 21 snapshot), my ADSL/pppoe
 setup worked fine... as it always has all the way back to 4.x. Now
 having installed 5.1-RELEASE, with no other changes, ppp no longer can
 seeming no longer connect to my adsl modem. I've been struggling with
 this for days.

Are you sure you really have 5.1-RELEASE and not 5-CURRENT shortly after 
-RELEASE? There have been many other reports on pppoe related breakage with 
ppp in -CURRENT, but 5.1-RELEASE should work (at least it works fine for me).

-- 
Michael Nottebrock   \ KDE on FreeBSD  \  ,ww  
  \ --- \ ,wWWCybaWW_) 
   \   http://freebsd.kde.org\ `WSheepW'free
  \  II  II node


pgp0.pgp
Description: signature


Re: adsl/pppoe no longer connecting on 5.1

2003-06-11 Thread P. U. Kruppa
On Wed, 11 Jun 2003, Gerald Mixa wrote:

 On Wednesday 11 June 2003 13:53, T. Muddletin wrote:

 Well, does your DSL Provider really support IPV6 ? Actually for me it seems
 that you try to establish an ipv6 connection, which is rarley supported!
  On my previous FreeBSD version (5.0 April 21 snapshot), my ADSL/pppoe
  setup worked fine... as it always has all the way back to 4.x. Now
  having installed 5.1-RELEASE, with no other changes, ppp no longer can
  seeming no longer connect to my adsl modem. I've been struggling with
  this for days.
 
  Is anyone else experiencing this, or can anyone suggest any things to
  try?
Yes, we had a discussion about this two or three days ago.
You could cvsup to RELENG_5_1 which still has the working ppp and
hope smeone is going to fix this on -CURRENT.

Uli.


+---+
|Peter Ulrich Kruppa|
|  -  Wuppertal -   |
|  Germany  |
+---+
___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to [EMAIL PROTECTED]


Re: adsl/pppoe no longer connecting on 5.1

2003-06-11 Thread T. Muddletin
Gerald wrote on Wednesday, June 11, 2003, 9:43:02 AM:
 Well, does your DSL Provider really support IPV6 ? Actually for me it seems
 that you try to establish an ipv6 connection, which is rarley supported!

That is interesting; I can't see where it appears to be this though.
Perhaps something in (cryptic to me) the tcpdump message indicates
this? Maybe this is the problem that CURRENT is having in general, if
suddenly the client has switched everyone to ipv6.

 07:47:59.950033 0:1:3:23:ee:f4 Broadcast 8863 32: PPPoE PADI [Host-Uniq
 UTF8] 07:48:01.949617 0:1:3:23:ee:f4 Broadcast 8863 32: PPPoE PADI
 [Host-Uniq UTF8]

?

-- 
Tim Middleton | Cain Gang Ltd | But the trouble was that my hysterical fit
[EMAIL PROTECTED] | www.Vex.Net   | could not go on for ever. --Dost (NFTU)

___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to [EMAIL PROTECTED]


Re: adsl/pppoe no longer connecting on 5.1

2003-06-11 Thread T. Muddletin
Michael wrote on Wednesday, June 11, 2003, 10:02:25 AM:
 Are you sure you really have 5.1-RELEASE and not 5-CURRENT shortly
 after -RELEASE? There have been many other reports on pppoe related
 breakage with ppp in -CURRENT, but 5.1-RELEASE should work (at least
 it works fine for me).

I definitely have -RELEASE... i'm working from the downloaded released
ISO image. And it definitely says RELEASE on boot up (from dmesg):

FreeBSD 5.1-RELEASE #0: Thu Jun  5 02:55:42 GMT 2003
[EMAIL PROTECTED]:/usr/obj/usr/src/sys/GENERIC

(Though i have since recompiled the kernel using the sources on the
CD-Rom -- i also recompiled src/usr.sbin/ppp at some point yesterday
in one of my many failed attempts to fix the thing... but it didn't
help... incidentally 'make buildworld' failed on a missing krb5.h ...
but that's another issue...)

-- 
Tim Middleton | Cain Gang Ltd | Then suddenly, for no apparent reason, the
[EMAIL PROTECTED] | www.Vex.Net   | unpitying orchestra struck up a polka. -D

___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to [EMAIL PROTECTED]


Re: adsl/pppoe no longer connecting on 5.1

2003-06-11 Thread Andrew Lankford
I'm having trouble with the latest build of -CURRENT as well.  Same problem, slightly 
different symptoms:

Portions of my config file:
disable ipv6
deny pap

set device PPPoE:xl0

...produce this in the log (repeatedly):

 Jun 11 22:00:14 bogushost2 ppp[222]: Warning:  Unexpected node type ``socket'' 
(wanted ``ether'') 
Jun 11 22:00:14 bogushost2 ppp[222]: Warning: deflink: PPPoE: unknown host 
Jun 11 22:00:14 bogushost2 ppp[222]: Warning: deflink: PPPoE: unknown host 
Jun 11 22:00:14 bogushost2 ppp[222]: Warning: deflink: Device (PPPoE:xl0) must egin 
with a '/', a '!' or contain at least one ':' 
Jun 11 22:00:14 bogushost2 ppp[222]: Phase: deflink: Enter pause (2) for redialing. 

Bloody irritating.

Andrew Lankford


___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to [EMAIL PROTECTED]


Re: adsl/pppoe no longer connecting on 5.1

2003-06-11 Thread Kris Kennaway
On Wed, Jun 11, 2003 at 10:34:39PM -0400, Andrew Lankford wrote:
 I'm having trouble with the latest build of -CURRENT as well.  Same problem, 
 slightly different symptoms:
 
 Portions of my config file:
 disable ipv6
 deny pap
 
 set device PPPoE:xl0
 
 ...produce this in the log (repeatedly):

Can you try backing out bsd.sys.mk to r1.26 and rebuild your world and
kernel?  Later versions of this file are causing strange problems with
package builds.

Kris


pgp0.pgp
Description: PGP signature


Re: adsl/pppoe no longer connecting on 5.1

2003-06-11 Thread Daniel O'Connor
On Thu, 12 Jun 2003 12:04, Andrew Lankford wrote:
 I'm having trouble with the latest build of -CURRENT as well.  Same
 problem, slightly different symptoms:

 Portions of my config file:
 disable ipv6
 deny pap

 set device PPPoE:xl0

 ...produce this in the log (repeatedly):

  Jun 11 22:00:14 bogushost2 ppp[222]: Warning:  Unexpected node type
 ``socket'' (wanted ``ether'') Jun 11 22:00:14 bogushost2 ppp[222]: Warning:
 deflink: PPPoE: unknown host Jun 11 22:00:14 bogushost2 ppp[222]: Warning:
 deflink: PPPoE: unknown host Jun 11 22:00:14 bogushost2 ppp[222]: Warning:
 deflink: Device (PPPoE:xl0) must egin with a '/', a '!' or contain at least
 one ':' Jun 11 22:00:14 bogushost2 ppp[222]: Phase: deflink: Enter pause
 (2) for redialing.

 Bloody irritating.

Are all of the lines except labels prefixed with a space?

eg.

default:
 set openmode active

foo:
 set device PPPoE:xl0
 set authname xyz
 set authkey abc

If you don't have the spaces I thnk the parser chokes on the : for PPPoE..

-- 
Daniel O'Connor software and network engineer
for Genesis Software - http://www.gsoft.com.au
The nice thing about standards is that there
are so many of them to choose from.
  -- Andrew Tanenbaum
GPG Fingerprint - 9A8C 569F 685A D928 5140  AE4B 319B 41F4 5D17 FDD5

___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to [EMAIL PROTECTED]


Re: adsl/pppoe no longer connecting on 5.1

2003-06-11 Thread Andrew Lankford
Can you try backing out bsd.sys.mk to r1.26 and rebuild your world and
kernel?  Later versions of this file are causing strange problems with package 
builds.

I was a little lazy and just backed out bsd.sys.mk to 1.26 as you suggested, rebuilt 
/usr/lib/ , /usr/include/, and ppp.  My kernel is the same as last time.  As a result, 
ppp's now up and running again.

Thanks for the help.

Andrew Lankford 


 
   
___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to [EMAIL PROTECTED]


Re: adsl/pppoe no longer connecting on 5.1

2003-06-11 Thread Kris Kennaway
On Wed, Jun 11, 2003 at 10:48:32PM -0600, Andrew Lankford wrote:
 Can you try backing out bsd.sys.mk to r1.26 and rebuild your world and
 kernel?  Later versions of this file are causing strange problems with package 
 builds.
 
 I was a little lazy and just backed out bsd.sys.mk to 1.26 as you suggested, rebuilt 
 /usr/lib/ , /usr/include/, and ppp.  My kernel is the same as last time.  As a 
 result, ppp's now up and running again.

Thanks, that's actually more useful because it isolates the problem.
It's probably something in ppp that is misbehaving with CSTD=c99.

Kris


pgp0.pgp
Description: PGP signature


Re: adsl/pppoe no longer connecting on 5.1

2003-06-11 Thread Andrew Lankford
Thanks, that's actually more useful because it isolates the problem.
It's probably something in ppp that is misbehaving with CSTD=c99.


True.  A simple rebuild of ppp (without libc, etc.) didn't change anything.

Andrew Lankford 


 
   
___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to [EMAIL PROTECTED]


Re: adsl/pppoe no longer connecting on 5.1

2003-06-11 Thread Wiktor Niesiobedzki
On Wed, Jun 11, 2003 at 09:50:22PM -0700, Kris Kennaway wrote:
 On Wed, Jun 11, 2003 at 10:48:32PM -0600, Andrew Lankford wrote:
  Can you try backing out bsd.sys.mk to r1.26 and rebuild your world and
  kernel?  Later versions of this file are causing strange problems with
  package builds.
  
  I was a little lazy and just backed out bsd.sys.mk to 1.26 as you
  suggested, rebuilt /usr/lib/ , /usr/include/, and ppp.  My kernel is the
  same as last time.  As a result, ppp's now up and running again.
 
 Thanks, that's actually more useful because it isolates the problem.
 It's probably something in ppp that is misbehaving with CSTD=c99.
 
alloca(3) function is misbehaving in ppp (namely ether.c). Is this a compiler
bug?

Cheers,

Wiktor Niesiobedzki
___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to [EMAIL PROTECTED]


Re: adsl/pppoe no longer connecting on 5.1

2003-06-11 Thread Kris Kennaway
On Thu, Jun 12, 2003 at 07:18:12AM +0200, Wiktor Niesiobedzki wrote:
 On Wed, Jun 11, 2003 at 09:50:22PM -0700, Kris Kennaway wrote:
  On Wed, Jun 11, 2003 at 10:48:32PM -0600, Andrew Lankford wrote:
   Can you try backing out bsd.sys.mk to r1.26 and rebuild your world and
   kernel?  Later versions of this file are causing strange problems with
   package builds.
   
   I was a little lazy and just backed out bsd.sys.mk to 1.26 as you
   suggested, rebuilt /usr/lib/ , /usr/include/, and ppp.  My kernel is the
   same as last time.  As a result, ppp's now up and running again.
  
  Thanks, that's actually more useful because it isolates the problem.
  It's probably something in ppp that is misbehaving with CSTD=c99.
  
 alloca(3) function is misbehaving in ppp (namely ether.c). Is this a compiler
 bug?

alloca() is not being inlined when -std is specified.  It is possible
there's a bug in the libc implementation.  I'm also suspicious that
some of the ppp data structures have changed size or alignment which
could be confusing netgraph.

Kris


pgp0.pgp
Description: PGP signature


Re: adsl/pppoe no longer connecting on 5.1

2003-06-11 Thread Tim Robbins
On Thu, Jun 12, 2003 at 07:18:12AM +0200, Wiktor Niesiobedzki wrote:

 On Wed, Jun 11, 2003 at 09:50:22PM -0700, Kris Kennaway wrote:
  On Wed, Jun 11, 2003 at 10:48:32PM -0600, Andrew Lankford wrote:
   Can you try backing out bsd.sys.mk to r1.26 and rebuild your world and
   kernel?  Later versions of this file are causing strange problems with
   package builds.
   
   I was a little lazy and just backed out bsd.sys.mk to 1.26 as you
   suggested, rebuilt /usr/lib/ , /usr/include/, and ppp.  My kernel is the
   same as last time.  As a result, ppp's now up and running again.
  
  Thanks, that's actually more useful because it isolates the problem.
  It's probably something in ppp that is misbehaving with CSTD=c99.
  
 alloca(3) function is misbehaving in ppp (namely ether.c). Is this a compiler
 bug?

Misbehaving in what way? CSTD=c99 causes gcc to use alloca() from libc instead
of its builtin version. Perhaps alloca() in libc is broken -- any bugs in it
would have been covered up by gcc until now.


Tim
___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to [EMAIL PROTECTED]