Re: can't boot with twe anymore.
In message [EMAIL PROTECTED], Alfred Perlstein writes:
Poul-Henning you promised me a patch two nights ago within a couple
of hours It's now going on the 36th hour since.
Yeah, well, I didn't calculate with being hit by influenze :-(
Can you try this one:
Index: twe_compat.h
===
RCS file: /home/ncvs/src/sys/dev/twe/twe_compat.h,v
retrieving revision 1.6
diff -u -r1.6 twe_compat.h
--- twe_compat.h8 Mar 2003 08:01:30 - 1.6
+++ twe_compat.h15 Mar 2003 09:48:46 -
@@ -166,7 +166,7 @@
# define TWE_BIO_LENGTH(bp)(bp)-bio_bcount
# define TWE_BIO_LBA(bp) (bp)-bio_pblkno
# define TWE_BIO_SOFTC(bp) (bp)-bio_disk-d_drv1
-# define TWE_BIO_UNIT(bp) (bp)-bio_disk-d_unit
+# define TWE_BIO_UNIT(bp) (((struct twed_softc
*)TWE_BIO_SOFTC(bp))-twed_drive-td_unit)
# define TWE_BIO_SET_ERROR(bp, err)do { (bp)-bio_error = err; (bp)-bio_flags |=
BIO_ERROR;} while(0)
# define TWE_BIO_HAS_ERROR(bp) ((bp)-bio_flags BIO_ERROR)
# define TWE_BIO_RESID(bp) (bp)-bio_resid
--
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
[EMAIL PROTECTED] | TCP/IP since RFC 956
FreeBSD committer | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.
To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message
Re: can't boot with twe anymore.
In message [EMAIL PROTECTED], Alfred Perlstein writes:
Poul-Henning you promised me a patch two nights ago within a couple
of hours It's now going on the 36th hour since.
Ok, 2nd try, this even compiles:
Index: twe_compat.h
===
RCS file: /home/ncvs/src/sys/dev/twe/twe_compat.h,v
retrieving revision 1.6
diff -u -r1.6 twe_compat.h
--- twe_compat.h8 Mar 2003 08:01:30 - 1.6
+++ twe_compat.h15 Mar 2003 09:58:06 -
@@ -166,7 +166,7 @@
# define TWE_BIO_LENGTH(bp)(bp)-bio_bcount
# define TWE_BIO_LBA(bp) (bp)-bio_pblkno
# define TWE_BIO_SOFTC(bp) (bp)-bio_disk-d_drv1
-# define TWE_BIO_UNIT(bp) (bp)-bio_disk-d_unit
+# define TWE_BIO_UNIT(bp) *(int *)(bp-bio_driver1)
# define TWE_BIO_SET_ERROR(bp, err)do { (bp)-bio_error = err; (bp)-bio_flags |=
BIO_ERROR;} while(0)
# define TWE_BIO_HAS_ERROR(bp) ((bp)-bio_flags BIO_ERROR)
# define TWE_BIO_RESID(bp) (bp)-bio_resid
Index: twe_freebsd.c
===
RCS file: /home/ncvs/src/sys/dev/twe/twe_freebsd.c,v
retrieving revision 1.24
diff -u -r1.24 twe_freebsd.c
--- twe_freebsd.c 8 Mar 2003 08:01:30 - 1.24
+++ twe_freebsd.c 15 Mar 2003 09:57:24 -
@@ -607,6 +607,7 @@
debug_called(4);
+bp-bio_driver1 = sc-twed_drive-td_unit;
TWED_BIO_IN;
/* bogus disk? */
--
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
[EMAIL PROTECTED] | TCP/IP since RFC 956
FreeBSD committer | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.
To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message
Re: can't boot with twe anymore.
* Poul-Henning Kamp [EMAIL PROTECTED] [030315 01:59] wrote:
In message [EMAIL PROTECTED], Alfred Perlstein writes:
Poul-Henning you promised me a patch two nights ago within a couple
of hours It's now going on the 36th hour since.
Ok, 2nd try, this even compiles:
That looks like it might work, but doesn't it work around instead
of fix the problem you found where twe does sparse unit assignment?
Index: twe_compat.h
===
RCS file: /home/ncvs/src/sys/dev/twe/twe_compat.h,v
retrieving revision 1.6
diff -u -r1.6 twe_compat.h
--- twe_compat.h 8 Mar 2003 08:01:30 - 1.6
+++ twe_compat.h 15 Mar 2003 09:58:06 -
@@ -166,7 +166,7 @@
# define TWE_BIO_LENGTH(bp) (bp)-bio_bcount
# define TWE_BIO_LBA(bp) (bp)-bio_pblkno
# define TWE_BIO_SOFTC(bp) (bp)-bio_disk-d_drv1
-# define TWE_BIO_UNIT(bp)(bp)-bio_disk-d_unit
+# define TWE_BIO_UNIT(bp)*(int *)(bp-bio_driver1)
# define TWE_BIO_SET_ERROR(bp, err) do { (bp)-bio_error = err; (bp)-bio_flags |=
BIO_ERROR;} while(0)
# define TWE_BIO_HAS_ERROR(bp) ((bp)-bio_flags BIO_ERROR)
# define TWE_BIO_RESID(bp) (bp)-bio_resid
Index: twe_freebsd.c
===
RCS file: /home/ncvs/src/sys/dev/twe/twe_freebsd.c,v
retrieving revision 1.24
diff -u -r1.24 twe_freebsd.c
--- twe_freebsd.c 8 Mar 2003 08:01:30 - 1.24
+++ twe_freebsd.c 15 Mar 2003 09:57:24 -
@@ -607,6 +607,7 @@
debug_called(4);
+bp-bio_driver1 = sc-twed_drive-td_unit;
TWED_BIO_IN;
/* bogus disk? */
--
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
[EMAIL PROTECTED] | TCP/IP since RFC 956
FreeBSD committer | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.
--
-Alfred Perlstein [EMAIL PROTECTED]
'Instead of asking why a piece of software is using 1970s technology,
start asking why software is ignoring 30 years of accumulated wisdom.'
To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message
Re: can't boot with twe anymore.
In message [EMAIL PROTECTED], Alfred Perlstein writes: * Poul-Henning Kamp [EMAIL PROTECTED] [030315 01:59] wrote: In message [EMAIL PROTECTED], Alfred Perlstein writes: Poul-Henning you promised me a patch two nights ago within a couple of hours It's now going on the 36th hour since. Ok, 2nd try, this even compiles: That looks like it might work, but doesn't it work around instead of fix the problem you found where twe does sparse unit assignment? It should make the driver work exactly like before, which IMO was slightly bogus, if that was what you were asking :-) -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 [EMAIL PROTECTED] | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: can't boot with twe anymore.
* Poul-Henning Kamp [EMAIL PROTECTED] [030315 04:09] wrote: In message [EMAIL PROTECTED], Alfred Perlstein writes: * Poul-Henning Kamp [EMAIL PROTECTED] [030315 01:59] wrote: In message [EMAIL PROTECTED], Alfred Perlstein writes: Poul-Henning you promised me a patch two nights ago within a couple of hours It's now going on the 36th hour since. Ok, 2nd try, this even compiles: That looks like it might work, but doesn't it work around instead of fix the problem you found where twe does sparse unit assignment? It should make the driver work exactly like before, which IMO was slightly bogus, if that was what you were asking :-) I'm not sure I understand, but I just tested this. It works. Thanks for getting back to me and I hope you're feeling better. -- -Alfred Perlstein [EMAIL PROTECTED] 'Instead of asking why a piece of software is using 1970s technology, start asking why software is ignoring 30 years of accumulated wisdom.' To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: can't boot with twe anymore.
Poul-Henning you promised me a patch two nights ago within a couple of hours It's now going on the 36th hour since. I spent several hours trying to figure out what went wrong, gave you what I figure to be good feedback and hints as to what's broken. Is there anything else I can do to get my box booting? I will be attempting to figure this out on my own now, but this pretty irritating. * Alfred Perlstein [EMAIL PROTECTED] [030312 22:52] wrote: I can't boot with twe now. I wind up calling into device_printf with a NULL dev_t which used to crash me until my most recent commit. Now I get: unknown0: controller error - unit not available (flags = 0x0) twe0: AEN: drive error for unknown unit 0 A kernel from Feb 14th seems fine. Please fix. To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: can't boot with twe anymore.
FreeBSD is a free software. You have no right to make any claims or force developers to do something to fit your needs (did you read BSD license?). If it's used to work fine but currently broken, it will be fixed. Also you're always welcome to fix it yourself. By installing -CURRENT, you agree that things like those you've described may happen, otherwise you should consider -STABLE. Meanwhile, reboot to working kernel. --- Regards, Rhett Alfred Perlstein wrote: Poul-Henning you promised me a patch two nights ago within a couple of hours It's now going on the 36th hour since. I spent several hours trying to figure out what went wrong, gave you what I figure to be good feedback and hints as to what's broken. Is there anything else I can do to get my box booting? I will be attempting to figure this out on my own now, but this pretty irritating. * Alfred Perlstein [EMAIL PROTECTED] [030312 22:52] wrote: I can't boot with twe now. I wind up calling into device_printf with a NULL dev_t which used to crash me until my most recent commit. Now I get: unknown0: controller error - unit not available (flags = 0x0) twe0: AEN: drive error for unknown unit 0 A kernel from Feb 14th seems fine. Please fix. __ Do you Yahoo!? Yahoo! Web Hosting - establish your business online http://webhosting.yahoo.com To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: can't boot with twe anymore.
On Fri, 14 Mar 2003, Rhett Monteg Hollander wrote: FreeBSD is a free software. You have no right to make any claims or force developers to do something to fit your needs (did you read BSD license?). If it's used to work fine but currently broken, it will be fixed. Also you're always welcome to fix it yourself. By installing -CURRENT, you agree that things like those you've described may happen, otherwise you should consider -STABLE. Dude. You should A) Develop an awareness of who you're talking to. B) Restrict your desire to rebuke people to private e-mail. -- This .signature sanitized for your protection To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
