Anybody want to review vi patch?
There's a bug in nvi 1.79. The options "noprint", "print", and
"octal" don't work properly. When these options are changed, the
routine that evaluates them is called before the option has been
set.
Do we have any people who know their way around the guts of nvi?
I've appended a patch, partly based on a change in nvi 1.81 where
this is fixed incompletely, and I'd like somebody to review this.
--
Christian "naddy" Weisgerber [EMAIL PROTECTED]
diff -ur /usr/src/contrib/nvi/common/options.c nvi/common/options.c
--- /usr/src/contrib/nvi/common/options.c Sat Apr 19 01:36:33 1997
+++ nvi/common/options.cSat Oct 21 13:06:06 2000
@@ -132,7 +132,7 @@
/* O_NUMBER4BSD */
{"number", f_reformat, OPT_0BOOL, 0},
/* O_OCTAL 4.4BSD */
- {"octal", f_print,OPT_0BOOL, 0},
+ {"octal", f_octal,OPT_0BOOL, 0},
/* O_OPEN 4BSD */
{"open",NULL, OPT_1BOOL, 0},
/* O_OPTIMIZE 4BSD */
diff -ur /usr/src/contrib/nvi/common/options_f.c nvi/common/options_f.c
--- /usr/src/contrib/nvi/common/options_f.c Fri Nov 1 07:45:38 1996
+++ nvi/common/options_f.c Sat Oct 21 13:11:14 2000
@@ -190,6 +190,34 @@
char *str;
u_long *valp;
{
+ /* Preset the value, needed for reinitialization of lookup table. */
+ if (o_set(sp, op-sp-opts, OS_STRDUP, str, 0))
+ return(1);
+
+ /* Reinitialize the key fast lookup table. */
+ v_key_ilookup(sp);
+
+ /* Reformat the screen. */
+ F_SET(sp, SC_SCR_REFORMAT);
+ return (0);
+}
+
+/*
+ * PUBLIC: int f_octal __P((SCR *, OPTION *, char *, u_long *));
+ */
+int
+f_octal(sp, op, str, valp)
+ SCR *sp;
+ OPTION *op;
+ char *str;
+ u_long *valp;
+{
+ /* Preset the value, needed for reinitialization of lookup table. */
+ if (*valp)
+ O_CLR(sp, op - sp-opts);
+ else
+ O_SET(sp, op - sp-opts);
+
/* Reinitialize the key fast lookup table. */
v_key_ilookup(sp);
diff -ur /usr/src/contrib/nvi/include/com_extern.h nvi/include/com_extern.h
--- /usr/src/contrib/nvi/include/com_extern.h Fri Nov 1 07:45:31 1996
+++ nvi/include/com_extern.hSat Oct 21 13:05:53 2000
@@ -157,6 +157,7 @@
int f_msgcat __P((SCR *, OPTION *, char *, u_long *));
int f_paragraph __P((SCR *, OPTION *, char *, u_long *));
int f_print __P((SCR *, OPTION *, char *, u_long *));
+int f_octal __P((SCR *, OPTION *, char *, u_long *));
int f_readonly __P((SCR *, OPTION *, char *, u_long *));
int f_recompile __P((SCR *, OPTION *, char *, u_long *));
int f_reformat __P((SCR *, OPTION *, char *, u_long *));
Re: Routing issue with cable modem
Ok, I tried tcpdump, and it's reporting the same malformed MAC and same erroneous protocol type. I guess that means, that the packets are trully bad... correct ? I will try rebuilding my kernel once again. I would like to track this problem to the source, I guess stdlib is where I would find the basic functions the build packets and throw them onto the net. I would appreciate any help as to which files/subroutines I should look into. Also, would be great to get some help from someone that knows their way around core system sources :) (I've never been there before) Tony Fleisher wrote: Hello, Have you perhaps updated to a new kernel since you installed ethereal? I seem to recall seing similiar situations to this when some data structures changed sizes. Is "/usr/sbin/tcpdump -e" showing this same MAC address corruption you describe? If not, I would recommend rebuilding ethereal. TOny. On Fri, 20 Oct 2000, Marko Ruban wrote: New issue seems to be at hand... I set the alias for the interface to be the gateway IP (10.17.56.12), and then I was able to add that as my default gateway. Not sure why aliasing wouldn't work with 10.17.56.11 or some other IP in that subnet. I tried to ping the DNS server after that, and watched hundreds of corrupt packets get sent out with no replies. So my new question is, which part of the system actually builds the packets ? Any way to debug or log that process ? Here's an example taken from ethereal output (view with proportional font) - Frame 6 (102 on wire, 102 captured) Arrival Time: Oct 20, 2000 16:42:38.2715 Time delta from previous packet: 0.71 seconds Frame Number: 6 Packet Length: 102 bytes Capture Length: 102 bytes Ethernet II Destination: 02:00:00:00:52:54 (02:00:00:00:52:54) Source: 05:f4:21:3f:52:54 (05:f4:21:3f:52:54) Type: Unknown (0x05f4) Data (88 bytes) 0 0200 5254 05f4 213f 5254 05f4 213f RT..!?RT..!? 10 0800 4500 0054 13fa fa01 97dc 0a11 ..E..T.. 20 380c cfac 0309 0800 c1f0 6101 3eae 8.a 30 f039 b722 0400 0809 0a0b 0c0d 0e0f 1011 .9." 40 1213 1415 1617 1819 1a1b 1c1d 1e1f 2021 .. ! 50 2223 2425 2627 2829 2a2b 2c2d 2e2f 3031 "#$%'()*+,-./01 60 3233 3435 3637234567 - Why I think this packet is malformed. First of all, protocol type Unknown (0x05f4) looks definitely bad. Secondly, protocol type looks like part of my NICs MAC address (52:54:05:f4:21:3f according to ifconfig, which translates into hex: 0x5254 05f4 213f). Thirdly, source address decoded by ethereal (and probably by any other packet processor) is wrong (first two bytes are carried over to the other side). Now, keeping all that in mind, lets do a pattern match on the REAL MAC address in hex dump of the packet. HEY, the source address actually starts four bytes later than it should, thus shifting the TRUE protocol type (0x0800 = IP) as well. First six bytes are the destination MAC, then come the EVIL 4 bytes, followed by 6 bytes of source MAC. I don't know what's going on, but looks pretty bad, yet simple on the hex level :) Any ideas ? To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-hackers" in the body of the message To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-questions" in the body of the message To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-hackers" in the body of the message
Re: Anybody want to review vi patch?
Do we have any people who know their way around the guts of nvi? I've appended a patch, partly based on a change in nvi 1.81 where this is fixed incompletely, and I'd like somebody to review this. I've forwarded this message to Keith Bostic since nobody would know better than he. :) - Jordan To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-hackers" in the body of the message
can't build custom kernel
Hackers, Sorry to bother, but two postings to -question of the msg below in two days got now response. I'm dead in the water. tia, Len FreeBSD 4.1.1 from an .iso image Making a custom kernal make depend gives: In file included from ../../i386/isa/isa_compat.c:46: ../../i386/isa/isa_compat.h:42: bw.h: No such file or directory mkdep: compile failed *** Error code 1 I cannot find / -name "bw.h" -print ... this file on our disk. Nor can I find "bw.h" in my -questions archive as a pb for anybody else. What's up? tia, Len http://BIND8NT.MEIway.com: ISC BIND 8.2.2 p5 8.2.3 T6B for NT4 W2K http://IMGate.MEIway.com: Build free, hi-perf, anti-spam mail gateways To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-hackers" in the body of the message
Re: Getting Linux NIS to work with FreeBSD NIS servers
On Sun, 15 Oct 2000, Stephen Hocking wrote: The Linux box appears toknow about the users, it just cant get the passwords right - something tickles my mind about DES vs MD5, is this the case, and how do I convert my MD5 passwords if needed? Not needed. Configure both machines to use the same crypt for the passwords. (for linux it should be nothing more than editing the right file in /etc/pam.d/ and regenerating the passwords for all "local" users) regards, Rik -- "What you're running that piece of shit Gnome?!?!" -- Miguel de Icaza, UKUUG 2000 http://www.conectiva.com/ http://www.surriel.com/ To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-hackers" in the body of the message
Re: can't build custom kernel
On Sat, 21 Oct 2000, Len Conrad wrote: Hackers, Sorry to bother, but two postings to -question of the msg below in two days got now response. I'm dead in the water. First thing: read /usr/src/UPDATING. The proper procedure to build a kernel is in there. To save you some time: cd /usr/src make buildkernel KERNEL=your kernel name make installkernel KERNEL=your kernel name If the build still fails, then yes, you have a legitimate problem. -- Chris BeHanna Software Engineer (at yourfit.com) [EMAIL PROTECTED] To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-hackers" in the body of the message
Re: FreeBSD vs. Linux
Hi! We need this information in order to determine which of these two OS to choose from to drive our website. Choose FreeBSD. It's faster. Also if some things don't work or work strangely or are poorly documented, finding sources for them is MUCH easier in FreeBSD. Linux Huh?! What's strange in FreeBSD? -- Best Regards, Freddy = Frederik Meerwaldt ICQ: 83045387 Homepage: http://www.freddym.org Bavaria/Germany OpenVMS and Unix Howtos and much more FREEBSD, NETBSD, OPENBSD, TRU64, OPENVMS, ULTRIX, BEOS, LINUX To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-hackers" in the body of the message
Re: FreeBSD vs. Linux
Frederik Meerwaldt wrote: We need this information in order to determine which of these two OS to choose from to drive our website. Choose FreeBSD. It's faster. Also if some things don't work or work strangely or are poorly documented, finding sources for them is MUCH easier in FreeBSD. Linux is a patchwork of independent packages, and tracking down what came from where and was patched by what is usually not easy. Also commercial distributions of Linux sometimes tend to "lose" parts of sources, so that you will not always be able to re-compile the stuff at all. There's been a short period when I worked on building a Linux distribution and that was a quite special experience. I you would want to get a Linux after all I would strongly recommend getting a free distribution like Debian or Slackware. -SB To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-hackers" in the body of the message
Re: can't build custom kernel
Len Conrad wrote: Hackers, Sorry to bother, but two postings to -question of the msg below in two days got now response. I'm dead in the water. tia, Len FreeBSD 4.1.1 from an .iso image Making a custom kernal make depend gives: In file included from ../../i386/isa/isa_compat.c:46: ../../i386/isa/isa_compat.h:42: bw.h: No such file or directory mkdep: compile failed *** Error code 1 Your sources are corrupt. There has never been a 'bw.h' file in the FreeBSD tree. How did you install the sources? You might want to delete them and install a fresh set with cvsup. Take a look at http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/i386/isa/Attic/isa_compat.h?rev=1.27.2.6content-type=text/x-cvsweb-markup for the current version of this file in RELENG_4. Good luck, Doug -- "The dead cannot be seduced." - Kai, "Lexx" Do YOU Yahoo!? To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-hackers" in the body of the message
Re: can't build custom kernel
Your sources are corrupt. There has never been a 'bw.h' file in the FreeBSD tree. How did you install the sources? from 4.1.1-R .iso image from ftp.de.freebsd.org You might want to delete them and install a fresh set with cvsup. [EMAIL PROTECTED] has since told me his etinc drivers don't work with 4.1.1 so I've got to drop back to 4.1, for which I have the .iso on cdrom. Good luck, thanks, an fbsd airhead like me needs it. First time I've been bitten by an .iso image. Len http://BIND8NT.MEIway.com: ISC BIND 8.2.2 p5 8.2.3 T6B for NT4 W2K http://IMGate.MEIway.com: Build free, hi-perf, anti-spam mail gateways To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-hackers" in the body of the message
Re: FreeBSD vs. Linux
On Sat, 21 Oct 2000, Frederik Meerwaldt wrote: -Differences... FreeBSD is a real Unix, while Linux is a ..how should I Hmmm. FreeBSD is not a UNIX, rather it's a UNIX alike OS. (Which really doesn't matter IMHO) Don't forget UNIX is a trademark of Open Group. -say... semi Unix. IMHO FreeBSD ist lots faster than Linux, as I had Linux -on my server before, and when I changed to FreeBSD everything ran faster. To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-hackers" in the body of the message
Re: FreeBSD vs. Linux
FengYue wrote: On Sat, 21 Oct 2000, Frederik Meerwaldt wrote: -Differences... FreeBSD is a real Unix, while Linux is a ..how should I Hmmm. FreeBSD is not a UNIX, rather it's a UNIX alike OS. (Which really doesn't matter IMHO) Don't forget UNIX is a trademark of Open Group. I believe a correct and true statement is "FreeBSD is a direct decendant of Unix(TM). Based on the BSD sources" Jim -- [EMAIL PROTECTED] http://www.FreeBSD.org The Power to Serve [EMAIL PROTECTED] http://www.TheHousleys.net - If it happens once, it's a bug. If it happens twice, it's a feature. If it happens more than twice, it's windows. -- Luiz de Barros To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-hackers" in the body of the message
Problem...
Hello! I try to use hfsutils - program for accessing Macintosh HFS floppy disks and CDROm's and when I try to run hmount /dev/cd0a I have SCSI CDROM I receive dscheck(#cd/0): b_bcount 512 is not on a sector boundary (ssize 2048) What is the matter is my CD bad or smth else, may be I bad understood help... Thank you very much for your help... To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-hackers" in the body of the message
