Re: OpenPAM and OSVERSION

2003-02-10 Thread Dag-Erling Smorgrav
Sergey Matveychuk [EMAIL PROTECTED] writes:
 What is OSVERSION num right after OpenPAM implemented?

What problem are you trying to solve?

DES
-- 
Dag-Erling Smorgrav - [EMAIL PROTECTED]

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-hackers in the body of the message



Re: OpenPAM and OSVERSION

2003-02-10 Thread Sergey Matveychuk
 Sergey Matveychuk [EMAIL PROTECTED] writes:
  What is OSVERSION num right after OpenPAM implemented?
 
 What problem are you trying to solve?

security/pam-* ports.
I'v fiexed pam-mysql for this time. It's works for me. I'm working for PR.


Sem.

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-hackers in the body of the message



Re: OpenPAM and OSVERSION

2003-02-10 Thread Dag-Erling Smorgrav
Sergey Matveychuk [EMAIL PROTECTED] writes:
   What is OSVERSION num right after OpenPAM implemented?
  What problem are you trying to solve?
 security/pam-* ports.
 I'v fiexed pam-mysql for this time. It's works for me. I'm working for PR.

If you've fixed it in a way which requires knowing whether the system
runs Linux-PAM or OpenPAM, you've fixed it wrong.

DES
-- 
Dag-Erling Smorgrav - [EMAIL PROTECTED]

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-hackers in the body of the message



Re: OpenPAM and OSVERSION

2003-02-10 Thread Sergey Matveychuk
 If you've fixed it in a way which requires knowing whether the system
 runs Linux-PAM or OpenPAM, you've fixed it wrong.

OK. Why?
What fix will be a right one?

My strategy is checking OSVERSION when build port and aplay a patch if it's
5.0+.


Sem.



To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-hackers in the body of the message



Re: OpenPAM and OSVERSION

2003-02-10 Thread Dag-Erling Smorgrav
Sergey Matveychuk [EMAIL PROTECTED] writes:
  If you've fixed it in a way which requires knowing whether the system
  runs Linux-PAM or OpenPAM, you've fixed it wrong.
 OK. Why?

Because most PAM problems in ports are bugs in the ports themselves,
which Linux-PAM just happens to tolerate and OpenPAM doesn't.  In
other words, it should be possible to find a solution to the problem
which works equally well for Linux-PAM and OpenPAM, without the need
to know which is which.  And as a last resort, you can make OpenPAM-
specific code conditional on the _OPENPAM preprocessor symbol.

 What fix will be a right one?

I can't tell you unless you show me what you believe needs fixing.

DES
-- 
Dag-Erling Smorgrav - [EMAIL PROTECTED]

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-hackers in the body of the message



Re: OpenPAM and OSVERSION

2003-02-10 Thread Sergey Matveychuk
 Because most PAM problems in ports are bugs in the ports themselves,
 which Linux-PAM just happens to tolerate and OpenPAM doesn't.  In
 other words, it should be possible to find a solution to the problem
 which works equally well for Linux-PAM and OpenPAM, without the need
 to know which is which.  And as a last resort, you can make OpenPAM-
 specific code conditional on the _OPENPAM preprocessor symbol.

No difference for port's user how source is change. Either a patch will
apply for 5.0 only when port build or general pach where PAM version detects
with preprocessor directives. Result code will be the same.
I think it's a style question. What the community opinion?

  What fix will be a right one?

 I can't tell you unless you show me what you believe needs fixing.

What a right way escape from PAM_CONV_AGAIN/PAM_TRY_AGAIN and relate code
from LINUX_PAM?


Sem.



To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-hackers in the body of the message



Re: OpenPAM and OSVERSION

2003-02-10 Thread Dag-Erling Smorgrav
Sergey Matveychuk [EMAIL PROTECTED] writes:
 What a right way escape from PAM_CONV_AGAIN/PAM_TRY_AGAIN and relate code
 from LINUX_PAM?

Shoot the module author for using it, and Andrew Morgan (Linux-PAM
author) for inventing it.

DES
-- 
Dag-Erling Smorgrav - [EMAIL PROTECTED]

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-hackers in the body of the message



Re: OpenPAM and OSVERSION

2003-02-09 Thread Doug Barton
On Mon, 10 Feb 2003, Sergey Matveychuk wrote:

 What is OSVERSION num right after OpenPAM implemented?

The easiest way to answer this for yourself is to search the cvs logs to
find when openpam was implemented, then search
http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/sys/param.h for the closest
match.

HTH,

Doug

-- 

The last time France wanted more evidence, it rolled right
through Paris with a German flag. - David Letterman

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-hackers in the body of the message