Re: [RFC] databases/mariadb55-{server|client} ports
Alexandr Kovalenko ha scritto: > Basically I'm for having both mysql and mariadb ports semi-identical - > have same install layouts, so if you feel that layout you are using in > mysql55-* is better - it is easy to fix so that mariadb55 will > resemble it. I don't say it's better in absolute terms, I say it's like in linux distros, so we are giving a coherent and consistent behavior. It's a tradeoff. > P.S. I've also noticed that you have .conf file in > "bin/mysqlaccess.conf" in mysql55-client - was that intentional? > Shouldn't it be placed somewhere like /usr/local/etc ? The reason is exactly the same as before, but yes, in this particular case it may not be the best decision (probably not installing it at all would be better). -- Alex Dupre ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: [RFC] databases/mariadb55-{server|client} ports
On Mon, Dec 24, 2012 at 10:24 PM, Alexandr Kovalenko wrote: > On Mon, Dec 24, 2012 at 8:05 PM, Alex Dupre wrote: >>> Thanks for noticing this. I'll submit another PR after this one is >>> commited to remove those headers from -client and add to -server, will >>> also re-add libmysqlservices.a to -server together with headers. >> >> >> Why are you going to hack the mariadb ports is such way? The MySQL 5.5 ports >> are so for a reason. From the original commit log: >> >> - new installation layout, resembling RPM packages: >> - client = Client Utilities + Development Libraries + Shared components >> - server = MySQL Server + Embedded > > I've asked MariaDB developers about that and they advised that > libmysqlservices (and appropriate header files) are server development > part. > Plugins which need libmysqlservices are server plugins. There is > separate type of plugins which are client plugins, which have nothing > to do with libmysqlservices. > > Basically I'm for having both mysql and mariadb ports semi-identical - > have same install layouts, so if you feel that layout you are using in > mysql55-* is better - it is easy to fix so that mariadb55 will > resemble it. > > P.S. I've also noticed that you have .conf file in > "bin/mysqlaccess.conf" in mysql55-client - was that intentional? > Shouldn't it be placed somewhere like /usr/local/etc ? Alex, just for my information - are you willing to commit my PR or we are just discussing common problems of our 2 (4) ports? If yes - could you please commit this version and later we'll find a way to agree on pkg-plists and either me or you (depends on which port should be fixed) will submit PR/commit fix? Thanks. -- Alexandr Kovalenko ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: [RFC] databases/mariadb55-{server|client} ports
On Mon, Dec 24, 2012 at 8:05 PM, Alex Dupre wrote: >> Thanks for noticing this. I'll submit another PR after this one is >> commited to remove those headers from -client and add to -server, will >> also re-add libmysqlservices.a to -server together with headers. > > > Why are you going to hack the mariadb ports is such way? The MySQL 5.5 ports > are so for a reason. From the original commit log: > > - new installation layout, resembling RPM packages: > - client = Client Utilities + Development Libraries + Shared components > - server = MySQL Server + Embedded I've asked MariaDB developers about that and they advised that libmysqlservices (and appropriate header files) are server development part. Plugins which need libmysqlservices are server plugins. There is separate type of plugins which are client plugins, which have nothing to do with libmysqlservices. Basically I'm for having both mysql and mariadb ports semi-identical - have same install layouts, so if you feel that layout you are using in mysql55-* is better - it is easy to fix so that mariadb55 will resemble it. P.S. I've also noticed that you have .conf file in "bin/mysqlaccess.conf" in mysql55-client - was that intentional? Shouldn't it be placed somewhere like /usr/local/etc ? -- Alexandr Kovalenko ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: [RFC] databases/mariadb55-{server|client} ports
Alexandr Kovalenko ha scritto: Thanks for noticing this. I'll submit another PR after this one is commited to remove those headers from -client and add to -server, will also re-add libmysqlservices.a to -server together with headers. Why are you going to hack the mariadb ports is such way? The MySQL 5.5 ports are so for a reason. From the original commit log: - new installation layout, resembling RPM packages: - client = Client Utilities + Development Libraries + Shared components - server = MySQL Server + Embedded -- Alex Dupre ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: [RFC] databases/mariadb55-{server|client} ports
On Mon, Dec 24, 2012 at 5:44 PM, Alex Dupre wrote: > Alexandr Kovalenko ha scritto: > >> At least it should be installed with server package, not client. > > > It is installed together with headers needed to build plugins. Thanks for noticing this. I'll submit another PR after this one is commited to remove those headers from -client and add to -server, will also re-add libmysqlservices.a to -server together with headers. -- Alexandr Kovalenko ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: [RFC] databases/mariadb55-{server|client} ports
Alexandr Kovalenko ha scritto: At least it should be installed with server package, not client. It is installed together with headers needed to build plugins. -- Alex Dupre ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: [RFC] databases/mariadb55-{server|client} ports
On Mon, Dec 24, 2012 at 10:06 AM, Alex Dupre wrote: > Alexandr Kovalenko ha scritto: > >> Fixed pkg-plist bug with libmysqlservices.a (which, btw, should be >> fixed in mysql55-client too - libmysqlservices.a should not be >> installed in any of packages). > > > Why do you say so? libmysqlservices.a is needed to create plugins. At least it should be installed with server package, not client. -- Alexandr Kovalenko ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: [RFC] databases/mariadb55-{server|client} ports
Alexandr Kovalenko ha scritto: Fixed pkg-plist bug with libmysqlservices.a (which, btw, should be fixed in mysql55-client too - libmysqlservices.a should not be installed in any of packages). Why do you say so? libmysqlservices.a is needed to create plugins. -- Alex Dupre ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: [RFC] databases/mariadb55-{server|client} ports
On Sun, Dec 23, 2012 at 6:09 PM, Alexandr Kovalenko wrote: > On Sun, Dec 23, 2012 at 6:36 AM, Alexandr Kovalenko > wrote: >> I've made attempt to make ports of MariaDB 5.5.x and here my proposed >> version of it. >> Ports were made out of respective mysql55-* ports. They also require >> minor change to Mk/bsd.database.mk >> >> Could you please review and advise if everything is good or something >> should be changed/improved. >> >> http://pastie.org/5567310 > > Fixed pkg-plist bug with libmysqlservices.a (which, btw, should be > fixed in mysql55-client too - libmysqlservices.a should not be > installed in any of packages). Ok, ports/174660 :) -- Alexandr Kovalenko ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: [RFC] databases/mariadb55-{server|client} ports
On Sun, Dec 23, 2012 at 6:36 AM, Alexandr Kovalenko wrote: > I've made attempt to make ports of MariaDB 5.5.x and here my proposed > version of it. > Ports were made out of respective mysql55-* ports. They also require > minor change to Mk/bsd.database.mk > > Could you please review and advise if everything is good or something > should be changed/improved. > > http://pastie.org/5567310 Fixed pkg-plist bug with libmysqlservices.a (which, btw, should be fixed in mysql55-client too - libmysqlservices.a should not be installed in any of packages). http://nevermind.kiev.ua/ports/mariadb55-ports-v2.tgz -- Alexandr Kovalenko ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
[RFC] databases/mariadb55-{server|client} ports
Hello, I've made attempt to make ports of MariaDB 5.5.x and here my proposed version of it. Ports were made out of respective mysql55-* ports. They also require minor change to Mk/bsd.database.mk Could you please review and advise if everything is good or something should be changed/improved. http://pastie.org/5567310 -- Alexandr Kovalenko ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"