Re: Port maintenance
On Tue, 30 Jun 2020 at 09:20, Brandon helsley wrote: > > Okay, I use the nvidia 390 driver and nvidia-xsettings, but they both have no > maintainer. I read all the material about what the responsibilitys are for a > maintainer and I think I can do a couple. I got a message from portscout > about a couple of ports that needed updated. I didn't sign up for any yet but > could start there. How do I set my email address to maintainer? I will begin > soon after I reread the documentation for contributing to ports and maybe ask > a few more questions as they arise. > The usual process is to submit an update (a fix or a version-update) to the port via bugs.freebsd.org. If it has no maintainer and you're willing to adopt it, your update will also change the MAINTAINER in the Makefile. Cheers. -- Jonathan Chen ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: Port maintenance
> On 29. Jun 2020, at 23:20, Brandon helsley > wrote: > > Okay, I use the nvidia 390 driver That one is already maintained by danfe@. > and nvidia-xsettings I only see nvidia-xconfig and nvidia-settings, both which have no maintainer. > , but they both have no maintainer. I read all the material about what the > responsibilitys are for a maintainer and I think I can do a couple. I got a > message from portscout about a couple of ports that needed updated. I didn't > sign up for any yet but could start there. How do I set my email address to > maintainer? Assuming maintainership is done through sending in a patch in form of a PR (the handbook describes this). I would recommend that you first open a few PRs with patches for one or two unmaintained ports, then, once you’re comfortable with the process (and committers are too, especially when it comes to attention to detail), you open a PR to take maintainership. -m ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: Port maintenance
Okay, I use the nvidia 390 driver and nvidia-xsettings, but they both have no maintainer. I read all the material about what the responsibilitys are for a maintainer and I think I can do a couple. I got a message from portscout about a couple of ports that needed updated. I didn't sign up for any yet but could start there. How do I set my email address to maintainer? I will begin soon after I reread the documentation for contributing to ports and maybe ask a few more questions as they arise. > > On Jun 28, 2020 at 4:23yPM, Michael Gmelinwrote: > > > > On 29. Jun 2020, at 00:18, Brandon helsley > wrote: > > > > > > > I'm > getting started reading the porters handbook. I was wondering if I can adopt > a port to practice maintaining one without the experience to keep it properly > updated at first. I'm a little intimidated by contributing and not sure how > best to learn the porters handbook. I guess read it multiple times? > > > Just pick a port that’s unmaintained and that you’re actually using yourself > (ideally on a daily basis). When you do changes, make sure: - it builds > cleanly in poudriere. - it passes portlint. - you follow the porter’s > handbook as good as you can, but without freaking out about it. In case > you’re uncertain, ask questions on this mailing list. Open PRs in bugzilla or > (in the beginning) reviews in phabricator. Committers will help you. Either > it will work, or you will learn. No one will judge you, so no worries. > Cheers, Michael > > > > > > > > > ___ > freebsd-ports@freebsd.org > mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-ports > > To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org" > ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: Port maintenance
> On 29. Jun 2020, at 00:18, Brandon helsley > wrote: > > > > > > > I'm getting started reading the porters handbook. I was wondering if I can > adopt a port to practice maintaining one without the experience to keep it > properly updated at first. I'm a little intimidated by contributing and not > sure how best to learn the porters handbook. I guess read it multiple times? > > Just pick a port that’s unmaintained and that you’re actually using yourself (ideally on a daily basis). When you do changes, make sure: - it builds cleanly in poudriere. - it passes portlint. - you follow the porter’s handbook as good as you can, but without freaking out about it. In case you’re uncertain, ask questions on this mailing list. Open PRs in bugzilla or (in the beginning) reviews in phabricator. Committers will help you. Either it will work, or you will learn. No one will judge you, so no worries. Cheers, Michael > > > > > > > > ___ > freebsd-ports@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-ports > To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org" ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Port maintenance
I'm getting started reading the porters handbook. I was wondering if I can adopt a port to practice maintaining one without the experience to keep it properly updated at first. I'm a little intimidated by contributing and not sure how best to learn the porters handbook. I guess read it multiple times? ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: tk85 Port Maintenance
On 11/15/2012 02:45, Pietro Cerutti wrote: On 2012-Nov-14, 14:52, Joseph a Nagy Jr wrote: snip I'm sorry, I'm not seeing what I'm missing. As I said, PORTREVISION, distinfo, and the patch files. Look them up in the handbook. PORTREVISION: not seeing a problem As for the patch files, if I don't know where they are or what they are or that they exist as for distinfo, if the checksum has changed, fine. That being said, I've lost all the revisions I've made to date. -- Yours in Christ, Joseph A Nagy Jr Whoever loves instruction loves knowledge, But he who hates correction is stupid. -- Proverbs 12:1 Emails are not formal business letters, whatever businesses may want. Original content CopyFree (F) under the OWL http://owl.apotheon.org signature.asc Description: OpenPGP digital signature
Re: tk85 Port Maintenance
On 2012-Nov-14, 14:52, Joseph a Nagy Jr wrote: Off-list On 11/13/12 01:59, Pietro Cerutti wrote: On 2012-Nov-08, 09:12, Joseph a Nagy Jr wrote: On 11/08/12 03:13, Pietro Cerutti wrote: snip By the way, Tcl/Tk 8.5.13 is bound to be released in the next few days (the first RC is out now, actually). You might want to include the update in your diff :) http://pastebin.com/UmasjFfz I fear this won't be enough. There are implications of the update that you're not considering, e.g., PORTREVISION, distinfo, modifications to the patch files, ... I suggest that you take a step back and read the FreeBSD's Porters Handbook [1]. It is very well written and contains a lot of information you cannot do without if you plan to maintain a port. I'm sorry, I'm not seeing what I'm missing. As I said, PORTREVISION, distinfo, and the patch files. Look them up in the handbook. -- Pietro Cerutti The FreeBSD Project g...@freebsd.org PGP Public Key: http://gahr.ch/pgp pgpkkW10QTA4p.pgp Description: PGP signature
Re: tk85 Port Maintenance
On 2012-Nov-08, 09:12, Joseph a Nagy Jr wrote: On 11/08/12 03:13, Pietro Cerutti wrote: snip By the way, Tcl/Tk 8.5.13 is bound to be released in the next few days (the first RC is out now, actually). You might want to include the update in your diff :) http://pastebin.com/UmasjFfz I fear this won't be enough. There are implications of the update that you're not considering, e.g., PORTREVISION, distinfo, modifications to the patch files, ... I suggest that you take a step back and read the FreeBSD's Porters Handbook [1]. It is very well written and contains a lot of information you cannot do without if you plan to maintain a port. I'll be submitting a patch for the update to 8.5.13 (was released earlier today) shortly. Thanks, [1] http://www.freebsd.org/doc/en/books/porters-handbook/book.html -- Pietro Cerutti The FreeBSD Project g...@freebsd.org PGP Public Key: http://gahr.ch/pgp pgpwebEROClmp.pgp Description: PGP signature
Re: tk85 Port Maintenance
On 2012-Nov-07, 17:12, Joseph a Nagy Jr wrote:
On 11/06/12 02:20, Pietro Cerutti wrote:
snip
* I won't comment on the LICENSE stuff, I don't know enough about it
* XFT_DESC
This is already defined in bsd.options.desc.mk. I'd say that
Xft font library is ok as a description.
* LIB_DEPENDS+= Xft:${PORTSDIR}/x11-fonts/libXft
This should really be
USE_XORG+= xft
* LIB_DEPENDS= tcl${SHORT_TK_VER}${THREADS_SUFFIX}:
If you're ok to wait until I get rid of the -thread slave ports,
you don't need to bother about this part of the Makefile
svn checked out, svn diff
http://pastebin.com/kLdUFp9H
-XFT_DESC= Use Xft fonts
+XFT_DESC= Xft font library
This is not needed. As I said, XFT_DESC is already defined in
bsd.options.desc.mk
The tr - ${TR} conversion is also wrong, you're changing what the sed
liner is looking for. If you do so, it won't find it anymore.
By the way, Tcl/Tk 8.5.13 is bound to be released in the next few days
(the first RC is out now, actually). You might want to include the
update in your diff :)
--
Pietro Cerutti
The FreeBSD Project
g...@freebsd.org
PGP Public Key:
http://gahr.ch/pgp
pgpmPUtle5SX3.pgp
Description: PGP signature
Re: tk85 Port Maintenance
On 11/08/12 03:13, Pietro Cerutti wrote:
On 2012-Nov-07, 17:12, Joseph a Nagy Jr wrote:
On 11/06/12 02:20, Pietro Cerutti wrote:
snip
* I won't comment on the LICENSE stuff, I don't know enough about it
* XFT_DESC
This is already defined in bsd.options.desc.mk. I'd say that
Xft font library is ok as a description.
* LIB_DEPENDS+= Xft:${PORTSDIR}/x11-fonts/libXft
This should really be
USE_XORG+= xft
* LIB_DEPENDS= tcl${SHORT_TK_VER}${THREADS_SUFFIX}:
If you're ok to wait until I get rid of the -thread slave ports,
you don't need to bother about this part of the Makefile
svn checked out, svn diff
http://pastebin.com/kLdUFp9H
-XFT_DESC= Use Xft fonts
+XFT_DESC= Xft font library
This is not needed. As I said, XFT_DESC is already defined in
bsd.options.desc.mk
Sorry, misunderstood.
The tr - ${TR} conversion is also wrong, you're changing what the sed
liner is looking for. If you do so, it won't find it anymore.
That was one of many suggestions from portlint.
By the way, Tcl/Tk 8.5.13 is bound to be released in the next few days
(the first RC is out now, actually). You might want to include the
update in your diff :)
I'll get on it.
--
Yours in Christ,
Joseph A Nagy Jr
Whoever loves instruction loves knowledge, But he who hates correction
is stupid. -- Proverbs 12:1
Emails are not formal business letters, whatever businesses may want.
Original content CopyFree (F) under the OWL http://owl.apotheon.org
signature.asc
Description: OpenPGP digital signature
Re: tk85 Port Maintenance
On 11/08/12 03:13, Pietro Cerutti wrote: snip By the way, Tcl/Tk 8.5.13 is bound to be released in the next few days (the first RC is out now, actually). You might want to include the update in your diff :) http://pastebin.com/UmasjFfz -- Yours in Christ, Joseph A Nagy Jr Whoever loves instruction loves knowledge, But he who hates correction is stupid. -- Proverbs 12:1 Emails are not formal business letters, whatever businesses may want. Original content CopyFree (F) under the OWL http://owl.apotheon.org signature.asc Description: OpenPGP digital signature
Re: tk85 Port Maintenance
On 8 November 2012 09:56, Joseph a Nagy Jr jnagyjr1...@gmail.com wrote:
The tr - ${TR} conversion is also wrong, you're changing what the sed
liner is looking for. If you do so, it won't find it anymore.
That was one of many suggestions from portlint.
try make -VTR to see what the difference is. Keep in mind that
portlint is a cool which gives guidance, but it isn't always correct.
--
Eitan Adler
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: tk85 Port Maintenance
On 11/08/12 09:33, Eitan Adler wrote:
On 8 November 2012 09:56, Joseph a Nagy Jr jnagyjr1...@gmail.com wrote:
The tr - ${TR} conversion is also wrong, you're changing what the sed
liner is looking for. If you do so, it won't find it anymore.
That was one of many suggestions from portlint.
try make -VTR to see what the difference is. Keep in mind that
portlint is a cool which gives guidance, but it isn't always correct.
Thanks, I'll keep that in mind, but I was just going by what he said
earlier about following its suggestions. Still learning. (:
--
Yours in Christ,
Joseph A Nagy Jr
Whoever loves instruction loves knowledge, But he who hates correction
is stupid. -- Proverbs 12:1
Emails are not formal business letters, whatever businesses may want.
Original content CopyFree (F) under the OWL http://owl.apotheon.org
signature.asc
Description: OpenPGP digital signature
Re: tk85 Port Maintenance
On 11/08/12 20:59, Eitan Adler wrote:
On 8 November 2012 21:42, Joseph a Nagy Jr jnagyjr1...@gmail.com wrote:
On 11/08/12 09:33, Eitan Adler wrote:
On 8 November 2012 09:56, Joseph a Nagy Jr jnagyjr1...@gmail.com wrote:
The tr - ${TR} conversion is also wrong, you're changing what the sed
liner is looking for. If you do so, it won't find it anymore.
That was one of many suggestions from portlint.
try make -VTR to see what the difference is. Keep in mind that
portlint is a cool which gives guidance, but it isn't always correct.
Thanks, I'll keep that in mind, but I was just going by what he said
earlier about following its suggestions. Still learning. (:
No worries. I'm also still learning, and I'm just trying to help you
learn too. :)
I appreciate it. I need help. lol
--
Yours in Christ,
Joseph A Nagy Jr
Whoever loves instruction loves knowledge, But he who hates correction
is stupid. -- Proverbs 12:1
Emails are not formal business letters, whatever businesses may want.
Original content CopyFree (F) under the OWL http://owl.apotheon.org
signature.asc
Description: OpenPGP digital signature
Re: tk85 Port Maintenance
On 11/06/12 02:20, Pietro Cerutti wrote:
snip
* I won't comment on the LICENSE stuff, I don't know enough about it
* XFT_DESC
This is already defined in bsd.options.desc.mk. I'd say that
Xft font library is ok as a description.
* LIB_DEPENDS+= Xft:${PORTSDIR}/x11-fonts/libXft
This should really be
USE_XORG+= xft
* LIB_DEPENDS= tcl${SHORT_TK_VER}${THREADS_SUFFIX}:
If you're ok to wait until I get rid of the -thread slave ports,
you don't need to bother about this part of the Makefile
svn checked out, svn diff
http://pastebin.com/kLdUFp9H
--
Yours in Christ,
Joseph A Nagy Jr
Whoever loves instruction loves knowledge, But he who hates correction
is stupid. -- Proverbs 12:1
Emails are not formal business letters, whatever businesses may want.
Original content CopyFree (F) under the OWL http://owl.apotheon.org
signature.asc
Description: OpenPGP digital signature
Re: tk85 Port Maintenance
On 11/02/12 06:21, Pietro Cerutti wrote:
On 2012-Oct-31, 12:41, Joseph a Nagy Jr wrote:
On 10/31/12 11:55, Pietro Cerutti wrote:
On 2012-Oct-31, 11:28, Joseph a Nagy Jr wrote:
snip
New diff[0], undoing some of the earlier changes even though portlint
complains:
portlint ~/port-maintenance/tk85/
WARN: Makefile: unless this is a master port, COMMENT has to be set by
=, not by ?=.
This *is* a master port, so it's ok to have COMMENT?=
WARN: Makefile: LIB_DEPENDS has to appear earlier.
This should be fixed as portlint suggests.
WARN: Makefile: no port directory
/usr/ports/lang/tcl${SHORT_TK_VER}-thread found, even though it is
listed in LIB_DEPENDS.
I would try and use USE_TCL instead of LIB_DEPENDS here
WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .2 in
Xft.2 unless it is really necessary.
This should be fixed as portlint suggests.
0 fatal errors and 4 warnings found.
[0]: http://pastebin.com/apf1Y9H0
I'll have a look at it on Friday, thanks!
Going ahead to make those changes, old pastebin link is defunct.
New diff with all changes:
http://pastebin.com/iwhpXfcp
This won't apply, either. Could you provide a diff as dumped by svn diff
in tk85's directory?
http://www.joseph-a-nagy-jr.us/downloads/patches/x11-toolkits/tk85/tk85-001.patch
If this doesn't work, fire me. I'm rather frustrated at the moment.
--
Yours in Christ,
Joseph A Nagy Jr
Whoever loves instruction loves knowledge, But he who hates correction
is stupid. -- Proverbs 12:1
Emails are not formal business letters, whatever businesses may want.
Original content CopyFree (F) under the OWL http://owl.apotheon.org
signature.asc
Description: OpenPGP digital signature
Re: tk85 Port Maintenance
On 2012-Nov-04, 08:48, Joseph a Nagy Jr wrote:
On 11/02/12 06:21, Pietro Cerutti wrote:
On 2012-Oct-31, 12:41, Joseph a Nagy Jr wrote:
On 10/31/12 11:55, Pietro Cerutti wrote:
On 2012-Oct-31, 11:28, Joseph a Nagy Jr wrote:
snip
New diff[0], undoing some of the earlier changes even though portlint
complains:
portlint ~/port-maintenance/tk85/
WARN: Makefile: unless this is a master port, COMMENT has to be set by
=, not by ?=.
This *is* a master port, so it's ok to have COMMENT?=
WARN: Makefile: LIB_DEPENDS has to appear earlier.
This should be fixed as portlint suggests.
WARN: Makefile: no port directory
/usr/ports/lang/tcl${SHORT_TK_VER}-thread found, even though it is
listed in LIB_DEPENDS.
I would try and use USE_TCL instead of LIB_DEPENDS here
WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .2 in
Xft.2 unless it is really necessary.
This should be fixed as portlint suggests.
0 fatal errors and 4 warnings found.
[0]: http://pastebin.com/apf1Y9H0
I'll have a look at it on Friday, thanks!
Going ahead to make those changes, old pastebin link is defunct.
New diff with all changes:
http://pastebin.com/iwhpXfcp
This won't apply, either. Could you provide a diff as dumped by svn diff
in tk85's directory?
Try this diff:
http://pastebin.com/9YacWnss
* I won't comment on the LICENSE stuff, I don't know enough about it
* XFT_DESC
This is already defined in bsd.options.desc.mk. I'd say that
Xft font library is ok as a description.
* LIB_DEPENDS+= Xft:${PORTSDIR}/x11-fonts/libXft
This should really be
USE_XORG+= xft
* LIB_DEPENDS= tcl${SHORT_TK_VER}${THREADS_SUFFIX}:
If you're ok to wait until I get rid of the -thread slave ports,
you don't need to bother about this part of the Makefile
--
Pietro Cerutti
The FreeBSD Project
g...@freebsd.org
PGP Public Key:
http://gahr.ch/pgp
pgprpYlO1sP79.pgp
Description: PGP signature
Re: tk85 Port Maintenance
On 11/06/12 02:20, Pietro Cerutti wrote:
snip
* I won't comment on the LICENSE stuff, I don't know enough about it
I've checked and there are no official endorsements of Tcl/Tk license
except from CopyFree folks. FSF and OSI don't even mention Tcl/Tk license.
* XFT_DESC
This is already defined in bsd.options.desc.mk. I'd say that
Xft font library is ok as a description.
okay
* LIB_DEPENDS+= Xft:${PORTSDIR}/x11-fonts/libXft
This should really be
USE_XORG+= xft
okay
* LIB_DEPENDS= tcl${SHORT_TK_VER}${THREADS_SUFFIX}:
If you're ok to wait until I get rid of the -thread slave ports,
you don't need to bother about this part of the Makefile
10-4.
Will work on new changes tonight.
--
Yours in Christ,
Joseph A Nagy Jr
Whoever loves instruction loves knowledge, But he who hates correction
is stupid. -- Proverbs 12:1
Emails are not formal business letters, whatever businesses may want.
Original content CopyFree (F) under the OWL http://owl.apotheon.org
signature.asc
Description: OpenPGP digital signature
Re: tk85 Port Maintenance
snip http://pastebin.com/GSG0Y19W -- Yours in Christ, Joseph A Nagy Jr Whoever loves instruction loves knowledge, But he who hates correction is stupid. -- Proverbs 12:1 Emails are not formal business letters, whatever businesses may want. Original content CopyFree (F) under the OWL http://owl.apotheon.org signature.asc Description: OpenPGP digital signature
Re: tk85 Port Maintenance
On 11/02/12 06:21, Pietro Cerutti wrote:
On 2012-Oct-31, 12:41, Joseph a Nagy Jr wrote:
On 10/31/12 11:55, Pietro Cerutti wrote:
On 2012-Oct-31, 11:28, Joseph a Nagy Jr wrote:
snip
New diff[0], undoing some of the earlier changes even though portlint
complains:
portlint ~/port-maintenance/tk85/
WARN: Makefile: unless this is a master port, COMMENT has to be set by
=, not by ?=.
This *is* a master port, so it's ok to have COMMENT?=
WARN: Makefile: LIB_DEPENDS has to appear earlier.
This should be fixed as portlint suggests.
WARN: Makefile: no port directory
/usr/ports/lang/tcl${SHORT_TK_VER}-thread found, even though it is
listed in LIB_DEPENDS.
I would try and use USE_TCL instead of LIB_DEPENDS here
WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .2 in
Xft.2 unless it is really necessary.
This should be fixed as portlint suggests.
0 fatal errors and 4 warnings found.
[0]: http://pastebin.com/apf1Y9H0
I'll have a look at it on Friday, thanks!
Going ahead to make those changes, old pastebin link is defunct.
New diff with all changes:
http://pastebin.com/iwhpXfcp
This won't apply, either. Could you provide a diff as dumped by svn diff
in tk85's directory?
Try this diff:
http://pastebin.com/9YacWnss
portlint complains about two lines using 'tr' instead of '${TR}' in four
different spots but its the only other change that I made - going on
complaints from portlint - that I could think of that are keeping this
from working. If you can think of anything else, let me know.
--
Yours in Christ,
Joseph A Nagy Jr
Whoever loves instruction loves knowledge, But he who hates correction
is stupid. -- Proverbs 12:1
Emails are not formal business letters, whatever businesses may want.
Original content CopyFree (F) under the OWL http://owl.apotheon.org
signature.asc
Description: OpenPGP digital signature
Re: tk85 Port Maintenance
On 2012-Oct-31, 12:41, Joseph a Nagy Jr wrote:
On 10/31/12 11:55, Pietro Cerutti wrote:
On 2012-Oct-31, 11:28, Joseph a Nagy Jr wrote:
snip
New diff[0], undoing some of the earlier changes even though portlint
complains:
portlint ~/port-maintenance/tk85/
WARN: Makefile: unless this is a master port, COMMENT has to be set by
=, not by ?=.
This *is* a master port, so it's ok to have COMMENT?=
WARN: Makefile: LIB_DEPENDS has to appear earlier.
This should be fixed as portlint suggests.
WARN: Makefile: no port directory
/usr/ports/lang/tcl${SHORT_TK_VER}-thread found, even though it is
listed in LIB_DEPENDS.
I would try and use USE_TCL instead of LIB_DEPENDS here
WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .2 in
Xft.2 unless it is really necessary.
This should be fixed as portlint suggests.
0 fatal errors and 4 warnings found.
[0]: http://pastebin.com/apf1Y9H0
I'll have a look at it on Friday, thanks!
Going ahead to make those changes, old pastebin link is defunct.
New diff with all changes:
http://pastebin.com/iwhpXfcp
This won't apply, either. Could you provide a diff as dumped by svn diff
in tk85's directory?
--
Pietro Cerutti
The FreeBSD Project
g...@freebsd.org
PGP Public Key:
http://gahr.ch/pgp
pgphqntzhLdqz.pgp
Description: PGP signature
Re: tk85 Port Maintenance
On 11/02/12 06:21, Pietro Cerutti wrote:
snip
This won't apply, either. Could you provide a diff as dumped by svn diff
in tk85's directory?
from within /usr/ports/x11-toolkits/tk85 on the original
root@alex-laptop# svn diff Makefile
Index: Makefile
===
--- Makefile(revision 306478)
+++ Makefile(working copy)
@@ -12,7 +12,7 @@
PKGNAMESUFFIX?=${THREADS_SUFFIX}
DISTNAME= ${PORTNAME}${PORTVERSION}-src
-MAINTAINER=po...@freebsd.org
+MAINTAINER=jnagyjr1...@gmail.com
COMMENT?= Graphical toolkit for Tcl
LICENSE= BSD
I can't svn diff the new Makefile (with the license and other updates)
--
Yours in Christ,
Joseph A Nagy Jr
Whoever loves instruction loves knowledge, But he who hates correction
is stupid. -- Proverbs 12:1
Emails are not formal business letters, whatever businesses may want.
Original content CopyFree (F) under the OWL http://owl.apotheon.org
signature.asc
Description: OpenPGP digital signature
tk85 Port Maintenance
Hi All, I'd like to volunteer to maintain the tk85 port. I've already begun making updates to the Makefile[0] in a workbench directory and have a working update to it. All changes were due to feedback from portlint. Any and all feedback would be appreciated. [0]: http://pastebin.com/6DuzdAzv -- Yours in Christ, Joseph A Nagy Jr Whoever loves instruction loves knowledge, But he who hates correction is stupid. -- Proverbs 12:1 Emails are not formal business letters, whatever businesses may want. Original content CopyFree (F) under the OWL http://owl.apotheon.org signature.asc Description: OpenPGP digital signature
Re: tk85 Port Maintenance
On 31 October 2012 13:03, Joseph a Nagy Jr jnagyjr1...@gmail.com wrote: Hi All, I'd like to volunteer to maintain the tk85 port. I've already begun making updates to the Makefile[0] in a workbench directory and have a working update to it. All changes were due to feedback from portlint. Any and all feedback would be appreciated. I've set you as maintainer. [0]: http://pastebin.com/6DuzdAzv Did you check with Martin Matuska that he's OK with removing the attribution lines? Why are you using LIB_DEPENDS instead of USE_TCL? Check it's not a master port before you remove the ? from COMMENT too. Chris ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: tk85 Port Maintenance
On 10/31/12 08:24, Chris Rees wrote: On 31 October 2012 13:03, Joseph a Nagy Jr jnagyjr1...@gmail.com wrote: Hi All, I'd like to volunteer to maintain the tk85 port. I've already begun making updates to the Makefile[0] in a workbench directory and have a working update to it. All changes were due to feedback from portlint. Any and all feedback would be appreciated. I've set you as maintainer. [0]: http://pastebin.com/6DuzdAzv Did you check with Martin Matuska that he's OK with removing the attribution lines? I was being helped with this by a gentleman on FreeNode in ##copyfree (s/he's also in ##freebsd (trout)). If that's not acceptable practice I can undo it. I've emailed Martin about another port (tk-wrapper) and have yet to receive a response. I was wanting to not send another email if the first was unwelcome. I'll check with him asap. Why are you using LIB_DEPENDS instead of USE_TCL? It was in the original Makefile and saw no reason to change it. I can make that change though. Check it's not a master port before you remove the ? from COMMENT too. snip 10-4. -- Yours in Christ, Joseph A Nagy Jr Whoever loves instruction loves knowledge, But he who hates correction is stupid. -- Proverbs 12:1 Emails are not formal business letters, whatever businesses may want. Original content CopyFree (F) under the OWL http://owl.apotheon.org signature.asc Description: OpenPGP digital signature
Re: tk85 Port Maintenance
On 2012-Oct-31, 08:36, Joseph a Nagy Jr wrote: On 10/31/12 08:24, Chris Rees wrote: On 31 October 2012 13:03, Joseph a Nagy Jr jnagyjr1...@gmail.com wrote: Hi All, I'd like to volunteer to maintain the tk85 port. I've already begun making updates to the Makefile[0] in a workbench directory and have a working update to it. All changes were due to feedback from portlint. Any and all feedback would be appreciated. I've set you as maintainer. [0]: http://pastebin.com/6DuzdAzv Did you check with Martin Matuska that he's OK with removing the attribution lines? I was being helped with this by a gentleman on FreeNode in ##copyfree (s/he's also in ##freebsd (trout)). If that's not acceptable practice I can undo it. I've emailed Martin about another port (tk-wrapper) and have yet to receive a response. I was wanting to not send another email if the first was unwelcome. I'll check with him asap. Why are you using LIB_DEPENDS instead of USE_TCL? It was in the original Makefile and saw no reason to change it. I can make that change though. Check it's not a master port before you remove the ? from COMMENT too. snip 10-4. Please be informed that I have in the pipeline some work on Tcl/Tk ports, including removal of the -thread slaves. Having said that, I don't have any major concerns about you taking maintainership of tk85, apart from the technical details pointed out by Chris, and I have not looked at the patch very carefully, but if you're going to touch the Tcl ports as well, I'd like the two of us to collaborate and sync work. Are you also interested in taking lang/tcl85? Thanks! -- Pietro Cerutti The FreeBSD Project g...@freebsd.org PGP Public Key: http://gahr.ch/pgp pgpTGHEgsyQBk.pgp Description: PGP signature
Re: tk85 Port Maintenance
On 2012-Oct-31, 08:03, Joseph a Nagy Jr wrote: Hi All, I'd like to volunteer to maintain the tk85 port. I've already begun making updates to the Makefile[0] in a workbench directory and have a working update to it. All changes were due to feedback from portlint. Any and all feedback would be appreciated. [0]: http://pastebin.com/6DuzdAzv Ehm, your diff fails to apply here.. -- Pietro Cerutti The FreeBSD Project g...@freebsd.org PGP Public Key: http://gahr.ch/pgp pgpZdRNPZ2Wvp.pgp Description: PGP signature
Re: tk85 Port Maintenance
On 10/31/12 08:57, Pietro Cerutti wrote: On 2012-Oct-31, 08:03, Joseph a Nagy Jr wrote: Hi All, I'd like to volunteer to maintain the tk85 port. I've already begun making updates to the Makefile[0] in a workbench directory and have a working update to it. All changes were due to feedback from portlint. Any and all feedback would be appreciated. [0]: http://pastebin.com/6DuzdAzv Ehm, your diff fails to apply here.. What's the issue? -- Yours in Christ, Joseph A Nagy Jr Whoever loves instruction loves knowledge, But he who hates correction is stupid. -- Proverbs 12:1 Emails are not formal business letters, whatever businesses may want. Original content CopyFree (F) under the OWL http://owl.apotheon.org signature.asc Description: OpenPGP digital signature
Re: tk85 Port Maintenance
On 10/31/12 08:49, Pietro Cerutti wrote: snip Please be informed that I have in the pipeline some work on Tcl/Tk ports, including removal of the -thread slaves. Okay Having said that, I don't have any major concerns about you taking maintainership of tk85, apart from the technical details pointed out by Chris, and I have not looked at the patch very carefully, but if you're going to touch the Tcl ports as well, I'd like the two of us to collaborate and sync work. Are you also interested in taking lang/tcl85? Not at the moment, but I could in the foreseeable future. Thanks! -- Yours in Christ, Joseph A Nagy Jr Whoever loves instruction loves knowledge, But he who hates correction is stupid. -- Proverbs 12:1 Emails are not formal business letters, whatever businesses may want. Original content CopyFree (F) under the OWL http://owl.apotheon.org signature.asc Description: OpenPGP digital signature
Re: tk85 Port Maintenance
On 10/31/12 08:57, Pietro Cerutti wrote: On 2012-Oct-31, 08:03, Joseph a Nagy Jr wrote: Hi All, I'd like to volunteer to maintain the tk85 port. I've already begun making updates to the Makefile[0] in a workbench directory and have a working update to it. All changes were due to feedback from portlint. Any and all feedback would be appreciated. [0]: http://pastebin.com/6DuzdAzv Ehm, your diff fails to apply here.. The problem comes from the Tcl/Tk license not being recognized as a known license. -- Yours in Christ, Joseph A Nagy Jr Whoever loves instruction loves knowledge, But he who hates correction is stupid. -- Proverbs 12:1 Emails are not formal business letters, whatever businesses may want. Original content CopyFree (F) under the OWL http://owl.apotheon.org signature.asc Description: OpenPGP digital signature
Re: tk85 Port Maintenance
On 2012-Oct-31, 09:14, Joseph a Nagy Jr wrote: On 10/31/12 08:57, Pietro Cerutti wrote: On 2012-Oct-31, 08:03, Joseph a Nagy Jr wrote: Hi All, I'd like to volunteer to maintain the tk85 port. I've already begun making updates to the Makefile[0] in a workbench directory and have a working update to it. All changes were due to feedback from portlint. Any and all feedback would be appreciated. [0]: http://pastebin.com/6DuzdAzv Ehm, your diff fails to apply here.. What's the issue? patch tk85.diff Hmm... Looks like a unified diff to me... The text leading up to this was: -- |--- Makefile.orig 2012-10-26 19:47:37.0 -0500 |+++ Makefile 2012-10-29 20:16:13.0 -0500 -- Patching file Makefile using Plan A... Reversed (or previously applied) patch detected! Assume -R? [y] Hunk #1 succeeded at 1 with fuzz 2. Hunk #2 failed at 12. Hunk #3 failed at 42. Hunk #4 failed at 61. Hunk #5 failed at 423. 4 out of 5 hunks failed--saving rejects to Makefile.rej done -- Pietro Cerutti The FreeBSD Project g...@freebsd.org PGP Public Key: http://gahr.ch/pgp pgpkzJn4B7S6M.pgp Description: PGP signature
Re: tk85 Port Maintenance
On 31 Oct 2012 15:21, Pietro Cerutti g...@freebsd.org wrote: On 2012-Oct-31, 09:14, Joseph a Nagy Jr wrote: On 10/31/12 08:57, Pietro Cerutti wrote: On 2012-Oct-31, 08:03, Joseph a Nagy Jr wrote: Hi All, I'd like to volunteer to maintain the tk85 port. I've already begun making updates to the Makefile[0] in a workbench directory and have a working update to it. All changes were due to feedback from portlint. Any and all feedback would be appreciated. [0]: http://pastebin.com/6DuzdAzv Ehm, your diff fails to apply here.. What's the issue? patch tk85.diff Hmm... Looks like a unified diff to me... The text leading up to this was: -- |--- Makefile.orig 2012-10-26 19:47:37.0 -0500 |+++ Makefile 2012-10-29 20:16:13.0 -0500 -- Patching file Makefile using Plan A... Reversed (or previously applied) patch detected! Assume -R? [y] Hunk #1 succeeded at 1 with fuzz 2. Hunk #2 failed at 12. Hunk #3 failed at 42. Hunk #4 failed at 61. Hunk #5 failed at 423. 4 out of 5 hunks failed--saving rejects to Makefile.rej done Say no to -r detected; it's noticed the maintainer change. Chris ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: tk85 Port Maintenance
On 2012-Oct-31, 15:25, Chris Rees wrote: On 31 Oct 2012 15:21, Pietro Cerutti g...@freebsd.org wrote: On 2012-Oct-31, 09:14, Joseph a Nagy Jr wrote: On 10/31/12 08:57, Pietro Cerutti wrote: On 2012-Oct-31, 08:03, Joseph a Nagy Jr wrote: Hi All, I'd like to volunteer to maintain the tk85 port. I've already begun making updates to the Makefile[0] in a workbench directory and have a working update to it. All changes were due to feedback from portlint. Any and all feedback would be appreciated. [0]: http://pastebin.com/6DuzdAzv Ehm, your diff fails to apply here.. What's the issue? patch tk85.diff Hmm... Looks like a unified diff to me... The text leading up to this was: -- |--- Makefile.orig 2012-10-26 19:47:37.0 -0500 |+++ Makefile 2012-10-29 20:16:13.0 -0500 -- Patching file Makefile using Plan A... Reversed (or previously applied) patch detected! Assume -R? [y] Hunk #1 succeeded at 1 with fuzz 2. Hunk #2 failed at 12. Hunk #3 failed at 42. Hunk #4 failed at 61. Hunk #5 failed at 423. 4 out of 5 hunks failed--saving rejects to Makefile.rej done Say no to -r detected; it's noticed the maintainer change. patch tk85.diff Hmm... Looks like a unified diff to me... The text leading up to this was: -- |--- Makefile.orig 2012-10-26 19:47:37.0 -0500 |+++ Makefile 2012-10-29 20:16:13.0 -0500 -- Patching file Makefile using Plan A... Reversed (or previously applied) patch detected! Assume -R? [y] n Apply anyway? [n] y Hunk #1 failed at 1. Hunk #2 failed at 7. Hunk #3 failed at 40. Hunk #4 failed at 58. Hunk #5 failed at 420. 5 out of 5 hunks failed--saving rejects to Makefile.rej done -- Pietro Cerutti The FreeBSD Project g...@freebsd.org PGP Public Key: http://gahr.ch/pgp pgp80x5kbhkEQ.pgp Description: PGP signature
Re: tk85 Port Maintenance
On 10/31/12 10:39, Pietro Cerutti wrote: snip patch tk85.diff Hmm... Looks like a unified diff to me... The text leading up to this was: -- |--- Makefile.orig 2012-10-26 19:47:37.0 -0500 |+++ Makefile 2012-10-29 20:16:13.0 -0500 -- Patching file Makefile using Plan A... Reversed (or previously applied) patch detected! Assume -R? [y] n Apply anyway? [n] y Hunk #1 failed at 1. Hunk #2 failed at 7. Hunk #3 failed at 40. Hunk #4 failed at 58. Hunk #5 failed at 420. 5 out of 5 hunks failed--saving rejects to Makefile.rej done working on it. -- Yours in Christ, Joseph A Nagy Jr Whoever loves instruction loves knowledge, But he who hates correction is stupid. -- Proverbs 12:1 Emails are not formal business letters, whatever businesses may want. Original content CopyFree (F) under the OWL http://owl.apotheon.org signature.asc Description: OpenPGP digital signature
Re: tk85 Port Maintenance
On 10/31/12 10:39, Pietro Cerutti wrote:
snip
patch tk85.diff
Hmm... Looks like a unified diff to me...
The text leading up to this was:
--
|--- Makefile.orig 2012-10-26 19:47:37.0 -0500
|+++ Makefile 2012-10-29 20:16:13.0 -0500
--
Patching file Makefile using Plan A...
Reversed (or previously applied) patch detected! Assume -R? [y] n
Apply anyway? [n] y
Hunk #1 failed at 1.
Hunk #2 failed at 7.
Hunk #3 failed at 40.
Hunk #4 failed at 58.
Hunk #5 failed at 420.
5 out of 5 hunks failed--saving rejects to Makefile.rej
done
New diff[0], undoing some of the earlier changes even though portlint
complains:
portlint ~/port-maintenance/tk85/
WARN: Makefile: unless this is a master port, COMMENT has to be set by
=, not by ?=.
WARN: Makefile: LIB_DEPENDS has to appear earlier.
WARN: Makefile: no port directory
/usr/ports/lang/tcl${SHORT_TK_VER}-thread found, even though it is
listed in LIB_DEPENDS.
WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .2 in
Xft.2 unless it is really necessary.
0 fatal errors and 4 warnings found.
[0]: http://pastebin.com/apf1Y9H0
--
Yours in Christ,
Joseph A Nagy Jr
Whoever loves instruction loves knowledge, But he who hates correction
is stupid. -- Proverbs 12:1
Emails are not formal business letters, whatever businesses may want.
Original content CopyFree (F) under the OWL http://owl.apotheon.org
signature.asc
Description: OpenPGP digital signature
Re: tk85 Port Maintenance
On 2012-Oct-31, 11:28, Joseph a Nagy Jr wrote:
On 10/31/12 10:39, Pietro Cerutti wrote:
snip
patch tk85.diff
Hmm... Looks like a unified diff to me...
The text leading up to this was:
--
|--- Makefile.orig 2012-10-26 19:47:37.0 -0500
|+++ Makefile 2012-10-29 20:16:13.0 -0500
--
Patching file Makefile using Plan A...
Reversed (or previously applied) patch detected! Assume -R? [y] n
Apply anyway? [n] y
Hunk #1 failed at 1.
Hunk #2 failed at 7.
Hunk #3 failed at 40.
Hunk #4 failed at 58.
Hunk #5 failed at 420.
5 out of 5 hunks failed--saving rejects to Makefile.rej
done
New diff[0], undoing some of the earlier changes even though portlint
complains:
portlint ~/port-maintenance/tk85/
WARN: Makefile: unless this is a master port, COMMENT has to be set by
=, not by ?=.
This *is* a master port, so it's ok to have COMMENT?=
WARN: Makefile: LIB_DEPENDS has to appear earlier.
This should be fixed as portlint suggests.
WARN: Makefile: no port directory
/usr/ports/lang/tcl${SHORT_TK_VER}-thread found, even though it is
listed in LIB_DEPENDS.
I would try and use USE_TCL instead of LIB_DEPENDS here
WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .2 in
Xft.2 unless it is really necessary.
This should be fixed as portlint suggests.
0 fatal errors and 4 warnings found.
[0]: http://pastebin.com/apf1Y9H0
I'll have a look at it on Friday, thanks!
--
Pietro Cerutti
The FreeBSD Project
g...@freebsd.org
PGP Public Key:
http://gahr.ch/pgp
pgp7yUKsu0zLC.pgp
Description: PGP signature
Re: tk85 Port Maintenance
On 10/31/12 11:55, Pietro Cerutti wrote:
On 2012-Oct-31, 11:28, Joseph a Nagy Jr wrote:
snip
New diff[0], undoing some of the earlier changes even though portlint
complains:
portlint ~/port-maintenance/tk85/
WARN: Makefile: unless this is a master port, COMMENT has to be set by
=, not by ?=.
This *is* a master port, so it's ok to have COMMENT?=
WARN: Makefile: LIB_DEPENDS has to appear earlier.
This should be fixed as portlint suggests.
WARN: Makefile: no port directory
/usr/ports/lang/tcl${SHORT_TK_VER}-thread found, even though it is
listed in LIB_DEPENDS.
I would try and use USE_TCL instead of LIB_DEPENDS here
WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .2 in
Xft.2 unless it is really necessary.
This should be fixed as portlint suggests.
0 fatal errors and 4 warnings found.
[0]: http://pastebin.com/apf1Y9H0
I'll have a look at it on Friday, thanks!
Going ahead to make those changes, old pastebin link is defunct.
New diff with all changes:
http://pastebin.com/iwhpXfcp
--
Yours in Christ,
Joseph A Nagy Jr
Whoever loves instruction loves knowledge, But he who hates correction
is stupid. -- Proverbs 12:1
Emails are not formal business letters, whatever businesses may want.
Original content CopyFree (F) under the OWL http://owl.apotheon.org
signature.asc
Description: OpenPGP digital signature
