Re: diff and submissions

[Mathieu Arnold]

Le 05/05/2017 à 12:37, Baptiste Daroussin a écrit :
> On Fri, May 05, 2017 at 12:27:13PM +0200, Mathieu Arnold wrote:
>> Le 05/05/2017 à 12:20, Baptiste Daroussin a écrit :
>>> I made a script which is a few lines of shell that converts pull
>>> requests to
>>> phabricator reviews automatically.
>>>
>>> I have handed it to some of the phabricator admins, I hope it will be 
>>> progress
>>> soon.
>> Please, do not do that.
>>
>> Phabricator is for code review, not bug reports.  It all ends up in our
>> repository, but Phabricator does not have any maintainer notification
>> like Bugzilla has.
>> robak@ has a script that does pull-request -> bugzilla, and it has been
>> waiting for months for someone with access to do something about it.
>>
> Pull request are for code submissions and phabricator is the equivalent for 
> that


It is great to review code, yes, but it will not notify maintainers that
they have a patch for one of their ports, it adds more work for the
ports committers that will have to go and review the code, and maybe
notice it came from github, and then maybe notice that someone need to
notify the maintainer of the port in question, so that they can accept,
or not, the patch.

It is mostly going to end up having code review that are not handled by
anyone because they are not code review, they came from github, and the
submitter on github is not aware that there has been some review and
they need to update their code, or that they need to submit it to
bugzilla afterwards so that it gets reviewed by the maintainer.


-- 
Mathieu Arnold




signature.asc
Description: OpenPGP digital signature

Re: diff and submissions

[Aristedes Maniatis]

On 5/5/17 8:17pm, Mathieu Arnold wrote:
> Le 05/05/2017 à 08:16, Franco Fichtner a écrit :
>>> On 4. May 2017, at 10:20 AM, Mathieu Arnold  wrote:
>>>
>>> If you went as far as being able to create a pull request, you can do a
>>> git show HEAD or git diff origin/trunk...HEAD and submit that in the
>>> FreeBSD PR as well.
>> It's pretty easy to extract the diff from a PR on GitHub, just append
>> ".diff", and ".patch" works too, but gives the full git commit history:
>>
>> https://github.com/freebsd/freebsd-ports/pull/62.diff
> 
> Yes, I am aware of that, the problem with github pull requests is that
> they are outside of the FreeBSD bug report process, they do not get
> assigned to maintainers, nobody notices them, they just stay there, and
> get obsolete.
> There have been 61 before, yes, I closed a lot because they were
> obsolete because it is outside of our process and nobody noticed them,
> and for the rest either asked the submitter to open a PR on our
> bugzilla, or opened one myself.
> 

A simple short term workaround might be:

1. Create a pull request template in github [1]

2. Include in it links to bugzilla and instructions for people to create a 
parallel bug report with a link back to github


The main reason I like github is that it is trivial to fork the repository, 
copy in my patched port files and add comments to the commit. It is 
considerably more different to remember to create .orig files and then diff 
them all, bundle it into a shar format and attach to bugzilla.

This is all from the perspective of someone who makes a submission once every 
3-6 months. Obviously if I had svn commit rights or had even checked out the 
ports tree from svn then I'd have other options. Most people like me use 
portsnap so they don't have an svn checkout.


Cheers
Ari





[1] 
https://help.github.com/articles/creating-a-pull-request-template-for-your-repository/



-- 
-->
Aristedes Maniatis
CEO, ish
https://www.ish.com.au
GPG fingerprint CBFB 84B4 738D 4E87 5E5C  5EFA EF6A 7D2E 3E49 102A



signature.asc
Description: OpenPGP digital signature

Re: diff and submissions

[Steven Hartland]

On 05/05/2017 11:27, Mathieu Arnold wrote:

Le 05/05/2017 à 12:20, Baptiste Daroussin a écrit :

On Fri, May 05, 2017 at 12:17:06PM +0200, Mathieu Arnold wrote:

Le 05/05/2017 à 08:16, Franco Fichtner a écrit :

On 4. May 2017, at 10:20 AM, Mathieu Arnold  wrote:

If you went as far as being able to create a pull request, you can do a
git show HEAD or git diff origin/trunk...HEAD and submit that in the
FreeBSD PR as well.

It's pretty easy to extract the diff from a PR on GitHub, just append
".diff", and ".patch" works too, but gives the full git commit history:

https://github.com/freebsd/freebsd-ports/pull/62.diff

Yes, I am aware of that, the problem with github pull requests is that
they are outside of the FreeBSD bug report process, they do not get
assigned to maintainers, nobody notices them, they just stay there, and
get obsolete.
There have been 61 before, yes, I closed a lot because they were
obsolete because it is outside of our process and nobody noticed them,
and for the rest either asked the submitter to open a PR on our
bugzilla, or opened one myself.


I made a script which is a few lines of shell that converts pull requests to
phabricator reviews automatically.

I have handed it to some of the phabricator admins, I hope it will be progress
soon.


Please, do not do that.

Phabricator is for code review, not bug reports.  It all ends up in our
repository, but Phabricator does not have any maintainer notification
like Bugzilla has.
robak@ has a script that does pull-request -> bugzilla, and it has been
waiting for months for someone with access to do something about it.

Pull requests are not bug reports, that would issues.

IMO PR -> phabricator would be best match.

Regards
Steve
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: diff and submissions

[Baptiste Daroussin]

On Fri, May 05, 2017 at 12:27:13PM +0200, Mathieu Arnold wrote:
> Le 05/05/2017 à 12:20, Baptiste Daroussin a écrit :
> > On Fri, May 05, 2017 at 12:17:06PM +0200, Mathieu Arnold wrote:
> >> Le 05/05/2017 à 08:16, Franco Fichtner a écrit :
>  On 4. May 2017, at 10:20 AM, Mathieu Arnold  wrote:
> 
>  If you went as far as being able to create a pull request, you can do a
>  git show HEAD or git diff origin/trunk...HEAD and submit that in the
>  FreeBSD PR as well.
> >>> It's pretty easy to extract the diff from a PR on GitHub, just append
> >>> ".diff", and ".patch" works too, but gives the full git commit history:
> >>>
> >>> https://github.com/freebsd/freebsd-ports/pull/62.diff
> >> Yes, I am aware of that, the problem with github pull requests is that
> >> they are outside of the FreeBSD bug report process, they do not get
> >> assigned to maintainers, nobody notices them, they just stay there, and
> >> get obsolete.
> >> There have been 61 before, yes, I closed a lot because they were
> >> obsolete because it is outside of our process and nobody noticed them,
> >> and for the rest either asked the submitter to open a PR on our
> >> bugzilla, or opened one myself.
> >>
> > I made a script which is a few lines of shell that converts pull requests to
> > phabricator reviews automatically.
> >
> > I have handed it to some of the phabricator admins, I hope it will be 
> > progress
> > soon.
> 
> 
> Please, do not do that.
> 
> Phabricator is for code review, not bug reports.  It all ends up in our
> repository, but Phabricator does not have any maintainer notification
> like Bugzilla has.
> robak@ has a script that does pull-request -> bugzilla, and it has been
> waiting for months for someone with access to do something about it.
> 

Pull request are for code submissions and phabricator is the equivalent for that

Bapt


signature.asc
Description: PGP signature

Re: diff and submissions

[Mathieu Arnold]

Le 05/05/2017 à 12:20, Baptiste Daroussin a écrit :
> On Fri, May 05, 2017 at 12:17:06PM +0200, Mathieu Arnold wrote:
>> Le 05/05/2017 à 08:16, Franco Fichtner a écrit :
 On 4. May 2017, at 10:20 AM, Mathieu Arnold  wrote:

 If you went as far as being able to create a pull request, you can do a
 git show HEAD or git diff origin/trunk...HEAD and submit that in the
 FreeBSD PR as well.
>>> It's pretty easy to extract the diff from a PR on GitHub, just append
>>> ".diff", and ".patch" works too, but gives the full git commit history:
>>>
>>> https://github.com/freebsd/freebsd-ports/pull/62.diff
>> Yes, I am aware of that, the problem with github pull requests is that
>> they are outside of the FreeBSD bug report process, they do not get
>> assigned to maintainers, nobody notices them, they just stay there, and
>> get obsolete.
>> There have been 61 before, yes, I closed a lot because they were
>> obsolete because it is outside of our process and nobody noticed them,
>> and for the rest either asked the submitter to open a PR on our
>> bugzilla, or opened one myself.
>>
> I made a script which is a few lines of shell that converts pull requests to
> phabricator reviews automatically.
>
> I have handed it to some of the phabricator admins, I hope it will be progress
> soon.


Please, do not do that.

Phabricator is for code review, not bug reports.  It all ends up in our
repository, but Phabricator does not have any maintainer notification
like Bugzilla has.
robak@ has a script that does pull-request -> bugzilla, and it has been
waiting for months for someone with access to do something about it.

-- 
Mathieu Arnold




signature.asc
Description: OpenPGP digital signature

Re: diff and submissions

[Baptiste Daroussin]

On Fri, May 05, 2017 at 12:17:06PM +0200, Mathieu Arnold wrote:
> Le 05/05/2017 à 08:16, Franco Fichtner a écrit :
> >> On 4. May 2017, at 10:20 AM, Mathieu Arnold  wrote:
> >>
> >> If you went as far as being able to create a pull request, you can do a
> >> git show HEAD or git diff origin/trunk...HEAD and submit that in the
> >> FreeBSD PR as well.
> > It's pretty easy to extract the diff from a PR on GitHub, just append
> > ".diff", and ".patch" works too, but gives the full git commit history:
> >
> > https://github.com/freebsd/freebsd-ports/pull/62.diff
> 
> Yes, I am aware of that, the problem with github pull requests is that
> they are outside of the FreeBSD bug report process, they do not get
> assigned to maintainers, nobody notices them, they just stay there, and
> get obsolete.
> There have been 61 before, yes, I closed a lot because they were
> obsolete because it is outside of our process and nobody noticed them,
> and for the rest either asked the submitter to open a PR on our
> bugzilla, or opened one myself.
> 

I made a script which is a few lines of shell that converts pull requests to
phabricator reviews automatically.

I have handed it to some of the phabricator admins, I hope it will be progress
soon.

Bapt


signature.asc
Description: PGP signature

Re: diff and submissions

[Mathieu Arnold]

Le 05/05/2017 à 08:16, Franco Fichtner a écrit :
>> On 4. May 2017, at 10:20 AM, Mathieu Arnold  wrote:
>>
>> If you went as far as being able to create a pull request, you can do a
>> git show HEAD or git diff origin/trunk...HEAD and submit that in the
>> FreeBSD PR as well.
> It's pretty easy to extract the diff from a PR on GitHub, just append
> ".diff", and ".patch" works too, but gives the full git commit history:
>
> https://github.com/freebsd/freebsd-ports/pull/62.diff

Yes, I am aware of that, the problem with github pull requests is that
they are outside of the FreeBSD bug report process, they do not get
assigned to maintainers, nobody notices them, they just stay there, and
get obsolete.
There have been 61 before, yes, I closed a lot because they were
obsolete because it is outside of our process and nobody noticed them,
and for the rest either asked the submitter to open a PR on our
bugzilla, or opened one myself.

-- 
Mathieu Arnold


___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: diff and submissions

[Franco Fichtner]

> On 4. May 2017, at 10:20 AM, Mathieu Arnold  wrote:
> 
> If you went as far as being able to create a pull request, you can do a
> git show HEAD or git diff origin/trunk...HEAD and submit that in the
> FreeBSD PR as well.

It's pretty easy to extract the diff from a PR on GitHub, just append
".diff", and ".patch" works too, but gives the full git commit history:

https://github.com/freebsd/freebsd-ports/pull/62.diff


Cheers,
Franco
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: diff and submissions

[Kurt Jaeger]

Hi!

> I maintain and couple of ports and I submit patches for others
> every so often. The process of preparing a patch file is slightly
> awkward as documented [1]

> If we want to use the github pull process is that now possible?

It's not possible, but if you provide a link to the pull process
in a problem report at bugzilla.freebsd.org, this might work, even
if it takes a bit more work.

> There are 61 pull requests here:
> https://github.com/freebsd/freebsd-ports/pulls

Yes, we're aware, but there's no automation that provides
a PR from a pull request. I vaguely remember that someone was working
on some stuff to get this, but I might mis-remember.

-- 
p...@opsec.eu+49 171 3101372 3 years to go !
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: diff and submissions

[Mathieu Arnold]

Le 04/05/2017 à 09:58, Aristedes Maniatis a écrit :
> I maintain and couple of ports and I submit patches for others every so 
> often. The process of preparing a patch file is slightly awkward as 
> documented [1]
>
> If we want to use the github pull process is that now possible? There are 61 
> pull requests here: https://github.com/freebsd/freebsd-ports/pulls


Right now, using pull requests is not supported, the problem is that
they cannot be disabled on Github. If you open one, it will take a very
long time to be seen and most certainly closed with saying "please open
a PR on bugzilla". We have a "github issue" -> "bugzilla" tool in the
work, but it is not ready yet.

If you went as far as being able to create a pull request, you can do a
git show HEAD or git diff origin/trunk...HEAD and submit that in the
FreeBSD PR as well.


-- 
Mathieu Arnold




signature.asc
Description: OpenPGP digital signature