Re: PR's not being picked up (Was Re: becoming a port committor)
Here is a patch to take care of removing of updating. On Mon, Nov 22, 2010 at 02:08:02PM -0800, Charlie Kester thus spake: On Mon 22 Nov 2010 at 11:28:36 PST Greg Byshenk wrote: I'm not a porter, but how about the below...? HTH -greg --- begin diff --- --- porting-submitting.html 2007-09-11 01:11:07.0 +0200 +++ porting-submitting.html 2010-11-22 20:14:54.0 +0100 @@ -69,6 +69,14 @@ /blockquote /div +div class=NOTE +blockquote class=NOTE +pbNote2:/b The instructions above are for creating a i class=EMPHASISnew/i +port. Port i class=EMPHASISupdates/i should be diff files instead of shar files, +as described in a href=port-upgrading.htmlUpgrading/a./p +/blockquote +/div + pOne more time, span class=emphasisi class=EMPHASISdo not include the original source distfile, the tt class=FILENAMEwork/tt directory, or the package you built with tt class=COMMANDmake package/tt/i/span./p --- end diff --- While we're at it, remove any mention of port updates from the existing note: --- begin diff --- --- porting-submitting.html.orig2010-11-22 14:01:35.0 -0800 +++ porting-submitting.html 2010-11-22 14:02:09.0 -0800 @@ -66,9 +66,8 @@ blockquote class=NOTE pbNote:/b You can make our work a lot easier, if you use a good description in the synopsis of the problem report. We prefer something like ``New port: -lt;categorygt;/lt;portnamegt; lt;short description of the portgt;'' for new ports -and ``Update port: lt;categorygt;/lt;portnamegt; lt;short description of the -updategt;'' for port updates. If you stick to this scheme, the chance that someone will +lt;categorygt;/lt;portnamegt; lt;short description of the portgt;'' for new ports. +If you stick to this scheme, the chance that someone will take a look at your PR soon is much better./p /blockquote /div --- end diff --- I'm not sure, but I suspect that this note has been the source of the confusion. ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org -- -jgh --- porters-handbook/book.sgml 2010-11-23 11:49:21.0 -0800 +++ porters-handbook/book.sgml 2010-11-23 11:50:28.0 -0800 @@ -394,9 +394,7 @@ description in the synopsis of the problem report. We prefer something like quoteNew port: lt;categorygt;/lt;portnamegt; - lt;short description of the portgt;/quote for new ports and - quoteUpdate port: lt;categorygt;/lt;portnamegt; - lt;short description of the updategt;/quote for port updates. + lt;short description of the portgt;/quote. If you stick to this scheme, the chance that someone will take a look at your PR soon is much better./para /note ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: PR's not being picked up (Was Re: becoming a port committor)
On Sunday 21 November 2010 20:26:49 Charlie Kester wrote: On Sun 21 Nov 2010 at 20:09:23 PST Beech Rintoul wrote: That is correct, although it is possible to use a unified diff with the -N flag against a non existent source. The problem is too many contributors send in update pr's in shar format which are a real PITA to deal with from our end. You may notice that many pr's aren't picked up by committers for just that reason. In such cases, does the submitter receive any communication explaining the reasons his PR isn't getting worked on? E.g., why not send an email requesting resubmission in the proper format? Many of the of oldest unassigned but still-open PR's show no evidence that they've even been looked at by a committer. There are no entries beyond the original one. How can we know which PR's were rejected/not picked up for some reason and which ones were genuinely overlooked? You can't, but if a significant amount of time passes and no committer assigns themselves to a pr it usually means there are problems, either with the format or the upgrade itself. It's rare that a pr get's completely overlooked. We try and look at the list daily (as time permits). From: Contributing to the FreeBSD Ports Collection-5.2.1 Keep your ports up to date: 5. At some stage a committer will deal with your PR. It may take minutes, or it may take weeks - so please be patient. The reality is if a committer reviews a pr for an update and it's in shar format he/she will usually pass them by. If you think it's taking too long an email or question on #bsdports will usually get a response. We do get emails from portmgr detailing outstanding pr's, but there is no requirement to grab one. We also have a bugbusting team that reviews outstanding pr's and broken ports. With the wealth of info in The porter's guide and in contributing a submission which is coded well and in the proper format will usually get a quick response. Beech -- --- Beech Rintoul - FreeBSD Developer - be...@freebsd.org /\ ASCII Ribbon Campaign | FreeBSD Since 4.x \ / - NO HTML/RTF in e-mail | http://people.freebsd.org/~beech X - NO Word docs in e-mail | Skype: akbeech / \ - http://www.FreeBSD.org/releases/8.0R/announce.html --- ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: PR's not being picked up (Was Re: becoming a port committor)
On Sun, 21 Nov 2010 23:22:57 -0800 Charlie Kester corky1...@comcast.net wrote: On Sun 21 Nov 2010 at 22:01:28 PST Janky Jay, III wrote: Almost anyone who is an only semi-serious port maintainer (meaning they only have a select few number of ports to maintain and are only trying to contribute/participate) knows that maybe this issue is due to the porter's handbook. Specifically http://www.freebsd.org/doc/en/books/porters-handbook/porting-submitting.html which blatantly states that all submissions whether they are new OR updates be submitted in shar format. Maybe the commiters should bring this up and have a few less to deal with..? Just a suggestion. That page doesn't say what you think it says. Its context is the creation of a new port. It doesn't say anything about updating an existing port. Actually it does discuss the wording of the synopsis for both new and updated ports which gives the impression that that that section covers both. Furthermore the update chapter is at the opposite end of the index under the single misleading word Upgrading. There's no mention of submitting which is what people will be looking for. IMO chapter 10 should either be 3.7 or be merged into 3.6. If anything deserves to be under Quick Porting it's this. Perhaps the problem is that some people never read the *rest* of the handbook? The trouble is that even when people do read handbooks from beginning to end there are always sections that that they are likely to skip until they need them, and this is one of them. ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: PR's not being picked up (Was Re: becoming a port committor)
On Mon, 22 Nov 2010 13:19:05 + RW rwmailli...@googlemail.com wrote: On Sun, 21 Nov 2010 23:22:57 -0800 Charlie Kester corky1...@comcast.net wrote: On Sun 21 Nov 2010 at 22:01:28 PST Janky Jay, III wrote: Almost anyone who is an only semi-serious port maintainer (meaning they only have a select few number of ports to maintain and are only trying to contribute/participate) knows that maybe this issue is due to the porter's handbook. Specifically http://www.freebsd.org/doc/en/books/porters-handbook/porting-submitting.html which blatantly states that all submissions whether they are new OR updates be submitted in shar format. Maybe the commiters should bring this up and have a few less to deal with..? Just a suggestion. That page doesn't say what you think it says. Its context is the creation of a new port. It doesn't say anything about updating an existing port. Actually it does discuss the wording of the synopsis for both new and updated ports which gives the impression that that that section covers both. Furthermore the update chapter is at the opposite end of the index under the single misleading word Upgrading. There's no mention of submitting which is what people will be looking for. IMO chapter 10 should either be 3.7 or be merged into 3.6. If anything deserves to be under Quick Porting it's this. Perhaps the problem is that some people never read the *rest* of the handbook? The trouble is that even when people do read handbooks from beginning to end there are always sections that that they are likely to skip until they need them, and this is one of them. Patches with your proposed changes please. Thanks. -- IOnut - Un^d^dregistered ;) FreeBSD user Intellectual Property is nowhere near as valuable as Intellect FreeBSD committer - ite...@freebsd.org, PGP Key ID 057E9F8B493A297B signature.asc Description: PGP signature
Re: PR's not being picked up (Was Re: becoming a port committor)
On Sun, Nov 21, 2010 at 09:26:49PM -0800, Charlie Kester wrote: E.g., why not send an email requesting resubmission in the proper format? A lot of committers do try to do just that. There is no automated process, however. Many of the of oldest unassigned but still-open PR's show no evidence that they've even been looked at by a committer. In that case you might post a followup, after some period of time, and ask for specific review. How can we know which PR's were rejected/not picked up for some reason and which ones were genuinely overlooked? Right now, you can't. OTOH there are various ways to browse the PRs (web pages, periodic postings.) The counter-argument to this is that we get 40+ PRs per day. Ones that seem easy and/or well-prepared are probably going to get handled more quickly. That's just the reality when dealing with such a large number of PRs. mcl ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: PR's not being picked up (Was Re: becoming a port committor)
Hi, On Mon, Nov 22, 2010 at 2:19 PM, RW rwmailli...@googlemail.com wrote: Actually it does discuss the wording of the synopsis for both new and updated ports which gives the impression that that that section covers both. Furthermore the update chapter is at the opposite end of the index under the single misleading word Upgrading. There's no mention of submitting which is what people will be looking for. IMO chapter 10 should either be 3.7 or be merged into 3.6. If anything deserves to be under Quick Porting it's this. So then we will see your PR for an update of that chapter in the Porter's Handbook in the next few days perhaps? The trouble is that even when people do read handbooks from beginning to end there are always sections that that they are likely to skip until they need them, and this is one of them. The Porter's Handbook is not going to be improved unless the people who read it and have ideas for improvement do something about it. HTH, HAND. -- Regards, Torfinn Ingolfsen ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: PR's not being picked up (Was Re: becoming a port committor)
On Mon, Nov 22, 2010 at 07:58:56PM +0100, Torfinn Ingolfsen wrote: On Mon, Nov 22, 2010 at 2:19 PM, RW rwmailli...@googlemail.com wrote: Actually it does discuss the wording of the synopsis for both new and updated ports which gives the impression that that that section covers both. Furthermore the update chapter is at the opposite end of the index under the single misleading word Upgrading. There's no mention of submitting which is what people will be looking for. IMO chapter 10 should either be 3.7 or be merged into 3.6. If anything deserves to be under Quick Porting it's this. So then we will see your PR for an update of that chapter in the Porter's Handbook in the next few days perhaps? The trouble is that even when people do read handbooks from beginning to end there are always sections that that they are likely to skip until they need them, and this is one of them. The Porter's Handbook is not going to be improved unless the people who read it and have ideas for improvement do something about it. HTH, HAND. -- Regards, Torfinn Ingolfsen I'm not a porter, but how about the below...? HTH -greg --- begin diff --- --- porting-submitting.html 2007-09-11 01:11:07.0 +0200 +++ porting-submitting.html 2010-11-22 20:14:54.0 +0100 @@ -69,6 +69,14 @@ /blockquote /div +div class=NOTE +blockquote class=NOTE +pbNote2:/b The instructions above are for creating a i class=EMPHASISnew/i +port. Port i class=EMPHASISupdates/i should be diff files instead of shar files, +as described in a href=port-upgrading.htmlUpgrading/a./p +/blockquote +/div + pOne more time, span class=emphasisi class=EMPHASISdo not include the original source distfile, the tt class=FILENAMEwork/tt directory, or the package you built with tt class=COMMANDmake package/tt/i/span./p --- end diff --- -- greg byshenk - gbysh...@byshenk.net - Leiden, NL ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: PR's not being picked up (Was Re: becoming a port committor)
On Mon 22 Nov 2010 at 11:28:36 PST Greg Byshenk wrote: I'm not a porter, but how about the below...? HTH -greg --- begin diff --- --- porting-submitting.html 2007-09-11 01:11:07.0 +0200 +++ porting-submitting.html 2010-11-22 20:14:54.0 +0100 @@ -69,6 +69,14 @@ /blockquote /div +div class=NOTE +blockquote class=NOTE +pbNote2:/b The instructions above are for creating a i class=EMPHASISnew/i +port. Port i class=EMPHASISupdates/i should be diff files instead of shar files, +as described in a href=port-upgrading.htmlUpgrading/a./p +/blockquote +/div + pOne more time, span class=emphasisi class=EMPHASISdo not include the original source distfile, the tt class=FILENAMEwork/tt directory, or the package you built with tt class=COMMANDmake package/tt/i/span./p --- end diff --- While we're at it, remove any mention of port updates from the existing note: --- begin diff --- --- porting-submitting.html.orig2010-11-22 14:01:35.0 -0800 +++ porting-submitting.html 2010-11-22 14:02:09.0 -0800 @@ -66,9 +66,8 @@ blockquote class=NOTE pbNote:/b You can make our work a lot easier, if you use a good description in the synopsis of the problem report. We prefer something like ``New port: -lt;categorygt;/lt;portnamegt; lt;short description of the portgt;'' for new ports -and ``Update port: lt;categorygt;/lt;portnamegt; lt;short description of the -updategt;'' for port updates. If you stick to this scheme, the chance that someone will +lt;categorygt;/lt;portnamegt; lt;short description of the portgt;'' for new ports. +If you stick to this scheme, the chance that someone will take a look at your PR soon is much better./p /blockquote /div --- end diff --- I'm not sure, but I suspect that this note has been the source of the confusion. ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: PR's not being picked up (Was Re: becoming a port committor)
On Mon, 22 Nov 2010 19:58:56 +0100 Torfinn Ingolfsen tin...@gmail.com wrote: On Mon, Nov 22, 2010 at 2:19 PM, RW rwmailli...@googlemail.com wrote: IMO chapter 10 should either be 3.7 or be merged into 3.6. If anything deserves to be under Quick Porting it's this. So then we will see your PR for an update of that chapter in the Porter's Handbook in the next few days perhaps? If someone that's never submitted a document patch before, submits one that involves moving a chapter in the porter's handbook, what are the chances of its being committed? It doesn't matter to me whether it gets updated or not, I don't have to to deal with the shar files. I'm simply dispelling the myth that's it's clearly documented. ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: PR's not being picked up (Was Re: becoming a port committor)
On Monday 22 November 2010 13:15:18 RW wrote: On Mon, 22 Nov 2010 19:58:56 +0100 Torfinn Ingolfsen tin...@gmail.com wrote: On Mon, Nov 22, 2010 at 2:19 PM, RW rwmailli...@googlemail.com wrote: If someone that's never submitted a document patch before, submits one that involves moving a chapter in the porter's handbook, what are the chances of its being committed? As long as what's proposed is accurate, well written and follows the general tone of the handbook (formatting style), the chances are very good. The docs team is always looking for contributors. Beech -- --- Beech Rintoul - FreeBSD Developer - be...@freebsd.org /\ ASCII Ribbon Campaign | FreeBSD Since 4.x \ / - NO HTML/RTF in e-mail | http://people.freebsd.org/~beech X - NO Word docs in e-mail | Skype: akbeech / \ - http://www.FreeBSD.org/releases/8.0R/announce.html --- signature.asc Description: This is a digitally signed message part.
Re: PR's not being picked up (Was Re: becoming a port committor)
I put together this patch. I hope this is sufficient. Thanks! Jason On Mon, Nov 22, 2010 at 07:58:56PM +0100, Torfinn Ingolfsen thus spake: Hi, On Mon, Nov 22, 2010 at 2:19 PM, RW rwmailli...@googlemail.com wrote: Actually it does discuss the wording of the synopsis for both new and updated ports which gives the impression that that that section covers both. Furthermore the update chapter is at the opposite end of the index under the single misleading word Upgrading. There's no mention of submitting which is what people will be looking for. IMO chapter 10 should either be 3.7 or be merged into 3.6. If anything deserves to be under Quick Porting it's this. So then we will see your PR for an update of that chapter in the Porter's Handbook in the next few days perhaps? The trouble is that even when people do read handbooks from beginning to end there are always sections that that they are likely to skip until they need them, and this is one of them. The Porter's Handbook is not going to be improved unless the people who read it and have ideas for improvement do something about it. HTH, HAND. -- Regards, Torfinn Ingolfsen ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org --- porters-handbook/book.sgml 2010-11-22 18:56:43.0 -0800 +++ porters-handbook/book.sgml.my 2010-11-22 19:34:25.0 -0800 @@ -412,6 +412,22 @@ url=http://www.FreeBSD.org/cgi/query-pr-summary.cgi?category=ports;ports waiting to be committed to os;/ulink./para + paraIf you are contributing a patch for a port, please emphasisdo not/emphasis + submit a shar. The recommeded way for submission of a patch is by using a utility + called command/usr/bin/diff/command which is included as part of the base os; + distribution. To create a suitable commanddiff/command, copy the file that + needs patching to replaceablesomething.orig/replaceable. Save your changes to + replaceablesomething/replaceable and then create your patch./para + + informalexample + screenprompt.user; userinput/usr/bin/diff something.orig something somthing.diff + /userinput/screen + /informalexample + + paraPlease see the aforementioned step for submission of replaceablesomething.diff + /replaceable to os; for consideration by using the man.send-pr.1; program. + /para + paraOnce we have looked at your port, we will get back to you if necessary, and put it in the tree. Your name will also appear in the list of ulink url=url.articles.contributors;/contrib-additional.htmlAdditional FreeBSD Contributors/ulink ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: PR's not being picked up (Was Re: becoming a port committor)
On Mon, Nov 22, 2010 at 11:08 PM, Charlie Kester corky1...@comcast.netwrote: On Mon 22 Nov 2010 at 11:28:36 PST Greg Byshenk wrote: I'm not a porter, but how about the below...? HTH -greg --- begin diff --- --- porting-submitting.html 2007-09-11 01:11:07.0 +0200 +++ porting-submitting.html 2010-11-22 20:14:54.0 +0100 @@ -69,6 +69,14 @@ /blockquote /div +div class=NOTE +blockquote class=NOTE +pbNote2:/b The instructions above are for creating a i class=EMPHASISnew/i +port. Port i class=EMPHASISupdates/i should be diff files instead of shar files, +as described in a href=port-upgrading.htmlUpgrading/a./p +/blockquote +/div + pOne more time, span class=emphasisi class=EMPHASISdo not include the original source distfile, the tt class=FILENAMEwork/tt directory, or the package you built with tt class=COMMANDmake package/tt/i/span./p --- end diff --- While we're at it, remove any mention of port updates from the existing note: --- begin diff --- --- porting-submitting.html.orig2010-11-22 14:01:35.0 -0800 +++ porting-submitting.html 2010-11-22 14:02:09.0 -0800 @@ -66,9 +66,8 @@ blockquote class=NOTE pbNote:/b You can make our work a lot easier, if you use a good description in the synopsis of the problem report. We prefer something like ``New port: -lt;categorygt;/lt;portnamegt; lt;short description of the portgt;'' for new ports -and ``Update port: lt;categorygt;/lt;portnamegt; lt;short description of the -updategt;'' for port updates. If you stick to this scheme, the chance that someone will +lt;categorygt;/lt;portnamegt; lt;short description of the portgt;'' for new ports. +If you stick to this scheme, the chance that someone will take a look at your PR soon is much better./p /blockquote /div --- end diff --- The two examples just posted are in HTML. I'm pretty sure that the documentation source isn't HTML. -- Regards, Torfinn Ingolfsen ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: becoming a port committor
On 11/20/2010 11:57 PM, Beech Rintoul wrote: Contribute approx. 50 pr's with patches that are consistently coded and prove to work (and in the right format) no shar files please. Does the Porter's Handbook need to be updated then? It explicitly says to use shar files to send ports in section 3.6, or where you referring specifically to patches and not full ports? http://www.freebsd.org/doc/en/books/porters-handbook/porting-submitting.html Jonathan ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: becoming a port committor
Hi, On Sun, Nov 21, 2010 at 7:49 PM, Jonathan jonat...@kc8onw.net wrote: On 11/20/2010 11:57 PM, Beech Rintoul wrote: Contribute approx. 50 pr's with patches that are consistently coded and prove to work (and in the right format) no shar files please. Does the Porter's Handbook need to be updated then? It explicitly says to use shar files to send ports in section 3.6, or where you referring specifically to patches and not full ports? That is my understanding at least: shar for new ports diffs for patches and updates to existing ports. HTH -- Regards, Torfinn Ingolfsen ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: becoming a port committor
On Sunday 21 November 2010 15:12:08 Torfinn Ingolfsen wrote: Hi, On Sun, Nov 21, 2010 at 7:49 PM, Jonathan jonat...@kc8onw.net wrote: On 11/20/2010 11:57 PM, Beech Rintoul wrote: Contribute approx. 50 pr's with patches that are consistently coded and prove to work (and in the right format) no shar files please. Does the Porter's Handbook need to be updated then? It explicitly says to use shar files to send ports in section 3.6, or where you referring specifically to patches and not full ports? That is my understanding at least: shar for new ports diffs for patches and updates to existing ports. HTH That is correct, although it is possible to use a unified diff with the -N flag against a non existent source. The problem is too many contributors send in update pr's in shar format which are a real PITA to deal with from our end. You may notice that many pr's aren't picked up by committers for just that reason. In the above I was referring to updates, not new ports. Beech -- --- Beech Rintoul - FreeBSD Developer - be...@freebsd.org /\ ASCII Ribbon Campaign | FreeBSD Since 4.x \ / - NO HTML/RTF in e-mail | http://people.freebsd.org/~beech X - NO Word docs in e-mail | Skype: akbeech / \ - http://www.FreeBSD.org/releases/8.0R/announce.html --- ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
PR's not being picked up (Was Re: becoming a port committor)
On Sun 21 Nov 2010 at 20:09:23 PST Beech Rintoul wrote: That is correct, although it is possible to use a unified diff with the -N flag against a non existent source. The problem is too many contributors send in update pr's in shar format which are a real PITA to deal with from our end. You may notice that many pr's aren't picked up by committers for just that reason. In such cases, does the submitter receive any communication explaining the reasons his PR isn't getting worked on? E.g., why not send an email requesting resubmission in the proper format? Many of the of oldest unassigned but still-open PR's show no evidence that they've even been looked at by a committer. There are no entries beyond the original one. How can we know which PR's were rejected/not picked up for some reason and which ones were genuinely overlooked? ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: PR's not being picked up (Was Re: becoming a port committor)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/21/2010 10:26 PM, Charlie Kester wrote: On Sun 21 Nov 2010 at 20:09:23 PST Beech Rintoul wrote: That is correct, although it is possible to use a unified diff with the -N flag against a non existent source. The problem is too many contributors send in update pr's in shar format which are a real PITA to deal with from our end. You may notice that many pr's aren't picked up by committers for just that reason. Almost anyone who is an only semi-serious port maintainer (meaning they only have a select few number of ports to maintain and are only trying to contribute/participate) knows that maybe this issue is due to the porter's handbook. Specifically http://www.freebsd.org/doc/en/books/porters-handbook/porting-submitting.html which blatantly states that all submissions whether they are new OR updates be submitted in shar format. Maybe the commiters should bring this up and have a few less to deal with..? Just a suggestion. Regards, Janky Jay, III -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkzqBzgACgkQGK3MsUbJZn5X/gCfbTgIyt4KEyI6ebtYmjm/DUk5 L2AAn28d2RCorQB4lm3KBGIqp9MHTxWZ =azIy -END PGP SIGNATURE- ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: PR's not being picked up (Was Re: becoming a port committor)
Janky Jay, III jan...@unfs.us writes: On 11/21/2010 10:26 PM, Charlie Kester wrote: On Sun 21 Nov 2010 at 20:09:23 PST Beech Rintoul wrote: That is correct, although it is possible to use a unified diff with the -N flag against a non existent source. The problem is too many contributors send in update pr's in shar format which are a real PITA to deal with from our end. You may notice that many pr's aren't picked up by committers for just that reason. Almost anyone who is an only semi-serious port maintainer (meaning they only have a select few number of ports to maintain and are only trying to contribute/participate) knows that maybe this issue is due to the porter's handbook. Specifically http://www.freebsd.org/doc/en/books/porters-handbook/porting-submitting.html which blatantly states that all submissions whether they are new OR updates be submitted in shar format. Maybe the commiters should bring this up and have a few less to deal with..? Just a suggestion. It's because you're looking at the wrong chapter. That one is about new ports, not updates/bugfixes/changes. http://www.freebsd.org/doc/en/books/porters-handbook/port-upgrading.html ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: PR's not being picked up (Was Re: becoming a port committor)
On Sun 21 Nov 2010 at 22:01:28 PST Janky Jay, III wrote: Almost anyone who is an only semi-serious port maintainer (meaning they only have a select few number of ports to maintain and are only trying to contribute/participate) knows that maybe this issue is due to the porter's handbook. Specifically http://www.freebsd.org/doc/en/books/porters-handbook/porting-submitting.html which blatantly states that all submissions whether they are new OR updates be submitted in shar format. Maybe the commiters should bring this up and have a few less to deal with..? Just a suggestion. That page doesn't say what you think it says. Its context is the creation of a new port. It doesn't say anything about updating an existing port. Perhaps the problem is that some people never read the *rest* of the handbook? If they would, they'd find this page, which explicitly says to use 'diff -ruN': http://www.freebsd.org/doc/en/books/porters-handbook/port-upgrading.html ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
becoming a port committor
I have a lot of free time now that I am retired. I see a large number of ports in open status that have been waiting to be committed longer than 30 days. What is the procedure to become a ports committor? ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: becoming a port committor
Fbsd8 fb...@a1poweruser.com writes: I have a lot of free time now that I am retired. I see a large number of ports in open status that have been waiting to be committed longer than 30 days. What is the procedure to become a ports committor? Excuse me, please. Are you like FreeBSD? -- 소여물 황병희(黃炳熙) | .. 출항 15분전.. You know who I am? -- Vito Corleone, Chapter 1, page 52 pgp61tArgBATS.pgp Description: PGP signature
Re: becoming a port committor
On Sat, Nov 20, 2010 at 4:41 PM, Fbsd8 fb...@a1poweruser.com wrote: I have a lot of free time now that I am retired. I see a large number of ports in open status that have been waiting to be committed longer than 30 days. What is the procedure to become a ports committor? ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org I suggest you use this page as a starting point http://www.freebsd.org/projects/index.html and especially this page regarding the Ports Collection http://www.freebsd.org/doc/en_US.ISO8859-1/articles/contributing-ports/article.html -- Bästa hälsningar Oskar Holmlund Professorsvägen 33 977 51 Luleå Sweden +46(0)70-3220292 http://www.ohdata.se ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: becoming a port committor
On 20 November 2010 15:41, Fbsd8 fb...@a1poweruser.com wrote: I have a lot of free time now that I am retired. I see a large number of ports in open status that have been waiting to be committed longer than 30 days. What is the procedure to become a ports committor? I explained in detail why your port hasn't been committed since June a couple of hours ago; http://www.freebsd.org/cgi/query-pr.cgi?pr=148777 Procedure: http://unix.derkeiler.com/Newsgroups/comp.unix.bsd.freebsd.misc/2007-11/msg00174.html You have to have a proven track record of sending _good_ code; they don't want people committing unless they know exactly what to do! This takes time and practice. You also have to have a record of answering questions well in the lists. Chris ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: becoming a port committor
On Sat, Nov 20, 2010 at 9:57 PM, Byung-Hee HWANG b...@izb.knu.ac.kr wrote: Fbsd8 fb...@a1poweruser.com writes: I have a lot of free time now that I am retired. I see a large number of ports in open status that have been waiting to be committed longer than 30 days. What is the procedure to become a ports committor? Excuse me, please. Are you like FreeBSD? Excuse me, but I fail to understand your question ? did u mean to ask OP do you like FreeBSD ? -- 소여물 황병희(黃炳熙) | .. 출항 15분전.. You know who I am? -- Vito Corleone, Chapter 1, page 52 ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: becoming a port committor
I have a lot of free time now that I am retired. I see a large number of ports in open status that have been waiting to be committed longer than 30 days. What is the procedure to become a ports committor? Normally you would become active in the ports project, submitting ports and patches, etc. Then after some unspecified amount of time (hopefully) an existing committer will nominate you for a 'commit bit', portmgr@ has to approve that. You then you work as a committer, but with a mentor approving your work, eventually ending up committing things by yourself. I've also been advised that joining #bsdports on EFnet and making yourself known will help! Regards Eric ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: becoming a port committor
On Saturday 20 November 2010 06:41:01 Fbsd8 wrote: I have a lot of free time now that I am retired. I see a large number of ports in open status that have been waiting to be committed longer than 30 days. A lot of these ports or the associated patches have problems or are in the wrong format. As for new ports, not all get committed for various reasons. Feel free to correct any problems and resubmit. Read the FreeBSD Porter's Handbook and Contributing to the FreeBSD Ports Collection. http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/ http://www.freebsd.org/doc/en_US.ISO8859-1/articles/contributing- ports/index.html What is the procedure to become a ports committor? There is no hard and fast procedure. You must be invited, approved by portmgr@ and undergo a period of mentorship. If approved, your mentor will decide when you're ready to commit on your own. Here are some guidelines: Contribute approx. 50 pr's with patches that are consistently coded and prove to work (and in the right format) no shar files please. Make your presence known on #bsdports and answer questions correctly. Have the ability to take (and act on) constructive criticism from senior maintainers, committors and portmgr. Understand and follow FreeBSD guidelines and procedures. Above all, be an asset and get along well with others in the project. If you do all of this you will be noticed and a mentor will likely contact you. Good Luck, Beech -- --- Beech Rintoul - FreeBSD Developer - be...@freebsd.org /\ ASCII Ribbon Campaign | FreeBSD Since 4.x \ / - NO HTML/RTF in e-mail | http://people.freebsd.org/~beech X - NO Word docs in e-mail | Skype: akbeech / \ - http://www.FreeBSD.org/releases/8.0R/announce.html --- signature.asc Description: This is a digitally signed message part.
Re: becoming a port committor
Masoom, Masoom Shaikh masoom.sha...@gmail.com writes: On Sat, Nov 20, 2010 at 9:57 PM, Byung-Hee HWANG b...@izb.knu.ac.kr wrote: Fbsd8 fb...@a1poweruser.com writes: I have a lot of free time now that I am retired. I see a large number of ports in open status that have been waiting to be committed longer than 30 days. What is the procedure to become a ports committor? Excuse me, please. Are you like FreeBSD? Excuse me, but I fail to understand your question ? did u mean to ask OP do you like FreeBSD ? I was wrong in English, sorry about that. As you mentioned above, that's correct as follow: Do you like FreeBSD ;; For OP (Fbsd8), i would like to say that a man who don't like FreeBSD can never be a real FreeBSD developer (committer). Well, i think liking FreeBSD is important, first of all. Sincerely, -- 소여물 황병희(黃炳熙) | .. 출항 15분전.. It's supposed to be so terrible that even my father won't talk about it. -- Michael Corleone, Chapter 1, page 24 pgpXivM5nd0hR.pgp Description: PGP signature
